Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make crowdsale constructors public #1562

Closed
frangio opened this issue Dec 18, 2018 · 0 comments
Closed

Make crowdsale constructors public #1562

frangio opened this issue Dec 18, 2018 · 0 comments
Labels
contracts Smart contract code.
Milestone
v2.1

Comments

@frangio
Copy link
Contributor

frangio commented Dec 18, 2018

In #1439 the crowdsale constructors were made internal, but this was a mistake because even though they will generally be extended it's possible to deploy the contracts as-is, which is specially useful for quick tests.

The constructoirs should be public to allow both scenarios.

This is not a breaking change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contracts Smart contract code.
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
1 participant
@frangio