Compatability with neon plugins

[NeonBohdan]

Ovos and Neon tts plugins has a bit different function signature
https://github.com/OpenVoiceOS/ovos-tts-server/blob/ceef8aacce4bf58b949573083c7686220f150c5e/ovos_tts_server/__init__.py#L38

Neon speaker dict has language, gender, voice params

def get_tts(self, sentence: str, output_file: str, speaker: Optional[dict] = None):
    speaker: dict speaker to initialize a model for with keys:
                `language` - language code
                `gender` - optional synthesizer gender requested
                `voice` - optional synthesizer voice requested

Not sure how to better make them compatible

[JarbasAl]

That should be handled in ovos plugin manager, inside execute method it should check the kwargs and pass the valid ones, it already checks things like language etc missing in mycroft plugins, so a check can be added for the neon dict

[NeonDaniel]

For the TTS server, could it parse gender and optionally pass all 3? I think it's useful to map lang/gender to a voice per-plugin so calls are more universal (voices are plugin-specific, but lang+gender is mostly universal).

Also, here's how I patched compatibility in neon_audio: https://github.com/NeonGeckoCom/neon_audio/blob/423fb9a592b78163460d7e386e53bfcb8872d68d/neon_audio/tts/neon.py#L164

[JarbasAl]

the server just load OPM, so im transfering this issue over, we can support any args needed no problem

[JarbasAl]

relevant code https://github.com/OpenVoiceOS/OVOS-plugin-manager/blob/dev/ovos_plugin_manager/templates/tts.py#L685

this is happening inside the call to execute maybe we should make the _synth method public and use that in the ovos-tts-server?