Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package with "name" and "version" of non-ASCII characters will have a filename "-.tar.gz" #18

Open
TrueBrain opened this issue Apr 20, 2020 · 1 comment
Open

Package with "name" and "version" of non-ASCII characters will have a filename "-.tar.gz" #18

TrueBrain opened this issue Apr 20, 2020 · 1 comment
Labels
bug Something isn't working prio: low This issue should be fixed, but we could do without

Comments

@TrueBrain
Copy link
Member

Package with "name" and "version" of non-ASCII characters will have a filename "-.tar.gz".

This is because _safe_name() removes any non-ASCII (well, give or take).

We should refuse these uploads, as this is most likely not what the uploaded intended.
@TrueBrain TrueBrain added prio: low This issue should be fixed, but we could do without bug Something isn't working labels Apr 21, 2020
@frosch123
Copy link
Member

I guess with #56 solved, this comes down to an extention of the "unique version" check:
Versions within a package should be non-empty and unique, after they passed through safe_filename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working prio: low This issue should be fixed, but we could do without
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TrueBrain @frosch123