Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend CML path ploting function for SMLs which have different location metadata #26

Open
Tracked by #1
cchwala opened this issue Feb 21, 2024 · 3 comments
Open
Tracked by #1
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers visualization

Comments

@cchwala
Copy link
Member

cchwala commented Feb 21, 2024

The CML path plotting function could easily be used for SML data if we calculate the second site coordinates for SMLs on the fly based on a assumed length. Note that for SMLs only one site is defined and the direction of the SML path to the satellite is then defined.

For a simple first implementation we could assume a fixed melting layer height and use this for calculating the "effective" length which we then use to calculate the coordinates of the second end of the line. We could e.g. also use dashed lines for SMLs to distinguish them from CML paths.

Updated: Even better than dashed lines for SMLs would be to add a marker to the SML line at the end which is on the ground.

@cchwala cchwala added the enhancement New feature or request label Feb 21, 2024
@cchwala cchwala added the good first issue Good for newcomers label Mar 18, 2024
@cchwala
Copy link
Member Author

cchwala commented Mar 18, 2024

This could easily be added as a variation of the plot_cmls function in the xarray Accessor that is currently being developed in #29.

@maxmargraf
Copy link
Contributor

Input from the SML datasets available within OpenSense typically have the following coordinates: lon and lat of the base station and the azimuth and elevation of the antenna. To plot the line of a SML one has to compute the point on the ground below the point where the microwave beam crosses the melting layer. This point can be calculated from the given coordinates.
I propose to add a new function in plot_map that returns the projected line on the ground. This line then can be used directly by the plot_cmls function. We might want to rename this to plot_lines and in turn rename the recent plot_lines to something more CML specific like plot_cml.

@cchwala
Copy link
Member Author

cchwala commented Jul 3, 2024

We have some example SML data where the ground site lon-lat is given and antenna elevation and azimuth are given. From that we can easily calculate the lon-lat where the SML path intersects the melting layer (at a defined height above ground). The code in this answer on stackoverflow seems to do exactly that.

I am not sure what our decision regarding naming convention of SML coordinates were. We could adjust the current convention for SMLs to use site_0_lon, site_0_lat, antenna_elevation and antenna_azimut instead of having a site_1_lon that is defined by the easting of the geostationary satellite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers visualization
Projects
No open projects
Development

No branches or pull requests

2 participants