Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support openai lib: 4.15.3 #335

Closed
caoer opened this issue Nov 5, 2023 · 4 comments · Fixed by #336 or #340
Closed

support openai lib: 4.15.3 #335

caoer opened this issue Nov 5, 2023 · 4 comments · Fixed by #336 or #340

Comments

@caoer
Copy link

caoer commented Nov 5, 2023

the code here only works for 4.8.0: https://github.com/OpenPipe/OpenPipe/blob/main/client-libs/typescript/src/openai/streaming.ts#L13

in the latest version, current(4.15.3): it is here: https://github.com/openai/openai-node/blob/e0138e8a5939f6fe53639df78cd541e4e20927ed/src/streaming.ts#L21C24-L21C24

related PR: openai/openai-node#370
The problem is that current OpenPipe's OpenAI lib does not work for streaming API due to refactoring of the PR above.

can we update to support latest code?

@arcticfly @corbt

@corbt
Copy link
Collaborator

corbt commented Nov 6, 2023

Yep this makes sense. Feel free to open a PR, if not we'll definitely get to this as soon as we can!

@arcticfly
Copy link
Collaborator

Reopening to fix the streaming bug in particular.

@arcticfly
Copy link
Collaborator

@caoer Thanks for pointing this out. Should be fixed in #340.

Could you try out version 0.6.2 and see if you get the same error?

@caoer
Copy link
Author

caoer commented Nov 10, 2023

Thanks @arcticfly and @corbt !
I've tested, it is working OK now.

    "openai": "4.17.3",
    "openpipe": "0.6.2",

@caoer caoer closed this as completed Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants