-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to NeuroBagel search #2956
Comments
Thanks @effigies! I think the description should also include something on "participant-level" search to make it clear that you can find a cohort of participants that match, not just the datasets. How about
for the search link. For the neurobagel description I would also add this like so:
@alyssadai and @rmanaem, anything I missed? |
The revised description is looking good! I would just correct the capitalization of "NeuroBagel" to "Neurobagel". Also, to differentiate what Neurobagel does from any kind of statistical harmonization (which might be the default interpretation for folks in the neuroimaging community), I suggest the following edit:
|
@alyssadai LGTM. Thanks for the suggestion! |
Hey folks, @effigies mentioned that you'd be open to a PR from us to add this link. We looked through the codebase and came up with two options that I think we can implement (mostly) with existing components. Because the "You can search at the participant level" link is not part of the search parameters container, I think it fits more on the search side of the UI. Let us know if you agree with the overall positioning. Option 1 - text link with accordion componentI think we could reuse the accordion-wrapper component together with a plain text link. The little Option 2 - dropdown with context information insideWe could also reuse the dropdown component and when a user clicks on it they would see the context and link - similar to how the "Clone dataset" workflow works on the dataset page. Let us know what you think / prefer. I think we could find some time this or next week to make a draft PR after that. |
Of these two, I prefer option 1. |
Sounds good @effigies, we'll prepare a PR in that case and then can discuss the rest there. |
What would you like to see added?
As mentioned in #2807 (comment), we can link to https://query.neurobagel.org/?node=OpenNeuro. "Annotated search" seems like a good name to indicate that this search is benefiting from third-party annotations. We could use the following text as an expansion:
Alternatives
Do you have any interest in helping implement the feature?
Yes, but I would need guidance
Additional information / screenshots
No response
The text was updated successfully, but these errors were encountered: