Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about testing results #49

Open
weleen opened this issue Oct 4, 2023 · 6 comments
Open

Questions about testing results #49

weleen opened this issue Oct 4, 2023 · 6 comments

Comments

@weleen
Copy link

weleen commented Oct 4, 2023

Thank you for your great job! I have tried to reproduce the results and encountered some issues.

Following instructions, I evaluate the provided checkpoint downloaded from huggingface.

I run the following commands:

python -m test --cfg configs/config_h3d_stage3.yaml --task t2m
python -m test --cfg configs/config_h3d_stage3.yaml --task m2t

The evaluation results are not consistent with the results reported in the paper. The attachments are the log and metrics.

t2m results:
image
log_2023-10-04-19-56-23_test.log
image

Would you happen to have any idea about what's wrong with the configuration?

@weleen
Copy link
Author

weleen commented Oct 5, 2023

About m2t task, the testing process is stuck at the 4th replication since the SIGTERM signal.
image

Similar to t2m, the testing result is behind the results reported in the paper. Especially Bleu@4 and CIDEr, only around 6 and 7.
image

I would appreciate it if you have time to help fix my issue.😄

@LinghaoChan
Copy link

@weleen hi! Has this issue been resolved? We met the same issue.

@weleen
Copy link
Author

weleen commented Nov 11, 2023

@weleen hi! Has this issue been resolved? We met the same issue.

@LinghaoChan I think there are some mistakes in get_motion_embeddings.

In m2t.py

m_lens = torch.div(m_lens,
self.cfg.DATASET.HUMANML3D.UNIT_LEN,
rounding_mode="floor")
ref_mov = self.t2m_moveencoder(feats_ref[..., :-4]).detach()
m_lens = m_lens // self.unit_length

In t2m.py

m_lens = torch.div(m_lens,
self.cfg.DATASET.HUMANML3D.UNIT_LEN,
rounding_mode="floor")
m_lens = m_lens // self.cfg.DATASET.HUMANML3D.UNIT_LEN

m_lens are divided two times.

However, even I fix these errors, the results are still different. Have you solved this issus?

@Spark001
Copy link

same issue

@GuangtaoLyu
Copy link

@weleen hi! Has this issue been resolved? We met the same issue.

hi, me too.

@shin-wn
Copy link

shin-wn commented Feb 19, 2025

me too.
Furthermore, I cant reproduce the real score of m2t on this MotionGPT paper and MotionGPT-2 paper.
In these papers, R-Precision, MM Dist. are following:

Image

However, when I run test.py in this repository, the R-precision and MM dist deviate by 0.2 points and 0.07 points, respectively.
Image

I consider this to be a very problematic deviation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants