From 879caab7a16eb335497b335725498b67da6c0a58 Mon Sep 17 00:00:00 2001 From: Mohamed ELIDRISSI <67818913+elidrissidev@users.noreply.github.com> Date: Sun, 27 Nov 2022 17:38:37 +0100 Subject: [PATCH 1/3] Fixed order comment REST endpoint route param (#2750) --- app/code/core/Mage/Sales/Model/Api2/Order/Comment/Rest.php | 2 +- app/code/core/Mage/Sales/etc/api2.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/code/core/Mage/Sales/Model/Api2/Order/Comment/Rest.php b/app/code/core/Mage/Sales/Model/Api2/Order/Comment/Rest.php index 8f7d3a4c0ab4..836c6143152c 100644 --- a/app/code/core/Mage/Sales/Model/Api2/Order/Comment/Rest.php +++ b/app/code/core/Mage/Sales/Model/Api2/Order/Comment/Rest.php @@ -32,7 +32,7 @@ abstract class Mage_Sales_Model_Api2_Order_Comment_Rest extends Mage_Sales_Model * Parameters in request used in model (usually specified in route mask) */ public const PARAM_ORDER_ID = 'id'; - public const PARAM_COMMENT_ID = 'comment_id'; + public const PARAM_COMMENT_ID = 'id'; /**#@-*/ /** diff --git a/app/code/core/Mage/Sales/etc/api2.xml b/app/code/core/Mage/Sales/etc/api2.xml index a068bd807cc6..258f5039a9b8 100644 --- a/app/code/core/Mage/Sales/etc/api2.xml +++ b/app/code/core/Mage/Sales/etc/api2.xml @@ -325,7 +325,7 @@ - /orders/comments/:comment_id + /orders/comments/:id entity From 1f65685a40c7eaf42bfc7eebafc212f3f51f146c Mon Sep 17 00:00:00 2001 From: sv3n Date: Tue, 29 Nov 2022 07:31:49 +0100 Subject: [PATCH 2/3] Moved file (#2764) --- dev/ddev/README.md => docs/DDEV.md | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename dev/ddev/README.md => docs/DDEV.md (100%) diff --git a/dev/ddev/README.md b/docs/DDEV.md similarity index 100% rename from dev/ddev/README.md rename to docs/DDEV.md From 7fe65add911ee9adc0d39eb93d7ca840a163d213 Mon Sep 17 00:00:00 2001 From: sv3n Date: Tue, 29 Nov 2022 07:33:47 +0100 Subject: [PATCH 3/3] Add php-cs-fixer & PHPCompatibility check to workflow (#2744) * PHP-CS-Fixer fixes Signed-off-by: Sven Reichel * Updated workflow Signed-off-by: Sven Reichel * Added php-cs-fixer workflow Signed-off-by: Sven Reichel * Added PHPCompatibility check * PHPCompatibility check can fail * Fixes: Node.js 12 actions are deprecated * Fixes: PSR12.ControlStructures.ControlStructureSpacing.LineIndent * Fixes: PSR12.ControlStructures.ControlStructureSpacing.CloseParenthesisLine * Dond check CM_Redis every time * Add .php-cs-fixer.cache to .gitignore * Fixes class name (wrong place ... i know) * Minor fixes * Combined workflows * Added app/Mage.php and files from root to rulesets * Remove unused phpstan_experimental_level.neon * Updated phpstan.neon (for upcoming commits) * Set PhpStan level to 5 (from 3) * Update phpstan to v1.9.2 * Updated phpstan-baseline.neon * Updated phpstan-baseline.neon * Update app/code/core/Mage/Tag/Model/Resource/Tag.php Co-authored-by: Ng Kiat Siong * Update lib/Varien/Db/Adapter/Pdo/Mysql.php Co-authored-by: Ng Kiat Siong * Set workflow include paths (skip other files) * Updated labeler.yml * Removed travis label * Improved workflow (#26) * Fixed grep modifier to get correct count * Updated ECG sniff baseline * Added Mage_Centinal to PhpStan checks * Added Mage_PaypalUk to PhpStan checks * Update app/code/core/Mage/Paypal/Model/Config.php Co-authored-by: Ng Kiat Siong Signed-off-by: Sven Reichel Co-authored-by: Ng Kiat Siong --- .github/labeler.yml | 23 +- .github/php-cs-fixer-ruleset.php | 106 + .github/phpcs-ruleset-ecg.xml | 177 + .github/phpcs-ruleset-php.xml | 20 + .github/phpcs-ruleset.xml | 57 +- .github/phpstan-baseline.neon | 14408 +++++++++++++--- .github/phpstan.neon | 40 +- .github/phpstan_experimental_level.neon | 9 - .github/workflows/check-files.yml | 106 + .github/workflows/composer.yml | 29 + .github/workflows/labeler.yml | 3 +- .github/workflows/php-cs-fixer.yml | 32 + .github/workflows/phpcs.yml | 41 +- .github/workflows/phpstan.yml | 41 +- .github/workflows/phpunit.yml | 13 +- .github/workflows/security-php.yml | 4 +- .github/workflows/sonar.yml | 14 +- .github/workflows/syntax-php.yml | 17 +- .github/workflows/syntax-xml.yml | 16 +- .github/workflows/workflow.yml | 80 + .gitignore | 3 + api.php | 4 +- app/Mage.php | 91 +- .../Adminhtml/Block/Api/Tab/Rolesedit.php | 3 +- .../Adminhtml/Block/Catalog/Category/Tree.php | 3 +- .../Form/Renderer/Fieldset/Element.php | 3 +- .../Product/Edit/Tab/Options/Option.php | 3 +- .../Catalog/Product/Helper/Form/Gallery.php | 3 +- .../Mage/Adminhtml/Block/Customer/Edit.php | 3 +- .../Block/Permissions/Tab/Rolesedit.php | 9 +- .../Block/Promo/Widget/Chooser/Daterange.php | 3 +- .../Block/Sales/Order/Create/Giftmessage.php | 3 +- .../Sales/Order/Create/Giftmessage/Form.php | 3 +- .../Block/Sales/Order/Invoice/View.php | 3 +- .../Mage/Adminhtml/Block/Sales/Order/View.php | 3 +- .../Block/Sales/Transactions/Detail.php | 3 +- .../Config/Form/Field/Array/Abstract.php | 6 +- .../System/Convert/Profile/Edit/Tab/Run.php | 3 +- .../Block/System/Store/Edit/Form.php | 6 +- .../core/Mage/Adminhtml/Block/Widget/Tabs.php | 3 +- .../core/Mage/Adminhtml/Controller/Action.php | 9 +- .../Mage/Adminhtml/Model/Giftmessage/Save.php | 12 +- .../Adminhtml/Model/Sales/Order/Create.php | 7 +- .../Catalog/CategoryController.php | 3 +- .../controllers/Catalog/ProductController.php | 12 +- .../Checkout/AgreementController.php | 2 +- .../controllers/Cms/PageController.php | 3 +- .../Newsletter/QueueController.php | 42 +- .../controllers/Promo/QuoteController.php | 3 +- .../Sales/Order/CreditmemoController.php | 6 +- .../Sales/Order/ShipmentController.php | 6 +- .../controllers/System/ConfigController.php | 3 +- .../Tax/Class/CustomerController.php | 4 +- .../Tax/Class/ProductController.php | 4 +- .../controllers/Tax/RuleController.php | 4 +- app/code/core/Mage/Api/Model/Config.php | 3 +- .../Mage/Api/Model/Server/Adapter/Soap.php | 6 +- .../Api/Model/Server/Handler/Abstract.php | 24 +- .../Api2/Block/Adminhtml/Roles/Buttons.php | 3 +- .../core/Mage/Api2/Model/Acl/Global/Role.php | 3 +- app/code/core/Mage/Api2/Model/Observer.php | 3 +- .../Mage/Authorizenet/Model/Directpost.php | 3 +- .../core/Mage/Backup/Model/Fs/Collection.php | 3 +- .../Adminhtml/Sales/Order/Items/Renderer.php | 3 +- .../Sales/Order/View/Items/Renderer.php | 3 +- .../Bundle/Block/Catalog/Product/Price.php | 3 +- .../Block/Sales/Order/Items/Renderer.php | 3 +- .../Bundle/Model/Resource/Price/Index.php | 6 +- .../Model/Sales/Order/Pdf/Items/Abstract.php | 15 +- .../Product/View/Options/Type/Select.php | 3 +- .../Block/Product/View/Type/Configurable.php | 3 +- app/code/core/Mage/Catalog/Helper/Data.php | 10 +- app/code/core/Mage/Catalog/Helper/Output.php | 6 +- app/code/core/Mage/Catalog/Model/Abstract.php | 3 +- .../core/Mage/Catalog/Model/Api/Resource.php | 3 +- .../Model/Api2/Product/Rest/Admin/V1.php | 3 +- .../Model/Api2/Product/Validator/Product.php | 9 +- .../core/Mage/Catalog/Model/Category/Api.php | 3 +- .../Mage/Catalog/Model/Category/Api/V2.php | 6 +- .../Catalog/Model/Category/Indexer/Flat.php | 79 +- .../Model/Category/Indexer/Product.php | 3 +- app/code/core/Mage/Catalog/Model/Design.php | 6 +- .../core/Mage/Catalog/Model/Product/Api.php | 3 +- .../Catalog/Model/Product/Attribute/Api.php | 3 +- .../Model/Product/Attribute/Media/Api.php | 3 +- .../Model/Product/Attribute/Tierprice/Api.php | 3 +- .../Product/Attribute/Tierprice/Api/V2.php | 3 +- .../Catalog/Model/Product/Flat/Observer.php | 3 +- .../core/Mage/Catalog/Model/Product/Image.php | 4 +- .../Model/Product/Option/Type/File.php | 3 +- .../Catalog/Model/Product/Type/Abstract.php | 3 +- .../Model/Product/Type/Configurable.php | 6 +- .../Catalog/Model/Resource/Category/Flat.php | 3 +- .../Catalog/Model/Resource/Eav/Attribute.php | 3 +- .../Model/Resource/Product/Flat/Indexer.php | 3 +- .../Catalog/Model/Resource/Product/Option.php | 3 +- .../Model/Resource/Product/Option/Value.php | 3 +- .../Model/Resource/Product/Website.php | 6 +- .../core/Mage/Catalog/Model/Resource/Url.php | 3 +- .../core/Mage/CatalogIndex/Model/Indexer.php | 6 +- .../CatalogIndex/Model/Indexer/Abstract.php | 3 +- .../Mage/CatalogInventory/Model/Observer.php | 30 +- .../mysql4-upgrade-0.7.3-0.7.4.php | 3 +- .../core/Mage/CatalogSearch/Block/Layer.php | 3 +- .../Mage/CatalogSearch/Model/Advanced.php | 23 +- .../Model/Resource/Search/Collection.php | 6 +- .../Centinel/Block/Adminhtml/Validation.php | 3 +- app/code/core/Mage/Centinel/Helper/Data.php | 2 +- app/code/core/Mage/Centinel/Model/Config.php | 6 +- .../core/Mage/Centinel/Model/Observer.php | 2 +- app/code/core/Mage/Centinel/Model/Service.php | 18 +- .../core/Mage/Centinel/Model/State/Jcb.php | 18 +- .../Mage/Centinel/Model/State/Mastercard.php | 15 +- .../core/Mage/Centinel/Model/State/Visa.php | 21 +- .../Mage/Centinel/Model/StateAbstract.php | 2 +- .../Centinel/controllers/IndexController.php | 2 +- app/code/core/Mage/Checkout/Block/Cart.php | 3 +- .../Block/Cart/Item/Renderer/Configurable.php | 3 +- .../Block/Cart/Item/Renderer/Grouped.php | 3 +- .../Mage/Checkout/Block/Onepage/Billing.php | 3 +- .../core/Mage/Checkout/Model/Api/Resource.php | 6 +- .../Checkout/Model/Api/Resource/Customer.php | 3 +- .../core/Mage/Checkout/Model/Cart/Api.php | 3 +- .../Checkout/Model/Cart/Product/Api/V2.php | 3 +- .../core/Mage/Checkout/Model/Type/Onepage.php | 6 +- app/code/core/Mage/Cms/Block/Page.php | 3 +- .../Mage/Cms/Model/Wysiwyg/Images/Storage.php | 3 +- .../Helper/Mediafallback.php | 3 +- .../ConfigurableSwatches/Model/Observer.php | 6 +- app/code/core/Mage/Core/Block/Profiler.php | 3 +- .../Mage/Core/Controller/Varien/Action.php | 6 +- .../Controller/Varien/Router/Standard.php | 3 +- app/code/core/Mage/Core/Helper/Data.php | 6 +- app/code/core/Mage/Core/Helper/Security.php | 3 +- app/code/core/Mage/Core/Model/App.php | 9 +- app/code/core/Mage/Core/Model/Locale.php | 2 +- .../Model/Resource/Db/Collection/Abstract.php | 3 +- .../Mage/Core/Model/Resource/Resource.php | 3 +- .../core/Mage/Core/Model/Resource/Session.php | 3 +- .../core/Mage/Core/Model/Resource/Setup.php | 3 +- .../Core/Model/Session/Abstract/Varien.php | 9 +- app/code/core/Mage/Core/Model/Translate.php | 3 +- app/code/core/Mage/Core/Model/Url.php | 3 +- .../Mage/Customer/Model/Address/Abstract.php | 3 +- .../core/Mage/Customer/Model/Api/Resource.php | 3 +- .../Model/Api2/Customer/Address/Rest.php | 3 +- .../Model/Convert/Adapter/Customer.php | 6 +- .../core/Mage/Customer/Model/Customer.php | 3 +- .../core/Mage/Customer/Model/Observer.php | 3 +- .../controllers/AccountController.php | 18 +- .../Dataflow/Model/Convert/Adapter/Io.php | 3 +- .../Dataflow/Model/Convert/Parser/Csv.php | 3 +- app/code/core/Mage/Dataflow/Model/Profile.php | 9 +- .../Mage/Downloadable/Helper/Download.php | 3 +- .../core/Mage/Downloadable/Model/Observer.php | 9 +- app/code/core/Mage/Eav/Model/Config.php | 3 +- .../Mage/Eav/Model/Convert/Adapter/Entity.php | 3 +- .../Mage/Eav/Model/Convert/Adapter/Grid.php | 3 +- .../Eav/Model/Entity/Attribute/Abstract.php | 6 +- .../Entity/Attribute/Backend/Abstract.php | 3 +- .../Entity/Attribute/Backend/Time/Created.php | 3 +- app/code/core/Mage/Eav/Model/Entity/Setup.php | 3 +- app/code/core/Mage/GiftMessage/Model/Api.php | 3 +- .../core/Mage/GiftMessage/Model/Api/V2.php | 3 +- .../Attribute/Backend/Boolean/Config.php | 3 +- .../Model/Export/Entity/Abstract.php | 9 +- .../Model/Export/Entity/Product.php | 3 +- .../Model/Import/Entity/Abstract.php | 3 +- .../Model/Import/Entity/Customer.php | 3 +- .../Model/Import/Entity/Product.php | 12 +- .../Import/Entity/Product/Type/Abstract.php | 15 +- .../Entity/Product/Type/Configurable.php | 6 +- .../Model/Import/Proxy/Product/Resource.php | 2 +- app/code/core/Mage/Index/Model/Indexer.php | 3 +- app/code/core/Mage/Index/Model/Lock.php | 2 +- .../Mage/Install/Model/Installer/Config.php | 3 +- app/code/core/Mage/Install/Model/Wizard.php | 3 +- .../controllers/SubscriberController.php | 3 +- .../Adminhtml/Oauth/AuthorizedTokens/Grid.php | 2 +- app/code/core/Mage/Oauth/Model/Server.php | 3 +- app/code/core/Mage/Page/Helper/Layout.php | 6 +- .../core/Mage/Paygate/Model/Authorizenet.php | 10 +- .../mysql4-data-upgrade-0.7.0-0.7.1.php | 3 +- .../mysql4-upgrade-0.7.0-0.7.1.php | 3 +- .../Mage/Payment/Block/Form/Container.php | 7 +- .../core/Mage/Payment/Model/Method/Cc.php | 7 +- .../Mage/Payment/Model/Recurring/Profile.php | 6 +- .../core/Mage/Paypal/Block/Bml/Banners.php | 3 +- .../core/Mage/Paypal/Block/Express/Form.php | 3 +- .../Mage/Paypal/Block/Express/Shortcut.php | 3 +- app/code/core/Mage/Paypal/Block/Iframe.php | 6 +- .../Paypal/Controller/Express/Abstract.php | 3 +- app/code/core/Mage/Paypal/Helper/Data.php | 3 +- app/code/core/Mage/Paypal/Model/Cart.php | 3 +- app/code/core/Mage/Paypal/Model/Config.php | 13 +- .../Mage/Paypal/Model/Express/Checkout.php | 10 +- app/code/core/Mage/Paypal/Model/Info.php | 3 +- app/code/core/Mage/Paypal/Model/Ipn.php | 3 +- .../Mage/Paypal/Model/Method/Agreement.php | 3 +- .../core/Mage/Paypal/Model/Payflowlink.php | 3 +- .../core/Mage/Paypal/Model/Payflowpro.php | 3 +- .../mysql4-upgrade-0.7.2-0.7.3.php | 3 +- .../Mage/PaypalUk/Block/Express/Shortcut.php | 7 +- app/code/core/Mage/PaypalUk/Model/Api/Nvp.php | 4 +- app/code/core/Mage/PaypalUk/Model/Express.php | 2 +- .../core/Mage/Persistent/Model/Observer.php | 6 +- .../core/Mage/ProductAlert/Model/Observer.php | 10 +- .../ProductAlert/Model/Resource/Price.php | 3 +- .../ProductAlert/Model/Resource/Stock.php | 3 +- .../Report/Product/Viewed/Collection.php | 3 +- .../Mage/Rss/controllers/IndexController.php | 3 +- .../Rule/Model/Condition/Product/Abstract.php | 3 +- .../Sales/Block/Recurring/Profile/View.php | 6 +- app/code/core/Mage/Sales/Helper/Guest.php | 3 +- .../core/Mage/Sales/Model/Api/Resource.php | 6 +- app/code/core/Mage/Sales/Model/Order.php | 12 +- .../Sales/Model/Order/Creditmemo/Item.php | 3 +- app/code/core/Mage/Sales/Model/Order/Item.php | 6 +- .../core/Mage/Sales/Model/Order/Payment.php | 3 +- app/code/core/Mage/Sales/Model/Quote.php | 9 +- .../Sales/Model/Quote/Address/Total/Msrp.php | 12 +- .../Mage/Sales/Model/Quote/Item/Abstract.php | 3 +- .../Report/Bestsellers/Collection.php | 5 +- .../core/Mage/Sales/Model/Resource/Setup.php | 3 +- .../core/Mage/Sales/Model/Service/Order.php | 3 +- .../mysql4-upgrade-1.3.99-1.4.0.0.php | 6 +- .../mysql4-upgrade-1.4.0.21-1.4.0.22.php | 3 +- .../Mage/SalesRule/Model/Resource/Rule.php | 6 +- .../core/Mage/SalesRule/Model/Validator.php | 5 +- .../core/Mage/Sendfriend/Model/Sendfriend.php | 3 +- app/code/core/Mage/Tag/Model/Api.php | 6 +- app/code/core/Mage/Tag/Model/Resource/Tag.php | 3 +- .../Tag/Model/Resource/Tag/Collection.php | 7 +- app/code/core/Mage/Usa/Helper/Data.php | 3 +- .../Mage/Usa/Model/Shipping/Carrier/Ups.php | 7 +- .../core/Mage/Weee/Model/Total/Quote/Weee.php | 3 +- .../Mage/Widget/Model/Widget/Instance.php | 3 +- app/code/core/Mage/Wishlist/Helper/Data.php | 3 +- app/code/core/Mage/Wishlist/Model/Item.php | 3 +- .../core/Mage/Wishlist/Model/Wishlist.php | 3 +- composer.json | 2 +- composer.lock | 14 +- cron.php | 2 +- get.php | 12 +- index.php | 8 +- install.php | 15 +- lib/Mage/Archive/Helper/File.php | 4 +- lib/Magento/Db/Adapter/Pdo/Mysql.php | 7 +- lib/Varien/Data/Collection/Filesystem.php | 3 +- lib/Varien/Data/Tree/Db.php | 9 +- lib/Varien/Data/Tree/Dbp.php | 9 +- lib/Varien/Db/Adapter/Pdo/Mysql.php | 40 +- lib/Varien/Db/Select.php | 9 +- lib/Varien/File/Csv.php | 3 +- lib/Varien/Filter/Template.php | 5 +- 255 files changed, 13432 insertions(+), 3233 deletions(-) create mode 100644 .github/php-cs-fixer-ruleset.php create mode 100644 .github/phpcs-ruleset-ecg.xml create mode 100644 .github/phpcs-ruleset-php.xml delete mode 100644 .github/phpstan_experimental_level.neon create mode 100644 .github/workflows/check-files.yml create mode 100644 .github/workflows/composer.yml create mode 100644 .github/workflows/php-cs-fixer.yml create mode 100644 .github/workflows/workflow.yml diff --git a/.github/labeler.yml b/.github/labeler.yml index b70014094961..2dd6d2f60c23 100644 --- a/.github/labeler.yml +++ b/.github/labeler.yml @@ -1,19 +1,13 @@ 'Environment': - .github/* - .github/**/* - - .phpstorm.meta.php/* - - .travis.yml - -'phpstan': - - .github/phpstan.neon - - .github/phpstan-baseline.neon - - .github/phpstan_experimental_level.neon 'htaccess': - .htaccess 'composer': - composer.json + - composer.lock 'downloader': - downloader/* @@ -603,3 +597,18 @@ # Add Documentation Label 'Documentation': - '*.md' + +'PHPStorm': + - .phpstorm.meta.php/* + +'phpcs': + - .github/phpcs*.xml + - .github/workflows/phpcs.yml + +'php-cs-fixer': + - .github/php-cs-fixer*.php + - .github/workflows/php-cs-fixer.yml + +'phpstan': + - .github/phpstan*.neon + - .github/workflows/phpstan.yml diff --git a/.github/php-cs-fixer-ruleset.php b/.github/php-cs-fixer-ruleset.php new file mode 100644 index 000000000000..83f9b99d93eb --- /dev/null +++ b/.github/php-cs-fixer-ruleset.php @@ -0,0 +1,106 @@ +setRules([ + // There MUST be one blank line after the namespace declaration. + 'blank_line_after_namespace' => true, + // Ensure there is no code on the same line as the PHP open tag and it is followed by a blank line. + 'blank_line_after_opening_tag' => true, + // The body of each structure MUST be enclosed by braces. Braces should be properly placed. Body of braces should be properly indented. + 'braces' => true, + // Whitespace around the keywords of a class, trait or interfaces definition should be one space. + 'class_definition' => true, + // Remove extra spaces in a nullable typehint. + 'compact_nullable_typehint' => true, + // The PHP constants `true`, `false`, and `null` MUST be written using the correct casing. + 'constant_case' => true, + // Equal sign in declare statement should be surrounded by spaces or not following configuration. + 'declare_equal_normalize' => true, + // The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words. + 'elseif' => true, + // PHP code MUST use only UTF-8 without BOM (remove BOM). + 'encoding' => true, + // PHP code must use the long ` true, + // Spaces should be properly placed in a function declaration. + 'function_declaration' => true, + // Code MUST use configured indentation type. + 'indentation_type' => true, + // All PHP files must use same line ending. + 'line_ending' => true, + // Cast should be written in lower case. + 'lowercase_cast' => true, + // PHP keywords MUST be in lower case. + 'lowercase_keywords' => true, + // Class static references `self`, `static` and `parent` MUST be in lower case. + 'lowercase_static_reference' => true, + // In method arguments and method call, there MUST NOT be a space before each comma and there MUST be one space after each comma. Argument lists MAY be split across multiple lines, where each subsequent line is indented once. When doing so, the first item in the list MUST be on the next line, and there MUST be only one argument per line. + 'method_argument_space' => true, + // All instances created with new keyword must be followed by braces. + 'new_with_braces' => true, + // There should be no empty lines after class opening brace. + 'no_blank_lines_after_class_opening' => true, + // There must be a comment when fall-through is intentional in a non-empty case body. + 'no_break_comment' => true, + // The closing `? >` tag MUST be omitted from files containing only PHP. + 'no_closing_tag' => true, + // Remove leading slashes in `use` clauses. + 'no_leading_import_slash' => true, + // There must be no space around double colons (also called Scope Resolution Operator or Paamayim Nekudotayim). + 'no_space_around_double_colon' => true, + // When making a method or function call, there MUST NOT be a space between the method or function name and the opening parenthesis. + 'no_spaces_after_function_name' => true, + // There MUST NOT be a space after the opening parenthesis. There MUST NOT be a space before the closing parenthesis. + 'no_spaces_inside_parenthesis' => true, + // Remove trailing whitespace at the end of non-blank lines. + 'no_trailing_whitespace' => true, + // There MUST be no trailing spaces inside comment or PHPDoc. + 'no_trailing_whitespace_in_comment' => true, + // Remove trailing whitespace at the end of blank lines. + 'no_whitespace_in_blank_line' => true, + // Orders the elements of classes/interfaces/traits. + 'ordered_class_elements' => false, + // Ordering `use` statements. + 'ordered_imports' => true, + // There should be one or no space before colon, and one space after it in return type declarations, according to configuration. + 'return_type_declaration' => true, + // Cast `(boolean)` and `(integer)` should be written as `(bool)` and `(int)`, `(double)` and `(real)` as `(float)`, `(binary)` as `(string)`. + 'short_scalar_cast' => true, + // A PHP file without end tag must always end with a single empty line feed. + 'single_blank_line_at_eof' => true, + // There should be exactly one blank line before a namespace declaration. + 'single_blank_line_before_namespace' => true, + // There MUST NOT be more than one property or constant declared per statement. + 'single_class_element_per_statement' => true, + // There MUST be one use keyword per declaration. + 'single_import_per_statement' => true, + // Each namespace use MUST go on its own line and there MUST be one blank line after the use statements block. + 'single_line_after_imports' => true, + // Each trait `use` must be done as single statement. + 'single_trait_insert_per_statement' => true, + // A case should be followed by a colon and not a semicolon. + 'switch_case_semicolon_to_colon' => true, + // Removes extra spaces between colon and case value. + 'switch_case_space' => true, + // Standardize spaces around ternary operator. + 'ternary_operator_spaces' => true, + // Visibility MUST be declared on all properties and methods; `abstract` and `final` MUST be declared before the visibility; `static` MUST be declared after the visibility. + 'visibility_required' => true, + ]) + ->setFinder( + PhpCsFixer\Finder::create() + ->in([ + 'app/code/core/Mage/', + 'lib/Mage/', + 'lib/Magento/', + 'lib/Varien/' + ]) + ->name('*.php') + ->ignoreDotFiles(true) + ->ignoreVCS(true) + ); diff --git a/.github/phpcs-ruleset-ecg.xml b/.github/phpcs-ruleset-ecg.xml new file mode 100644 index 000000000000..5d05531ec645 --- /dev/null +++ b/.github/phpcs-ruleset-ecg.xml @@ -0,0 +1,177 @@ + + + ./../api.php + ./../cron.php + ./../get.php + ./../index.php + ./../install.php + ./../app/Mage.php + ./../app/code/core/Mage/ + ./../lib/Mage/ + ./../lib/Magento/ + ./../lib/Varien/ + + + + */core/Mage/Admin/Model/Acl/Role/Registry.php* + */core/Mage/Admin/Model/Resource/User.php* + */core/Mage/Adminhtml/Block/Catalog/Product/Attribute/Set/Main.php* + */core/Mage/Adminhtml/Block/Report/Config/Form/Field/YtdStart.php* + */core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/Create/Items.php* + */core/Mage/Adminhtml/Block/Widget/Grid.php* + */core/Mage/Adminhtml/controllers/CustomerController.php* + */core/Mage/Adminhtml/controllers/IndexController.php* + */core/Mage/Adminhtml/controllers/NotificationController.php* + */core/Mage/Adminhtml/controllers/PollController.php* + */core/Mage/Adminhtml/controllers/RatingController.php* + */core/Mage/Adminhtml/controllers/TagController.php* + */core/Mage/Adminhtml/controllers/Catalog/ProductController.php* + */core/Mage/Adminhtml/controllers/Catalog/SearchController.php* + */core/Mage/Adminhtml/controllers/Catalog/Product/ReviewController.php* + */core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php* + */core/Mage/Adminhtml/controllers/Newsletter/SubscriberController.php* + */core/Mage/Adminhtml/controllers/Promo/QuoteController.php* + */core/Mage/Adminhtml/controllers/Sales/OrderController.php* + */core/Mage/Adminhtml/controllers/System/Convert/ProfileController.php* + */core/Mage/Adminhtml/controllers/Tax/RateController.php* + */core/Mage/Adminhtml/Model/Email/Template.php* + */core/Mage/Adminhtml/Model/Giftmessage/Save.php* + */core/Mage/Adminhtml/Model/Sales/Order/Create.php* + */core/Mage/Adminhtml/Model/System/Config/Backend/Category.php* + */core/Mage/Adminhtml/Model/System/Config/Backend/Locale.php* + */core/Mage/Adminhtml/Model/System/Config/Backend/Customer/Show/Customer.php* + */core/Mage/Api/Model/Resource/User.php* + */core/Mage/Api2/Model/Observer.php* + */core/Mage/Api2/controllers/Adminhtml/Api2/AttributeController.php* + */core/Mage/Api2/controllers/Adminhtml/Api2/RoleController.php* + */core/Mage/Authorizenet/Helper/Data.php* + */core/Mage/Backup/Model/Fs/Collection.php* + */core/Mage/Bundle/Model/Product/Type.php* + */core/Mage/Catalog/Model/Api2/Product/Website/Rest.php* + */core/Mage/Catalog/Model/Convert/Adapter/Product.php* + */core/Mage/Catalog/Model/Convert/Parser/Product.php* + */core/Mage/Catalog/Model/Product/Option.php* + */core/Mage/Catalog/Model/Product/Attribute/Backend/Price.php* + */core/Mage/Catalog/Model/Product/Attribute/Backend/Groupprice/Abstract.php* + */core/Mage/Catalog/Model/Product/Option/Value.php* + */core/Mage/Catalog/Model/Product/Type/Configurable.php* + */core/Mage/Catalog/Model/Resource/Category/Flat.php* + */core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php* + */core/Mage/Catalog/Model/Resource/Product.php* + */core/Mage/Catalog/Model/Resource/Product/Link.php* + */core/Mage/Catalog/Model/Resource/Product/Option.php* + */core/Mage/Catalog/Model/Resource/Product/Compare/Item.php* + */core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php* + */core/Mage/Catalog/Model/Resource/Product/Option/Value.php* + */core/Mage/CatalogIndex/Model/Indexer.php* + */core/Mage/CatalogInventory/Model/Observer.php* + */core/Mage/CatalogInventory/Model/Api2/Stock/Item/Rest.php* + */core/Mage/CatalogRule/Model/Observer.php* + */core/Mage/Cron/Model/Observer.php* + */core/Mage/Downloadable/Model/Product/Type.php* + */core/Mage/Downloadable/Model/Observer.php* + */core/Mage/Checkout/Model/Cart/Api.php* + */core/Mage/Checkout/Model/Type/Multishipping.php* + */core/Mage/Core/Model/Email/Queue.php* + */core/Mage/Core/Model/File/Storage.php* + */core/Mage/Core/Model/File/Storage/Directory/Database.php* + */core/Mage/Core/Model/Resource/Db/Collection/Abstract.php* + */core/Mage/Core/Model/Resource/Transaction.php* + */core/Mage/Core/Model/Resource/Translate/String.php* + */core/Mage/Core/Model/Session/Abstract.php* + */core/Mage/Core/Model/Session/Abstract/Varien.php* + */core/Mage/Customer/Model/Convert/Adapter/Customer.php* + */core/Mage/Customer/Model/Convert/Parser/Customer.php* + */core/Mage/Customer/Model/Resource/Customer.php* + */core/Mage/Customer/Model/Resource/Group.php* + */core/Mage/Dataflow/Model/Profile.php* + */core/Mage/Dataflow/Model/Convert/Mapper/Column.php* + */core/Mage/Dataflow/Model/Convert/Parser/Csv.php* + */core/Mage/Dataflow/Model/Convert/Parser/Xml/Excel.php* + */core/Mage/Dataflow/Model/Session/Parser/Csv.php* + */core/Mage/Directory/Model/Currency/Import/Abstract.php* + */core/Mage/Downloadable/Model/Resource/Link.php* + */core/Mage/Eav/Model/Convert/Adapter/Entity.php* + */core/Mage/Eav/Model/Convert/Adapter/Grid.php* + */core/Mage/Eav/Model/Entity/Abstract.php* + */core/Mage/Eav/Model/Entity/Setup.php* + */core/Mage/Eav/Model/Entity/Attribute/Set.php* + */core/Mage/Eav/Model/Entity/Collection/Abstract.php* + */core/Mage/Eav/Model/Form/Type.php* + */core/Mage/Eav/Model/Resource/Entity/Attribute.php* + */core/Mage/Eav/Model/Resource/Entity/Attribute/Group.php* + */core/Mage/Eav/Model/Resource/Entity/Attribute/Set.php* + */core/Mage/GiftMessage/Model/Observer.php* + */core/Mage/ImportExport/Model/Export/Entity/Product.php* + */core/Mage/ImportExport/Model/Import/Entity/Product.php* + */core/Mage/ImportExport/Model/Import/Entity/Product/Type/Configurable.php* + */core/Mage/ImportExport/Model/Import/Entity/Product/Type/Grouped.php* + */core/Mage/ImportExport/Model/Import/Proxy/Product/Resource.php* + */core/Mage/Index/controllers/Adminhtml/ProcessController.php* + */core/Mage/Index/Model/Process.php* + */core/Mage/Index/Model/Resource/Event.php* + */core/Mage/Log/Model/Resource/Log.php* + */core/Mage/Newsletter/Model/Queue.php* + */core/Mage/Oauth/controllers/Adminhtml/Oauth/Admin/TokenController.php* + */core/Mage/Oauth/controllers/Adminhtml/Oauth/AuthorizedTokensController.php* + */core/Mage/Paypal/Model/Ipn.php* + */core/Mage/Paypal/Model/Report/Settlement.php* + */core/Mage/Poll/Model/Poll.php* + */core/Mage/Poll/Model/Resource/Poll.php* + */core/Mage/ProductAlert/Model/Observer.php* + */core/Mage/Reports/Model/Resource/Event.php* + */core/Mage/Reports/Model/Resource/Customer/Collection.php* + */core/Mage/Reports/Model/Resource/Product/Index/Abstract.php* + */core/Mage/Rating/Model/Resource/Rating/Option/Vote/Collection.php* + */core/Mage/Rating/Model/Resource/Rating/Option.php* + */core/Mage/Review/Model/Resource/Review/Collection.php* + */core/Mage/Review/Model/Resource/Review/Product/Collection.php* + */core/Mage/Sales/Model/Entity/Order/Attribute/Backend/Parent.php* + */core/Mage/Sales/Model/Entity/Order/Creditmemo/Attribute/Backend/Parent.php* + */core/Mage/Sales/Model/Entity/Order/Invoice/Attribute/Backend/Parent.php* + */core/Mage/Sales/Model/Entity/Order/Shipment/Attribute/Backend/Parent.php* + */core/Mage/Sales/Model/Entity/Quote.php* + */core/Mage/Sales/Model/Order/Api.php* + */core/Mage/Sales/Model/Order/Invoice.php* + */core/Mage/Sales/Model/Order/Payment.php* + */core/Mage/Sales/Model/Quote/Item.php* + */core/Mage/Sales/Model/Resource/Order/Attribute/Backend/Parent.php* + */core/Mage/Sales/Model/Resource/Order/Creditmemo/Attribute/Backend/Parent.php + */core/Mage/Sales/Model/Resource/Order/Invoice/Attribute/Backend/Parent.php* + */core/Mage/Sales/Model/Resource/Order/Shipment/Attribute/Backend/Parent.php* + */core/Mage/Sales/Model/Observer.php* + */core/Mage/Sales/Model/Order.php* + */core/Mage/Sales/Model/Order/Creditmemo.php* + */core/Mage/Sales/Model/Order/Shipment.php* + */core/Mage/SalesRule/Model/Observer.php* + */core/Mage/SalesRule/Model/Rule.php* + */core/Mage/Tag/controllers/IndexController.php* + */core/Mage/Tag/Model/Api.php* + */core/Mage/Tag/Model/Resource/Product/Collection.php* + */core/Mage/Tax/Model/Observer.php* + */core/Mage/Tax/Model/Calculation/Rate.php* + */core/Mage/Tax/Model/Calculation/Rule.php* + */core/Mage/Tax/Model/Resource/Setup.php* + */core/Mage/Wishlist/controllers/IndexController.php* + */core/Mage/Wishlist/Model/Item.php* + */core/Mage/Wishlist/Model/Observer.php* + */lib/Mage/Backup/Filesystem/Rollback/Ftp.php* + */lib/Varien/Cache/Core.php* + */lib/Varien/Cache/Backend/Memcached.php* + */lib/Varien/Convert/Parser/Csv.php* + */lib/Varien/Object/Cache.php* + */core/Mage/*/data/* + */core/Mage/*/sql/* + + + */core/Mage/Catalog/Model/Resource/Eav/Mysql4/**.php* + */core/Mage/Install/Block/Db/Type/Mysql4.php* + */core/Mage/Install/Model/Installer/Db/Mysql4.php* + + */core/Mage/*/Model/Mysql4/**.php* + + */core/Mage/*/Model/Resource/Helper/Mysql4.php* + + diff --git a/.github/phpcs-ruleset-php.xml b/.github/phpcs-ruleset-php.xml new file mode 100644 index 000000000000..1ae92b385b86 --- /dev/null +++ b/.github/phpcs-ruleset-php.xml @@ -0,0 +1,20 @@ + + + ./../api.php + ./../cron.php + ./../get.php + ./../index.php + ./../install.php + ./../app/Mage.php + ./../app/code/core/Mage/ + ./../lib/Mage/ + ./../lib/Magento/ + ./../lib/Varien/ + + + */Varien/Object.php* + */Varien/Data/Form/Abstract.php* + */Varien/Db/Tree.php* + */Varien/Directory/Collection.php* + + diff --git a/.github/phpcs-ruleset.xml b/.github/phpcs-ruleset.xml index 5e21176d0411..eb255eaba00a 100644 --- a/.github/phpcs-ruleset.xml +++ b/.github/phpcs-ruleset.xml @@ -1,31 +1,54 @@ - + + ./../api.php + ./../cron.php + ./../get.php + ./../index.php + ./../install.php + ./../app/Mage.php + ./../app/code/core/Mage/ + ./../lib/Mage/ + ./../lib/Magento/ + ./../lib/Varien/ + + + + */get.php* + */index.php* + */app/Mage.php* + */core/Mage/Adminhtml/controllers/Sales/Order/EditController.php* + */core/Mage/Adminhtml/controllers/System/Convert/GuiController.php* + */core/Mage/Authorizenet/controllers/Adminhtml/Authorizenet/Directpost/PaymentController.php* + */core/Mage/Bundle/controllers/Adminhtml/Bundle/Product/EditController.php* + */core/Mage/Bundle/controllers/Product/EditController.php* + */core/Mage/Bundle/controllers/SelectionController.php* + */core/Mage/Centinel/Model/Api/Client.php* + */core/Mage/Downloadable/controllers/Adminhtml/Downloadable/Product/EditController.php* + */core/Mage/Downloadable/controllers/Product/EditController.php* + */core/Mage/Downloadable/controllers/FileController.php* + + */lib/Varien/Db/Tree/Exception.php* + */lib/Varien/Db/Tree/Node.php* + */lib/Varien/Db/Exception.php* + */lib/Varien/Db/Tree.php* + */lib/Varien/Directory/Collection.php* + */lib/Varien/Directory/Factory.php* + */lib/Varien/File/CsvMulty.php* + */lib/Varien/File/Object.php* + */lib/Varien/Io/Sftp.php* + - - - + - + - diff --git a/.github/phpstan-baseline.neon b/.github/phpstan-baseline.neon index 450d48aaa4fa..47854e1bb78d 100644 --- a/.github/phpstan-baseline.neon +++ b/.github/phpstan-baseline.neon @@ -1,5735 +1,14945 @@ parameters: ignoreErrors: - - message: "#^Comparison operation \"\\=\\=\" between \\(Varien_Simplexml_Element\\|null\\) and 1 results in an error\\.$#" + message: "#^Call to an undefined method Mage_Core_Model_Abstract\\:\\:addError\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Admin/Model/Config.php + path: ../app/Mage.php - - message: "#^Cannot call method getClassName\\(\\) on SimpleXMLElement\\|false\\.$#" - count: 1 - path: ../app/code/core/Mage/Admin/Model/Resource/Acl.php + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/Mage.php - - message: "#^Return type \\(bool\\) of method Mage_Admin_Model_Resource_User\\:\\:delete\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Resource_Db_Abstract\\)\\) of method Mage_Core_Model_Resource_Db_Abstract\\:\\:delete\\(\\)$#" + message: "#^Parameter \\#2 \\$value of function ini_set expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Admin/Model/Resource/User.php + path: ../app/Mage.php - - message: "#^Call to an undefined method Mage_Admin_Model_Resource_Roles\\:\\:update\\(\\)\\.$#" + message: "#^Right side of && is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Admin/Model/Roles.php + path: ../app/Mage.php - - message: "#^Comparison operation \"\\=\\=\" between \\(Varien_Simplexml_Element\\|null\\) and 1 results in an error\\.$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Admin/Model/Roles.php + path: ../app/Mage.php - - message: "#^Call to an undefined method Mage_Admin_Model_Resource_Rules\\:\\:update\\(\\)\\.$#" + message: "#^Strict comparison using \\=\\=\\= between 19 and 20 will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Admin/Model/Rules.php + path: ../app/Mage.php - - message: "#^Call to an undefined method Zend_Controller_Response_Abstract\\:\\:sendHeadersAndExit\\(\\)\\.$#" + message: "#^Comparison operation \"\\=\\=\" between \\(Varien_Simplexml_Element\\|null\\) and 1 results in an error\\.$#" count: 1 - path: ../app/code/core/Mage/Admin/Model/Session.php + path: ../app/code/core/Mage/Admin/Model/Config.php - - message: "#^Call to an undefined method Mage_Api_Model_Resource_Roles_User_Collection\\:\\:setUserFilter\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$sourceData of class Varien_Simplexml_Config constructor expects string\\|Varien_Simplexml_Element\\|null, Varien_Simplexml_Config given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Api/Tab/Userroles.php + path: ../app/code/core/Mage/Admin/Model/Config.php - - message: "#^Return type \\(false\\) of method Mage_Adminhtml_Block_Cache_Grid\\:\\:getRowUrl\\(\\) should be compatible with return type \\(string\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:getRowUrl\\(\\)$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Cache/Grid.php + message: "#^Parameter \\#2 \\$arguments of static method Mage\\:\\:getModel\\(\\) expects array\\|object, string given\\.$#" + count: 2 + path: ../app/code/core/Mage/Admin/Model/Config.php - - message: "#^Method Mage_Adminhtml_Block_Catalog_Category_Checkboxes_Tree\\:\\:_getNodeJson\\(\\) should return string but returns array\\\\.$#" + message: "#^Parameter \\#2 \\$mergeToObject of method Mage_Core_Model_Config\\:\\:loadModulesConfiguration\\(\\) expects Mage_Core_Model_Config_Base\\|null, Varien_Simplexml_Config given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Category/Checkboxes/Tree.php + path: ../app/code/core/Mage/Admin/Model/Config.php - - message: "#^Method Mage_Adminhtml_Block_Catalog_Category_Tree\\:\\:_getNodeJson\\(\\) should return string but returns array\\\\.$#" + message: "#^Parameter \\#2 \\$resource of method Mage_Admin_Model_Config\\:\\:loadAclResources\\(\\) expects Mage_Core_Model_Config_Element\\|null, Varien_Simplexml_Element given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Category/Tree.php + path: ../app/code/core/Mage/Admin/Model/Config.php - - message: "#^Cannot assign offset 'checked' to string\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Category/Widget/Chooser.php + path: ../app/code/core/Mage/Admin/Model/Observer.php - - message: "#^Cannot call method addAttributeToSelect\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + message: "#^Cannot call method getClassName\\(\\) on SimpleXMLElement\\|false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Category/Widget/Chooser.php + path: ../app/code/core/Mage/Admin/Model/Resource/Acl.php - - message: "#^Method Mage_Adminhtml_Block_Catalog_Category_Widget_Chooser\\:\\:_getNodeJson\\(\\) should return string but returns array\\\\.$#" + message: "#^Parameter \\#2 \\$arguments of static method Mage\\:\\:getModel\\(\\) expects array\\|object, string given\\.$#" + count: 2 + path: ../app/code/core/Mage/Admin/Model/Resource/Acl.php + + - + message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Category/Widget/Chooser.php + path: ../app/code/core/Mage/Admin/Model/Resource/Block.php - - message: "#^Method Mage_Adminhtml_Block_Widget_Grid\\:\\:addColumn\\(\\) invoked with 3 parameters, 2 required\\.$#" + message: "#^Parameter \\#1 \\$role of method Mage_Admin_Model_Resource_Roles\\:\\:_updateRoleUsersAcl\\(\\) expects Mage_Admin_Model_Roles, Mage_Core_Model_Abstract given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Attribute/Grid.php + path: ../app/code/core/Mage/Admin/Model/Resource/Roles.php - - message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Catalog_Product_Attribute_Set_Grid\\:\\:_prepareColumns\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:_prepareColumns\\(\\)$#" + message: "#^Return type \\(bool\\) of method Mage_Admin_Model_Resource_User\\:\\:delete\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Resource_Db_Abstract\\)\\) of method Mage_Core_Model_Resource_Db_Abstract\\:\\:delete\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Attribute/Set/Grid.php + path: ../app/code/core/Mage/Admin/Model/Resource/User.php - - message: "#^Method Mage_Adminhtml_Block_Catalog_Product_Edit_Action_Attribute\\:\\:_getHelper\\(\\) should return Mage_Adminhtml_Helper_Catalog_Product_Edit_Action_Attribute but returns Mage_Core_Helper_Abstract\\.$#" + message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Action/Attribute.php + path: ../app/code/core/Mage/Admin/Model/Resource/Variable.php - - message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Catalog_Product_Edit_Tab_Attributes\\:\\:_prepareForm\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Form\\)\\) of method Mage_Adminhtml_Block_Widget_Form\\:\\:_prepareForm\\(\\)$#" + message: "#^Call to an undefined method Mage_Admin_Model_Resource_Roles\\:\\:update\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Attributes.php + path: ../app/code/core/Mage/Admin/Model/Roles.php - - message: "#^Cannot assign offset 'expanded' to string\\.$#" + message: "#^Comparison operation \"\\=\\=\" between \\(Varien_Simplexml_Element\\|null\\) and 1 results in an error\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Categories.php + path: ../app/code/core/Mage/Admin/Model/Roles.php - - message: "#^Return type \\(array\\) of method Mage_Adminhtml_Block_Catalog_Product_Edit_Tab_Categories\\:\\:_getNodeJson\\(\\) should be compatible with return type \\(string\\) of method Mage_Adminhtml_Block_Catalog_Category_Tree\\:\\:_getNodeJson\\(\\)$#" + message: "#^Call to an undefined method Mage_Admin_Model_Resource_Rules\\:\\:update\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Categories.php + path: ../app/code/core/Mage/Admin/Model/Rules.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 2 parameters, 0 required\\.$#" + message: "#^Call to an undefined method Zend_Controller_Response_Abstract\\:\\:sendHeadersAndExit\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Config/Simple.php + path: ../app/code/core/Mage/Admin/Model/Session.php - - message: "#^Method Mage_Catalog_Model_Product_Type_Configurable\\:\\:canUseAttribute\\(\\) invoked with 2 parameters, 1 required\\.$#" + message: "#^Call to function is_null\\(\\) with bool will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Settings.php + path: ../app/code/core/Mage/Admin/Model/Session.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute\\:\\:isScopeGlobal\\(\\)\\.$#" - count: 2 - path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Gallery.php + message: "#^Parameter \\#1 \\$parent of method Mage_Admin_Model_User\\:\\:findFirstAvailableMenu\\(\\) expects Mage_Core_Model_Config_Element\\|null, Varien_Simplexml_Element given\\.$#" + count: 1 + path: ../app/code/core/Mage/Admin/Model/User.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute\\:\\:isScopeStore\\(\\)\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_AdminNotification_Model_Inbox will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Gallery.php + path: ../app/code/core/Mage/AdminNotification/Helper/Data.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute\\:\\:isScopeWebsite\\(\\)\\.$#" + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Gallery.php + path: ../app/code/core/Mage/AdminNotification/Helper/Data.php - - message: "#^PHPDoc type Mage_Core_Model_Abstract of property Mage_Adminhtml_Block_Customer_Edit_Renderer_Region\\:\\:\\$_factory is not covariant with PHPDoc type Mage_Core_Model_Factory of overridden property Mage_Core_Block_Abstract\\:\\:\\$_factory\\.$#" + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Renderer/Region.php + path: ../app/code/core/Mage/AdminNotification/Model/Feed.php - - message: "#^Property Mage_Adminhtml_Block_Customer_Edit_Tab_View_Sales\\:\\:\\$_collection \\(Mage_Sales_Model_Entity_Sale_Collection\\) does not accept Varien_Data_Collection_Db\\.$#" + message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View/Sales.php + path: ../app/code/core/Mage/AdminNotification/Model/Feed.php - - message: "#^Method Mage_Wishlist_Model_Resource_Item_Collection\\:\\:addDaysInWishlist\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View/Wishlist.php + path: ../app/code/core/Mage/Adminhtml/Block/Api/Tab/Rolesedit.php - - message: "#^Method Mage_Adminhtml_Block_Customer_Sales_Order_Address_Form_Renderer_Vat\\:\\:getValidateButton\\(\\) should return Mage_Adminhtml_Block_Widget_Button but returns Mage_Core_Block_Abstract\\.$#" + message: "#^Call to an undefined method Mage_Api_Model_Resource_Roles_User_Collection\\:\\:setUserFilter\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Customer/Sales/Order/Address/Form/Renderer/Vat.php + path: ../app/code/core/Mage/Adminhtml/Block/Api/Tab/Userroles.php - - message: "#^Property Mage_Adminhtml_Block_Customer_Sales_Order_Address_Form_Renderer_Vat\\:\\:\\$_validateButton \\(Mage_Adminhtml_Block_Widget_Button\\|null\\) does not accept Mage_Core_Block_Abstract\\.$#" + message: "#^Return type \\(false\\) of method Mage_Adminhtml_Block_Cache_Grid\\:\\:getRowUrl\\(\\) should be compatible with return type \\(string\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:getRowUrl\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Customer/Sales/Order/Address/Form/Renderer/Vat.php + path: ../app/code/core/Mage/Adminhtml/Block/Cache/Grid.php - - message: "#^Variable \\$d might not be defined\\.$#" + message: "#^If condition is always true\\.$#" + count: 3 + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Category/Abstract.php + + - + message: "#^Left side of && is always true\\.$#" count: 2 - path: ../app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Category/Abstract.php - - message: "#^Variable \\$localmaxlength might not be defined\\.$#" + message: "#^Right side of && is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Category/Abstract.php - - message: "#^Variable \\$localmaxvalue might not be defined\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Category/Abstract.php - - message: "#^Variable \\$localminvalue might not be defined\\.$#" + message: "#^Method Mage_Adminhtml_Block_Catalog_Category_Checkboxes_Tree\\:\\:_getNodeJson\\(\\) should return string but returns array\\\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Category/Checkboxes/Tree.php - - message: "#^Variable \\$class might not be defined\\.$#" + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Notification/Grid/Renderer/Severity.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Category/Tab/Attributes.php - - message: "#^Variable \\$value might not be defined\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Notification/Grid/Renderer/Severity.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Category/Tab/Design.php - - message: "#^Access to an undefined property Mage_Adminhtml_Block_Notification_Window\\:\\:\\$_aclResourcePath\\.$#" + message: "#^Method Mage_Adminhtml_Block_Catalog_Category_Tree\\:\\:_getNodeJson\\(\\) should return string but returns array\\\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Notification/Window.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Category/Tree.php - - message: "#^Comparison operation \"\\=\\=\" between \\(Varien_Simplexml_Element\\|null\\) and 1 results in an error\\.$#" + message: "#^Offset 'children' on string on left side of \\?\\? does not exist\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Category/Tree.php + + - + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Page/Menu.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Category/Tree.php - - message: "#^Call to method getCollection\\(\\) on an unknown class Mage_Permissions_Model_Users\\.$#" + message: "#^Cannot assign offset 'checked' to string\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Permissions/Grid/User.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Category/Widget/Chooser.php - - message: "#^Call to an undefined method Varien_Data_Collection\\:\\:addFieldToFilter\\(\\)\\.$#" - count: 2 - path: ../app/code/core/Mage/Adminhtml/Block/Permissions/Role/Grid/User.php + message: "#^Cannot call method addAttributeToSelect\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Category/Widget/Chooser.php - - message: "#^Call to an undefined method Mage_Admin_Model_Resource_Roles_User_Collection\\:\\:setUserFilter\\(\\)\\.$#" + message: "#^Method Mage_Adminhtml_Block_Catalog_Category_Widget_Chooser\\:\\:_getNodeJson\\(\\) should return string but returns array\\\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Permissions/Tab/Userroles.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Category/Widget/Chooser.php - - message: "#^Call to an undefined method Varien_Data_Collection\\:\\:addFieldToFilter\\(\\)\\.$#" - count: 2 - path: ../app/code/core/Mage/Adminhtml/Block/Permissions/User/Edit/Tab/Roles.php + message: "#^Parameter \\#1 \\$renderer of static method Varien_Data_Form\\:\\:setElementRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Form.php - - message: "#^Call to method getCollection\\(\\) on an unknown class Mage_Permissions_Model_Roles\\.$#" + message: "#^Parameter \\#1 \\$renderer of static method Varien_Data_Form\\:\\:setFieldsetElementRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Permissions/Usernroles.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Form.php - - message: "#^Call to method getCollection\\(\\) on an unknown class Mage_Permissions_Model_Users\\.$#" + message: "#^Parameter \\#1 \\$renderer of static method Varien_Data_Form\\:\\:setFieldsetRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Permissions/Usernroles.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Form.php - - message: "#^Variable \\$answerData might not be defined\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Poll/Answer/Edit.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Form/Renderer/Fieldset/Element.php - - message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Report_Grid\\:\\:_prepareCollection\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:_prepareCollection\\(\\)$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Report/Grid.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Form/Renderer/Fieldset/Element.php - - message: "#^Call to an undefined method Mage_Reports_Model_Resource_Report_Collection_Abstract\\:\\:addOrderStatusFilter\\(\\)\\.$#" + message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Attribute/Edit/Tab/Main.php - - message: "#^Cannot call method setPeriod\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" - count: 4 - path: ../app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php + message: "#^Parameter \\#4 \\$after of method Varien_Data_Form_Element_Fieldset\\:\\:addField\\(\\) expects bool, string given\\.$#" + count: 3 + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Attribute/Edit/Tab/Main.php - - message: "#^Method Mage_Adminhtml_Block_Report_Grid_Abstract\\:\\:addColumn\\(\\) should return Mage_Adminhtml_Block_Report_Grid_Abstract but returns Mage_Adminhtml_Block_Widget_Grid\\.$#" + message: "#^Method Mage_Adminhtml_Block_Widget_Grid\\:\\:addColumn\\(\\) invoked with 3 parameters, 2 required\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Attribute/Grid.php - - message: "#^Method Mage_Adminhtml_Block_Report_Grid_Abstract\\:\\:getCollection\\(\\) should return Mage_Reports_Model_Grouped_Collection but returns Varien_Data_Collection\\.$#" + message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Catalog_Product_Attribute_Set_Grid\\:\\:_prepareColumns\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:_prepareColumns\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Attribute/Set/Grid.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:setStore\\(\\)\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Report/Product/Grid.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Composite/Fieldset/Grouped.php - - message: "#^Method Mage_Reports_Model_Totals\\:\\:countTotals\\(\\) invoked with 1 parameter, 3 required\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Report/Product/Grid.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Created.php - - message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Report_Product_Grid\\:\\:_afterLoadCollection\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:_afterLoadCollection\\(\\)$#" + message: "#^Parameter \\#1 \\$attributeId of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:getAttributeById\\(\\) expects int, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Report/Product/Grid.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Created.php - - message: "#^Call to an undefined method Mage_Reports_Model_Resource_Report_Collection_Abstract\\:\\:addRuleFilter\\(\\)\\.$#" + message: "#^Parameter \\#2 \\$product of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:getAttributeById\\(\\) expects null, Mage_Catalog_Model_Product given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Report/Sales/Coupons/Grid.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Created.php - - message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Report_Shopcart_Customer_Grid\\:\\:_afterLoadCollection\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:_afterLoadCollection\\(\\)$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Report/Shopcart/Customer/Grid.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit.php - - message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Review_Grid\\:\\:_prepareMassaction\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:_prepareMassaction\\(\\)$#" + message: "#^Method Mage_Adminhtml_Block_Catalog_Product_Edit_Action_Attribute\\:\\:_getHelper\\(\\) should return Mage_Adminhtml_Helper_Catalog_Product_Edit_Action_Attribute but returns Mage_Core_Helper_Abstract\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Review/Grid.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Action/Attribute.php - - message: "#^Return type \\(int\\) of method Mage_Adminhtml_Block_Review_Grid_Filter_Type\\:\\:getCondition\\(\\) should be compatible with return type \\(array\\|null\\) of method Mage_Adminhtml_Block_Widget_Grid_Column_Filter_Select\\:\\:getCondition\\(\\)$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Review/Grid/Filter/Type.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Js.php - - message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Review_Product_Grid\\:\\:_prepareColumns\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Catalog_Product_Grid\\:\\:_prepareColumns\\(\\)$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Review/Product/Grid.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Js.php - - message: "#^Method Mage_Adminhtml_Block_Sales_Order_Create_Billing_Address\\:\\:getAddress\\(\\) should return Mage_Customer_Model_Address but returns Mage_Sales_Model_Quote_Address\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Billing/Address.php + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" + count: 4 + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Attributes.php - - message: "#^Property Mage_Adminhtml_Block_Sales_Order_Create_Form_Address\\:\\:\\$_addressForm \\(Mage_Customer_Model_Form\\) does not accept Mage_Eav_Model_Form\\.$#" + message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Catalog_Product_Edit_Tab_Attributes\\:\\:_prepareForm\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Form\\)\\) of method Mage_Adminhtml_Block_Widget_Form\\:\\:_prepareForm\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Address.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Attributes.php - - message: "#^Method Mage_Adminhtml_Block_Sales_Order_Create_Giftmessage_Form\\:\\:getEntity\\(\\) should return Varien_Object but returns Mage_Eav_Model_Entity_Abstract\\.$#" + message: "#^Call to function is_null\\(\\) with Varien_Object will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage/Form.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Attributes/Create.php - - message: "#^Property Mage_Adminhtml_Block_Sales_Order_Create_Giftmessage_Form\\:\\:\\$_entity \\(Mage_Eav_Model_Entity_Abstract\\) does not accept Varien_Object\\.$#" + message: "#^Cannot assign offset 'expanded' to string\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage/Form.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Categories.php - - message: "#^Argument of an invalid type float supplied for foreach, only iterables are supported\\.$#" + message: "#^If condition is always true\\.$#" count: 2 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Items/Grid.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Categories.php - - message: "#^Undefined variable\\: \\$info$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Items/Grid.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Categories.php - - message: "#^Call to method getIsOldCustomer\\(\\) on an unknown class Mage_Adminhtml_Model_Quote\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Newsletter.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Categories.php - - message: "#^Method Mage_Adminhtml_Block_Sales_Order_Create_Shipping_Address\\:\\:getAddress\\(\\) should return Mage_Customer_Model_Address but returns Mage_Sales_Model_Quote_Address\\.$#" + message: "#^Return type \\(array\\) of method Mage_Adminhtml_Block_Catalog_Product_Edit_Tab_Categories\\:\\:_getNodeJson\\(\\) should be compatible with return type \\(string\\) of method Mage_Adminhtml_Block_Catalog_Category_Tree\\:\\:_getNodeJson\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Shipping/Address.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Categories.php - - message: "#^Variable \\$button might not be defined\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar.php + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Inventory.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Compare_Item_Collection\\:\\:useProductItem\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Compared.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Inventory.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Compare_Item_Collection\\:\\:useProductItem\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Pcompared.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Price.php - - message: "#^Call to an undefined method Mage_Adminhtml_Block_Sales_Order_Creditmemo_Create_Adjustments\\:\\:addTotal\\(\\)\\.$#" + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/Create/Adjustments.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Price/Group/Abstract.php - - message: "#^Call to an undefined method Mage_Adminhtml_Block_Sales_Order_Creditmemo_Create_Adjustments\\:\\:removeTotal\\(\\)\\.$#" - count: 3 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/Create/Adjustments.php + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Price/Group/Abstract.php - - message: "#^Return type \\(Mage_Sales_Model_Order_Creditmemo\\) of method Mage_Adminhtml_Block_Sales_Order_Creditmemo_Create_Items\\:\\:getSource\\(\\) should be compatible with return type \\(Mage_Sales_Model_Order_Invoice\\) of method Mage_Adminhtml_Block_Sales_Items_Abstract\\:\\:getSource\\(\\)$#" + message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 2 parameters, 0 required\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/Create/Items.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Config/Simple.php - - message: "#^Return type \\(Mage_Sales_Model_Order_Creditmemo\\) of method Mage_Adminhtml_Block_Sales_Order_Creditmemo_View_Items\\:\\:getSource\\(\\) should be compatible with return type \\(Mage_Sales_Model_Order_Invoice\\) of method Mage_Adminhtml_Block_Sales_Items_Abstract\\:\\:getSource\\(\\)$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/View/Items.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Config/Simple.php - - message: "#^Return type \\(Mage_Sales_Model_Order_Shipment\\) of method Mage_Adminhtml_Block_Sales_Order_Shipment_Create_Items\\:\\:getSource\\(\\) should be compatible with return type \\(Mage_Sales_Model_Order_Invoice\\) of method Mage_Adminhtml_Block_Sales_Items_Abstract\\:\\:getSource\\(\\)$#" + message: "#^Method Mage_Catalog_Model_Product_Type_Configurable\\:\\:canUseAttribute\\(\\) invoked with 2 parameters, 1 required\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Create/Items.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Settings.php - - message: "#^Call to an undefined method Mage_Shipping_Model_Carrier_Abstract\\:\\:isGirthAllowed\\(\\)\\.$#" + message: "#^Parameter \\#2 \\$replace of function str_replace expects array\\|string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Websites.php - - message: "#^Method Mage_Adminhtml_Block_Sales_Order_Shipment_Packaging\\:\\:getQtyOrderedItem\\(\\) should return int\\|null but empty return statement found\\.$#" + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tabs.php - - message: "#^Variable \\$createLabelUrl might not be defined\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Grid.php - - message: "#^Variable \\$itemsGridUrl might not be defined\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute\\:\\:isScopeGlobal\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Gallery.php - - message: "#^Variable \\$itemsOrderItemId might not be defined\\.$#" + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute\\:\\:isScopeStore\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Gallery.php - - message: "#^Return type \\(Mage_Sales_Model_Order_Shipment\\) of method Mage_Adminhtml_Block_Sales_Order_Shipment_View_Items\\:\\:getSource\\(\\) should be compatible with return type \\(Mage_Sales_Model_Order_Invoice\\) of method Mage_Adminhtml_Block_Sales_Items_Abstract\\:\\:getSource\\(\\)$#" + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute\\:\\:isScopeWebsite\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/View/Items.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Gallery.php - - message: "#^Property Mage_Adminhtml_Block_Sales_Order_View_Items_Renderer_Default\\:\\:\\$_giftMessage \\(Mage_GiftMessage_Model_Message\\) does not accept default value of type array\\.$#" + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Items/Renderer/Default.php + path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Search/Edit/Form.php - - message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:setOrderFilter\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Tab/Creditmemos.php + path: ../app/code/core/Mage/Adminhtml/Block/Checkout/Agreement/Edit/Form.php - - message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:setOrderFilter\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'afterLoad' given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Tab/Invoices.php + path: ../app/code/core/Mage/Adminhtml/Block/Checkout/Agreement/Grid.php - - message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:setOrderFilter\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Tab/Shipments.php + path: ../app/code/core/Mage/Adminhtml/Block/Cms/Block/Edit/Form.php - - message: "#^Property Mage_Adminhtml_Block_Shipping_Carrier_Tablerate_Grid\\:\\:\\$_conditionName \\(string\\) does not accept int\\.$#" + message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'afterLoad' given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Shipping/Carrier/Tablerate/Grid.php + path: ../app/code/core/Mage/Adminhtml/Block/Cms/Block/Grid.php - - message: "#^Property Mage_Adminhtml_Block_Store_Switcher_Form_Renderer_Fieldset\\:\\:\\$_element \\(Varien_Data_Form_Element_Fieldset\\) does not accept Varien_Data_Form_Element_Abstract\\.$#" + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Store/Switcher/Form/Renderer/Fieldset.php + path: ../app/code/core/Mage/Adminhtml/Block/Cms/Page/Edit/Tab/Main.php - - message: "#^Property Mage_Adminhtml_Block_Store_Switcher_Form_Renderer_Fieldset_Element\\:\\:\\$_element \\(Varien_Data_Form_Element_Fieldset\\) does not accept Varien_Data_Form_Element_Abstract\\.$#" + message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'afterLoad' given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Store/Switcher/Form/Renderer/Fieldset/Element.php + path: ../app/code/core/Mage/Adminhtml/Block/Cms/Page/Grid.php - - message: "#^Cannot call method initForm\\(\\) on Mage_Core_Block_Abstract\\|false\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Config/Edit.php + path: ../app/code/core/Mage/Adminhtml/Block/Cms/Wysiwyg/Images/Content/Files.php - - message: "#^Call to an undefined method Mage_Core_Model_Abstract\\:\\:toOptionArray\\(\\)\\.$#" + message: "#^PHPDoc type Mage_Core_Model_Abstract of property Mage_Adminhtml_Block_Customer_Edit_Renderer_Region\\:\\:\\$_factory is not covariant with PHPDoc type Mage_Core_Model_Factory of overridden property Mage_Core_Block_Abstract\\:\\:\\$_factory\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Config/Form.php + path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Renderer/Region.php - - message: "#^Comparison operation \"\\=\\=\" between \\(Mage_Core_Model_Config_Element\\|null\\) and 1 results in an error\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Store will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Account.php + + - + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" + count: 4 + path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Account.php + + - + message: "#^Parameter \\#4 \\$after of method Varien_Data_Form_Element_Fieldset\\:\\:addField\\(\\) expects bool, string given\\.$#" count: 2 - path: ../app/code/core/Mage/Adminhtml/Block/System/Config/Form.php + path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Account.php - - message: "#^Variable \\$attributes might not be defined\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Convert/Gui/Edit/Tab/Wizard.php + message: "#^Left side of && is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Addresses.php - - message: "#^Variable \\$img might not be defined\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Convert/Profile/Run.php + message: "#^Parameter \\#4 \\$after of method Varien_Data_Form_Element_Fieldset\\:\\:addField\\(\\) expects bool, string given\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Addresses.php - - message: "#^Variable \\$liStyle might not be defined\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Convert/Profile/Run.php + path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View.php - - message: "#^Method Mage_Adminhtml_Block_System_Email_Template_Edit\\:\\:getUsedCurrentlyForPaths\\(\\) should return string but returns array\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Email/Template/Edit.php + path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View.php - - message: "#^Method Mage_Adminhtml_Block_System_Email_Template_Edit\\:\\:getUsedDefaultForPaths\\(\\) should return string but returns array\\.$#" + message: "#^Parameter \\#1 \\$date of method Mage_Core_Helper_Data\\:\\:formatDate\\(\\) expects string\\|Zend_Date\\|null, int\\\\|int\\<1, max\\> given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Email/Template/Edit.php + path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View.php - - message: "#^Method Mage_Core_Model_Email_Template\\:\\:getProcessedTemplate\\(\\) invoked with 2 parameters, 0\\-1 required\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Email/Template/Preview.php + path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View/Grid/Renderer/Item.php - - message: "#^Variable \\$addLabel might not be defined\\.$#" + message: "#^Property Mage_Adminhtml_Block_Customer_Edit_Tab_View_Sales\\:\\:\\$_collection \\(Mage_Sales_Model_Entity_Sale_Collection\\) does not accept Varien_Data_Collection_Db\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php + path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View/Sales.php - - message: "#^Variable \\$deleteLabel might not be defined\\.$#" + message: "#^Method Mage_Wishlist_Model_Resource_Item_Collection\\:\\:addDaysInWishlist\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php + path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View/Wishlist.php - - message: "#^Variable \\$deleteUrl might not be defined\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php + path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Wishlist.php - - message: "#^Variable \\$editLabel might not be defined\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php + path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Wishlist.php - - message: "#^Variable \\$saveLabel might not be defined\\.$#" + message: "#^Call to function is_array\\(\\) with mixed will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php + path: ../app/code/core/Mage/Adminhtml/Block/Customer/Form/Element/File.php - - message: "#^Variable \\$groupModel might not be defined\\.$#" - count: 18 - path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php + message: "#^Result of && is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Customer/Form/Element/File.php - - message: "#^Variable \\$showGroupFieldset might not be defined\\.$#" + message: "#^Method Mage_Adminhtml_Block_Customer_Sales_Order_Address_Form_Renderer_Vat\\:\\:getValidateButton\\(\\) should return Mage_Adminhtml_Block_Widget_Button but returns Mage_Core_Block_Abstract\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php + path: ../app/code/core/Mage/Adminhtml/Block/Customer/Sales/Order/Address/Form/Renderer/Vat.php - - message: "#^Variable \\$showStoreFieldset might not be defined\\.$#" + message: "#^Property Mage_Adminhtml_Block_Customer_Sales_Order_Address_Form_Renderer_Vat\\:\\:\\$_validateButton \\(Mage_Adminhtml_Block_Widget_Button\\|null\\) does not accept Mage_Core_Block_Abstract\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php + path: ../app/code/core/Mage/Adminhtml/Block/Customer/Sales/Order/Address/Form/Renderer/Vat.php - - message: "#^Variable \\$showWebsiteFieldset might not be defined\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php + path: ../app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php - - message: "#^Variable \\$storeModel might not be defined\\.$#" - count: 21 - path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php + message: "#^Variable \\$d might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php - - message: "#^Variable \\$websiteModel might not be defined\\.$#" - count: 15 - path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php + message: "#^Variable \\$localmaxlength might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php - - message: "#^Call to an undefined method Mage_Tag_Model_Resource_Tag_Collection\\:\\:addAttributeToFilter\\(\\)\\.$#" + message: "#^Variable \\$localmaxvalue might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Tag/Grid/All.php + path: ../app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php - - message: "#^Binary operation \"\\*\" between string and 1 results in an error\\.$#" + message: "#^Variable \\$localminvalue might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Tax/Rate/Grid/Renderer/Data.php + path: ../app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php - - message: "#^Variable \\$category in empty\\(\\) always exists and is not falsy\\.$#" + message: "#^Call to function is_null\\(\\) with Varien_Object will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Urlrewrite/Category/Tree.php + path: ../app/code/core/Mage/Adminhtml/Block/Media/Editor.php - - message: "#^Method Mage_Adminhtml_Block_Widget_Container\\:\\:_addButtonChildBlock\\(\\) should return Mage_Adminhtml_Block_Widget_Button but returns Mage_Core_Block_Abstract\\|false\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Newsletter_Model_Resource_Queue_Collection will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Widget/Container.php + path: ../app/code/core/Mage/Adminhtml/Block/Newsletter/Subscriber.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 2 parameters, 0 required\\.$#" - count: 2 - path: ../app/code/core/Mage/Adminhtml/Block/Widget/Form.php + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Resource_Website_Collection will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Newsletter/Subscriber/Grid/Filter/Website.php - - message: "#^Call to an undefined method Varien_Data_Collection\\:\\:addFieldToFilter\\(\\)\\.$#" + message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#" count: 2 - path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid.php + path: ../app/code/core/Mage/Adminhtml/Block/Newsletter/Template/Edit/Form.php - - message: "#^Call to an undefined method Varien_Data_Collection\\:\\:getSelect\\(\\)\\.$#" - count: 3 - path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid.php + message: "#^Variable \\$class might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Notification/Grid/Renderer/Severity.php - - message: "#^Method Mage_Adminhtml_Block_Widget_Grid\\:\\:getSubTotalItem\\(\\) should return Varien_Object but returns string\\.$#" + message: "#^Variable \\$value might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid.php + path: ../app/code/core/Mage/Adminhtml/Block/Notification/Grid/Renderer/Severity.php - - message: "#^Property Mage_Adminhtml_Block_Widget_Grid\\:\\:\\$defaultColumnSettings \\(array\\\\>\\) does not accept default value of type array\\\\>\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid.php + path: ../app/code/core/Mage/Adminhtml/Block/Notification/Toolbar.php - - message: "#^Method Mage_Adminhtml_Block_Widget_Grid_Column_Filter_Date\\:\\:_convertDate\\(\\) should return Zend_Date but returns null\\.$#" + message: "#^Access to an undefined property Mage_Adminhtml_Block_Notification_Window\\:\\:\\$_aclResourcePath\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Date.php + path: ../app/code/core/Mage/Adminhtml/Block/Notification/Window.php - - message: "#^Method Mage_Adminhtml_Block_Widget_Grid_Column_Filter_Datetime\\:\\:_convertDate\\(\\) should return Zend_Date but returns null\\.$#" + message: "#^Call to function is_null\\(\\) with bool will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Datetime.php + path: ../app/code/core/Mage/Adminhtml/Block/Notification/Window.php - - message: "#^Binary operation \"\\*\" between string and 1 results in an error\\.$#" + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Number.php + path: ../app/code/core/Mage/Adminhtml/Block/Notification/Window.php - - message: "#^Call to an undefined method Mage_Adminhtml_Block_Widget_Tab_Interface\\:\\:getSkipGenerateContent\\(\\)\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Widget/Tabs.php + path: ../app/code/core/Mage/Adminhtml/Block/Notification/Window.php - - message: "#^Call to an undefined method Mage_Adminhtml_Block_Widget_Tab_Interface\\:\\:getTabId\\(\\)\\.$#" + message: "#^Comparison operation \"\\=\\=\" between \\(Varien_Simplexml_Element\\|null\\) and 1 results in an error\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Widget/Tabs.php + path: ../app/code/core/Mage/Adminhtml/Block/Page/Menu.php - - message: "#^Call to an undefined method Mage_Adminhtml_Block_Widget_Tab_Interface\\:\\:toHtml\\(\\)\\.$#" + message: "#^Call to method getCollection\\(\\) on an unknown class Mage_Permissions_Model_Users\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Widget/Tabs.php + path: ../app/code/core/Mage/Adminhtml/Block/Permissions/Grid/User.php - - message: "#^PHPDoc tag @param references unknown parameter\\: \\$tabNId$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Widget/Tabs.php + message: "#^Call to an undefined method Varien_Data_Collection\\:\\:addFieldToFilter\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/Permissions/Role/Grid/User.php - - message: "#^Return type \\(Mage_Admin_Model_Session\\) of method Mage_Adminhtml_Controller_Report_Abstract\\:\\:_getSession\\(\\) should be compatible with return type \\(Mage_Adminhtml_Model_Session\\) of method Mage_Adminhtml_Controller_Action\\:\\:_getSession\\(\\)$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Controller/Report/Abstract.php + path: ../app/code/core/Mage/Adminhtml/Block/Permissions/Tab/Rolesedit.php - - message: "#^Method Mage_Adminhtml_Model_Config\\:\\:getSection\\(\\) should return Varien_Simplexml_Element but return statement is missing\\.$#" + message: "#^Call to an undefined method Mage_Admin_Model_Resource_Roles_User_Collection\\:\\:setUserFilter\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Model/Config.php + path: ../app/code/core/Mage/Adminhtml/Block/Permissions/Tab/Userroles.php - - message: "#^Property Mage_Adminhtml_Model_Config\\:\\:\\$_config \\(Mage_Core_Model_Config_Base\\) does not accept Varien_Simplexml_Config\\.$#" + message: "#^Call to an undefined method Varien_Data_Collection\\:\\:addFieldToFilter\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/Permissions/User/Edit/Tab/Roles.php + + - + message: "#^Call to method getCollection\\(\\) on an unknown class Mage_Permissions_Model_Roles\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Model/Config.php + path: ../app/code/core/Mage/Adminhtml/Block/Permissions/Usernroles.php - - message: "#^Property Varien_Simplexml_Config\\:\\:\\$_cacheChecksum \\(unknown_type\\) does not accept null\\.$#" + message: "#^Call to method getCollection\\(\\) on an unknown class Mage_Permissions_Model_Users\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Model/Config.php + path: ../app/code/core/Mage/Adminhtml/Block/Permissions/Usernroles.php - - message: "#^Call to an undefined method Mage_Adminhtml_Model_Config_Data\\:\\:__\\(\\)\\.$#" + message: "#^Variable \\$answerData might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Model/Config/Data.php + path: ../app/code/core/Mage/Adminhtml/Block/Poll/Answer/Edit.php - - message: "#^Property Mage_Adminhtml_Model_Config_Data\\:\\:\\$_configRoot \\(Mage_Core_Model_Config_Element\\) does not accept Varien_Simplexml_Element\\|false\\.$#" + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Model/Config/Data.php + path: ../app/code/core/Mage/Adminhtml/Block/Promo/Catalog/Edit/Tab/Main.php - - message: "#^Method Mage_Eav_Model_Entity_Abstract\\:\\:load\\(\\) invoked with 1 parameter, 2\\-3 required\\.$#" + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Model/Giftmessage/Save.php + path: ../app/code/core/Mage/Adminhtml/Block/Promo/Quote/Edit/Tab/Labels.php - - message: "#^Method Mage_Adminhtml_Model_Sales_Order_Create\\:\\:initFromOrderItem\\(\\) should return Mage_Sales_Model_Quote_Item\\|string but returns \\$this\\(Mage_Adminhtml_Model_Sales_Order_Create\\)\\.$#" + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 2 - path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + path: ../app/code/core/Mage/Adminhtml/Block/Promo/Quote/Edit/Tab/Main.php - - message: "#^Property Mage_Adminhtml_Model_Sales_Order_Create\\:\\:\\$_customerAddressForm \\(Mage_Customer_Model_Form\\) does not accept bool\\|Mage_Eav_Model_Form\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + message: "#^Parameter \\#3 \\$refValues of method Mage_Adminhtml_Block_Widget_Form_Element_Dependence\\:\\:addFieldDependence\\(\\) expects array\\|string, int given\\.$#" + count: 3 + path: ../app/code/core/Mage/Adminhtml/Block/Promo/Quote/Edit/Tab/Main.php - - message: "#^Property Mage_Adminhtml_Model_Sales_Order_Create\\:\\:\\$_customerForm \\(Mage_Customer_Model_Form\\) does not accept bool\\|Mage_Eav_Model_Form\\.$#" + message: "#^Parameter \\#1 \\$separator of function explode expects non\\-empty\\-string, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + path: ../app/code/core/Mage/Adminhtml/Block/Promo/Widget/Chooser/Daterange.php - - message: "#^Property Mage_Adminhtml_Model_Sales_Order_Create\\:\\:\\$_wishlist \\(Mage_Wishlist_Model_Wishlist\\) does not accept false\\.$#" + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + path: ../app/code/core/Mage/Adminhtml/Block/Rating/Edit/Tab/Form.php - - message: "#^Variable \\$billingAddress might not be defined\\.$#" - count: 2 - path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + message: "#^Parameter \\#1 \\$hour of function mktime expects int, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Report/Config/Form/Field/YtdStart.php - - message: "#^Variable \\$shippingAddress might not be defined\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Grid.php - - message: "#^Call to an undefined method Mage_Sales_Model_Order\\:\\:createFromQuoteAddress\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$collection of method Mage_Adminhtml_Block_Widget_Grid\\:\\:setCollection\\(\\) expects Varien_Data_Collection, Mage_Reports_Model_Resource_Report_Collection given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Random.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Grid.php - - message: "#^Call to an undefined method Mage_Sales_Model_Order\\:\\:validate\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$from of method Mage_Reports_Model_Resource_Report_Collection\\:\\:setInterval\\(\\) expects int, Zend_Date given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Random.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Grid.php - - message: "#^Call to an undefined method Mage_Sales_Model_Quote\\:\\:addCatalogProduct\\(\\)\\.$#" + message: "#^Parameter \\#2 \\$to of method Mage_Reports_Model_Resource_Report_Collection\\:\\:setInterval\\(\\) expects int, Zend_Date given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Random.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Grid.php - - message: "#^Cannot access offset 'file' on bool\\|void\\.$#" + message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Report_Grid\\:\\:_prepareCollection\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:_prepareCollection\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Model/System/Config/Backend/File.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Grid.php - - message: "#^Comparison operation \"\\=\\=\" between \\(Varien_Simplexml_Element\\|null\\) and 1 results in an error\\.$#" + message: "#^Call to an undefined method Mage_Reports_Model_Resource_Report_Collection_Abstract\\:\\:addOrderStatusFilter\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Model/System/Config/Source/Admin/Page.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php - - message: "#^Method Varien_Data_Collection\\:\\:toOptionArray\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Call to function is_null\\(\\) with Varien_Data_Collection will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Model/System/Config/Source/Country.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php - - message: "#^Method Mage_Adminhtml_Model_System_Store\\:\\:__construct\\(\\) with return type void returns \\$this\\(Mage_Adminhtml_Model_System_Store\\) but should not return anything\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Model/System/Store.php + message: "#^Cannot call method setPeriod\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + count: 4 + path: ../app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php - - message: "#^Variable \\$values might not be defined\\.$#" + message: "#^Method Mage_Adminhtml_Block_Report_Grid_Abstract\\:\\:addColumn\\(\\) should return Mage_Adminhtml_Block_Report_Grid_Abstract but returns Mage_Adminhtml_Block_Widget_Grid\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/Model/System/Store.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" + message: "#^Method Mage_Adminhtml_Block_Report_Grid_Abstract\\:\\:getCollection\\(\\) should return Mage_Reports_Model_Grouped_Collection but returns Varien_Data_Collection\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php - - message: "#^Return type \\(Mage_Adminhtml_Helper_Catalog_Product_Edit_Action_Attribute\\) of method Mage_Adminhtml_Catalog_Product_Action_AttributeController\\:\\:_getHelper\\(\\) should be compatible with return type \\(Mage_Adminhtml_Helper_Data\\) of method Mage_Adminhtml_Controller_Action\\:\\:_getHelper\\(\\)$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php - - message: "#^Cannot access offset 'tmp_name' on bool\\|void\\.$#" - count: 2 - path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/Product/GalleryController.php + message: "#^Parameter \\#2 \\$value of method Mage_Adminhtml_Block_Widget_Grid\\:\\:isColumnGrouped\\(\\) expects string\\|null, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php - - message: "#^Offset 'file' does not exist on array\\{path\\: \\(array\\|string\\), url\\: string\\}\\.$#" + message: "#^Property Mage_Adminhtml_Block_Report_Grid_Abstract\\:\\:\\$_columnGroupBy \\(string\\) in isset\\(\\) is not nullable\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/Product/GalleryController.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php - - message: "#^Offset 'file' does not exist on array\\{path\\: \\(array\\|string\\)\\}\\.$#" + message: "#^Parameter \\#1 \\$value of method Zend_Currency\\:\\:toCurrency\\(\\) expects float\\|int\\|null, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/Product/GalleryController.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Grid/Column/Renderer/Currency.php - - message: "#^Method Mage_Adminhtml_Controller_Action\\:\\:_setForcedFormKeyActions\\(\\) invoked with 2 parameters, 1 required\\.$#" + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:setStore\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/SearchController.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Product/Grid.php - - message: "#^Property Mage_Adminhtml_Customer_Wishlist_Product_Composite_WishlistController\\:\\:\\$_wishlistItem \\(Mage_Wishlist_Model_Wishlist\\) does not accept Mage_Wishlist_Model_Item\\.$#" + message: "#^Method Mage_Reports_Model_Totals\\:\\:countTotals\\(\\) invoked with 1 parameter, 3 required\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Customer/Wishlist/Product/Composite/WishlistController.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Product/Grid.php - - message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:getClassName\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$grid of method Mage_Reports_Model_Totals\\:\\:countTotals\\(\\) expects Mage_Adminhtml_Block_Report_Grid, \\$this\\(Mage_Adminhtml_Block_Report_Product_Grid\\) given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/IndexController.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Product/Grid.php - - message: "#^Variable \\$id in isset\\(\\) always exists and is not nullable\\.$#" + message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Report_Product_Grid\\:\\:_afterLoadCollection\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:_afterLoadCollection\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Permissions/BlockController.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Product/Grid.php - - message: "#^Variable \\$id in isset\\(\\) always exists and is not nullable\\.$#" + message: "#^Parameter \\#1 \\$fields of method Mage_Reports_Model_Resource_Product_Lowstock_Collection\\:\\:joinInventoryItem\\(\\) expects array, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Permissions/VariableController.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Product/Lowstock/Grid.php - - message: "#^Cannot call method aggregate\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" - count: 2 - path: ../app/code/core/Mage/Adminhtml/controllers/Report/StatisticsController.php + message: "#^Call to an undefined method Mage_Reports_Model_Resource_Report_Collection_Abstract\\:\\:addRuleFilter\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Report/Sales/Coupons/Grid.php - - message: "#^Return type \\(Mage_Admin_Model_Session\\) of method Mage_Adminhtml_Report_StatisticsController\\:\\:_getSession\\(\\) should be compatible with return type \\(Mage_Adminhtml_Model_Session\\) of method Mage_Adminhtml_Controller_Action\\:\\:_getSession\\(\\)$#" + message: "#^Parameter \\#1 \\$collection of method Mage_Adminhtml_Block_Report_Grid_Abstract\\:\\:_addCustomFilter\\(\\) expects Mage_Reports_Model_Resource_Report_Collection_Abstract, Varien_Object given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Report/StatisticsController.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Sales/Coupons/Grid.php - - message: "#^Method Mage_Adminhtml_Model_Sales_Order_Create\\:\\:moveQuoteItem\\(\\) invoked with 2 parameters, 3 required\\.$#" + message: "#^Parameter \\#2 \\$filterData of method Mage_Adminhtml_Block_Report_Grid_Abstract\\:\\:_addCustomFilter\\(\\) expects Varien_Object, Mage_Reports_Model_Resource_Report_Collection_Abstract given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreateController.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Sales/Coupons/Grid.php - - message: "#^Method Mage_Adminhtml_Model_Sales_Order_Create\\:\\:resetShippingMethod\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Parameter \\#2 \\$filter of method Mage_Reports_Model_Resource_Quote_Collection\\:\\:prepareForAbandonedReport\\(\\) expects string\\|null, array\\\\|string\\> given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreateController.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Shopcart/Abandoned/Grid.php - - message: "#^Return type \\(Mage_Adminhtml_Model_Session_Quote\\) of method Mage_Adminhtml_Sales_Order_CreateController\\:\\:_getSession\\(\\) should be compatible with return type \\(Mage_Adminhtml_Model_Session\\) of method Mage_Adminhtml_Controller_Action\\:\\:_getSession\\(\\)$#" + message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Report_Shopcart_Customer_Grid\\:\\:_afterLoadCollection\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:_afterLoadCollection\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreateController.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Shopcart/Customer/Grid.php - - message: "#^Call to an undefined method Mage_Sales_Model_Order_Creditmemo\\:\\:void\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$statusCode of method Mage_Tag_Model_Resource_Popular_Collection\\:\\:addStatusFilter\\(\\) expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreditmemoController.php + path: ../app/code/core/Mage/Adminhtml/Block/Report/Tag/Popular/Grid.php - - message: "#^Undefined variable\\: \\$shippingResponse$#" + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/InvoiceController.php + path: ../app/code/core/Mage/Adminhtml/Block/Review/Add/Form.php - - message: "#^Variable \\$shippingResponse in isset\\(\\) is never defined\\.$#" + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/InvoiceController.php + path: ../app/code/core/Mage/Adminhtml/Block/Review/Edit/Form.php - - message: "#^Method Mage_Adminhtml_Sales_Order_ShipmentController\\:\\:getShippingItemsGridAction\\(\\) should return Mage_Core_Controller_Response_Http but returns Zend_Controller_Response_Abstract\\.$#" + message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Review_Grid\\:\\:_prepareMassaction\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:_prepareMassaction\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php + path: ../app/code/core/Mage/Adminhtml/Block/Review/Grid.php - - message: "#^Method Mage_Adminhtml_Controller_Action\\:\\:_setForcedFormKeyActions\\(\\) invoked with 2 parameters, 1 required\\.$#" + message: "#^Return type \\(int\\) of method Mage_Adminhtml_Block_Review_Grid_Filter_Type\\:\\:getCondition\\(\\) should be compatible with return type \\(array\\|null\\) of method Mage_Adminhtml_Block_Widget_Grid_Column_Filter_Select\\:\\:getCondition\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php + path: ../app/code/core/Mage/Adminhtml/Block/Review/Grid/Filter/Type.php - - message: "#^Variable \\$pdf might not be defined\\.$#" - count: 4 - path: ../app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php + message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Review_Product_Grid\\:\\:_prepareColumns\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Catalog_Product_Grid\\:\\:_prepareColumns\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Review/Product/Grid.php - - message: "#^Variable \\$data in isset\\(\\) always exists and is not nullable\\.$#" + message: "#^Parameter \\#1 \\$storeId of method Mage_Rating_Model_Resource_Rating_Collection\\:\\:setStoreFilter\\(\\) expects int, array given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/System/Convert/ProfileController.php + path: ../app/code/core/Mage/Adminhtml/Block/Review/Rating/Detailed.php - - message: "#^Cannot call method fetchRates\\(\\) on Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/System/CurrencyController.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Items/Abstract.php - - message: "#^Method Mage_Adminhtml_System_StoreController\\:\\:_backupDatabase\\(\\) should return \\$this\\(Mage_Adminhtml_System_StoreController\\) but empty return statement found\\.$#" - count: 2 - path: ../app/code/core/Mage/Adminhtml/controllers/System/StoreController.php + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Items/Abstract.php - - message: "#^Variable \\$codeBase might not be defined\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/System/StoreController.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Comments/View.php - - message: "#^Variable \\$itemId might not be defined\\.$#" + message: "#^Method Mage_Adminhtml_Block_Sales_Order_Create_Billing_Address\\:\\:getAddress\\(\\) should return Mage_Customer_Model_Address but returns Mage_Sales_Model_Quote_Address\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/System/StoreController.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Billing/Address.php - - message: "#^Variable \\$model might not be defined\\.$#" - count: 5 - path: ../app/code/core/Mage/Adminhtml/controllers/System/StoreController.php + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Billing/Method/Form.php - - message: "#^Variable \\$notExists might not be defined\\.$#" + message: "#^Parameter \\#1 \\$currency of method Mage_Directory_Model_Currency\\:\\:getCurrencyRates\\(\\) expects string, Mage_Directory_Model_Currency given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/System/StoreController.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Data.php - - message: "#^Variable \\$title might not be defined\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/System/StoreController.php + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" + count: 5 + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form.php - - message: "#^Method Mage_Directory_Model_Country\\:\\:loadByCode\\(\\) invoked with 2 parameters, 1 required\\.$#" + message: "#^Call to function is_null\\(\\) with Varien_Data_Form will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Tax/RateController.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Abstract.php - - message: "#^Method Mage_Adminhtml_Tax_RuleController\\:\\:saveAction\\(\\) should return Mage_Core_Controller_Response_Http\\|Mage_Core_Controller_Varien_Action but return statement is missing\\.$#" + message: "#^Parameter \\#1 \\$renderer of static method Varien_Data_Form\\:\\:setElementRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Tax/RuleController.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Abstract.php - - message: "#^Method Mage_Adminhtml_Tax_RuleController\\:\\:saveAction\\(\\) should return Mage_Core_Controller_Response_Http\\|Mage_Core_Controller_Varien_Action but returns Zend_Controller_Response_Abstract\\.$#" + message: "#^Parameter \\#1 \\$renderer of static method Varien_Data_Form\\:\\:setFieldsetElementRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Tax/RuleController.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Abstract.php - - message: "#^Method Mage_Api_Model_Acl\\:\\:_getRoleRegistry\\(\\) should return Mage_Api_Model_Acl_Role_Registry but returns Zend_Acl_Role_Registry\\.$#" + message: "#^Parameter \\#1 \\$renderer of static method Varien_Data_Form\\:\\:setFieldsetRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Acl.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Abstract.php - - message: "#^Return type \\(Zend_Cache_Core\\) of method Mage_Api_Model_Config\\:\\:getCache\\(\\) should be compatible with return type \\(Varien_Simplexml_Config_Cache_Abstract\\) of method Varien_Simplexml_Config\\:\\:getCache\\(\\)$#" + message: "#^Call to function is_null\\(\\) with Mage_Customer_Model_Form will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Config.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Address.php - - message: "#^Cannot call method getClassName\\(\\) on bool\\|SimpleXMLElement\\.$#" - count: 1 - path: ../app/code/core/Mage/Api/Model/Resource/Acl.php + message: "#^If condition is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Address.php - - message: "#^Method Mage_Core_Model_Resource_Db_Abstract\\:\\:load\\(\\) invoked with 1 parameter, 2\\-3 required\\.$#" + message: "#^Parameter \\#1 \\$addressId of method Mage_Customer_Model_Customer\\:\\:getAddressById\\(\\) expects int, null given\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Resource/Roles.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Address.php - - message: "#^Return type \\(bool\\) of method Mage_Api_Model_Resource_User\\:\\:delete\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Resource_Db_Abstract\\)\\) of method Mage_Core_Model_Resource_Db_Abstract\\:\\:delete\\(\\)$#" - count: 1 - path: ../app/code/core/Mage/Api/Model/Resource/User.php + message: "#^Parameter \\#4 \\$after of method Varien_Data_Form_Element_Fieldset\\:\\:addField\\(\\) expects bool, string given\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Address.php - - message: "#^Call to an undefined method Mage_Api_Model_Resource_Roles\\:\\:update\\(\\)\\.$#" + message: "#^Property Mage_Adminhtml_Block_Sales_Order_Create_Form_Address\\:\\:\\$_addressForm \\(Mage_Customer_Model_Form\\) does not accept Mage_Eav_Model_Form\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Roles.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Address.php - - message: "#^Call to an undefined method Mage_Api_Model_Resource_Rules\\:\\:update\\(\\)\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_GiftMessage_Model_Message will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Rules.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage/Form.php - - message: "#^Call to an undefined method SoapServer\\:\\:setReturnResponse\\(\\)\\.$#" + message: "#^Method Mage_Adminhtml_Block_Sales_Order_Create_Giftmessage_Form\\:\\:getEntity\\(\\) should return Varien_Object but returns Mage_Eav_Model_Entity_Abstract\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Server/Adapter/Soap.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage/Form.php - - message: "#^Property Mage_Api_Model_Server_Adapter_Soap\\:\\:\\$_soap \\(SoapServer\\) does not accept Zend_Soap_Server\\.$#" + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage/Form.php + + - + message: "#^Property Mage_Adminhtml_Block_Sales_Order_Create_Giftmessage_Form\\:\\:\\$_entity \\(Mage_Eav_Model_Entity_Abstract\\) does not accept Varien_Object\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Server/Adapter/Soap.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage/Form.php - - message: "#^Result of method SoapServer\\:\\:handle\\(\\) \\(void\\) is used\\.$#" + message: "#^Call to function is_null\\(\\) with 0 will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Server/Adapter/Soap.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Header.php - - message: "#^Return type \\(Varien_Object\\) of method Mage_Api_Model_Server_Adapter_Soap\\:\\:getController\\(\\) should be compatible with return type \\(Mage_Api_Controller_Action\\) of method Mage_Api_Model_Server_Adapter_Interface\\:\\:getController\\(\\)$#" + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Server/Adapter/Soap.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Header.php - - message: "#^Access to an undefined property object\\:\\:\\$model\\.$#" + message: "#^Argument of an invalid type float supplied for foreach, only iterables are supported\\.$#" count: 2 - path: ../app/code/core/Mage/Api/Model/Server/Handler/Abstract.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Items/Grid.php - - message: "#^Method Mage_Api_Model_Session\\:\\:isSessionExpired\\(\\) invoked with 0 parameters, 1 required\\.$#" + message: "#^Parameter \\#1 \\$optionId of method Mage_Catalog_Model_Product\\:\\:getOptionById\\(\\) expects int, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Server/Handler/Abstract.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Items/Grid.php - - message: "#^Result of method SoapServer\\:\\:handle\\(\\) \\(void\\) is used\\.$#" + message: "#^Undefined variable\\: \\$info$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Server/V2/Adapter/Soap.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Items/Grid.php - - message: "#^Return type \\(Mage_Api_Model_Wsdl_Config\\) of method Mage_Api_Model_Server_V2_Adapter_Soap\\:\\:_getWsdlConfig\\(\\) should be compatible with return type \\(Varien_Object\\) of method Mage_Api_Model_Server_Adapter_Soap\\:\\:_getWsdlConfig\\(\\)$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Server/V2/Adapter/Soap.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Items/Grid.php - - message: "#^Result of method SoapServer\\:\\:handle\\(\\) \\(void\\) is used\\.$#" + message: "#^Call to method getIsOldCustomer\\(\\) on an unknown class Mage_Adminhtml_Model_Quote\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Server/Wsi/Adapter/Soap.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Newsletter.php - - message: "#^Return type \\(Mage_Api_Model_Wsdl_Config\\) of method Mage_Api_Model_Server_Wsi_Adapter_Soap\\:\\:_getWsdlConfig\\(\\) should be compatible with return type \\(Varien_Object\\) of method Mage_Api_Model_Server_Adapter_Soap\\:\\:_getWsdlConfig\\(\\)$#" + message: "#^Method Mage_Adminhtml_Block_Sales_Order_Create_Shipping_Address\\:\\:getAddress\\(\\) should return Mage_Customer_Model_Address but returns Mage_Sales_Model_Quote_Address\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Server/Wsi/Adapter/Soap.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Shipping/Address.php - - message: "#^Parameter \\#1 \\$request \\(stdClass\\) of method Mage_Api_Model_Server_Wsi_Handler\\:\\:endSession\\(\\) should be compatible with parameter \\$sessionId \\(string\\) of method Mage_Api_Model_Server_Handler_Abstract\\:\\:endSession\\(\\)$#" + message: "#^Variable \\$button might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Server/Wsi/Handler.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar.php - - message: "#^Return type \\(stdClass\\) of method Mage_Api_Model_Server_Wsi_Handler\\:\\:endSession\\(\\) should be compatible with return type \\(true\\) of method Mage_Api_Model_Server_Handler_Abstract\\:\\:endSession\\(\\)$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Server/Wsi/Handler.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Compared.php - - message: "#^Return type \\(stdClass\\) of method Mage_Api_Model_Server_Wsi_Handler\\:\\:login\\(\\) should be compatible with return type \\(string\\) of method Mage_Api_Model_Server_Handler_Abstract\\:\\:login\\(\\)$#" + message: "#^Method Mage_Catalog_Model_Resource_Product_Compare_Item_Collection\\:\\:useProductItem\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Server/Wsi/Handler.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Compared.php - - message: "#^Return type \\(bool\\) of method Mage_Api_Model_Session\\:\\:clear\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Session_Abstract_Varien\\)\\) of method Mage_Core_Model_Session_Abstract_Varien\\:\\:clear\\(\\)$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Session.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Pcompared.php - - message: "#^Return type \\(void\\) of method Mage_Api_Model_Session\\:\\:revalidateCookie\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Session_Abstract_Varien\\)\\) of method Mage_Core_Model_Session_Abstract_Varien\\:\\:revalidateCookie\\(\\)$#" + message: "#^Method Mage_Catalog_Model_Resource_Product_Compare_Item_Collection\\:\\:useProductItem\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Session.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Pcompared.php - - message: "#^Invalid array key type array\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Wsdl/Config.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Wishlist.php - - message: "#^Call to an undefined method SimpleXMLElement\\:\\:extendChild\\(\\)\\.$#" + message: "#^Call to an undefined method Mage_Adminhtml_Block_Sales_Order_Creditmemo_Create_Adjustments\\:\\:addTotal\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Api/Model/Wsdl/Config/Element.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/Create/Adjustments.php - - message: "#^Return type \\(array\\) of method Mage_Api_Model_Wsdl_Config_Element\\:\\:getChildren\\(\\) should be compatible with return type \\(RecursiveIterator\\|null\\) of method RecursiveIterator\\\\:\\:getChildren\\(\\)$#" - count: 1 - path: ../app/code/core/Mage/Api/Model/Wsdl/Config/Element.php + message: "#^Call to an undefined method Mage_Adminhtml_Block_Sales_Order_Creditmemo_Create_Adjustments\\:\\:removeTotal\\(\\)\\.$#" + count: 3 + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/Create/Adjustments.php - - message: "#^Return type \\(void\\) of method Mage_Api2_Block_Adminhtml_Attribute_Grid\\:\\:_prepareCollection\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:_prepareCollection\\(\\)$#" + message: "#^Return type \\(Mage_Sales_Model_Order_Creditmemo\\) of method Mage_Adminhtml_Block_Sales_Order_Creditmemo_Create_Items\\:\\:getSource\\(\\) should be compatible with return type \\(Mage_Sales_Model_Order_Invoice\\) of method Mage_Adminhtml_Block_Sales_Items_Abstract\\:\\:getSource\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Api2/Block/Adminhtml/Attribute/Grid.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/Create/Items.php - - message: "#^Property Mage_Api2_Block_Adminhtml_Attribute_Tab_Resource\\:\\:\\$_treeModel \\(Mage_Api2_Model_Acl_Global_Rule_Tree\\) does not accept default value of type false\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Api2/Block/Adminhtml/Attribute/Tab/Resource.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/Totals.php - - message: "#^Call to an undefined method Varien_Data_Collection\\:\\:addFieldToFilter\\(\\)\\.$#" - count: 2 - path: ../app/code/core/Mage/Api2/Block/Adminhtml/Permissions/User/Edit/Tab/Roles.php + message: "#^If condition is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/View.php - - message: "#^Property Mage_Api2_Block_Adminhtml_Roles_Tab_Resources\\:\\:\\$_treeModel \\(Mage_Api2_Model_Acl_Global_Rule_Tree\\) does not accept default value of type false\\.$#" + message: "#^Return type \\(Mage_Sales_Model_Order_Creditmemo\\) of method Mage_Adminhtml_Block_Sales_Order_Creditmemo_View_Items\\:\\:getSource\\(\\) should be compatible with return type \\(Mage_Sales_Model_Order_Invoice\\) of method Mage_Adminhtml_Block_Sales_Items_Abstract\\:\\:getSource\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Api2/Block/Adminhtml/Roles/Tab/Resources.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/View/Items.php - - message: "#^Cannot access offset 'order' on int\\.$#" - count: 4 - path: ../app/code/core/Mage/Api2/Helper/Data.php + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Payment.php - - message: "#^Variable \\$adapters might not be defined\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Api2/Helper/Data.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Create/Items.php - - message: "#^Parameter \\#1 \\$roleId \\(int\\) of method Mage_Api2_Model_Acl\\:\\:addRole\\(\\) should be compatible with parameter \\$role \\(string\\|Zend_Acl_Role_Interface\\) of method Zend_Acl\\:\\:addRole\\(\\)$#" + message: "#^Return type \\(Mage_Sales_Model_Order_Shipment\\) of method Mage_Adminhtml_Block_Sales_Order_Shipment_Create_Items\\:\\:getSource\\(\\) should be compatible with return type \\(Mage_Sales_Model_Order_Invoice\\) of method Mage_Adminhtml_Block_Sales_Items_Abstract\\:\\:getSource\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Api2/Model/Acl.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Create/Items.php - - message: "#^Method Mage_Api2_Model_Acl_Global_Rule_ResourcePermission\\:\\:setFilterValue\\(\\) should return Mage_Api2_Model_Acl_PermissionInterface but return statement is missing\\.$#" + message: "#^Call to an undefined method Mage_Shipping_Model_Carrier_Abstract\\:\\:isGirthAllowed\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Api2/Model/Acl/Global/Rule/ResourcePermission.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - message: "#^Variable \\$operationName might not be defined\\.$#" - count: 2 - path: ../app/code/core/Mage/Api2/Model/Acl/Global/Rule/Tree.php + message: "#^If condition is always true\\.$#" + count: 5 + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - message: "#^Method Mage_Api2_Model_Config\\:\\:getResourceGroup\\(\\) should return bool\\|Mage_Core_Model_Config_Element but returns Varien_Simplexml_Element\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Api2/Model/Config.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - message: "#^Call to an undefined method Mage_Api2_Model_Config\\:\\:getMainRoute\\(\\)\\.$#" + message: "#^Method Mage_Adminhtml_Block_Sales_Order_Shipment_Packaging\\:\\:getQtyOrderedItem\\(\\) should return int\\|null but empty return statement found\\.$#" count: 1 - path: ../app/code/core/Mage/Api2/Model/Multicall.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - message: "#^Property Mage_Api2_Model_Request\\:\\:\\$_interpreter \\(Mage_Api2_Model_Request_Interpreter_Interface\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" - count: 1 - path: ../app/code/core/Mage/Api2/Model/Request.php + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 6 + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - message: "#^Call to an undefined method Mage_Api2_Model_Resource\\:\\:_multiDelete\\(\\)\\.$#" + message: "#^Variable \\$createLabelUrl might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Api2/Model/Resource.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - message: "#^Method Mage_Api2_Model_Resource\\:\\:_create\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Variable \\$itemsGridUrl might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Api2/Model/Resource.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - message: "#^Method Mage_Api2_Model_Resource\\:\\:_getSubModel\\(\\) should return \\$this\\(Mage_Api2_Model_Resource\\) but returns Mage_Api2_Model_Resource\\.$#" + message: "#^Variable \\$itemsOrderItemId might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Api2/Model/Resource.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - message: "#^Method Mage_Api2_Model_Resource\\:\\:_multiCreate\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Api2/Model/Resource.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/View/Form.php - - message: "#^Method Mage_Api2_Model_Resource\\:\\:_multiUpdate\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Return type \\(Mage_Sales_Model_Order_Shipment\\) of method Mage_Adminhtml_Block_Sales_Order_Shipment_View_Items\\:\\:getSource\\(\\) should be compatible with return type \\(Mage_Sales_Model_Order_Invoice\\) of method Mage_Adminhtml_Block_Sales_Items_Abstract\\:\\:getSource\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Api2/Model/Resource.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/View/Items.php - - message: "#^Method Mage_Api2_Model_Resource\\:\\:_update\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Api2/Model/Resource.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/View/Tracking.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Api2/Model/Resource/Validator/Eav.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Status/New/Form.php - - message: "#^Property Mage_Api2_Model_Resource_Validator_Eav\\:\\:\\$_eavForm \\(Mage_Eav_Model_Form\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Api2/Model/Resource/Validator/Eav.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Totalbar.php - - message: "#^Call to an undefined method Zend_Validate_Interface\\:\\:setMessage\\(\\)\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_GiftMessage_Model_Message will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Api2/Model/Resource/Validator/Fields.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Giftmessage.php - - message: "#^Method Mage_Api2_Model_Response\\:\\:setMimeType\\(\\) should return \\$this\\(Mage_Api2_Model_Response\\) but returns Zend_Controller_Response_Abstract\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Order will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Api2/Model/Response.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Giftmessage.php - - message: "#^Parameter \\#1 \\$request \\(Mage_Api2_Model_Request\\) of method Mage_Api2_Model_Route_Abstract\\:\\:match\\(\\) should be compatible with parameter \\$path \\(string\\) of method Zend_Controller_Router_Route\\:\\:match\\(\\)$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Api2/Model/Route/Abstract.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Giftmessage.php - - message: "#^Constructor of class Mage_Api2_Model_Route_ApiType has an unused parameter \\$defaults\\.$#" - count: 1 - path: ../app/code/core/Mage/Api2/Model/Route/ApiType.php + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Giftmessage.php - - message: "#^Constructor of class Mage_Api2_Model_Route_ApiType has an unused parameter \\$locale\\.$#" + message: "#^Parameter \\#1 \\$entity of method Mage_Adminhtml_Block_Sales_Order_View_Giftmessage\\:\\:setEntity\\(\\) expects Mage_Sales_Model_Order, Mage_Eav_Model_Entity_Abstract given\\.$#" count: 1 - path: ../app/code/core/Mage/Api2/Model/Route/ApiType.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Giftmessage.php - - message: "#^Constructor of class Mage_Api2_Model_Route_ApiType has an unused parameter \\$reqs\\.$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Api2/Model/Route/ApiType.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Giftmessage.php - - message: "#^Constructor of class Mage_Api2_Model_Route_ApiType has an unused parameter \\$route\\.$#" - count: 1 - path: ../app/code/core/Mage/Api2/Model/Route/ApiType.php + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Info.php - - message: "#^Constructor of class Mage_Api2_Model_Route_ApiType has an unused parameter \\$translator\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Api2/Model/Route/ApiType.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Info.php - - message: "#^Call to an undefined method Varien_Object\\:\\:decrypt\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$entityType of method Mage_Eav_Model_Config\\:\\:getEntityAttributeCodes\\(\\) expects Mage_Eav_Model_Entity_Type, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Authorizenet/Model/Directpost.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Info.php - - message: "#^Call to an undefined method Varien_Object\\:\\:encrypt\\(\\)\\.$#" - count: 1 - path: ../app/code/core/Mage/Authorizenet/Model/Directpost.php + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Info.php - - message: "#^Method Mage_Authorizenet_Model_Directpost\\:\\:initialize\\(\\) should return \\$this\\(Mage_Authorizenet_Model_Directpost\\) but return statement is missing\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Authorizenet/Model/Directpost.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Items.php - - message: "#^Return type \\(bool\\) of method Mage_Authorizenet_Model_Directpost\\:\\:validate\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Cc\\)\\) of method Mage_Payment_Model_Method_Cc\\:\\:validate\\(\\)$#" + message: "#^Parameter \\#1 \\$item of method Mage_Checkout_Helper_Data\\:\\:getBasePriceInclTax\\(\\) expects Mage_Core_Model_Abstract, Varien_Object given\\.$#" count: 1 - path: ../app/code/core/Mage/Authorizenet/Model/Directpost.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Items/Renderer/Default.php - - message: "#^Return type \\(void\\) of method Mage_Authorizenet_Model_Directpost\\:\\:authorize\\(\\) should be compatible with return type \\(\\$this\\(Mage_Paygate_Model_Authorizenet\\)\\) of method Mage_Paygate_Model_Authorizenet\\:\\:authorize\\(\\)$#" + message: "#^Parameter \\#1 \\$item of method Mage_Checkout_Helper_Data\\:\\:getPriceInclTax\\(\\) expects Mage_Core_Model_Abstract, Varien_Object given\\.$#" count: 1 - path: ../app/code/core/Mage/Authorizenet/Model/Directpost.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Items/Renderer/Default.php - - message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:generateRequestFromOrder\\(\\)\\.$#" + message: "#^Property Mage_Adminhtml_Block_Sales_Order_View_Items_Renderer_Default\\:\\:\\$_giftMessage \\(Mage_GiftMessage_Model_Message\\) does not accept default value of type array\\.$#" count: 1 - path: ../app/code/core/Mage/Authorizenet/Model/Directpost/Observer.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Items/Renderer/Default.php - - message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:generateRequestFromOrder\\(\\)\\.$#" + message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:setOrderFilter\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Authorizenet/controllers/Adminhtml/Authorizenet/Directpost/PaymentController.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Tab/Creditmemos.php - - message: "#^Method Mage_Authorizenet_Directpost_PaymentController\\:\\:_getIframeBlock\\(\\) should return Mage_Authorizenet_Block_Directpost_Iframe but returns Mage_Core_Block_Abstract\\|false\\.$#" + message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:setOrderFilter\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Authorizenet/controllers/Directpost/PaymentController.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Tab/Invoices.php - - message: "#^Variable \\$params might not be defined\\.$#" + message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:setOrderFilter\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Authorizenet/controllers/Directpost/PaymentController.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Tab/Shipments.php - - message: "#^Method Mage_Backup_Helper_Data\\:\\:getCreateSuccessMessageByType\\(\\) should return string but empty return statement found\\.$#" + message: "#^Parameter \\#1 \\$order of method Mage_Sales_Helper_Reorder\\:\\:canReorder\\(\\) expects Mage_Sales_Model_Order, Varien_Object given\\.$#" count: 1 - path: ../app/code/core/Mage/Backup/Helper/Data.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Reorder/Renderer/Action.php - - message: "#^Property Mage_Backup_Model_Backup\\:\\:\\$_handler \\(resource\\) does not accept null\\.$#" + message: "#^Ternary operator condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Backup/Model/Backup.php + path: ../app/code/core/Mage/Adminhtml/Block/Sales/Transactions/Grid.php - - message: "#^Variable \\$filePath might not be defined\\.$#" - count: 4 - path: ../app/code/core/Mage/Backup/Model/Backup.php + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Shipping/Carrier/Tablerate/Grid.php - - message: "#^Call to an undefined method Mage_Backup_Interface\\:\\:setRootDir\\(\\)\\.$#" + message: "#^Property Mage_Adminhtml_Block_Shipping_Carrier_Tablerate_Grid\\:\\:\\$_conditionName \\(string\\) does not accept int\\.$#" count: 1 - path: ../app/code/core/Mage/Backup/Model/Observer.php + path: ../app/code/core/Mage/Adminhtml/Block/Shipping/Carrier/Tablerate/Grid.php - - message: "#^Property Mage_Backup_Model_Resource_Db\\:\\:\\$_write \\(Varien_Db_Adapter_Pdo_Mysql\\) does not accept Varien_Db_Adapter_Interface\\|false\\.$#" + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Backup/Model/Resource/Db.php + path: ../app/code/core/Mage/Adminhtml/Block/Sitemap/Edit/Form.php - - message: "#^Parameter \\#1 \\$elementId \\(string\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Composite_Fieldset_Options_Type_Checkbox\\:\\:setValidationContainer\\(\\) should be compatible with parameter \\$elementId \\(int\\) of method Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option\\:\\:setValidationContainer\\(\\)$#" + message: "#^Property Mage_Adminhtml_Block_Store_Switcher_Form_Renderer_Fieldset\\:\\:\\$_element \\(Varien_Data_Form_Element_Fieldset\\) does not accept Varien_Data_Form_Element_Abstract\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Composite/Fieldset/Options/Type/Checkbox.php + path: ../app/code/core/Mage/Adminhtml/Block/Store/Switcher/Form/Renderer/Fieldset.php - - message: "#^Parameter \\#2 \\$containerId \\(string\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Composite_Fieldset_Options_Type_Checkbox\\:\\:setValidationContainer\\(\\) should be compatible with parameter \\$containerId \\(int\\) of method Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option\\:\\:setValidationContainer\\(\\)$#" + message: "#^Property Mage_Adminhtml_Block_Store_Switcher_Form_Renderer_Fieldset_Element\\:\\:\\$_element \\(Varien_Data_Form_Element_Fieldset\\) does not accept Varien_Data_Form_Element_Abstract\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Composite/Fieldset/Options/Type/Checkbox.php + path: ../app/code/core/Mage/Adminhtml/Block/Store/Switcher/Form/Renderer/Fieldset/Element.php - - message: "#^Parameter \\#1 \\$elementId \\(string\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Composite_Fieldset_Options_Type_Multi\\:\\:setValidationContainer\\(\\) should be compatible with parameter \\$elementId \\(int\\) of method Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option\\:\\:setValidationContainer\\(\\)$#" + message: "#^Cannot call method initForm\\(\\) on Mage_Core_Block_Abstract\\|false\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Composite/Fieldset/Options/Type/Multi.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Config/Edit.php - - message: "#^Parameter \\#2 \\$containerId \\(string\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Composite_Fieldset_Options_Type_Multi\\:\\:setValidationContainer\\(\\) should be compatible with parameter \\$containerId \\(int\\) of method Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option\\:\\:setValidationContainer\\(\\)$#" + message: "#^Call to an undefined method Mage_Core_Model_Abstract\\:\\:toOptionArray\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Composite/Fieldset/Options/Type/Multi.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Config/Form.php - - message: "#^Parameter \\#1 \\$elementId \\(string\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Composite_Fieldset_Options_Type_Radio\\:\\:setValidationContainer\\(\\) should be compatible with parameter \\$elementId \\(int\\) of method Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option\\:\\:setValidationContainer\\(\\)$#" + message: "#^Comparison operation \"\\=\\=\" between \\(Mage_Core_Model_Config_Element\\|null\\) and 1 results in an error\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/System/Config/Form.php + + - + message: "#^Else branch is unreachable because previous condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Composite/Fieldset/Options/Type/Radio.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Config/Form.php - - message: "#^Parameter \\#2 \\$containerId \\(string\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Composite_Fieldset_Options_Type_Radio\\:\\:setValidationContainer\\(\\) should be compatible with parameter \\$containerId \\(int\\) of method Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option\\:\\:setValidationContainer\\(\\)$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Composite/Fieldset/Options/Type/Radio.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Config/Form.php - - message: "#^Parameter \\#1 \\$elementId \\(string\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Composite_Fieldset_Options_Type_Select\\:\\:setValidationContainer\\(\\) should be compatible with parameter \\$elementId \\(int\\) of method Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option\\:\\:setValidationContainer\\(\\)$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Composite/Fieldset/Options/Type/Select.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Config/Form.php - - message: "#^Parameter \\#2 \\$containerId \\(string\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Composite_Fieldset_Options_Type_Select\\:\\:setValidationContainer\\(\\) should be compatible with parameter \\$containerId \\(int\\) of method Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option\\:\\:setValidationContainer\\(\\)$#" + message: "#^Parameter \\#1 \\$element of method Mage_Adminhtml_Block_System_Config_Form\\:\\:_prepareFieldComment\\(\\) expects Mage_Core_Model_Config_Element, Varien_Simplexml_Element given\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Composite/Fieldset/Options/Type/Select.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Config/Form.php - - message: "#^Method Mage_Bundle_Block_Adminhtml_Catalog_Product_Edit_Tab_Bundle_Option_Selection\\:\\:isUsedWebsitePrice\\(\\) should return string but returns bool\\.$#" + message: "#^Parameter \\#1 \\$element of method Mage_Adminhtml_Block_System_Config_Form\\:\\:_prepareFieldTooltip\\(\\) expects Mage_Core_Model_Config_Element, Varien_Simplexml_Element given\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Bundle/Option/Selection.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Config/Form.php - - message: "#^Return type \\(void\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Edit_Tabs\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Adminhtml_Block_Catalog_Product_Edit_Tabs\\:\\:_prepareLayout\\(\\)$#" + message: "#^Parameter \\#1 \\$element of method Mage_Adminhtml_Block_System_Config_Form\\:\\:_prepareGroupComment\\(\\) expects Mage_Core_Model_Config_Element, Varien_Simplexml_Element given\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tabs.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Config/Form.php - - message: "#^Variable \\$_items might not be defined\\.$#" + message: "#^Parameter \\#1 \\$element of method Mage_Adminhtml_Block_System_Config_Form\\:\\:getScopeLabel\\(\\) expects Mage_Core_Model_Config_Element, Varien_Simplexml_Element given\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Config/Form.php - - message: "#^Call to an undefined method Mage_Catalog_Model_Product_Type_Price\\:\\:getIsPricesCalculatedByIndex\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$field of method Mage_Adminhtml_Block_System_Config_Form\\:\\:canUseDefaultValue\\(\\) expects Varien_Simplexml_Element, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Block/Catalog/Product/Price.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Config/Form.php - - message: "#^Call to an undefined method Mage_Catalog_Model_Product_Type_Price\\:\\:getSelectionPreFinalPrice\\(\\)\\.$#" - count: 3 - path: ../app/code/core/Mage/Bundle/Block/Catalog/Product/View/Type/Bundle/Option.php + message: "#^Parameter \\#1 \\$field of method Mage_Adminhtml_Block_System_Config_Form\\:\\:canUseWebsiteValue\\(\\) expects Varien_Simplexml_Element, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/System/Config/Form.php - - message: "#^Variable \\$_items might not be defined\\.$#" + message: "#^Parameter \\#1 \\$separator of function explode expects non\\-empty\\-string, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Block/Sales/Order/Items/Renderer.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Config/Form.php - - message: "#^Call to an undefined method Mage_Catalog_Model_Product_Configuration_Item_Interface\\:\\:getQty\\(\\)\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Helper/Catalog/Product/Configuration.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Config/Tabs.php - - message: "#^Call to an undefined method Mage_Catalog_Model_Product_Type_Price\\:\\:getSelectionFinalTotalPrice\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$emptyLabel of method Mage_Directory_Model_Resource_Country_Collection\\:\\:toOptionArray\\(\\) expects string, false given\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Helper/Catalog/Product/Configuration.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Convert/Gui/Edit/Tab/Wizard.php - - message: "#^Call to an undefined method Mage_Bundle_Model_CatalogIndex_Data_Bundle\\:\\:_addAttributeFilter\\(\\)\\.$#" + message: "#^Variable \\$attributes might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/CatalogIndex/Data/Bundle.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Convert/Gui/Edit/Tab/Wizard.php - - message: "#^Call to an undefined method Mage_Bundle_Model_CatalogIndex_Data_Bundle\\:\\:_getLinkSelect\\(\\)\\.$#" + message: "#^Variable \\$img might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/CatalogIndex/Data/Bundle.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Convert/Profile/Run.php - - message: "#^PHPDoc type bool of property Mage_Bundle_Model_CatalogIndex_Data_Bundle\\:\\:\\$_haveChildren is not covariant with PHPDoc type array\\ of overridden property Mage_CatalogIndex_Model_Data_Simple\\:\\:\\$_haveChildren\\.$#" + message: "#^Variable \\$liStyle might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/CatalogIndex/Data/Bundle.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Convert/Profile/Run.php - - message: "#^Property Mage_Bundle_Model_CatalogIndex_Data_Bundle\\:\\:\\$_haveChildren \\(bool\\) does not accept default value of type array\\\\.$#" + message: "#^Parameter \\#1 \\$currency of method Mage_Directory_Model_Currency\\:\\:getCurrencyRates\\(\\) expects string, array given\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/CatalogIndex/Data/Bundle.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Currency/Rate/Matrix.php - - message: "#^Call to an undefined method Mage_Bundle_Model_Resource_Price_Index\\:\\:reindexProduct\\(\\)\\.$#" + message: "#^Parameter \\#2 \\$characters of function rtrim expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/Price/Index.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Currency/Rate/Matrix.php - - message: "#^Call to an undefined method Mage_Bundle_Model_Product_Price\\:\\:getPricesTierPrice\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/System/Design/Edit/Tab/General.php + + - + message: "#^If condition is always true\\.$#" count: 2 - path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Email/Template/Edit.php - - message: "#^Method Mage_Bundle_Model_Product_Price\\:\\:getOptions\\(\\) should return Mage_Bundle_Model_Resource_Option_Collection but returns array\\.$#" + message: "#^Method Mage_Adminhtml_Block_System_Email_Template_Edit\\:\\:getUsedCurrentlyForPaths\\(\\) should return string but returns array\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Email/Template/Edit.php - - message: "#^Method Mage_Bundle_Model_Product_Price\\:\\:getPrice\\(\\) should return string but returns int\\.$#" + message: "#^Method Mage_Adminhtml_Block_System_Email_Template_Edit\\:\\:getUsedDefaultForPaths\\(\\) should return string but returns array\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Email/Template/Edit.php - - message: "#^Offset 'option_id' does not exist on array\\{final_price\\: mixed\\}\\.$#" - count: 4 - path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + message: "#^Method Mage_Core_Model_Email_Template\\:\\:getProcessedTemplate\\(\\) invoked with 2 parameters, 0\\-1 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/System/Email/Template/Preview.php - - message: "#^Return type \\(string\\) of method Mage_Bundle_Model_Product_Price\\:\\:getPrice\\(\\) should be compatible with return type \\(float\\) of method Mage_Catalog_Model_Product_Type_Price\\:\\:getPrice\\(\\)$#" + message: "#^Variable \\$addLabel might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php - - message: "#^Call to an undefined method Mage_Catalog_Model_Product_Type_Price\\:\\:getSelectionFinalTotalPrice\\(\\)\\.$#" - count: 2 - path: ../app/code/core/Mage/Bundle/Model/Product/Type.php + message: "#^Variable \\$deleteLabel might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php - - message: "#^Parameter \\#1 \\$product \\(Mage_Catalog_Model_Product\\) of method Mage_Bundle_Model_Product_Type\\:\\:getForceChildItemQtyChanges\\(\\) should be compatible with parameter \\$product \\(null\\) of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:getForceChildItemQtyChanges\\(\\)$#" + message: "#^Variable \\$deleteUrl might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/Product/Type.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php - - message: "#^Parameter \\#2 \\$product \\(Mage_Catalog_Model_Product\\) of method Mage_Bundle_Model_Product_Type\\:\\:prepareQuoteItemQty\\(\\) should be compatible with parameter \\$product \\(null\\) of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:prepareQuoteItemQty\\(\\)$#" + message: "#^Variable \\$editLabel might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/Product/Type.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php - - message: "#^Parameter \\#4 \\$product \\(Mage_Catalog_Model_Product\\) of method Mage_Bundle_Model_Product_Type\\:\\:updateQtyOption\\(\\) should be compatible with parameter \\$product \\(null\\) of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:updateQtyOption\\(\\)$#" + message: "#^Variable \\$saveLabel might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/Product/Type.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php - - message: "#^Return type \\(int\\) of method Mage_Bundle_Model_Product_Type\\:\\:prepareQuoteItemQty\\(\\) should be compatible with return type \\(float\\) of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:prepareQuoteItemQty\\(\\)$#" + message: "#^Variable \\$groupModel might not be defined\\.$#" + count: 18 + path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php + + - + message: "#^Variable \\$showGroupFieldset might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/Product/Type.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php - - message: "#^Variable \\$selections in empty\\(\\) always exists and is not falsy\\.$#" + message: "#^Variable \\$showStoreFieldset might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/Product/Type.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php - - message: "#^Property Mage_Bundle_Model_Resource_Option_Collection\\:\\:\\$_itemIds \\(array\\) does not accept null\\.$#" + message: "#^Variable \\$showWebsiteFieldset might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/Resource/Option/Collection.php + path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php - - message: "#^Variable \\$basePrice might not be defined\\.$#" + message: "#^Variable \\$storeModel might not be defined\\.$#" + count: 21 + path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php + + - + message: "#^Variable \\$websiteModel might not be defined\\.$#" + count: 15 + path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php + + - + message: "#^Call to an undefined method Mage_Tag_Model_Resource_Tag_Collection\\:\\:addAttributeToFilter\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Tag/Grid/All.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Tag/Grid/All.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Tag/Grid/Customers.php + + - + message: "#^Binary operation \"\\*\" between string and 1 results in an error\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Tax/Rate/Grid/Renderer/Data.php + + - + message: "#^Parameter \\#1 \\$num of function number_format expects float, string\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Tax/Rate/Grid/Renderer/Data.php + + - + message: "#^Parameter \\#1 \\$classTypeId of method Mage_Tax_Model_Resource_Class_Collection\\:\\:setClassTypeFilter\\(\\) expects int, string given\\.$#" count: 2 - path: ../app/code/core/Mage/Bundle/Model/Resource/Price/Index.php + path: ../app/code/core/Mage/Adminhtml/Block/Tax/Rule/Edit/Form.php - - message: "#^Variable \\$customOptions might not be defined\\.$#" + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/Tax/Rule/Grid.php + + - + message: "#^Parameter \\#1 \\$classTypeId of method Mage_Tax_Model_Resource_Class_Collection\\:\\:setClassTypeFilter\\(\\) expects int, string given\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/Tax/Rule/Grid.php + + - + message: "#^Variable \\$category in empty\\(\\) always exists and is not falsy\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/Resource/Price/Index.php + path: ../app/code/core/Mage/Adminhtml/Block/Urlrewrite/Category/Tree.php - - message: "#^Variable \\$priceCond might not be defined\\.$#" + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/Resource/Price/Index.php + path: ../app/code/core/Mage/Adminhtml/Block/Urlrewrite/Edit/Form.php - - message: "#^Variable \\$priceTypeCond might not be defined\\.$#" + message: "#^Method Mage_Adminhtml_Block_Widget_Container\\:\\:_addButtonChildBlock\\(\\) should return Mage_Adminhtml_Block_Widget_Button but returns Mage_Core_Block_Abstract\\|false\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/Resource/Price/Index.php + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Container.php - - message: "#^Variable \\$valueIdCond might not be defined\\.$#" + message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 2 parameters, 0 required\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Form.php + + - + message: "#^Parameter \\#1 \\$renderer of static method Varien_Data_Form\\:\\:setElementRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/Resource/Price/Index.php + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Form.php - - message: "#^Method Mage_Bundle_Model_Resource_Selection_Collection\\:\\:_initSelect\\(\\) should return \\$this\\(Mage_Bundle_Model_Resource_Selection_Collection\\) but return statement is missing\\.$#" + message: "#^Parameter \\#1 \\$renderer of static method Varien_Data_Form\\:\\:setFieldsetElementRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/Resource/Selection/Collection.php + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Form.php - - message: "#^Variable \\$_items might not be defined\\.$#" + message: "#^Parameter \\#1 \\$renderer of static method Varien_Data_Form\\:\\:setFieldsetRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Bundle/Model/Sales/Order/Pdf/Items/Abstract.php + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Form.php - - message: "#^Call to an undefined method Mage_Captcha_Model_Interface\\:\\:isRequired\\(\\)\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Captcha/Block/Captcha/Zend.php + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Form.php - - message: "#^Call to an undefined method Mage_Captcha_Model_Interface\\:\\:isRequired\\(\\)\\.$#" - count: 9 - path: ../app/code/core/Mage/Captcha/Model/Observer.php + message: "#^Call to an undefined method Varien_Data_Collection\\:\\:addFieldToFilter\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid.php - - message: "#^Call to an undefined method Mage_Captcha_Model_Interface\\:\\:logAttempt\\(\\)\\.$#" + message: "#^Call to an undefined method Varien_Data_Collection\\:\\:getSelect\\(\\)\\.$#" count: 3 - path: ../app/code/core/Mage/Captcha/Model/Observer.php + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid.php - - message: "#^Result of method Mage_Captcha_Model_Interface\\:\\:isCorrect\\(\\) \\(void\\) is used\\.$#" - count: 9 - path: ../app/code/core/Mage/Captcha/Model/Observer.php + message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid.php - - message: "#^Property Zend_Captcha_Word\\:\\:\\$_word \\(string\\) does not accept null\\.$#" + message: "#^If condition is always true\\.$#" + count: 3 + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid.php + + - + message: "#^Method Mage_Adminhtml_Block_Widget_Grid\\:\\:getSubTotalItem\\(\\) should return Varien_Object but returns string\\.$#" count: 1 - path: ../app/code/core/Mage/Captcha/Model/Zend.php + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid.php - - message: "#^Return type \\(Mage_Customer_Model_Session\\) of method Mage_Captcha_Model_Zend\\:\\:getSession\\(\\) should be compatible with return type \\(Zend_Session_Namespace\\) of method Zend_Captcha_Word\\:\\:getSession\\(\\)$#" + message: "#^Property Mage_Adminhtml_Block_Widget_Grid\\:\\:\\$defaultColumnSettings \\(array\\\\>\\) does not accept default value of type array\\\\>\\.$#" count: 1 - path: ../app/code/core/Mage/Captcha/Model/Zend.php + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid.php - - message: "#^Call to an undefined method Mage_Captcha_Model_Interface\\:\\:getImgSrc\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$emptyLabel of method Mage_Directory_Model_Resource_Country_Collection\\:\\:toOptionArray\\(\\) expects string, false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Country.php + + - + message: "#^Method Mage_Adminhtml_Block_Widget_Grid_Column_Filter_Date\\:\\:_convertDate\\(\\) should return Zend_Date but returns null\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Date.php + + - + message: "#^Method Mage_Adminhtml_Block_Widget_Grid_Column_Filter_Datetime\\:\\:_convertDate\\(\\) should return Zend_Date but returns null\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Datetime.php + + - + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Select.php + + - + message: "#^Parameter \\#2 \\$checked of method Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Checkbox\\:\\:_getCheckboxHtml\\(\\) expects bool, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Checkbox.php + + - + message: "#^Parameter \\#1 \\$value of method Zend_Currency\\:\\:toCurrency\\(\\) expects float\\|int\\|null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Currency.php + + - + message: "#^Binary operation \"\\*\" between string and 1 results in an error\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Number.php + + - + message: "#^Parameter \\#1 \\$value of method Zend_Currency\\:\\:toCurrency\\(\\) expects float\\|int\\|null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Price.php + + - + message: "#^Call to an undefined method Mage_Adminhtml_Block_Widget_Tab_Interface\\:\\:getSkipGenerateContent\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Tabs.php + + - + message: "#^Call to an undefined method Mage_Adminhtml_Block_Widget_Tab_Interface\\:\\:getTabId\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Tabs.php + + - + message: "#^Call to an undefined method Mage_Adminhtml_Block_Widget_Tab_Interface\\:\\:toHtml\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Tabs.php + + - + message: "#^PHPDoc tag @param references unknown parameter\\: \\$tabNId$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Block/Widget/Tabs.php + + - + message: "#^Parameter \\#1 \\$ids of method Mage_Adminhtml_Controller_Action\\:\\:loadLayout\\(\\) expects bool\\|string\\|null, array\\ given\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Controller/Action.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 4 + path: ../app/code/core/Mage/Adminhtml/Controller/Action.php + + - + message: "#^Return type \\(Mage_Admin_Model_Session\\) of method Mage_Adminhtml_Controller_Report_Abstract\\:\\:_getSession\\(\\) should be compatible with return type \\(Mage_Adminhtml_Model_Session\\) of method Mage_Adminhtml_Controller_Action\\:\\:_getSession\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Controller/Report/Abstract.php + + - + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Controller/Sales/Creditmemo.php + + - + message: "#^Parameter \\#1 \\$creditmemos of method Mage_Sales_Model_Order_Pdf_Creditmemo\\:\\:getPdf\\(\\) expects array\\, Mage_Sales_Model_Resource_Order_Creditmemo_Collection given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Controller/Sales/Creditmemo.php + + - + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Controller/Sales/Invoice.php + + - + message: "#^Parameter \\#1 \\$invoices of method Mage_Sales_Model_Order_Pdf_Invoice\\:\\:getPdf\\(\\) expects array\\, Mage_Sales_Model_Resource_Order_Invoice_Collection given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Controller/Sales/Invoice.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Controller/Sales/Shipment.php + + - + message: "#^Parameter \\#1 \\$shipments of method Mage_Sales_Model_Order_Pdf_Shipment\\:\\:getPdf\\(\\) expects array\\, Mage_Sales_Model_Resource_Order_Shipment_Collection given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Controller/Sales/Shipment.php + + - + message: "#^Call to function is_array\\(\\) with string\\|null will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Helper/Catalog/Product/Edit/Action/Attribute.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Resource_Product_Collection will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Helper/Catalog/Product/Edit/Action/Attribute.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Eav_Model_Resource_Entity_Attribute_Collection will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Helper/Catalog/Product/Edit/Action/Attribute.php + + - + message: "#^Call to function is_null\\(\\) with array\\|Mage_Core_Model_Resource_Db_Collection_Abstract\\|Mage_Eav_Model_Entity_Collection_Abstract will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Helper/Dashboard/Abstract.php + + - + message: "#^Method Mage_Adminhtml_Model_Config\\:\\:getSection\\(\\) should return Varien_Simplexml_Element but return statement is missing\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Config.php + + - + message: "#^Parameter \\#1 \\$cache of method Varien_Simplexml_Config\\:\\:setCache\\(\\) expects Varien_Simplexml_Config_Cache_Abstract, Zend_Cache_Core given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Config.php + + - + message: "#^Parameter \\#1 \\$sectionNode of method Mage_Adminhtml_Model_Config\\:\\:getAttributeModule\\(\\) expects Varien_Simplexml_Element\\|null, array\\\\|false\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Config.php + + - + message: "#^Parameter \\#2 \\$groupNode of method Mage_Adminhtml_Model_Config\\:\\:getAttributeModule\\(\\) expects Varien_Simplexml_Element\\|null, array\\\\|false\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Config.php + + - + message: "#^Parameter \\#3 \\$fieldNode of method Mage_Adminhtml_Model_Config\\:\\:getAttributeModule\\(\\) expects Varien_Simplexml_Element\\|null, array\\\\|false\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Config.php + + - + message: "#^Property Mage_Adminhtml_Model_Config\\:\\:\\$_config \\(Mage_Core_Model_Config_Base\\) does not accept Varien_Simplexml_Config\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Config.php + + - + message: "#^Property Varien_Simplexml_Config\\:\\:\\$_cacheChecksum \\(unknown_type\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Config.php + + - + message: "#^Call to an undefined method Mage_Adminhtml_Model_Config_Data\\:\\:__\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Config/Data.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Config_Element will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Config/Data.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Config/Data.php + + - + message: "#^Parameter \\#1 \\$field of method Mage_Adminhtml_Model_Config_Data\\:\\:_isValidField\\(\\) expects Mage_Core_Model_Config_Element, Varien_Simplexml_Element\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Config/Data.php + + - + message: "#^Property Mage_Adminhtml_Model_Config_Data\\:\\:\\$_configRoot \\(Mage_Core_Model_Config_Element\\) does not accept Varien_Simplexml_Element\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Config/Data.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 3 + path: ../app/code/core/Mage/Adminhtml/Model/Config/Data.php + + - + message: "#^Method Mage_Eav_Model_Entity_Abstract\\:\\:load\\(\\) invoked with 1 parameter, 2\\-3 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Giftmessage/Save.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 3 + path: ../app/code/core/Mage/Adminhtml/Model/Giftmessage/Save.php + + - + message: "#^Parameter \\#1 \\$object of method Mage_Eav_Model_Entity_Abstract\\:\\:load\\(\\) expects Mage_Core_Model_Abstract, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Giftmessage/Save.php + + - + message: "#^If condition is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Product_Compare_List will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Customer_Model_Form will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Quote will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Wishlist_Model_Wishlist will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + + - + message: "#^If condition is always true\\.$#" + count: 6 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + + - + message: "#^Left side of && is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + + - + message: "#^Method Mage_Adminhtml_Model_Sales_Order_Create\\:\\:initFromOrderItem\\(\\) should return Mage_Sales_Model_Quote_Item\\|string but returns \\$this\\(Mage_Adminhtml_Model_Sales_Order_Create\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + + - + message: "#^Parameter \\#1 \\$optionId of method Mage_Catalog_Model_Product\\:\\:getOptionById\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + + - + message: "#^Parameter \\#2 \\$string of function explode expects string, array given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + + - + message: "#^Parameter \\#3 \\$storeId of method Mage_Customer_Model_Customer\\:\\:sendNewAccountEmail\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + + - + message: "#^Property Mage_Adminhtml_Model_Sales_Order_Create\\:\\:\\$_customerAddressForm \\(Mage_Customer_Model_Form\\) does not accept bool\\|Mage_Eav_Model_Form\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + + - + message: "#^Property Mage_Adminhtml_Model_Sales_Order_Create\\:\\:\\$_customerForm \\(Mage_Customer_Model_Form\\) does not accept bool\\|Mage_Eav_Model_Form\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + + - + message: "#^Property Mage_Adminhtml_Model_Sales_Order_Create\\:\\:\\$_wishlist \\(Mage_Wishlist_Model_Wishlist\\) does not accept false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + + - + message: "#^Right side of && is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + + - + message: "#^Variable \\$billingAddress might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + + - + message: "#^Variable \\$shippingAddress might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + + - + message: "#^Call to an undefined method Mage_Sales_Model_Order\\:\\:createFromQuoteAddress\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Random.php + + - + message: "#^Call to an undefined method Mage_Sales_Model_Order\\:\\:validate\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Random.php + + - + message: "#^Call to an undefined method Mage_Sales_Model_Quote\\:\\:addCatalogProduct\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Random.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Store will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Session/Quote.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Customer_Model_Customer will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Session/Quote.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Order will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Session/Quote.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Quote will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/Session/Quote.php + + - + message: "#^Cannot access offset 'file' on bool\\|void\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/System/Config/Backend/File.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/System/Config/Backend/File.php + + - + message: "#^Comparison operation \"\\=\\=\" between \\(Varien_Simplexml_Element\\|null\\) and 1 results in an error\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/System/Config/Source/Admin/Page.php + + - + message: "#^Parameter \\#1 \\$emptyLabel of method Mage_Directory_Model_Resource_Country_Collection\\:\\:toOptionArray\\(\\) expects string, false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/System/Config/Source/Allregion.php + + - + message: "#^Method Varien_Data_Collection\\:\\:toOptionArray\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/System/Config/Source/Country.php + + - + message: "#^Method Mage_Adminhtml_Model_System_Store\\:\\:__construct\\(\\) with return type void returns \\$this\\(Mage_Adminhtml_Model_System_Store\\) but should not return anything\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/System/Store.php + + - + message: "#^Variable \\$values might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/Model/System/Store.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Api/RoleController.php + + - + message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php + + - + message: "#^Call to function is_array\\(\\) with string\\|null will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php + + - + message: "#^If condition is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php + + - + message: "#^Parameter \\#1 \\$productIds of method Mage_Catalog_Model_Product_Action\\:\\:updateAttributes\\(\\) expects array, string\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php + + - + message: "#^Parameter \\#1 \\$productIds of method Mage_Catalog_Model_Product_Action\\:\\:updateWebsites\\(\\) expects array, string\\|null given\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php + + - + message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, string\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php + + - + message: "#^Return type \\(Mage_Adminhtml_Helper_Catalog_Product_Edit_Action_Attribute\\) of method Mage_Adminhtml_Catalog_Product_Action_AttributeController\\:\\:_getHelper\\(\\) should be compatible with return type \\(Mage_Adminhtml_Helper_Data\\) of method Mage_Adminhtml_Controller_Action\\:\\:_getHelper\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php + + - + message: "#^Parameter \\#1 \\$pattern of class Zend_Validate_Regex constructor expects string\\|Zend_Config, array\\ given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/Product/AttributeController.php + + - + message: "#^Cannot access offset 'tmp_name' on bool\\|void\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/Product/GalleryController.php + + - + message: "#^Offset 'file' does not exist on array\\{path\\: \\(array\\\\|string\\), url\\: string\\}\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/Product/GalleryController.php + + - + message: "#^Offset 'file' does not exist on array\\{path\\: \\(array\\\\|string\\)\\}\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/Product/GalleryController.php + + - + message: "#^Ternary operator condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/Product/SetController.php + + - + message: "#^Parameter \\#1 \\$ids of method Mage_Adminhtml_Controller_Action\\:\\:loadLayout\\(\\) expects bool\\|string\\|null, array\\ given\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/ProductController.php + + - + message: "#^Method Mage_Adminhtml_Controller_Action\\:\\:_setForcedFormKeyActions\\(\\) invoked with 2 parameters, 1 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/SearchController.php + + - + message: "#^Parameter \\#1 \\$item of method Mage_Sales_Model_Resource_Quote_Item_Option_Collection\\:\\:addItemFilter\\(\\) expects array\\|int, Mage_Sales_Model_Quote_Item given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Customer/Cart/Product/Composite/CartController.php + + - + message: "#^Parameter \\#1 \\$content of method Zend_Controller_Response_Abstract\\:\\:setBody\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Customer/System/Config/ValidatevatController.php + + - + message: "#^Property Mage_Adminhtml_Customer_Wishlist_Product_Composite_WishlistController\\:\\:\\$_wishlistItem \\(Mage_Wishlist_Model_Wishlist\\) does not accept Mage_Wishlist_Model_Item\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Customer/Wishlist/Product/Composite/WishlistController.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 3 + path: ../app/code/core/Mage/Adminhtml/controllers/CustomerController.php + + - + message: "#^Parameter \\#2 \\$timestamp of function date expects int\\|null, array\\|bool given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/CustomerController.php + + - + message: "#^Parameter \\#2 \\$value of method Zend_Controller_Response_Abstract\\:\\:setHeader\\(\\) expects string, array\\|bool given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/CustomerController.php + + - + message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:getClassName\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/IndexController.php + + - + message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'delete' given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Newsletter/ProblemController.php + + - + message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'unsubscribe' given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Newsletter/ProblemController.php + + - + message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'sendPerSubscriber' given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Newsletter/QueueController.php + + - + message: "#^Variable \\$id in isset\\(\\) always exists and is not nullable\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Permissions/BlockController.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Permissions/RoleController.php + + - + message: "#^Comparison operation \"\\>\\=\" between int\\<1, max\\> and 1 is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Permissions/UserController.php + + - + message: "#^Variable \\$id in isset\\(\\) always exists and is not nullable\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Permissions/VariableController.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/PollController.php + + - + message: "#^Cannot call method aggregate\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/controllers/Report/StatisticsController.php + + - + message: "#^Return type \\(Mage_Admin_Model_Session\\) of method Mage_Adminhtml_Report_StatisticsController\\:\\:_getSession\\(\\) should be compatible with return type \\(Mage_Adminhtml_Model_Session\\) of method Mage_Adminhtml_Controller_Action\\:\\:_getSession\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Report/StatisticsController.php + + - + message: "#^Method Mage_Adminhtml_Model_Sales_Order_Create\\:\\:moveQuoteItem\\(\\) invoked with 2 parameters, 3 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreateController.php + + - + message: "#^Method Mage_Adminhtml_Model_Sales_Order_Create\\:\\:resetShippingMethod\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreateController.php + + - + message: "#^Return type \\(Mage_Adminhtml_Model_Session_Quote\\) of method Mage_Adminhtml_Sales_Order_CreateController\\:\\:_getSession\\(\\) should be compatible with return type \\(Mage_Adminhtml_Model_Session\\) of method Mage_Adminhtml_Controller_Action\\:\\:_getSession\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreateController.php + + - + message: "#^Call to an undefined method Mage_Sales_Model_Order_Creditmemo\\:\\:void\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreditmemoController.php + + - + message: "#^Right side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreditmemoController.php + + - + message: "#^Result of && is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/InvoiceController.php + + - + message: "#^Undefined variable\\: \\$shippingResponse$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/InvoiceController.php + + - + message: "#^Variable \\$shippingResponse in isset\\(\\) is never defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/InvoiceController.php + + - + message: "#^Call to function is_object\\(\\) with array\\|string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php + + - + message: "#^Method Mage_Adminhtml_Sales_Order_ShipmentController\\:\\:getShippingItemsGridAction\\(\\) should return Mage_Core_Controller_Response_Http but returns Zend_Controller_Response_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php + + - + message: "#^Parameter \\#1 \\$order of method Mage_Sales_Model_Resource_Order_Collection_Abstract\\:\\:setOrderFilter\\(\\) expects int\\|Mage_Sales_Model_Order, array\\ given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php + + - + message: "#^Parameter \\#1 \\$prefix of function uniqid expects string, int\\<0, max\\> given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php + + - + message: "#^Parameter \\#2 \\$enable of function imageinterlace expects bool\\|null, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php + + - + message: "#^Method Mage_Adminhtml_Controller_Action\\:\\:_setForcedFormKeyActions\\(\\) invoked with 2 parameters, 1 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php + + - + message: "#^Parameter \\#1 \\$creditmemos of method Mage_Sales_Model_Order_Pdf_Creditmemo\\:\\:getPdf\\(\\) expects array\\, Mage_Sales_Model_Resource_Order_Creditmemo_Collection given\\.$#" + count: 4 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php + + - + message: "#^Parameter \\#1 \\$invoices of method Mage_Sales_Model_Order_Pdf_Invoice\\:\\:getPdf\\(\\) expects array\\, Mage_Sales_Model_Resource_Order_Invoice_Collection given\\.$#" + count: 4 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php + + - + message: "#^Parameter \\#1 \\$shipments of method Mage_Sales_Model_Order_Pdf_Shipment\\:\\:getPdf\\(\\) expects array\\, Mage_Sales_Model_Resource_Order_Shipment_Collection given\\.$#" + count: 4 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php + + - + message: "#^Variable \\$pdf might not be defined\\.$#" + count: 4 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/Recurring/ProfileController.php + + - + message: "#^Parameter \\#1 \\$order of method Mage_Sales_Model_Order_Payment\\:\\:setOrder\\(\\) expects Mage_Sales_Model_Order, Mage_Sales_Model_Order_Payment given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/TransactionsController.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Sales/TransactionsController.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/System/Config/System/StorageController.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/System/Config/System/StorageController.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/controllers/System/ConfigController.php + + - + message: "#^Variable \\$data in isset\\(\\) always exists and is not nullable\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/System/Convert/ProfileController.php + + - + message: "#^Cannot call method fetchRates\\(\\) on Mage_Core_Model_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/System/CurrencyController.php + + - + message: "#^Parameter \\#1 \\$modelClass of static method Mage\\:\\:getModel\\(\\) expects string, array given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/System/CurrencyController.php + + - + message: "#^Method Mage_Adminhtml_System_StoreController\\:\\:_backupDatabase\\(\\) should return \\$this\\(Mage_Adminhtml_System_StoreController\\) but empty return statement found\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/controllers/System/StoreController.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 6 + path: ../app/code/core/Mage/Adminhtml/controllers/System/StoreController.php + + - + message: "#^Variable \\$codeBase might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/System/StoreController.php + + - + message: "#^Variable \\$itemId might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/System/StoreController.php + + - + message: "#^Variable \\$model might not be defined\\.$#" + count: 5 + path: ../app/code/core/Mage/Adminhtml/controllers/System/StoreController.php + + - + message: "#^Variable \\$notExists might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/System/StoreController.php + + - + message: "#^Variable \\$title might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/System/StoreController.php + + - + message: "#^Method Mage_Directory_Model_Country\\:\\:loadByCode\\(\\) invoked with 2 parameters, 1 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Tax/RateController.php + + - + message: "#^Parameter \\#1 \\$id of method Mage_Core_Model_Abstract\\:\\:load\\(\\) expects int\\|string, null given\\.$#" + count: 2 + path: ../app/code/core/Mage/Adminhtml/controllers/Tax/RateController.php + + - + message: "#^Method Mage_Adminhtml_Tax_RuleController\\:\\:saveAction\\(\\) should return Mage_Core_Controller_Response_Http\\|Mage_Core_Controller_Varien_Action but return statement is missing\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Tax/RuleController.php + + - + message: "#^Method Mage_Adminhtml_Tax_RuleController\\:\\:saveAction\\(\\) should return Mage_Core_Controller_Response_Http\\|Mage_Core_Controller_Varien_Action but returns Zend_Controller_Response_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Tax/RuleController.php + + - + message: "#^Parameter \\#1 \\$ruleModel of method Mage_Adminhtml_Tax_RuleController\\:\\:_isValidRuleRequest\\(\\) expects Mage_Tax_Model_Calculation_Rule, Mage_Core_Model_Abstract given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/Tax/RuleController.php + + - + message: "#^Parameter \\#2 \\$value of method Mage_Core_Model_Config\\:\\:saveConfig\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Adminhtml/controllers/TaxController.php + + - + message: "#^Method Mage_Api_Model_Acl\\:\\:_getRoleRegistry\\(\\) should return Mage_Api_Model_Acl_Role_Registry but returns Zend_Acl_Role_Registry\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Acl.php + + - + message: "#^Parameter \\#2 \\$arguments of static method Mage\\:\\:getModel\\(\\) expects array\\|object, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Config.php + + - + message: "#^Parameter \\#2 \\$resource of method Mage_Api_Model_Config\\:\\:loadAclResources\\(\\) expects Mage_Core_Model_Config_Element\\|null, Varien_Simplexml_Element given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Config.php + + - + message: "#^Parameter \\#4 \\$lifeTime of method Mage_Core_Model_App\\:\\:saveCache\\(\\) expects int\\|false\\|null, bool given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Config.php + + - + message: "#^Return type \\(Zend_Cache_Core\\) of method Mage_Api_Model_Config\\:\\:getCache\\(\\) should be compatible with return type \\(Varien_Simplexml_Config_Cache_Abstract\\) of method Varien_Simplexml_Config\\:\\:getCache\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Config.php + + - + message: "#^Cannot call method getClassName\\(\\) on bool\\|SimpleXMLElement\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Resource/Acl.php + + - + message: "#^Parameter \\#2 \\$arguments of static method Mage\\:\\:getModel\\(\\) expects array\\|object, string given\\.$#" + count: 2 + path: ../app/code/core/Mage/Api/Model/Resource/Acl.php + + - + message: "#^Method Mage_Core_Model_Resource_Db_Abstract\\:\\:load\\(\\) invoked with 1 parameter, 2\\-3 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Resource/Roles.php + + - + message: "#^Parameter \\#1 \\$role of method Mage_Api_Model_Resource_Roles\\:\\:_updateRoleUsersAcl\\(\\) expects Mage_Api_Model_Roles, Mage_Core_Model_Abstract given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Resource/Roles.php + + - + message: "#^Parameter \\#1 \\$user of method Mage_Api_Model_Resource_User\\:\\:hasAssigned2Role\\(\\) expects int\\|Mage_Api_Model_User, Mage_Core_Model_Abstract given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Resource/User.php + + - + message: "#^Return type \\(bool\\) of method Mage_Api_Model_Resource_User\\:\\:delete\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Resource_Db_Abstract\\)\\) of method Mage_Core_Model_Resource_Db_Abstract\\:\\:delete\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Resource/User.php + + - + message: "#^Call to an undefined method Mage_Api_Model_Resource_Roles\\:\\:update\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Roles.php + + - + message: "#^Parameter \\#3 \\$level of method Mage_Api_Model_Roles\\:\\:_buildResourcesArray\\(\\) expects int, null given\\.$#" + count: 2 + path: ../app/code/core/Mage/Api/Model/Roles.php + + - + message: "#^Call to an undefined method Mage_Api_Model_Resource_Rules\\:\\:update\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Rules.php + + - + message: "#^Call to an undefined method SoapServer\\:\\:setReturnResponse\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/Adapter/Soap.php + + - + message: "#^Parameter \\#1 \\$code of class SoapFault constructor expects array\\|string\\|null, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/Adapter/Soap.php + + - + message: "#^Parameter \\#3 \\$subject of function preg_replace expects array\\|string, void given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/Adapter/Soap.php + + - + message: "#^Property Mage_Api_Model_Server_Adapter_Soap\\:\\:\\$_soap \\(SoapServer\\) does not accept Zend_Soap_Server\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/Adapter/Soap.php + + - + message: "#^Result of method SoapServer\\:\\:handle\\(\\) \\(void\\) is used\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/Adapter/Soap.php + + - + message: "#^Return type \\(Varien_Object\\) of method Mage_Api_Model_Server_Adapter_Soap\\:\\:getController\\(\\) should be compatible with return type \\(Mage_Api_Controller_Action\\) of method Mage_Api_Model_Server_Adapter_Interface\\:\\:getController\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/Adapter/Soap.php + + - + message: "#^Access to an undefined property object\\:\\:\\$model\\.$#" + count: 2 + path: ../app/code/core/Mage/Api/Model/Server/Handler/Abstract.php + + - + message: "#^Instanceof between Mage_Core_Model_Abstract\\|false and Mage_Api_Model_Resource_Abstract will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/Handler/Abstract.php + + - + message: "#^Method Mage_Api_Model_Session\\:\\:isSessionExpired\\(\\) invoked with 0 parameters, 1 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/Handler/Abstract.php + + - + message: "#^Parameter \\#3 \\$subject of function preg_replace expects array\\|string, void given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/V2/Adapter/Soap.php + + - + message: "#^Result of method SoapServer\\:\\:handle\\(\\) \\(void\\) is used\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/V2/Adapter/Soap.php + + - + message: "#^Return type \\(Mage_Api_Model_Wsdl_Config\\) of method Mage_Api_Model_Server_V2_Adapter_Soap\\:\\:_getWsdlConfig\\(\\) should be compatible with return type \\(Varien_Object\\) of method Mage_Api_Model_Server_Adapter_Soap\\:\\:_getWsdlConfig\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/V2/Adapter/Soap.php + + - + message: "#^Parameter \\#1 \\$string of function strlen expects string, array given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/V2/Handler.php + + - + message: "#^Parameter \\#2 \\$needle of function strpos expects string, array given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/V2/Handler.php + + - + message: "#^Parameter \\#3 \\$subject of function preg_replace expects array\\|string, void given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/Wsi/Adapter/Soap.php + + - + message: "#^Result of method SoapServer\\:\\:handle\\(\\) \\(void\\) is used\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/Wsi/Adapter/Soap.php + + - + message: "#^Return type \\(Mage_Api_Model_Wsdl_Config\\) of method Mage_Api_Model_Server_Wsi_Adapter_Soap\\:\\:_getWsdlConfig\\(\\) should be compatible with return type \\(Varien_Object\\) of method Mage_Api_Model_Server_Adapter_Soap\\:\\:_getWsdlConfig\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/Wsi/Adapter/Soap.php + + - + message: "#^Parameter \\#1 \\$request \\(stdClass\\) of method Mage_Api_Model_Server_Wsi_Handler\\:\\:endSession\\(\\) should be compatible with parameter \\$sessionId \\(string\\) of method Mage_Api_Model_Server_Handler_Abstract\\:\\:endSession\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/Wsi/Handler.php + + - + message: "#^Parameter \\#1 \\$string of function strlen expects string, array given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/Wsi/Handler.php + + - + message: "#^Parameter \\#2 \\$needle of function strpos expects string, array given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/Wsi/Handler.php + + - + message: "#^Return type \\(stdClass\\) of method Mage_Api_Model_Server_Wsi_Handler\\:\\:endSession\\(\\) should be compatible with return type \\(true\\) of method Mage_Api_Model_Server_Handler_Abstract\\:\\:endSession\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/Wsi/Handler.php + + - + message: "#^Return type \\(stdClass\\) of method Mage_Api_Model_Server_Wsi_Handler\\:\\:login\\(\\) should be compatible with return type \\(string\\) of method Mage_Api_Model_Server_Handler_Abstract\\:\\:login\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Server/Wsi/Handler.php + + - + message: "#^Return type \\(bool\\) of method Mage_Api_Model_Session\\:\\:clear\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Session_Abstract_Varien\\)\\) of method Mage_Core_Model_Session_Abstract_Varien\\:\\:clear\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Session.php + + - + message: "#^Return type \\(void\\) of method Mage_Api_Model_Session\\:\\:revalidateCookie\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Session_Abstract_Varien\\)\\) of method Mage_Core_Model_Session_Abstract_Varien\\:\\:revalidateCookie\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Session.php + + - + message: "#^Invalid array key type array\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Wsdl/Config.php + + - + message: "#^Parameter \\#2 \\$mergeToObject of method Mage_Core_Model_Config\\:\\:loadModulesConfiguration\\(\\) expects Mage_Core_Model_Config_Base\\|null, \\$this\\(Mage_Api_Model_Wsdl_Config\\) given\\.$#" + count: 2 + path: ../app/code/core/Mage/Api/Model/Wsdl/Config.php + + - + message: "#^Parameter \\#3 \\$mergeModel of method Mage_Core_Model_Config\\:\\:loadModulesConfiguration\\(\\) expects null, Mage_Api_Model_Wsdl_Config_Base given\\.$#" + count: 2 + path: ../app/code/core/Mage/Api/Model/Wsdl/Config.php + + - + message: "#^Call to an undefined method SimpleXMLElement\\:\\:extendChild\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Wsdl/Config/Element.php + + - + message: "#^Parameter \\#1 \\$source of static method Mage_Api_Model_Wsdl_Config_Element\\:\\:_getChildren\\(\\) expects Varien_Simplexml_Element, SimpleXMLElement given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Wsdl/Config/Element.php + + - + message: "#^Return type \\(array\\) of method Mage_Api_Model_Wsdl_Config_Element\\:\\:getChildren\\(\\) should be compatible with return type \\(RecursiveIterator\\|null\\) of method RecursiveIterator\\\\:\\:getChildren\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Api/Model/Wsdl/Config/Element.php + + - + message: "#^Return type \\(void\\) of method Mage_Api2_Block_Adminhtml_Attribute_Grid\\:\\:_prepareCollection\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:_prepareCollection\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Api2/Block/Adminhtml/Attribute/Grid.php + + - + message: "#^Property Mage_Api2_Block_Adminhtml_Attribute_Tab_Resource\\:\\:\\$_treeModel \\(Mage_Api2_Model_Acl_Global_Rule_Tree\\) does not accept default value of type false\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Block/Adminhtml/Attribute/Tab/Resource.php + + - + message: "#^Call to an undefined method Varien_Data_Collection\\:\\:addFieldToFilter\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/Api2/Block/Adminhtml/Permissions/User/Edit/Tab/Roles.php + + - + message: "#^Property Mage_Api2_Block_Adminhtml_Roles_Tab_Resources\\:\\:\\$_treeModel \\(Mage_Api2_Model_Acl_Global_Rule_Tree\\) does not accept default value of type false\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Block/Adminhtml/Roles/Tab/Resources.php + + - + message: "#^Cannot access offset 'order' on int\\.$#" + count: 4 + path: ../app/code/core/Mage/Api2/Helper/Data.php + + - + message: "#^Variable \\$adapters might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Helper/Data.php + + - + message: "#^Parameter \\#1 \\$roleId \\(int\\) of method Mage_Api2_Model_Acl\\:\\:addRole\\(\\) should be compatible with parameter \\$role \\(string\\|Zend_Acl_Role_Interface\\) of method Zend_Acl\\:\\:addRole\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Acl.php + + - + message: "#^Parameter \\#1 \\$role of method Zend_Acl\\:\\:hasRole\\(\\) expects string\\|Zend_Acl_Role_Interface, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Acl/Global.php + + - + message: "#^Parameter \\#1 \\$role of method Zend_Acl\\:\\:isAllowed\\(\\) expects string\\|Zend_Acl_Role_Interface\\|null, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Acl/Global.php + + - + message: "#^Strict comparison using \\=\\=\\= between int and null will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Acl/Global.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Acl/Global/Rule/ResourcePermission.php + + - + message: "#^Method Mage_Api2_Model_Acl_Global_Rule_ResourcePermission\\:\\:setFilterValue\\(\\) should return Mage_Api2_Model_Acl_PermissionInterface but return statement is missing\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Acl/Global/Rule/ResourcePermission.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Acl/Global/Rule/Tree.php + + - + message: "#^Variable \\$operationName might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Api2/Model/Acl/Global/Rule/Tree.php + + - + message: "#^Instanceof between Mage_Core_Model_Abstract\\|false and Mage_Api2_Model_Auth_Adapter_Abstract will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Auth/Adapter.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Auth/Adapter.php + + - + message: "#^Method Mage_Api2_Model_Config\\:\\:getResourceGroup\\(\\) should return bool\\|Mage_Core_Model_Config_Element but returns Varien_Simplexml_Element\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Config.php + + - + message: "#^Parameter \\#1 \\$cache of method Varien_Simplexml_Config\\:\\:setCache\\(\\) expects Varien_Simplexml_Config_Cache_Abstract, Zend_Cache_Core given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Config.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Dispatcher.php + + - + message: "#^Parameter \\#2 \\$lowerOrEqualsTo of method Mage_Api2_Model_Config\\:\\:getResourceLastVersion\\(\\) expects int\\|null, bool\\|string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Dispatcher.php + + - + message: "#^Call to an undefined method Mage_Api2_Model_Config\\:\\:getMainRoute\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Multicall.php + + - + message: "#^Property Mage_Api2_Model_Request\\:\\:\\$_interpreter \\(Mage_Api2_Model_Request_Interpreter_Interface\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Request.php + + - + message: "#^Call to an undefined method Mage_Api2_Model_Resource\\:\\:_multiDelete\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource.php + + - + message: "#^Method Mage_Api2_Model_Resource\\:\\:_create\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource.php + + - + message: "#^Method Mage_Api2_Model_Resource\\:\\:_getSubModel\\(\\) should return \\$this\\(Mage_Api2_Model_Resource\\) but returns Mage_Api2_Model_Resource\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource.php + + - + message: "#^Method Mage_Api2_Model_Resource\\:\\:_multiCreate\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource.php + + - + message: "#^Method Mage_Api2_Model_Resource\\:\\:_multiUpdate\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource.php + + - + message: "#^Method Mage_Api2_Model_Resource\\:\\:_update\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 6 + path: ../app/code/core/Mage/Api2/Model/Resource.php + + - + message: "#^Parameter \\#1 \\$renderer of method Mage_Api2_Model_Resource\\:\\:setRenderer\\(\\) expects Mage_Api2_Model_Renderer_Interface, Mage_Core_Model_Abstract\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource.php + + - + message: "#^Parameter \\#1 \\$version of method Mage_Api2_Model_Resource\\:\\:setVersion\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource.php + + - + message: "#^Parameter \\#2 \\$code of method Mage_Api2_Model_Response\\:\\:addMessage\\(\\) expects string, int given\\.$#" + count: 2 + path: ../app/code/core/Mage/Api2/Model/Resource.php + + - + message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource/Acl/Global/Role.php + + - + message: "#^Parameter \\#2 \\$value of method Varien_Data_Collection\\:\\:addFilter\\(\\) expects array\\|string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource/Acl/Global/Rule/Collection.php + + - + message: "#^Instanceof between Mage_Core_Model_Abstract and Mage_Eav_Model_Form will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource/Validator/Eav.php + + - + message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource/Validator/Eav.php + + - + message: "#^Parameter \\#2 \\.\\.\\.\\$arrays of function array_merge expects array, false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource/Validator/Eav.php + + - + message: "#^Property Mage_Api2_Model_Resource_Validator_Eav\\:\\:\\$_eavForm \\(Mage_Eav_Model_Form\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource/Validator/Eav.php + + - + message: "#^Property Mage_Api2_Model_Resource_Validator_Eav\\:\\:\\$_eavForm \\(Mage_Eav_Model_Form\\) in empty\\(\\) is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource/Validator/Eav.php + + - + message: "#^Property Mage_Api2_Model_Resource_Validator_Eav\\:\\:\\$_entity \\(Mage_Core_Model_Abstract\\) in empty\\(\\) is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource/Validator/Eav.php + + - + message: "#^Result of \\|\\| is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource/Validator/Eav.php + + - + message: "#^Result of \\|\\| is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource/Validator/Eav.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource/Validator/Eav.php + + - + message: "#^Call to an undefined method Zend_Validate_Interface\\:\\:setMessage\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Resource/Validator/Fields.php + + - + message: "#^Method Mage_Api2_Model_Response\\:\\:setMimeType\\(\\) should return \\$this\\(Mage_Api2_Model_Response\\) but returns Zend_Controller_Response_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Response.php + + - + message: "#^Parameter \\#1 \\$request \\(Mage_Api2_Model_Request\\) of method Mage_Api2_Model_Route_Abstract\\:\\:match\\(\\) should be compatible with parameter \\$path \\(string\\) of method Zend_Controller_Router_Route\\:\\:match\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Route/Abstract.php + + - + message: "#^Constructor of class Mage_Api2_Model_Route_ApiType has an unused parameter \\$defaults\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Route/ApiType.php + + - + message: "#^Constructor of class Mage_Api2_Model_Route_ApiType has an unused parameter \\$locale\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Route/ApiType.php + + - + message: "#^Constructor of class Mage_Api2_Model_Route_ApiType has an unused parameter \\$reqs\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Route/ApiType.php + + - + message: "#^Constructor of class Mage_Api2_Model_Route_ApiType has an unused parameter \\$route\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Route/ApiType.php + + - + message: "#^Constructor of class Mage_Api2_Model_Route_ApiType has an unused parameter \\$translator\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Route/ApiType.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Api2/Model/Server.php + + - + message: "#^Call to an undefined method Varien_Object\\:\\:decrypt\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Authorizenet/Model/Directpost.php + + - + message: "#^Call to an undefined method Varien_Object\\:\\:encrypt\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Authorizenet/Model/Directpost.php + + - + message: "#^Method Mage_Authorizenet_Model_Directpost\\:\\:initialize\\(\\) should return \\$this\\(Mage_Authorizenet_Model_Directpost\\) but return statement is missing\\.$#" + count: 1 + path: ../app/code/core/Mage/Authorizenet/Model/Directpost.php + + - + message: "#^Parameter \\#1 \\$payment of method Mage_Authorizenet_Model_Directpost\\:\\:_getRealParentTransactionId\\(\\) expects Mage_Sales_Model_Order_Payment, Varien_Object given\\.$#" + count: 3 + path: ../app/code/core/Mage/Authorizenet/Model/Directpost.php + + - + message: "#^Parameter \\#1 \\$payment of method Mage_Authorizenet_Model_Directpost\\:\\:authorize\\(\\) expects Varien_Object, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Authorizenet/Model/Directpost.php + + - + message: "#^Parameter \\#1 \\$payment of method Mage_Paygate_Model_Authorizenet\\:\\:_buildRequest\\(\\) expects Mage_Payment_Model_Info, Varien_Object given\\.$#" + count: 3 + path: ../app/code/core/Mage/Authorizenet/Model/Directpost.php + + - + message: "#^Parameter \\#2 \\$amount of method Mage_Authorizenet_Model_Directpost\\:\\:_refund\\(\\) expects string, float given\\.$#" + count: 1 + path: ../app/code/core/Mage/Authorizenet/Model/Directpost.php + + - + message: "#^Return type \\(bool\\) of method Mage_Authorizenet_Model_Directpost\\:\\:validate\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Cc\\)\\) of method Mage_Payment_Model_Method_Cc\\:\\:validate\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Authorizenet/Model/Directpost.php + + - + message: "#^Return type \\(void\\) of method Mage_Authorizenet_Model_Directpost\\:\\:authorize\\(\\) should be compatible with return type \\(\\$this\\(Mage_Paygate_Model_Authorizenet\\)\\) of method Mage_Paygate_Model_Authorizenet\\:\\:authorize\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Authorizenet/Model/Directpost.php + + - + message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:generateRequestFromOrder\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Authorizenet/Model/Directpost/Observer.php + + - + message: "#^Parameter \\#1 \\$spec of method Zend_Controller_Response_Abstract\\:\\:getBody\\(\\) expects bool, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Authorizenet/Model/Directpost/Observer.php + + - + message: "#^Parameter \\#6 \\$fpTimestamp of method Mage_Authorizenet_Model_Directpost_Request\\:\\:_generateSha2RequestSign\\(\\) expects string, int\\<1, max\\> given\\.$#" + count: 1 + path: ../app/code/core/Mage/Authorizenet/Model/Directpost/Request.php + + - + message: "#^Parameter \\#6 \\$fpTimestamp of method Mage_Authorizenet_Model_Directpost_Request\\:\\:generateRequestSign\\(\\) expects string, int\\<1, max\\> given\\.$#" + count: 1 + path: ../app/code/core/Mage/Authorizenet/Model/Directpost/Request.php + + - + message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:generateRequestFromOrder\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Authorizenet/controllers/Adminhtml/Authorizenet/Directpost/PaymentController.php + + - + message: "#^Method Mage_Authorizenet_Directpost_PaymentController\\:\\:_getIframeBlock\\(\\) should return Mage_Authorizenet_Block_Directpost_Iframe but returns Mage_Core_Block_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Authorizenet/controllers/Directpost/PaymentController.php + + - + message: "#^Variable \\$params might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Authorizenet/controllers/Directpost/PaymentController.php + + - + message: "#^Method Mage_Backup_Helper_Data\\:\\:getCreateSuccessMessageByType\\(\\) should return string but empty return statement found\\.$#" + count: 1 + path: ../app/code/core/Mage/Backup/Helper/Data.php + + - + message: "#^Call to function is_null\\(\\) with resource will always evaluate to false\\.$#" + count: 3 + path: ../app/code/core/Mage/Backup/Model/Backup.php + + - + message: "#^Property Mage_Backup_Model_Backup\\:\\:\\$_handler \\(resource\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Backup/Model/Backup.php + + - + message: "#^Variable \\$filePath might not be defined\\.$#" + count: 4 + path: ../app/code/core/Mage/Backup/Model/Backup.php + + - + message: "#^Parameter \\#2 \\$value of function ini_set expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Backup/Model/Db.php + + - + message: "#^Call to an undefined method Mage_Backup_Interface\\:\\:setRootDir\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Backup/Model/Observer.php + + - + message: "#^Property Mage_Backup_Model_Resource_Db\\:\\:\\$_write \\(Varien_Db_Adapter_Pdo_Mysql\\) does not accept Varien_Db_Adapter_Interface\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Backup/Model/Resource/Db.php + + - + message: "#^Parameter \\#1 \\$elementId \\(string\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Composite_Fieldset_Options_Type_Checkbox\\:\\:setValidationContainer\\(\\) should be compatible with parameter \\$elementId \\(int\\) of method Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option\\:\\:setValidationContainer\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Composite/Fieldset/Options/Type/Checkbox.php + + - + message: "#^Parameter \\#2 \\$containerId \\(string\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Composite_Fieldset_Options_Type_Checkbox\\:\\:setValidationContainer\\(\\) should be compatible with parameter \\$containerId \\(int\\) of method Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option\\:\\:setValidationContainer\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Composite/Fieldset/Options/Type/Checkbox.php + + - + message: "#^Parameter \\#1 \\$elementId \\(string\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Composite_Fieldset_Options_Type_Multi\\:\\:setValidationContainer\\(\\) should be compatible with parameter \\$elementId \\(int\\) of method Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option\\:\\:setValidationContainer\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Composite/Fieldset/Options/Type/Multi.php + + - + message: "#^Parameter \\#2 \\$containerId \\(string\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Composite_Fieldset_Options_Type_Multi\\:\\:setValidationContainer\\(\\) should be compatible with parameter \\$containerId \\(int\\) of method Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option\\:\\:setValidationContainer\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Composite/Fieldset/Options/Type/Multi.php + + - + message: "#^Parameter \\#1 \\$elementId \\(string\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Composite_Fieldset_Options_Type_Radio\\:\\:setValidationContainer\\(\\) should be compatible with parameter \\$elementId \\(int\\) of method Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option\\:\\:setValidationContainer\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Composite/Fieldset/Options/Type/Radio.php + + - + message: "#^Parameter \\#2 \\$containerId \\(string\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Composite_Fieldset_Options_Type_Radio\\:\\:setValidationContainer\\(\\) should be compatible with parameter \\$containerId \\(int\\) of method Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option\\:\\:setValidationContainer\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Composite/Fieldset/Options/Type/Radio.php + + - + message: "#^Parameter \\#1 \\$elementId \\(string\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Composite_Fieldset_Options_Type_Select\\:\\:setValidationContainer\\(\\) should be compatible with parameter \\$elementId \\(int\\) of method Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option\\:\\:setValidationContainer\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Composite/Fieldset/Options/Type/Select.php + + - + message: "#^Parameter \\#2 \\$containerId \\(string\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Composite_Fieldset_Options_Type_Select\\:\\:setValidationContainer\\(\\) should be compatible with parameter \\$containerId \\(int\\) of method Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option\\:\\:setValidationContainer\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Composite/Fieldset/Options/Type/Select.php + + - + message: "#^Parameter \\#2 \\$product of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:setStoreFilter\\(\\) expects null, Mage_Catalog_Model_Product given\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Bundle/Option.php + + - + message: "#^Method Mage_Bundle_Block_Adminhtml_Catalog_Product_Edit_Tab_Bundle_Option_Selection\\:\\:isUsedWebsitePrice\\(\\) should return string but returns bool\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Bundle/Option/Selection.php + + - + message: "#^Return type \\(void\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Edit_Tabs\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Adminhtml_Block_Catalog_Product_Edit_Tabs\\:\\:_prepareLayout\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tabs.php + + - + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php + + - + message: "#^Variable \\$_items might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php + + - + message: "#^Parameter \\#4 \\$cond of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:joinTable\\(\\) expects array\\|null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Block/Catalog/Product/List/Partof.php + + - + message: "#^Call to an undefined method Mage_Catalog_Model_Product_Type_Price\\:\\:getIsPricesCalculatedByIndex\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Block/Catalog/Product/Price.php + + - + message: "#^Parameter \\#2 \\$product of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:setStoreFilter\\(\\) expects null, Mage_Catalog_Model_Product given\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Block/Catalog/Product/View/Type/Bundle.php + + - + message: "#^Call to an undefined method Mage_Catalog_Model_Product_Type_Price\\:\\:getSelectionPreFinalPrice\\(\\)\\.$#" + count: 3 + path: ../app/code/core/Mage/Bundle/Block/Catalog/Product/View/Type/Bundle/Option.php + + - + message: "#^Call to function is_null\\(\\) with array\\|int\\|string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Block/Catalog/Product/View/Type/Bundle/Option.php + + - + message: "#^Call to function is_null\\(\\) with bool will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Block/Catalog/Product/View/Type/Bundle/Option.php + + - + message: "#^Variable \\$_items might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Block/Sales/Order/Items/Renderer.php + + - + message: "#^Call to an undefined method Mage_Catalog_Model_Product_Configuration_Item_Interface\\:\\:getQty\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Helper/Catalog/Product/Configuration.php + + - + message: "#^Call to an undefined method Mage_Catalog_Model_Product_Type_Price\\:\\:getSelectionFinalTotalPrice\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Helper/Catalog/Product/Configuration.php + + - + message: "#^Ternary operator condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Helper/Catalog/Product/Configuration.php + + - + message: "#^Call to an undefined method Mage_Bundle_Model_CatalogIndex_Data_Bundle\\:\\:_addAttributeFilter\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/CatalogIndex/Data/Bundle.php + + - + message: "#^Call to an undefined method Mage_Bundle_Model_CatalogIndex_Data_Bundle\\:\\:_getLinkSelect\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/CatalogIndex/Data/Bundle.php + + - + message: "#^PHPDoc type bool of property Mage_Bundle_Model_CatalogIndex_Data_Bundle\\:\\:\\$_haveChildren is not covariant with PHPDoc type array\\ of overridden property Mage_CatalogIndex_Model_Data_Simple\\:\\:\\$_haveChildren\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/CatalogIndex/Data/Bundle.php + + - + message: "#^Property Mage_Bundle_Model_CatalogIndex_Data_Bundle\\:\\:\\$_haveChildren \\(bool\\) does not accept default value of type array\\\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/CatalogIndex/Data/Bundle.php + + - + message: "#^Parameter \\#2 \\$product of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:setStoreFilter\\(\\) expects null, Mage_Catalog_Model_Product given\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Observer.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Option.php + + - + message: "#^Result of && is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Option.php + + - + message: "#^Call to an undefined method Mage_Bundle_Model_Resource_Price_Index\\:\\:reindexProduct\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Price/Index.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Product/Attribute/Source/Price/View.php + + - + message: "#^Call to an undefined method Mage_Bundle_Model_Product_Price\\:\\:getPricesTierPrice\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + + - + message: "#^Call to function is_null\\(\\) with float will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + + - + message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + + - + message: "#^Method Mage_Bundle_Model_Product_Price\\:\\:getOptions\\(\\) should return Mage_Bundle_Model_Resource_Option_Collection but returns array\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + + - + message: "#^Method Mage_Bundle_Model_Product_Price\\:\\:getPrice\\(\\) should return string but returns int\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + + - + message: "#^Offset 'option_id' does not exist on array\\{final_price\\: mixed\\}\\.$#" + count: 4 + path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + + - + message: "#^Parameter \\#1 \\$price of method Mage_Catalog_Model_Product\\:\\:setFinalPrice\\(\\) expects float, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + + - + message: "#^Parameter \\#2 \\$product of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:setStoreFilter\\(\\) expects null, Mage_Catalog_Model_Product given\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + + - + message: "#^Parameter \\#2 \\$qty of method Mage_Catalog_Model_Product_Type_Price\\:\\:_applyOptionsPrice\\(\\) expects int, float\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + + - + message: "#^Parameter \\#2 \\$selectionProduct of method Mage_Bundle_Model_Product_Price\\:\\:getSelectionFinalTotalPrice\\(\\) expects Mage_Catalog_Model_Product, Mage_Bundle_Model_Selection given\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + + - + message: "#^Parameter \\#3 \\$bundleQty of method Mage_Bundle_Model_Product_Price\\:\\:getLowestPrice\\(\\) expects int, float given\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + + - + message: "#^Parameter \\#4 \\$selectionQty of method Mage_Bundle_Model_Product_Price\\:\\:getSelectionFinalTotalPrice\\(\\) expects float, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + + - + message: "#^Return type \\(string\\) of method Mage_Bundle_Model_Product_Price\\:\\:getPrice\\(\\) should be compatible with return type \\(float\\) of method Mage_Catalog_Model_Product_Type_Price\\:\\:getPrice\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Product/Price.php + + - + message: "#^Call to an undefined method Mage_Catalog_Model_Product_Type_Price\\:\\:getSelectionFinalTotalPrice\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/Bundle/Model/Product/Type.php + + - + message: "#^Call to function is_array\\(\\) with string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Product/Type.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Product/Type.php + + - + message: "#^Parameter \\#1 \\$product \\(Mage_Catalog_Model_Product\\) of method Mage_Bundle_Model_Product_Type\\:\\:getForceChildItemQtyChanges\\(\\) should be compatible with parameter \\$product \\(null\\) of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:getForceChildItemQtyChanges\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Product/Type.php + + - + message: "#^Parameter \\#2 \\$product \\(Mage_Catalog_Model_Product\\) of method Mage_Bundle_Model_Product_Type\\:\\:prepareQuoteItemQty\\(\\) should be compatible with parameter \\$product \\(null\\) of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:prepareQuoteItemQty\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Product/Type.php + + - + message: "#^Parameter \\#2 \\$product of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:setStoreFilter\\(\\) expects null, Mage_Catalog_Model_Product given\\.$#" + count: 4 + path: ../app/code/core/Mage/Bundle/Model/Product/Type.php + + - + message: "#^Parameter \\#4 \\$product \\(Mage_Catalog_Model_Product\\) of method Mage_Bundle_Model_Product_Type\\:\\:updateQtyOption\\(\\) should be compatible with parameter \\$product \\(null\\) of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:updateQtyOption\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Product/Type.php + + - + message: "#^Return type \\(int\\) of method Mage_Bundle_Model_Product_Type\\:\\:prepareQuoteItemQty\\(\\) should be compatible with return type \\(float\\) of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:prepareQuoteItemQty\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Product/Type.php + + - + message: "#^Variable \\$selections in empty\\(\\) always exists and is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Product/Type.php + + - + message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Resource/Indexer/Price.php + + - + message: "#^Parameter \\#3 \\$false of method Varien_Db_Adapter_Pdo_Mysql\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Resource/Indexer/Price.php + + - + message: "#^Parameter \\#5 \\$condition of method Mage_Catalog_Model_Resource_Product_Indexer_Abstract\\:\\:_addAttributeToSelect\\(\\) expects Zend_Db_Expr\\|null, string given\\.$#" + count: 2 + path: ../app/code/core/Mage/Bundle/Model/Resource/Indexer/Price.php + + - + message: "#^Parameter \\#5 \\$condition of method Mage_Catalog_Model_Resource_Product_Indexer_Abstract\\:\\:_addAttributeToSelect\\(\\) expects Zend_Db_Expr\\|null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Resource/Indexer/Stock.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Resource/Option/Collection.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Resource/Option/Collection.php + + - + message: "#^Parameter \\#1 \\$selection of method Mage_Bundle_Model_Option\\:\\:addSelection\\(\\) expects Mage_Bundle_Model_Selection, Mage_Catalog_Model_Product given\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Resource/Option/Collection.php + + - + message: "#^Property Mage_Bundle_Model_Resource_Option_Collection\\:\\:\\$_itemIds \\(array\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Resource/Option/Collection.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Bundle/Model/Resource/Price/Index.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Resource/Price/Index.php + + - + message: "#^Variable \\$basePrice might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Bundle/Model/Resource/Price/Index.php + + - + message: "#^Variable \\$customOptions might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Resource/Price/Index.php + + - + message: "#^Variable \\$priceCond might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Resource/Price/Index.php + + - + message: "#^Variable \\$priceTypeCond might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Resource/Price/Index.php + + - + message: "#^Variable \\$valueIdCond might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Resource/Price/Index.php + + - + message: "#^Method Mage_Bundle_Model_Resource_Selection_Collection\\:\\:_initSelect\\(\\) should return \\$this\\(Mage_Bundle_Model_Resource_Selection_Collection\\) but return statement is missing\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Resource/Selection/Collection.php + + - + message: "#^Variable \\$_items might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Sales/Order/Pdf/Items/Abstract.php + + - + message: "#^Parameter \\#1 \\$item of method Mage_Bundle_Model_Sales_Order_Pdf_Items_Abstract\\:\\:canShowPriceInfo\\(\\) expects Mage_Sales_Model_Order_Item, Mage_Sales_Model_Order_Invoice_Item given\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Sales/Order/Pdf/Items/Invoice.php + + - + message: "#^Parameter \\#1 \\$item of method Mage_Bundle_Model_Sales_Order_Pdf_Items_Abstract\\:\\:getValueHtml\\(\\) expects Mage_Sales_Model_Order_Item, Mage_Sales_Model_Order_Invoice_Item given\\.$#" + count: 1 + path: ../app/code/core/Mage/Bundle/Model/Sales/Order/Pdf/Items/Invoice.php + + - + message: "#^Call to an undefined method Mage_Captcha_Model_Interface\\:\\:isRequired\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Captcha/Block/Captcha/Zend.php + + - + message: "#^Call to an undefined method Mage_Captcha_Model_Interface\\:\\:isRequired\\(\\)\\.$#" + count: 9 + path: ../app/code/core/Mage/Captcha/Model/Observer.php + + - + message: "#^Call to an undefined method Mage_Captcha_Model_Interface\\:\\:logAttempt\\(\\)\\.$#" + count: 3 + path: ../app/code/core/Mage/Captcha/Model/Observer.php + + - + message: "#^Negated boolean expression is always true\\.$#" + count: 9 + path: ../app/code/core/Mage/Captcha/Model/Observer.php + + - + message: "#^Result of method Mage_Captcha_Model_Interface\\:\\:isCorrect\\(\\) \\(void\\) is used\\.$#" + count: 9 + path: ../app/code/core/Mage/Captcha/Model/Observer.php + + - + message: "#^Property Mage_Captcha_Model_Zend\\:\\:\\$_helper \\(Mage_Captcha_Helper_Data\\) in empty\\(\\) is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Captcha/Model/Zend.php + + - + message: "#^Property Zend_Captcha_Word\\:\\:\\$_word \\(string\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Captcha/Model/Zend.php + + - + message: "#^Return type \\(Mage_Customer_Model_Session\\) of method Mage_Captcha_Model_Zend\\:\\:getSession\\(\\) should be compatible with return type \\(Zend_Session_Namespace\\) of method Zend_Captcha_Word\\:\\:getSession\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Captcha/Model/Zend.php + + - + message: "#^Call to an undefined method Mage_Captcha_Model_Interface\\:\\:getImgSrc\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Captcha/controllers/Adminhtml/RefreshController.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Captcha/controllers/Adminhtml/RefreshController.php + + - + message: "#^Call to an undefined method Mage_Captcha_Model_Interface\\:\\:getImgSrc\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Captcha/controllers/RefreshController.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Captcha/controllers/RefreshController.php + + - + message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Breadcrumbs.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Category/View.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Layer/View.php + + - + message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Navigation.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Category will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Navigation.php + + - + message: "#^Cannot call method count\\(\\) on string\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Block/Navigation.php + + - + message: "#^Comparison operation \"\\>\" between int\\<2, 7\\> and 0 is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Navigation.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Navigation.php + + - + message: "#^Property Mage_Catalog_Block_Navigation\\:\\:\\$_currentCategoryKey \\(string\\) does not accept int\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Navigation.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Navigation.php + + - + message: "#^Variable \\$htmlChildren in empty\\(\\) always exists and is always falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Navigation.php + + - + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Block/Product.php + + - + message: "#^Variable \\$productId might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/Abstract.php + + - + message: "#^Parameter \\#2 \\$templateType of method Mage_Review_Block_Helper\\:\\:getSummaryHtml\\(\\) expects string, bool given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/Abstract.php + + - + message: "#^Property Mage_Catalog_Block_Product_Abstract\\:\\:\\$_reviewsHelperBlock \\(Mage_Review_Block_Helper\\|null\\) does not accept Mage_Core_Block_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/Abstract.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Resource_Product_Compare_Item_Collection will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/Compare/List.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/Compare/List.php + + - + message: "#^Method Mage_Catalog_Model_Resource_Product_Compare_Item_Collection\\:\\:useProductItem\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/Compare/List.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Eav_Model_Entity_Collection_Abstract will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/List.php + + - + message: "#^Method Mage_Catalog_Block_Product_List\\:\\:_getProductCollection\\(\\) should return Mage_Catalog_Model_Resource_Product_Collection but returns Mage_Eav_Model_Entity_Collection_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/List.php + + - + message: "#^Property Mage_Catalog_Block_Product_List_Crosssell\\:\\:\\$_itemCollection \\(Mage_Catalog_Model_Resource_Eav_Mysql4_Product_Link_Product_Collection\\) does not accept Mage_Catalog_Model_Resource_Product_Link_Product_Collection\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/List/Crosssell.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Eav_Model_Entity_Collection_Abstract will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/List/Promotion.php + + - + message: "#^Parameter \\#2 \\$condition of method Mage_Catalog_Model_Resource_Product_Collection\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/List/Promotion.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Eav_Model_Entity_Collection_Abstract will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/List/Random.php + + - + message: "#^Method Mage_Catalog_Block_Product_List_Toolbar\\:\\:getDefaultPerPageValue\\(\\) should return string but returns int\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/List/Toolbar.php + + - + message: "#^Parameter \\#1 \\$array of function array_keys expects array, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/List/Toolbar.php + + - + message: "#^Property Mage_Catalog_Block_Product_List_Toolbar\\:\\:\\$_availableMode \\(string\\) does not accept array\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/List/Toolbar.php + + - + message: "#^Property Mage_Catalog_Block_Product_List_Toolbar\\:\\:\\$_availableMode \\(string\\) does not accept array\\\\.$#" + count: 4 + path: ../app/code/core/Mage/Catalog/Block/Product/List/Toolbar.php + + - + message: "#^Property Mage_Catalog_Block_Product_List_Toolbar\\:\\:\\$_availableMode \\(string\\) does not accept default value of type array\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/List/Toolbar.php + + - + message: "#^Property Mage_Catalog_Block_Product_List_Toolbar\\:\\:\\$_availableMode \\(string\\) in isset\\(\\) is not nullable\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/List/Toolbar.php + + - + message: "#^Property Mage_Catalog_Block_Product_List_Toolbar\\:\\:\\$_collection \\(Mage_Core_Model_Resource_Db_Collection_Abstract\\) does not accept Varien_Data_Collection\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/List/Toolbar.php + + - + message: "#^Right side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/List/Upsell.php + + - + message: "#^Property Mage_Catalog_Block_Product_New\\:\\:\\$_productsCount \\(null\\) does not accept int\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Block/Product/New.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/Price.php + + - + message: "#^Call to function is_null\\(\\) with int\\|Mage_Core_Model_Store will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/View/Abstract.php + + - + message: "#^Parameter \\#1 \\$product of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:getStoreFilter\\(\\) expects null, Mage_Catalog_Model_Product given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/View/Abstract.php + + - + message: "#^Parameter \\#2 \\$product of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:setStoreFilter\\(\\) expects null, Mage_Catalog_Model_Product given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/View/Abstract.php + + - + message: "#^Parameter \\#1 \\$price of method Mage_Core_Model_Store\\:\\:convertPrice\\(\\) expects float, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/View/Attributes.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/View/Options.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/View/Options/Abstract.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/View/Options/Abstract.php + + - + message: "#^Method Mage_Catalog_Block_Product_View_Options_Type_Date\\:\\:_getValueWithLeadingZeros\\(\\) should return string but returns int\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/View/Options/Type/Date.php + + - + message: "#^Invalid array key type array\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/View/Type/Configurable.php + + - + message: "#^Method Mage_Catalog_Block_Product_View_Type_Configurable\\:\\:_getHelper\\(\\) should return Mage_Catalog_Helper_Product_Type_Composite but returns Mage_Core_Helper_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/View/Type/Configurable.php + + - + message: "#^Parameter \\#1 \\$page of method Varien_Data_Collection\\:\\:setCurPage\\(\\) expects int, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/Widget/Html/Pager.php + + - + message: "#^Parameter \\#1 \\$size of method Varien_Data_Collection\\:\\:setPageSize\\(\\) expects int, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/Widget/Html/Pager.php + + - + message: "#^Property Mage_Catalog_Block_Product_Widget_Html_Pager\\:\\:\\$_lastPage \\(int\\) does not accept float\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/Widget/Html/Pager.php + + - + message: "#^Variable \\$finish might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/Widget/Html/Pager.php + + - + message: "#^Variable \\$start might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/Widget/Html/Pager.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/Widget/New.php + + - + message: "#^Property Mage_Catalog_Block_Product_Widget_New\\:\\:\\$_pager \\(Mage_Catalog_Block_Product_Widget_Html_Pager\\) does not accept Mage_Core_Block_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Product/Widget/New.php + + - + message: "#^Parameter \\#1 \\$varName of method Mage_Page_Block_Html_Pager\\:\\:setShowPerPage\\(\\) expects string, false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Seo/Sitemap/Abstract.php + + - + message: "#^Parameter \\#1 \\$category \\(Mage_Catalog_Model_Category\\) of method Mage_Catalog_Block_Seo_Sitemap_Category\\:\\:getItemUrl\\(\\) should be compatible with parameter \\$item \\(Mage_Catalog_Block_Seo_Sitemap_Abstract\\) of method Mage_Catalog_Block_Seo_Sitemap_Abstract\\:\\:getItemUrl\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Seo/Sitemap/Category.php + + - + message: "#^Parameter \\#1 \\$product \\(Mage_Catalog_Model_Product\\) of method Mage_Catalog_Block_Seo_Sitemap_Product\\:\\:getItemUrl\\(\\) should be compatible with parameter \\$item \\(Mage_Catalog_Block_Seo_Sitemap_Abstract\\) of method Mage_Catalog_Block_Seo_Sitemap_Abstract\\:\\:getItemUrl\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Seo/Sitemap/Product.php + + - + message: "#^Parameter \\#1 \\$varName of method Mage_Page_Block_Html_Pager\\:\\:setShowPerPage\\(\\) expects string, false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Seo/Sitemap/Tree/Category.php + + - + message: "#^Variable \\$finish might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Seo/Sitemap/Tree/Pager.php + + - + message: "#^Variable \\$start might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Seo/Sitemap/Tree/Pager.php + + - + message: "#^Parameter \\#1 \\$entityId of method Mage_Catalog_Model_Resource_Abstract\\:\\:getAttributeRawValue\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Widget/Link.php + + - + message: "#^Parameter \\#1 \\$productId of method Mage_Catalog_Helper_Product\\:\\:getFullProductUrl\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Widget/Link.php + + - + message: "#^Parameter \\#2 \\$categoryId of method Mage_Catalog_Helper_Product\\:\\:getFullProductUrl\\(\\) expects int\\|null, string\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Widget/Link.php + + - + message: "#^Variable \\$store might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Block/Widget/Link.php + + - + message: "#^Parameter \\#4 \\$cond of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:joinTable\\(\\) expects array\\|null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Category/Url/Rewrite.php + + - + message: "#^Parameter \\#1 \\$categoryId of method Mage_Catalog_Helper_Data\\:\\:_isCategoryLink\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Data.php + + - + message: "#^Parameter \\#2 \\$visibility of method Mage_Catalog_Helper_Data\\:\\:canApplyMsrp\\(\\) expects int\\|null, string given\\.$#" + count: 3 + path: ../app/code/core/Mage/Catalog/Helper/Data.php + + - + message: "#^Property Mage_Catalog_Helper_Data\\:\\:\\$_categoryPath \\(string\\) does not accept array\\\\>\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Data.php + + - + message: "#^Call to function is_null\\(\\) with bool will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Helper/Flat/Abstract.php + + - + message: "#^Property Mage_Catalog_Helper_Image\\:\\:\\$_angle \\(int\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Image.php + + - + message: "#^Property Mage_Catalog_Helper_Image\\:\\:\\$_imageFile \\(string\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Image.php + + - + message: "#^Property Mage_Catalog_Helper_Image\\:\\:\\$_model \\(Mage_Catalog_Model_Product_Image\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Image.php + + - + message: "#^Property Mage_Catalog_Helper_Image\\:\\:\\$_product \\(Mage_Catalog_Model_Product\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Image.php + + - + message: "#^Property Mage_Catalog_Helper_Image\\:\\:\\$_watermark \\(string\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Image.php + + - + message: "#^Property Mage_Catalog_Helper_Image\\:\\:\\$_watermarkImageOpacity \\(int\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Image.php + + - + message: "#^Property Mage_Catalog_Helper_Image\\:\\:\\$_watermarkPosition \\(string\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Image.php + + - + message: "#^Property Mage_Catalog_Helper_Image\\:\\:\\$_watermarkSize \\(string\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Image.php + + - + message: "#^Property Mage_Catalog_Helper_Output\\:\\:\\$_templateProcessor \\(Varien_Filter_Template\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Output.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute_Frontend_Abstract\\:\\:getUrl\\(\\)\\.$#" + count: 3 + path: ../app/code/core/Mage/Catalog/Helper/Product.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Product/Compare.php + + - + message: "#^Property Mage_Catalog_Helper_Product_Compare\\:\\:\\$_itemCollection \\(Mage_Catalog_Model_Resource_Eav_Mysql4_Product_Compare_Item_Collection\\) does not accept Mage_Catalog_Model_Resource_Product_Compare_Item_Collection\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Product/Compare.php + + - + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Helper/Product/Configuration.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Product/Configuration.php + + - + message: "#^Parameter \\#1 \\$optionId of method Mage_Catalog_Model_Product\\:\\:getOptionById\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Product/Configuration.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Helper/Product/Configuration.php + + - + message: "#^Call to an undefined method Mage_Core_Model_Abstract\\:\\:loadSelf\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Product/Flat.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Product_Flat_Flag will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Product/Flat.php + + - + message: "#^Property Mage_Catalog_Helper_Product_Flat\\:\\:\\$_forceFlatStatusOld \\(bool\\) in isset\\(\\) is not nullable\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Product/Flat.php + + - + message: "#^Argument of an invalid type float supplied for foreach, only iterables are supported\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Product/Type/Composite.php + + - + message: "#^Parameter \\#3 \\$subject of function str_replace expects array\\|string, float given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Helper/Product/Type/Composite.php + + - + message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:setStoreId\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Abstract.php + + - + message: "#^Method Mage_Core_Model_Website\\:\\:getStoreIds\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Abstract.php + + - + message: "#^Return type \\(Mage_Catalog_Model_Resource_Collection_Abstract\\) of method Mage_Catalog_Model_Abstract\\:\\:getResourceCollection\\(\\) should be compatible with return type \\(Mage_Core_Model_Resource_Db_Collection_Abstract\\) of method Mage_Core_Model_Abstract\\:\\:getResourceCollection\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Abstract.php + + - + message: "#^Call to an undefined method Mage_Catalog_Model_Api_Resource\\:\\:_checkAttributeAcl\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Api/Resource.php + + - + message: "#^Call to function is_null\\(\\) with int\\|string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Api/Resource.php + + - + message: "#^Variable \\$storeId might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Api/Resource.php + + - + message: "#^Argument of an invalid type float supplied for foreach, only iterables are supported\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Product will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php + + - + message: "#^If condition is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php + + - + message: "#^Parameter \\#1 \\$shippingAddress of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects Mage_Sales_Model_Quote_Address\\|false\\|null, Mage_Customer_Model_Address\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php + + - + message: "#^Parameter \\#1 \\$store of method Mage_Tax_Helper_Data\\:\\:isCrossBorderTradeEnabled\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php + + - + message: "#^Parameter \\#2 \\$billingAddress of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects Mage_Sales_Model_Quote_Address\\|false\\|null, Mage_Customer_Model_Address\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php + + - + message: "#^Parameter \\#4 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php + + - + message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Rest/Admin/V1.php + + - + message: "#^Parameter \\#2 \\$fields of method Mage_Catalog_Model_Api2_Product_Rest_Admin_V1\\:\\:_filterConfigValueUsed\\(\\) expects string, array\\ given\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Rest/Admin/V1.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Customer_Model_Customer will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Rest/Customer/V1.php + + - + message: "#^Return type \\(int\\) of method Mage_Catalog_Model_Api2_Product_Rest_Customer_V1\\:\\:_getCustomerGroupId\\(\\) should be compatible with return type \\(null\\) of method Mage_Catalog_Model_Api2_Product_Rest\\:\\:_getCustomerGroupId\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Rest/Customer/V1.php + + - + message: "#^Return type \\(int\\) of method Mage_Catalog_Model_Api2_Product_Rest_Guest_V1\\:\\:_getCustomerGroupId\\(\\) should be compatible with return type \\(null\\) of method Mage_Catalog_Model_Api2_Product_Rest\\:\\:_getCustomerGroupId\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Rest/Guest/V1.php + + - + message: "#^Call to an undefined method Mage_Core_Model_Abstract\\:\\:toOptionArray\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Validator/Product.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\:\\:formatDate\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Validator/Product.php + + - + message: "#^Call to function is_null\\(\\) with int\\|string will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Validator/Product.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Validator/Product.php + + - + message: "#^Call to an undefined method Varien_Object\\:\\:formatUrlKey\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Attribute/Backend/Urlkey/Abstract.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Resource_Category_Tree will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Category.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Category.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Category.php + + - + message: "#^Method Mage_Catalog_Model_Category\\:\\:getDefaultAttributeSetId\\(\\) should return int but returns string\\|null\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Category.php + + - + message: "#^Method Mage_Catalog_Model_Category\\:\\:getParentDesignCategory\\(\\) should return \\$this\\(Mage_Catalog_Model_Category\\) but returns Mage_Catalog_Model_Category\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Category.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Category.php + + - + message: "#^Cannot call method getRootCategoryId\\(\\) on int\\|string\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Category/Api.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Category/Api.php + + - + message: "#^Parameter \\#1 \\$array of function array_pop is passed by reference, so it expects variables only\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Category/Api.php + + - + message: "#^Parameter \\#2 \\$store of method Mage_Catalog_Helper_Product\\:\\:getProduct\\(\\) expects int, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Category/Api.php + + - + message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Category/Attribute/Api.php + + - + message: "#^Cannot access offset 'file' on bool\\|void\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Category/Attribute/Backend/Image.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Category/Attribute/Source/Sortby.php + + - + message: "#^Property Mage_Catalog_Model_Category_Url\\:\\:\\$_url \\(Mage_Core_Model_Url\\) does not accept bool\\|Mage_Core_Model_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Category/Url.php + + - + message: "#^Call to an undefined method Mage_Catalog_Model_Config\\:\\:_init\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Config.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 3 + path: ../app/code/core/Mage/Catalog/Model/Config.php + + - + message: "#^Method Mage_Catalog_Model_Config\\:\\:getAttributeSetId\\(\\) invoked with 1 parameter, 2 required\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Config.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Convert/Adapter/Catalog.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getStoreId\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Convert/Adapter/Product.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Collection\\:\\:setStoreId\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Convert/Adapter/Product.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Product will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Convert/Adapter/Product.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Convert/Adapter/Product.php + + - + message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Convert/Adapter/Product.php + + - + message: "#^Parameter \\#1 \\$joinAttr of method Mage_Eav_Model_Convert_Adapter_Entity\\:\\:setJoinAttr\\(\\) expects string, array\\ given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Convert/Adapter/Product.php + + - + message: "#^Property Mage_Catalog_Model_Convert_Adapter_Product\\:\\:\\$_galleryBackendModel \\(Mage_Catalog_Model_Product_Attribute_Backend_Media\\) does not accept Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Convert/Adapter/Product.php + + - + message: "#^Property Mage_Catalog_Model_Convert_Adapter_Product\\:\\:\\$_productModel \\(Mage_Catalog_Model_Product\\) does not accept string\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Convert/Adapter/Product.php + + - + message: "#^Return type \\(Mage_Catalog_Model_Resource_Product_Collection\\) of method Mage_Catalog_Model_Convert_Adapter_Product\\:\\:_getCollectionForLoad\\(\\) should be compatible with return type \\(Mage_Eav_Model_Entity_Collection\\) of method Mage_Eav_Model_Convert_Adapter_Entity\\:\\:_getCollectionForLoad\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Convert/Adapter/Product.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:setStore\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Convert/Parser/Product.php + + - + message: "#^Call to function is_array\\(\\) with bool\\|string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Convert/Parser/Product.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Convert/Parser/Product.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Convert/Parser/Product.php + + - + message: "#^Left side of && is always true\\.$#" + count: 4 + path: ../app/code/core/Mage/Catalog/Model/Design.php + + - + message: "#^Method Mage_Catalog_Model_Category\\:\\:getParentDesignCategory\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Design.php + + - + message: "#^Method Mage_Catalog_Model_Design\\:\\:applyCustomDesign\\(\\) should return false\\|null but return statement is missing\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Design.php + + - + message: "#^Parameter \\#1 \\$store of method Mage_Core_Model_Locale\\:\\:isStoreDateInInterval\\(\\) expects int\\|Mage_Core_Model_Store\\|string, null given\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Design.php + + - + message: "#^Variable \\$_category might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Design.php + + - + message: "#^Property Mage_Catalog_Model_Entity_Product_Attribute_Design_Options_Container\\:\\:\\$_configNodePath \\(Mage_Core_Model_Config_Element\\) does not accept string\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Entity/Product/Attribute/Design/Options/Container.php + + - + message: "#^Method Mage_Catalog_Model_Factory\\:\\:getCategoryUrlInstance\\(\\) should return Mage_Catalog_Model_Category_Url but returns bool\\|Mage_Core_Model_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Factory.php + + - + message: "#^Method Mage_Catalog_Model_Factory\\:\\:getCategoryUrlRewriteHelper\\(\\) should return Mage_Catalog_Helper_Category_Url_Rewrite_Interface but returns Mage_Core_Helper_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Factory.php + + - + message: "#^Method Mage_Catalog_Model_Factory\\:\\:getProductUrlInstance\\(\\) should return Mage_Catalog_Model_Product_Url but returns bool\\|Mage_Core_Model_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Factory.php + + - + message: "#^Method Mage_Catalog_Model_Factory\\:\\:getProductUrlRewriteHelper\\(\\) should return Mage_Catalog_Helper_Product_Url_Rewrite_Interface but returns Mage_Core_Helper_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Factory.php + + - + message: "#^Parameter \\#1 \\$setId of method Mage_Eav_Model_Resource_Entity_Attribute_Collection\\:\\:setAttributeSetFilter\\(\\) expects int, array given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Abstract.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Resource_Layer_Filter_Attribute will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Attribute.php + + - + message: "#^Comparison operation \"\\=\\=\" between Mage_Catalog_Model_Resource_Eav_Attribute and 1 results in an error\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Attribute.php + + - + message: "#^Parameter \\#2 \\$filterBlock \\(Varien_Object\\) of method Mage_Catalog_Model_Layer_Filter_Attribute\\:\\:apply\\(\\) should be compatible with parameter \\$filterBlock \\(null\\) of method Mage_Catalog_Model_Layer_Filter_Abstract\\:\\:apply\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Attribute.php + + - + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Category.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Category.php + + - + message: "#^Argument of an invalid type int supplied for foreach, only iterables are supported\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Resource_Layer_Filter_Decimal will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php + + - + message: "#^Parameter \\#1 \\$range of method Mage_Catalog_Model_Layer_Filter_Decimal\\:\\:_renderItemLabel\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php + + - + message: "#^Parameter \\#1 \\$string of function strlen expects string, float given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php + + - + message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php + + - + message: "#^Parameter \\#2 \\$filterBlock \\(Mage_Catalog_Block_Layer_Filter_Decimal\\) of method Mage_Catalog_Model_Layer_Filter_Decimal\\:\\:apply\\(\\) should be compatible with parameter \\$filterBlock \\(null\\) of method Mage_Catalog_Model_Layer_Filter_Abstract\\:\\:apply\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php + + - + message: "#^Parameter \\#2 \\$filterBlock of method Mage_Catalog_Model_Layer_Filter_Abstract\\:\\:apply\\(\\) expects null, Mage_Catalog_Block_Layer_Filter_Decimal given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php + + - + message: "#^Parameter \\#2 \\$range of method Mage_Catalog_Model_Resource_Layer_Filter_Decimal\\:\\:applyFilterToCollection\\(\\) expects float, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php + + - + message: "#^Parameter \\#2 \\$value of method Mage_Catalog_Model_Layer_Filter_Decimal\\:\\:_renderItemLabel\\(\\) expects float, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php + + - + message: "#^Parameter \\#3 \\$index of method Mage_Catalog_Model_Resource_Layer_Filter_Decimal\\:\\:applyFilterToCollection\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php + + - + message: "#^Argument of an invalid type int\\\\|int\\<1, max\\> supplied for foreach, only iterables are supported\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Price.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Resource_Layer_Filter_Price will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Price.php + + - + message: "#^Parameter \\#1 \\$array of function array_keys expects array, int\\\\|int\\<1, max\\> given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Price.php + + - + message: "#^Parameter \\#1 \\$string of function strlen expects string, float given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Price.php + + - + message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Price.php + + - + message: "#^Parameter \\#3 \\$lowerPrice of method Mage_Catalog_Model_Layer_Filter_Price\\:\\:loadPreviousPrices\\(\\) expects int\\|null, float\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Price/Algorithm.php + + - + message: "#^Parameter \\#3 \\$upperPrice of method Mage_Catalog_Model_Layer_Filter_Price\\:\\:loadNextPrices\\(\\) expects int\\|null, float\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Price/Algorithm.php + + - + message: "#^Parameter \\#4 \\$upperPrice of method Mage_Catalog_Model_Layer_Filter_Price\\:\\:loadPrices\\(\\) expects int\\|null, float\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Price/Algorithm.php + + - + message: "#^Method Mage_Catalog_Model_Resource_Category_Flat\\:\\:move\\(\\) invoked with 3 parameters, 1 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Observer.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Observer.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\:\\:addImage\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product.php + + - + message: "#^Method Mage_Catalog_Model_Product\\:\\:canBeShowInCategory\\(\\) should return bool but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product.php + + - + message: "#^Method Mage_Catalog_Model_Product\\:\\:duplicate\\(\\) should return \\$this\\(Mage_Catalog_Model_Product\\) but returns Mage_Catalog_Model_Product\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product.php + + - + message: "#^Method Mage_Catalog_Model_Product\\:\\:getDefaultAttributeSetId\\(\\) should return int but returns string\\|null\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product.php + + - + message: "#^Parameter \\#1 \\$tags of method Mage_Core_Model_App\\:\\:cleanCache\\(\\) expects array, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product.php + + - + message: "#^Property Mage_Catalog_Model_Product\\:\\:\\$_typeInstance \\(Mage_Catalog_Model_Product_Type_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product.php + + - + message: "#^Call to function is_null\\(\\) with int\\|string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Api.php + + - + message: "#^Parameter \\#1 \\$productType of method Mage_Catalog_Model_Product_Api\\:\\:_checkProductTypeExists\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Api.php + + - + message: "#^Strict comparison using \\=\\=\\= between \\*NEVER\\* and true will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Product/Api.php + + - + message: "#^Cannot access property \\$additional_attributes on array\\.$#" + count: 5 + path: ../app/code/core/Mage/Catalog/Model/Product/Api/V2.php + + - + message: "#^Cannot access property \\$categories on array\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Product/Api/V2.php + + - + message: "#^Cannot access property \\$stock_data on array\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Api/V2.php + + - + message: "#^Cannot access property \\$tier_price on array\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Api/V2.php + + - + message: "#^Cannot access property \\$website_ids on array\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Product/Api/V2.php + + - + message: "#^Cannot access property \\$websites on array\\.$#" + count: 3 + path: ../app/code/core/Mage/Catalog/Model/Product/Api/V2.php + + - + message: "#^Parameter \\#1 \\$object_or_class of function property_exists expects object\\|string, array given\\.$#" + count: 7 + path: ../app/code/core/Mage/Catalog/Model/Product/Api/V2.php + + - + message: "#^Parameter \\#1 \\$productType of method Mage_Catalog_Model_Product_Api\\:\\:_checkProductTypeExists\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Api/V2.php + + - + message: "#^Parameter \\#2 \\$attributes of method Mage_Catalog_Model_Api_Resource\\:\\:_isAllowedAttribute\\(\\) expects array\\|null, stdClass\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Api/V2.php + + - + message: "#^Parameter \\#2 \\$productData of method Mage_Catalog_Model_Product_Api_V2\\:\\:update\\(\\) expects array, stdClass given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Api/V2.php + + - + message: "#^Parameter \\#3 \\$attributes \\(stdClass\\) of method Mage_Catalog_Model_Product_Api_V2\\:\\:info\\(\\) should be compatible with parameter \\$attributes \\(array\\) of method Mage_Catalog_Model_Product_Api\\:\\:info\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Api/V2.php + + - + message: "#^Strict comparison using \\=\\=\\= between \\*NEVER\\* and true will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Product/Api/V2.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Attribute/Backend/Groupprice/Abstract.php + + - + message: "#^Cannot call method getBackend\\(\\) on bool\\|Mage_Catalog_Model_Resource_Attribute\\.$#" + count: 11 + path: ../app/code/core/Mage/Catalog/Model/Product/Attribute/Media/Api.php + + - + message: "#^Variable \\$file might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Attribute/Media/Api.php + + - + message: "#^Parameter \\#1 \\$data \\(stdClass\\) of method Mage_Catalog_Model_Product_Attribute_Media_Api_V2\\:\\:_prepareImageData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Catalog_Model_Product_Attribute_Media_Api\\:\\:_prepareImageData\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Attribute/Media/Api/V2.php + + - + message: "#^Parameter \\#1 \\$skeletonId of method Mage_Eav_Model_Entity_Attribute_Set\\:\\:initFromSkeleton\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Attribute/Set/Api.php + + - + message: "#^Strict comparison using \\=\\=\\= between \\*NEVER\\* and true will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Attribute/Tierprice/Api.php + + - + message: "#^Method Mage_Catalog_Model_Resource_Product_Compare_Item\\:\\:clean\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Compare/Item.php + + - + message: "#^Call to an undefined method Mage_Catalog_Model_Resource_Product_Flat_Indexer\\:\\:prepareFlatTables\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Flat/Indexer.php + + - + message: "#^Binary operation \"\\*\" between string and 1024 results in an error\\.$#" + count: 3 + path: ../app/code/core/Mage/Catalog/Model/Product/Image.php + + - + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Product/Image.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Image.php + + - + message: "#^Parameter \\#1 \\$height of method Mage_Catalog_Model_Product_Image\\:\\:setHeight\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Image.php + + - + message: "#^Parameter \\#1 \\$heigth of method Varien_Image\\:\\:setWatermarkHeigth\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Image.php + + - + message: "#^Parameter \\#1 \\$size of method Mage_Catalog_Model_Product_Image\\:\\:setWatermarkSize\\(\\) expects array, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Image.php + + - + message: "#^Parameter \\#1 \\$width of method Mage_Catalog_Model_Product_Image\\:\\:setWidth\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Image.php + + - + message: "#^Result of && is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Image.php + + - + message: "#^Cannot call method isIndexable\\(\\) on Mage_Eav_Model_Entity_Attribute_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Indexer/Eav.php + + - + message: "#^Parameter \\#1 \\$type of method Mage_Catalog_Model_Product_Link\\:\\:getAttributes\\(\\) expects null, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Link/Api.php + + - + message: "#^Parameter \\#2 \\$store of method Mage_Catalog_Helper_Product\\:\\:getProduct\\(\\) expects int, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Link/Api.php + + - + message: "#^Parameter \\#5 \\$identifierType \\(null\\) of method Mage_Catalog_Model_Product_Link_Api_V2\\:\\:assign\\(\\) should be compatible with parameter \\$identifierType \\(string\\) of method Mage_Catalog_Model_Product_Link_Api\\:\\:assign\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Link/Api/V2.php + + - + message: "#^Parameter \\#5 \\$identifierType \\(null\\) of method Mage_Catalog_Model_Product_Link_Api_V2\\:\\:update\\(\\) should be compatible with parameter \\$identifierType \\(string\\) of method Mage_Catalog_Model_Product_Link_Api\\:\\:update\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Link/Api/V2.php + + - + message: "#^Method Mage_Catalog_Model_Product_Option\\:\\:getValuesCollection\\(\\) should return Mage_Catalog_Model_Resource_Eav_Mysql4_Product_Option_Value_Collection but returns Mage_Catalog_Model_Resource_Product_Option_Value_Collection\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Option.php + + - + message: "#^Method Mage_Catalog_Model_Product_Option\\:\\:groupFactory\\(\\) should return Mage_Catalog_Model_Product_Option_Type_Default but returns Mage_Core_Model_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Option.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Option.php + + - + message: "#^Parameter \\#1 \\$optionId of method Mage_Catalog_Model_Product\\:\\:getOptionById\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Option/Api.php + + - + message: "#^Parameter \\#1 \\$option_id of method Mage_Catalog_Model_Product_Option\\:\\:deletePrices\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Option/Api.php + + - + message: "#^Parameter \\#1 \\$option_id of method Mage_Catalog_Model_Product_Option\\:\\:deleteTitles\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Option/Api.php + + - + message: "#^Parameter \\#1 \\$option_id of method Mage_Catalog_Model_Product_Option_Value\\:\\:deleteValue\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Option/Api.php + + - + message: "#^Parameter \\#1 \\$optionId of method Mage_Catalog_Model_Product\\:\\:getOptionById\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Option/Observer.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Product/Option/Type/Default.php + + - + message: "#^Call to an undefined method Mage_Catalog_Model_Product_Configuration_Item_Option_Interface\\:\\:getId\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php + + - + message: "#^Call to an undefined method Mage_Catalog_Model_Product_Configuration_Item_Option_Interface\\:\\:setValue\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php + + - + message: "#^Variable \\$value in isset\\(\\) always exists and is not nullable\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php + + - + message: "#^Elseif condition is always true\\.$#" + count: 3 + path: ../app/code/core/Mage/Catalog/Model/Product/Option/Type/Select.php + + - + message: "#^If condition is always true\\.$#" + count: 6 + path: ../app/code/core/Mage/Catalog/Model/Product/Option/Type/Select.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Option/Type/Select.php + + - + message: "#^Parameter \\#1 \\$valueId of method Mage_Catalog_Model_Product_Option\\:\\:getValueById\\(\\) expects int, string given\\.$#" + count: 6 + path: ../app/code/core/Mage/Catalog/Model/Product/Option/Type/Select.php + + - + message: "#^Parameter \\#1 \\$value of method Mage_Catalog_Model_Product_Option_Value\\:\\:addValue\\(\\) expects string, array given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Option/Value/Api.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:getStoreId\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Status.php + + - + message: "#^Method Mage_Catalog_Model_Product_Type\\:\\:priceFactory\\(\\) should return Mage_Catalog_Model_Product_Type_Price but returns Mage_Core_Model_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type.php + + - + message: "#^Call to function is_string\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Abstract.php + + - + message: "#^Method Mage_Catalog_Model_Product_Type_Abstract\\:\\:getAttributeById\\(\\) should return Mage_Eav_Model_Entity_Attribute_Abstract but returns null\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Abstract.php + + - + message: "#^Parameter \\#1 \\$optionId of method Mage_Catalog_Model_Product\\:\\:getOptionById\\(\\) expects int, string given\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Abstract.php + + - + message: "#^Call to function is_array\\(\\) with string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Configurable.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Eav_Model_Entity_Attribute_Abstract will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Configurable.php + + - + message: "#^Call to function is_null\\(\\) with array\\ will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Configurable.php + + - + message: "#^Call to function is_null\\(\\) with int\\|Mage_Core_Model_Store will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Configurable.php + + - + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Configurable.php + + - + message: "#^Method Mage_Catalog_Model_Product_Type_Configurable\\:\\:getProductByAttributes\\(\\) should return Mage_Catalog_Model_Product\\|null but returns Varien_Object\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Configurable.php + + - + message: "#^Parameter \\#2 \\$product of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:setStoreFilter\\(\\) expects null, Mage_Catalog_Model_Product given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Configurable.php + + - + message: "#^Parameter \\#3 \\$product of method Mage_Catalog_Model_Product\\:\\:addCustomOption\\(\\) expects int\\|null, Mage_Catalog_Model_Product given\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Configurable.php + + - + message: "#^Call to function is_null\\(\\) with float will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Configurable/Price.php + + - + message: "#^Cannot access offset 'pricing_value' on true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Configurable/Price.php + + - + message: "#^Parameter \\#1 \\$priceInfo of method Mage_Catalog_Model_Product_Type_Configurable_Price\\:\\:_calcSelectionPrice\\(\\) expects array, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Configurable/Price.php + + - + message: "#^Parameter \\#2 \\$product of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:setStoreFilter\\(\\) expects null, Mage_Catalog_Model_Product given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Configurable/Price.php + + - + message: "#^Parameter \\#2 \\$qty of method Mage_Catalog_Model_Product_Type_Price\\:\\:_applyOptionsPrice\\(\\) expects int, float\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Configurable/Price.php + + - + message: "#^Call to function is_array\\(\\) with string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Grouped.php + + - + message: "#^Parameter \\#3 \\$product of method Mage_Catalog_Model_Product\\:\\:addCustomOption\\(\\) expects int\\|null, Mage_Catalog_Model_Product given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Grouped.php + + - + message: "#^Call to function is_null\\(\\) with float will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Grouped/Price.php + + - + message: "#^Parameter \\#2 \\$product of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:setStoreFilter\\(\\) expects null, Mage_Catalog_Model_Product given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Grouped/Price.php + + - + message: "#^Call to function is_array\\(\\) with float will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Price.php + + - + message: "#^Call to function is_null\\(\\) with float will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Price.php + + - + message: "#^Parameter \\#1 \\$optionId of method Mage_Catalog_Model_Product\\:\\:getOptionById\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Price.php + + - + message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, float given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Price.php + + - + message: "#^Parameter \\#2 \\$qty of method Mage_Catalog_Model_Product_Type_Price\\:\\:_applyOptionsPrice\\(\\) expects int, float\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Product/Type/Price.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute_Abstract\\:\\:isScopeStore\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Resource/Abstract.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute_Abstract\\:\\:isScopeWebsite\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Resource/Abstract.php + + - + message: "#^Cannot call method isScopeStore\\(\\) on Mage_Eav_Model_Entity_Attribute_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Abstract.php + + - + message: "#^Cannot call method isScopeWebsite\\(\\) on Mage_Eav_Model_Entity_Attribute_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Abstract.php + + - + message: "#^Method Mage_Core_Model_Website\\:\\:getStoreIds\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Abstract.php + + - + message: "#^Parameter \\#1 \\$object of method Mage_Catalog_Model_Resource_Abstract\\:\\:_saveAttributeValue\\(\\) expects Mage_Catalog_Model_Abstract, Varien_Object given\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Resource/Abstract.php + + - + message: "#^Parameter \\#1 \\$object of method Mage_Catalog_Model_Resource_Abstract\\:\\:load\\(\\) expects Mage_Core_Model_Abstract, Varien_Object given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Abstract.php + + - + message: "#^Right side of \\|\\| is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Abstract.php + + - + message: "#^Method Mage_Catalog_Model_Resource_Attribute\\:\\:isUsedBySuperProducts\\(\\) should return int but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Attribute.php + + - + message: "#^Parameter \\#1 \\$object of method Mage_Catalog_Model_Resource_Attribute\\:\\:_clearUselessAttributeValues\\(\\) expects Mage_Catalog_Model_Resource_Eav_Attribute, Mage_Eav_Model_Entity_Attribute given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Attribute.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category.php + + - + message: "#^Method Mage_Catalog_Model_Resource_Category\\:\\:checkId\\(\\) should return bool but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category.php + + - + message: "#^Method Mage_Catalog_Model_Resource_Category\\:\\:getChildrenAmount\\(\\) should return int but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category.php + + - + message: "#^Method Mage_Catalog_Model_Resource_Category\\:\\:getChildrenCount\\(\\) should return int but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category.php + + - + message: "#^Parameter \\#1 \\$alias of method Mage_Eav_Model_Entity_Abstract\\:\\:getTable\\(\\) expects string, array\\ given\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category.php + + - + message: "#^Parameter \\#1 \\$categoryIds of method Mage_Catalog_Model_Resource_Category_Collection\\:\\:addIdFilter\\(\\) expects array, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category.php + + - + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category.php + + - + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category.php + + - + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category.php + + - + message: "#^Parameter \\#3 \\$exclude of method Mage_Catalog_Model_Resource_Category_Tree\\:\\:addCollectionData\\(\\) expects array, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category.php + + - + message: "#^Property Mage_Catalog_Model_Resource_Category\\:\\:\\$_isActiveAttributeId \\(int\\) does not accept string\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category.php + + - + message: "#^Property Mage_Catalog_Model_Resource_Category\\:\\:\\$_storeId \\(int\\) on left side of \\?\\? is not nullable\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category.php + + - + message: "#^Property Mage_Catalog_Model_Resource_Category\\:\\:\\$_tree \\(Varien_Data_Tree_Db\\) does not accept Varien_Data_Tree_Dbp\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category.php + + - + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Collection.php + + - + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Collection.php + + - + message: "#^Variable \\$condition might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Collection.php + + - + message: "#^Variable \\$ids in empty\\(\\) always exists and is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Collection.php + + - + message: "#^Call to an undefined method Mage_Catalog_Model_Resource_Category_Collection\\:\\:addSortedField\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php + + - + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php + + - + message: "#^Method Mage_Catalog_Model_Resource_Category_Flat\\:\\:checkId\\(\\) should return bool but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php + + - + message: "#^Parameter \\#1 \\$entityIds of method Mage_Catalog_Model_Resource_Category_Flat\\:\\:_getAttributeValues\\(\\) expects array, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php + + - + message: "#^Parameter \\#1 \\$entityIds of method Mage_Catalog_Model_Resource_Category_Flat\\:\\:_getAttributeValues\\(\\) expects array, int\\|string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php + + - + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php + + - + message: "#^Strict comparison using \\=\\=\\= between Mage_Core_Model_Store and null will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php + + - + message: "#^Variable \\$options might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php + + - + message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Abstract\\:\\:getMainStoreTable\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Flat/Collection.php + + - + message: "#^Parameter \\#1 \\$resource of method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:__construct\\(\\) expects Mage_Core_Model_Resource_Db_Abstract\\|null, Mage_Core_Model_Resource_Abstract\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Flat/Collection.php + + - + message: "#^Variable \\$condition might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Flat/Collection.php + + - + message: "#^Variable \\$ids in empty\\(\\) always exists and is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Flat/Collection.php + + - + message: "#^Call to an undefined method Zend_Db_Select\\:\\:insertFromSelect\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php + + - + message: "#^Parameter \\#2 \\$true of method Varien_Db_Adapter_Interface\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php + + - + message: "#^Parameter \\#2 \\$true of method Varien_Db_Adapter_Pdo_Mysql\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php + + - + message: "#^Parameter \\#3 \\$false of method Varien_Db_Adapter_Interface\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php + + - + message: "#^Parameter \\#3 \\$false of method Varien_Db_Adapter_Pdo_Mysql\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php + + - + message: "#^Variable \\$anchorProductsTable might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php + + - + message: "#^Variable \\$anchorTable might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php + + - + message: "#^Variable \\$enabledTable might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php + + - + message: "#^Call to an undefined method Zend_Db_Adapter_Abstract\\:\\:getCheckSql\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + + - + message: "#^Call to an undefined method Zend_Db_Adapter_Abstract\\:\\:getConcatSql\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + + - + message: "#^Call to an undefined method Zend_Db_Adapter_Abstract\\:\\:getLengthSql\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Resource_Category_Collection will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + + - + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + + - + message: "#^Method Mage_Catalog_Model_Resource_Category_Tree\\:\\:_getItemIsActive\\(\\) invoked with 2 parameters, 1 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + + - + message: "#^Parameter \\#1 \\$category \\(Mage_Catalog_Model_Category\\) of method Mage_Catalog_Model_Resource_Category_Tree\\:\\:move\\(\\) should be compatible with parameter \\$node \\(Varien_Data_Tree_Node\\) of method Varien_Data_Tree_Dbp\\:\\:move\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + + - + message: "#^Parameter \\#1 \\$children of method Varien_Data_Tree_Dbp\\:\\:addChildNodes\\(\\) expects Varien_Data_Tree_Node, array\\\\> given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + + - + message: "#^Parameter \\#1 \\$connection of method Varien_Data_Tree_Dbp\\:\\:__construct\\(\\) expects Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + + - + message: "#^Parameter \\#1 \\$node of method Varien_Data_Tree_Dbp\\:\\:move\\(\\) expects Varien_Data_Tree_Node, Mage_Catalog_Model_Category given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + + - + message: "#^Parameter \\#2 \\$cols of method Zend_Db_Select\\:\\:from\\(\\) expects array\\|string\\|Zend_Db_Expr, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + + - + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + + - + message: "#^Parameter \\#3 \\$parentNode of method Varien_Data_Tree_Dbp\\:\\:addChildNodes\\(\\) expects Varien_Data_Tree_Node, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + + - + message: "#^Property Mage_Catalog_Model_Resource_Category_Tree\\:\\:\\$_isActiveAttributeId \\(int\\) does not accept string\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + + - + message: "#^Result of && is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + + - + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Collection/Abstract.php + + - + message: "#^Parameter \\#2 \\$alias of method Varien_Db_Adapter_Interface\\:\\:quoteColumnAs\\(\\) expects string, null given\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Resource/Collection/Abstract.php + + - + message: "#^Property Mage_Catalog_Model_Resource_Config\\:\\:\\$_storeId \\(int\\) on left side of \\?\\? is not nullable\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Config.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Eav/Attribute.php + + - + message: "#^Binary operation \"\\-\" between int and non\\-falsy\\-string results in an error\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Resource/Layer/Filter/Price.php + + - + message: "#^Binary operation \"\\-\" between non\\-falsy\\-string and 1 results in an error\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Resource/Layer/Filter/Price.php + + - + message: "#^Call to function is_null\\(\\) with Varien_Db_Select will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Layer/Filter/Price.php + + - + message: "#^Call to an undefined method Mage_Catalog_Model_Resource_Category\\:\\:refreshProductIndex\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product.php + + - + message: "#^Method Mage_Catalog_Model_Resource_Product\\:\\:getIdBySku\\(\\) should return int\\|false but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product.php + + - + message: "#^Parameter \\#1 \\$alias of method Mage_Eav_Model_Entity_Abstract\\:\\:getTable\\(\\) expects string, array\\ given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product.php + + - + message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, int given\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product.php + + - + message: "#^Parameter \\#1 \\$product of method Mage_Catalog_Model_Resource_Product\\:\\:getCategoryIds\\(\\) expects Mage_Catalog_Model_Product, Varien_Object given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product.php + + - + message: "#^Parameter \\#1 \\$object of method Mage_Catalog_Model_Resource_Abstract\\:\\:_saveAttributeValue\\(\\) expects Mage_Catalog_Model_Abstract, Varien_Object given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Action.php + + - + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Action.php + + - + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Action.php + + - + message: "#^Method Mage_Catalog_Model_Resource_Product_Attribute_Backend_Media\\:\\:insertGallery\\(\\) should return int but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Attribute/Backend/Media.php + + - + message: "#^Call to an undefined method Varien_Object\\:\\:formatUrlKey\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Attribute/Backend/Urlkey.php + + - + message: "#^Method Mage_Catalog_Model_Url\\:\\:refreshProductRewrites\\(\\) invoked with 3 parameters, 1 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Attribute/Backend/Urlkey.php + + - + message: "#^Parameter \\#1 \\$storeId of method Mage_Catalog_Model_Url\\:\\:refreshProductRewrites\\(\\) expects int, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Attribute/Backend/Urlkey.php + + - + message: "#^Parameter \\#2 \\$resourceModel of method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:_init\\(\\) expects Mage_Core_Model_Resource_Db_Abstract\\|null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Attribute/Collection.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getAllTableColumns\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getAttributeForSelect\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getAttributeSortColumn\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getFlatTableName\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:setStoreId\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + + - + message: "#^Call to function is_null\\(\\) with float will always evaluate to false\\.$#" + count: 3 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + + - + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + + - + message: "#^Method Mage_Catalog_Model_Resource_Product_Collection\\:\\:_addUrlRewrite\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + + - + message: "#^Method Mage_Catalog_Model_Resource_Product_Collection\\:\\:getProductCountSelect\\(\\) should return Varien_Db_Select but returns Zend_Db_Select\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + + - + message: "#^Parameter \\#1 \\$date of method Mage_Core_Model_Resource_Abstract\\:\\:formatDate\\(\\) expects string\\|Zend_Date\\|true\\|null, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + + - + message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + + - + message: "#^Parameter \\#1 \\$select of method Mage_Catalog_Model_Resource_Product_Collection\\:\\:_getSelectCountSql\\(\\) expects null, Varien_Db_Select given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + + - + message: "#^Parameter \\#4 \\$cond of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:joinTable\\(\\) expects array\\|null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + + - + message: "#^Property Mage_Catalog_Model_Resource_Product_Collection\\:\\:\\$_allIdsCache \\(array\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + + - + message: "#^Property Mage_Catalog_Model_Resource_Product_Collection\\:\\:\\$_productCountSelect \\(Zend_Db_Select\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + + - + message: "#^Property Mage_Catalog_Model_Resource_Product_Collection\\:\\:\\$_urlRewriteCategory \\(int\\) does not accept default value of type string\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + + - + message: "#^Variable \\$websiteId might not be defined\\.$#" + count: 3 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + + - + message: "#^Method Mage_Catalog_Model_Resource_Product_Compare_Item\\:\\:getCount\\(\\) should return int but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Compare/Item.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Compare/Item/Collection.php + + - + message: "#^Parameter \\#1 \\$object of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:setObject\\(\\) expects Varien_Object\\|null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Compare/Item/Collection.php + + - + message: "#^Method Mage_Catalog_Model_Resource_Product_Flat\\:\\:getTypeId\\(\\) should return int but returns string\\|null\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Flat.php + + - + message: "#^Parameter \\#1 \\$entity of method Mage_Eav_Model_Entity_Attribute_Abstract\\:\\:setEntity\\(\\) expects Mage_Eav_Model_Entity_Abstract, Mage_Core_Model_Resource_Abstract given\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Flat/Indexer.php + + - + message: "#^Method Mage_Catalog_Model_Resource_Product_Indexer_Abstract\\:\\:_getAttribute\\(\\) should return Mage_Catalog_Model_Resource_Eav_Attribute but returns Mage_Eav_Model_Entity_Attribute_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Abstract.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav.php + + - + message: "#^Parameter \\#5 \\$condition of method Mage_Catalog_Model_Resource_Product_Indexer_Abstract\\:\\:_addAttributeToSelect\\(\\) expects Zend_Db_Expr\\|null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav/Abstract.php + + - + message: "#^Parameter \\#5 \\$condition of method Mage_Catalog_Model_Resource_Product_Indexer_Abstract\\:\\:_addAttributeToSelect\\(\\) expects Zend_Db_Expr\\|null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav/Decimal.php + + - + message: "#^Parameter \\#5 \\$condition of method Mage_Catalog_Model_Resource_Product_Indexer_Abstract\\:\\:_addAttributeToSelect\\(\\) expects Zend_Db_Expr\\|null, string given\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav/Source.php + + - + message: "#^Binary operation \"\\*\" between string and 0\\.3 results in an error\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php + + - + message: "#^Binary operation \"\\+\" between int\\<0, max\\> and string results in an error\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php + + - + message: "#^Call to an undefined method Mage_Catalog_Model_Resource_Product_Indexer_Price_Interface\\:\\:getIsComposite\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php + + - + message: "#^Cannot call method setTypeId\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php + + - + message: "#^Parameter \\#1 \\$date of method Mage_Core_Model_Resource_Abstract\\:\\:formatDate\\(\\) expects string\\|Zend_Date\\|true\\|null, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php + + - + message: "#^Parameter \\#5 \\$condition of method Mage_Catalog_Model_Resource_Product_Indexer_Abstract\\:\\:_addAttributeToSelect\\(\\) expects Zend_Db_Expr\\|null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price/Configurable.php + + - + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price/Default.php + + - + message: "#^Parameter \\#3 \\$false of method Varien_Db_Adapter_Pdo_Mysql\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" + count: 5 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price/Default.php + + - + message: "#^Parameter \\#5 \\$condition of method Mage_Catalog_Model_Resource_Product_Indexer_Abstract\\:\\:_addAttributeToSelect\\(\\) expects Zend_Db_Expr\\|null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price/Default.php + + - + message: "#^Parameter \\#3 \\$false of method Varien_Db_Adapter_Pdo_Mysql\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price/Grouped.php + + - + message: "#^Parameter \\#5 \\$condition of method Mage_Catalog_Model_Resource_Product_Indexer_Abstract\\:\\:_addAttributeToSelect\\(\\) expects Zend_Db_Expr\\|null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price/Grouped.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Link/Collection.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Link/Collection.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Link/Collection.php + + - + message: "#^Parameter \\#2 \\$alias of method Varien_Db_Adapter_Interface\\:\\:quoteColumnAs\\(\\) expects string, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Link/Collection.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Link/Product/Collection.php + + - + message: "#^Left side of && is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Link/Product/Collection.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Link/Product/Collection.php + + - + message: "#^Parameter \\#2 \\$newOptionId of method Mage_Catalog_Model_Product_Option_Value\\:\\:duplicate\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Option.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Option/Collection.php + + - + message: "#^Parameter \\#2 \\$product of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:getAttributeById\\(\\) expects null, Mage_Catalog_Model_Product given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Type/Configurable/Attribute/Collection.php + + - + message: "#^Parameter \\#2 \\$product of method Mage_Catalog_Model_Resource_Product\\:\\:refreshEnabledIndex\\(\\) expects Mage_Catalog_Model_Product\\|null, array given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Website.php + + - + message: "#^Parameter \\#1 \\$array of function array_reverse expects array, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Setup.php + + - + message: "#^Parameter \\#3 \\$default of method Mage_Eav_Model_Entity_Setup\\:\\:_getValue\\(\\) expects string\\|null, int given\\.$#" + count: 15 + path: ../app/code/core/Mage/Catalog/Model/Resource/Setup.php + + - + message: "#^Parameter \\#1 \\$categoryIds of method Mage_Catalog_Model_Resource_Url\\:\\:_getCategories\\(\\) expects array\\|int, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Url.php + + - + message: "#^Parameter \\#1 \\$productIds of method Mage_Catalog_Model_Resource_Url\\:\\:_getProducts\\(\\) expects array\\|int, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Url.php + + - + message: "#^Parameter \\#3 \\$storeId of method Mage_Catalog_Model_Resource_Url\\:\\:_getProductAttribute\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Url.php + + - + message: "#^Variable \\$category might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Url.php + + - + message: "#^Variable \\$rootCategoryPath might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Resource/Url.php + + - + message: "#^Variable \\$rootCategoryPathLength might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Resource/Url.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Resource_Url will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Url.php + + - + message: "#^Parameter \\#2 \\$categoryIds of method Mage_Catalog_Model_Resource_Url\\:\\:prepareRewrites\\(\\) expects array\\|int\\|null, false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Url.php + + - + message: "#^Parameter \\#2 \\$categoryIds of method Mage_Catalog_Model_Resource_Url\\:\\:prepareRewrites\\(\\) expects array\\|int\\|null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Url.php + + - + message: "#^Property Mage_Catalog_Model_Url\\:\\:\\$_rewrite \\(Varien_Object\\) does not accept null\\.$#" + count: 2 + path: ../app/code/core/Mage/Catalog/Model/Url.php + + - + message: "#^Property Mage_Catalog_Model_Url\\:\\:\\$_saveRewritesHistory \\(bool\\) on left side of \\?\\? is not nullable\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/Model/Url.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/controllers/CategoryController.php + + - + message: "#^Parameter \\#1 \\$store of method Mage_Core_Model_Locale\\:\\:isStoreDateInInterval\\(\\) expects int\\|Mage_Core_Model_Store\\|string, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/controllers/CategoryController.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/controllers/ProductController.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/controllers/ProductController.php + + - + message: "#^Parameter \\#1 \\$store of method Mage_Core_Model_Locale\\:\\:isStoreDateInInterval\\(\\) expects int\\|Mage_Core_Model_Store\\|string, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/controllers/ProductController.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Catalog/controllers/Seo/SitemapController.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Aggregation.php + + - + message: "#^Call to an undefined method Mage_CatalogIndex_Model_Resource_Attribute\\:\\:checkCount\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Attribute.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Product_Type_Abstract will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Data/Abstract.php + + - + message: "#^Parameter \\#1 \\$products of method Mage_CatalogIndex_Model_Data_Abstract\\:\\:getAttributeData\\(\\) expects array, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Data/Abstract.php + + - + message: "#^Property Mage_CatalogIndex_Model_Data_Abstract\\:\\:\\$_typeInstance \\(Mage_Catalog_Model_Product_Type_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Data/Abstract.php + + - + message: "#^Variable \\$idField might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Data/Abstract.php + + - + message: "#^Variable \\$whereField might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Data/Abstract.php + + - + message: "#^Parameter \\#1 \\$product \\(array\\) of method Mage_CatalogIndex_Model_Data_Grouped\\:\\:getFinalPrice\\(\\) should be compatible with parameter \\$product \\(int\\) of method Mage_CatalogIndex_Model_Data_Abstract\\:\\:getFinalPrice\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Data/Grouped.php + + - + message: "#^Return type \\(false\\) of method Mage_CatalogIndex_Model_Data_Grouped\\:\\:getFinalPrice\\(\\) should be compatible with return type \\(float\\) of method Mage_CatalogIndex_Model_Data_Abstract\\:\\:getFinalPrice\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Data/Grouped.php + + - + message: "#^Property Mage_CatalogIndex_Model_Data_Simple\\:\\:\\$_haveChildren \\(array\\\\) does not accept default value of type false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Data/Simple.php + + - + message: "#^Property Mage_CatalogIndex_Model_Data_Virtual\\:\\:\\$_haveChildren \\(array\\\\) does not accept default value of type false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Data/Virtual.php + + - + message: "#^Call to function is_array\\(\\) with mixed will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Indexer.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Indexer.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Indexer.php + + - + message: "#^Variable \\$kill in isset\\(\\) always exists and is not nullable\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Indexer.php + + - + message: "#^Variable \\$storeObject might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/CatalogIndex/Model/Indexer.php + + - + message: "#^Return type \\(string\\) of method Mage_CatalogIndex_Model_Indexer_Eav\\:\\:_getIndexableAttributeConditions\\(\\) should be compatible with return type \\(array\\) of method Mage_CatalogIndex_Model_Indexer_Abstract\\:\\:_getIndexableAttributeConditions\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Indexer/Eav.php + + - + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Indexer/Minimalprice.php + + - + message: "#^Return type \\(string\\) of method Mage_CatalogIndex_Model_Indexer_Price\\:\\:_getIndexableAttributeConditions\\(\\) should be compatible with return type \\(array\\) of method Mage_CatalogIndex_Model_Indexer_Abstract\\:\\:_getIndexableAttributeConditions\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Indexer/Price.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Price.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Resource/Aggregation.php + + - + message: "#^Parameter \\#1 \\$aggregationId of method Mage_CatalogIndex_Model_Resource_Aggregation\\:\\:_saveTagRelations\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Resource/Aggregation.php + + - + message: "#^Parameter \\#1 \\$date of method Mage_Core_Model_Resource_Abstract\\:\\:formatDate\\(\\) expects string\\|Zend_Date\\|true\\|null, int\\<1, max\\> given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Resource/Aggregation.php + + - + message: "#^Parameter \\#1 \\$select of method Mage_CatalogIndex_Model_Resource_Data_Abstract\\:\\:_addAttributeFilter\\(\\) expects Varien_Db_Select, Zend_Db_Select given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Resource/Data/Configurable.php + + - + message: "#^Parameter \\#1 \\$select of method Mage_CatalogIndex_Model_Resource_Data_Abstract\\:\\:_addAttributeFilter\\(\\) expects Varien_Db_Select, Zend_Db_Select given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Resource/Data/Grouped.php + + - + message: "#^Method Mage_CatalogIndex_Model_Resource_Indexer_Abstract\\:\\:saveIndex\\(\\) with return type void returns mixed but should not return anything\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Resource/Indexer/Abstract.php + + - + message: "#^Binary operation \"\\*\" between string and float results in an error\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Resource/Price.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Resource/Setup.php + + - + message: "#^Parameter \\#3 \\$storeIds of method Mage_CatalogIndex_Model_Resource_Setup\\:\\:_setWebsiteInfo\\(\\) expects array, Mage_Core_Model_Website given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Resource/Setup.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Customer_Model_Resource_Group_Collection will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Retreiver.php + + - + message: "#^Method Mage_CatalogIndex_Model_Retreiver\\:\\:getRetreiver\\(\\) should return Mage_CatalogIndex_Model_Data_Abstract but returns Mage_Core_Model_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogIndex/Model/Retreiver.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Block/Adminhtml/Form/Field/Customergroup.php + + - + message: "#^Parameter \\#1 \\$value of method Mage_Core_Block_Html_Select\\:\\:addOption\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Block/Adminhtml/Form/Field/Customergroup.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Block/Adminhtml/Form/Field/Minsaleqty.php + + - + message: "#^Property Mage_CatalogInventory_Block_Adminhtml_Form_Field_Minsaleqty\\:\\:\\$_groupRenderer \\(Mage_CatalogInventory_Block_Adminhtml_Form_Field_Customergroup\\) does not accept Mage_Core_Block_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Block/Adminhtml/Form/Field/Minsaleqty.php + + - + message: "#^If condition is always true\\.$#" + count: 4 + path: ../app/code/core/Mage/CatalogInventory/Model/Observer.php + + - + message: "#^Method Mage_CatalogInventory_Model_Observer\\:\\:_getQuoteItemQtyForCheck\\(\\) should return int but returns float\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Observer.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/CatalogInventory/Model/Observer.php + + - + message: "#^Parameter \\#1 \\$product of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:getForceChildItemQtyChanges\\(\\) expects null, Mage_Catalog_Model_Product given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Observer.php + + - + message: "#^Parameter \\#1 \\$type of method Mage_Sales_Model_Quote\\:\\:removeErrorInfosByParams\\(\\) expects string, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Observer.php + + - + message: "#^Parameter \\#2 \\$product of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:prepareQuoteItemQty\\(\\) expects null, Mage_Catalog_Model_Product given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Observer.php + + - + message: "#^Binary operation \"\\*\" between string and 0\\.3 results in an error\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock.php + + - + message: "#^Binary operation \"\\+\" between int\\<0, max\\> and string results in an error\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock.php + + - + message: "#^Cannot call method setTypeId\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock.php + + - + message: "#^Parameter \\#2 \\$true of method Varien_Db_Adapter_Pdo_Mysql\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock/Configurable.php + + - + message: "#^Parameter \\#3 \\$false of method Varien_Db_Adapter_Pdo_Mysql\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" + count: 2 + path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock/Configurable.php + + - + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock/Default.php + + - + message: "#^Parameter \\#2 \\$true of method Varien_Db_Adapter_Pdo_Mysql\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" + count: 2 + path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock/Default.php + + - + message: "#^Parameter \\#3 \\$false of method Varien_Db_Adapter_Pdo_Mysql\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" + count: 3 + path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock/Default.php + + - + message: "#^Parameter \\#2 \\$true of method Varien_Db_Adapter_Pdo_Mysql\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock/Grouped.php + + - + message: "#^Parameter \\#3 \\$false of method Varien_Db_Adapter_Pdo_Mysql\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" + count: 2 + path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock/Grouped.php + + - + message: "#^Parameter \\#1 \\$fieldName of method Varien_Db_Adapter_Interface\\:\\:prepareSqlCondition\\(\\) expects string, bool given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Stock.php + + - + message: "#^Parameter \\#2 \\$true of method Varien_Db_Adapter_Interface\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Stock.php + + - + message: "#^Parameter \\#4 \\$cond of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:joinTable\\(\\) expects array\\|null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Stock.php + + - + message: "#^Property Mage_CatalogInventory_Model_Resource_Stock\\:\\:\\$_isConfigBackorders \\(bool\\) does not accept int\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Stock.php + + - + message: "#^Property Mage_CatalogInventory_Model_Resource_Stock\\:\\:\\$_isConfigManageStock \\(bool\\) does not accept int\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Stock.php + + - + message: "#^Parameter \\#2 \\$true of method Varien_Db_Adapter_Pdo_Mysql\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Stock/Item.php + + - + message: "#^Return type \\(Varien_Db_Select\\) of method Mage_CatalogInventory_Model_Resource_Stock_Item_Collection\\:\\:_initSelect\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Resource_Db_Collection_Abstract\\)\\) of method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:_initSelect\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Stock/Item/Collection.php + + - + message: "#^Parameter \\#1 \\$products of method Mage_CatalogInventory_Model_Resource_Stock_Item_Collection\\:\\:addProductsFilter\\(\\) expects array\\, Mage_Catalog_Model_Resource_Product_Collection given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Stock.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Stock/Item.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Stock/Item.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Stock/Item.php + + - + message: "#^Property Mage_CatalogInventory_Model_Stock_Item\\:\\:\\$_productInstance \\(Mage_Catalog_Model_Product\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Stock/Item.php + + - + message: "#^Ternary operator condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Stock/Item.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Stock/Item.php + + - + message: "#^Variable \\$parentItem in empty\\(\\) always exists and is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Stock/Item.php + + - + message: "#^Parameter \\#1 \\$sku of method Mage_Catalog_Model_Product\\:\\:getIdBySku\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Stock/Item/Api.php + + - + message: "#^Parameter \\#1 \\$sku of method Mage_Catalog_Model_Product\\:\\:getIdBySku\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Stock/Item/Api/V2.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/CatalogInventory/Model/Stock/Status.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogInventory/Model/Stock/Status.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogRule/Model/Action/Index/Refresh.php + + - + message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, int given\\.$#" + count: 4 + path: ../app/code/core/Mage/CatalogRule/Model/Action/Index/Refresh.php + + - + message: "#^Return type \\(int\\) of method Mage_CatalogRule_Model_Action_Index_Refresh_Row\\:\\:_getProduct\\(\\) should be compatible with return type \\(null\\) of method Mage_CatalogRule_Model_Action_Index_Refresh\\:\\:_getProduct\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/CatalogRule/Model/Action/Index/Refresh/Row.php + + - + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogRule/Model/Observer.php + + - + message: "#^Parameter \\#1 \\$combine of method Mage_CatalogRule_Model_Observer\\:\\:_removeAttributeFromConditions\\(\\) expects Mage_CatalogRule_Model_Rule_Condition_Combine, Mage_Rule_Model_Condition_Combine given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogRule/Model/Observer.php + + - + message: "#^Variable \\$gId might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogRule/Model/Observer.php + + - + message: "#^Variable \\$pId might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogRule/Model/Observer.php + + - + message: "#^Variable \\$wId might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogRule/Model/Observer.php + + - + message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, float given\\.$#" + count: 2 + path: ../app/code/core/Mage/CatalogRule/Model/Resource/Rule.php + + - + message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, int given\\.$#" + count: 3 + path: ../app/code/core/Mage/CatalogRule/Model/Resource/Rule.php + + - + message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, int\\<0, 86398\\>\\|int\\<86400, max\\> given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogRule/Model/Resource/Rule.php + + - + message: "#^Variable \\$indexAlias might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogRule/Model/Resource/Rule/Product/Price.php + + - + message: "#^Call to an undefined method Mage_Rule_Model_Condition_Combine\\:\\:collectValidatedAttributes\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogRule/Model/Rule.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogRule/Model/Rule.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogRule/Model/Rule.php + + - + message: "#^Parameter \\#1 \\$product of method Mage_CatalogRule_Model_Resource_Rule\\:\\:applyAllRules\\(\\) expects int\\|Mage_Catalog_Model_Product\\|null, Mage_Core_Model_Abstract given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogRule/Model/Rule.php + + - + message: "#^Parameter \\#2 \\$product of method Mage_CatalogRule_Model_Resource_Rule\\:\\:applyToProduct\\(\\) expects Mage_Catalog_Model_Product, Mage_Core_Model_Abstract given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogRule/Model/Rule.php + + - + message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Block/Advanced/Form.php + + - + message: "#^Parameter \\#1 \\$currency of method Mage_Directory_Model_Currency\\:\\:getCurrencyRates\\(\\) expects string, Mage_Directory_Model_Currency given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Block/Advanced/Form.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Block/Advanced/Form.php + + - + message: "#^Parameter \\#2 \\$offset of function array_slice expects int, float given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Block/Advanced/Result.php + + - + message: "#^Parameter \\#3 \\$length of function array_slice expects int\\|null, float given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Block/Advanced/Result.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Block/Autocomplete.php + + - + message: "#^Call to function is_null\\(\\) with Mage_CatalogSearch_Model_Resource_Fulltext_Collection will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Block/Result.php + + - + message: "#^Property Mage_CatalogSearch_Block_Result\\:\\:\\$_productCollection \\(Mage_CatalogSearch_Model_Resource_Fulltext_Collection\\) does not accept Mage_Eav_Model_Entity_Collection_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Block/Result.php + + - + message: "#^Variable \\$temp might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Block/Term.php + + - + message: "#^Variable \\$termKeys might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/CatalogSearch/Block/Term.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Helper/Data.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 3 + path: ../app/code/core/Mage/CatalogSearch/Helper/Data.php + + - + message: "#^Property Mage_CatalogSearch_Helper_Data\\:\\:\\$_queryText \\(string\\) in isset\\(\\) is not nullable\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Helper/Data.php + + - + message: "#^Call to function is_array\\(\\) with bool\\|string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Model/Advanced.php + + - + message: "#^Call to function is_null\\(\\) with Mage_CatalogSearch_Model_Resource_Advanced_Collection will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Model/Advanced.php + + - + message: "#^Method Mage_CatalogSearch_Model_Advanced\\:\\:getProductCollection\\(\\) should return Mage_CatalogSearch_Model_Resource_Advanced_Collection but returns array\\|float\\|int\\|string\\|false\\|null\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Model/Advanced.php + + - + message: "#^Return type \\(bool\\) of method Mage_CatalogSearch_Model_Layer_Filter_Attribute\\:\\:_getIsFilterableAttribute\\(\\) should be compatible with return type \\(Mage_Catalog_Model_Resource_Eav_Attribute\\) of method Mage_Catalog_Model_Layer_Filter_Attribute\\:\\:_getIsFilterableAttribute\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Model/Layer/Filter/Attribute.php + + - + message: "#^Variable \\$select might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Advanced/Collection.php + + - + message: "#^Call to function is_array\\(\\) with bool\\|string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php + + - + message: "#^If condition is always true\\.$#" + count: 4 + path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php + + - + message: "#^Parameter \\#1 \\$entity of method Mage_Eav_Model_Entity_Attribute_Abstract\\:\\:setEntity\\(\\) expects Mage_Eav_Model_Entity_Abstract, Mage_Core_Model_Resource_Abstract given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php + + - + message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php + + - + message: "#^Parameter \\#1 \\$typeId of method Mage_CatalogSearch_Model_Resource_Fulltext\\:\\:_getProductTypeInstance\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php + + - + message: "#^Parameter \\#2 \\$typeId of method Mage_CatalogSearch_Model_Resource_Fulltext\\:\\:_getProductChildrenIds\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Collection.php + + - + message: "#^If condition is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Collection.php + + - + message: "#^Property Mage_CatalogSearch_Model_Resource_Fulltext_Collection\\:\\:\\$_relevanceSortOrder \\(null\\) does not accept default value of type int\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Collection.php + + - + message: "#^Property Mage_CatalogSearch_Model_Resource_Fulltext_Collection\\:\\:\\$_relevanceSortOrder \\(null\\) does not accept int\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Collection.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Search/Collection.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Search/Collection.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/CatalogSearch/controllers/TermController.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Centinel/Block/Adminhtml/Validation.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Centinel/Block/Adminhtml/Validation/Form.php + + - + message: "#^Right side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Centinel/Block/Adminhtml/Validation/Form.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Centinel/Helper/Data.php + + - + message: "#^Cannot call method setItem\\(\\) on array\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Block/Cart/Abstract.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Block/Cart/Crosssell.php + + - + message: "#^Variable \\$ninProductIds in empty\\(\\) always exists and is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Block/Cart/Crosssell.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Block/Cart/Item/Renderer.php + + - + message: "#^Right side of && is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Block/Cart/Item/Renderer.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Block/Cart/Item/Renderer/Configurable.php + + - + message: "#^Parameter \\#1 \\$productThumbnail of method Mage_Checkout_Block_Cart_Item_Renderer\\:\\:overrideProductThumbnail\\(\\) expects Mage_Catalog_Helper_Image, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Block/Cart/Item/Renderer/Grouped.php + + - + message: "#^Property Mage_Checkout_Block_Cart_Shipping\\:\\:\\$_address \\(array\\) does not accept Mage_Sales_Model_Quote_Address\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Block/Cart/Shipping.php + + - + message: "#^Method Mage_Checkout_Block_Cart_Sidebar\\:\\:_addTax\\(\\) is unused\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Block/Cart/Sidebar.php + + - + message: "#^Left side of && is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Checkout/Block/Links.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Block/Onepage/Abstract.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Quote_Address will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Block/Onepage/Billing.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Block/Onepage/Billing.php + + - + message: "#^Property Mage_Checkout_Block_Onepage_Billing\\:\\:\\$_taxvat \\(Mage_Customer_Block_Widget_Taxvat\\) does not accept Mage_Core_Block_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Block/Onepage/Billing.php + + - + message: "#^Right side of && is always true\\.$#" + count: 3 + path: ../app/code/core/Mage/Checkout/Block/Onepage/Billing.php + + - + message: "#^Method Mage_Checkout_Block_Onepage_Progress\\:\\:getShippingPriceInclTax\\(\\) should return float but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Block/Onepage/Progress.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Quote_Address will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Block/Onepage/Shipping.php + + - + message: "#^Property Mage_Checkout_Block_Onepage_Success\\:\\:\\$_order is unused\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Block/Onepage/Success.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Controller/Action.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Controller/Action.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Helper/Data.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Helper/Data.php + + - + message: "#^Call to function is_null\\(\\) with int\\|string will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Checkout/Model/Api/Resource.php + + - + message: "#^Variable \\$storeId might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Api/Resource.php + + - + message: "#^Call to function is_null\\(\\) with int\\|string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Api/Resource/Customer.php + + - + message: "#^Method Mage_Checkout_Model_Cart\\:\\:saveQuote\\(\\) should return Mage_Checkout_Model_Cart_Interface but return statement is missing\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Cart.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 5 + path: ../app/code/core/Mage/Checkout/Model/Cart.php + + - + message: "#^Parameter \\#2 \\$message of method Mage_Checkout_Model_Session\\:\\:addQuoteItemMessage\\(\\) expects Mage_Core_Model_Message, Mage_Core_Model_Message_Error\\|Mage_Core_Model_Message_Notice\\|Mage_Core_Model_Message_Success\\|Mage_Core_Model_Message_Warning given\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Cart.php + + - + message: "#^Result of && is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Cart.php + + - + message: "#^Variable \\$product might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Cart.php + + - + message: "#^Variable \\$productId might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Cart.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Cart/Api.php + + - + message: "#^Variable \\$order might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Cart/Api.php + + - + message: "#^Variable \\$quote might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Cart/Api.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Cart/Coupon/Api.php + + - + message: "#^Variable \\$customer might not be defined\\.$#" + count: 4 + path: ../app/code/core/Mage/Checkout/Model/Cart/Customer/Api.php + + - + message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Checkout_Model_Cart_Customer_Api_V2\\:\\:_prepareCustomerAddressData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Checkout_Model_Cart_Customer_Api\\:\\:_prepareCustomerAddressData\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Cart/Customer/Api/V2.php + + - + message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Checkout_Model_Cart_Customer_Api_V2\\:\\:_prepareCustomerData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Checkout_Model_Cart_Customer_Api\\:\\:_prepareCustomerData\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Cart/Customer/Api/V2.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Cart/Customer/Api/V2.php + + - + message: "#^Call to function is_null\\(\\) with int\\|string will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Checkout/Model/Cart/Payment/Api.php + + - + message: "#^Right side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Cart/Payment/Api.php + + - + message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Checkout_Model_Cart_Payment_Api_V2\\:\\:_preparePaymentData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Checkout_Model_Cart_Payment_Api\\:\\:_preparePaymentData\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Cart/Payment/Api/V2.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Cart/Payment/Api/V2.php + + - + message: "#^Call to function is_null\\(\\) with int\\|string will always evaluate to false\\.$#" + count: 4 + path: ../app/code/core/Mage/Checkout/Model/Cart/Product/Api.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Cart/Product/Api.php + + - + message: "#^Method Mage_Checkout_Model_Cart_Product_Api_V2\\:\\:_prepareProductsData\\(\\) should return array but returns mixed\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Cart/Product/Api/V2.php + + - + message: "#^Call to function is_null\\(\\) with int\\|string will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Checkout/Model/Cart/Shipping/Api.php + + - + message: "#^Variable \\$ratesResult might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Cart/Shipping/Api.php + + - + message: "#^Method Mage_Checkout_Model_Session\\:\\:getQuoteId\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Observer.php + + - + message: "#^Method Mage_Checkout_Model_Session\\:\\:unsetAll\\(\\) should return \\$this\\(Mage_Checkout_Model_Session\\) but return statement is missing\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Session.php + + - + message: "#^Parameter \\#1 \\$quoteId of method Mage_Checkout_Model_Session\\:\\:setQuoteId\\(\\) expects int, null given\\.$#" + count: 2 + path: ../app/code/core/Mage/Checkout/Model/Session.php + + - + message: "#^Call to an undefined method Mage_Sales_Model_Order\\:\\:createFromQuoteAddress\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Type/Abstract.php + + - + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Checkout/Model/Type/Abstract.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Checkout/Model/Type/Abstract.php + + - + message: "#^If condition is always true\\.$#" + count: 5 + path: ../app/code/core/Mage/Checkout/Model/Type/Multishipping.php + + - + message: "#^Method Mage_Sales_Model_Quote\\:\\:getBillingAddress\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Type/Multishipping.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Type/Multishipping.php + + - + message: "#^Result of && is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Checkout/Model/Type/Multishipping.php + + - + message: "#^Right side of && is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Checkout/Model/Type/Multishipping.php + + - + message: "#^Variable \\$paymentMethod in empty\\(\\) always exists and is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Type/Multishipping.php + + - + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Checkout/Model/Type/Onepage.php + + - + message: "#^Negated boolean expression is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Type/Onepage.php + + - + message: "#^Parameter \\#3 \\$storeId of method Mage_Customer_Model_Customer\\:\\:sendNewAccountEmail\\(\\) expects string, int given\\.$#" + count: 2 + path: ../app/code/core/Mage/Checkout/Model/Type/Onepage.php + + - + message: "#^Property Mage_Checkout_Model_Type_Onepage\\:\\:\\$_quote \\(Mage_Sales_Model_Quote\\) on left side of \\?\\? is not nullable\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Type/Onepage.php + + - + message: "#^Right side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/Model/Type/Onepage.php + + - + message: "#^Variable \\$customerRequest might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Checkout/Model/Type/Onepage.php + + - + message: "#^Comparison operation \"\\=\\=\" between 0\\|0\\.0\\|array\\|string\\|false\\|null and 0 results in an error\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/controllers/CartController.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/controllers/CartController.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/controllers/CartController.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Checkout/controllers/CartController.php + + - + message: "#^Parameter \\#2 \\$loginUrl of method Mage_Customer_Model_Session\\:\\:authenticate\\(\\) expects bool\\|null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/controllers/MultishippingController.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 7 + path: ../app/code/core/Mage/Checkout/controllers/MultishippingController.php + + - + message: "#^Call to an undefined method Mage_Sales_Model_Service_Order\\:\\:register\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/controllers/OnepageController.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Order will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/controllers/OnepageController.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/controllers/OnepageController.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Cms/Helper/Page.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Cms/Helper/Page.php + + - + message: "#^Parameter \\#1 \\$route of static method Mage\\:\\:getUrl\\(\\) expects string, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Cms/Helper/Page.php + + - + message: "#^Parameter \\#1 \\$store of method Mage_Core_Model_Locale\\:\\:isStoreDateInInterval\\(\\) expects int\\|Mage_Core_Model_Store\\|string, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Cms/Helper/Page.php + + - + message: "#^Cannot access offset 'cookie' on void\\|true\\.$#" + count: 1 + path: ../app/code/core/Mage/Cms/Model/Wysiwyg/Images/Storage.php + + - + message: "#^Method Mage_Cms_Model_Wysiwyg_Images_Storage\\:\\:getConfig\\(\\) should return Mage_Core_Model_Config_Element but returns Varien_Simplexml_Element\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Cms/Model/Wysiwyg/Images/Storage.php + + - + message: "#^Property Mage_Cms_Model_Wysiwyg_Images_Storage\\:\\:\\$_config \\(Mage_Core_Model_Config_Element\\) does not accept Varien_Simplexml_Element\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Cms/Model/Wysiwyg/Images/Storage.php + + - + message: "#^Parameter \\#1 \\$attr of method Mage_ConfigurableSwatches_Helper_Data\\:\\:attrIsSwatchType\\(\\) expects int\\|Mage_Eav_Model_Attribute, Mage_Catalog_Model_Resource_Eav_Attribute given\\.$#" + count: 1 + path: ../app/code/core/Mage/ConfigurableSwatches/Block/Catalog/Layer/State/Swatch.php + + - + message: "#^Right side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/ConfigurableSwatches/Helper/Data.php + + - + message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 2 parameters, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/ConfigurableSwatches/Helper/Productimg.php + + - + message: "#^Variable \\$mediaGalleryImages in empty\\(\\) always exists and is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/ConfigurableSwatches/Helper/Productimg.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Product_Type_Configurable_Attribute will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/ConfigurableSwatches/Helper/Productlist.php + + - + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/ConfigurableSwatches/Helper/Productlist.php + + - + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/ConfigurableSwatches/Helper/Productlist.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/ConfigurableSwatches/Helper/Productlist.php + + - + message: "#^Method Mage_ConfigurableSwatches_Helper_Productlist\\:\\:getSwatchAttribute\\(\\) should return Mage_Eav_Model_Attribute but returns Mage_Catalog_Model_Product_Type_Configurable_Attribute\\.$#" + count: 1 + path: ../app/code/core/Mage/ConfigurableSwatches/Helper/Productlist.php + + - + message: "#^Property Mage_ConfigurableSwatches_Helper_Productlist\\:\\:\\$_swatchAttribute \\(Mage_Catalog_Model_Product_Type_Configurable_Attribute\\) does not accept Mage_Eav_Model_Entity_Attribute_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/ConfigurableSwatches/Helper/Productlist.php + + - + message: "#^Property Mage_ConfigurableSwatches_Helper_Productlist\\:\\:\\$_swatchAttributeFilteredValue \\(int\\) does not accept false\\.$#" + count: 1 + path: ../app/code/core/Mage/ConfigurableSwatches/Helper/Productlist.php + + - + message: "#^Parameter \\#1 \\$select of method Varien_Data_Collection_Db\\:\\:_fetchAll\\(\\) expects Zend_Db_Select, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/ConfigurableSwatches/Model/Resource/Catalog/Product/Type/Configurable/Product/Collection.php + + - + message: "#^Variable \\$query might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/ConfigurableSwatches/Model/Resource/Catalog/Product/Type/Configurable/Product/Collection.php + + - + message: "#^Parameter \\#1 \\$array of function array_unshift expects array, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/ConfigurableSwatches/Model/System/Config/Source/Catalog/Product/Configattribute/Select.php + + - + message: "#^Return type \\(void\\) of method Mage_Contacts_IndexController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Controller_Front_Action\\)\\) of method Mage_Core_Controller_Front_Action\\:\\:preDispatch\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Contacts/controllers/IndexController.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Block_Messages will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Abstract.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_App will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Abstract.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Factory will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Abstract.php + + - + message: "#^If condition is always true\\.$#" + count: 3 + path: ../app/code/core/Mage/Core/Block/Abstract.php + + - + message: "#^Method Mage_Core_Block_Abstract\\:\\:_getUrlModel\\(\\) should return Mage_Core_Model_Url but returns Mage_Core_Model_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Abstract.php + + - + message: "#^Method Mage_Core_Block_Abstract\\:\\:getHelper\\(\\) should return \\$this\\(Mage_Core_Block_Abstract\\) but returns Mage_Core_Block_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Abstract.php + + - + message: "#^Method Mage_Core_Block_Abstract\\:\\:getParentBlock\\(\\) should return \\$this\\(Mage_Core_Block_Abstract\\) but returns Mage_Core_Block_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Abstract.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Block/Abstract.php + + - + message: "#^Parameter \\#2 \\$block of method Mage_Core_Model_Layout\\:\\:setBlock\\(\\) expects Mage_Core_Model_Layout, \\$this\\(Mage_Core_Block_Abstract\\) given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Abstract.php + + - + message: "#^Parameter \\#2 \\$block of method Mage_Core_Model_Layout\\:\\:setBlock\\(\\) expects Mage_Core_Model_Layout, Mage_Core_Block_Abstract given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Abstract.php + + - + message: "#^Result of && is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Abstract.php + + - + message: "#^Right side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Abstract.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Abstract.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Flush.php + + - + message: "#^Parameter \\#3 \\$value of static method Zend_Locale_Data\\:\\:getContent\\(\\) expects bool\\|string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Html/Calendar.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Html/Select.php + + - + message: "#^Ternary operator condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Messages.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Profiler.php + + - + message: "#^Parameter \\#2 \\$return of function print_r expects bool, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Profiler.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Template.php + + - + message: "#^Parameter \\#3 \\$file of static method Mage\\:\\:log\\(\\) expects string, null given\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Block/Template.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Template.php + + - + message: "#^Return type \\(void\\) of method Mage_Core_Block_Template_Zend\\:\\:setScriptPath\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Template\\)\\) of method Mage_Core_Block_Template\\:\\:setScriptPath\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Template/Zend.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Text.php + + - + message: "#^Parameter \\#2 \\$value of method Mage_Core_Block_Text_Tag\\:\\:setTagParam\\(\\) expects null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Text/Tag/Css.php + + - + message: "#^Parameter \\#2 \\$value of method Mage_Core_Block_Text_Tag\\:\\:setTagParam\\(\\) expects null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Text/Tag/Css/Admin.php + + - + message: "#^Parameter \\#1 \\$name of method Mage_Core_Block_Abstract\\:\\:setAttribute\\(\\) expects string, array\\ given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Text/Tag/Debug.php + + - + message: "#^Parameter \\#1 \\$text of method Mage_Core_Block_Text_Tag\\:\\:setContents\\(\\) expects string, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Text/Tag/Debug.php + + - + message: "#^Parameter \\#2 \\$return of function print_r expects bool, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Text/Tag/Debug.php + + - + message: "#^Parameter \\#2 \\$value of method Mage_Core_Block_Text_Tag\\:\\:setTagParam\\(\\) expects null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Block/Text/Tag/Js.php + + - + message: "#^Parameter \\#2 \\$value of method Zend_Controller_Response_Abstract\\:\\:setHeader\\(\\) expects string, int\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Front/Action.php + + - + message: "#^Call to an undefined method Zend_Controller_Router_Interface\\:\\:addRoute\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Front/Router.php + + - + message: "#^Parameter \\#1 \\$type of static method Mage\\:\\:getBaseUrl\\(\\) expects string, array given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Front/Router.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Request/Http.php + + - + message: "#^Result of && is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Request/Http.php + + - + message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Request/Http.php + + - + message: "#^Strict comparison using \\=\\=\\= between string and null will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Controller/Request/Http.php + + - + message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:is\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Varien/Action.php + + - + message: "#^Constructor of class Mage_Core_Controller_Varien_Action has an unused parameter \\$invokeArgs\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Varien/Action.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Varien/Action.php + + - + message: "#^Parameter \\#1 \\$handles of method Mage_Core_Controller_Varien_Action\\:\\:loadLayout\\(\\) expects bool\\|string\\|null, array\\ given\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Controller/Varien/Action.php + + - + message: "#^Parameter \\#2 \\$value of method Zend_Controller_Response_Abstract\\:\\:setHeader\\(\\) expects string, int\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Varien/Action.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 3 + path: ../app/code/core/Mage/Core/Controller/Varien/Action.php + + - + message: "#^Property Mage_Core_Controller_Varien_Action\\:\\:\\$_request \\(Mage_Core_Controller_Request_Http\\) does not accept Zend_Controller_Request_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Varien/Action.php + + - + message: "#^Property Mage_Core_Controller_Varien_Action\\:\\:\\$_response \\(Mage_Core_Controller_Response_Http\\) does not accept Zend_Controller_Response_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Varien/Action.php + + - + message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Varien/Front.php + + - + message: "#^Comparison operation \"\\>\" between int\\<0, 100\\> and 100 is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Varien/Front.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Varien/Front.php + + - + message: "#^Method Mage_Core_Controller_Varien_Front\\:\\:_getRequestRewriteController\\(\\) should return Mage_Core_Model_Url_Rewrite_Request but returns bool\\|Mage_Core_Model_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Varien/Front.php + + - + message: "#^Parameter \\#2 \\$useRouterName \\(bool\\) of method Mage_Core_Controller_Varien_Router_Admin\\:\\:collectRoutes\\(\\) should be compatible with parameter \\$useRouterName \\(string\\) of method Mage_Core_Controller_Varien_Router_Standard\\:\\:collectRoutes\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Varien/Router/Admin.php + + - + message: "#^Parameter \\#2 \\$useRouterName of method Mage_Core_Controller_Varien_Router_Standard\\:\\:collectRoutes\\(\\) expects string, bool given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Varien/Router/Admin.php + + - + message: "#^Parameter \\#1 \\$store of method Mage_Core_Model_App\\:\\:setCurrentStore\\(\\) expects string, Mage_Core_Model_Store given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Varien/Router/Default.php + + - + message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Varien/Router/Standard.php + + - + message: "#^Negated boolean expression is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Varien/Router/Standard.php + + - + message: "#^Parameter \\#2 \\$modules of method Mage_Core_Controller_Varien_Router_Standard\\:\\:getModuleByName\\(\\) expects string, array given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Varien/Router/Standard.php + + - + message: "#^Variable \\$action might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Controller/Varien/Router/Standard.php + + - + message: "#^Variable \\$controller might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Varien/Router/Standard.php + + - + message: "#^Variable \\$controllerInstance might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Controller/Varien/Router/Standard.php + + - + message: "#^Variable \\$realModule might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Controller/Varien/Router/Standard.php + + - + message: "#^Method Mage_Core_Helper_Abstract\\:\\:_getRequest\\(\\) should return Mage_Core_Controller_Request_Http but returns Zend_Controller_Request_Http\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Helper/Abstract.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Helper/Abstract.php + + - + message: "#^Parameter \\#2 \\$allowedTags of method Mage_Core_Helper_Abstract\\:\\:escapeHtml\\(\\) expects array\\|null, string\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Helper/Abstract.php + + - + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Helper/File/Storage.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Resource_File_Storage_Database will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Helper/File/Storage/Database.php + + - + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Helper/Http.php + + - + message: "#^Call to function is_null\\(\\) with Varien_Simplexml_Config will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Helper/Js.php + + - + message: "#^Parameter \\#2 \\$mergeToObject of method Mage_Core_Model_Config\\:\\:loadModulesConfiguration\\(\\) expects Mage_Core_Model_Config_Base\\|null, Varien_Simplexml_Config given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Helper/Js.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Helper/String.php + + - + message: "#^Property Mage_Core_Helper_String\\:\\:\\$_arrayHelper \\(Mage_Core_Helper_Array\\) does not accept Mage_Core_Helper_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Helper/String.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Abstract.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Abstract.php + + - + message: "#^Parameter \\#2 \\$arguments of static method Mage\\:\\:getResourceModel\\(\\) expects array, object given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Abstract.php + + - + message: "#^Property Mage_Core_Model_Abstract\\:\\:\\$_cacheTag \\(string\\|true\\) does not accept default value of type false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Abstract.php + + - + message: "#^Property Mage_Core_Model_Abstract\\:\\:\\$_isObjectNew \\(bool\\) on left side of \\?\\? is not nullable\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Abstract.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Store will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/App.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Website will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/App.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/App.php + + - + message: "#^Method Mage_Core_Model_App\\:\\:getDefaultStoreView\\(\\) should return Mage_Core_Model_Store but returns null\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/App.php + + - + message: "#^Method Mage_Core_Model_App\\:\\:getResponse\\(\\) should return Mage_Core_Controller_Response_Http but returns Zend_Controller_Response_Http\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/App.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 6 + path: ../app/code/core/Mage/Core/Model/App.php + + - + message: "#^Parameter \\#1 \\$group of method Mage_Core_Model_App\\:\\:_getStoreByGroup\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/App.php + + - + message: "#^Parameter \\#1 \\$group of method Mage_Core_Model_Store\\:\\:setGroup\\(\\) expects Mage_Core_Model_Store_Group, Varien_Object\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/App.php + + - + message: "#^Parameter \\#1 \\$website of method Mage_Core_Model_Store\\:\\:setWebsite\\(\\) expects Mage_Core_Model_Website, Varien_Object\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/App.php + + - + message: "#^Parameter \\#1 \\$website of method Mage_Core_Model_Store_Group\\:\\:setWebsite\\(\\) expects Mage_Core_Model_Website, Varien_Object\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/App.php + + - + message: "#^Parameter \\#3 \\$period of method Mage_Core_Model_Cookie\\:\\:set\\(\\) expects int\\|null, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/App.php + + - + message: "#^Property Mage_Core_Model_App\\:\\:\\$_request \\(Mage_Core_Controller_Request_Http\\) in empty\\(\\) is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/App.php + + - + message: "#^Property Mage_Core_Model_App\\:\\:\\$_response \\(Zend_Controller_Response_Http\\) in empty\\(\\) is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/App.php + + - + message: "#^Property Mage_Core_Model_App\\:\\:\\$_store \\(Mage_Core_Model_Store\\) in empty\\(\\) is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/App.php + + - + message: "#^Property Mage_Core_Model_App\\:\\:\\$_useSessionInUrl \\(bool\\) does not accept string\\|null\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/App.php + + - + message: "#^Property Mage_Core_Model_App\\:\\:\\$_website \\(Mage_Core_Model_Website\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/App.php + + - + message: "#^Result of && is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/App.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/App.php + + - + message: "#^Variable \\$id in isset\\(\\) always exists and is not nullable\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/App.php + + - + message: "#^Parameter \\#1 \\$store of method Mage_Core_Model_App\\:\\:setCurrentStore\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/App/Emulation.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Cache.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Cache.php + + - + message: "#^Method Mage_Core_Model_Cache\\:\\:getDbAdapter\\(\\) should return Zend_Db_Adapter_Abstract but returns Varien_Db_Adapter_Interface\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Cache.php + + - + message: "#^Property Mage_Core_Model_Cache\\:\\:\\$_frontend \\(Varien_Cache_Core\\) does not accept Zend_Cache_Core\\|Zend_Cache_Frontend\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Cache.php + + - + message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Cache.php + + - + message: "#^Call to an undefined method SimpleXMLElement\\:\\:getClassName\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Config.php + + - + message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:getClassName\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Config.php + + - + message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:is\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Config.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Resource_Config will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Config.php + + - + message: "#^Method Mage_Core_Model_Config\\:\\:cleanCache\\(\\) should return \\$this\\(Mage_Core_Model_Config\\) but returns Mage_Core_Model_Config\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Config.php + + - + message: "#^Method Mage_Core_Model_Config\\:\\:getNodeClassInstance\\(\\) should return bool but returns object\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Config.php + + - + message: "#^Parameter \\#1 \\$data of method Mage_Core_Model_Config\\:\\:_saveCache\\(\\) expects string, int\\<1, max\\> given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Config.php + + - + message: "#^Parameter \\#1 \\$fileName of method Mage_Core_Model_Config\\:\\:loadModulesConfiguration\\(\\) expects string, array\\ given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Config.php + + - + message: "#^Parameter \\#1 \\$options of method Mage_Core_Model_Config\\:\\:reinit\\(\\) expects array, Mage_Core_Model_Config_Options given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Config.php + + - + message: "#^Parameter \\#1 \\$path of method Varien_Simplexml_Element\\:\\:descend\\(\\) expects string, array given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Config.php + + - + message: "#^Parameter \\#2 \\$constructArguments of method Mage_Core_Model_Config\\:\\:getModelInstance\\(\\) expects array\\|object, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Config.php + + - + message: "#^Property Varien_Simplexml_Config\\:\\:\\$_cacheChecksum \\(unknown_type\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Config.php + + - + message: "#^Return type \\(Mage_Core_Model_App\\) of method Mage_Core_Model_Config\\:\\:_saveCache\\(\\) should be compatible with return type \\(bool\\) of method Varien_Simplexml_Config\\:\\:_saveCache\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Config.php + + - + message: "#^Return type \\(Zend_Cache_Core\\) of method Mage_Core_Model_Config\\:\\:getCache\\(\\) should be compatible with return type \\(Varien_Simplexml_Config_Cache_Abstract\\) of method Varien_Simplexml_Config\\:\\:getCache\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Config.php + + - + message: "#^Return type \\(string\\) of method Mage_Core_Model_Config\\:\\:_loadCache\\(\\) should be compatible with return type \\(bool\\) of method Varien_Simplexml_Config\\:\\:_loadCache\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Config.php + + - + message: "#^Strict comparison using \\=\\=\\= between int\\|string and false will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Config.php + + - + message: "#^Variable \\$key might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Config.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Store will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Cookie.php + + - + message: "#^Method Mage_Core_Model_Cookie\\:\\:getHttponly\\(\\) should return bool but returns null\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Cookie.php + + - + message: "#^Parameter \\#3 \\$options of function setcookie expects array\\{expires\\?\\: int, path\\?\\: string, domain\\?\\: string, secure\\?\\: bool, httponly\\?\\: bool, samesite\\?\\: 'Lax'\\|'lax'\\|'None'\\|'none'\\|'Strict'\\|'strict', url_encode\\?\\: int\\}, array\\{expires\\: int, path\\: string, domain\\: string, secure\\: bool\\|int, httponly\\: bool, samesite\\: string\\} given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Cookie.php + + - + message: "#^Binary operation \"\\+\" between string and string results in an error\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Date.php + + - + message: "#^Binary operation \"\\-\" between string and string results in an error\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Date.php + + - + message: "#^Property Mage_Core_Model_Date\\:\\:\\$_systemOffset is never read, only written\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Date.php + + - + message: "#^Call to an undefined method Mage_Core_Model_Resource_Design\\:\\:validate\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Design.php + + - + message: "#^Parameter \\#1 \\$cache of method Varien_Simplexml_Config\\:\\:setCache\\(\\) expects Varien_Simplexml_Config_Cache_Abstract, Zend_Cache_Core given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Design/Config.php + + - + message: "#^Parameter \\#2 \\$value of method Varien_Simplexml_Config\\:\\:setNode\\(\\) expects string, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Design/Config.php + + - + message: "#^Property Varien_Simplexml_Config\\:\\:\\$_cacheChecksum \\(unknown_type\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Design/Config.php + + - + message: "#^Property Mage_Core_Model_Design_Fallback\\:\\:\\$_store \\(Mage_Core_Model_Store\\) on left side of \\?\\? is not nullable\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Design/Fallback.php + + - + message: "#^Binary operation \"\\.\" between non\\-falsy\\-string and array results in an error\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Design/Package.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Design_Config will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Design/Package.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Design_Fallback will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Design/Package.php + + - + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Design/Package.php + + - + message: "#^Cannot assign offset 'layout'\\|'locale'\\|'skin'\\|'template' to string\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Design/Package.php + + - + message: "#^Cannot assign offset string to string\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Design/Package.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Design/Package.php + + - + message: "#^Parameter \\#1 \\$file of method Mage_Core_Model_Design_Package\\:\\:_renderFilename\\(\\) expects array, string given\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Design/Package.php + + - + message: "#^Property Mage_Core_Model_Design_Package\\:\\:\\$_store \\(int\\|Mage_Core_Model_Store\\|string\\) on left side of \\?\\? is not nullable\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Design/Package.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Design/Source/Design.php + + - + message: "#^Parameter \\#1 \\$policyCode of method Mage_Core_Model_Domainpolicy\\:\\:_getDomainPolicyByCode\\(\\) expects string, int given\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Domainpolicy.php + + - + message: "#^Right side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Email.php + + - + message: "#^Method Zend_Mail\\:\\:addBcc\\(\\) invoked with 2 parameters, 1 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Email/Queue.php + + - + message: "#^Method Mage_Core_Model_Email_Template\\:\\:getProcessedTemplate\\(\\) invoked with 2 parameters, 0\\-1 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Email/Template.php + + - + message: "#^Parameter \\#1 \\$html of method Mage_Core_Model_Email_Template\\:\\:getPreparedTemplateText\\(\\) expects null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Email/Template.php + + - + message: "#^Parameter \\#1 \\$html of method Mage_Core_Model_Email_Template_Abstract\\:\\:_applyInlineCss\\(\\) expects string, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Email/Template.php + + - + message: "#^Parameter \\#1 \\$value of method Mage_Core_Model_Email_Template\\:\\:setId\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Email/Template.php + + - + message: "#^Method Mage_Core_Model_Email_Template_Abstract\\:\\:loadByConfigPath\\(\\) invoked with 2 parameters, 1 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Email/Template/Abstract.php + + - + message: "#^Parameter \\#1 \\$id of method Mage_Core_Model_App\\:\\:getStore\\(\\) expects bool\\|int\\|Mage_Core_Model_Store\\|string\\|null, Varien_Object\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Email/Template/Filter.php + + - + message: "#^Parameter \\#2 \\$name of method Mage_Core_Model_Layout\\:\\:createBlock\\(\\) expects string, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Email/Template/Filter.php + + - + message: "#^Call to an undefined method Varien_Crypt_Abstract\\:\\:init\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Encryption.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Encryption.php + + - + message: "#^Method Mage_Core_Model_Factory\\:\\:getUrlRewriteInstance\\(\\) should return Mage_Core_Model_Url_Rewrite but returns bool\\|Mage_Core_Model_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Factory.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/File/Storage.php + + - + message: "#^Result of \\|\\| is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/File/Storage.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_File_Storage_Directory_Database will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/File/Storage/Database.php + + - + message: "#^Parameter \\#1 \\$params of method Mage_Core_Model_File_Storage_Database_Abstract\\:\\:__construct\\(\\) expects array, string\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/File/Storage/Database.php + + - + message: "#^Parameter \\#1 \\$params of method Mage_Core_Model_File_Storage_Database_Abstract\\:\\:__construct\\(\\) expects array, string\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/File/Storage/Directory/Database.php + + - + message: "#^Variable \\$parentId might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/File/Storage/Directory/Database.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/File/Storage/File.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/File/Storage/File.php + + - + message: "#^Call to function is_string\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/File/Validator/NotProtectedExtension.php + + - + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Flag.php + + - + message: "#^Elseif condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Input/Filter.php + + - + message: "#^PHPDoc tag @param for parameter \\$filter with type array\\|Zend_Filter_Interface is not subtype of native type Zend_Filter_Interface\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Input/Filter.php + + - + message: "#^Parameter \\#1 \\$name of method Mage_Core_Model_Input_Filter\\:\\:addFilter\\(\\) expects string, Zend_Filter_Interface given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Input/Filter.php + + - + message: "#^Parameter \\#1 \\$name of method Mage_Core_Model_Input_Filter\\:\\:addFilter\\(\\) expects string, array\\|Zend_Filter_Interface given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Input/Filter.php + + - + message: "#^Parameter \\#2 \\$filter of method Mage_Core_Model_Input_Filter\\:\\:addFilter\\(\\) expects array\\|Zend_Filter_Interface, string given\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Input/Filter.php + + - + message: "#^Call to an undefined method SimpleXMLElement\\:\\:getAttribute\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Layout.php + + - + message: "#^Cannot unset offset '@attributes' on \\(array\\{\\}\\|array\\{\\000\\*\\000_parent\\: Varien_Simplexml_Element\\}\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Layout.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Layout.php + + - + message: "#^Method Mage_Core_Model_Layout\\:\\:getMessagesBlock\\(\\) should return Mage_Core_Block_Messages but returns Mage_Core_Block_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Layout.php + + - + message: "#^Method Mage_Core_Model_Layout\\:\\:getMessagesBlock\\(\\) should return Mage_Core_Block_Messages but returns Mage_Core_Block_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Layout.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Layout.php + + - + message: "#^Parameter \\#1 \\$node of method Varien_Simplexml_Config\\:\\:setXml\\(\\) expects Varien_Simplexml_Element, SimpleXMLElement given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Layout.php + + - + message: "#^Parameter \\#1 \\$node of method Varien_Simplexml_Config\\:\\:setXml\\(\\) expects Varien_Simplexml_Element, SimpleXMLElement\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Layout.php + + - + message: "#^Parameter \\#1 \\$parent of method Mage_Core_Model_Layout\\:\\:generateBlocks\\(\\) expects Mage_Core_Model_Layout_Element\\|null, Varien_Simplexml_Element given\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Layout.php + + - + message: "#^Parameter \\#1 \\$sourceData of method Varien_Simplexml_Config\\:\\:__construct\\(\\) expects string\\|Varien_Simplexml_Element\\|null, array given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Layout.php + + - + message: "#^Parameter \\#2 \\$parent of method Mage_Core_Model_Layout\\:\\:_generateAction\\(\\) expects Mage_Core_Model_Layout_Element, Varien_Simplexml_Element given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Layout.php + + - + message: "#^Parameter \\#2 \\$parent of method Mage_Core_Model_Layout\\:\\:_generateBlock\\(\\) expects Mage_Core_Model_Layout_Element, Varien_Simplexml_Element given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Layout.php + + - + message: "#^Parameter \\#2 \\$value of method SimpleXMLElement\\:\\:addAttribute\\(\\) expects string, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Layout.php + + - + message: "#^Method Mage_Core_Model_Layout_Update\\:\\:saveCache\\(\\) should return bool but returns Mage_Core_Model_App\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Layout/Update.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Locale.php + + - + message: "#^Parameter \\#3 \\$value of method Zend_Locale\\:\\:getTranslationList\\(\\) expects string\\|null, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Locale.php + + - + message: "#^Property Mage_Core_Model_Locale\\:\\:\\$_locale \\(Zend_Locale\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Locale.php + + - + message: "#^Method Mage_Core_Model_Message_Collection\\:\\:getMessageByIdentifier\\(\\) should return Mage_Core_Model_Message_Abstract\\|null but return statement is missing\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Message/Collection.php + + - + message: "#^Call to an undefined method Mage_Core_Model_Resource_Type_Abstract\\:\\:getConnection\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource.php + + - + message: "#^Call to an undefined method SimpleXMLElement\\:\\:getClassName\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource.php + + - + message: "#^Method Mage_Core_Model_Resource\\:\\:_getDefaultConnection\\(\\) should return string but returns Varien_Db_Adapter_Interface\\|false\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Resource.php + + - + message: "#^Method Mage_Core_Model_Resource\\:\\:getConnection\\(\\) should return Varien_Db_Adapter_Interface\\|false but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource.php + + - + message: "#^Parameter \\#1 \\$adapter of method Varien_Db_Adapter_Interface\\:\\:setCacheAdapter\\(\\) expects Zend_Cache_Backend_Interface, Zend_Cache_Core given\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Resource.php + + - + message: "#^Parameter \\#2 \\$value of method Mage_Core_Model_Config_Element\\:\\:is\\(\\) expects string\\|true, 1 given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Cache.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Cache.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Config.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Resource/Db/Abstract.php + + - + message: "#^Call to function is_null\\(\\) with int\\|string will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Resource/Db/Abstract.php + + - + message: "#^Else branch is unreachable because previous condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Db/Abstract.php + + - + message: "#^Left side of && is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Resource/Db/Abstract.php + + - + message: "#^Method Mage_Core_Model_Resource_Db_Abstract\\:\\:_getConnection\\(\\) should return Magento_Db_Adapter_Pdo_Mysql but returns Varien_Db_Adapter_Interface\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Db/Abstract.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Db/Abstract.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php + + - + message: "#^Parameter \\#1 \\$conn of method Varien_Data_Collection_Db\\:\\:setConnection\\(\\) expects Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php + + - + message: "#^Parameter \\#1 \\$select of method Varien_Data_Collection_Db\\:\\:_fetchAll\\(\\) expects Zend_Db_Select, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php + + - + message: "#^Property Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:\\$_resource \\(Mage_Core_Model_Resource_Db_Abstract\\) does not accept Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php + + - + message: "#^Property Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:\\$_resource \\(Mage_Core_Model_Resource_Db_Abstract\\) in empty\\(\\) is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php + + - + message: "#^Result of && is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php + + - + message: "#^Variable \\$alias in isset\\(\\) always exists and is always null\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php + + - + message: "#^Variable \\$alias might not be defined\\.$#" + count: 3 + path: ../app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php + + - + message: "#^Variable \\$columnsToSelect in isset\\(\\) always exists and is not nullable\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php + + - + message: "#^Parameter \\#1 \\$date of method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:formatDate\\(\\) expects int\\|string\\|Zend_Date, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Design/Collection.php + + - + message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'afterLoad' given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Email/Queue/Collection.php + + - + message: "#^Method Mage_Core_Model_Resource_Entity_Abstract\\:\\:getConfig\\(\\) should return bool\\|string but returns Varien_Simplexml_Config\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Entity/Abstract.php + + - + message: "#^Property Mage_Core_Model_Resource_Entity_Abstract\\:\\:\\$_config \\(Varien_Simplexml_Config\\) does not accept default value of type array\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Entity/Abstract.php + + - + message: "#^Method Mage_Core_Model_Resource_File_Storage_Directory_Database\\:\\:getParentId\\(\\) should return int but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/File/Storage/Directory/Database.php + + - + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/File/Storage/File.php + + - + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Resource/File/Storage/File.php + + - + message: "#^Left side of \\|\\| is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/File/Storage/File.php + + - + message: "#^Property Mage_Core_Model_Resource_File_Storage_File\\:\\:\\$filePointer \\(resource\\) does not accept null\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Resource/File/Storage/File.php + + - + message: "#^Result of \\|\\| is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/File/Storage/File.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/File/Storage/File.php + + - + message: "#^PHPDoc tag @param for parameter \\$callbacks with type array\\|string is not subtype of native type array\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Iterator.php + + - + message: "#^Parameter \\#2 \\$conn of method Mage_Core_Model_Resource_Iterator\\:\\:_getStatement\\(\\) expects Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Iterator.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Layout.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Resource/Resource.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Resource/Resource.php + + - + message: "#^Result of && is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Resource/Resource.php + + - + message: "#^Result of \\|\\| is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Resource.php + + - + message: "#^Static property Mage_Core_Model_Resource_Resource\\:\\:\\$_dataVersions \\(array\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Resource.php + + - + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Session.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Session.php + + - + message: "#^Parameter \\#6 \\$gc of function session_set_save_handler expects callable\\(string\\)\\: bool, array\\{\\$this\\(Mage_Core_Model_Resource_Session\\), 'gc'\\} given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Session.php + + - + message: "#^Property Mage_Core_Model_Resource_Session\\:\\:\\$_lifeTime \\(int\\) does not accept string\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Session.php + + - + message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:getClassName\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Resource/Setup.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Setup.php + + - + message: "#^Parameter \\#1 \\$hook of method Varien_Db_Adapter_Pdo_Mysql\\:\\:setQueryHook\\(\\) expects array, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Setup.php + + - + message: "#^Property Mage_Core_Model_Resource_Setup\\:\\:\\$_conn \\(Varien_Db_Adapter_Pdo_Mysql\\) does not accept Varien_Db_Adapter_Interface\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Setup.php + + - + message: "#^Property Mage_Core_Model_Resource_Setup\\:\\:\\$_moduleConfig \\(Mage_Core_Model_Config_Element\\) does not accept SimpleXMLElement\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Setup.php + + - + message: "#^Property Mage_Core_Model_Resource_Setup\\:\\:\\$_resourceConfig \\(Mage_Core_Model_Config_Element\\) does not accept SimpleXMLElement\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Setup.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Setup.php + + - + message: "#^Binary operation \"\\.\" between string and array results in an error\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Setup/Query/Modifier.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Setup/Query/Modifier.php + + - + message: "#^Parameter \\#3 \\$replacement of method Mage_Core_Model_Resource_Setup_Query_Modifier\\:\\:_firstReplace\\(\\) expects array, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Setup/Query/Modifier.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Resource/Translate.php + + - + message: "#^Right side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Type/Db/Mysqli.php + + - + message: "#^Right side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Type/Db/Pdo/Mysql.php + + - + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Resource/Url/Rewrite.php + + - + message: "#^Parameter \\#1 \\$host of method Mage_Core_Model_Session_Abstract\\:\\:addHost\\(\\) expects string, true given\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Session/Abstract.php + + - + message: "#^Parameter \\#2 \\$clear \\(bool\\) of method Mage_Core_Model_Session_Abstract_Varien\\:\\:getData\\(\\) should be compatible with parameter \\$index \\(int\\|string\\) of method Varien_Object\\:\\:getData\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Session/Abstract/Varien.php + + - + message: "#^Access to an undefined property Zend_Session_Namespace\\:\\:\\$data\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Session/Abstract/Zend.php + + - + message: "#^Parameter \\#2 \\$clear \\(bool\\) of method Mage_Core_Model_Session_Abstract_Zend\\:\\:getData\\(\\) should be compatible with parameter \\$index \\(int\\|string\\) of method Varien_Object\\:\\:getData\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Session/Abstract/Zend.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Store_Group will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Store.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Website will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Store.php + + - + message: "#^Elseif condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Store.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Store.php + + - + message: "#^Left side of && is always true\\.$#" + count: 3 + path: ../app/code/core/Mage/Core/Model/Store.php + + - + message: "#^Method Mage_Core_Model_Store\\:\\:_getSession\\(\\) should return Mage_Core_Model_Session but returns Mage_Core_Model_Session_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Store.php + + - + message: "#^Method Mage_Core_Model_Store\\:\\:getPriceFilter\\(\\) should return Varien_Filter_Sprintf but returns Mage_Directory_Model_Currency_Filter\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Store.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Store.php + + - + message: "#^PHPDoc type bool of property Mage_Core_Model_Store\\:\\:\\$_cacheTag is not covariant with PHPDoc type string\\|true of overridden property Mage_Core_Model_Abstract\\:\\:\\$_cacheTag\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Store.php + + - + message: "#^Property Mage_Core_Model_Store\\:\\:\\$_priceFilter \\(Mage_Directory_Model_Currency_Filter\\) does not accept Varien_Filter_Sprintf\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Store.php + + - + message: "#^Right side of && is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Store.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Store.php + + - + message: "#^Variable \\$store might not be defined\\.$#" + count: 8 + path: ../app/code/core/Mage/Core/Model/Store/Api.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Website will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Store/Group.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 5 + path: ../app/code/core/Mage/Core/Model/Store/Group.php + + - + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Store/Group.php + + - + message: "#^Call to function is_null\\(\\) with Varien_Object will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Template.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Template.php + + - + message: "#^Property Mage_Core_Model_Template\\:\\:\\$_emulatedDesignConfig \\(Varien_Object\\) does not accept default value of type false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Template.php + + - + message: "#^Property Mage_Core_Model_Template\\:\\:\\$_emulatedDesignConfig \\(Varien_Object\\) does not accept false\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Template.php + + - + message: "#^Property Mage_Core_Model_Template\\:\\:\\$_initialEnvironmentInfo \\(Varien_Object\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Template.php + + - + message: "#^Property Mage_Core_Model_Template\\:\\:\\$_initialEnvironmentInfo \\(Varien_Object\\) in empty\\(\\) is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Template.php + + - + message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Translate.php + + - + message: "#^Call to function is_null\\(\\) with Zend_Translate will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Translate.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Translate.php + + - + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Translate.php + + - + message: "#^Parameter \\#1 \\$options of class Zend_Translate constructor expects array\\|Zend_Config\\|Zend_Translate_Adapter, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Translate.php + + - + message: "#^Parameter \\#2 \\$scope of method Mage_Core_Model_Translate\\:\\:_addData\\(\\) expects string, false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Translate.php + + - + message: "#^Call to function is_null\\(\\) with bool will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Translate/Inline.php + + - + message: "#^Parameter \\#1 \\$storeId of method Mage_Core_Helper_Data\\:\\:isDevAllowed\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Translate/Inline.php + + - + message: "#^Parameter \\#3 \\$storeId of method Mage_Core_Model_Resource_Translate_String\\:\\:deleteTranslate\\(\\) expects int\\|null, false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Translate/Inline.php + + - + message: "#^Parameter \\#4 \\$flags of function preg_match expects TFlags of 0\\|256\\|512\\|768, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Translate/Inline.php + + - + message: "#^Call to function is_null\\(\\) with bool will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Url.php + + - + message: "#^Method Mage_Core_Model_Url\\:\\:getRequest\\(\\) should return Mage_Core_Controller_Request_Http but returns Zend_Controller_Request_Http\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Url.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 3 + path: ../app/code/core/Mage/Core/Model/Url.php + + - + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/Model/Url/Rewrite.php + + - + message: "#^Negated boolean expression is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Url/Rewrite.php + + - + message: "#^PHPDoc type mixed of property Mage_Core_Model_Url_Rewrite\\:\\:\\$_cacheTag is not covariant with PHPDoc type string\\|true of overridden property Mage_Core_Model_Abstract\\:\\:\\$_cacheTag\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Url/Rewrite.php + + - + message: "#^Parameter \\#3 \\$period of method Mage_Core_Model_Cookie\\:\\:set\\(\\) expects int\\|null, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Url/Rewrite.php + + - + message: "#^Result of \\|\\| is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Url/Rewrite.php + + - + message: "#^Strict comparison using \\=\\=\\= between int and false will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Url/Rewrite.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Url/Rewrite.php + + - + message: "#^Variable \\$targetUrl might not be defined\\.$#" + count: 3 + path: ../app/code/core/Mage/Core/Model/Url/Rewrite.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Url/Rewrite/Request.php + + - + message: "#^Negated boolean expression is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Url/Rewrite/Request.php + + - + message: "#^Parameter \\#3 \\$period of method Mage_Core_Model_Cookie\\:\\:set\\(\\) expects int\\|null, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Url/Rewrite/Request.php + + - + message: "#^Result of \\|\\| is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Url/Rewrite/Request.php + + - + message: "#^Strict comparison using \\=\\=\\= between int and false will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Url/Rewrite/Request.php + + - + message: "#^Strict comparison using \\=\\=\\= between int and null will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Url/Rewrite/Request.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Url/Rewrite/Request.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 8 + path: ../app/code/core/Mage/Core/Model/Website.php + + - + message: "#^Call to function is_null\\(\\) with bool will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/Model/Website.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/controllers/AjaxController.php + + - + message: "#^Function mageCoreErrorHandler\\(\\) never returns void so it can be removed from the return type\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/functions.php + + - + message: "#^Function mageDebugBacktrace\\(\\) never returns void so it can be removed from the return type\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/functions.php + + - + message: "#^Parameter \\#1 \\$prefix of function uniqid expects string, int\\<0, max\\> given\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/functions.php + + - + message: "#^Parameter \\#1 \\$separator of function explode expects non\\-empty\\-string, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Core/functions.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 2 + path: ../app/code/core/Mage/Core/functions.php + + - + message: "#^Strict comparison using \\=\\=\\= between int\\|string and null will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Cron/Model/Observer.php + + - + message: "#^Variable \\$arguments might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Cron/Model/Observer.php + + - + message: "#^Property Mage_CurrencySymbol_Block_Adminhtml_System_Currencysymbol\\:\\:\\$_controller is never read, only written\\.$#" + count: 1 + path: ../app/code/core/Mage/CurrencySymbol/Block/Adminhtml/System/Currencysymbol.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/CurrencySymbol/Helper/Data.php + + - + message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/CurrencySymbol/Model/System/Currencysymbol.php + + - + message: "#^Property Mage_CurrencySymbol_Model_System_Currencysymbol\\:\\:\\$_storeId \\(string\\|null\\) does not accept int\\|null\\.$#" + count: 1 + path: ../app/code/core/Mage/CurrencySymbol/Model/System/Currencysymbol.php + + - + message: "#^Property Mage_CurrencySymbol_Model_System_Currencysymbol\\:\\:\\$_websiteId \\(string\\|null\\) does not accept int\\|null\\.$#" + count: 1 + path: ../app/code/core/Mage/CurrencySymbol/Model/System/Currencysymbol.php + + - + message: "#^Else branch is unreachable because previous condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Customer/Block/Account/Dashboard/Address.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Newsletter_Model_Subscriber will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Block/Account/Dashboard/Info.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Newsletter_Model_Subscriber will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Block/Account/Dashboard/Newsletter.php + + - + message: "#^Call to an undefined method Mage_Wishlist_Model_Resource_Item_Collection\\:\\:addAttributeToSelect\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Block/Account/Dashboard/Sidebar.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Block/Account/Dashboard/Sidebar.php + + - + message: "#^Property Mage_Customer_Block_Account_Navigation\\:\\:\\$_activeLink \\(bool\\) does not accept string\\.$#" + count: 2 + path: ../app/code/core/Mage/Customer/Block/Account/Navigation.php + + - + message: "#^Left side of \\|\\| is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Block/Address/Book.php + + - + message: "#^Right side of \\|\\| is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Block/Address/Book.php + + - + message: "#^Method Mage_Customer_Block_Address_Edit\\:\\:getCountryId\\(\\) should return int but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Block/Address/Edit.php + + - + message: "#^Return type \\(int\\) of method Mage_Customer_Block_Address_Edit\\:\\:getCountryId\\(\\) should be compatible with return type \\(string\\) of method Mage_Directory_Block_Data\\:\\:getCountryId\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Customer/Block/Address/Edit.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Customer_Model_Address will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Block/Form/Register.php + + - + message: "#^Method Mage_Customer_Block_Form_Register\\:\\:getCountryId\\(\\) should return int but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Block/Form/Register.php + + - + message: "#^Return type \\(int\\) of method Mage_Customer_Block_Form_Register\\:\\:getCountryId\\(\\) should be compatible with return type \\(string\\) of method Mage_Directory_Block_Data\\:\\:getCountryId\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Customer/Block/Form/Register.php + + - + message: "#^Method Mage_Customer_Block_Newsletter\\:\\:getAction\\(\\) should return Mage_Core_Controller_Varien_Action but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Block/Newsletter.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Helper/Address.php + + - + message: "#^Parameter \\#1 \\$entityType of method Mage_Eav_Model_Config\\:\\:getEntityAttributeCodes\\(\\) expects Mage_Eav_Model_Entity_Type, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Helper/Address.php + + - + message: "#^Property Mage_Customer_Helper_Data\\:\\:\\$_customer \\(Mage_Customer_Model_Customer\\) in empty\\(\\) is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Helper/Data.php + + - + message: "#^Property Mage_Customer_Helper_Data\\:\\:\\$_groups \\(Mage_Customer_Model_Entity_Group_Collection\\) does not accept Mage_Customer_Model_Resource_Group_Collection\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Helper/Data.php + + - + message: "#^Property Mage_Customer_Helper_Data\\:\\:\\$_groups \\(Mage_Customer_Model_Entity_Group_Collection\\) in empty\\(\\) is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Helper/Data.php + + - + message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Address/Abstract.php + + - + message: "#^Method Mage_Customer_Model_Address_Abstract\\:\\:getStreet\\(\\) should return string but returns array\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Address/Abstract.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Address/Abstract.php + + - + message: "#^Parameter \\#1 \\$entity of method Mage_Customer_Model_Api_Resource\\:\\:getAllowedAttributes\\(\\) expects Mage_Eav_Model_Entity_Abstract, Mage_Customer_Model_Address given\\.$#" + count: 4 + path: ../app/code/core/Mage/Customer/Model/Address/Api.php + + - + message: "#^Cannot access property \\$is_default_billing on array\\.$#" + count: 2 + path: ../app/code/core/Mage/Customer/Model/Address/Api/V2.php + + - + message: "#^Cannot access property \\$is_default_shipping on array\\.$#" + count: 2 + path: ../app/code/core/Mage/Customer/Model/Address/Api/V2.php + + - + message: "#^Parameter \\#1 \\$entity of method Mage_Customer_Model_Api_Resource\\:\\:getAllowedAttributes\\(\\) expects Mage_Eav_Model_Entity_Abstract, Mage_Customer_Model_Address given\\.$#" + count: 3 + path: ../app/code/core/Mage/Customer/Model/Address/Api/V2.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Store will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Address/Config.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getResource\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Api/Resource.php + + - + message: "#^Call to an undefined method Mage_Customer_Model_Api2_Customer_Address\\:\\:_getDefaultAddressesInfo\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Api2/Customer/Address.php + + - + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Api2/Customer/Rest/Customer/V1.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Customer_Model_Customer will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Convert/Adapter/Customer.php + + - + message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Convert/Adapter/Customer.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Convert/Adapter/Customer.php + + - + message: "#^Property Mage_Customer_Model_Convert_Adapter_Customer\\:\\:\\$_customerModel \\(Mage_Customer_Model_Customer\\) does not accept string\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Convert/Adapter/Customer.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:setStore\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Convert/Parser/Customer.php + + - + message: "#^Call to function is_array\\(\\) with bool\\|string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Convert/Parser/Customer.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Convert/Parser/Customer.php + + - + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Customer/Model/Convert/Parser/Customer.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Convert/Parser/Customer.php + + - + message: "#^Variable \\$regionId might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Customer/Model/Convert/Parser/Customer.php + + - + message: "#^If condition is always true\\.$#" + count: 4 + path: ../app/code/core/Mage/Customer/Model/Customer.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Customer.php + + - + message: "#^Method Mage_Directory_Model_Region\\:\\:loadByName\\(\\) invoked with 1 parameter, 2 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Customer.php + + - + message: "#^Property Mage_Customer_Model_Customer\\:\\:\\$_addresses \\(array\\\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Customer.php + + - + message: "#^Property Mage_Customer_Model_Customer\\:\\:\\$_addressesCollection \\(Mage_Customer_Model_Entity_Address_Collection\\) does not accept Mage_Customer_Model_Resource_Address_Collection\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Customer.php + + - + message: "#^Property Mage_Customer_Model_Customer\\:\\:\\$_addressesCollection \\(Mage_Customer_Model_Entity_Address_Collection\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Customer.php + + - + message: "#^Property Mage_Customer_Model_Customer\\:\\:\\$_attributes \\(array\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Customer.php + + - + message: "#^Ternary operator condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Customer.php + + - + message: "#^Parameter \\#1 \\$entity of method Mage_Customer_Model_Api_Resource\\:\\:getAllowedAttributes\\(\\) expects Mage_Eav_Model_Entity_Abstract, Mage_Customer_Model_Customer given\\.$#" + count: 3 + path: ../app/code/core/Mage/Customer/Model/Customer/Api.php + + - + message: "#^Parameter \\#1 \\$data \\(stdClass\\) of method Mage_Customer_Model_Customer_Api_V2\\:\\:_prepareData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Customer_Model_Customer_Api\\:\\:_prepareData\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Customer/Api/V2.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Customer/Api/V2.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Customer/Attribute/Source/Store.php + + - + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Resource/Address.php + + - + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Resource/Address.php + + - + message: "#^Method Mage_Customer_Model_Resource_Customer\\:\\:getWebsiteId\\(\\) should return int but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Resource/Customer.php + + - + message: "#^Parameter \\#1 \\$alias of method Mage_Eav_Model_Entity_Abstract\\:\\:getTable\\(\\) expects string, array\\ given\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Resource/Customer.php + + - + message: "#^Parameter \\#1 \\$customer of method Mage_Customer_Model_Resource_Customer\\:\\:_saveAddresses\\(\\) expects Mage_Customer_Model_Customer, Varien_Object given\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Resource/Customer.php + + - + message: "#^Parameter \\#2 \\$entityId of method Mage_Eav_Model_Entity_Abstract\\:\\:load\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Resource/Customer.php + + - + message: "#^Parameter \\#3 \\$attribute of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addExpressionAttributeToSelect\\(\\) expects string, array\\ given\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Resource/Customer/Collection.php + + - + message: "#^Parameter \\#2 \\$resourceModel of method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:_init\\(\\) expects Mage_Core_Model_Resource_Db_Abstract\\|null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Resource/Form/Attribute/Collection.php + + - + message: "#^Parameter \\#3 \\$default of method Mage_Eav_Model_Entity_Setup\\:\\:_getValue\\(\\) expects string\\|null, int given\\.$#" + count: 4 + path: ../app/code/core/Mage/Customer/Model/Resource/Setup.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Session.php + + - + message: "#^Parameter \\#1 \\$url of method Mage_Core_Controller_Response_Http\\:\\:setRedirect\\(\\) expects string, bool given\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Session.php + + - + message: "#^Right side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/Model/Session.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 2 + path: ../app/code/core/Mage/Customer/Model/Session.php + + - + message: "#^Cannot call method addAttributeToSelect\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/controllers/AccountController.php + + - + message: "#^Cannot call method sendNewAccountEmail\\(\\) on Mage_Core_Model_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/controllers/AccountController.php + + - + message: "#^Method Mage_Customer_AccountController\\:\\:postDispatch\\(\\) should return \\$this\\(Mage_Customer_AccountController\\) but return statement is missing\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/controllers/AccountController.php + + - + message: "#^Method Mage_Customer_AccountController\\:\\:preDispatch\\(\\) should return \\$this\\(Mage_Customer_AccountController\\) but empty return statement found\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/controllers/AccountController.php + + - + message: "#^Parameter \\#3 \\$storeId of method Mage_Customer_Model_Customer\\:\\:sendNewAccountEmail\\(\\) expects string, int given\\.$#" + count: 2 + path: ../app/code/core/Mage/Customer/controllers/AccountController.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/controllers/AccountController.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/controllers/AddressController.php + + - + message: "#^Variable \\$address might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Customer/controllers/AddressController.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Dataflow_Model_Batch_Export will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Batch.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Dataflow_Model_Batch_Import will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Batch.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Dataflow_Model_Batch_Io will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Batch.php + + - + message: "#^Method Mage_Dataflow_Model_Batch\\:\\:setParams\\(\\) should return Mage_Dataflow_Model_Batch_Abstract but returns \\$this\\(Mage_Dataflow_Model_Batch\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Batch.php + + - + message: "#^Property Mage_Dataflow_Model_Batch\\:\\:\\$_batchExport \\(Mage_Dataflow_Model_Batch_Export\\) does not accept string\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Batch.php + + - + message: "#^Property Mage_Dataflow_Model_Batch\\:\\:\\$_batchImport \\(Mage_Dataflow_Model_Batch_Import\\) does not accept string\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Batch.php + + - + message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Abstract\\:\\:deleteCollection\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Batch/Abstract.php + + - + message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Abstract\\:\\:getIdCollection\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Batch/Abstract.php + + - + message: "#^Call to function is_null\\(\\) with Varien_Io_File will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Batch/Io.php + + - + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Dataflow/Model/Batch/Io.php + + - + message: "#^Call to an undefined method Mage_Dataflow_Model_Convert_Action\\:\\:getData\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert.php + + - + message: "#^Call to an undefined method Mage_Dataflow_Model_Convert_Action_Abstract\\:\\:getClassNameByType\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php + + - + message: "#^Call to an undefined method Mage_Dataflow_Model_Convert_Container_Interface\\:\\:setAction\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php + + - + message: "#^Call to an undefined method Mage_Dataflow_Model_Convert_Container_Interface\\:\\:setProfile\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php + + - + message: "#^Property Mage_Dataflow_Model_Convert_Action_Abstract\\:\\:\\$_container \\(Mage_Dataflow_Model_Convert_Container_Abstract\\) does not accept Mage_Dataflow_Model_Convert_Container_Interface\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php + + - + message: "#^Undefined variable\\: \\$action$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Adapter/Db/Table.php + + - + message: "#^If condition is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php + + - + message: "#^Negated boolean expression is always true\\.$#" + count: 3 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Adapter/Zend/Cache.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Adapter/Zend/Db.php + + - + message: "#^Call to an undefined method Mage_Dataflow_Model_Convert_Container_Interface\\:\\:getName\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Container/Collection.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Dataflow_Model_Batch will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Mapper/Column.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Dataflow_Model_Batch_Export will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Mapper/Column.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Dataflow_Model_Batch_Import will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Mapper/Column.php + + - + message: "#^Method Mage_Dataflow_Model_Convert_Mapper_Column\\:\\:getBatchImportModel\\(\\) has invalid return type Mage_Dataflow_Model_Import_Export\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Mapper/Column.php + + - + message: "#^Property Mage_Dataflow_Model_Convert_Mapper_Column\\:\\:\\$_batchExport \\(Mage_Dataflow_Model_Batch_Export\\) does not accept string\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Mapper/Column.php + + - + message: "#^Property Mage_Dataflow_Model_Convert_Mapper_Column\\:\\:\\$_batchImport \\(Mage_Dataflow_Model_Batch_Import\\) does not accept string\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Mapper/Column.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Dataflow_Model_Batch will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Parser/Abstract.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Dataflow_Model_Batch_Export will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Parser/Abstract.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Dataflow_Model_Batch_Import will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Parser/Abstract.php + + - + message: "#^Property Mage_Dataflow_Model_Convert_Parser_Abstract\\:\\:\\$_batchExport \\(Mage_Dataflow_Model_Batch_Export\\) does not accept string\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Parser/Abstract.php + + - + message: "#^Property Mage_Dataflow_Model_Convert_Parser_Abstract\\:\\:\\$_batchImport \\(Mage_Dataflow_Model_Batch_Import\\) does not accept string\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Parser/Abstract.php + + - + message: "#^Argument of an invalid type string\\|false supplied for foreach, only iterables are supported\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Parser/Csv.php + + - + message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Parser/Csv.php + + - + message: "#^Result of && is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Parser/Csv.php + + - + message: "#^Strict comparison using \\=\\=\\= between string and null will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Parser/Csv.php + + - + message: "#^Call to function is_null\\(\\) with SimpleXMLElement will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Parser/Xml/Excel.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Parser/Xml/Excel.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Parser/Xml/Excel.php + + - + message: "#^Method Mage_Dataflow_Model_Convert_Profile_Abstract\\:\\:run\\(\\) should return Mage_Dataflow_Model_Convert_Profile_Abstract but empty return statement found\\.$#" + count: 2 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Profile/Abstract.php + + - + message: "#^Undefined variable\\: \\$profile$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Convert/Profile/Abstract.php + + - + message: "#^Comparison operation \"\\<\" between int\\<0, max\\> and 0 is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Profile.php + + - + message: "#^Result of && is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Profile.php + + - + message: "#^Right side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Profile.php + + - + message: "#^Variable \\$parseFileXml might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Profile.php + + - + message: "#^Variable \\$path might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Dataflow/Model/Profile.php + + - + message: "#^Parameter \\#1 \\$date of method Mage_Core_Model_Resource_Abstract\\:\\:formatDate\\(\\) expects string\\|Zend_Date\\|true\\|null, int\\<1, max\\> given\\.$#" + count: 2 + path: ../app/code/core/Mage/Dataflow/Model/Resource/Profile.php + + - + message: "#^Parameter \\#1 \\$date of method Mage_Core_Model_Resource_Abstract\\:\\:formatDate\\(\\) expects string\\|Zend_Date\\|true\\|null, int\\<1, max\\> given\\.$#" + count: 1 + path: ../app/code/core/Mage/Dataflow/Model/Resource/Profile/History.php + + - + message: "#^Parameter \\#1 \\$currency of method Mage_Directory_Model_Currency\\:\\:getCurrencyRates\\(\\) expects string, Mage_Directory_Model_Currency given\\.$#" + count: 1 + path: ../app/code/core/Mage/Directory/Block/Currency.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Directory/Helper/Data.php + + - + message: "#^Parameter \\#1 \\$storeId of method Mage_Directory_Helper_Data\\:\\:_getRegions\\(\\) expects string, int\\|null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Directory/Helper/Data.php + + - + message: "#^Property Mage_Directory_Helper_Data\\:\\:\\$_countryCollection \\(Mage_Directory_Model_Resource_Country_Collection\\) does not accept Mage_Core_Model_Resource_Db_Collection_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Directory/Helper/Data.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Directory/Model/Country.php + + - + message: "#^Method Mage_Directory_Model_Country\\:\\:getFormat\\(\\) should return Mage_Directory_Model_Country_Format but returns null\\.$#" + count: 1 + path: ../app/code/core/Mage/Directory/Model/Country.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Directory/Model/Currency.php + + - + message: "#^Parameter \\#1 \\$value of method Zend_Currency\\:\\:toCurrency\\(\\) expects float\\|int\\|null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Directory/Model/Currency/Filter.php + + - + message: "#^Variable \\$response might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Directory/Model/Currency/Import/Fixerio.php + + - + message: "#^Method Mage_Directory_Model_Currency_Import_Webservicex\\:\\:_convert\\(\\) should return float\\|null but return statement is missing\\.$#" + count: 1 + path: ../app/code/core/Mage/Directory/Model/Currency/Import/Webservicex.php + + - + message: "#^Parameter \\#1 \\$modelClass of static method Mage\\:\\:getModel\\(\\) expects string, array given\\.$#" + count: 1 + path: ../app/code/core/Mage/Directory/Model/Observer.php + + - + message: "#^Variable \\$importModel might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Directory/Model/Observer.php + + - + message: "#^Variable \\$allowCountries in empty\\(\\) always exists and is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Directory/Model/Resource/Country/Collection.php + + - + message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Directory/Model/Resource/Currency.php + + - + message: "#^Parameter \\#2 \\$countryId of method Mage_Directory_Model_Resource_Region\\:\\:_loadByCountry\\(\\) expects int, string given\\.$#" + count: 2 + path: ../app/code/core/Mage/Directory/Model/Resource/Region.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Resource_Eav_Attribute will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Block/Adminhtml/Catalog/Product/Edit/Tab/Downloadable/Links.php + + - + message: "#^Property Mage_Downloadable_Block_Adminhtml_Catalog_Product_Edit_Tab_Downloadable_Links\\:\\:\\$_purchasedSeparatelyAttribute \\(Mage_Catalog_Model_Resource_Eav_Attribute\\) does not accept Mage_Eav_Model_Entity_Attribute\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Block/Adminhtml/Catalog/Product/Edit/Tab/Downloadable/Links.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Block/Adminhtml/Catalog/Product/Edit/Tab/Downloadable/Samples.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Block/Adminhtml/Sales/Items/Column/Downloadable/Name.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Block/Catalog/Product/Links.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Helper/Catalog/Product/Configuration.php + + - + message: "#^Call to function is_null\\(\\) with resource will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Helper/Download.php + + - + message: "#^Cannot call method streamRead\\(\\) on resource\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Helper/Download.php + + - + message: "#^Cannot call method streamStat\\(\\) on resource\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Helper/Download.php + + - + message: "#^Parameter \\#1 \\$string of function strtolower expects string, bool given\\.$#" + count: 2 + path: ../app/code/core/Mage/Downloadable/Helper/Download.php + + - + message: "#^Property Mage_Downloadable_Helper_Download\\:\\:\\$_handle \\(resource\\) does not accept Varien_Io_File\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Helper/Download.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Helper/File.php + + - + message: "#^Call to function is_null\\(\\) with int\\|string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Model/Link/Api.php + + - + message: "#^Cannot access offset 'file' on bool\\|void\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Model/Link/Api.php + + - + message: "#^Offset 'file' does not exist on array\\{status\\: 'new'\\}\\.$#" + count: 2 + path: ../app/code/core/Mage/Downloadable/Model/Link/Api.php + + - + message: "#^Variable \\$downloadableModel might not be defined\\.$#" + count: 3 + path: ../app/code/core/Mage/Downloadable/Model/Link/Api.php + + - + message: "#^Parameter \\#2 \\$code of class Exception constructor expects int, string given\\.$#" + count: 2 + path: ../app/code/core/Mage/Downloadable/Model/Link/Api/Uploader.php + + - + message: "#^Property Varien_File_Uploader\\:\\:\\$_uploadType \\(string\\) does not accept int\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Model/Link/Api/Uploader.php + + - + message: "#^Parameter \\#2 \\$resource \\(object\\) of method Mage_Downloadable_Model_Link_Api_V2\\:\\:add\\(\\) should be compatible with parameter \\$resource \\(array\\) of method Mage_Downloadable_Model_Link_Api\\:\\:add\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Model/Link/Api/V2.php + + - + message: "#^Left side of && is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Downloadable/Model/Observer.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Model/Observer.php + + - + message: "#^Call to function is_null\\(\\) with float will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Model/Product/Price.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Model/Resource/Link.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Model/Resource/Sample.php + + - + message: "#^Parameter \\#1 \\$item of method Mage_Sales_Model_Order_Pdf_Items_Abstract\\:\\:getSku\\(\\) expects Mage_Sales_Model_Order_Creditmemo_Item\\|Mage_Sales_Model_Order_Invoice_Item, Varien_Object given\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Model/Sales/Order/Pdf/Items/Creditmemo.php + + - + message: "#^Parameter \\#1 \\$item of method Mage_Sales_Model_Order_Pdf_Items_Abstract\\:\\:getSku\\(\\) expects Mage_Sales_Model_Order_Creditmemo_Item\\|Mage_Sales_Model_Order_Invoice_Item, Varien_Object given\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/Model/Sales/Order/Pdf/Items/Invoice.php + + - + message: "#^Cannot access offset 'tmp_name' on bool\\|void\\.$#" + count: 2 + path: ../app/code/core/Mage/Downloadable/controllers/Adminhtml/Downloadable/FileController.php + + - + message: "#^Offset 'file' on array\\{path\\: \\(array\\\\|string\\)\\} in isset\\(\\) does not exist\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/controllers/Adminhtml/Downloadable/FileController.php + + - + message: "#^Parameter \\#2 \\$loginUrl of method Mage_Customer_Model_Session\\:\\:authenticate\\(\\) expects bool\\|null, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/controllers/CustomerController.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/controllers/CustomerController.php + + - + message: "#^Dead catch \\- Mage_Core_Exception is never thrown in the try block\\.$#" + count: 2 + path: ../app/code/core/Mage/Downloadable/controllers/DownloadController.php + + - + message: "#^Method Mage_Customer_Model_Session\\:\\:setBeforeAuthUrl\\(\\) invoked with 2 parameters, 1 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/controllers/DownloadController.php + + - + message: "#^Return type \\(void\\) of method Mage_Downloadable_FileController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Controller_Action\\)\\) of method Mage_Adminhtml_Controller_Action\\:\\:preDispatch\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/controllers/FileController.php + + - + message: "#^Return type \\(void\\) of method Mage_Downloadable_Product_EditController\\:\\:preDispatch\\(\\) should be compatible with return type \\(Mage_Adminhtml_Controller_Action\\) of method Mage_Adminhtml_Catalog_ProductController\\:\\:preDispatch\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Downloadable/controllers/Product/EditController.php + + - + message: "#^Parameter \\#1 \\$readonly of method Varien_Data_Form_Abstract\\:\\:setReadonly\\(\\) expects bool, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Block/Adminhtml/Attribute/Edit/Main/Abstract.php + + - + message: "#^Call to function is_array\\(\\) with string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Block/Adminhtml/Attribute/Edit/Options/Abstract.php + + - + message: "#^Property Zend_Validate_InArray\\:\\:\\$_messageTemplates \\(array\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Adminhtml/System/Config/Source/Inputtype/Validator.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Resource_Entity_Attribute\\:\\:getUsedInForms\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Attribute.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Website will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Attribute.php + + - + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Attribute/Data/Abstract.php + + - + message: "#^Method Mage_Eav_Model_Attribute_Data_Abstract\\:\\:setRequestScope\\(\\) should return string but returns \\$this\\(Mage_Eav_Model_Attribute_Data_Abstract\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Attribute/Data/Abstract.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Eav/Model/Attribute/Data/Abstract.php + + - + message: "#^Property Mage_Eav_Model_Attribute_Data_Abstract\\:\\:\\$_attribite \\(Mage_Eav_Model_Attribute\\) does not accept Mage_Eav_Model_Entity_Attribute_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Attribute/Data/Abstract.php + + - + message: "#^Property Mage_Eav_Model_Attribute_Data_Abstract\\:\\:\\$_dateFilterFormat \\(string\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Attribute/Data/Abstract.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getEntityTypeCode\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Attribute/Data/File.php + + - + message: "#^Call to an undefined method Mage_Core_Model_Resource_Abstract\\:\\:getDefaultAttributes\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Config.php + + - + message: "#^Cannot call method loadByCode\\(\\) on Mage_Core_Model_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Config.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Config.php + + - + message: "#^Method Mage_Eav_Model_Config\\:\\:getAttribute\\(\\) should return Mage_Eav_Model_Entity_Attribute_Abstract\\|false but returns Mage_Eav_Model_Entity_Attribute_Interface\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Config.php + + - + message: "#^Negated boolean expression is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Config.php + + - + message: "#^Parameter \\#1 \\$entityType of method Mage_Eav_Model_Config\\:\\:_createAttribute\\(\\) expects string, Mage_Eav_Model_Entity_Type given\\.$#" + count: 4 + path: ../app/code/core/Mage/Eav/Model/Config.php + + - + message: "#^Parameter \\#1 \\$entityType of method Mage_Eav_Model_Config\\:\\:_initAttributes\\(\\) expects string, Mage_Eav_Model_Entity_Type given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Config.php + + - + message: "#^Parameter \\#1 \\$id of method Mage_Eav_Model_Config\\:\\:_getAttributeReference\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Config.php + + - + message: "#^Property Mage_Eav_Model_Config\\:\\:\\$_attributeData \\(array\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Config.php + + - + message: "#^Property Mage_Eav_Model_Config\\:\\:\\$_entityData \\(array\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Config.php + + - + message: "#^Property Mage_Eav_Model_Config\\:\\:\\$_objects \\(array\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Config.php + + - + message: "#^Property Mage_Eav_Model_Config\\:\\:\\$_references \\(array\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Config.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Config.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Store will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Convert/Adapter/Entity.php + + - + message: "#^Method Mage_Eav_Model_Convert_Adapter_Entity\\:\\:_getCollectionForLoad\\(\\) should return Mage_Eav_Model_Entity_Collection but returns Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Convert/Adapter/Entity.php + + - + message: "#^Parameter \\#1 \\$joinAttr of method Mage_Eav_Model_Convert_Adapter_Entity\\:\\:setJoinAttr\\(\\) expects string, array\\ given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Convert/Adapter/Entity.php + + - + message: "#^Variable \\$defBind might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Convert/Adapter/Entity.php + + - + message: "#^Variable \\$entityIds might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Convert/Adapter/Entity.php + + - + message: "#^Parameter \\#2 \\$string of function explode expects string, array given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Convert/Parser/Abstract.php + + - + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity.php + + - + message: "#^Call to function is_string\\(\\) with Varien_Db_Adapter_Pdo_Mysql will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Method Mage_Eav_Model_Entity_Abstract\\:\\:_getReadAdapter\\(\\) should return Magento_Db_Adapter_Pdo_Mysql but returns Varien_Db_Adapter_Pdo_Mysql\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Method Mage_Eav_Model_Entity_Abstract\\:\\:_getWriteAdapter\\(\\) should return Magento_Db_Adapter_Pdo_Mysql but returns Varien_Db_Adapter_Pdo_Mysql\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Parameter \\#1 \\$object of method Mage_Eav_Model_Entity_Abstract\\:\\:_saveAttribute\\(\\) expects Mage_Core_Model_Abstract, Varien_Object given\\.$#" + count: 2 + path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Parameter \\#1 \\$object of method Mage_Eav_Model_Entity_Abstract\\:\\:load\\(\\) expects Mage_Core_Model_Abstract, Varien_Object given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Parameter \\#1 \\$select of method Mage_Eav_Model_Entity_Abstract\\:\\:_addLoadAttributesSelectFields\\(\\) expects Varien_Db_Select, Zend_Db_Select given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Parameter \\#2 \\$arguments of static method Mage\\:\\:getModel\\(\\) expects array\\|object, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Property Mage_Eav_Model_Entity_Abstract\\:\\:\\$_read \\(Varien_Db_Adapter_Pdo_Mysql\\) does not accept Varien_Db_Adapter_Interface\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Property Mage_Eav_Model_Entity_Abstract\\:\\:\\$_read \\(Varien_Db_Adapter_Pdo_Mysql\\) does not accept string\\|Zend_Db_Adapter_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Property Mage_Eav_Model_Entity_Abstract\\:\\:\\$_type \\(Mage_Eav_Model_Entity_Type\\) in empty\\(\\) is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Property Mage_Eav_Model_Entity_Abstract\\:\\:\\$_write \\(Varien_Db_Adapter_Pdo_Mysql\\) does not accept Varien_Db_Adapter_Interface\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Property Mage_Eav_Model_Entity_Abstract\\:\\:\\$_write \\(Varien_Db_Adapter_Pdo_Mysql\\) does not accept string\\|Zend_Db_Adapter_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Result of && is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Variable \\$attributeCode might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Variable \\$id might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Variable \\$instance might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Variable \\$method might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Variable \\$part might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Abstract\\:\\:getIdByCode\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php + + - + message: "#^Method Mage_Eav_Model_Entity_Attribute_Abstract\\:\\:getFlatUpdateSelect\\(\\) should return \\$this\\(Mage_Eav_Model_Entity_Attribute_Abstract\\)\\|Varien_Db_Select but returns null\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php + + - + message: "#^Property Mage_Eav_Model_Entity_Attribute_Abstract\\:\\:\\$_backend \\(Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\) in empty\\(\\) is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php + + - + message: "#^Property Mage_Eav_Model_Entity_Attribute_Abstract\\:\\:\\$_entity \\(Mage_Eav_Model_Entity_Abstract\\) does not accept Mage_Eav_Model_Entity_Type\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php + + - + message: "#^Property Mage_Eav_Model_Entity_Attribute_Abstract\\:\\:\\$_frontend \\(Mage_Eav_Model_Entity_Attribute_Frontend_Abstract\\) in empty\\(\\) is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php + + - + message: "#^Property Mage_Eav_Model_Entity_Attribute_Abstract\\:\\:\\$_source \\(Mage_Eav_Model_Entity_Attribute_Source_Abstract\\) in empty\\(\\) is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php + + - + message: "#^Return type \\(\\$this\\(Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\)\\) of method Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\:\\:setValueId\\(\\) should be compatible with return type \\(int\\) of method Mage_Eav_Model_Entity_Attribute_Backend_Interface\\:\\:setValueId\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Backend/Abstract.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Frontend/Abstract.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Frontend/Abstract.php + + - + message: "#^Variable \\$out in empty\\(\\) always exists and is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Frontend/Abstract.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Resource_Entity_Attribute_Group\\:\\:deleteGroups\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Group.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Source/Boolean.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:getStoreId\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Source/Table.php + + - + message: "#^Parameter \\#2 \\$attribute of method Mage_Eav_Model_Resource_Entity_Attribute_Option\\:\\:addOptionValueToCollection\\(\\) expects Mage_Eav_Model_Entity_Attribute, Mage_Eav_Model_Entity_Attribute_Abstract given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Source/Table.php + + - + message: "#^Parameter \\#1 \\$resource of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:__construct\\(\\) expects Mage_Core_Model_Resource_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Collection.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute_Interface\\:\\:getAttributeCode\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + + - + message: "#^Constructor of class Mage_Eav_Model_Entity_Collection_Abstract has an unused parameter \\$resource\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + + - + message: "#^Parameter \\#1 \\$className of method Varien_Data_Collection\\:\\:setItemObjectClass\\(\\) expects string, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + + - + message: "#^Parameter \\#1 \\$select of method Varien_Data_Collection_Db\\:\\:_fetchAll\\(\\) expects Zend_Db_Select, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + + - + message: "#^Parameter \\#2 \\$alias of method Varien_Db_Adapter_Interface\\:\\:quoteColumnAs\\(\\) expects string, null given\\.$#" + count: 4 + path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + + - + message: "#^Parameter \\#2 \\$array of function implode expects array\\, array\\\\|string\\> given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + + - + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int\\\\|int\\<1, max\\> given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + + - + message: "#^Parameter \\#2 \\$return of function print_r expects bool, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + + - + message: "#^Property Mage_Eav_Model_Entity_Collection_Abstract\\:\\:\\$_entity \\(Mage_Eav_Model_Entity_Abstract\\) in empty\\(\\) is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + + - + message: "#^Variable \\$attrArr might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + + - + message: "#^Variable \\$bindAttribute might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + + - + message: "#^Variable \\$entity might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + + - + message: "#^Variable \\$query might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + + - + message: "#^Variable \\$select might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + + - + message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + + - + message: "#^Binary operation \"\\+\" between string and 1 results in an error\\.$#" + count: 3 + path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + + - + message: "#^Binary operation \"\\+\" between string and 10 results in an error\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + + - + message: "#^Call to an undefined method Varien_Db_Adapter_Interface\\:\\:lastInsertId\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + + - + message: "#^Left side of && is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + + - + message: "#^Method Mage_Eav_Model_Entity_Setup\\:\\:getDefaultAttributeGroupId\\(\\) should return int but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + + - + message: "#^Method Mage_Eav_Model_Entity_Setup\\:\\:getDefaultAttributeSetId\\(\\) should return int but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + + - + message: "#^Parameter \\#1 \\$code of method Mage_Eav_Model_Entity_Setup\\:\\:updateEntityType\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + + - + message: "#^Parameter \\#1 \\$priTableName of method Mage_Core_Model_Resource_Setup\\:\\:getFkName\\(\\) expects string, array\\ given\\.$#" + count: 3 + path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + + - + message: "#^Parameter \\#1 \\$tableName of method Mage_Core_Model_Resource_Setup\\:\\:getIdxName\\(\\) expects string, array\\ given\\.$#" + count: 6 + path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + + - + message: "#^Parameter \\#2 \\$field of method Mage_Eav_Model_Entity_Setup\\:\\:updateEntityType\\(\\) expects string, array\\ given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + + - + message: "#^Parameter \\#3 \\$default of method Mage_Eav_Model_Entity_Setup\\:\\:_getValue\\(\\) expects string\\|null, array given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + + - + message: "#^Parameter \\#3 \\$default of method Mage_Eav_Model_Entity_Setup\\:\\:_getValue\\(\\) expects string\\|null, false given\\.$#" + count: 2 + path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + + - + message: "#^Parameter \\#3 \\$default of method Mage_Eav_Model_Entity_Setup\\:\\:_getValue\\(\\) expects string\\|null, int given\\.$#" + count: 7 + path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + + - + message: "#^Parameter \\#3 \\$field of method Mage_Eav_Model_Entity_Setup\\:\\:updateAttribute\\(\\) expects string, array given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Eav_Model_Entity_Setup\\:\\:updateEntityType\\(\\) expects string\\|null, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + + - + message: "#^Variable \\$connection might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + + - + message: "#^Property Mage_Eav_Model_Entity_Type\\:\\:\\$_sets \\(Mage_Eav_Model_Resource_Entity_Attribute_Set_Collection\\) in empty\\(\\) is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Entity/Type.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Abstract will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Form.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Store will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Form.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Eav_Model_Entity_Type will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Form.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 3 + path: ../app/code/core/Mage/Eav/Model/Form.php + + - + message: "#^Parameter \\#1 \\$attribute of static method Mage_Eav_Model_Attribute_Data\\:\\:factory\\(\\) expects Mage_Eav_Model_Attribute, Mage_Eav_Model_Entity_Attribute given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Form.php + + - + message: "#^Parameter \\#2 \\.\\.\\.\\$arrays of function array_merge expects array, false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Form.php + + - + message: "#^Ternary operator condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Resource/Attribute/Collection.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Resource/Config.php + + - + message: "#^Method Mage_Eav_Model_Resource_Entity_Attribute\\:\\:_getMaxSortOrder\\(\\) should return int but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Resource/Entity/Attribute.php + + - + message: "#^Method Mage_Eav_Model_Resource_Entity_Attribute\\:\\:getIdByCode\\(\\) should return int but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Resource/Entity/Attribute.php + + - + message: "#^Method Mage_Eav_Model_Resource_Entity_Attribute_Group\\:\\:_getMaxSortOrder\\(\\) should return int but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Resource/Entity/Attribute/Group.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:getStoreId\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Resource/Entity/Attribute/Option.php + + - + message: "#^Method Mage_Eav_Model_Resource_Entity_Attribute_Set\\:\\:getDefaultGroupId\\(\\) should return int\\|null but returns string\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Resource/Entity/Attribute/Set.php + + - + message: "#^Variable \\$store might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Eav/Model/Resource/Form/Attribute/Collection.php + + - + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Resource/Form/Fieldset/Collection.php + + - + message: "#^PHPDoc tag @param for parameter \\$object with type Mage_Eav_Model_Resource_Form_Type is incompatible with native type Mage_Core_Model_Abstract\\.$#" + count: 2 + path: ../app/code/core/Mage/Eav/Model/Resource/Form/Type.php + + - + message: "#^Parameter \\#1 \\$object of method Mage_Eav_Model_Resource_Form_Type\\:\\:getEntityTypes\\(\\) expects Mage_Eav_Model_Form_Type, Mage_Core_Model_Abstract given\\.$#" + count: 1 + path: ../app/code/core/Mage/Eav/Model/Resource/Form/Type.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/GiftMessage/Block/Adminhtml/Sales/Order/Create/Items.php + + - + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/GiftMessage/Block/Adminhtml/Sales/Order/View/Items.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/GiftMessage/Block/Adminhtml/Sales/Order/View/Items.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/GiftMessage/Block/Adminhtml/Sales/Order/View/Items.php + + - + message: "#^Call to function is_null\\(\\) with Mage_GiftMessage_Model_Message will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/GiftMessage/Block/Message/Form.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/GiftMessage/Helper/Message.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/GiftMessage/Helper/Message.php + + - + message: "#^Call to function is_null\\(\\) with int\\|string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/GiftMessage/Model/Api.php + + - + message: "#^Method Mage_GiftMessage_Model_Api_V2\\:\\:_prepareData\\(\\) should return array but returns mixed\\.$#" + count: 1 + path: ../app/code/core/Mage/GiftMessage/Model/Api/V2.php + + - + message: "#^Return type \\(stdClass\\) of method Mage_GiftMessage_Model_Api_V2\\:\\:_setGiftMessage\\(\\) should be compatible with return type \\(array\\) of method Mage_GiftMessage_Model_Api\\:\\:_setGiftMessage\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/GiftMessage/Model/Api/V2.php + + - + message: "#^Method Mage_GiftMessage_Model_Message\\:\\:getEntityModelByType\\(\\) should return Mage_Eav_Model_Entity_Abstract but returns Mage_Core_Model_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/GiftMessage/Model/Message.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/GiftMessage/Model/Observer.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:setGiftMessageId\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/GiftMessage/controllers/IndexController.php + + - + message: "#^Call to an undefined method Mage_GiftMessage_IndexController\\:\\:_getMappedType\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/GiftMessage/controllers/IndexController.php + + - + message: "#^Method Mage_Eav_Model_Entity_Abstract\\:\\:load\\(\\) invoked with 1 parameter, 2\\-3 required\\.$#" + count: 1 + path: ../app/code/core/Mage/GiftMessage/controllers/IndexController.php + + - + message: "#^Method Mage_GoogleAnalytics_Block_Ga\\:\\:_getOrdersTrackingCodeAnalytics\\(\\) should return string but empty return statement found\\.$#" + count: 1 + path: ../app/code/core/Mage/GoogleAnalytics/Block/Ga.php + + - + message: "#^Method Mage_GoogleAnalytics_Block_Ga\\:\\:_getOrdersTrackingCodeUniversal\\(\\) should return string but empty return statement found\\.$#" + count: 1 + path: ../app/code/core/Mage/GoogleAnalytics/Block/Ga.php + + - + message: "#^Method Mage_GoogleAnalytics_Helper_Data\\:\\:isUseUniversalAnalytics\\(\\) should return string but returns bool\\.$#" + count: 1 + path: ../app/code/core/Mage/GoogleAnalytics/Helper/Data.php + + - + message: "#^Return type \\(void\\) of method Mage_GoogleCheckout_Model_Payment\\:\\:authorize\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Abstract\\)\\) of method Mage_Payment_Model_Method_Abstract\\:\\:authorize\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/GoogleCheckout/Model/Payment.php + + - + message: "#^Return type \\(void\\) of method Mage_GoogleCheckout_Model_Payment\\:\\:cancel\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Abstract\\)\\) of method Mage_Payment_Model_Method_Abstract\\:\\:cancel\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/GoogleCheckout/Model/Payment.php + + - + message: "#^Return type \\(void\\) of method Mage_GoogleCheckout_Model_Payment\\:\\:capture\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Abstract\\)\\) of method Mage_Payment_Model_Method_Abstract\\:\\:capture\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/GoogleCheckout/Model/Payment.php + + - + message: "#^Return type \\(void\\) of method Mage_GoogleCheckout_Model_Payment\\:\\:refund\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Abstract\\)\\) of method Mage_Payment_Model_Method_Abstract\\:\\:refund\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/GoogleCheckout/Model/Payment.php + + - + message: "#^Return type \\(void\\) of method Mage_GoogleCheckout_Model_Payment\\:\\:void\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Abstract\\)\\) of method Mage_Payment_Model_Method_Abstract\\:\\:void\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/GoogleCheckout/Model/Payment.php + + - + message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 4 + path: ../app/code/core/Mage/ImportExport/Block/Adminhtml/Export/Filter.php + + - + message: "#^Parameter \\#1 \\$limit of method Mage_Adminhtml_Block_Widget_Grid\\:\\:setDefaultLimit\\(\\) expects int, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Block/Adminhtml/Export/Filter.php + + - + message: "#^Return type \\(false\\) of method Mage_ImportExport_Block_Adminhtml_Export_Filter\\:\\:getRowUrl\\(\\) should be compatible with return type \\(string\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:getRowUrl\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Block/Adminhtml/Export/Filter.php + + - + message: "#^Method Mage_ImportExport_Helper_Data\\:\\:getMaxUploadSize\\(\\) should return int but returns string\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Helper/Data.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Abstract.php + + - + message: "#^Parameter \\#2 \\$arguments of static method Mage\\:\\:getModel\\(\\) expects array\\|object, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Abstract.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export.php + + - + message: "#^Instanceof between Mage_Core_Model_Abstract\\|false and Mage_ImportExport_Model_Export_Adapter_Abstract will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export.php + + - + message: "#^Instanceof between Mage_Core_Model_Abstract\\|false and Mage_ImportExport_Model_Export_Entity_Abstract will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/ImportExport/Model/Export.php + + - + message: "#^Property Mage_ImportExport_Model_Export\\:\\:\\$_entityAdapter \\(Mage_ImportExport_Model_Export_Entity_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export.php + + - + message: "#^Property Mage_ImportExport_Model_Export\\:\\:\\$_writer \\(Mage_ImportExport_Model_Export_Adapter_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export.php + + - + message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php + + - + message: "#^Property Mage_ImportExport_Model_Export_Entity_Abstract\\:\\:\\$_connection \\(Varien_Db_Adapter_Pdo_Mysql\\) does not accept Varien_Db_Adapter_Interface\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php + + - + message: "#^Property Mage_ImportExport_Model_Export_Entity_Abstract\\:\\:\\$_entityTypeId \\(int\\) does not accept string\\|null\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php + + - + message: "#^Call to an undefined method Mage_Customer_Model_Entity_Attribute\\:\\:getFrontendInput\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Customer.php + + - + message: "#^Call to an undefined method Mage_Customer_Model_Entity_Attribute\\:\\:getSource\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Customer.php + + - + message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Customer.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addCategoryIds\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php + + - + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:setStoreId\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php + + - + message: "#^Instanceof between Mage_Core_Model_Abstract and Mage_ImportExport_Model_Export_Entity_Product_Type_Abstract will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php + + - + message: "#^Offset int\\|string on non\\-empty\\-array\\ in isset\\(\\) always exists and is not nullable\\.$#" + count: 2 + path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php + + - + message: "#^Parameter \\#1 \\$value of method Mage_Catalog_Model_Resource_Category_Collection\\:\\:getItemById\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php + + - + message: "#^Variable \\$collection might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php + + - + message: "#^Binary operation \"\\+\" between string and 50\\|int\\<100, max\\> results in an error\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import.php + + - + message: "#^Cannot access offset 'file' on bool\\|void\\.$#" + count: 2 + path: ../app/code/core/Mage/ImportExport/Model/Import.php + + - + message: "#^Cannot access offset 'path' on bool\\|void\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import.php + + - + message: "#^Instanceof between Mage_Core_Model_Abstract\\|false and Mage_ImportExport_Model_Import_Entity_Abstract will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import.php + + - + message: "#^Parameter \\#2 \\$arguments of static method Mage\\:\\:getModel\\(\\) expects array\\|object, string given\\.$#" + count: 3 + path: ../app/code/core/Mage/ImportExport/Model/Import.php + + - + message: "#^Property Mage_ImportExport_Model_Import\\:\\:\\$_entityAdapter \\(Mage_ImportExport_Model_Import_Entity_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import.php + + - + message: "#^Static property Mage_ImportExport_Model_Import\\:\\:\\$_entityInvalidatedIndexes \\(Mage_ImportExport_Model_Import_Entity_Abstract\\) does not accept default value of type array\\\\>\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import.php + + - + message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php + + - + message: "#^Property Mage_ImportExport_Model_Import_Entity_Abstract\\:\\:\\$_connection \\(Varien_Convert_Adapter_Interface\\) does not accept Varien_Db_Adapter_Interface\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php + + - + message: "#^Property Mage_ImportExport_Model_Import_Entity_Abstract\\:\\:\\$_entityTypeId \\(int\\) does not accept string\\|null\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php + + - + message: "#^Call to an undefined method Mage_Customer_Model_Entity_Attribute\\:\\:getBackend\\(\\)\\.$#" + count: 3 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php + + - + message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:insertMultiple\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php + + - + message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:insertOnDuplicate\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php + + - + message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:query\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php + + - + message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:quoteInto\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php + + - + message: "#^Parameter \\#1 \\$str of method Mage_Core_Helper_UnserializeArray\\:\\:unserialize\\(\\) expects string, array given\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php + + - + message: "#^Variable \\$entityId might not be defined\\.$#" + count: 4 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php + + - + message: "#^Call to an undefined method Mage_Customer_Model_Entity_Attribute\\:\\:getBackend\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer/Address.php + + - + message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:delete\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer/Address.php + + - + message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:insertMultiple\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer/Address.php + + - + message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:insertOnDuplicate\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer/Address.php + + - + message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:quoteInto\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer/Address.php + + - + message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:delete\\(\\)\\.$#" + count: 8 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:fetchPairs\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:insertMultiple\\(\\)\\.$#" + count: 3 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:insertOnDuplicate\\(\\)\\.$#" + count: 14 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:query\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:quoteInto\\(\\)\\.$#" + count: 12 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:select\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Call to function is_null\\(\\) with Mage_ImportExport_Model_Import_Uploader will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Instanceof between Mage_Core_Model_Abstract and Mage_ImportExport_Model_Import_Entity_Product_Type_Abstract will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Method Mage_ImportExport_Model_Import_Entity_Product\\:\\:getConnection\\(\\) should return Varien_Db_Adapter_Pdo_Mysql but returns Varien_Convert_Adapter_Interface\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Negated boolean expression is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Parameter \\#1 \\$value of method Mage_Catalog_Model_Resource_Category_Collection\\:\\:getItemById\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Parameter \\#2 \\$increment of method Varien_Db_Adapter_Interface\\:\\:changeTableAutoIncrement\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Property Mage_ImportExport_Model_Import_Entity_Product\\:\\:\\$_urlKeyAttributeId \\(int\\) does not accept string\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Result of \\|\\| is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Variable \\$prevOptionId might not be defined\\.$#" + count: 4 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Variable \\$rowSku might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Variable \\$sku might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Variable \\$productId might not be defined\\.$#" + count: 4 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Configurable.php + + - + message: "#^Variable \\$productSuperAttrId might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Configurable.php + + - + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Grouped.php + + - + message: "#^Variable \\$productData might not be defined\\.$#" + count: 3 + path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Grouped.php + + - + message: "#^Cannot access offset 'name' on bool\\|void\\.$#" + count: 2 + path: ../app/code/core/Mage/ImportExport/Model/Import/Uploader.php + + - + message: "#^Property Varien_File_Uploader\\:\\:\\$_uploadType \\(string\\) does not accept int\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Import/Uploader.php + + - + message: "#^Else branch is unreachable because previous condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Resource/Import/Data.php + + - + message: "#^Property Mage_ImportExport_Model_Resource_Import_Data\\:\\:\\$_iterator \\(IteratorIterator\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/ImportExport/Model/Resource/Import/Data.php + + - + message: "#^Parameter \\#2 \\$elementId of method Mage_ImportExport_Block_Adminhtml_Import_Frame_Result\\:\\:addAction\\(\\) expects string, array\\ given\\.$#" + count: 2 + path: ../app/code/core/Mage/ImportExport/controllers/Adminhtml/ImportController.php + + - + message: "#^Parameter \\#1 \\$date of method Mage_Core_Model_Resource_Abstract\\:\\:formatDate\\(\\) expects string\\|Zend_Date\\|true\\|null, int\\<1, max\\> given\\.$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Event.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Index_Model_Resource_Process_Collection will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Indexer.php + + - + message: "#^Method Mage_Index_Model_Lock\\:\\:getInstance\\(\\) should return \\$this\\(Mage_Index_Model_Lock\\) but returns Mage_Index_Model_Lock\\.$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Lock.php + + - + message: "#^Property Mage_Index_Model_Lock\\:\\:\\$_storage \\(Mage_Index_Model_Lock_Storage_Interface\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Lock.php + + - + message: "#^Strict comparison using \\=\\=\\= between mixed and null will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Lock.php + + - + message: "#^Method Mage_Core_Model_Resource\\:\\:getConnection\\(\\) invoked with 2 parameters, 1 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Lock/Storage/Db.php + + - + message: "#^Method Mage_Index_Model_Lock_Storage_Db\\:\\:releaseLock\\(\\) should return int\\|null but returns bool\\.$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Lock/Storage/Db.php + + - + message: "#^Property Mage_Index_Model_Lock_Storage_Db\\:\\:\\$_helper \\(Mage_Index_Model_Resource_Helper_Mysql4\\) does not accept Mage_Core_Model_Resource_Helper_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Lock/Storage/Db.php + + - + message: "#^Return type \\(int\\|null\\) of method Mage_Index_Model_Lock_Storage_Db\\:\\:releaseLock\\(\\) should be compatible with return type \\(bool\\) of method Mage_Index_Model_Lock_Storage_Interface\\:\\:releaseLock\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Lock/Storage/Db.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Index_Model_Lock will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Process.php + + - + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Index/Model/Process.php + + - + message: "#^Parameter \\#1 \\$namespace of method Mage_Index_Model_Event\\:\\:setDataNamespace\\(\\) expects string, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Process.php + + - + message: "#^Parameter \\#1 \\$process of method Mage_Index_Model_Event\\:\\:setProcess\\(\\) expects Mage_Index_Model_Process, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Process.php + + - + message: "#^Parameter \\#2 \\$status of method Mage_Index_Model_Event\\:\\:addProcessId\\(\\) expects string, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Process.php + + - + message: "#^Call to function is_array\\(\\) with '' will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Resource/Event.php + + - + message: "#^Property Varien_Data_Collection\\:\\:\\$_totalRecords \\(int\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Resource/Event/Collection.php + + - + message: "#^Property Varien_Data_Collection_Db\\:\\:\\$_data \\(array\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Resource/Event/Collection.php + + - + message: "#^Parameter \\#1 \\$adapter of method Varien_Db_Adapter_Interface\\:\\:setCacheAdapter\\(\\) expects Zend_Cache_Backend_Interface, Zend_Cache_Core given\\.$#" + count: 2 + path: ../app/code/core/Mage/Index/Model/Resource/Lock/Resource.php + + - + message: "#^Return type \\(Varien_Db_Adapter_Interface\\|false\\) of method Mage_Index_Model_Resource_Lock_Resource\\:\\:_getDefaultConnection\\(\\) should be compatible with return type \\(string\\) of method Mage_Core_Model_Resource\\:\\:_getDefaultConnection\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Resource/Lock/Resource.php + + - + message: "#^Parameter \\#1 \\$date of method Mage_Core_Model_Resource_Abstract\\:\\:formatDate\\(\\) expects string\\|Zend_Date\\|true\\|null, int\\<1, max\\> given\\.$#" + count: 5 + path: ../app/code/core/Mage/Index/Model/Resource/Process.php + + - + message: "#^Parameter \\#2 \\$true of method Varien_Db_Adapter_Interface\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Resource/Process/Collection.php + + - + message: "#^Method Mage_Index_Model_Resource_Setup\\:\\:_syncIndexes\\(\\) should return \\$this\\(Mage_Index_Model_Resource_Setup\\) but return statement is missing\\.$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Resource/Setup.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Resource/Setup.php + + - + message: "#^Return type \\(void\\) of method Mage_Index_Model_Resource_Setup\\:\\:applyUpdates\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Resource_Setup\\)\\|true\\) of method Mage_Core_Model_Resource_Setup\\:\\:applyUpdates\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Index/Model/Resource/Setup.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/Controller/Action.php + + - + message: "#^Offset 'path' does not exist on array\\{\\000\\*\\000_parent\\: Varien_Simplexml_Element\\}\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/Model/Config.php + + - + message: "#^Parameter \\#2 \\$mergeToObject of method Mage_Core_Model_Config\\:\\:loadModulesConfiguration\\(\\) expects Mage_Core_Model_Config_Base\\|null, \\$this\\(Mage_Install_Model_Config\\) given\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/Model/Config.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Install_Model_Session will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/Model/Installer.php + + - + message: "#^Constant data not found\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/Model/Installer.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/Model/Installer.php + + - + message: "#^Parameter \\#2 \\$value of method Mage_Core_Model_Resource_Setup\\:\\:setConfigData\\(\\) expects string, int given\\.$#" + count: 5 + path: ../app/code/core/Mage/Install/Model/Installer.php + + - + message: "#^Property Mage_Install_Model_Installer\\:\\:\\$_dataModel \\(Mage_Install_Model_Session\\) does not accept Varien_Object\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/Model/Installer.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Install_Model_Installer will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/Model/Installer/Abstract.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Install_Model_Installer_Data\\|Mage_Install_Model_Session will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/Model/Installer/Console.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/Model/Installer/Console.php + + - + message: "#^If condition is always false\\.$#" + count: 7 + path: ../app/code/core/Mage/Install/Model/Installer/Console.php + + - + message: "#^Call to an undefined method Mage_Install_Model_Installer_Db_Abstract\\:\\:getVersion\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/Model/Installer/Db.php + + - + message: "#^Method Mage_Install_Model_Installer_Db\\:\\:_getDbResource\\(\\) should return Mage_Install_Model_Installer_Db_Abstract but returns resource\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/Model/Installer/Db.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Install/Model/Installer/Db.php + + - + message: "#^Property Mage_Install_Model_Installer_Db\\:\\:\\$_dbResource \\(resource\\) does not accept Mage_Core_Model_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/Model/Installer/Db.php + + - + message: "#^Property Mage_Install_Model_Installer_Db\\:\\:\\$_dbResource \\(resource\\) in isset\\(\\) is not nullable\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/Model/Installer/Db.php + + - + message: "#^Property Mage_Install_Model_Installer_Db_Abstract\\:\\:\\$_connection \\(Varien_Db_Adapter_Interface\\) in isset\\(\\) is not nullable\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/Model/Installer/Db/Abstract.php + + - + message: "#^Method Mage_Install_IndexController\\:\\:preDispatch\\(\\) with return type void returns void but should not return anything\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/controllers/IndexController.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/controllers/IndexController.php + + - + message: "#^Result of method Mage_Core_Controller_Varien_Action\\:\\:preDispatch\\(\\) \\(void\\) is used\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/controllers/IndexController.php + + - + message: "#^Method Mage_Install_WizardController\\:\\:preDispatch\\(\\) with return type void returns void but should not return anything\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/controllers/WizardController.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 8 + path: ../app/code/core/Mage/Install/controllers/WizardController.php + + - + message: "#^Result of method Mage_Core_Controller_Varien_Action\\:\\:preDispatch\\(\\) \\(void\\) is used\\.$#" + count: 1 + path: ../app/code/core/Mage/Install/controllers/WizardController.php + + - + message: "#^Method Mage_Log_Model_Aggregation\\:\\:_date\\(\\) never returns false so it can be removed from the return type\\.$#" + count: 1 + path: ../app/code/core/Mage/Log/Model/Aggregation.php + + - + message: "#^Method Mage_Log_Model_Aggregation\\:\\:_removeEmpty\\(\\) is unused\\.$#" + count: 1 + path: ../app/code/core/Mage/Log/Model/Aggregation.php + + - + message: "#^Parameter \\#1 \\$id of method Mage_Log_Model_Aggregation\\:\\:_update\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Log/Model/Aggregation.php + + - + message: "#^Property Mage_Log_Model_Aggregation\\:\\:\\$_lastRecord \\(string\\) does not accept int\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Log/Model/Aggregation.php + + - + message: "#^Binary operation \"\\+\" between non\\-falsy\\-string and 1 results in an error\\.$#" + count: 2 + path: ../app/code/core/Mage/Log/Model/Resource/Log.php + + - + message: "#^Method Mage_Media_Model_File_Image\\:\\:getImage\\(\\) should return bool\\|resource but returns GdImage\\.$#" + count: 1 + path: ../app/code/core/Mage/Media/Model/File/Image.php + + - + message: "#^Method Mage_Media_Model_File_Image\\:\\:getTmpImage\\(\\) should return resource but returns GdImage\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Media/Model/File/Image.php + + - + message: "#^Parameter \\#1 \\$dst_image of function imagecopyresampled expects GdImage, resource given\\.$#" + count: 1 + path: ../app/code/core/Mage/Media/Model/File/Image.php + + - + message: "#^Parameter \\#1 \\$image of function imagedestroy expects GdImage, resource given\\.$#" + count: 1 + path: ../app/code/core/Mage/Media/Model/File/Image.php + + - + message: "#^Parameter \\#1 \\$image of function imagegif expects GdImage, resource given\\.$#" + count: 1 + path: ../app/code/core/Mage/Media/Model/File/Image.php + + - + message: "#^Parameter \\#1 \\$image of function imagejpeg expects GdImage, resource given\\.$#" + count: 1 + path: ../app/code/core/Mage/Media/Model/File/Image.php + + - + message: "#^Parameter \\#1 \\$image of function imagepng expects GdImage, resource given\\.$#" + count: 1 + path: ../app/code/core/Mage/Media/Model/File/Image.php + + - + message: "#^Parameter \\#2 \\$src_image of function imagecopyresampled expects GdImage, resource given\\.$#" + count: 1 + path: ../app/code/core/Mage/Media/Model/File/Image.php + + - + message: "#^Call to function is_null\\(\\) with resource will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Media/Model/Image.php + + - + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Media/Model/Image.php + + - + message: "#^Property Mage_Media_Model_Image\\:\\:\\$_image \\(resource\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Media/Model/Image.php + + - + message: "#^Property Mage_Media_Model_Image\\:\\:\\$_tmpImage \\(resource\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Media/Model/Image.php + + - + message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'sendPerSubscriber' given\\.$#" + count: 1 + path: ../app/code/core/Mage/Newsletter/Model/Observer.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Newsletter_Model_Subscriber will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Newsletter/Model/Problem.php + + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Newsletter/Model/Problem.php + + - + message: "#^Method Mage_Newsletter_Model_Problem\\:\\:getSubscriber\\(\\) should return Mage_Newsletter_Model_Subscriber but returns null\\.$#" + count: 1 + path: ../app/code/core/Mage/Newsletter/Model/Problem.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Newsletter_Model_Resource_Subscriber_Collection will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Newsletter/Model/Queue.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Newsletter_Model_Template will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Newsletter/Model/Queue.php + + - + message: "#^Parameter \\#1 \\$queue of method Mage_Newsletter_Model_Resource_Queue\\:\\:setStores\\(\\) expects Mage_Newsletter_Model_Queue, Mage_Core_Model_Abstract given\\.$#" + count: 1 + path: ../app/code/core/Mage/Newsletter/Model/Resource/Queue.php + + - + message: "#^Call to an undefined method Mage_Customer_Model_Entity_Attribute\\:\\:getAttributeId\\(\\)\\.$#" + count: 3 + path: ../app/code/core/Mage/Newsletter/Model/Resource/Subscriber/Collection.php + + - + message: "#^Call to an undefined method Mage_Customer_Model_Entity_Attribute\\:\\:getBackend\\(\\)\\.$#" + count: 3 + path: ../app/code/core/Mage/Newsletter/Model/Resource/Subscriber/Collection.php + + - + message: "#^Parameter \\#2 \\$true of method Varien_Db_Adapter_Interface\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" + count: 2 + path: ../app/code/core/Mage/Newsletter/Model/Resource/Subscriber/Collection.php + + - + message: "#^Parameter \\#3 \\$false of method Varien_Db_Adapter_Interface\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" + count: 2 + path: ../app/code/core/Mage/Newsletter/Model/Resource/Subscriber/Collection.php + + - + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Newsletter/Model/Resource/Template.php + + - + message: "#^Call to function is_null\\(\\) with bool will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Newsletter/Model/Subscriber.php + + - + message: "#^Parameter \\#1 \\$scope of method Mage_Newsletter_Model_Resource_Subscriber\\:\\:setMessagesScope\\(\\) expects string, bool given\\.$#" + count: 1 + path: ../app/code/core/Mage/Newsletter/Model/Subscriber.php + + - + message: "#^Call to function is_null\\(\\) with Zend_Mail will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Newsletter/Model/Template.php + + - + message: "#^Parameter \\#1 \\$storeId of method Mage_Core_Model_Email_Template_Filter\\:\\:setStoreId\\(\\) expects int, Mage_Core_Model_Store given\\.$#" + count: 1 + path: ../app/code/core/Mage/Newsletter/Model/Template.php + + - + message: "#^Parameter \\#1 \\$string of function strlen expects string, bool given\\.$#" + count: 1 + path: ../app/code/core/Mage/Newsletter/Model/Template.php + + - + message: "#^Property Mage_Newsletter_Model_Template\\:\\:\\$_mail \\(Zend_Mail\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Newsletter/Model/Template.php + + - + message: "#^Method Mage_Newsletter_ManageController\\:\\:saveAction\\(\\) should return Mage_Newsletter_ManageController but return statement is missing\\.$#" + count: 1 + path: ../app/code/core/Mage/Newsletter/controllers/ManageController.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Newsletter/controllers/ManageController.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Oauth/Block/Adminhtml/Oauth/Consumer/Edit.php + + - + message: "#^Parameter \\#1 \\$length of function openssl_random_pseudo_bytes expects int, float given\\.$#" + count: 1 + path: ../app/code/core/Mage/Oauth/Helper/Data.php + + - + message: "#^Parameter \\#2 \\$idFieldName of method Mage_Core_Model_Resource_Db_Abstract\\:\\:_init\\(\\) expects string, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Oauth/Model/Resource/Nonce.php + + - + message: "#^Parameter \\#1 \\$date of static method Varien_Date\\:\\:formatDate\\(\\) expects string\\|Zend_Date\\|true\\|null, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Oauth/Model/Resource/Token.php + + - + message: "#^Parameter \\#2 \\$value of method Varien_Data_Collection\\:\\:addFilter\\(\\) expects array\\|string, int given\\.$#" + count: 4 + path: ../app/code/core/Mage/Oauth/Model/Resource/Token/Collection.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 2 + path: ../app/code/core/Mage/Oauth/controllers/Adminhtml/Oauth/AuthorizeController.php + + - + message: "#^Return type \\(void\\) of method Mage_Oauth_Adminhtml_Oauth_AuthorizeController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Controller_Action\\)\\) of method Mage_Adminhtml_Controller_Action\\:\\:preDispatch\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Oauth/controllers/Adminhtml/Oauth/AuthorizeController.php + + - + message: "#^Parameter \\#1 \\$data of method Mage_Oauth_Adminhtml_Oauth_ConsumerController\\:\\:_setFormData\\(\\) expects array, null given\\.$#" + count: 2 + path: ../app/code/core/Mage/Oauth/controllers/Adminhtml/Oauth/ConsumerController.php + + - + message: "#^Call to an undefined method Mage_Core_Model_Abstract\\:\\:authenticate\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Captcha/controllers/Adminhtml/RefreshController.php + path: ../app/code/core/Mage/Oauth/controllers/Customer/TokenController.php - - message: "#^Call to an undefined method Mage_Captcha_Model_Interface\\:\\:getImgSrc\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$messagesStorage of method Mage_Core_Controller_Varien_Action\\:\\:_initLayoutMessages\\(\\) expects array\\|string, Mage_Customer_Model_Session given\\.$#" count: 1 - path: ../app/code/core/Mage/Captcha/controllers/RefreshController.php + path: ../app/code/core/Mage/Oauth/controllers/Customer/TokenController.php - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" + message: "#^Parameter \\#1 \\$modelClass of static method Mage\\:\\:getSingleton\\(\\) expects string, Mage_Customer_Model_Session given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Breadcrumbs.php + path: ../app/code/core/Mage/Oauth/controllers/Customer/TokenController.php - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Navigation.php + path: ../app/code/core/Mage/Oauth/controllers/Customer/TokenController.php - - message: "#^Cannot call method count\\(\\) on string\\.$#" - count: 2 - path: ../app/code/core/Mage/Catalog/Block/Navigation.php + message: "#^Property Mage_Oauth_Customer_TokenController\\:\\:\\$_session \\(Mage_Customer_Model_Session\\) does not accept Mage_Core_Model_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/Oauth/controllers/Customer/TokenController.php - - message: "#^Property Mage_Catalog_Block_Navigation\\:\\:\\$_currentCategoryKey \\(string\\) does not accept int\\.$#" + message: "#^Property Mage_Oauth_Customer_TokenController\\:\\:\\$_sessionName \\(Mage_Customer_Model_Session\\) does not accept default value of type string\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Navigation.php + path: ../app/code/core/Mage/Oauth/controllers/Customer/TokenController.php - - message: "#^Variable \\$htmlChildren in empty\\(\\) always exists and is always falsy\\.$#" + message: "#^Return type \\(void\\) of method Mage_Oauth_InitiateController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Controller_Front_Action\\)\\) of method Mage_Core_Controller_Front_Action\\:\\:preDispatch\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Navigation.php + path: ../app/code/core/Mage/Oauth/controllers/InitiateController.php - - message: "#^Variable \\$productId might not be defined\\.$#" + message: "#^Return type \\(void\\) of method Mage_Oauth_TokenController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Controller_Front_Action\\)\\) of method Mage_Core_Controller_Front_Action\\:\\:preDispatch\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Product.php + path: ../app/code/core/Mage/Oauth/controllers/TokenController.php - - message: "#^Property Mage_Catalog_Block_Product_Abstract\\:\\:\\$_reviewsHelperBlock \\(Mage_Review_Block_Helper\\|null\\) does not accept Mage_Core_Block_Abstract\\|false\\.$#" + message: "#^Negated boolean expression is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Product/Abstract.php + path: ../app/code/core/Mage/Page/Block/Html/Breadcrumbs.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Compare_Item_Collection\\:\\:useProductItem\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Parameter \\#3 \\$after of method Mage_Page_Block_Html_Breadcrumbs\\:\\:addCrumb\\(\\) expects bool, \\(int\\|string\\) given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Product/Compare/List.php + path: ../app/code/core/Mage/Page/Block/Html/Breadcrumbs.php - - message: "#^Method Mage_Catalog_Block_Product_List\\:\\:_getProductCollection\\(\\) should return Mage_Catalog_Model_Resource_Product_Collection but returns Mage_Eav_Model_Entity_Collection_Abstract\\.$#" + message: "#^Parameter \\#2 \\$before of method Mage_Page_Block_Html_Head\\:\\:_sortItems\\(\\) expects string, bool given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Product/List.php + path: ../app/code/core/Mage/Page/Block/Html/Head.php - - message: "#^Property Mage_Catalog_Block_Product_List_Crosssell\\:\\:\\$_itemCollection \\(Mage_Catalog_Model_Resource_Eav_Mysql4_Product_Link_Product_Collection\\) does not accept Mage_Catalog_Model_Resource_Product_Link_Product_Collection\\.$#" + message: "#^Variable \\$finish might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Product/List/Crosssell.php + path: ../app/code/core/Mage/Page/Block/Html/Pager.php - - message: "#^Method Mage_Catalog_Block_Product_List_Toolbar\\:\\:getDefaultPerPageValue\\(\\) should return string but returns int\\.$#" + message: "#^Variable \\$start might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Product/List/Toolbar.php + path: ../app/code/core/Mage/Page/Block/Html/Pager.php - - message: "#^Property Mage_Catalog_Block_Product_List_Toolbar\\:\\:\\$_availableMode \\(string\\) does not accept array\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Product/List/Toolbar.php + path: ../app/code/core/Mage/Page/Block/Html/Topmenu/Renderer.php - - message: "#^Property Mage_Catalog_Block_Product_List_Toolbar\\:\\:\\$_availableMode \\(string\\) does not accept array\\\\.$#" - count: 4 - path: ../app/code/core/Mage/Catalog/Block/Product/List/Toolbar.php + message: "#^Method Mage_PageCache_Helper_Data\\:\\:getCacheControlInstance\\(\\) should return Mage_PageCache_Model_Control_Interface but returns Mage_Core_Model_Abstract\\.$#" + count: 1 + path: ../app/code/core/Mage/PageCache/Helper/Data.php - - message: "#^Property Mage_Catalog_Block_Product_List_Toolbar\\:\\:\\$_availableMode \\(string\\) does not accept default value of type array\\.$#" + message: "#^Parameter \\#2 \\$value of method Mage_Core_Model_Cookie\\:\\:set\\(\\) expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Product/List/Toolbar.php + path: ../app/code/core/Mage/PageCache/Helper/Data.php - - message: "#^Property Mage_Catalog_Block_Product_List_Toolbar\\:\\:\\$_collection \\(Mage_Core_Model_Resource_Db_Collection_Abstract\\) does not accept Varien_Data_Collection\\.$#" + message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:isPartialAuthorization\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Product/List/Toolbar.php + path: ../app/code/core/Mage/Paygate/Block/Authorizenet/Form/Cc.php - - message: "#^Property Mage_Catalog_Block_Product_New\\:\\:\\$_productsCount \\(null\\) does not accept int\\.$#" + message: "#^Parameter \\#2 \\$block of method Mage_Core_Block_Abstract\\:\\:setChild\\(\\) expects Mage_Core_Block_Abstract, string given\\.$#" count: 2 - path: ../app/code/core/Mage/Catalog/Block/Product/New.php + path: ../app/code/core/Mage/Paygate/Block/Authorizenet/Form/Cc.php - - message: "#^Method Mage_Catalog_Block_Product_View_Options_Type_Date\\:\\:_getValueWithLeadingZeros\\(\\) should return string but returns int\\.$#" + message: "#^Property Mage_Payment_Block_Info\\:\\:\\$_paymentSpecificInformation \\(Varien_Object\\) does not accept null\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Product/View/Options/Type/Date.php + path: ../app/code/core/Mage/Paygate/Block/Authorizenet/Info/Cc.php - - message: "#^Invalid array key type array\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Paygate_Model_Authorizenet_Cards will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Product/View/Type/Configurable.php + path: ../app/code/core/Mage/Paygate/Model/Authorizenet.php - - message: "#^Method Mage_Catalog_Block_Product_View_Type_Configurable\\:\\:_getHelper\\(\\) should return Mage_Catalog_Helper_Product_Type_Composite but returns Mage_Core_Helper_Abstract\\.$#" + message: "#^Cannot assign new offset to string\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Product/View/Type/Configurable.php + path: ../app/code/core/Mage/Paygate/Model/Authorizenet.php - - message: "#^Property Mage_Catalog_Block_Product_Widget_Html_Pager\\:\\:\\$_lastPage \\(int\\) does not accept float\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Product/Widget/Html/Pager.php + path: ../app/code/core/Mage/Paygate/Model/Authorizenet.php - - message: "#^Variable \\$finish might not be defined\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Block/Product/Widget/Html/Pager.php + message: "#^Parameter \\#1 \\$payment of method Mage_Paygate_Model_Authorizenet\\:\\:_addTransaction\\(\\) expects Mage_Sales_Model_Order_Payment, Mage_Payment_Model_Info given\\.$#" + count: 7 + path: ../app/code/core/Mage/Paygate/Model/Authorizenet.php - - message: "#^Variable \\$start might not be defined\\.$#" + message: "#^Parameter \\#1 \\$payment of method Mage_Paygate_Model_Authorizenet\\:\\:_processFailureMultitransactionAction\\(\\) expects Mage_Payment_Model_Info, Varien_Object given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Product/Widget/Html/Pager.php + path: ../app/code/core/Mage/Paygate/Model/Authorizenet.php - - message: "#^Property Mage_Catalog_Block_Product_Widget_New\\:\\:\\$_pager \\(Mage_Catalog_Block_Product_Widget_Html_Pager\\) does not accept Mage_Core_Block_Abstract\\|false\\.$#" + message: "#^Parameter \\#1 \\$payment of method Mage_Paygate_Model_Authorizenet\\:\\:_refundCardTransaction\\(\\) expects Mage_Payment_Model_Info, Varien_Object given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Product/Widget/New.php + path: ../app/code/core/Mage/Paygate/Model/Authorizenet.php - - message: "#^Parameter \\#1 \\$category \\(Mage_Catalog_Model_Category\\) of method Mage_Catalog_Block_Seo_Sitemap_Category\\:\\:getItemUrl\\(\\) should be compatible with parameter \\$item \\(Mage_Catalog_Block_Seo_Sitemap_Abstract\\) of method Mage_Catalog_Block_Seo_Sitemap_Abstract\\:\\:getItemUrl\\(\\)$#" + message: "#^Parameter \\#1 \\$payment of method Mage_Paygate_Model_Authorizenet\\:\\:getCardsStorage\\(\\) expects Mage_Payment_Model_Info\\|null, Varien_Object given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Block/Seo/Sitemap/Category.php + path: ../app/code/core/Mage/Paygate/Model/Authorizenet.php - - message: "#^Parameter \\#1 \\$product \\(Mage_Catalog_Model_Product\\) of method Mage_Catalog_Block_Seo_Sitemap_Product\\:\\:getItemUrl\\(\\) should be compatible with parameter \\$item \\(Mage_Catalog_Block_Seo_Sitemap_Abstract\\) of method Mage_Catalog_Block_Seo_Sitemap_Abstract\\:\\:getItemUrl\\(\\)$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Block/Seo/Sitemap/Product.php + message: "#^Parameter \\#1 \\$response of method Mage_Paygate_Model_Authorizenet\\:\\:_registerCard\\(\\) expects Mage_Paygate_Model_Authorizenet_Result, Varien_Object given\\.$#" + count: 2 + path: ../app/code/core/Mage/Paygate/Model/Authorizenet.php - - message: "#^Variable \\$finish might not be defined\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Block/Seo/Sitemap/Tree/Pager.php + message: "#^Parameter \\#2 \\$messages of method Mage_Paygate_Model_Authorizenet\\:\\:_processFailureMultitransactionAction\\(\\) expects string, array\\ given\\.$#" + count: 3 + path: ../app/code/core/Mage/Paygate/Model/Authorizenet.php - - message: "#^Variable \\$start might not be defined\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Block/Seo/Sitemap/Tree/Pager.php + message: "#^Parameter \\#2 \\$orderPayment of method Mage_Paygate_Model_Authorizenet\\:\\:_processPartialAuthorizationResponse\\(\\) expects Mage_Sales_Model_Order_Payment, Mage_Payment_Model_Info given\\.$#" + count: 2 + path: ../app/code/core/Mage/Paygate/Model/Authorizenet.php - - message: "#^Variable \\$store might not be defined\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Block/Widget/Link.php + message: "#^Parameter \\#2 \\$payment of method Mage_Paygate_Model_Authorizenet\\:\\:_registerCard\\(\\) expects Mage_Sales_Model_Order_Payment, Mage_Payment_Model_Info given\\.$#" + count: 2 + path: ../app/code/core/Mage/Paygate/Model/Authorizenet.php - - message: "#^Property Mage_Catalog_Helper_Data\\:\\:\\$_categoryPath \\(string\\) does not accept array\\\\>\\.$#" + message: "#^Parameter \\#3 \\$lastTransactionId of method Mage_Paygate_Helper_Data\\:\\:getExtendedTransactionMessage\\(\\) expects string, null given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Helper/Data.php + path: ../app/code/core/Mage/Paygate/Model/Authorizenet.php - - message: "#^Property Mage_Catalog_Helper_Image\\:\\:\\$_angle \\(int\\) does not accept null\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Helper/Image.php + path: ../app/code/core/Mage/Paygate/Model/Authorizenet.php - - message: "#^Property Mage_Catalog_Helper_Image\\:\\:\\$_imageFile \\(string\\) does not accept null\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Helper/Image.php + message: "#^Variable \\$defaultExceptionMessage might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Paygate/Model/Authorizenet.php - - message: "#^Property Mage_Catalog_Helper_Image\\:\\:\\$_model \\(Mage_Catalog_Model_Product_Image\\) does not accept null\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Helper/Image.php + message: "#^Variable \\$newTransactionType might not be defined\\.$#" + count: 3 + path: ../app/code/core/Mage/Paygate/Model/Authorizenet.php - - message: "#^Property Mage_Catalog_Helper_Image\\:\\:\\$_product \\(Mage_Catalog_Model_Product\\) does not accept null\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Helper/Image.php + path: ../app/code/core/Mage/Paygate/Model/Authorizenet/Cards.php - - message: "#^Property Mage_Catalog_Helper_Image\\:\\:\\$_watermark \\(string\\) does not accept null\\.$#" + message: "#^Parameter \\#1 \\$as_float of function microtime expects bool, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Helper/Image.php + path: ../app/code/core/Mage/Paygate/Model/Authorizenet/Cards.php - - message: "#^Property Mage_Catalog_Helper_Image\\:\\:\\$_watermarkImageOpacity \\(int\\) does not accept null\\.$#" + message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:cancelPartialAuthorization\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Helper/Image.php + path: ../app/code/core/Mage/Paygate/controllers/Adminhtml/Paygate/Authorizenet/PaymentController.php - - message: "#^Property Mage_Catalog_Helper_Image\\:\\:\\$_watermarkPosition \\(string\\) does not accept null\\.$#" + message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:cancelPartialAuthorization\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Helper/Image.php + path: ../app/code/core/Mage/Paygate/controllers/Authorizenet/PaymentController.php - - message: "#^Property Mage_Catalog_Helper_Image\\:\\:\\$_watermarkSize \\(string\\) does not accept null\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Helper/Image.php + path: ../app/code/core/Mage/Payment/Block/Catalog/Product/View/Profile.php - - message: "#^Property Mage_Catalog_Helper_Output\\:\\:\\$_templateProcessor \\(Varien_Filter_Template\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Property Mage_Core_Block_Template\\:\\:\\$_template \\(string\\) does not accept null\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Helper/Output.php + path: ../app/code/core/Mage/Payment/Block/Catalog/Product/View/Profile.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute_Frontend_Abstract\\:\\:getUrl\\(\\)\\.$#" - count: 3 - path: ../app/code/core/Mage/Catalog/Helper/Product.php + message: "#^Property Mage_Payment_Block_Catalog_Product_View_Profile\\:\\:\\$_profile \\(Mage_Payment_Model_Recurring_Profile\\) does not accept default value of type false\\.$#" + count: 1 + path: ../app/code/core/Mage/Payment/Block/Catalog/Product/View/Profile.php - - message: "#^Property Mage_Catalog_Helper_Product_Compare\\:\\:\\$_itemCollection \\(Mage_Catalog_Model_Resource_Eav_Mysql4_Product_Compare_Item_Collection\\) does not accept Mage_Catalog_Model_Resource_Product_Compare_Item_Collection\\.$#" + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Helper/Product/Compare.php + path: ../app/code/core/Mage/Payment/Block/Form/Banktransfer.php - - message: "#^Call to an undefined method Mage_Core_Model_Abstract\\:\\:loadSelf\\(\\)\\.$#" + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Helper/Product/Flat.php + path: ../app/code/core/Mage/Payment/Block/Form/Cashondelivery.php - - message: "#^Argument of an invalid type float supplied for foreach, only iterables are supported\\.$#" + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Payment/Block/Form/Cc.php + + - + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Helper/Product/Type/Composite.php + path: ../app/code/core/Mage/Payment/Block/Form/Cc.php - - message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:setStoreId\\(\\)\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Abstract.php + path: ../app/code/core/Mage/Payment/Block/Form/Cc.php - - message: "#^Method Mage_Core_Model_Website\\:\\:getStoreIds\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Payment/Block/Info.php + + - + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Abstract.php + path: ../app/code/core/Mage/Payment/Block/Info/Banktransfer.php - - message: "#^Return type \\(Mage_Catalog_Model_Resource_Collection_Abstract\\) of method Mage_Catalog_Model_Abstract\\:\\:getResourceCollection\\(\\) should be compatible with return type \\(Mage_Core_Model_Resource_Db_Collection_Abstract\\) of method Mage_Core_Model_Abstract\\:\\:getResourceCollection\\(\\)$#" + message: "#^Parameter \\#1 \\$message of method Exception\\:\\:__construct\\(\\) expects string, null given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Abstract.php + path: ../app/code/core/Mage/Payment/Exception.php - - message: "#^Call to an undefined method Mage_Catalog_Model_Api_Resource\\:\\:_checkAttributeAcl\\(\\)\\.$#" + message: "#^Call to an undefined method Mage_Core_Model_Abstract\\:\\:isAvailable\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Api/Resource.php + path: ../app/code/core/Mage/Payment/Helper/Data.php - - message: "#^Variable \\$storeId might not be defined\\.$#" + message: "#^If condition is always true\\.$#" count: 2 - path: ../app/code/core/Mage/Catalog/Model/Api/Resource.php + path: ../app/code/core/Mage/Payment/Helper/Data.php - - message: "#^Argument of an invalid type float supplied for foreach, only iterables are supported\\.$#" + message: "#^Method Mage_Payment_Helper_Data\\:\\:getStoreMethods\\(\\) should return array\\ but returns array\\\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php + path: ../app/code/core/Mage/Payment/Helper/Data.php - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Rest/Admin/V1.php + message: "#^Call to function is_null\\(\\) with Mage_Payment_Model_Method_Abstract will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Payment/Model/Billing/AgreementAbstract.php - - message: "#^Return type \\(int\\) of method Mage_Catalog_Model_Api2_Product_Rest_Customer_V1\\:\\:_getCustomerGroupId\\(\\) should be compatible with return type \\(null\\) of method Mage_Catalog_Model_Api2_Product_Rest\\:\\:_getCustomerGroupId\\(\\)$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Rest/Customer/V1.php + path: ../app/code/core/Mage/Payment/Model/Billing/AgreementAbstract.php - - message: "#^Return type \\(int\\) of method Mage_Catalog_Model_Api2_Product_Rest_Guest_V1\\:\\:_getCustomerGroupId\\(\\) should be compatible with return type \\(null\\) of method Mage_Catalog_Model_Api2_Product_Rest\\:\\:_getCustomerGroupId\\(\\)$#" + message: "#^Method Mage_Payment_Model_Config\\:\\:_getMethod\\(\\) should return Mage_Payment_Model_Method_Abstract\\|false but returns Mage_Core_Model_Abstract\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Rest/Guest/V1.php + path: ../app/code/core/Mage/Payment/Model/Config.php - - message: "#^Call to an undefined method Mage_Core_Model_Abstract\\:\\:toOptionArray\\(\\)\\.$#" + message: "#^Comparison operation \"\\<\" between \\(array\\|float\\|int\\) and 0\\.0001 results in an error\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Validator/Product.php + path: ../app/code/core/Mage/Payment/Model/Method/Abstract.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\:\\:formatDate\\(\\)\\.$#" + message: "#^Parameter \\#2 \\$arguments of static method Mage\\:\\:getModel\\(\\) expects array\\|object, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Api2/Product/Validator/Product.php + path: ../app/code/core/Mage/Payment/Model/Method/Abstract.php - - message: "#^Call to an undefined method Varien_Object\\:\\:formatUrlKey\\(\\)\\.$#" + message: "#^Binary operation \"\\*\\=\" between string and 2 results in an error\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Attribute/Backend/Urlkey/Abstract.php + path: ../app/code/core/Mage/Payment/Model/Method/Cc.php - - message: "#^Method Mage_Catalog_Model_Category\\:\\:getDefaultAttributeSetId\\(\\) should return int but returns string\\|null\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Category.php + path: ../app/code/core/Mage/Payment/Model/Method/Cc.php - - message: "#^Method Mage_Catalog_Model_Category\\:\\:getParentDesignCategory\\(\\) should return \\$this\\(Mage_Catalog_Model_Category\\) but returns Mage_Catalog_Model_Category\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Model/Category.php + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Payment/Model/Recurring/Profile.php - - message: "#^Cannot call method getRootCategoryId\\(\\) on int\\|string\\.$#" + message: "#^Method Mage_Payment_Model_Recurring_Profile\\:\\:exportStartDatetime\\(\\) should return string\\|Zend_Date but empty return statement found\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Category/Api.php + path: ../app/code/core/Mage/Payment/Model/Recurring/Profile.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Model/Category/Attribute/Api.php + message: "#^Negated boolean expression is always false\\.$#" + count: 6 + path: ../app/code/core/Mage/Payment/Model/Recurring/Profile.php - - message: "#^Cannot access offset 'file' on bool\\|void\\.$#" + message: "#^Parameter \\#1 \\$message of static method Mage\\:\\:throwException\\(\\) expects string, array given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Category/Attribute/Backend/Image.php + path: ../app/code/core/Mage/Payment/Model/Recurring/Profile.php - - message: "#^Property Mage_Catalog_Model_Category_Url\\:\\:\\$_url \\(Mage_Core_Model_Url\\) does not accept bool\\|Mage_Core_Model_Abstract\\.$#" + message: "#^Result of \\|\\| is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Category/Url.php + path: ../app/code/core/Mage/Payment/Model/Recurring/Profile.php - - message: "#^Call to an undefined method Mage_Catalog_Model_Config\\:\\:_init\\(\\)\\.$#" + message: "#^Property Mage_Paypal_Block_Adminhtml_System_Config_Field_Country\\:\\:\\$_defaultCountry \\(string\\) does not accept null\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Config.php - - - - message: "#^Method Mage_Catalog_Model_Config\\:\\:getAttributeSetId\\(\\) invoked with 1 parameter, 2 required\\.$#" - count: 2 - path: ../app/code/core/Mage/Catalog/Model/Config.php + path: ../app/code/core/Mage/Paypal/Block/Adminhtml/System/Config/Field/Country.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getStoreId\\(\\)\\.$#" + message: "#^Parameter \\#2 \\$value of method Mage_Core_Model_Config\\:\\:saveConfig\\(\\) expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Convert/Adapter/Product.php + path: ../app/code/core/Mage/Paypal/Block/Adminhtml/System/Config/Fieldset/Deprecated.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Collection\\:\\:setStoreId\\(\\)\\.$#" + message: "#^Method Mage_Paypal_Block_Adminhtml_System_Config_Fieldset_Group\\:\\:_getCollapseState\\(\\) should return bool but returns int\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Convert/Adapter/Product.php + path: ../app/code/core/Mage/Paypal/Block/Adminhtml/System/Config/Fieldset/Group.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Method Mage_Paypal_Block_Express_Review\\:\\:_formatPrice\\(\\) should return string but returns float\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Convert/Adapter/Product.php + path: ../app/code/core/Mage/Paypal/Block/Express/Review.php - - message: "#^Property Mage_Catalog_Model_Convert_Adapter_Product\\:\\:\\$_galleryBackendModel \\(Mage_Catalog_Model_Product_Attribute_Backend_Media\\) does not accept Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\.$#" + message: "#^Method Mage_Paypal_Block_Express_Review\\:\\:_getShippingPrice\\(\\) should return bool but returns float\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Convert/Adapter/Product.php + path: ../app/code/core/Mage/Paypal/Block/Express/Review.php - - message: "#^Property Mage_Catalog_Model_Convert_Adapter_Product\\:\\:\\$_productModel \\(Mage_Catalog_Model_Product\\) does not accept string\\.$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Convert/Adapter/Product.php + path: ../app/code/core/Mage/Paypal/Block/Express/Review.php - - message: "#^Return type \\(Mage_Catalog_Model_Resource_Product_Collection\\) of method Mage_Catalog_Model_Convert_Adapter_Product\\:\\:_getCollectionForLoad\\(\\) should be compatible with return type \\(Mage_Eav_Model_Entity_Collection\\) of method Mage_Eav_Model_Convert_Adapter_Entity\\:\\:_getCollectionForLoad\\(\\)$#" + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Quote_Address will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Convert/Adapter/Product.php + path: ../app/code/core/Mage/Paypal/Block/Express/Review/Billing.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:setStore\\(\\)\\.$#" + message: "#^Right side of \\|\\| is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Convert/Parser/Product.php + path: ../app/code/core/Mage/Paypal/Block/Express/Review/Billing.php - - message: "#^Method Mage_Catalog_Model_Category\\:\\:getParentDesignCategory\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Quote_Address will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Design.php + path: ../app/code/core/Mage/Paypal/Block/Express/Review/Shipping.php - - message: "#^Method Mage_Catalog_Model_Design\\:\\:applyCustomDesign\\(\\) should return false\\|null but return statement is missing\\.$#" + message: "#^Right side of \\|\\| is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Design.php + path: ../app/code/core/Mage/Paypal/Block/Express/Review/Shipping.php - - message: "#^Variable \\$_category might not be defined\\.$#" + message: "#^Return type \\(false\\) of method Mage_Paypal_Block_Hosted_Pro_Info\\:\\:getCcTypeName\\(\\) should be compatible with return type \\(string\\|null\\) of method Mage_Paypal_Block_Payment_Info\\:\\:getCcTypeName\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Design.php + path: ../app/code/core/Mage/Paypal/Block/Hosted/Pro/Info.php - - message: "#^Property Mage_Catalog_Model_Entity_Product_Attribute_Design_Options_Container\\:\\:\\$_configNodePath \\(Mage_Core_Model_Config_Element\\) does not accept string\\.$#" + message: "#^Method Mage_Paypal_Block_Iframe\\:\\:_getBlock\\(\\) should return \\$this\\(Mage_Paypal_Block_Iframe\\) but returns Mage_Payment_Block_Form\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Entity/Product/Attribute/Design/Options/Container.php + path: ../app/code/core/Mage/Paypal/Block/Iframe.php - - message: "#^Method Mage_Catalog_Model_Factory\\:\\:getCategoryUrlInstance\\(\\) should return Mage_Catalog_Model_Category_Url but returns bool\\|Mage_Core_Model_Abstract\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Model/Factory.php + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Paypal/Block/Iframe.php - - message: "#^Method Mage_Catalog_Model_Factory\\:\\:getCategoryUrlRewriteHelper\\(\\) should return Mage_Catalog_Helper_Category_Url_Rewrite_Interface but returns Mage_Core_Helper_Abstract\\.$#" + message: "#^Property Mage_Paypal_Block_Iframe\\:\\:\\$_block \\(Mage_Payment_Block_Form\\) does not accept Mage_Core_Block_Abstract\\|false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Factory.php + path: ../app/code/core/Mage/Paypal/Block/Iframe.php - - message: "#^Method Mage_Catalog_Model_Factory\\:\\:getProductUrlInstance\\(\\) should return Mage_Catalog_Model_Product_Url but returns bool\\|Mage_Core_Model_Abstract\\.$#" + message: "#^Return type \\(false\\) of method Mage_Paypal_Block_Payflow_Link_Info\\:\\:getCcTypeName\\(\\) should be compatible with return type \\(string\\|null\\) of method Mage_Paypal_Block_Payment_Info\\:\\:getCcTypeName\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Factory.php + path: ../app/code/core/Mage/Paypal/Block/Payflow/Link/Info.php - - message: "#^Method Mage_Catalog_Model_Factory\\:\\:getProductUrlRewriteHelper\\(\\) should return Mage_Catalog_Helper_Product_Url_Rewrite_Interface but returns Mage_Core_Helper_Abstract\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Factory.php + path: ../app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - message: "#^Comparison operation \"\\=\\=\" between Mage_Catalog_Model_Resource_Eav_Attribute and 1 results in an error\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Attribute.php + message: "#^Left side of && is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - message: "#^Parameter \\#2 \\$filterBlock \\(Varien_Object\\) of method Mage_Catalog_Model_Layer_Filter_Attribute\\:\\:apply\\(\\) should be compatible with parameter \\$filterBlock \\(null\\) of method Mage_Catalog_Model_Layer_Filter_Abstract\\:\\:apply\\(\\)$#" + message: "#^Method Mage_Paypal_Controller_Express_Abstract\\:\\:_initCheckout\\(\\) should return Mage_Paypal_Model_Express_Checkout but returns Mage_Core_Model_Abstract\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Attribute.php + path: ../app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - message: "#^Argument of an invalid type int supplied for foreach, only iterables are supported\\.$#" + message: "#^Method Mage_Paypal_Controller_Express_Abstract\\:\\:_initToken\\(\\) should return Mage_Paypal_ExpressController\\|string but returns \\$this\\(Mage_Paypal_Controller_Express_Abstract\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php + path: ../app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - message: "#^Parameter \\#2 \\$filterBlock \\(Mage_Catalog_Block_Layer_Filter_Decimal\\) of method Mage_Catalog_Model_Layer_Filter_Decimal\\:\\:apply\\(\\) should be compatible with parameter \\$filterBlock \\(null\\) of method Mage_Catalog_Model_Layer_Filter_Abstract\\:\\:apply\\(\\)$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php + path: ../app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - message: "#^Argument of an invalid type int\\\\|int\\<1, max\\> supplied for foreach, only iterables are supported\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Model/Layer/Filter/Price.php + message: "#^Parameter \\#1 \\$setToken of method Mage_Paypal_Controller_Express_Abstract\\:\\:_initToken\\(\\) expects string\\|null, false given\\.$#" + count: 2 + path: ../app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - message: "#^Method Mage_Catalog_Model_Resource_Category_Flat\\:\\:move\\(\\) invoked with 3 parameters, 1 required\\.$#" + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Observer.php + path: ../app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\:\\:addImage\\(\\)\\.$#" + message: "#^Property Mage_Paypal_Controller_Express_Abstract\\:\\:\\$_checkout \\(Mage_Paypal_Model_Express_Checkout\\) does not accept Mage_Core_Model_Abstract\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product.php + path: ../app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - message: "#^Method Mage_Catalog_Model_Product\\:\\:canBeShowInCategory\\(\\) should return bool but returns string\\.$#" + message: "#^Property Mage_Paypal_Controller_Express_Abstract\\:\\:\\$_config \\(Mage_Paypal_Model_Config\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product.php + path: ../app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - message: "#^Method Mage_Catalog_Model_Product\\:\\:duplicate\\(\\) should return \\$this\\(Mage_Catalog_Model_Product\\) but returns Mage_Catalog_Model_Product\\.$#" + message: "#^Property Mage_Paypal_Controller_Express_Abstract\\:\\:\\$_quote \\(Mage_Sales_Model_Quote\\) does not accept default value of type false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product.php + path: ../app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - message: "#^Method Mage_Catalog_Model_Product\\:\\:getDefaultAttributeSetId\\(\\) should return int but returns string\\|null\\.$#" + message: "#^Variable \\$isAjax might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product.php + path: ../app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - message: "#^Property Mage_Catalog_Model_Product\\:\\:\\$_typeInstance \\(Mage_Catalog_Model_Product_Type_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product.php + path: ../app/code/core/Mage/Paypal/Helper/Hss.php - - message: "#^Cannot access property \\$additional_attributes on array\\.$#" - count: 5 - path: ../app/code/core/Mage/Catalog/Model/Product/Api/V2.php + message: "#^Left side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Paypal/Helper/Hss.php - - message: "#^Cannot access property \\$categories on array\\.$#" + message: "#^Method Mage_Paypal_Model_Api_Abstract\\:\\:_exportLineItems\\(\\) should return bool but empty return statement found\\.$#" count: 2 - path: ../app/code/core/Mage/Catalog/Model/Product/Api/V2.php + path: ../app/code/core/Mage/Paypal/Model/Api/Abstract.php - - message: "#^Cannot access property \\$stock_data on array\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Api/V2.php + path: ../app/code/core/Mage/Paypal/Model/Api/Abstract.php - - message: "#^Cannot access property \\$tier_price on array\\.$#" + message: "#^Parameter \\#2 \\$arguments of static method Mage\\:\\:getModel\\(\\) expects array\\|object, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Api/V2.php + path: ../app/code/core/Mage/Paypal/Model/Api/Abstract.php - - message: "#^Cannot access property \\$website_ids on array\\.$#" - count: 2 - path: ../app/code/core/Mage/Catalog/Model/Product/Api/V2.php + message: "#^Call to an undefined method Mage_Paypal_Model_Api_Nvp\\:\\:_export\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Paypal/Model/Api/Nvp.php - - message: "#^Cannot access property \\$websites on array\\.$#" - count: 3 - path: ../app/code/core/Mage/Catalog/Model/Product/Api/V2.php + message: "#^Call to an undefined method Mage_Paypal_Model_Api_Nvp\\:\\:_import\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Paypal/Model/Api/Nvp.php - - message: "#^Parameter \\#3 \\$attributes \\(stdClass\\) of method Mage_Catalog_Model_Product_Api_V2\\:\\:info\\(\\) should be compatible with parameter \\$attributes \\(array\\) of method Mage_Catalog_Model_Product_Api\\:\\:info\\(\\)$#" + message: "#^Method Mage_Paypal_Model_Api_Nvp\\:\\:_exportLineItems\\(\\) should return true\\|null but empty return statement found\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Api/V2.php + path: ../app/code/core/Mage/Paypal/Model/Api/Nvp.php - - message: "#^Cannot call method getBackend\\(\\) on bool\\|Mage_Catalog_Model_Resource_Attribute\\.$#" - count: 11 - path: ../app/code/core/Mage/Catalog/Model/Product/Attribute/Media/Api.php + message: "#^Method Mage_Paypal_Model_Api_Nvp\\:\\:_exportLineItems\\(\\) should return true\\|null but returns bool\\.$#" + count: 1 + path: ../app/code/core/Mage/Paypal/Model/Api/Nvp.php - - message: "#^Variable \\$file might not be defined\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Attribute/Media/Api.php + path: ../app/code/core/Mage/Paypal/Model/Api/Nvp.php - - message: "#^Parameter \\#1 \\$data \\(stdClass\\) of method Mage_Catalog_Model_Product_Attribute_Media_Api_V2\\:\\:_prepareImageData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Catalog_Model_Product_Attribute_Media_Api\\:\\:_prepareImageData\\(\\)$#" + message: "#^Method Mage_Paypal_Model_Api_Standard\\:\\:_exportLineItems\\(\\) should return true\\|null but empty return statement found\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Attribute/Media/Api/V2.php + path: ../app/code/core/Mage/Paypal/Model/Api/Standard.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Compare_Item\\:\\:clean\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Method Mage_Paypal_Model_Api_Standard\\:\\:_exportLineItems\\(\\) should return true\\|null but returns bool\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Compare/Item.php + path: ../app/code/core/Mage/Paypal/Model/Api/Standard.php - - message: "#^Call to an undefined method Mage_Catalog_Model_Resource_Product_Flat_Indexer\\:\\:prepareFlatTables\\(\\)\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Flat/Indexer.php + path: ../app/code/core/Mage/Paypal/Model/Api/Standard.php - - message: "#^Binary operation \"\\*\" between string and 1024 results in an error\\.$#" - count: 3 - path: ../app/code/core/Mage/Catalog/Model/Product/Image.php + message: "#^Call to an undefined method Varien_Object\\:\\:isNominal\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Paypal/Model/Cart.php - - message: "#^Cannot call method isIndexable\\(\\) on Mage_Eav_Model_Entity_Attribute_Abstract\\|false\\.$#" + message: "#^Empty array passed to foreach\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Indexer/Eav.php + path: ../app/code/core/Mage/Paypal/Model/Cart.php - - message: "#^Parameter \\#5 \\$identifierType \\(null\\) of method Mage_Catalog_Model_Product_Link_Api_V2\\:\\:assign\\(\\) should be compatible with parameter \\$identifierType \\(string\\) of method Mage_Catalog_Model_Product_Link_Api\\:\\:assign\\(\\)$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Link/Api/V2.php + path: ../app/code/core/Mage/Paypal/Model/Cart.php - - message: "#^Parameter \\#5 \\$identifierType \\(null\\) of method Mage_Catalog_Model_Product_Link_Api_V2\\:\\:update\\(\\) should be compatible with parameter \\$identifierType \\(string\\) of method Mage_Catalog_Model_Product_Link_Api\\:\\:update\\(\\)$#" + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Link/Api/V2.php + path: ../app/code/core/Mage/Paypal/Model/Config.php - - message: "#^Method Mage_Catalog_Model_Product_Option\\:\\:getValuesCollection\\(\\) should return Mage_Catalog_Model_Resource_Eav_Mysql4_Product_Option_Value_Collection but returns Mage_Catalog_Model_Resource_Product_Option_Value_Collection\\.$#" + message: "#^Negated boolean expression is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Option.php + path: ../app/code/core/Mage/Paypal/Model/Config.php - - message: "#^Method Mage_Catalog_Model_Product_Option\\:\\:groupFactory\\(\\) should return Mage_Catalog_Model_Product_Option_Type_Default but returns Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Property Mage_Paypal_Model_Direct\\:\\:\\$_pro \\(Mage_Paypal_Model_Pro\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Option.php + path: ../app/code/core/Mage/Paypal/Model/Direct.php - - message: "#^Call to an undefined method Mage_Catalog_Model_Product_Configuration_Item_Option_Interface\\:\\:getId\\(\\)\\.$#" + message: "#^Call to an undefined method Mage_Payment_Model_Info\\:\\:lookupTransaction\\(\\)\\.$#" count: 2 - path: ../app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php + path: ../app/code/core/Mage/Paypal/Model/Express.php - - message: "#^Call to an undefined method Mage_Catalog_Model_Product_Configuration_Item_Option_Interface\\:\\:setValue\\(\\)\\.$#" + message: "#^If condition is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php + path: ../app/code/core/Mage/Paypal/Model/Express.php - - message: "#^Variable \\$value in isset\\(\\) always exists and is not nullable\\.$#" + message: "#^Method Mage_Paypal_Model_Express\\:\\:assignData\\(\\) should return Mage_Payment_Model_Info but returns \\$this\\(Mage_Paypal_Model_Express\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php + path: ../app/code/core/Mage/Paypal/Model/Express.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:getStoreId\\(\\)\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Status.php + message: "#^Parameter \\#1 \\$amount of method Mage_Paypal_Model_Express\\:\\:_callDoAuthorize\\(\\) expects int, float given\\.$#" + count: 2 + path: ../app/code/core/Mage/Paypal/Model/Express.php - - message: "#^Method Mage_Catalog_Model_Product_Type\\:\\:priceFactory\\(\\) should return Mage_Catalog_Model_Product_Type_Price but returns Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Parameter \\#1 \\$datetime of class DateTime constructor expects string, null given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Type.php + path: ../app/code/core/Mage/Paypal/Model/Express.php - - message: "#^Method Mage_Catalog_Model_Product_Type_Abstract\\:\\:getAttributeById\\(\\) should return Mage_Eav_Model_Entity_Attribute_Abstract but returns null\\.$#" + message: "#^Parameter \\#1 \\$txnId of method Mage_Sales_Model_Order_Payment\\:\\:lookupTransaction\\(\\) expects string, false given\\.$#" + count: 2 + path: ../app/code/core/Mage/Paypal/Model/Express.php + + - + message: "#^Property Mage_Paypal_Model_Express\\:\\:\\$_pro \\(Mage_Paypal_Model_Pro\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Type/Abstract.php + path: ../app/code/core/Mage/Paypal/Model/Express.php - - message: "#^Method Mage_Catalog_Model_Product_Type_Configurable\\:\\:getProductByAttributes\\(\\) should return Mage_Catalog_Model_Product\\|null but returns Varien_Object\\.$#" + message: "#^Return type \\(Mage_Payment_Model_Info\\) of method Mage_Paypal_Model_Express\\:\\:assignData\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Abstract\\)\\) of method Mage_Payment_Model_Method_Abstract\\:\\:assignData\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Type/Configurable.php + path: ../app/code/core/Mage/Paypal/Model/Express.php - - message: "#^Cannot access offset 'pricing_value' on true\\.$#" + message: "#^Call to function is_null\\(\\) with int\\|string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Type/Configurable/Price.php + path: ../app/code/core/Mage/Paypal/Model/Express/Checkout.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute_Abstract\\:\\:isScopeStore\\(\\)\\.$#" + message: "#^Cannot call method getData\\(\\) on array\\.$#" count: 2 - path: ../app/code/core/Mage/Catalog/Model/Resource/Abstract.php + path: ../app/code/core/Mage/Paypal/Model/Express/Checkout.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute_Abstract\\:\\:isScopeWebsite\\(\\)\\.$#" + message: "#^Cannot call method getExportedKeys\\(\\) on array\\.$#" count: 2 - path: ../app/code/core/Mage/Catalog/Model/Resource/Abstract.php + path: ../app/code/core/Mage/Paypal/Model/Express/Checkout.php - - message: "#^Cannot call method isScopeStore\\(\\) on Mage_Eav_Model_Entity_Attribute_Abstract\\|false\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Abstract.php + path: ../app/code/core/Mage/Paypal/Model/Express/Checkout.php - - message: "#^Cannot call method isScopeWebsite\\(\\) on Mage_Eav_Model_Entity_Attribute_Abstract\\|false\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Abstract.php + path: ../app/code/core/Mage/Paypal/Model/Express/Checkout.php - - message: "#^Method Mage_Core_Model_Website\\:\\:getStoreIds\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Abstract.php + path: ../app/code/core/Mage/Paypal/Model/Express/Checkout.php - - message: "#^Method Mage_Catalog_Model_Resource_Attribute\\:\\:isUsedBySuperProducts\\(\\) should return int but returns string\\.$#" + message: "#^Parameter \\#1 \\$message of static method Mage\\:\\:throwException\\(\\) expects string, array given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Attribute.php + path: ../app/code/core/Mage/Paypal/Model/Express/Checkout.php - - message: "#^Method Mage_Catalog_Model_Resource_Category\\:\\:checkId\\(\\) should return bool but returns string\\.$#" + message: "#^Parameter \\#2 \\$arguments of static method Mage\\:\\:getModel\\(\\) expects array\\|object, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category.php + path: ../app/code/core/Mage/Paypal/Model/Express/Checkout.php - - message: "#^Method Mage_Catalog_Model_Resource_Category\\:\\:getChildrenAmount\\(\\) should return int but returns string\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category.php + message: "#^Parameter \\#3 \\$storeId of method Mage_Customer_Model_Customer\\:\\:sendNewAccountEmail\\(\\) expects string, int given\\.$#" + count: 2 + path: ../app/code/core/Mage/Paypal/Model/Express/Checkout.php - - message: "#^Method Mage_Catalog_Model_Resource_Category\\:\\:getChildrenCount\\(\\) should return int but returns string\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category.php + message: "#^Right side of && is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Paypal/Model/Express/Checkout.php - - message: "#^Property Mage_Catalog_Model_Resource_Category\\:\\:\\$_isActiveAttributeId \\(int\\) does not accept string\\.$#" + message: "#^Variable \\$address might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category.php + path: ../app/code/core/Mage/Paypal/Model/Express/Checkout.php - - message: "#^Property Mage_Catalog_Model_Resource_Category\\:\\:\\$_tree \\(Varien_Data_Tree_Db\\) does not accept Varien_Data_Tree_Dbp\\.$#" + message: "#^Variable \\$shippingAddress might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category.php + path: ../app/code/core/Mage/Paypal/Model/Express/Checkout.php - - message: "#^Variable \\$ids in empty\\(\\) always exists and is not falsy\\.$#" + message: "#^Method Mage_Paypal_Model_Hostedpro\\:\\:initialize\\(\\) should return \\$this\\(Mage_Paypal_Model_Hostedpro\\) but return statement is missing\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Collection.php + path: ../app/code/core/Mage/Paypal/Model/Hostedpro.php - - message: "#^Call to an undefined method Mage_Catalog_Model_Resource_Category_Collection\\:\\:addSortedField\\(\\)\\.$#" + message: "#^Return type \\(bool\\) of method Mage_Paypal_Model_Hostedpro\\:\\:getAllowedCcTypes\\(\\) should be compatible with return type \\(string\\) of method Mage_Paypal_Model_Direct\\:\\:getAllowedCcTypes\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php + path: ../app/code/core/Mage/Paypal/Model/Hostedpro.php - - message: "#^Method Mage_Catalog_Model_Resource_Category_Flat\\:\\:checkId\\(\\) should return bool but returns string\\.$#" + message: "#^Return type \\(bool\\) of method Mage_Paypal_Model_Hostedpro\\:\\:validate\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Cc\\)\\) of method Mage_Payment_Model_Method_Cc\\:\\:validate\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php + path: ../app/code/core/Mage/Paypal/Model/Hostedpro.php - - message: "#^Variable \\$options might not be defined\\.$#" + message: "#^Binary operation \"\\-\" between array\\|string and array\\|string results in an error\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php + path: ../app/code/core/Mage/Paypal/Model/Ipn.php - - message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Abstract\\:\\:getMainStoreTable\\(\\)\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Flat/Collection.php + path: ../app/code/core/Mage/Paypal/Model/Ipn.php - - message: "#^Variable \\$condition might not be defined\\.$#" + message: "#^Parameter \\#1 \\$amount of method Mage_Sales_Model_Order_Payment\\:\\:registerCaptureNotification\\(\\) expects float, array\\|string given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Flat/Collection.php + path: ../app/code/core/Mage/Paypal/Model/Ipn.php - - message: "#^Variable \\$ids in empty\\(\\) always exists and is not falsy\\.$#" + message: "#^Parameter \\#2 \\$arguments of static method Mage\\:\\:getModel\\(\\) expects array\\|object, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Flat/Collection.php + path: ../app/code/core/Mage/Paypal/Model/Ipn.php - - message: "#^Call to an undefined method Zend_Db_Select\\:\\:insertFromSelect\\(\\)\\.$#" + message: "#^Parameter \\#2 \\$url of method Zend_Http_Client_Adapter_Interface\\:\\:write\\(\\) expects Zend_Uri_Http, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php + path: ../app/code/core/Mage/Paypal/Model/Ipn.php - - message: "#^Variable \\$anchorProductsTable might not be defined\\.$#" + message: "#^Property Mage_Paypal_Model_Ipn\\:\\:\\$_order \\(Mage_Sales_Model_Order\\) does not accept null\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php + path: ../app/code/core/Mage/Paypal/Model/Ipn.php - - message: "#^Variable \\$anchorTable might not be defined\\.$#" + message: "#^Property Mage_Paypal_Model_Ipn\\:\\:\\$_order \\(Mage_Sales_Model_Order\\) in empty\\(\\) is not falsy\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php + path: ../app/code/core/Mage/Paypal/Model/Ipn.php - - message: "#^Variable \\$enabledTable might not be defined\\.$#" + message: "#^Property Mage_Paypal_Model_Ipn\\:\\:\\$_recurringProfile \\(Mage_Sales_Model_Recurring_Profile\\) does not accept null\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php - - - - message: "#^Call to an undefined method Zend_Db_Adapter_Abstract\\:\\:getCheckSql\\(\\)\\.$#" - count: 2 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + path: ../app/code/core/Mage/Paypal/Model/Ipn.php - - message: "#^Call to an undefined method Zend_Db_Adapter_Abstract\\:\\:getConcatSql\\(\\)\\.$#" + message: "#^Property Mage_Paypal_Model_Ipn\\:\\:\\$_recurringProfile \\(Mage_Sales_Model_Recurring_Profile\\) in empty\\(\\) is not falsy\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + path: ../app/code/core/Mage/Paypal/Model/Ipn.php - - message: "#^Call to an undefined method Zend_Db_Adapter_Abstract\\:\\:getLengthSql\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$payment of method Mage_Paypal_Model_Method_Agreement\\:\\:_placeOrder\\(\\) expects Mage_Sales_Model_Order_Payment, Varien_Object given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + path: ../app/code/core/Mage/Paypal/Model/Method/Agreement.php - - message: "#^Method Mage_Catalog_Model_Resource_Category_Tree\\:\\:_getItemIsActive\\(\\) invoked with 2 parameters, 1 required\\.$#" + message: "#^Parameter \\#1 \\$spec of method Zend_Controller_Response_Abstract\\:\\:getBody\\(\\) expects bool, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + path: ../app/code/core/Mage/Paypal/Model/Observer.php - - message: "#^Parameter \\#1 \\$category \\(Mage_Catalog_Model_Category\\) of method Mage_Catalog_Model_Resource_Category_Tree\\:\\:move\\(\\) should be compatible with parameter \\$node \\(Varien_Data_Tree_Node\\) of method Varien_Data_Tree_Dbp\\:\\:move\\(\\)$#" + message: "#^Parameter \\#2 \\$return of function print_r expects bool, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + path: ../app/code/core/Mage/Paypal/Model/Payflow/Request.php - - message: "#^Property Mage_Catalog_Model_Resource_Category_Tree\\:\\:\\$_isActiveAttributeId \\(int\\) does not accept string\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php + path: ../app/code/core/Mage/Paypal/Model/Payflowlink.php - - message: "#^Binary operation \"\\-\" between int and non\\-falsy\\-string results in an error\\.$#" - count: 2 - path: ../app/code/core/Mage/Catalog/Model/Resource/Layer/Filter/Price.php + message: "#^Parameter \\#1 \\$payment of method Mage_Paypal_Model_Payflowlink\\:\\:_buildTokenRequest\\(\\) expects Mage_Sales_Model_Order_Payment, Mage_Payment_Model_Info given\\.$#" + count: 1 + path: ../app/code/core/Mage/Paypal/Model/Payflowlink.php - - message: "#^Binary operation \"\\-\" between non\\-falsy\\-string and 1 results in an error\\.$#" - count: 2 - path: ../app/code/core/Mage/Catalog/Model/Resource/Layer/Filter/Price.php + message: "#^Parameter \\#1 \\$payment of method Mage_Paypal_Model_Payflowlink\\:\\:_generateSecureSilentPostHash\\(\\) expects Mage_Sales_Model_Order_Payment, Mage_Payment_Model_Info given\\.$#" + count: 1 + path: ../app/code/core/Mage/Paypal/Model/Payflowlink.php - - message: "#^Call to an undefined method Mage_Catalog_Model_Resource_Category\\:\\:refreshProductIndex\\(\\)\\.$#" + message: "#^Parameter \\#2 \\$array of function implode expects array\\|null, string given\\.$#" count: 2 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product.php + path: ../app/code/core/Mage/Paypal/Model/Payflowlink.php - - message: "#^Method Mage_Catalog_Model_Resource_Product\\:\\:getIdBySku\\(\\) should return int\\|false but returns string\\.$#" + message: "#^Parameter \\#2 \\$payment of method Mage_Paypal_Model_Payflowlink\\:\\:_processTokenErrors\\(\\) expects Mage_Sales_Model_Order_Payment, Mage_Payment_Model_Info given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product.php + path: ../app/code/core/Mage/Paypal/Model/Payflowlink.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Attribute_Backend_Media\\:\\:insertGallery\\(\\) should return int but returns string\\.$#" + message: "#^Return type \\(bool\\) of method Mage_Paypal_Model_Payflowlink\\:\\:validate\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Cc\\)\\) of method Mage_Payment_Model_Method_Cc\\:\\:validate\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Attribute/Backend/Media.php + path: ../app/code/core/Mage/Paypal/Model/Payflowlink.php - - message: "#^Call to an undefined method Varien_Object\\:\\:formatUrlKey\\(\\)\\.$#" + message: "#^Variable \\$order in empty\\(\\) always exists and is not falsy\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Attribute/Backend/Urlkey.php + path: ../app/code/core/Mage/Paypal/Model/Payflowlink.php - - message: "#^Method Mage_Catalog_Model_Url\\:\\:refreshProductRewrites\\(\\) invoked with 3 parameters, 1 required\\.$#" + message: "#^Parameter \\#1 \\$payment of method Mage_Paypal_Model_Payflowpro\\:\\:_buildBasicRequest\\(\\) expects Mage_Sales_Model_Order_Payment, Mage_Payment_Model_Info given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Attribute/Backend/Urlkey.php + path: ../app/code/core/Mage/Paypal/Model/Payflowpro.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getAllTableColumns\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$payment of method Mage_Paypal_Model_Payflowpro\\:\\:void\\(\\) expects Mage_Sales_Model_Order_Payment, Varien_Object given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + path: ../app/code/core/Mage/Paypal/Model/Payflowpro.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getAttributeForSelect\\(\\)\\.$#" + message: "#^Parameter \\#2 \\$array of function implode expects array\\|null, string given\\.$#" + count: 2 + path: ../app/code/core/Mage/Paypal/Model/Payflowpro.php + + - + message: "#^Parameter \\#2 \\$storeId of method Mage_Payment_Model_Method_Abstract\\:\\:getConfigData\\(\\) expects int\\|Mage_Core_Model_Store\\|string\\|null, false given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + path: ../app/code/core/Mage/Paypal/Model/Payflowpro.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getAttributeSortColumn\\(\\)\\.$#" + message: "#^Parameter \\#3 \\$map of static method Varien_Object_Mapper\\:\\:accumulateByMap\\(\\) expects array, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + path: ../app/code/core/Mage/Paypal/Model/Payflowpro.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getFlatTableName\\(\\)\\.$#" + message: "#^Property Mage_Paypal_Model_Payflowpro\\:\\:\\$_centinelFieldMap \\(string\\) does not accept default value of type array\\\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + path: ../app/code/core/Mage/Paypal/Model/Payflowpro.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:setStoreId\\(\\)\\.$#" + message: "#^Variable \\$order in empty\\(\\) always exists and is not falsy\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + path: ../app/code/core/Mage/Paypal/Model/Payflowpro.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Collection\\:\\:_addUrlRewrite\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Method Mage_Paypal_Model_Pro\\:\\:capture\\(\\) should return false\\|null but return statement is missing\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + path: ../app/code/core/Mage/Paypal/Model/Pro.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Collection\\:\\:getProductCountSelect\\(\\) should return Varien_Db_Select but returns Zend_Db_Select\\.$#" + message: "#^Parameter \\#2 \\$payment of method Mage_Paypal_Model_Pro\\:\\:_importCaptureResultToPayment\\(\\) expects Mage_Sales_Model_Order_Payment, Varien_Object given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + path: ../app/code/core/Mage/Paypal/Model/Pro.php - - message: "#^Property Mage_Catalog_Model_Resource_Product_Collection\\:\\:\\$_allIdsCache \\(array\\) does not accept null\\.$#" + message: "#^Parameter \\#2 \\$payment of method Mage_Paypal_Model_Pro\\:\\:_importRefundResultToPayment\\(\\) expects Mage_Sales_Model_Order_Payment, Varien_Object given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + path: ../app/code/core/Mage/Paypal/Model/Pro.php - - message: "#^Property Mage_Catalog_Model_Resource_Product_Collection\\:\\:\\$_productCountSelect \\(Zend_Db_Select\\) does not accept null\\.$#" + message: "#^Parameter \\#2 \\$to of method Mage_Paypal_Model_Pro\\:\\:importPaymentInfo\\(\\) expects Mage_Payment_Model_Info, Varien_Object given\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + path: ../app/code/core/Mage/Paypal/Model/Pro.php - - message: "#^Property Mage_Catalog_Model_Resource_Product_Collection\\:\\:\\$_urlRewriteCategory \\(int\\) does not accept default value of type string\\.$#" + message: "#^Property Mage_Paypal_Model_Pro\\:\\:\\$_api \\(Mage_Paypal_Model_Api_Nvp\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + path: ../app/code/core/Mage/Paypal/Model/Pro.php - - message: "#^Variable \\$websiteId might not be defined\\.$#" - count: 3 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + message: "#^Property Mage_Paypal_Model_Pro\\:\\:\\$_api \\(Mage_Paypal_Model_Api_Nvp\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Paypal/Model/Pro.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Compare_Item\\:\\:getCount\\(\\) should return int but returns string\\.$#" + message: "#^Property Mage_Paypal_Model_Pro\\:\\:\\$_config \\(Mage_Paypal_Model_Config\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Compare/Item.php + path: ../app/code/core/Mage/Paypal/Model/Pro.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Flat\\:\\:getTypeId\\(\\) should return int but returns string\\|null\\.$#" + message: "#^Method Mage_Paypal_Model_Standard\\:\\:initialize\\(\\) should return \\$this\\(Mage_Paypal_Model_Standard\\) but return statement is missing\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Flat.php + path: ../app/code/core/Mage/Paypal/Model/Standard.php - - message: "#^Comparison operation \"\\>\" between int\\<0, max\\> and Varien_Simplexml_Element\\|false results in an error\\.$#" + message: "#^Method Varien_Data_Collection\\:\\:toOptionArray\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Flat/Indexer.php + path: ../app/code/core/Mage/Paypal/Model/System/Config/Source/BuyerCountry.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Indexer_Abstract\\:\\:_getAttribute\\(\\) should return Mage_Catalog_Model_Resource_Eav_Attribute but returns Mage_Eav_Model_Entity_Attribute_Abstract\\|false\\.$#" + message: "#^Method Varien_Data_Collection\\:\\:toOptionArray\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Abstract.php + path: ../app/code/core/Mage/Paypal/Model/System/Config/Source/MerchantCountry.php - - message: "#^Binary operation \"\\*\" between string and 0\\.3 results in an error\\.$#" + message: "#^Method Mage_Paypal_HostedproController\\:\\:_getIframeBlock\\(\\) should return Mage_Paypal_Block_Hosted_Pro_Iframe but returns Mage_Core_Block_Abstract\\|false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php + path: ../app/code/core/Mage/Paypal/controllers/HostedproController.php - - message: "#^Binary operation \"\\+\" between int\\<0, max\\> and string results in an error\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php + path: ../app/code/core/Mage/Paypal/controllers/PayflowController.php - - message: "#^Call to an undefined method Mage_Catalog_Model_Resource_Product_Indexer_Price_Interface\\:\\:getIsComposite\\(\\)\\.$#" - count: 2 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php + message: "#^Method Mage_Paypal_PayflowController\\:\\:_getIframeBlock\\(\\) should return Mage_Paypal_Block_Payflow_Link_Iframe but returns Mage_Core_Block_Abstract\\|false\\.$#" + count: 1 + path: ../app/code/core/Mage/Paypal/controllers/PayflowController.php - - message: "#^Cannot call method setTypeId\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php + path: ../app/code/core/Mage/Paypal/controllers/PayflowadvancedController.php - - message: "#^Variable \\$category might not be defined\\.$#" + message: "#^Method Mage_Paypal_PayflowadvancedController\\:\\:_getIframeBlock\\(\\) should return Mage_Paypal_Block_Payflow_Advanced_Iframe but returns Mage_Core_Block_Abstract\\|false\\.$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Url.php + path: ../app/code/core/Mage/Paypal/controllers/PayflowadvancedController.php - - message: "#^Variable \\$rootCategoryPath might not be defined\\.$#" + message: "#^Return type \\(void\\) of method Mage_PaypalUk_Model_Pro\\:\\:fetchTransactionInfo\\(\\) should be compatible with return type \\(array\\) of method Mage_Paypal_Model_Pro\\:\\:fetchTransactionInfo\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Url.php + path: ../app/code/core/Mage/PaypalUk/Model/Pro.php - - message: "#^Variable \\$rootCategoryPathLength might not be defined\\.$#" + message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'delete' given\\.$#" count: 2 - path: ../app/code/core/Mage/Catalog/Model/Resource/Url.php + path: ../app/code/core/Mage/Persistent/Model/Observer.php - - message: "#^Property Mage_Catalog_Model_Url\\:\\:\\$_rewrite \\(Varien_Object\\) does not accept null\\.$#" - count: 2 - path: ../app/code/core/Mage/Catalog/Model/Url.php + message: "#^Variable \\$key might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Poll/Block/ActivePoll.php - - message: "#^Call to an undefined method Mage_CatalogIndex_Model_Resource_Attribute\\:\\:checkCount\\(\\)\\.$#" + message: "#^Variable \\$value might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogIndex/Model/Attribute.php + path: ../app/code/core/Mage/Poll/Block/ActivePoll.php - - message: "#^Property Mage_CatalogIndex_Model_Data_Abstract\\:\\:\\$_typeInstance \\(Mage_Catalog_Model_Product_Type_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Method Mage_Poll_Model_Poll\\:\\:getPoolId\\(\\) should return int but returns string\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogIndex/Model/Data/Abstract.php + path: ../app/code/core/Mage/Poll/Model/Poll.php - - message: "#^Variable \\$idField might not be defined\\.$#" + message: "#^Method Mage_Poll_Model_Poll\\:\\:getRandomId\\(\\) should return string but returns int\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogIndex/Model/Data/Abstract.php + path: ../app/code/core/Mage/Poll/Model/Poll.php - - message: "#^Variable \\$whereField might not be defined\\.$#" + message: "#^Parameter \\#1 \\$pollId of method Mage_Poll_Model_Poll\\:\\:getCookieName\\(\\) expects int\\|null, string given\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogIndex/Model/Data/Abstract.php + path: ../app/code/core/Mage/Poll/Model/Poll.php - - message: "#^Parameter \\#1 \\$product \\(array\\) of method Mage_CatalogIndex_Model_Data_Grouped\\:\\:getFinalPrice\\(\\) should be compatible with parameter \\$product \\(int\\) of method Mage_CatalogIndex_Model_Data_Abstract\\:\\:getFinalPrice\\(\\)$#" + message: "#^Parameter \\#1 \\$pollId of method Mage_Poll_Model_Poll\\:\\:getPollId\\(\\) expects string\\|null, int\\|null given\\.$#" + count: 4 + path: ../app/code/core/Mage/Poll/Model/Poll.php + + - + message: "#^Parameter \\#2 \\$pollId of method Mage_Poll_Model_Resource_Poll\\:\\:getVotedPollIdsByIp\\(\\) expects int\\|false, string given\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogIndex/Model/Data/Grouped.php + path: ../app/code/core/Mage/Poll/Model/Poll.php - - message: "#^Return type \\(false\\) of method Mage_CatalogIndex_Model_Data_Grouped\\:\\:getFinalPrice\\(\\) should be compatible with return type \\(float\\) of method Mage_CatalogIndex_Model_Data_Abstract\\:\\:getFinalPrice\\(\\)$#" + message: "#^Method Mage_Poll_Model_Resource_Poll\\:\\:checkAnswerId\\(\\) should return bool but returns string\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogIndex/Model/Data/Grouped.php + path: ../app/code/core/Mage/Poll/Model/Resource/Poll.php - - message: "#^Property Mage_CatalogIndex_Model_Data_Simple\\:\\:\\$_haveChildren \\(array\\\\) does not accept default value of type false\\.$#" + message: "#^Method Mage_Poll_Model_Resource_Poll\\:\\:getRandomId\\(\\) should return int but returns string\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogIndex/Model/Data/Simple.php + path: ../app/code/core/Mage/Poll/Model/Resource/Poll.php - - message: "#^Property Mage_CatalogIndex_Model_Data_Virtual\\:\\:\\$_haveChildren \\(array\\\\) does not accept default value of type false\\.$#" + message: "#^Method Mage_Poll_Model_Resource_Poll_Answer_Collection\\:\\:countPercent\\(\\) should return \\$this\\(Mage_Poll_Model_Resource_Poll_Answer_Collection\\) but empty return statement found\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogIndex/Model/Data/Virtual.php + path: ../app/code/core/Mage/Poll/Model/Resource/Poll/Answer/Collection.php - - message: "#^Variable \\$kill in isset\\(\\) always exists and is not nullable\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Store will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogIndex/Model/Indexer.php + path: ../app/code/core/Mage/ProductAlert/Block/Email/Abstract.php - - message: "#^Variable \\$storeObject might not be defined\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_ProductAlert_Helper_Data will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/ProductAlert/Block/Product/View.php + + - + message: "#^Negated boolean expression is always false\\.$#" count: 2 - path: ../app/code/core/Mage/CatalogIndex/Model/Indexer.php + path: ../app/code/core/Mage/ProductAlert/Block/Product/View.php - - message: "#^Return type \\(string\\) of method Mage_CatalogIndex_Model_Indexer_Eav\\:\\:_getIndexableAttributeConditions\\(\\) should be compatible with return type \\(array\\) of method Mage_CatalogIndex_Model_Indexer_Abstract\\:\\:_getIndexableAttributeConditions\\(\\)$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogIndex/Model/Indexer/Eav.php + path: ../app/code/core/Mage/ProductAlert/Block/Stock.php - - message: "#^Return type \\(string\\) of method Mage_CatalogIndex_Model_Indexer_Price\\:\\:_getIndexableAttributeConditions\\(\\) should be compatible with return type \\(array\\) of method Mage_CatalogIndex_Model_Indexer_Abstract\\:\\:_getIndexableAttributeConditions\\(\\)$#" + message: "#^Method Mage_ProductAlert_Helper_Data\\:\\:createBlock\\(\\) should return string but returns Mage_Core_Block_Abstract\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogIndex/Model/Indexer/Price.php + path: ../app/code/core/Mage/ProductAlert/Helper/Data.php - - message: "#^Method Mage_CatalogIndex_Model_Resource_Indexer_Abstract\\:\\:saveIndex\\(\\) with return type void returns mixed but should not return anything\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Website will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogIndex/Model/Resource/Indexer/Abstract.php + path: ../app/code/core/Mage/ProductAlert/Model/Email.php - - message: "#^Binary operation \"\\*\" between string and float results in an error\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Customer_Model_Customer will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogIndex/Model/Resource/Price.php + path: ../app/code/core/Mage/ProductAlert/Model/Email.php - - message: "#^Method Mage_CatalogIndex_Model_Retreiver\\:\\:getRetreiver\\(\\) should return Mage_CatalogIndex_Model_Data_Abstract but returns Mage_Core_Model_Abstract\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_ProductAlert_Block_Email_Price will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogIndex/Model/Retreiver.php + path: ../app/code/core/Mage/ProductAlert/Model/Email.php - - message: "#^Property Mage_CatalogInventory_Block_Adminhtml_Form_Field_Minsaleqty\\:\\:\\$_groupRenderer \\(Mage_CatalogInventory_Block_Adminhtml_Form_Field_Customergroup\\) does not accept Mage_Core_Block_Abstract\\|false\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_ProductAlert_Block_Email_Stock will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogInventory/Block/Adminhtml/Form/Field/Minsaleqty.php + path: ../app/code/core/Mage/ProductAlert/Model/Email.php - - message: "#^Method Mage_CatalogInventory_Model_Observer\\:\\:_getQuoteItemQtyForCheck\\(\\) should return int but returns float\\.$#" + message: "#^Property Mage_ProductAlert_Model_Email\\:\\:\\$_customer \\(Mage_Customer_Model_Customer\\) does not accept null\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogInventory/Model/Observer.php + path: ../app/code/core/Mage/ProductAlert/Model/Email.php - - message: "#^Binary operation \"\\*\" between string and 0\\.3 results in an error\\.$#" + message: "#^Property Mage_ProductAlert_Model_Email\\:\\:\\$_priceBlock \\(Mage_ProductAlert_Block_Email_Price\\) does not accept string\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock.php + path: ../app/code/core/Mage/ProductAlert/Model/Email.php - - message: "#^Binary operation \"\\+\" between int\\<0, max\\> and string results in an error\\.$#" + message: "#^Property Mage_ProductAlert_Model_Email\\:\\:\\$_stockBlock \\(Mage_ProductAlert_Block_Email_Stock\\) does not accept string\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock.php + path: ../app/code/core/Mage/ProductAlert/Model/Email.php - - message: "#^Cannot call method setTypeId\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + message: "#^Result of \\|\\| is always false\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock.php + path: ../app/code/core/Mage/ProductAlert/Model/Email.php - - message: "#^Property Mage_CatalogInventory_Model_Resource_Stock\\:\\:\\$_isConfigBackorders \\(bool\\) does not accept int\\.$#" + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Stock.php + path: ../app/code/core/Mage/ProductAlert/Model/Observer.php - - message: "#^Property Mage_CatalogInventory_Model_Resource_Stock\\:\\:\\$_isConfigManageStock \\(bool\\) does not accept int\\.$#" - count: 1 - path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Stock.php + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/ProductAlert/Model/Observer.php - - message: "#^Return type \\(Varien_Db_Select\\) of method Mage_CatalogInventory_Model_Resource_Stock_Item_Collection\\:\\:_initSelect\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Resource_Db_Collection_Abstract\\)\\) of method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:_initSelect\\(\\)$#" - count: 1 - path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Stock/Item/Collection.php + message: "#^Parameter \\#1 \\$store of method Mage_Core_Model_App\\:\\:setCurrentStore\\(\\) expects string, Mage_Core_Model_Store given\\.$#" + count: 4 + path: ../app/code/core/Mage/ProductAlert/Model/Observer.php - - message: "#^Property Mage_CatalogInventory_Model_Stock_Item\\:\\:\\$_productInstance \\(Mage_Catalog_Model_Product\\) does not accept null\\.$#" + message: "#^Call to function is_null\\(\\) with int\\|string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogInventory/Model/Stock/Item.php + path: ../app/code/core/Mage/ProductAlert/Model/Resource/Price.php - - message: "#^Variable \\$parentItem in empty\\(\\) always exists and is not falsy\\.$#" - count: 1 - path: ../app/code/core/Mage/CatalogInventory/Model/Stock/Item.php + message: "#^Result of && is always false\\.$#" + count: 3 + path: ../app/code/core/Mage/ProductAlert/Model/Resource/Price.php - - message: "#^Return type \\(int\\) of method Mage_CatalogRule_Model_Action_Index_Refresh_Row\\:\\:_getProduct\\(\\) should be compatible with return type \\(null\\) of method Mage_CatalogRule_Model_Action_Index_Refresh\\:\\:_getProduct\\(\\)$#" + message: "#^Call to function is_null\\(\\) with int\\|string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogRule/Model/Action/Index/Refresh/Row.php + path: ../app/code/core/Mage/ProductAlert/Model/Resource/Stock.php - - message: "#^Variable \\$gId might not be defined\\.$#" - count: 1 - path: ../app/code/core/Mage/CatalogRule/Model/Observer.php + message: "#^Result of && is always false\\.$#" + count: 3 + path: ../app/code/core/Mage/ProductAlert/Model/Resource/Stock.php - - message: "#^Variable \\$pId might not be defined\\.$#" + message: "#^Method Mage_ProductAlert_Model_Observer\\:\\:process\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogRule/Model/Observer.php + path: ../app/code/core/Mage/ProductAlert/controllers/AddController.php - - message: "#^Variable \\$wId might not be defined\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogRule/Model/Observer.php + path: ../app/code/core/Mage/ProductAlert/controllers/AddController.php - - message: "#^Variable \\$indexAlias might not be defined\\.$#" + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogRule/Model/Resource/Rule/Product/Price.php + path: ../app/code/core/Mage/ProductAlert/controllers/AddController.php - - message: "#^Call to an undefined method Mage_Rule_Model_Condition_Combine\\:\\:collectValidatedAttributes\\(\\)\\.$#" + message: "#^Return type \\(void\\) of method Mage_ProductAlert_AddController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Controller_Front_Action\\)\\) of method Mage_Core_Controller_Front_Action\\:\\:preDispatch\\(\\)$#" count: 1 - path: ../app/code/core/Mage/CatalogRule/Model/Rule.php + path: ../app/code/core/Mage/ProductAlert/controllers/AddController.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogSearch/Block/Advanced/Form.php + path: ../app/code/core/Mage/ProductAlert/controllers/UnsubscribeController.php - - message: "#^Property Mage_CatalogSearch_Block_Result\\:\\:\\$_productCollection \\(Mage_CatalogSearch_Model_Resource_Fulltext_Collection\\) does not accept Mage_Eav_Model_Entity_Collection_Abstract\\.$#" + message: "#^Method Mage_Rating_Model_Resource_Rating\\:\\:getEntityIdByCode\\(\\) should return int but returns string\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogSearch/Block/Result.php + path: ../app/code/core/Mage/Rating/Model/Resource/Rating.php - - message: "#^Variable \\$temp might not be defined\\.$#" + message: "#^Parameter \\#1 \\$object of method Mage_Rating_Model_Resource_Rating\\:\\:_getEntitySummaryData\\(\\) expects Mage_Rating_Model_Rating, Mage_Core_Model_Abstract given\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogSearch/Block/Term.php + path: ../app/code/core/Mage/Rating/Model/Resource/Rating.php - - message: "#^Variable \\$termKeys might not be defined\\.$#" - count: 2 - path: ../app/code/core/Mage/CatalogSearch/Block/Term.php + message: "#^Variable \\$data in empty\\(\\) always exists and is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Rating/Model/Resource/Rating.php - - message: "#^Method Mage_CatalogSearch_Model_Advanced\\:\\:getProductCollection\\(\\) should return Mage_CatalogSearch_Model_Resource_Advanced_Collection but returns array\\|float\\|int\\|string\\|false\\|null\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogSearch/Model/Advanced.php + path: ../app/code/core/Mage/Rating/Model/Resource/Rating/Collection.php - - message: "#^Return type \\(bool\\) of method Mage_CatalogSearch_Model_Layer_Filter_Attribute\\:\\:_getIsFilterableAttribute\\(\\) should be compatible with return type \\(Mage_Catalog_Model_Resource_Eav_Attribute\\) of method Mage_Catalog_Model_Layer_Filter_Attribute\\:\\:_getIsFilterableAttribute\\(\\)$#" - count: 1 - path: ../app/code/core/Mage/CatalogSearch/Model/Layer/Filter/Attribute.php + message: "#^Method Mage_Rating_Model_Resource_Rating_Collection\\:\\:getItemById\\(\\) invoked with 1 parameter, 0 required\\.$#" + count: 2 + path: ../app/code/core/Mage/Rating/Model/Resource/Rating/Collection.php - - message: "#^Variable \\$select might not be defined\\.$#" + message: "#^Variable \\$storeId in empty\\(\\) always exists and is not falsy\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Advanced/Collection.php + path: ../app/code/core/Mage/Rating/Model/Resource/Rating/Collection.php - - message: "#^Property Mage_CatalogSearch_Model_Resource_Fulltext_Collection\\:\\:\\$_relevanceSortOrder \\(null\\) does not accept default value of type int\\.$#" + message: "#^Method Mage_Rating_Model_Resource_Rating_Entity\\:\\:getIdByCode\\(\\) should return int but returns string\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Collection.php + path: ../app/code/core/Mage/Rating/Model/Resource/Rating/Entity.php - - message: "#^Property Mage_CatalogSearch_Model_Resource_Fulltext_Collection\\:\\:\\$_relevanceSortOrder \\(null\\) does not accept int\\.$#" + message: "#^Parameter \\#2 \\$value of method Varien_Data_Collection\\:\\:addFilter\\(\\) expects array\\|string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Collection.php + path: ../app/code/core/Mage/Rating/Model/Resource/Rating/Option/Collection.php - - message: "#^Cannot call method setItem\\(\\) on array\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Reports_Model_Product_Index_Abstract will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/Block/Cart/Abstract.php + path: ../app/code/core/Mage/Reports/Block/Product/Abstract.php - - message: "#^Variable \\$ninProductIds in empty\\(\\) always exists and is not falsy\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Reports_Model_Resource_Product_Index_Collection_Abstract will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/Block/Cart/Crosssell.php + path: ../app/code/core/Mage/Reports/Block/Product/Abstract.php - - message: "#^Property Mage_Checkout_Block_Cart_Shipping\\:\\:\\$_address \\(array\\) does not accept Mage_Sales_Model_Quote_Address\\.$#" + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/Block/Cart/Shipping.php + path: ../app/code/core/Mage/Reports/Block/Product/Abstract.php - - message: "#^Property Mage_Checkout_Block_Onepage_Billing\\:\\:\\$_taxvat \\(Mage_Customer_Block_Widget_Taxvat\\) does not accept Mage_Core_Block_Abstract\\|false\\.$#" + message: "#^Property Mage_Reports_Block_Product_Abstract\\:\\:\\$_indexModel \\(Mage_Reports_Model_Product_Index_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/Block/Onepage/Billing.php + path: ../app/code/core/Mage/Reports/Block/Product/Abstract.php - - message: "#^Method Mage_Checkout_Block_Onepage_Progress\\:\\:getShippingPriceInclTax\\(\\) should return float but returns string\\.$#" - count: 1 - path: ../app/code/core/Mage/Checkout/Block/Onepage/Progress.php + message: "#^Variable \\$dateStart might not be defined\\.$#" + count: 7 + path: ../app/code/core/Mage/Reports/Helper/Data.php - - message: "#^Variable \\$storeId might not be defined\\.$#" + message: "#^Variable \\$t might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/Model/Api/Resource.php + path: ../app/code/core/Mage/Reports/Helper/Data.php - - message: "#^Method Mage_Checkout_Model_Cart\\:\\:saveQuote\\(\\) should return Mage_Checkout_Model_Cart_Interface but return statement is missing\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/Model/Cart.php + path: ../app/code/core/Mage/Reports/Model/Event/Observer.php - - message: "#^Variable \\$product might not be defined\\.$#" + message: "#^Property Mage_Reports_Model_Grouped_Collection\\:\\:\\$_resourceCollection \\(Mage_Core_Model_Resource_Db_Collection_Abstract\\) does not accept Varien_Data_Collection_Db\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/Model/Cart.php + path: ../app/code/core/Mage/Reports/Model/Grouped/Collection.php - - message: "#^Variable \\$productId might not be defined\\.$#" + message: "#^Method Mage_Reports_Model_Resource_Product_Index_Abstract\\:\\:clean\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/Model/Cart.php + path: ../app/code/core/Mage/Reports/Model/Product/Index/Abstract.php - - message: "#^Variable \\$order might not be defined\\.$#" + message: "#^Property Mage_Reports_Model_Report\\:\\:\\$_reportModel \\(Mage_Reports_Model_Report\\) does not accept Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/Model/Cart/Api.php + path: ../app/code/core/Mage/Reports/Model/Report.php - - message: "#^Variable \\$quote might not be defined\\.$#" + message: "#^Parameter \\#3 \\$attribute of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addExpressionAttributeToSelect\\(\\) expects string, array\\ given\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/Model/Cart/Api.php + path: ../app/code/core/Mage/Reports/Model/Resource/Accounts/Collection.php - - message: "#^Variable \\$customer might not be defined\\.$#" - count: 4 - path: ../app/code/core/Mage/Checkout/Model/Cart/Customer/Api.php + message: "#^Parameter \\#3 \\$attribute of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addExpressionAttributeToSelect\\(\\) expects string, array\\ given\\.$#" + count: 6 + path: ../app/code/core/Mage/Reports/Model/Resource/Coupons/Collection.php - - message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Checkout_Model_Cart_Customer_Api_V2\\:\\:_prepareCustomerAddressData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Checkout_Model_Cart_Customer_Api\\:\\:_prepareCustomerAddressData\\(\\)$#" + message: "#^Call to an undefined method Mage_Customer_Model_Customer\\:\\:remove\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/Model/Cart/Customer/Api/V2.php + path: ../app/code/core/Mage/Reports/Model/Resource/Customer/Collection.php - - message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Checkout_Model_Cart_Customer_Api_V2\\:\\:_prepareCustomerData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Checkout_Model_Cart_Customer_Api\\:\\:_prepareCustomerData\\(\\)$#" + message: "#^Call to an undefined method Mage_Sales_Model_Resource_Quote_Item_Collection\\:\\:setQuoteFilter\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/Model/Cart/Customer/Api/V2.php + path: ../app/code/core/Mage/Reports/Model/Resource/Customer/Collection.php - - message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Checkout_Model_Cart_Payment_Api_V2\\:\\:_preparePaymentData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Checkout_Model_Cart_Payment_Api\\:\\:_preparePaymentData\\(\\)$#" + message: "#^Else branch is unreachable because previous condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/Model/Cart/Payment/Api/V2.php + path: ../app/code/core/Mage/Reports/Model/Resource/Customer/Collection.php - - message: "#^Method Mage_Checkout_Model_Cart_Product_Api_V2\\:\\:_prepareProductsData\\(\\) should return array but returns mixed\\.$#" - count: 1 - path: ../app/code/core/Mage/Checkout/Model/Cart/Product/Api/V2.php + message: "#^Parameter \\#2 \\$value of method Varien_Db_Adapter_Interface\\:\\:getIfNullSql\\(\\) expects string, int given\\.$#" + count: 4 + path: ../app/code/core/Mage/Reports/Model/Resource/Customer/Collection.php - - message: "#^Variable \\$ratesResult might not be defined\\.$#" + message: "#^Property Mage_Reports_Model_Resource_Entity_Summary_Collection_Abstract\\:\\:\\$_entityCollection \\(Mage_Eav_Model_Entity_Collection_Abstract\\) in empty\\(\\) is not falsy\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/Model/Cart/Shipping/Api.php + path: ../app/code/core/Mage/Reports/Model/Resource/Entity/Summary/Collection/Abstract.php - - message: "#^Method Mage_Checkout_Model_Session\\:\\:getQuoteId\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Call to an undefined method Varien_Data_Collection_Db\\:\\:getResource\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/Model/Observer.php + path: ../app/code/core/Mage/Reports/Model/Resource/Event.php - - message: "#^Method Mage_Checkout_Model_Session\\:\\:unsetAll\\(\\) should return \\$this\\(Mage_Checkout_Model_Session\\) but return statement is missing\\.$#" + message: "#^Method Mage_Reports_Model_Resource_Helper_Mysql4\\:\\:mergeVisitorProductIndex\\(\\) should return string but returns int\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/Model/Session.php + path: ../app/code/core/Mage/Reports/Model/Resource/Helper/Mysql4.php - - message: "#^Call to an undefined method Mage_Sales_Model_Order\\:\\:createFromQuoteAddress\\(\\)\\.$#" + message: "#^Parameter \\#2 \\$true of method Varien_Db_Adapter_Interface\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/Model/Type/Abstract.php + path: ../app/code/core/Mage/Reports/Model/Resource/Helper/Mysql4.php - - message: "#^Method Mage_Sales_Model_Quote\\:\\:getBillingAddress\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Parameter \\#3 \\$false of method Varien_Db_Adapter_Interface\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/Model/Type/Multishipping.php + path: ../app/code/core/Mage/Reports/Model/Resource/Helper/Mysql4.php - - message: "#^Variable \\$paymentMethod in empty\\(\\) always exists and is not falsy\\.$#" + message: "#^Parameter \\#2 \\$true of method Varien_Db_Adapter_Interface\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/Model/Type/Multishipping.php + path: ../app/code/core/Mage/Reports/Model/Resource/Invoiced/Collection.php - - message: "#^Variable \\$customerRequest might not be defined\\.$#" - count: 2 - path: ../app/code/core/Mage/Checkout/Model/Type/Onepage.php + message: "#^Parameter \\#3 \\$attribute of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addExpressionAttributeToSelect\\(\\) expects string, array\\ given\\.$#" + count: 8 + path: ../app/code/core/Mage/Reports/Model/Resource/Invoiced/Collection.php - - message: "#^Comparison operation \"\\=\\=\" between 0\\|0\\.0\\|array\\|string\\|false\\|null and 0 results in an error\\.$#" + message: "#^Parameter \\#3 \\$false of method Varien_Db_Adapter_Interface\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/controllers/CartController.php + path: ../app/code/core/Mage/Reports/Model/Resource/Invoiced/Collection.php - - message: "#^Call to an undefined method Mage_Sales_Model_Service_Order\\:\\:register\\(\\)\\.$#" + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Checkout/controllers/OnepageController.php + path: ../app/code/core/Mage/Reports/Model/Resource/Order/Collection.php - - message: "#^Cannot access offset 'cookie' on void\\|true\\.$#" + message: "#^Method Mage_Reports_Model_Resource_Order_Collection\\:\\:_prepareSummaryAggregated\\(\\) invoked with 4 parameters, 3 required\\.$#" count: 1 - path: ../app/code/core/Mage/Cms/Model/Wysiwyg/Images/Storage.php + path: ../app/code/core/Mage/Reports/Model/Resource/Order/Collection.php - - message: "#^Method Mage_Cms_Model_Wysiwyg_Images_Storage\\:\\:getConfig\\(\\) should return Mage_Core_Model_Config_Element but returns Varien_Simplexml_Element\\|false\\.$#" + message: "#^Parameter \\#2 \\$customStart of method Mage_Reports_Model_Resource_Order_Collection\\:\\:getDateRange\\(\\) expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Cms/Model/Wysiwyg/Images/Storage.php + path: ../app/code/core/Mage/Reports/Model/Resource/Order/Collection.php - - message: "#^Property Mage_Cms_Model_Wysiwyg_Images_Storage\\:\\:\\$_config \\(Mage_Core_Model_Config_Element\\) does not accept Varien_Simplexml_Element\\|false\\.$#" + message: "#^Parameter \\#2 \\$interval of method Varien_Db_Adapter_Interface\\:\\:getDateAddSql\\(\\) expects int, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Cms/Model/Wysiwyg/Images/Storage.php + path: ../app/code/core/Mage/Reports/Model/Resource/Order/Collection.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 2 parameters, 0 required\\.$#" - count: 1 - path: ../app/code/core/Mage/ConfigurableSwatches/Helper/Productimg.php + message: "#^Parameter \\#2 \\$value of method Varien_Db_Adapter_Interface\\:\\:getIfNullSql\\(\\) expects string, int given\\.$#" + count: 20 + path: ../app/code/core/Mage/Reports/Model/Resource/Order/Collection.php - - message: "#^Variable \\$mediaGalleryImages in empty\\(\\) always exists and is not falsy\\.$#" + message: "#^Parameter \\#3 \\$customEnd of method Mage_Reports_Model_Resource_Order_Collection\\:\\:getDateRange\\(\\) expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/ConfigurableSwatches/Helper/Productimg.php + path: ../app/code/core/Mage/Reports/Model/Resource/Order/Collection.php - - message: "#^Method Mage_ConfigurableSwatches_Helper_Productlist\\:\\:getSwatchAttribute\\(\\) should return Mage_Eav_Model_Attribute but returns Mage_Catalog_Model_Product_Type_Configurable_Attribute\\.$#" + message: "#^Parameter \\#3 \\$false of method Varien_Db_Adapter_Interface\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/ConfigurableSwatches/Helper/Productlist.php + path: ../app/code/core/Mage/Reports/Model/Resource/Order/Collection.php - - message: "#^Property Mage_ConfigurableSwatches_Helper_Productlist\\:\\:\\$_swatchAttribute \\(Mage_Catalog_Model_Product_Type_Configurable_Attribute\\) does not accept Mage_Eav_Model_Entity_Attribute_Abstract\\|false\\.$#" + message: "#^Variable \\$productViewEvent might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/ConfigurableSwatches/Helper/Productlist.php + path: ../app/code/core/Mage/Reports/Model/Resource/Product/Collection.php - - message: "#^Property Mage_ConfigurableSwatches_Helper_Productlist\\:\\:\\$_swatchAttributeFilteredValue \\(int\\) does not accept false\\.$#" + message: "#^Parameter \\#1 \\$date of static method Varien_Date\\:\\:formatDate\\(\\) expects string\\|Zend_Date\\|true\\|null, int given\\.$#" count: 1 - path: ../app/code/core/Mage/ConfigurableSwatches/Helper/Productlist.php + path: ../app/code/core/Mage/Reports/Model/Resource/Product/Index/Abstract.php - - message: "#^Variable \\$query might not be defined\\.$#" + message: "#^Parameter \\#2 \\$true of method Varien_Db_Adapter_Interface\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" count: 2 - path: ../app/code/core/Mage/ConfigurableSwatches/Model/Resource/Catalog/Product/Type/Configurable/Product/Collection.php + path: ../app/code/core/Mage/Reports/Model/Resource/Product/Lowstock/Collection.php - - message: "#^Return type \\(void\\) of method Mage_Contacts_IndexController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Controller_Front_Action\\)\\) of method Mage_Core_Controller_Front_Action\\:\\:preDispatch\\(\\)$#" + message: "#^Parameter \\#1 \\$from of method Mage_Reports_Model_Resource_Product_Ordered_Collection\\:\\:_joinFields\\(\\) expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Contacts/controllers/IndexController.php + path: ../app/code/core/Mage/Reports/Model/Resource/Product/Ordered/Collection.php - - message: "#^Method Mage_Core_Block_Abstract\\:\\:_getUrlModel\\(\\) should return Mage_Core_Model_Url but returns Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Parameter \\#2 \\$to of method Mage_Reports_Model_Resource_Product_Ordered_Collection\\:\\:_joinFields\\(\\) expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Block/Abstract.php + path: ../app/code/core/Mage/Reports/Model/Resource/Product/Ordered/Collection.php - - message: "#^Method Mage_Core_Block_Abstract\\:\\:getHelper\\(\\) should return \\$this\\(Mage_Core_Block_Abstract\\) but returns Mage_Core_Block_Abstract\\.$#" + message: "#^Parameter \\#1 \\$from of method Mage_Reports_Model_Resource_Product_Collection\\:\\:addOrderedQty\\(\\) expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Block/Abstract.php + path: ../app/code/core/Mage/Reports/Model/Resource/Product/Sold/Collection.php - - message: "#^Method Mage_Core_Block_Abstract\\:\\:getParentBlock\\(\\) should return \\$this\\(Mage_Core_Block_Abstract\\) but returns Mage_Core_Block_Abstract\\.$#" + message: "#^Parameter \\#2 \\$to of method Mage_Reports_Model_Resource_Product_Collection\\:\\:addOrderedQty\\(\\) expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Block/Abstract.php + path: ../app/code/core/Mage/Reports/Model/Resource/Product/Sold/Collection.php - - message: "#^Return type \\(void\\) of method Mage_Core_Block_Template_Zend\\:\\:setScriptPath\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Template\\)\\) of method Mage_Core_Block_Template\\:\\:setScriptPath\\(\\)$#" + message: "#^Parameter \\#1 \\$filter of method Mage_Reports_Model_Resource_Quote_Collection\\:\\:addCustomerData\\(\\) expects array\\|null, string\\|null given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Block/Template/Zend.php + path: ../app/code/core/Mage/Reports/Model/Resource/Quote/Collection.php - - message: "#^Call to an undefined method Zend_Controller_Router_Interface\\:\\:addRoute\\(\\)\\.$#" + message: "#^Parameter \\#2 \\$filter of method Mage_Reports_Model_Resource_Quote_Collection\\:\\:addSubtotal\\(\\) expects array\\|null, string\\|null given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Controller/Front/Router.php + path: ../app/code/core/Mage/Reports/Model/Resource/Quote/Collection.php - - message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:is\\(\\)\\.$#" - count: 1 - path: ../app/code/core/Mage/Core/Controller/Varien/Action.php + message: "#^Parameter \\#3 \\$cols of method Zend_Db_Select\\:\\:joinInner\\(\\) expects array\\|string, null given\\.$#" + count: 2 + path: ../app/code/core/Mage/Reports/Model/Resource/Quote/Collection.php - - message: "#^Constructor of class Mage_Core_Controller_Varien_Action has an unused parameter \\$invokeArgs\\.$#" - count: 1 - path: ../app/code/core/Mage/Core/Controller/Varien/Action.php + message: "#^Parameter \\#3 \\$attribute of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addExpressionAttributeToSelect\\(\\) expects string, array\\ given\\.$#" + count: 7 + path: ../app/code/core/Mage/Reports/Model/Resource/Refunded/Collection.php - - message: "#^Property Mage_Core_Controller_Varien_Action\\:\\:\\$_request \\(Mage_Core_Controller_Request_Http\\) does not accept Zend_Controller_Request_Abstract\\.$#" + message: "#^Parameter \\#1 \\$date of method Mage_Core_Model_Resource_Abstract\\:\\:formatDate\\(\\) expects string\\|Zend_Date\\|true\\|null, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Controller/Varien/Action.php + path: ../app/code/core/Mage/Reports/Model/Resource/Report/Abstract.php - - message: "#^Property Mage_Core_Controller_Varien_Action\\:\\:\\$_response \\(Mage_Core_Controller_Response_Http\\) does not accept Zend_Controller_Response_Abstract\\.$#" + message: "#^Parameter \\#1 \\$select of method Mage_Reports_Model_Resource_Report_Abstract\\:\\:_makeConditionFromDateRangeSelect\\(\\) expects Varien_Db_Select, string\\|Zend_Db_Select given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Controller/Varien/Action.php + path: ../app/code/core/Mage/Reports/Model/Resource/Report/Abstract.php - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" - count: 1 - path: ../app/code/core/Mage/Core/Controller/Varien/Front.php + message: "#^Parameter \\#1 \\$datetime of method Mage_Reports_Model_Resource_Report_Collection\\:\\:timeShift\\(\\) expects string, int given\\.$#" + count: 4 + path: ../app/code/core/Mage/Reports/Model/Resource/Report/Collection.php - - message: "#^Method Mage_Core_Controller_Varien_Front\\:\\:_getRequestRewriteController\\(\\) should return Mage_Core_Model_Url_Rewrite_Request but returns bool\\|Mage_Core_Model_Abstract\\.$#" + message: "#^Property Mage_Reports_Model_Resource_Report_Collection\\:\\:\\$_from \\(string\\) does not accept int\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Controller/Varien/Front.php + path: ../app/code/core/Mage/Reports/Model/Resource/Report/Collection.php - - message: "#^Parameter \\#2 \\$useRouterName \\(bool\\) of method Mage_Core_Controller_Varien_Router_Admin\\:\\:collectRoutes\\(\\) should be compatible with parameter \\$useRouterName \\(string\\) of method Mage_Core_Controller_Varien_Router_Standard\\:\\:collectRoutes\\(\\)$#" + message: "#^Property Mage_Reports_Model_Resource_Report_Collection\\:\\:\\$_to \\(string\\) does not accept int\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Controller/Varien/Router/Admin.php + path: ../app/code/core/Mage/Reports/Model/Resource/Report/Collection.php - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php + + - + message: "#^Comparison operation \"\\!\\=\" between array\\|int and 0 results in an error\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Controller/Varien/Router/Standard.php + path: ../app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php - - message: "#^Variable \\$action might not be defined\\.$#" + message: "#^If condition is always true\\.$#" + count: 4 + path: ../app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php + + - + message: "#^Left side of && is always true\\.$#" count: 2 - path: ../app/code/core/Mage/Core/Controller/Varien/Router/Standard.php + path: ../app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php - - message: "#^Variable \\$controller might not be defined\\.$#" + message: "#^Negated boolean expression is always false\\.$#" + count: 4 + path: ../app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php + + - + message: "#^Parameter \\#1 \\$conn of method Varien_Data_Collection_Db\\:\\:setConnection\\(\\) expects Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Controller/Varien/Router/Standard.php + path: ../app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php - - message: "#^Variable \\$controllerInstance might not be defined\\.$#" + message: "#^Parameter \\#1 \\$select of method Mage_Core_Model_Resource_Helper_Mysql4\\:\\:getQueryUsingAnalyticFunction\\(\\) expects Varien_Db_Select, Zend_Db_Select given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Controller/Varien/Router/Standard.php + path: ../app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php - - message: "#^Variable \\$realModule might not be defined\\.$#" + message: "#^Right side of && is always true\\.$#" count: 2 - path: ../app/code/core/Mage/Core/Controller/Varien/Router/Standard.php + path: ../app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php - - message: "#^Method Mage_Core_Helper_Abstract\\:\\:_getRequest\\(\\) should return Mage_Core_Controller_Request_Http but returns Zend_Controller_Request_Http\\.$#" + message: "#^Variable \\$currentStoreIds in isset\\(\\) always exists and is not nullable\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Helper/Abstract.php + path: ../app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php - - message: "#^Property Mage_Core_Helper_String\\:\\:\\$_arrayHelper \\(Mage_Core_Helper_Array\\) does not accept Mage_Core_Helper_Abstract\\.$#" + message: "#^Call to an undefined method Mage_Reports_Model_Resource_Review_Collection\\:\\:_joinFields\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Helper/String.php + path: ../app/code/core/Mage/Reports/Model/Resource/Review/Collection.php - - message: "#^Property Mage_Core_Model_Abstract\\:\\:\\$_cacheTag \\(string\\|true\\) does not accept default value of type false\\.$#" + message: "#^Call to an undefined static method Mage_Review_Model_Resource_Review_Collection\\:\\:resetSelect\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Abstract.php + path: ../app/code/core/Mage/Reports/Model/Resource/Review/Collection.php - - message: "#^Method Mage_Core_Model_App\\:\\:getDefaultStoreView\\(\\) should return Mage_Core_Model_Store but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Core/Model/App.php + message: "#^Parameter \\#2 \\$groupAliasName of method Mage_Core_Model_Resource_Helper_Mysql4\\:\\:prepareColumn\\(\\) expects string\\|null, array given\\.$#" + count: 3 + path: ../app/code/core/Mage/Reports/Model/Resource/Review/Product/Collection.php - - message: "#^Method Mage_Core_Model_App\\:\\:getResponse\\(\\) should return Mage_Core_Controller_Response_Http but returns Zend_Controller_Response_Http\\.$#" - count: 1 - path: ../app/code/core/Mage/Core/Model/App.php + message: "#^Parameter \\#3 \\$attribute of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addExpressionAttributeToSelect\\(\\) expects string, array\\ given\\.$#" + count: 3 + path: ../app/code/core/Mage/Reports/Model/Resource/Shipping/Collection.php - - message: "#^Property Mage_Core_Model_App\\:\\:\\$_useSessionInUrl \\(bool\\) does not accept string\\|null\\.$#" + message: "#^Parameter \\#3 \\$attribute of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addExpressionAttributeToSelect\\(\\) expects string, array\\ given\\.$#" + count: 2 + path: ../app/code/core/Mage/Reports/Model/Resource/Tax/Collection.php + + - + message: "#^Method Mage_Reports_Model_Resource_Wishlist_Collection\\:\\:getSharedCount\\(\\) should return int but returns string\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/App.php + path: ../app/code/core/Mage/Reports/Model/Resource/Wishlist/Collection.php - - message: "#^Property Mage_Core_Model_App\\:\\:\\$_website \\(Mage_Core_Model_Website\\) does not accept null\\.$#" + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:setStore\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/App.php + path: ../app/code/core/Mage/Reports/Model/Resource/Wishlist/Product/Collection.php - - message: "#^Variable \\$id in isset\\(\\) always exists and is not nullable\\.$#" + message: "#^Property DOMNode\\:\\:\\$nodeValue \\(string\\|null\\) does not accept int\\\\|int\\<1, max\\>\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/App.php + path: ../app/code/core/Mage/Reports/Model/Test.php - - message: "#^Method Mage_Core_Model_Cache\\:\\:getDbAdapter\\(\\) should return Zend_Db_Adapter_Abstract but returns Varien_Db_Adapter_Interface\\|false\\.$#" + message: "#^Argument of an invalid type Mage_Reports_Model_Report supplied for foreach, only iterables are supported\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Cache.php + path: ../app/code/core/Mage/Reports/Model/Totals.php - - message: "#^Property Mage_Core_Model_Cache\\:\\:\\$_frontend \\(Varien_Cache_Core\\) does not accept Zend_Cache_Core\\|Zend_Cache_Frontend\\.$#" + message: "#^If condition is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Cache.php + path: ../app/code/core/Mage/Reports/Model/Totals.php - - message: "#^Call to an undefined method SimpleXMLElement\\:\\:getClassName\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$from of method Mage_Reports_Model_Resource_Report_Collection\\:\\:getReportFull\\(\\) expects int, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Config.php + path: ../app/code/core/Mage/Reports/Model/Totals.php - - message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:getClassName\\(\\)\\.$#" - count: 2 - path: ../app/code/core/Mage/Core/Model/Config.php + message: "#^Parameter \\#2 \\$to of method Mage_Reports_Model_Resource_Report_Collection\\:\\:getReportFull\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Reports/Model/Totals.php - - message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:is\\(\\)\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Config.php + path: ../app/code/core/Mage/Review/Block/Form.php - - message: "#^Method Mage_Core_Model_Config\\:\\:cleanCache\\(\\) should return \\$this\\(Mage_Core_Model_Config\\) but returns Mage_Core_Model_Config\\.$#" + message: "#^Return type \\(string\\) of method Mage_Review_Block_Form\\:\\:getAction\\(\\) should be compatible with return type \\(Mage_Core_Controller_Varien_Action\\) of method Mage_Core_Block_Abstract\\:\\:getAction\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Config.php + path: ../app/code/core/Mage/Review/Block/Form.php - - message: "#^Method Mage_Core_Model_Config\\:\\:getNodeClassInstance\\(\\) should return bool but returns object\\.$#" + message: "#^Method Mage_Review_Model_Resource_Review\\:\\:getEntityIdByCode\\(\\) should return bool\\|int but returns string\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Config.php + path: ../app/code/core/Mage/Review/Model/Resource/Review.php - - message: "#^Property Varien_Simplexml_Config\\:\\:\\$_cacheChecksum \\(unknown_type\\) does not accept null\\.$#" + message: "#^Method Mage_Review_Model_Resource_Review\\:\\:getTotalReviews\\(\\) should return int but returns string\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Config.php + path: ../app/code/core/Mage/Review/Model/Resource/Review.php - - message: "#^Return type \\(Mage_Core_Model_App\\) of method Mage_Core_Model_Config\\:\\:_saveCache\\(\\) should be compatible with return type \\(bool\\) of method Varien_Simplexml_Config\\:\\:_saveCache\\(\\)$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Config.php + path: ../app/code/core/Mage/Review/Model/Resource/Review.php - - message: "#^Return type \\(Zend_Cache_Core\\) of method Mage_Core_Model_Config\\:\\:getCache\\(\\) should be compatible with return type \\(Varien_Simplexml_Config_Cache_Abstract\\) of method Varien_Simplexml_Config\\:\\:getCache\\(\\)$#" + message: "#^Comparison operation \"\\=\\=\" between array\\|null and 1 results in an error\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Config.php + path: ../app/code/core/Mage/Review/Model/Resource/Review/Product/Collection.php - - message: "#^Return type \\(string\\) of method Mage_Core_Model_Config\\:\\:_loadCache\\(\\) should be compatible with return type \\(bool\\) of method Varien_Simplexml_Config\\:\\:_loadCache\\(\\)$#" + message: "#^Comparison operation \"\\=\\=\" between array\\|null and 2 results in an error\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Config.php + path: ../app/code/core/Mage/Review/Model/Resource/Review/Product/Collection.php - - message: "#^Variable \\$key might not be defined\\.$#" - count: 1 - path: ../app/code/core/Mage/Core/Model/Config.php + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Review/Model/Review.php - - message: "#^Method Mage_Core_Model_Cookie\\:\\:getHttponly\\(\\) should return bool but returns null\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Cookie.php + path: ../app/code/core/Mage/Review/Model/Review.php - - message: "#^Binary operation \"\\+\" between string and string results in an error\\.$#" + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Date.php + path: ../app/code/core/Mage/Review/controllers/CustomerController.php - - message: "#^Binary operation \"\\-\" between string and string results in an error\\.$#" + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Date.php + path: ../app/code/core/Mage/Review/controllers/ProductController.php - - message: "#^Call to an undefined method Mage_Core_Model_Resource_Design\\:\\:validate\\(\\)\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Design.php + path: ../app/code/core/Mage/Rss/Block/Catalog/Category.php - - message: "#^Property Varien_Simplexml_Config\\:\\:\\$_cacheChecksum \\(unknown_type\\) does not accept null\\.$#" + message: "#^Parameter \\#1 \\$categoryIds of method Mage_Catalog_Model_Resource_Category_Collection\\:\\:addIdFilter\\(\\) expects array, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Design/Config.php + path: ../app/code/core/Mage/Rss/Block/Catalog/Category.php - - message: "#^Binary operation \"\\.\" between non\\-falsy\\-string and array results in an error\\.$#" + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Design/Package.php + path: ../app/code/core/Mage/Rss/Block/Catalog/Category.php - - message: "#^Cannot assign offset 'layout'\\|'locale'\\|'skin'\\|'template' to string\\.$#" + message: "#^Parameter \\#2 \\$joinType of method Mage_Catalog_Model_Resource_Product_Collection\\:\\:addAttributeToSelect\\(\\) expects string\\|false, true given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Design/Package.php + path: ../app/code/core/Mage/Rss/Block/Catalog/NotifyStock.php - - message: "#^Cannot assign offset string to string\\.$#" + message: "#^If condition is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Design/Package.php + path: ../app/code/core/Mage/Rss/Block/Catalog/Special.php - - message: "#^Method Zend_Mail\\:\\:addBcc\\(\\) invoked with 2 parameters, 1 required\\.$#" + message: "#^Static property Mage_Rss_Block_Catalog_Special\\:\\:\\$_currentDate \\(Zend_Date\\) in isset\\(\\) is not nullable\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Email/Queue.php + path: ../app/code/core/Mage/Rss/Block/Catalog/Special.php - - message: "#^Method Mage_Core_Model_Email_Template\\:\\:getProcessedTemplate\\(\\) invoked with 2 parameters, 0\\-1 required\\.$#" + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Email/Template.php + path: ../app/code/core/Mage/Rss/Block/List.php - - message: "#^Method Mage_Core_Model_Email_Template_Abstract\\:\\:loadByConfigPath\\(\\) invoked with 2 parameters, 1 required\\.$#" + message: "#^Parameter \\#1 \\$date of method Mage_Core_Model_Resource_Abstract\\:\\:formatDate\\(\\) expects string\\|Zend_Date\\|true\\|null, int\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Email/Template/Abstract.php + path: ../app/code/core/Mage/Rss/Block/Order/New.php - - message: "#^Call to an undefined method Varien_Crypt_Abstract\\:\\:init\\(\\)\\.$#" + message: "#^Parameter \\#4 \\$month of function mktime expects int\\|null, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Encryption.php + path: ../app/code/core/Mage/Rss/Block/Order/New.php - - message: "#^Method Mage_Core_Model_Factory\\:\\:getUrlRewriteInstance\\(\\) should return Mage_Core_Model_Url_Rewrite but returns bool\\|Mage_Core_Model_Abstract\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Customer_Model_Customer will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Factory.php + path: ../app/code/core/Mage/Rss/Block/Wishlist.php - - message: "#^Variable \\$parentId might not be defined\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Wishlist_Model_Wishlist will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/File/Storage/Directory/Database.php + path: ../app/code/core/Mage/Rss/Block/Wishlist.php - - message: "#^PHPDoc tag @param for parameter \\$filter with type array\\|Zend_Filter_Interface is not subtype of native type Zend_Filter_Interface\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Input/Filter.php + path: ../app/code/core/Mage/Rss/Helper/Catalog.php - - message: "#^Call to an undefined method SimpleXMLElement\\:\\:getAttribute\\(\\)\\.$#" + message: "#^Cannot call method getId\\(\\) on true\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Layout.php + path: ../app/code/core/Mage/Rss/Helper/Data.php - - message: "#^Cannot unset offset '@attributes' on \\(array\\{\\}\\|array\\{\\000\\*\\000_parent\\: Varien_Simplexml_Element\\}\\)\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Layout.php + path: ../app/code/core/Mage/Rss/Helper/Data.php - - message: "#^Method Mage_Core_Model_Layout\\:\\:getMessagesBlock\\(\\) should return Mage_Core_Block_Messages but returns Mage_Core_Block_Abstract\\.$#" + message: "#^Parameter \\#1 \\$headers of method Mage_Core_Helper_Http\\:\\:authValidate\\(\\) expects string\\|null, array\\|null given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Layout.php + path: ../app/code/core/Mage/Rss/Helper/Data.php - - message: "#^Method Mage_Core_Model_Layout\\:\\:getMessagesBlock\\(\\) should return Mage_Core_Block_Messages but returns Mage_Core_Block_Abstract\\|false\\.$#" + message: "#^Call to function is_null\\(\\) with int\\|string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Layout.php + path: ../app/code/core/Mage/Rss/Helper/Order.php - - message: "#^Method Mage_Core_Model_Layout_Update\\:\\:saveCache\\(\\) should return bool but returns Mage_Core_Model_App\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Customer_Model_Customer will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Layout/Update.php + path: ../app/code/core/Mage/Rss/controllers/IndexController.php - - message: "#^Property Mage_Core_Model_Locale\\:\\:\\$_locale \\(Zend_Locale\\) does not accept null\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Wishlist_Model_Wishlist will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Locale.php + path: ../app/code/core/Mage/Rss/controllers/IndexController.php - - message: "#^Method Mage_Core_Model_Message_Collection\\:\\:getMessageByIdentifier\\(\\) should return Mage_Core_Model_Message_Abstract\\|null but return statement is missing\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Message/Collection.php + path: ../app/code/core/Mage/Rss/controllers/IndexController.php - - message: "#^Call to an undefined method Mage_Core_Model_Resource_Type_Abstract\\:\\:getConnection\\(\\)\\.$#" + message: "#^Call to function is_string\\(\\) with array will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Resource.php + path: ../app/code/core/Mage/Rule/Model/Abstract.php - - message: "#^Call to an undefined method SimpleXMLElement\\:\\:getClassName\\(\\)\\.$#" - count: 1 - path: ../app/code/core/Mage/Core/Model/Resource.php + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Rule/Model/Abstract.php - - message: "#^Method Mage_Core_Model_Resource\\:\\:_getDefaultConnection\\(\\) should return string but returns Varien_Db_Adapter_Interface\\|false\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 2 - path: ../app/code/core/Mage/Core/Model/Resource.php + path: ../app/code/core/Mage/Rule/Model/Abstract.php - - message: "#^Method Mage_Core_Model_Resource\\:\\:getConnection\\(\\) should return Varien_Db_Adapter_Interface\\|false but returns string\\.$#" + message: "#^Offset 'actions'\\|'conditions' on array\\{\\} in isset\\(\\) does not exist\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Resource.php + path: ../app/code/core/Mage/Rule/Model/Abstract.php - - message: "#^Method Mage_Core_Model_Resource_Db_Abstract\\:\\:_getConnection\\(\\) should return Magento_Db_Adapter_Pdo_Mysql but returns Varien_Db_Adapter_Interface\\|false\\.$#" + message: "#^Property Mage_Rule_Model_Abstract\\:\\:\\$_conditions \\(Mage_Rule_Model_Condition_Combine\\) in empty\\(\\) is not falsy\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Resource/Db/Abstract.php + path: ../app/code/core/Mage/Rule/Model/Abstract.php - - message: "#^Property Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:\\$_resource \\(Mage_Core_Model_Resource_Db_Abstract\\) does not accept Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + message: "#^Result of && is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php + path: ../app/code/core/Mage/Rule/Model/Abstract.php - - message: "#^Variable \\$alias in isset\\(\\) always exists and is always null\\.$#" + message: "#^Call to an undefined method Mage_Rule_Model_Action_Interface\\:\\:getId\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php + path: ../app/code/core/Mage/Rule/Model/Action/Collection.php - - message: "#^Variable \\$alias might not be defined\\.$#" - count: 3 - path: ../app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php + message: "#^Call to an undefined method Mage_Rule_Model_Action_Interface\\:\\:setId\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Rule/Model/Action/Collection.php - - message: "#^Variable \\$columnsToSelect in isset\\(\\) always exists and is not nullable\\.$#" + message: "#^Call to an undefined method Mage_Rule_Model_Action_Interface\\:\\:setRule\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php + path: ../app/code/core/Mage/Rule/Model/Action/Collection.php - - message: "#^Method Mage_Core_Model_Resource_Entity_Abstract\\:\\:getConfig\\(\\) should return bool\\|string but returns Varien_Simplexml_Config\\.$#" + message: "#^Cannot call method loadArray\\(\\) on Mage_Core_Model_Abstract\\|false\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Resource/Entity/Abstract.php + path: ../app/code/core/Mage/Rule/Model/Action/Collection.php - - message: "#^Property Mage_Core_Model_Resource_Entity_Abstract\\:\\:\\$_config \\(Varien_Simplexml_Config\\) does not accept default value of type array\\.$#" + message: "#^Parameter \\#1 \\$action of method Mage_Rule_Model_Action_Collection\\:\\:addAction\\(\\) expects Mage_Rule_Model_Action_Interface, Mage_Core_Model_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Resource/Entity/Abstract.php + path: ../app/code/core/Mage/Rule/Model/Action/Collection.php - - message: "#^Method Mage_Core_Model_Resource_File_Storage_Directory_Database\\:\\:getParentId\\(\\) should return int but returns string\\.$#" + message: "#^Binary operation \"\\.\" between array and ' ' results in an error\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Resource/File/Storage/Directory/Database.php + path: ../app/code/core/Mage/Rule/Model/Condition/Abstract.php - - message: "#^Property Mage_Core_Model_Resource_File_Storage_File\\:\\:\\$filePointer \\(resource\\) does not accept null\\.$#" - count: 2 - path: ../app/code/core/Mage/Core/Model/Resource/File/Storage/File.php + message: "#^Call to function is_array\\(\\) with non\\-empty\\-string will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Rule/Model/Condition/Abstract.php - - message: "#^PHPDoc tag @param for parameter \\$callbacks with type array\\|string is not subtype of native type array\\.$#" + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Resource/Iterator.php + path: ../app/code/core/Mage/Rule/Model/Condition/Abstract.php - - message: "#^Static property Mage_Core_Model_Resource_Resource\\:\\:\\$_dataVersions \\(array\\) does not accept null\\.$#" + message: "#^Property Mage_Rule_Model_Condition_Abstract\\:\\:\\$_inputType \\(string\\) on left side of \\?\\? is not nullable\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Resource/Resource.php + path: ../app/code/core/Mage/Rule/Model/Condition/Abstract.php - - message: "#^Property Mage_Core_Model_Resource_Session\\:\\:\\$_lifeTime \\(int\\) does not accept string\\|false\\.$#" + message: "#^Variable \\$valueArr in empty\\(\\) always exists and is always falsy\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Resource/Session.php + path: ../app/code/core/Mage/Rule/Model/Condition/Abstract.php - - message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:getClassName\\(\\)\\.$#" - count: 2 - path: ../app/code/core/Mage/Core/Model/Resource/Setup.php + message: "#^Method Mage_Rule_Model_Condition_Abstract\\:\\:loadArray\\(\\) invoked with 2 parameters, 1 required\\.$#" + count: 1 + path: ../app/code/core/Mage/Rule/Model/Condition/Combine.php - - message: "#^Property Mage_Core_Model_Resource_Setup\\:\\:\\$_conn \\(Varien_Db_Adapter_Pdo_Mysql\\) does not accept Varien_Db_Adapter_Interface\\|false\\.$#" + message: "#^Parameter \\#1 \\$arr of method Mage_Rule_Model_Condition_Combine\\:\\:loadArray\\(\\) expects array, \\$this\\(Mage_Rule_Model_Condition_Combine\\) given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Resource/Setup.php + path: ../app/code/core/Mage/Rule/Model/Condition/Combine.php - - message: "#^Property Mage_Core_Model_Resource_Setup\\:\\:\\$_moduleConfig \\(Mage_Core_Model_Config_Element\\) does not accept SimpleXMLElement\\.$#" + message: "#^Call to function is_int\\(\\) with string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Resource/Setup.php + path: ../app/code/core/Mage/Rule/Model/Condition/Product/Abstract.php - - message: "#^Property Mage_Core_Model_Resource_Setup\\:\\:\\$_resourceConfig \\(Mage_Core_Model_Config_Element\\) does not accept SimpleXMLElement\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Resource/Setup.php + path: ../app/code/core/Mage/Rule/Model/Condition/Product/Abstract.php - - message: "#^Binary operation \"\\.\" between string and array results in an error\\.$#" + message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Resource/Setup/Query/Modifier.php + path: ../app/code/core/Mage/Rule/Model/Condition/Product/Abstract.php - - message: "#^Parameter \\#2 \\$clear \\(bool\\) of method Mage_Core_Model_Session_Abstract_Varien\\:\\:getData\\(\\) should be compatible with parameter \\$index \\(int\\|string\\) of method Varien_Object\\:\\:getData\\(\\)$#" + message: "#^Method Mage_Rule_Model_Condition_Product_Abstract\\:\\:getAttributeObject\\(\\) should return Mage_Catalog_Model_Resource_Eav_Attribute but returns Varien_Object\\|false\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Session/Abstract/Varien.php + path: ../app/code/core/Mage/Rule/Model/Condition/Product/Abstract.php - - message: "#^Access to an undefined property Zend_Session_Namespace\\:\\:\\$data\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 2 - path: ../app/code/core/Mage/Core/Model/Session/Abstract/Zend.php - - - - message: "#^Parameter \\#2 \\$clear \\(bool\\) of method Mage_Core_Model_Session_Abstract_Zend\\:\\:getData\\(\\) should be compatible with parameter \\$index \\(int\\|string\\) of method Varien_Object\\:\\:getData\\(\\)$#" - count: 1 - path: ../app/code/core/Mage/Core/Model/Session/Abstract/Zend.php + path: ../app/code/core/Mage/Rule/Model/Condition/Product/Abstract.php - - message: "#^Method Mage_Core_Model_Store\\:\\:_getSession\\(\\) should return Mage_Core_Model_Session but returns Mage_Core_Model_Session_Abstract\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Store.php + path: ../app/code/core/Mage/Sales/Block/Adminhtml/Recurring/Profile/Edit/Form.php - - message: "#^Method Mage_Core_Model_Store\\:\\:getPriceFilter\\(\\) should return Varien_Filter_Sprintf but returns Mage_Directory_Model_Currency_Filter\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Store.php + path: ../app/code/core/Mage/Sales/Block/Adminhtml/Recurring/Profile/Edit/Form.php - - message: "#^PHPDoc type bool of property Mage_Core_Model_Store\\:\\:\\$_cacheTag is not covariant with PHPDoc type string\\|true of overridden property Mage_Core_Model_Abstract\\:\\:\\$_cacheTag\\.$#" + message: "#^Parameter \\#1 \\$renderer of static method Varien_Data_Form\\:\\:setFieldsetElementRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Store.php + path: ../app/code/core/Mage/Sales/Block/Adminhtml/Recurring/Profile/Edit/Form.php - - message: "#^Property Mage_Core_Model_Store\\:\\:\\$_priceFilter \\(Mage_Directory_Model_Currency_Filter\\) does not accept Varien_Filter_Sprintf\\.$#" + message: "#^Parameter \\#1 \\$renderer of static method Varien_Data_Form\\:\\:setFieldsetRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Store.php - - - - message: "#^Variable \\$store might not be defined\\.$#" - count: 8 - path: ../app/code/core/Mage/Core/Model/Store/Api.php + path: ../app/code/core/Mage/Sales/Block/Adminhtml/Recurring/Profile/Edit/Form.php - - message: "#^Property Mage_Core_Model_Template\\:\\:\\$_emulatedDesignConfig \\(Varien_Object\\) does not accept default value of type false\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Template.php + path: ../app/code/core/Mage/Sales/Block/Adminhtml/Recurring/Profile/View/Items.php - - message: "#^Property Mage_Core_Model_Template\\:\\:\\$_emulatedDesignConfig \\(Varien_Object\\) does not accept false\\.$#" + message: "#^Parameter \\#4 \\$after of method Varien_Data_Form_Element_Fieldset\\:\\:addField\\(\\) expects bool, string given\\.$#" count: 2 - path: ../app/code/core/Mage/Core/Model/Template.php + path: ../app/code/core/Mage/Sales/Block/Adminhtml/Report/Filter/Form.php - - message: "#^Property Mage_Core_Model_Template\\:\\:\\$_initialEnvironmentInfo \\(Varien_Object\\) does not accept null\\.$#" + message: "#^Parameter \\#4 \\$after of method Varien_Data_Form_Element_Fieldset\\:\\:addField\\(\\) expects bool, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Template.php + path: ../app/code/core/Mage/Sales/Block/Adminhtml/Report/Filter/Form/Coupon.php - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Billing_Agreement will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Translate.php + path: ../app/code/core/Mage/Sales/Block/Billing/Agreement/View.php - - message: "#^Method Mage_Core_Model_Url\\:\\:getRequest\\(\\) should return Mage_Core_Controller_Request_Http but returns Zend_Controller_Request_Http\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Resource_Order_Collection will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Url.php + path: ../app/code/core/Mage/Sales/Block/Billing/Agreement/View.php - - message: "#^PHPDoc type mixed of property Mage_Core_Model_Url_Rewrite\\:\\:\\$_cacheTag is not covariant with PHPDoc type string\\|true of overridden property Mage_Core_Model_Abstract\\:\\:\\$_cacheTag\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Core/Model/Url/Rewrite.php + path: ../app/code/core/Mage/Sales/Block/Billing/Agreement/View.php - - message: "#^Variable \\$targetUrl might not be defined\\.$#" - count: 3 - path: ../app/code/core/Mage/Core/Model/Url/Rewrite.php - - - - message: "#^Variable \\$arguments might not be defined\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Resource_Billing_Agreement_Collection will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Cron/Model/Observer.php + path: ../app/code/core/Mage/Sales/Block/Billing/Agreements.php - - message: "#^Property Mage_CurrencySymbol_Model_System_Currencysymbol\\:\\:\\$_storeId \\(string\\|null\\) does not accept int\\|null\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Resource_Order_Comment_Collection_Abstract will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/CurrencySymbol/Model/System/Currencysymbol.php + path: ../app/code/core/Mage/Sales/Block/Order/Comments.php - - message: "#^Property Mage_CurrencySymbol_Model_System_Currencysymbol\\:\\:\\$_websiteId \\(string\\|null\\) does not accept int\\|null\\.$#" + message: "#^Cannot call method setParentFilter\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" count: 1 - path: ../app/code/core/Mage/CurrencySymbol/Model/System/Currencysymbol.php + path: ../app/code/core/Mage/Sales/Block/Order/Comments.php - - message: "#^Call to an undefined method Mage_Wishlist_Model_Resource_Item_Collection\\:\\:addAttributeToSelect\\(\\)\\.$#" + message: "#^Property Mage_Sales_Block_Order_Comments\\:\\:\\$_commentCollection \\(Mage_Sales_Model_Resource_Order_Comment_Collection_Abstract\\) does not accept Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" count: 1 - path: ../app/code/core/Mage/Customer/Block/Account/Dashboard/Sidebar.php + path: ../app/code/core/Mage/Sales/Block/Order/Comments.php - - message: "#^Property Mage_Customer_Block_Account_Navigation\\:\\:\\$_activeLink \\(bool\\) does not accept string\\.$#" - count: 2 - path: ../app/code/core/Mage/Customer/Block/Account/Navigation.php + message: "#^Property Mage_Sales_Block_Order_Comments\\:\\:\\$_commentCollection \\(Mage_Sales_Model_Resource_Order_Comment_Collection_Abstract\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Block/Order/Comments.php - - message: "#^Method Mage_Customer_Block_Address_Edit\\:\\:getCountryId\\(\\) should return int but returns string\\.$#" + message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Creditmemo\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Customer/Block/Address/Edit.php + path: ../app/code/core/Mage/Sales/Block/Order/Creditmemo.php - - message: "#^Return type \\(int\\) of method Mage_Customer_Block_Address_Edit\\:\\:getCountryId\\(\\) should be compatible with return type \\(string\\) of method Mage_Directory_Block_Data\\:\\:getCountryId\\(\\)$#" + message: "#^Call to method setOrderFilter\\(\\) on an unknown class Mage_Sales_Model_Resource_Invoice_Collection\\.$#" count: 1 - path: ../app/code/core/Mage/Customer/Block/Address/Edit.php + path: ../app/code/core/Mage/Sales/Block/Order/Details.php - - message: "#^Method Mage_Customer_Block_Form_Register\\:\\:getCountryId\\(\\) should return int but returns string\\.$#" + message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Email_Creditmemo_Items\\:\\:_prepareItem\\(\\) should be compatible with return type \\(\\$this\\(Mage_Sales_Block_Items_Abstract\\)\\) of method Mage_Sales_Block_Items_Abstract\\:\\:_prepareItem\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Customer/Block/Form/Register.php + path: ../app/code/core/Mage/Sales/Block/Order/Email/Creditmemo/Items.php - - message: "#^Return type \\(int\\) of method Mage_Customer_Block_Form_Register\\:\\:getCountryId\\(\\) should be compatible with return type \\(string\\) of method Mage_Directory_Block_Data\\:\\:getCountryId\\(\\)$#" + message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Email_Invoice_Items\\:\\:_prepareItem\\(\\) should be compatible with return type \\(\\$this\\(Mage_Sales_Block_Items_Abstract\\)\\) of method Mage_Sales_Block_Items_Abstract\\:\\:_prepareItem\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Customer/Block/Form/Register.php + path: ../app/code/core/Mage/Sales/Block/Order/Email/Invoice/Items.php - - message: "#^Method Mage_Customer_Block_Newsletter\\:\\:getAction\\(\\) should return Mage_Core_Controller_Varien_Action but returns string\\.$#" + message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Email_Shipment_Items\\:\\:_prepareItem\\(\\) should be compatible with return type \\(\\$this\\(Mage_Sales_Block_Items_Abstract\\)\\) of method Mage_Sales_Block_Items_Abstract\\:\\:_prepareItem\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Customer/Block/Newsletter.php + path: ../app/code/core/Mage/Sales/Block/Order/Email/Shipment/Items.php - - message: "#^Property Mage_Customer_Helper_Data\\:\\:\\$_groups \\(Mage_Customer_Model_Entity_Group_Collection\\) does not accept Mage_Customer_Model_Resource_Group_Collection\\.$#" + message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Info\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Customer/Helper/Data.php + path: ../app/code/core/Mage/Sales/Block/Order/Info.php - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" + message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Invoice\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Customer/Model/Address/Abstract.php + path: ../app/code/core/Mage/Sales/Block/Order/Invoice.php - - message: "#^Method Mage_Customer_Model_Address_Abstract\\:\\:getStreet\\(\\) should return string but returns array\\.$#" + message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Print\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Customer/Model/Address/Abstract.php + path: ../app/code/core/Mage/Sales/Block/Order/Print.php - - message: "#^Cannot access property \\$is_default_billing on array\\.$#" - count: 2 - path: ../app/code/core/Mage/Customer/Model/Address/Api/V2.php + message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Print_Creditmemo\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Sales/Block/Order/Print/Creditmemo.php - - message: "#^Cannot access property \\$is_default_shipping on array\\.$#" - count: 2 - path: ../app/code/core/Mage/Customer/Model/Address/Api/V2.php + message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Print_Invoice\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Sales/Block/Order/Print/Invoice.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getResource\\(\\)\\.$#" + message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Print_Shipment\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Customer/Model/Api/Resource.php + path: ../app/code/core/Mage/Sales/Block/Order/Print/Shipment.php - - message: "#^Call to an undefined method Mage_Customer_Model_Api2_Customer_Address\\:\\:_getDefaultAddressesInfo\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$size of method Varien_Data_Collection\\:\\:setPageSize\\(\\) expects int, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Customer/Model/Api2/Customer/Address.php + path: ../app/code/core/Mage/Sales/Block/Order/Recent.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Shipment\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Customer/Model/Convert/Adapter/Customer.php + path: ../app/code/core/Mage/Sales/Block/Order/Shipment.php - - message: "#^Property Mage_Customer_Model_Convert_Adapter_Customer\\:\\:\\$_customerModel \\(Mage_Customer_Model_Customer\\) does not accept string\\.$#" + message: "#^Elseif condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Customer/Model/Convert/Adapter/Customer.php + path: ../app/code/core/Mage/Sales/Block/Order/Totals.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:setStore\\(\\)\\.$#" + message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_View\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Customer/Model/Convert/Parser/Customer.php + path: ../app/code/core/Mage/Sales/Block/Order/View.php - - message: "#^Variable \\$regionId might not be defined\\.$#" - count: 2 - path: ../app/code/core/Mage/Customer/Model/Convert/Parser/Customer.php + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Block/Recurring/Profile/View.php - - message: "#^Method Mage_Directory_Model_Region\\:\\:loadByName\\(\\) invoked with 1 parameter, 2 required\\.$#" + message: "#^Property Mage_Sales_Block_Recurring_Profiles\\:\\:\\$_profiles \\(Mage_Sales_Model_Resource_Recurring_Profile_Collection\\) does not accept Mage_Core_Model_Resource_Db_Collection_Abstract\\.$#" count: 1 - path: ../app/code/core/Mage/Customer/Model/Customer.php + path: ../app/code/core/Mage/Sales/Block/Recurring/Profiles.php - - message: "#^Property Mage_Customer_Model_Customer\\:\\:\\$_addresses \\(array\\\\) does not accept null\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Customer/Model/Customer.php + path: ../app/code/core/Mage/Sales/Block/Reorder/Sidebar.php - - message: "#^Property Mage_Customer_Model_Customer\\:\\:\\$_addressesCollection \\(Mage_Customer_Model_Entity_Address_Collection\\) does not accept Mage_Customer_Model_Resource_Address_Collection\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Customer/Model/Customer.php + path: ../app/code/core/Mage/Sales/Block/Reorder/Sidebar.php - - message: "#^Property Mage_Customer_Model_Customer\\:\\:\\$_addressesCollection \\(Mage_Customer_Model_Entity_Address_Collection\\) does not accept null\\.$#" + message: "#^Parameter \\#1 \\$order of method Mage_Sales_Model_Resource_Order_Collection_Abstract\\:\\:setOrderFilter\\(\\) expects int\\|Mage_Sales_Model_Order, array given\\.$#" count: 1 - path: ../app/code/core/Mage/Customer/Model/Customer.php + path: ../app/code/core/Mage/Sales/Model/Api2/Order.php - - message: "#^Property Mage_Customer_Model_Customer\\:\\:\\$_attributes \\(array\\) does not accept null\\.$#" - count: 1 - path: ../app/code/core/Mage/Customer/Model/Customer.php + message: "#^Parameter \\#2 \\$code of method Mage_Api2_Model_Resource\\:\\:_critical\\(\\) expects int\\|null, string given\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/Model/Api2/Order/Comment/Rest/Admin/V1.php - - message: "#^Parameter \\#1 \\$data \\(stdClass\\) of method Mage_Customer_Model_Customer_Api_V2\\:\\:_prepareData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Customer_Model_Customer_Api\\:\\:_prepareData\\(\\)$#" + message: "#^Variable \\$oldArea might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Customer/Model/Customer/Api/V2.php + path: ../app/code/core/Mage/Sales/Model/Api2/Order/Comment/Rest/Admin/V1.php - - message: "#^Method Mage_Customer_Model_Resource_Customer\\:\\:getWebsiteId\\(\\) should return int but returns string\\.$#" + message: "#^Variable \\$oldStore might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Customer/Model/Resource/Customer.php + path: ../app/code/core/Mage/Sales/Model/Api2/Order/Comment/Rest/Admin/V1.php - - message: "#^Cannot call method addAttributeToSelect\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:getClassName\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Customer/controllers/AccountController.php + path: ../app/code/core/Mage/Sales/Model/Config/Ordered.php - - message: "#^Cannot call method sendNewAccountEmail\\(\\) on Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Offset 'after' on array\\{\\000\\*\\000_parent\\: Varien_Simplexml_Element, \\000\\*\\000_parent\\: Varien_Simplexml_Element, before\\: array\\{\\}\\} in isset\\(\\) does not exist\\.$#" count: 1 - path: ../app/code/core/Mage/Customer/controllers/AccountController.php + path: ../app/code/core/Mage/Sales/Model/Config/Ordered.php - - message: "#^Method Mage_Customer_AccountController\\:\\:postDispatch\\(\\) should return \\$this\\(Mage_Customer_AccountController\\) but return statement is missing\\.$#" + message: "#^Offset 'before' on array\\{\\000\\*\\000_parent\\: Varien_Simplexml_Element, \\000\\*\\000_parent\\: Varien_Simplexml_Element\\} in isset\\(\\) does not exist\\.$#" count: 1 - path: ../app/code/core/Mage/Customer/controllers/AccountController.php + path: ../app/code/core/Mage/Sales/Model/Config/Ordered.php - - message: "#^Method Mage_Customer_AccountController\\:\\:preDispatch\\(\\) should return \\$this\\(Mage_Customer_AccountController\\) but empty return statement found\\.$#" + message: "#^Parameter \\#3 \\$totalConfig of method Mage_Sales_Model_Config_Ordered\\:\\:_initModelInstance\\(\\) expects array, Varien_Simplexml_Element given\\.$#" count: 1 - path: ../app/code/core/Mage/Customer/controllers/AccountController.php + path: ../app/code/core/Mage/Sales/Model/Config/Ordered.php - - message: "#^Variable \\$address might not be defined\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Customer/controllers/AddressController.php + path: ../app/code/core/Mage/Sales/Model/Convert/Quote.php - - message: "#^Method Mage_Dataflow_Model_Batch\\:\\:setParams\\(\\) should return Mage_Dataflow_Model_Batch_Abstract but returns \\$this\\(Mage_Dataflow_Model_Batch\\)\\.$#" + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Batch.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order.php - - message: "#^Property Mage_Dataflow_Model_Batch\\:\\:\\$_batchExport \\(Mage_Dataflow_Model_Batch_Export\\) does not accept string\\.$#" + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Batch.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order.php - - message: "#^Property Mage_Dataflow_Model_Batch\\:\\:\\$_batchImport \\(Mage_Dataflow_Model_Batch_Import\\) does not accept string\\.$#" + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Batch.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Address.php - - message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Abstract\\:\\:deleteCollection\\(\\)\\.$#" + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Batch/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Address.php - - message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Abstract\\:\\:getIdCollection\\(\\)\\.$#" + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Batch/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Address/Collection.php - - message: "#^Call to an undefined method Mage_Dataflow_Model_Convert_Action\\:\\:getData\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Convert.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Creditmemo.php - - message: "#^Call to an undefined method Mage_Dataflow_Model_Convert_Action_Abstract\\:\\:getClassNameByType\\(\\)\\.$#" + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Creditmemo.php - - message: "#^Call to an undefined method Mage_Dataflow_Model_Convert_Container_Interface\\:\\:setAction\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Creditmemo/Comment.php - - message: "#^Call to an undefined method Mage_Dataflow_Model_Convert_Container_Interface\\:\\:setProfile\\(\\)\\.$#" + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Creditmemo/Comment.php - - message: "#^Property Mage_Dataflow_Model_Convert_Action_Abstract\\:\\:\\$_container \\(Mage_Dataflow_Model_Convert_Container_Abstract\\) does not accept Mage_Dataflow_Model_Convert_Container_Interface\\.$#" + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Creditmemo/Comment/Collection.php - - message: "#^Undefined variable\\: \\$action$#" + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Creditmemo/Item.php - - message: "#^Call to an undefined method Mage_Dataflow_Model_Convert_Container_Interface\\:\\:getName\\(\\)\\.$#" - count: 2 - path: ../app/code/core/Mage/Dataflow/Model/Convert/Container/Collection.php + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Creditmemo/Item.php - - message: "#^Method Mage_Dataflow_Model_Convert_Mapper_Column\\:\\:getBatchImportModel\\(\\) has invalid return type Mage_Dataflow_Model_Import_Export\\.$#" + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Convert/Mapper/Column.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Creditmemo/Item/Collection.php - - message: "#^Property Mage_Dataflow_Model_Convert_Mapper_Column\\:\\:\\$_batchExport \\(Mage_Dataflow_Model_Batch_Export\\) does not accept string\\.$#" + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Convert/Mapper/Column.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Invoice.php - - message: "#^Property Mage_Dataflow_Model_Convert_Mapper_Column\\:\\:\\$_batchImport \\(Mage_Dataflow_Model_Batch_Import\\) does not accept string\\.$#" + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Convert/Mapper/Column.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Invoice.php - - message: "#^Property Mage_Dataflow_Model_Convert_Parser_Abstract\\:\\:\\$_batchExport \\(Mage_Dataflow_Model_Batch_Export\\) does not accept string\\.$#" + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Convert/Parser/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Invoice/Comment.php - - message: "#^Property Mage_Dataflow_Model_Convert_Parser_Abstract\\:\\:\\$_batchImport \\(Mage_Dataflow_Model_Batch_Import\\) does not accept string\\.$#" + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Convert/Parser/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Invoice/Comment.php - - message: "#^Argument of an invalid type string\\|false supplied for foreach, only iterables are supported\\.$#" + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Convert/Parser/Csv.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Invoice/Comment/Collection.php - - message: "#^Method Mage_Dataflow_Model_Convert_Profile_Abstract\\:\\:run\\(\\) should return Mage_Dataflow_Model_Convert_Profile_Abstract but empty return statement found\\.$#" - count: 2 - path: ../app/code/core/Mage/Dataflow/Model/Convert/Profile/Abstract.php + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Invoice/Item.php - - message: "#^Undefined variable\\: \\$profile$#" + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Convert/Profile/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Invoice/Item.php - - message: "#^Variable \\$parseFileXml might not be defined\\.$#" + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Profile.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Invoice/Item/Collection.php - - message: "#^Variable \\$path might not be defined\\.$#" - count: 2 - path: ../app/code/core/Mage/Dataflow/Model/Profile.php + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Item.php - - message: "#^Property Mage_Directory_Helper_Data\\:\\:\\$_countryCollection \\(Mage_Directory_Model_Resource_Country_Collection\\) does not accept Mage_Core_Model_Resource_Db_Collection_Abstract\\.$#" + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Directory/Helper/Data.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Item.php - - message: "#^Method Mage_Directory_Model_Country\\:\\:getFormat\\(\\) should return Mage_Directory_Model_Country_Format but returns null\\.$#" + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Directory/Model/Country.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Item/Collection.php - - message: "#^Variable \\$response might not be defined\\.$#" + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Directory/Model/Currency/Import/Fixerio.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Payment.php - - message: "#^Method Mage_Directory_Model_Currency_Import_Webservicex\\:\\:_convert\\(\\) should return float\\|null but return statement is missing\\.$#" + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Directory/Model/Currency/Import/Webservicex.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Payment.php - - message: "#^Variable \\$importModel might not be defined\\.$#" - count: 2 - path: ../app/code/core/Mage/Directory/Model/Observer.php + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Payment/Collection.php - - message: "#^Variable \\$allowCountries in empty\\(\\) always exists and is not falsy\\.$#" + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Directory/Model/Resource/Country/Collection.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Shipment.php - - message: "#^Property Mage_Downloadable_Block_Adminhtml_Catalog_Product_Edit_Tab_Downloadable_Links\\:\\:\\$_purchasedSeparatelyAttribute \\(Mage_Catalog_Model_Resource_Eav_Attribute\\) does not accept Mage_Eav_Model_Entity_Attribute\\.$#" + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Downloadable/Block/Adminhtml/Catalog/Product/Edit/Tab/Downloadable/Links.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Shipment.php - - message: "#^Cannot call method streamRead\\(\\) on resource\\.$#" + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Downloadable/Helper/Download.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Shipment/Comment.php - - message: "#^Cannot call method streamStat\\(\\) on resource\\.$#" + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Downloadable/Helper/Download.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Shipment/Comment.php - - message: "#^Property Mage_Downloadable_Helper_Download\\:\\:\\$_handle \\(resource\\) does not accept Varien_Io_File\\.$#" + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Downloadable/Helper/Download.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Shipment/Comment/Collection.php - - message: "#^Cannot access offset 'file' on bool\\|void\\.$#" + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Downloadable/Model/Link/Api.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Shipment/Item.php - - message: "#^Offset 'file' does not exist on array\\{status\\: 'new'\\}\\.$#" - count: 2 - path: ../app/code/core/Mage/Downloadable/Model/Link/Api.php + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Shipment/Item.php - - message: "#^Variable \\$downloadableModel might not be defined\\.$#" - count: 3 - path: ../app/code/core/Mage/Downloadable/Model/Link/Api.php + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Shipment/Item/Collection.php - - message: "#^Property Varien_File_Uploader\\:\\:\\$_uploadType \\(string\\) does not accept int\\.$#" + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Downloadable/Model/Link/Api/Uploader.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Shipment/Track.php - - message: "#^Parameter \\#2 \\$resource \\(object\\) of method Mage_Downloadable_Model_Link_Api_V2\\:\\:add\\(\\) should be compatible with parameter \\$resource \\(array\\) of method Mage_Downloadable_Model_Link_Api\\:\\:add\\(\\)$#" + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Downloadable/Model/Link/Api/V2.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Shipment/Track.php - - message: "#^Cannot access offset 'tmp_name' on bool\\|void\\.$#" + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" count: 2 - path: ../app/code/core/Mage/Downloadable/controllers/Adminhtml/Downloadable/FileController.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Shipment/Track/Collection.php - - message: "#^Method Mage_Customer_Model_Session\\:\\:setBeforeAuthUrl\\(\\) invoked with 2 parameters, 1 required\\.$#" + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Downloadable/controllers/DownloadController.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Status/History.php - - message: "#^Return type \\(void\\) of method Mage_Downloadable_FileController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Controller_Action\\)\\) of method Mage_Adminhtml_Controller_Action\\:\\:preDispatch\\(\\)$#" + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Downloadable/controllers/FileController.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Status/History.php - - message: "#^Return type \\(void\\) of method Mage_Downloadable_Product_EditController\\:\\:preDispatch\\(\\) should be compatible with return type \\(Mage_Adminhtml_Controller_Action\\) of method Mage_Adminhtml_Catalog_ProductController\\:\\:preDispatch\\(\\)$#" + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Downloadable/controllers/Product/EditController.php + path: ../app/code/core/Mage/Sales/Model/Entity/Order/Status/History/Collection.php - - message: "#^Property Zend_Validate_InArray\\:\\:\\$_messageTemplates \\(array\\) does not accept null\\.$#" - count: 1 - path: ../app/code/core/Mage/Eav/Model/Adminhtml/System/Config/Source/Inputtype/Validator.php + message: "#^Call to an undefined method Mage_Sales_Model_Resource_Quote_Collection\\:\\:addAttributeToSelect\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/Model/Entity/Quote.php - - message: "#^Call to an undefined method Mage_Eav_Model_Resource_Entity_Attribute\\:\\:getUsedInForms\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Attribute.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote.php - - message: "#^Method Mage_Eav_Model_Attribute_Data_Abstract\\:\\:setRequestScope\\(\\) should return string but returns \\$this\\(Mage_Eav_Model_Attribute_Data_Abstract\\)\\.$#" + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Attribute/Data/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote.php - - message: "#^Property Mage_Eav_Model_Attribute_Data_Abstract\\:\\:\\$_attribite \\(Mage_Eav_Model_Attribute\\) does not accept Mage_Eav_Model_Entity_Attribute_Abstract\\.$#" + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Attribute/Data/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address.php - - message: "#^Property Mage_Eav_Model_Attribute_Data_Abstract\\:\\:\\$_dateFilterFormat \\(string\\) does not accept null\\.$#" + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Attribute/Data/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getEntityTypeCode\\(\\)\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Attribute/Data/File.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Backend/Region.php - - message: "#^Call to an undefined method Mage_Core_Model_Resource_Abstract\\:\\:getDefaultAttributes\\(\\)\\.$#" + message: "#^Return type \\(void\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Backend_Region\\:\\:beforeSave\\(\\) should be compatible with return type \\(\\$this\\(Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\)\\) of method Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\:\\:beforeSave\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Config.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Backend/Region.php - - message: "#^Cannot call method loadByCode\\(\\) on Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Custbalance\\)\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Custbalance\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Config.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Frontend/Custbalance.php - - message: "#^Method Mage_Eav_Model_Config\\:\\:getAttribute\\(\\) should return Mage_Eav_Model_Entity_Attribute_Abstract\\|false but returns Mage_Eav_Model_Entity_Attribute_Interface\\.$#" + message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Discount\\)\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Discount\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Config.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Frontend/Discount.php - - message: "#^Property Mage_Eav_Model_Config\\:\\:\\$_attributeData \\(array\\) does not accept null\\.$#" + message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Grand\\)\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Grand\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Config.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Frontend/Grand.php - - message: "#^Property Mage_Eav_Model_Config\\:\\:\\$_entityData \\(array\\) does not accept null\\.$#" + message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Shipping\\)\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Shipping\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Config.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Frontend/Shipping.php - - message: "#^Property Mage_Eav_Model_Config\\:\\:\\$_objects \\(array\\) does not accept null\\.$#" + message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Subtotal\\)\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Subtotal\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Config.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Frontend/Subtotal.php - - message: "#^Property Mage_Eav_Model_Config\\:\\:\\$_references \\(array\\) does not accept null\\.$#" + message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Tax\\)\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Tax\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Config.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Frontend/Tax.php - - message: "#^Method Mage_Eav_Model_Convert_Adapter_Entity\\:\\:_getCollectionForLoad\\(\\) should return Mage_Eav_Model_Entity_Collection but returns Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Convert/Adapter/Entity.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Collection.php - - message: "#^Variable \\$defBind might not be defined\\.$#" + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Convert/Adapter/Entity.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Item.php - - message: "#^Variable \\$entityIds might not be defined\\.$#" + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Convert/Adapter/Entity.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Item.php - - message: "#^Binary operation \"\\.\" between Mage_Eav_Model_Entity_Interface and '_collection' results in an error\\.$#" + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Item/Collection.php - - message: "#^Cannot call method addData\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Rate.php - - message: "#^Cannot call method getId\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Rate.php - - message: "#^Variable \\$collection might not be defined\\.$#" + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Rate/Collection.php - - message: "#^Variable \\$entity might not be defined\\.$#" + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Item.php - - message: "#^Method Mage_Eav_Model_Entity_Abstract\\:\\:_getReadAdapter\\(\\) should return Magento_Db_Adapter_Pdo_Mysql but returns Varien_Db_Adapter_Pdo_Mysql\\.$#" + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Item.php - - message: "#^Method Mage_Eav_Model_Entity_Abstract\\:\\:_getWriteAdapter\\(\\) should return Magento_Db_Adapter_Pdo_Mysql but returns Varien_Db_Adapter_Pdo_Mysql\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Item/Collection.php - - message: "#^Property Mage_Eav_Model_Entity_Abstract\\:\\:\\$_read \\(Varien_Db_Adapter_Pdo_Mysql\\) does not accept Varien_Db_Adapter_Interface\\|false\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Item/Collection.php - - message: "#^Property Mage_Eav_Model_Entity_Abstract\\:\\:\\$_read \\(Varien_Db_Adapter_Pdo_Mysql\\) does not accept string\\|Zend_Db_Adapter_Abstract\\.$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Item/Collection.php - - message: "#^Property Mage_Eav_Model_Entity_Abstract\\:\\:\\$_write \\(Varien_Db_Adapter_Pdo_Mysql\\) does not accept Varien_Db_Adapter_Interface\\|false\\.$#" + message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Payment.php - - message: "#^Property Mage_Eav_Model_Entity_Abstract\\:\\:\\$_write \\(Varien_Db_Adapter_Pdo_Mysql\\) does not accept string\\|Zend_Db_Adapter_Abstract\\.$#" + message: "#^Parameter \\#2 \\$write of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract\\|null, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Payment.php - - message: "#^Variable \\$attributeCode might not be defined\\.$#" + message: "#^Parameter \\#2 \\$condition of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects array\\|string\\|null, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Payment/Collection.php - - message: "#^Variable \\$id might not be defined\\.$#" + message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'delete' given\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php - - - - message: "#^Variable \\$instance might not be defined\\.$#" - count: 2 - path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Observer.php - - message: "#^Variable \\$method might not be defined\\.$#" - count: 2 - path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Resource_Order_Invoice_Collection will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order.php - - message: "#^Variable \\$part might not be defined\\.$#" - count: 2 - path: ../app/code/core/Mage/Eav/Model/Entity/Abstract.php + message: "#^Call to function is_null\\(\\) with iterable\\&Mage_Sales_Model_Resource_Order_Address_Collection will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order.php - - message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Abstract\\:\\:getIdByCode\\(\\)\\.$#" + message: "#^Call to function is_null\\(\\) with iterable\\&Mage_Sales_Model_Resource_Order_Item_Collection will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Order.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Abstract\\:\\:getFlatUpdateSelect\\(\\) should return \\$this\\(Mage_Eav_Model_Entity_Attribute_Abstract\\)\\|Varien_Db_Select but returns null\\.$#" + message: "#^Call to function is_null\\(\\) with iterable\\&Mage_Sales_Model_Resource_Order_Payment_Collection will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Order.php - - message: "#^Property Mage_Eav_Model_Entity_Attribute_Abstract\\:\\:\\$_entity \\(Mage_Eav_Model_Entity_Abstract\\) does not accept Mage_Eav_Model_Entity_Type\\.$#" + message: "#^Call to function is_null\\(\\) with iterable\\&Mage_Sales_Model_Resource_Order_Status_History_Collection will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Order.php - - message: "#^Return type \\(\\$this\\(Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\)\\) of method Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\:\\:setValueId\\(\\) should be compatible with return type \\(int\\) of method Mage_Eav_Model_Entity_Attribute_Backend_Interface\\:\\:setValueId\\(\\)$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Backend/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Order.php - - message: "#^Variable \\$out in empty\\(\\) always exists and is not falsy\\.$#" + message: "#^Parameter \\#1 \\$prefix of function uniqid expects string, int\\<0, max\\> given\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Frontend/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Order.php - - message: "#^Call to an undefined method Mage_Eav_Model_Resource_Entity_Attribute_Group\\:\\:deleteGroups\\(\\)\\.$#" + message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_addresses \\(iterable\\&Mage_Sales_Model_Resource_Order_Address_Collection\\) does not accept null\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Group.php + path: ../app/code/core/Mage/Sales/Model/Order.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:getStoreId\\(\\)\\.$#" + message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_creditmemos \\(\\(iterable\\&Mage_Sales_Model_Resource_Order_Creditmemo_Collection\\)\\|false\\) does not accept null\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Source/Table.php + path: ../app/code/core/Mage/Sales/Model/Order.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute_Interface\\:\\:getAttributeCode\\(\\)\\.$#" + message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_invoices \\(Mage_Sales_Model_Resource_Order_Invoice_Collection\\) does not accept null\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Order.php - - message: "#^Constructor of class Mage_Eav_Model_Entity_Collection_Abstract has an unused parameter \\$resource\\.$#" - count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_items \\(iterable\\&Mage_Sales_Model_Resource_Order_Item_Collection\\) does not accept null\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/Model/Order.php - - message: "#^Variable \\$attrArr might not be defined\\.$#" + message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_payments \\(iterable\\&Mage_Sales_Model_Resource_Order_Payment_Collection\\) does not accept null\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Order.php - - message: "#^Variable \\$entity might not be defined\\.$#" + message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_shipments \\(Mage_Sales_Model_Resource_Order_Shipment_Collection\\|false\\) does not accept null\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Order.php - - message: "#^Variable \\$query might not be defined\\.$#" - count: 2 - path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_statusHistory \\(iterable\\&Mage_Sales_Model_Resource_Order_Status_History_Collection\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order.php - - message: "#^Variable \\$select might not be defined\\.$#" - count: 2 - path: ../app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_tracks \\(Mage_Sales_Model_Resource_Order_Shipment_Track_Collection\\) does not accept null\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order.php - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" + message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_tracks \\(Mage_Sales_Model_Resource_Order_Shipment_Track_Collection\\) in empty\\(\\) is not falsy\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + path: ../app/code/core/Mage/Sales/Model/Order.php - - message: "#^Binary operation \"\\+\" between string and 1 results in an error\\.$#" - count: 3 - path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order/Address.php - - message: "#^Binary operation \"\\+\" between string and 10 results in an error\\.$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + path: ../app/code/core/Mage/Sales/Model/Order/Address.php - - message: "#^Call to an undefined method Varien_Db_Adapter_Interface\\:\\:lastInsertId\\(\\)\\.$#" + message: "#^Variable \\$oldArea might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + path: ../app/code/core/Mage/Sales/Model/Order/Api.php - - message: "#^Method Mage_Eav_Model_Entity_Setup\\:\\:getDefaultAttributeGroupId\\(\\) should return int but returns string\\.$#" + message: "#^Variable \\$oldStore might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + path: ../app/code/core/Mage/Sales/Model/Order/Api.php - - message: "#^Method Mage_Eav_Model_Entity_Setup\\:\\:getDefaultAttributeSetId\\(\\) should return int but returns string\\.$#" + message: "#^Call to function is_null\\(\\) with iterable\\&Mage_Sales_Model_Resource_Order_Creditmemo_Comment_Collection will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + path: ../app/code/core/Mage/Sales/Model/Order/Creditmemo.php - - message: "#^Variable \\$connection might not be defined\\.$#" + message: "#^Parameter \\#1 \\$string of function trim expects string, float given\\.$#" count: 2 - path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php + path: ../app/code/core/Mage/Sales/Model/Order/Creditmemo.php - - message: "#^Method Mage_Eav_Model_Resource_Entity_Attribute\\:\\:_getMaxSortOrder\\(\\) should return int but returns string\\.$#" + message: "#^Property Mage_Sales_Model_Order_Creditmemo\\:\\:\\$_items \\(iterable\\&Mage_Sales_Model_Resource_Order_Creditmemo_Item_Collection\\) in empty\\(\\) is not falsy\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Resource/Entity/Attribute.php + path: ../app/code/core/Mage/Sales/Model/Order/Creditmemo.php - - message: "#^Method Mage_Eav_Model_Resource_Entity_Attribute\\:\\:getIdByCode\\(\\) should return int but returns string\\.$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Resource/Entity/Attribute.php + path: ../app/code/core/Mage/Sales/Model/Order/Creditmemo.php - - message: "#^Method Mage_Eav_Model_Resource_Entity_Attribute_Group\\:\\:_getMaxSortOrder\\(\\) should return int but returns string\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Resource/Entity/Attribute/Group.php + path: ../app/code/core/Mage/Sales/Model/Order/Creditmemo/Comment.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:getStoreId\\(\\)\\.$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Resource/Entity/Attribute/Option.php + path: ../app/code/core/Mage/Sales/Model/Order/Creditmemo/Comment.php - - message: "#^Method Mage_Eav_Model_Resource_Entity_Attribute_Set\\:\\:getDefaultGroupId\\(\\) should return int\\|null but returns string\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Eav/Model/Resource/Entity/Attribute/Set.php + path: ../app/code/core/Mage/Sales/Model/Order/Creditmemo/Comment.php - - message: "#^Variable \\$store might not be defined\\.$#" - count: 2 - path: ../app/code/core/Mage/Eav/Model/Resource/Form/Attribute/Collection.php + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order/Creditmemo/Item.php - - message: "#^PHPDoc tag @param for parameter \\$object with type Mage_Eav_Model_Resource_Form_Type is incompatible with native type Mage_Core_Model_Abstract\\.$#" - count: 2 - path: ../app/code/core/Mage/Eav/Model/Resource/Form/Type.php + message: "#^Right side of && is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order/Creditmemo/Item.php - - message: "#^Method Mage_GiftMessage_Model_Api_V2\\:\\:_prepareData\\(\\) should return array but returns mixed\\.$#" + message: "#^Parameter \\#2 \\$options of method Mage_Directory_Model_Currency\\:\\:format\\(\\) expects array, null given\\.$#" count: 1 - path: ../app/code/core/Mage/GiftMessage/Model/Api/V2.php + path: ../app/code/core/Mage/Sales/Model/Order/Creditmemo/Total/Shipping.php - - message: "#^Return type \\(stdClass\\) of method Mage_GiftMessage_Model_Api_V2\\:\\:_setGiftMessage\\(\\) should be compatible with return type \\(array\\) of method Mage_GiftMessage_Model_Api\\:\\:_setGiftMessage\\(\\)$#" + message: "#^Call to function is_null\\(\\) with iterable\\&Mage_Sales_Model_Resource_Order_Invoice_Comment_Collection will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/GiftMessage/Model/Api/V2.php + path: ../app/code/core/Mage/Sales/Model/Order/Invoice.php - - message: "#^Method Mage_GiftMessage_Model_Message\\:\\:getEntityModelByType\\(\\) should return Mage_Eav_Model_Entity_Abstract but returns Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Cannot call method addAttributeToFilter\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" count: 1 - path: ../app/code/core/Mage/GiftMessage/Model/Message.php + path: ../app/code/core/Mage/Sales/Model/Order/Invoice.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:setGiftMessageId\\(\\)\\.$#" + message: "#^Property Mage_Sales_Model_Order_Invoice\\:\\:\\$_comments \\(iterable\\&Mage_Sales_Model_Resource_Order_Invoice_Comment_Collection\\) does not accept null\\.$#" count: 1 - path: ../app/code/core/Mage/GiftMessage/controllers/IndexController.php + path: ../app/code/core/Mage/Sales/Model/Order/Invoice.php - - message: "#^Call to an undefined method Mage_GiftMessage_IndexController\\:\\:_getMappedType\\(\\)\\.$#" + message: "#^Property Mage_Sales_Model_Order_Invoice\\:\\:\\$_items \\(iterable\\&Mage_Sales_Model_Resource_Order_Invoice_Item_Collection\\) does not accept null\\.$#" count: 1 - path: ../app/code/core/Mage/GiftMessage/controllers/IndexController.php + path: ../app/code/core/Mage/Sales/Model/Order/Invoice.php - - message: "#^Method Mage_Eav_Model_Entity_Abstract\\:\\:load\\(\\) invoked with 1 parameter, 2\\-3 required\\.$#" + message: "#^Property Mage_Sales_Model_Order_Invoice\\:\\:\\$_items \\(iterable\\&Mage_Sales_Model_Resource_Order_Invoice_Item_Collection\\) in empty\\(\\) is not falsy\\.$#" count: 1 - path: ../app/code/core/Mage/GiftMessage/controllers/IndexController.php + path: ../app/code/core/Mage/Sales/Model/Order/Invoice.php - - message: "#^Method Mage_GoogleAnalytics_Block_Ga\\:\\:_getOrdersTrackingCodeAnalytics\\(\\) should return string but empty return statement found\\.$#" + message: "#^Property Mage_Sales_Model_Order_Invoice\\:\\:\\$_order \\(Mage_Sales_Model_Order\\) does not accept null\\.$#" count: 1 - path: ../app/code/core/Mage/GoogleAnalytics/Block/Ga.php + path: ../app/code/core/Mage/Sales/Model/Order/Invoice.php - - message: "#^Method Mage_GoogleAnalytics_Block_Ga\\:\\:_getOrdersTrackingCodeUniversal\\(\\) should return string but empty return statement found\\.$#" + message: "#^Property Varien_Object\\:\\:\\$_origData \\(array\\) does not accept null\\.$#" count: 1 - path: ../app/code/core/Mage/GoogleAnalytics/Block/Ga.php + path: ../app/code/core/Mage/Sales/Model/Order/Invoice.php - - message: "#^Method Mage_GoogleAnalytics_Helper_Data\\:\\:isUseUniversalAnalytics\\(\\) should return string but returns bool\\.$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/GoogleAnalytics/Helper/Data.php + path: ../app/code/core/Mage/Sales/Model/Order/Invoice.php - - message: "#^Return type \\(void\\) of method Mage_GoogleCheckout_Model_Payment\\:\\:authorize\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Abstract\\)\\) of method Mage_Payment_Model_Method_Abstract\\:\\:authorize\\(\\)$#" + message: "#^Parameter \\#1 \\$incrementId of method Mage_Sales_Model_Order_Invoice\\:\\:loadByIncrementId\\(\\) expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/GoogleCheckout/Model/Payment.php + path: ../app/code/core/Mage/Sales/Model/Order/Invoice/Api.php - - message: "#^Return type \\(void\\) of method Mage_GoogleCheckout_Model_Payment\\:\\:cancel\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Abstract\\)\\) of method Mage_Payment_Model_Method_Abstract\\:\\:cancel\\(\\)$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/GoogleCheckout/Model/Payment.php + path: ../app/code/core/Mage/Sales/Model/Order/Invoice/Comment.php - - message: "#^Return type \\(void\\) of method Mage_GoogleCheckout_Model_Payment\\:\\:capture\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Abstract\\)\\) of method Mage_Payment_Model_Method_Abstract\\:\\:capture\\(\\)$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/GoogleCheckout/Model/Payment.php + path: ../app/code/core/Mage/Sales/Model/Order/Invoice/Comment.php - - message: "#^Return type \\(void\\) of method Mage_GoogleCheckout_Model_Payment\\:\\:refund\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Abstract\\)\\) of method Mage_Payment_Model_Method_Abstract\\:\\:refund\\(\\)$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/GoogleCheckout/Model/Payment.php + path: ../app/code/core/Mage/Sales/Model/Order/Invoice/Comment.php - - message: "#^Return type \\(void\\) of method Mage_GoogleCheckout_Model_Payment\\:\\:void\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Abstract\\)\\) of method Mage_Payment_Model_Method_Abstract\\:\\:void\\(\\)$#" + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Order_Item will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/GoogleCheckout/Model/Payment.php + path: ../app/code/core/Mage/Sales/Model/Order/Invoice/Item.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" - count: 4 - path: ../app/code/core/Mage/ImportExport/Block/Adminhtml/Export/Filter.php + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/Model/Order/Invoice/Item.php - - message: "#^Return type \\(false\\) of method Mage_ImportExport_Block_Adminhtml_Export_Filter\\:\\:getRowUrl\\(\\) should be compatible with return type \\(string\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:getRowUrl\\(\\)$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Block/Adminhtml/Export/Filter.php + path: ../app/code/core/Mage/Sales/Model/Order/Invoice/Item.php - - message: "#^Method Mage_ImportExport_Helper_Data\\:\\:getMaxUploadSize\\(\\) should return int but returns string\\|false\\.$#" + message: "#^Property Mage_Sales_Model_Order_Invoice_Item\\:\\:\\$_orderItem \\(Mage_Sales_Model_Order_Item\\) does not accept Varien_Object\\|null\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Helper/Data.php + path: ../app/code/core/Mage/Sales/Model/Order/Invoice/Item.php - - message: "#^Property Mage_ImportExport_Model_Export\\:\\:\\$_entityAdapter \\(Mage_ImportExport_Model_Export_Entity_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Export.php + path: ../app/code/core/Mage/Sales/Model/Order/Invoice/Item.php - - message: "#^Property Mage_ImportExport_Model_Export\\:\\:\\$_writer \\(Mage_ImportExport_Model_Export_Adapter_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Call to an undefined method Mage_Catalog_Model_Product_Type_Abstract\\:\\:getForceApplyDiscountToParentItem\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Export.php + path: ../app/code/core/Mage/Sales/Model/Order/Item.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Order will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Order/Item.php - - message: "#^Property Mage_ImportExport_Model_Export_Entity_Abstract\\:\\:\\$_connection \\(Varien_Db_Adapter_Pdo_Mysql\\) does not accept Varien_Db_Adapter_Interface\\|false\\.$#" + message: "#^Result of && is always false\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Order/Item.php - - message: "#^Property Mage_ImportExport_Model_Export_Entity_Abstract\\:\\:\\$_entityTypeId \\(int\\) does not accept string\\|null\\.$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Order/Item.php - - message: "#^Call to an undefined method Mage_Customer_Model_Entity_Attribute\\:\\:getFrontendInput\\(\\)\\.$#" + message: "#^If condition is always false\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Customer.php + path: ../app/code/core/Mage/Sales/Model/Order/Payment.php - - message: "#^Call to an undefined method Mage_Customer_Model_Entity_Attribute\\:\\:getSource\\(\\)\\.$#" - count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Customer.php + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/Model/Order/Payment.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Method Mage_Sales_Model_Order_Payment\\:\\:_addTransaction\\(\\) should return Mage_Sales_Model_Order_Payment_Transaction\\|null but return statement is missing\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Customer.php + path: ../app/code/core/Mage/Sales/Model/Order/Payment.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:addCategoryIds\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$invoice of method Mage_Sales_Model_Order_Payment\\:\\:capture\\(\\) expects Mage_Sales_Model_Order_Invoice, null given\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php + path: ../app/code/core/Mage/Sales/Model/Order/Payment.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:setStoreId\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$setFailsafe of method Mage_Sales_Model_Order_Payment_Transaction\\:\\:isFailsafe\\(\\) expects null, bool given\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/Model/Order/Payment.php + + - + message: "#^Parameter \\#1 \\$txnId of method Mage_Sales_Model_Order_Payment\\:\\:_lookupTransaction\\(\\) expects string, false given\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php + path: ../app/code/core/Mage/Sales/Model/Order/Payment.php - - message: "#^Variable \\$collection might not be defined\\.$#" + message: "#^Parameter \\#1 \\$txnId of method Mage_Sales_Model_Order_Payment\\:\\:_lookupTransaction\\(\\) expects string, null given\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php + path: ../app/code/core/Mage/Sales/Model/Order/Payment.php - - message: "#^Cannot access offset 'file' on bool\\|void\\.$#" + message: "#^Property Mage_Sales_Model_Order_Payment\\:\\:\\$_canVoidLookup \\(string\\) does not accept bool\\.$#" count: 2 - path: ../app/code/core/Mage/ImportExport/Model/Import.php + path: ../app/code/core/Mage/Sales/Model/Order/Payment.php - - message: "#^Cannot access offset 'path' on bool\\|void\\.$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Import.php + path: ../app/code/core/Mage/Sales/Model/Order/Payment.php - - message: "#^Property Mage_ImportExport_Model_Import\\:\\:\\$_entityAdapter \\(Mage_ImportExport_Model_Import_Entity_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Import.php + path: ../app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - message: "#^Static property Mage_ImportExport_Model_Import\\:\\:\\$_entityInvalidatedIndexes \\(Mage_ImportExport_Model_Import_Entity_Abstract\\) does not accept default value of type array\\\\>\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Import.php + path: ../app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php + + - + message: "#^Parameter \\#1 \\$order of method Mage_Sales_Model_Order_Payment_Transaction\\:\\:setOrder\\(\\) expects bool\\|Mage_Sales_Model_Order_Payment\\|null, Mage_Sales_Model_Order given\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - message: "#^Property Mage_ImportExport_Model_Import_Entity_Abstract\\:\\:\\$_connection \\(Varien_Convert_Adapter_Interface\\) does not accept Varien_Db_Adapter_Interface\\|false\\.$#" + message: "#^Parameter \\#1 \\$order of method Mage_Sales_Model_Resource_Order_Collection_Abstract\\:\\:setOrderFilter\\(\\) expects int\\|Mage_Sales_Model_Order, Mage_Sales_Model_Order_Payment given\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - message: "#^Property Mage_ImportExport_Model_Import_Entity_Abstract\\:\\:\\$_entityTypeId \\(int\\) does not accept string\\|null\\.$#" + message: "#^Parameter \\#1 \\$shouldSave of method Mage_Sales_Model_Order_Payment_Transaction\\:\\:closeAuthorization\\(\\) expects bool, string given\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - message: "#^Call to an undefined method Mage_Customer_Model_Entity_Attribute\\:\\:getBackend\\(\\)\\.$#" - count: 3 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php + message: "#^Parameter \\#1 \\$txnId of method Mage_Sales_Model_Order_Payment_Transaction\\:\\:_beforeLoadByTxnId\\(\\) expects int, string given\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:insertMultiple\\(\\)\\.$#" + message: "#^Property Mage_Sales_Model_Order_Payment_Transaction\\:\\:\\$_identifiedChildren \\(array\\) does not accept false\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php + path: ../app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:insertOnDuplicate\\(\\)\\.$#" + message: "#^Property Mage_Sales_Model_Order_Payment_Transaction\\:\\:\\$_order \\(Mage_Sales_Model_Order_Payment\\) does not accept Mage_Sales_Model_Order\\.$#" count: 2 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php + path: ../app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:query\\(\\)\\.$#" + message: "#^Property Mage_Sales_Model_Order_Payment_Transaction\\:\\:\\$_order \\(Mage_Sales_Model_Order_Payment\\) does not accept false\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php + path: ../app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:quoteInto\\(\\)\\.$#" + message: "#^Property Mage_Sales_Model_Order_Payment_Transaction\\:\\:\\$_parentTransaction \\(\\$this\\(Mage_Sales_Model_Order_Payment_Transaction\\)\\) does not accept Mage_Sales_Model_Order_Payment_Transaction\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php + path: ../app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - message: "#^Variable \\$entityId might not be defined\\.$#" - count: 4 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php + message: "#^Property Mage_Sales_Model_Order_Payment_Transaction\\:\\:\\$_parentTransaction \\(\\$this\\(Mage_Sales_Model_Order_Payment_Transaction\\)\\) does not accept false\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - message: "#^Call to an undefined method Mage_Customer_Model_Entity_Attribute\\:\\:getBackend\\(\\)\\.$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer/Address.php + path: ../app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:delete\\(\\)\\.$#" + message: "#^Ternary operator condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer/Address.php + path: ../app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:insertMultiple\\(\\)\\.$#" + message: "#^If condition is always false\\.$#" count: 2 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer/Address.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:insertOnDuplicate\\(\\)\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer/Address.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:quoteInto\\(\\)\\.$#" + message: "#^Instanceof between Mage_Core_Model_Abstract\\|false and Mage_Sales_Model_Order_Pdf_Total_Default will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Customer/Address.php - - - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:delete\\(\\)\\.$#" - count: 8 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:fetchPairs\\(\\)\\.$#" - count: 2 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + message: "#^Method Mage_Sales_Model_Order_Pdf_Abstract\\:\\:getAlignCenter\\(\\) should return int but returns float\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:insertMultiple\\(\\)\\.$#" - count: 3 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + message: "#^Method Mage_Sales_Model_Order_Pdf_Abstract\\:\\:getAlignRight\\(\\) should return int but returns float\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:insertOnDuplicate\\(\\)\\.$#" - count: 14 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + message: "#^Variable \\$order might not be defined\\.$#" + count: 12 + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:query\\(\\)\\.$#" + message: "#^Variable \\$shipment might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:quoteInto\\(\\)\\.$#" - count: 12 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + message: "#^Variable \\$shippingAddress might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:select\\(\\)\\.$#" - count: 2 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + message: "#^Variable \\$shippingMethod might not be defined\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php - - message: "#^Method Mage_ImportExport_Model_Import_Entity_Product\\:\\:getConnection\\(\\) should return Varien_Db_Adapter_Pdo_Mysql but returns Varien_Convert_Adapter_Interface\\.$#" + message: "#^Parameter \\#1 \\$object of method Mage_Sales_Model_Order_Pdf_Abstract\\:\\:_setFontBold\\(\\) expects Zend_Pdf_Page, Zend_Pdf_Style given\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Creditmemo.php - - message: "#^Property Mage_ImportExport_Model_Import_Entity_Product\\:\\:\\$_urlKeyAttributeId \\(int\\) does not accept string\\.$#" + message: "#^Parameter \\#2 \\$store of method Mage_Sales_Model_Order_Pdf_Abstract\\:\\:insertAddress\\(\\) expects null, Mage_Core_Model_Store given\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Creditmemo.php - - message: "#^Variable \\$prevOptionId might not be defined\\.$#" - count: 4 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + message: "#^Parameter \\#2 \\$store of method Mage_Sales_Model_Order_Pdf_Abstract\\:\\:insertLogo\\(\\) expects null, Mage_Core_Model_Store given\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Creditmemo.php - - message: "#^Variable \\$rowSku might not be defined\\.$#" + message: "#^Variable \\$creditmemo might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Creditmemo.php - - message: "#^Variable \\$sku might not be defined\\.$#" - count: 2 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + message: "#^Parameter \\#1 \\$object of method Mage_Sales_Model_Order_Pdf_Abstract\\:\\:_setFontBold\\(\\) expects Zend_Pdf_Page, Zend_Pdf_Style given\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Invoice.php - - message: "#^Variable \\$productId might not be defined\\.$#" - count: 4 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Configurable.php + message: "#^Parameter \\#2 \\$store of method Mage_Sales_Model_Order_Pdf_Abstract\\:\\:insertAddress\\(\\) expects null, Mage_Core_Model_Store given\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Invoice.php - - message: "#^Variable \\$productSuperAttrId might not be defined\\.$#" + message: "#^Parameter \\#2 \\$store of method Mage_Sales_Model_Order_Pdf_Abstract\\:\\:insertLogo\\(\\) expects null, Mage_Core_Model_Store given\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Configurable.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Invoice.php - - message: "#^Variable \\$productData might not be defined\\.$#" - count: 3 - path: ../app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Grouped.php + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Abstract will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Items/Abstract.php - - message: "#^Cannot access offset 'name' on bool\\|void\\.$#" - count: 2 - path: ../app/code/core/Mage/ImportExport/Model/Import/Uploader.php + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Order will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Items/Abstract.php - - message: "#^Property Varien_File_Uploader\\:\\:\\$_uploadType \\(string\\) does not accept int\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Order_Pdf_Abstract will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Import/Uploader.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Items/Abstract.php - - message: "#^Property Mage_ImportExport_Model_Resource_Import_Data\\:\\:\\$_iterator \\(IteratorIterator\\) does not accept null\\.$#" + message: "#^Call to function is_null\\(\\) with Varien_Object will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/ImportExport/Model/Resource/Import/Data.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Items/Abstract.php - - message: "#^Method Mage_Index_Model_Lock\\:\\:getInstance\\(\\) should return \\$this\\(Mage_Index_Model_Lock\\) but returns Mage_Index_Model_Lock\\.$#" + message: "#^Call to function is_null\\(\\) with Zend_Pdf_Page will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Index/Model/Lock.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Items/Abstract.php - - message: "#^Property Mage_Index_Model_Lock\\:\\:\\$_storage \\(Mage_Index_Model_Lock_Storage_Interface\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Method Mage_Sales_Model_Order_Pdf_Items_Abstract\\:\\:getSku\\(\\) should return string but returns array\\.$#" count: 1 - path: ../app/code/core/Mage/Index/Model/Lock.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Items/Abstract.php - - message: "#^Method Mage_Core_Model_Resource\\:\\:getConnection\\(\\) invoked with 2 parameters, 1 required\\.$#" + message: "#^Parameter \\#1 \\$item of method Mage_Sales_Model_Order_Pdf_Items_Abstract\\:\\:getSku\\(\\) expects Mage_Sales_Model_Order_Creditmemo_Item\\|Mage_Sales_Model_Order_Invoice_Item, Varien_Object given\\.$#" count: 1 - path: ../app/code/core/Mage/Index/Model/Lock/Storage/Db.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Items/Creditmemo/Default.php - - message: "#^Method Mage_Index_Model_Lock_Storage_Db\\:\\:releaseLock\\(\\) should return int\\|null but returns bool\\.$#" + message: "#^Parameter \\#1 \\$item of method Mage_Sales_Model_Order_Pdf_Items_Abstract\\:\\:getSku\\(\\) expects Mage_Sales_Model_Order_Creditmemo_Item\\|Mage_Sales_Model_Order_Invoice_Item, Varien_Object given\\.$#" count: 1 - path: ../app/code/core/Mage/Index/Model/Lock/Storage/Db.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Items/Invoice/Default.php - - message: "#^Property Mage_Index_Model_Lock_Storage_Db\\:\\:\\$_helper \\(Mage_Index_Model_Resource_Helper_Mysql4\\) does not accept Mage_Core_Model_Resource_Helper_Abstract\\.$#" + message: "#^Parameter \\#1 \\$item of method Mage_Sales_Model_Order_Pdf_Items_Abstract\\:\\:getSku\\(\\) expects Mage_Sales_Model_Order_Creditmemo_Item\\|Mage_Sales_Model_Order_Invoice_Item, Varien_Object given\\.$#" count: 1 - path: ../app/code/core/Mage/Index/Model/Lock/Storage/Db.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Items/Shipment/Default.php - - message: "#^Return type \\(int\\|null\\) of method Mage_Index_Model_Lock_Storage_Db\\:\\:releaseLock\\(\\) should be compatible with return type \\(bool\\) of method Mage_Index_Model_Lock_Storage_Interface\\:\\:releaseLock\\(\\)$#" + message: "#^Parameter \\#1 \\$object of method Mage_Sales_Model_Order_Pdf_Abstract\\:\\:_setFontBold\\(\\) expects Zend_Pdf_Page, Zend_Pdf_Style given\\.$#" count: 1 - path: ../app/code/core/Mage/Index/Model/Lock/Storage/Db.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Shipment.php - - message: "#^Property Varien_Data_Collection\\:\\:\\$_totalRecords \\(int\\) does not accept null\\.$#" + message: "#^Parameter \\#2 \\$obj of method Mage_Sales_Model_Order_Pdf_Abstract\\:\\:insertOrder\\(\\) expects Mage_Sales_Model_Order, Mage_Sales_Model_Order_Shipment given\\.$#" count: 1 - path: ../app/code/core/Mage/Index/Model/Resource/Event/Collection.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Shipment.php - - message: "#^Property Varien_Data_Collection_Db\\:\\:\\$_data \\(array\\) does not accept null\\.$#" + message: "#^Parameter \\#2 \\$store of method Mage_Sales_Model_Order_Pdf_Abstract\\:\\:insertAddress\\(\\) expects null, Mage_Core_Model_Store given\\.$#" count: 1 - path: ../app/code/core/Mage/Index/Model/Resource/Event/Collection.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Shipment.php - - message: "#^Return type \\(Varien_Db_Adapter_Interface\\|false\\) of method Mage_Index_Model_Resource_Lock_Resource\\:\\:_getDefaultConnection\\(\\) should be compatible with return type \\(string\\) of method Mage_Core_Model_Resource\\:\\:_getDefaultConnection\\(\\)$#" + message: "#^Parameter \\#2 \\$store of method Mage_Sales_Model_Order_Pdf_Abstract\\:\\:insertLogo\\(\\) expects null, Mage_Core_Model_Store given\\.$#" count: 1 - path: ../app/code/core/Mage/Index/Model/Resource/Lock/Resource.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Shipment.php - - message: "#^Method Mage_Index_Model_Resource_Setup\\:\\:_syncIndexes\\(\\) should return \\$this\\(Mage_Index_Model_Resource_Setup\\) but return statement is missing\\.$#" + message: "#^Variable \\$shipment might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Index/Model/Resource/Setup.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Shipment.php - - message: "#^Return type \\(void\\) of method Mage_Index_Model_Resource_Setup\\:\\:applyUpdates\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Resource_Setup\\)\\|true\\) of method Mage_Core_Model_Resource_Setup\\:\\:applyUpdates\\(\\)$#" + message: "#^Parameter \\#1 \\$text of method Zend_Pdf_Canvas_Abstract\\:\\:drawText\\(\\) expects string, \\(float\\|int\\) given\\.$#" count: 1 - path: ../app/code/core/Mage/Index/Model/Resource/Setup.php + path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Shipment/Packaging.php - - message: "#^Offset 'path' does not exist on array\\{\\000\\*\\000_parent\\: Varien_Simplexml_Element\\}\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Resource_Order_Shipment_Comment_Collection will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Install/Model/Config.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment.php - - message: "#^Constant data not found\\.$#" + message: "#^Property Mage_Sales_Model_Order_Shipment\\:\\:\\$_items \\(Mage_Sales_Model_Resource_Order_Shipment_Item_Collection\\) in empty\\(\\) is not falsy\\.$#" count: 1 - path: ../app/code/core/Mage/Install/Model/Installer.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment.php - - message: "#^Property Mage_Install_Model_Installer\\:\\:\\$_dataModel \\(Mage_Install_Model_Session\\) does not accept Varien_Object\\.$#" + message: "#^Property Mage_Sales_Model_Order_Shipment\\:\\:\\$_tracks \\(Mage_Sales_Model_Resource_Order_Shipment_Track_Collection\\) in empty\\(\\) is not falsy\\.$#" count: 1 - path: ../app/code/core/Mage/Install/Model/Installer.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment.php - - message: "#^Call to an undefined method Mage_Install_Model_Installer_Db_Abstract\\:\\:getVersion\\(\\)\\.$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Install/Model/Installer/Db.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment.php - - message: "#^Method Mage_Install_Model_Installer_Db\\:\\:_getDbResource\\(\\) should return Mage_Install_Model_Installer_Db_Abstract but returns resource\\.$#" + message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getStoreId\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Install/Model/Installer/Db.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Api.php - - message: "#^Property Mage_Install_Model_Installer_Db\\:\\:\\$_dbResource \\(resource\\) does not accept Mage_Core_Model_Abstract\\.$#" + message: "#^Call to function is_object\\(\\) with array\\|string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Install/Model/Installer/Db.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Api.php - - message: "#^Method Mage_Install_IndexController\\:\\:preDispatch\\(\\) with return type void returns void but should not return anything\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Install/controllers/IndexController.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Api.php - - message: "#^Result of method Mage_Core_Controller_Varien_Action\\:\\:preDispatch\\(\\) \\(void\\) is used\\.$#" + message: "#^Parameter \\#1 \\$comment of method Mage_Sales_Model_Order_Shipment\\:\\:addComment\\(\\) expects Mage_Sales_Model_Order_Shipment_Comment, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Install/controllers/IndexController.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Api.php - - message: "#^Method Mage_Install_WizardController\\:\\:preDispatch\\(\\) with return type void returns void but should not return anything\\.$#" + message: "#^Parameter \\#1 \\$comment of method Mage_Sales_Model_Order_Shipment\\:\\:addComment\\(\\) expects Mage_Sales_Model_Order_Shipment_Comment, string\\|null given\\.$#" count: 1 - path: ../app/code/core/Mage/Install/controllers/WizardController.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Api.php - - message: "#^Result of method Mage_Core_Controller_Varien_Action\\:\\:preDispatch\\(\\) \\(void\\) is used\\.$#" + message: "#^Parameter \\#1 \\$object of method Mage_Sales_Model_Order_Shipment_Api\\:\\:_getCarriers\\(\\) expects Mage_Eav_Model_Entity_Abstract, Mage_Sales_Model_Order given\\.$#" count: 1 - path: ../app/code/core/Mage/Install/controllers/WizardController.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Api.php - - message: "#^Property Mage_Log_Model_Aggregation\\:\\:\\$_lastRecord \\(string\\) does not accept int\\|false\\.$#" + message: "#^Parameter \\#1 \\$object of method Mage_Sales_Model_Order_Shipment_Api\\:\\:_getCarriers\\(\\) expects Mage_Eav_Model_Entity_Abstract, Mage_Sales_Model_Order_Shipment given\\.$#" count: 1 - path: ../app/code/core/Mage/Log/Model/Aggregation.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Api.php - - message: "#^Binary operation \"\\+\" between non\\-falsy\\-string and 1 results in an error\\.$#" - count: 2 - path: ../app/code/core/Mage/Log/Model/Resource/Log.php + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Api.php - - message: "#^Method Mage_Media_Model_File_Image\\:\\:getImage\\(\\) should return bool\\|resource but returns GdImage\\.$#" + message: "#^Parameter \\#1 \\$comment of method Mage_Sales_Model_Order_Shipment\\:\\:addComment\\(\\) expects Mage_Sales_Model_Order_Shipment_Comment, string\\|null given\\.$#" count: 1 - path: ../app/code/core/Mage/Media/Model/File/Image.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Api/V2.php - - message: "#^Method Mage_Media_Model_File_Image\\:\\:getTmpImage\\(\\) should return resource but returns GdImage\\|false\\.$#" + message: "#^Parameter \\#1 \\$object of method Mage_Sales_Model_Order_Shipment_Api\\:\\:_getCarriers\\(\\) expects Mage_Eav_Model_Entity_Abstract, Mage_Sales_Model_Order given\\.$#" count: 1 - path: ../app/code/core/Mage/Media/Model/File/Image.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Api/V2.php - - message: "#^Property Mage_Media_Model_Image\\:\\:\\$_image \\(resource\\) does not accept null\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Media/Model/Image.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Api/V2.php - - message: "#^Property Mage_Media_Model_Image\\:\\:\\$_tmpImage \\(resource\\) does not accept null\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Media/Model/Image.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Comment.php - - message: "#^Method Mage_Newsletter_Model_Problem\\:\\:getSubscriber\\(\\) should return Mage_Newsletter_Model_Subscriber but returns null\\.$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Newsletter/Model/Problem.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Comment.php - - message: "#^Call to an undefined method Mage_Customer_Model_Entity_Attribute\\:\\:getAttributeId\\(\\)\\.$#" - count: 3 - path: ../app/code/core/Mage/Newsletter/Model/Resource/Subscriber/Collection.php + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Comment.php - - message: "#^Call to an undefined method Mage_Customer_Model_Entity_Attribute\\:\\:getBackend\\(\\)\\.$#" - count: 3 - path: ../app/code/core/Mage/Newsletter/Model/Resource/Subscriber/Collection.php + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Item.php - - message: "#^Property Mage_Newsletter_Model_Template\\:\\:\\$_mail \\(Zend_Mail\\) does not accept null\\.$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Newsletter/Model/Template.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Item.php - - message: "#^Method Mage_Newsletter_ManageController\\:\\:saveAction\\(\\) should return Mage_Newsletter_ManageController but return statement is missing\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Newsletter/controllers/ManageController.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Track.php - - message: "#^Return type \\(void\\) of method Mage_Oauth_Adminhtml_Oauth_AuthorizeController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Controller_Action\\)\\) of method Mage_Adminhtml_Controller_Action\\:\\:preDispatch\\(\\)$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Oauth/controllers/Adminhtml/Oauth/AuthorizeController.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Track.php - - message: "#^Call to an undefined method Mage_Core_Model_Abstract\\:\\:authenticate\\(\\)\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Oauth/controllers/Customer/TokenController.php + path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Track.php - - message: "#^Property Mage_Oauth_Customer_TokenController\\:\\:\\$_session \\(Mage_Customer_Model_Session\\) does not accept Mage_Core_Model_Abstract\\.$#" + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/Model/Order/Status/History.php + + - + message: "#^Property Mage_Sales_Model_Order_Status_History\\:\\:\\$_shouldSetOrderBeforeSave is never read, only written\\.$#" count: 1 - path: ../app/code/core/Mage/Oauth/controllers/Customer/TokenController.php + path: ../app/code/core/Mage/Sales/Model/Order/Status/History.php - - message: "#^Property Mage_Oauth_Customer_TokenController\\:\\:\\$_sessionName \\(Mage_Customer_Model_Session\\) does not accept default value of type string\\.$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Oauth/controllers/Customer/TokenController.php + path: ../app/code/core/Mage/Sales/Model/Order/Status/History.php - - message: "#^Return type \\(void\\) of method Mage_Oauth_InitiateController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Controller_Front_Action\\)\\) of method Mage_Core_Controller_Front_Action\\:\\:preDispatch\\(\\)$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Oauth/controllers/InitiateController.php + path: ../app/code/core/Mage/Sales/Model/Order/Status/History.php - - message: "#^Return type \\(void\\) of method Mage_Oauth_TokenController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Controller_Front_Action\\)\\) of method Mage_Core_Controller_Front_Action\\:\\:preDispatch\\(\\)$#" + message: "#^Instanceof between Mage_Core_Model_Abstract\\|false and Mage_Sales_Model_Order_Total_Abstract will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Oauth/controllers/TokenController.php + path: ../app/code/core/Mage/Sales/Model/Order/Total/Config/Base.php - - message: "#^Variable \\$finish might not be defined\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Page/Block/Html/Pager.php + path: ../app/code/core/Mage/Sales/Model/Order/Total/Config/Base.php - - message: "#^Variable \\$start might not be defined\\.$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Page/Block/Html/Pager.php + path: ../app/code/core/Mage/Sales/Model/Payment/Method/Billing/AgreementAbstract.php - - message: "#^Method Mage_PageCache_Helper_Data\\:\\:getCacheControlInstance\\(\\) should return Mage_PageCache_Model_Control_Interface but returns Mage_Core_Model_Abstract\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Customer_Model_Customer will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/PageCache/Helper/Data.php + path: ../app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:isPartialAuthorization\\(\\)\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Resource_Order_Address_Collection will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Paygate/Block/Authorizenet/Form/Cc.php + path: ../app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Property Mage_Payment_Block_Info\\:\\:\\$_paymentSpecificInformation \\(Varien_Object\\) does not accept null\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Resource_Quote_Item_Collection will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Paygate/Block/Authorizenet/Info/Cc.php + path: ../app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Cannot assign new offset to string\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Resource_Quote_Payment_Collection will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Paygate/Model/Authorizenet.php + path: ../app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Variable \\$defaultExceptionMessage might not be defined\\.$#" - count: 2 - path: ../app/code/core/Mage/Paygate/Model/Authorizenet.php + message: "#^If condition is always true\\.$#" + count: 8 + path: ../app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Variable \\$newTransactionType might not be defined\\.$#" - count: 3 - path: ../app/code/core/Mage/Paygate/Model/Authorizenet.php + message: "#^Left side of && is always true\\.$#" + count: 4 + path: ../app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:cancelPartialAuthorization\\(\\)\\.$#" + message: "#^Method Mage_Sales_Model_Quote\\:\\:getIsVirtual\\(\\) should return bool but returns int\\.$#" count: 1 - path: ../app/code/core/Mage/Paygate/controllers/Adminhtml/Paygate/Authorizenet/PaymentController.php + path: ../app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:cancelPartialAuthorization\\(\\)\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Paygate/controllers/Authorizenet/PaymentController.php + path: ../app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Property Mage_Core_Block_Template\\:\\:\\$_template \\(string\\) does not accept null\\.$#" + message: "#^Parameter \\#2 \\$array of function implode expects array\\, array\\ given\\.$#" count: 1 - path: ../app/code/core/Mage/Payment/Block/Catalog/Product/View/Profile.php + path: ../app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Property Mage_Payment_Block_Catalog_Product_View_Profile\\:\\:\\$_profile \\(Mage_Payment_Model_Recurring_Profile\\) does not accept default value of type false\\.$#" + message: "#^Property Mage_Sales_Model_Quote\\:\\:\\$_addresses \\(Mage_Sales_Model_Resource_Order_Address_Collection\\) does not accept Mage_Sales_Model_Resource_Quote_Address_Collection\\.$#" count: 1 - path: ../app/code/core/Mage/Payment/Block/Catalog/Product/View/Profile.php + path: ../app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Call to an undefined method Mage_Core_Model_Abstract\\:\\:isAvailable\\(\\)\\.$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Payment/Helper/Data.php + path: ../app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Method Mage_Payment_Helper_Data\\:\\:getStoreMethods\\(\\) should return array\\ but returns array\\\\.$#" - count: 1 - path: ../app/code/core/Mage/Payment/Helper/Data.php + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 4 + path: ../app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Method Mage_Payment_Model_Config\\:\\:_getMethod\\(\\) should return Mage_Payment_Model_Method_Abstract\\|false but returns Mage_Core_Model_Abstract\\.$#" + message: "#^Variable \\$item might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Payment/Model/Config.php + path: ../app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Comparison operation \"\\<\" between \\(array\\|float\\|int\\) and 0\\.0001 results in an error\\.$#" - count: 1 - path: ../app/code/core/Mage/Payment/Model/Method/Abstract.php + message: "#^Variable \\$old in empty\\(\\) always exists and is not falsy\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Binary operation \"\\*\\=\" between string and 2 results in an error\\.$#" + message: "#^Call to function is_null\\(\\) with iterable\\&Mage_Sales_Model_Resource_Quote_Address_Item_Collection will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Payment/Model/Method/Cc.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address.php - - message: "#^Method Mage_Payment_Model_Recurring_Profile\\:\\:exportStartDatetime\\(\\) should return string\\|Zend_Date but empty return statement found\\.$#" + message: "#^Call to function is_null\\(\\) with iterable\\&Mage_Sales_Model_Resource_Quote_Address_Rate_Collection will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Payment/Model/Recurring/Profile.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address.php - - message: "#^Property Mage_Paypal_Block_Adminhtml_System_Config_Field_Country\\:\\:\\$_defaultCountry \\(string\\) does not accept null\\.$#" + message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Block/Adminhtml/System/Config/Field/Country.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address.php - - message: "#^Method Mage_Paypal_Block_Adminhtml_System_Config_Fieldset_Group\\:\\:_getCollapseState\\(\\) should return bool but returns int\\.$#" + message: "#^If condition is always true\\.$#" + count: 3 + path: ../app/code/core/Mage/Sales/Model/Quote/Address.php + + - + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Block/Adminhtml/System/Config/Fieldset/Group.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address.php - - message: "#^Method Mage_Paypal_Block_Express_Review\\:\\:_formatPrice\\(\\) should return string but returns float\\.$#" + message: "#^Method Mage_Sales_Model_Quote_Address\\:\\:getItemsCollection\\(\\) should return Mage_Eav_Model_Entity_Collection_Abstract but returns iterable\\&Mage_Sales_Model_Resource_Quote_Address_Item_Collection\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Block/Express/Review.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address.php - - message: "#^Method Mage_Paypal_Block_Express_Review\\:\\:_getShippingPrice\\(\\) should return bool but returns float\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Block/Express/Review.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address.php - - message: "#^Return type \\(false\\) of method Mage_Paypal_Block_Hosted_Pro_Info\\:\\:getCcTypeName\\(\\) should be compatible with return type \\(string\\|null\\) of method Mage_Paypal_Block_Payment_Info\\:\\:getCcTypeName\\(\\)$#" + message: "#^Parameter \\#1 \\$parentItem of method Mage_Sales_Model_Quote_Item_Abstract\\:\\:setParentItem\\(\\) expects Mage_Sales_Model_Quote_Item, Mage_Sales_Model_Quote_Address_Item given\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Block/Hosted/Pro/Info.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address.php - - message: "#^Method Mage_Paypal_Block_Iframe\\:\\:_getBlock\\(\\) should return \\$this\\(Mage_Paypal_Block_Iframe\\) but returns Mage_Payment_Block_Form\\.$#" + message: "#^Property Mage_Sales_Model_Quote_Address\\:\\:\\$_nominalOnly \\(bool\\) does not accept null\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/Model/Quote/Address.php + + - + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Block/Iframe.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address.php + + - + message: "#^Variable \\$totalInstance might not be defined\\.$#" + count: 3 + path: ../app/code/core/Mage/Sales/Model/Quote/Address.php - - message: "#^Property Mage_Paypal_Block_Iframe\\:\\:\\$_block \\(Mage_Payment_Block_Form\\) does not accept Mage_Core_Block_Abstract\\|false\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Block/Iframe.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Item.php - - message: "#^Return type \\(false\\) of method Mage_Paypal_Block_Payflow_Link_Info\\:\\:getCcTypeName\\(\\) should be compatible with return type \\(string\\|null\\) of method Mage_Paypal_Block_Payment_Info\\:\\:getCcTypeName\\(\\)$#" + message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:getClassName\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Block/Payflow/Link/Info.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Collector.php - - message: "#^Method Mage_Paypal_Controller_Express_Abstract\\:\\:_initCheckout\\(\\) should return Mage_Paypal_Model_Express_Checkout but returns Mage_Core_Model_Abstract\\.$#" + message: "#^Instanceof between Mage_Core_Model_Abstract\\|false and Mage_Sales_Model_Quote_Address_Total_Abstract will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Controller/Express/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Collector.php - - message: "#^Method Mage_Paypal_Controller_Express_Abstract\\:\\:_initToken\\(\\) should return Mage_Paypal_ExpressController\\|string but returns \\$this\\(Mage_Paypal_Controller_Express_Abstract\\)\\.$#" + message: "#^Parameter \\#3 \\$totalConfig of method Mage_Sales_Model_Quote_Address_Total_Collector\\:\\:_initModelInstance\\(\\) expects array, Varien_Simplexml_Element given\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Controller/Express/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Collector.php - - message: "#^Property Mage_Paypal_Controller_Express_Abstract\\:\\:\\$_checkout \\(Mage_Paypal_Model_Express_Checkout\\) does not accept Mage_Core_Model_Abstract\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Controller/Express/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Collector.php - - message: "#^Property Mage_Paypal_Controller_Express_Abstract\\:\\:\\$_config \\(Mage_Paypal_Model_Config\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Quote_Address_Total_Discount\\)\\) of method Mage_Sales_Model_Quote_Address_Total_Discount\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Paypal/Controller/Express/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Discount.php - - message: "#^Property Mage_Paypal_Controller_Express_Abstract\\:\\:\\$_quote \\(Mage_Sales_Model_Quote\\) does not accept default value of type false\\.$#" + message: "#^Return type \\(Mage_Sales_Model_Quote_Address_Total_Grand\\) of method Mage_Sales_Model_Quote_Address_Total_Grand\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Paypal/Controller/Express/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Grand.php - - message: "#^Variable \\$isAjax might not be defined\\.$#" + message: "#^Parameter \\#2 \\$visibility of method Mage_Catalog_Helper_Data\\:\\:canApplyMsrp\\(\\) expects int\\|null, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Controller/Express/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Msrp.php - - message: "#^Method Mage_Paypal_Model_Api_Abstract\\:\\:_exportLineItems\\(\\) should return bool but empty return statement found\\.$#" - count: 2 - path: ../app/code/core/Mage/Paypal/Model/Api/Abstract.php + message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Quote_Address_Total_Nominal\\)\\) of method Mage_Sales_Model_Quote_Address_Total_Nominal\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Nominal.php - - message: "#^Call to an undefined method Mage_Paypal_Model_Api_Nvp\\:\\:_export\\(\\)\\.$#" + message: "#^Return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Nominal_Shipping\\:\\:fetch\\(\\) should be compatible with return type \\(Mage_Sales_Model_Quote_Address_Total_Shipping\\) of method Mage_Sales_Model_Quote_Address_Total_Shipping\\:\\:fetch\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Api/Nvp.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Nominal/Shipping.php - - message: "#^Call to an undefined method Mage_Paypal_Model_Api_Nvp\\:\\:_import\\(\\)\\.$#" + message: "#^Return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Nominal_Subtotal\\:\\:fetch\\(\\) should be compatible with return type \\(Mage_Sales_Model_Quote_Address_Total_Subtotal\\) of method Mage_Sales_Model_Quote_Address_Total_Subtotal\\:\\:fetch\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Api/Nvp.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Nominal/Subtotal.php - - message: "#^Method Mage_Paypal_Model_Api_Nvp\\:\\:_exportLineItems\\(\\) should return true\\|null but empty return statement found\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Api/Nvp.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Shipping.php - - message: "#^Method Mage_Paypal_Model_Api_Nvp\\:\\:_exportLineItems\\(\\) should return true\\|null but returns bool\\.$#" + message: "#^Return type \\(Mage_Sales_Model_Quote_Address_Total_Shipping\\) of method Mage_Sales_Model_Quote_Address_Total_Shipping\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Api/Nvp.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Shipping.php - - message: "#^Method Mage_Paypal_Model_Api_Standard\\:\\:_exportLineItems\\(\\) should return true\\|null but empty return statement found\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Api/Standard.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Shipping.php - - message: "#^Method Mage_Paypal_Model_Api_Standard\\:\\:_exportLineItems\\(\\) should return true\\|null but returns bool\\.$#" + message: "#^Variable \\$addressQty in isset\\(\\) always exists and is not nullable\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Api/Standard.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Shipping.php - - message: "#^Call to an undefined method Varien_Object\\:\\:isNominal\\(\\)\\.$#" - count: 1 - path: ../app/code/core/Mage/Paypal/Model/Cart.php + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Subtotal.php - - message: "#^Property Mage_Paypal_Model_Direct\\:\\:\\$_pro \\(Mage_Paypal_Model_Pro\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Direct.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Subtotal.php - - message: "#^Call to an undefined method Mage_Payment_Model_Info\\:\\:lookupTransaction\\(\\)\\.$#" - count: 2 - path: ../app/code/core/Mage/Paypal/Model/Express.php + message: "#^Negated boolean expression is always false\\.$#" + count: 3 + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Subtotal.php - - message: "#^Method Mage_Paypal_Model_Express\\:\\:assignData\\(\\) should return Mage_Payment_Model_Info but returns \\$this\\(Mage_Paypal_Model_Express\\)\\.$#" + message: "#^Return type \\(Mage_Sales_Model_Quote_Address_Total_Subtotal\\) of method Mage_Sales_Model_Quote_Address_Total_Subtotal\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Express.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Subtotal.php - - message: "#^Property Mage_Paypal_Model_Express\\:\\:\\$_pro \\(Mage_Paypal_Model_Pro\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Express.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Tax.php - - message: "#^Return type \\(Mage_Payment_Model_Info\\) of method Mage_Paypal_Model_Express\\:\\:assignData\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Abstract\\)\\) of method Mage_Payment_Model_Method_Abstract\\:\\:assignData\\(\\)$#" + message: "#^Parameter \\#4 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Express.php + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Tax.php - - message: "#^Cannot call method getData\\(\\) on array\\.$#" - count: 2 - path: ../app/code/core/Mage/Paypal/Model/Express/Checkout.php + message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Quote_Address_Total_Tax\\)\\) of method Mage_Sales_Model_Quote_Address_Total_Tax\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Tax.php - - message: "#^Cannot call method getExportedKeys\\(\\) on array\\.$#" - count: 2 - path: ../app/code/core/Mage/Paypal/Model/Express/Checkout.php + message: "#^If condition is always true\\.$#" + count: 4 + path: ../app/code/core/Mage/Sales/Model/Quote/Item.php - - message: "#^Variable \\$address might not be defined\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Express/Checkout.php + path: ../app/code/core/Mage/Sales/Model/Quote/Item.php - - message: "#^Variable \\$shippingAddress might not be defined\\.$#" + message: "#^Method Mage_Sales_Model_Quote_Item\\:\\:__clone\\(\\) with return type void returns \\$this\\(Mage_Sales_Model_Quote_Item\\) but should not return anything\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Express/Checkout.php + path: ../app/code/core/Mage/Sales/Model/Quote/Item.php - - message: "#^Method Mage_Paypal_Model_Hostedpro\\:\\:initialize\\(\\) should return \\$this\\(Mage_Paypal_Model_Hostedpro\\) but return statement is missing\\.$#" + message: "#^Method Mage_Sales_Model_Quote_Item\\:\\:save\\(\\) should return \\$this\\(Mage_Sales_Model_Quote_Item\\) but return statement is missing\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Hostedpro.php + path: ../app/code/core/Mage/Sales/Model/Quote/Item.php - - message: "#^Return type \\(bool\\) of method Mage_Paypal_Model_Hostedpro\\:\\:getAllowedCcTypes\\(\\) should be compatible with return type \\(string\\) of method Mage_Paypal_Model_Direct\\:\\:getAllowedCcTypes\\(\\)$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Hostedpro.php + path: ../app/code/core/Mage/Sales/Model/Quote/Item.php - - message: "#^Return type \\(bool\\) of method Mage_Paypal_Model_Hostedpro\\:\\:validate\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Cc\\)\\) of method Mage_Payment_Model_Method_Cc\\:\\:validate\\(\\)$#" + message: "#^Negated boolean expression is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Hostedpro.php + path: ../app/code/core/Mage/Sales/Model/Quote/Item.php - - message: "#^Binary operation \"\\-\" between array\\|string and array\\|string results in an error\\.$#" + message: "#^Parameter \\#4 \\$product of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:updateQtyOption\\(\\) expects null, Mage_Catalog_Model_Product given\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Ipn.php + path: ../app/code/core/Mage/Sales/Model/Quote/Item.php - - message: "#^Property Mage_Paypal_Model_Ipn\\:\\:\\$_order \\(Mage_Sales_Model_Order\\) does not accept null\\.$#" + message: "#^Property Mage_Sales_Model_Quote_Item\\:\\:\\$_quote \\(Mage_Sales_Model_Quote\\) does not accept null\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Ipn.php + path: ../app/code/core/Mage/Sales/Model/Quote/Item.php - - message: "#^Property Mage_Paypal_Model_Ipn\\:\\:\\$_recurringProfile \\(Mage_Sales_Model_Recurring_Profile\\) does not accept null\\.$#" + message: "#^Return type \\(void\\) of method Mage_Sales_Model_Quote_Item\\:\\:__clone\\(\\) should be compatible with return type \\(\\$this\\(Mage_Sales_Model_Quote_Item_Abstract\\)\\) of method Mage_Sales_Model_Quote_Item_Abstract\\:\\:__clone\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Ipn.php + path: ../app/code/core/Mage/Sales/Model/Quote/Item.php - - message: "#^Return type \\(bool\\) of method Mage_Paypal_Model_Payflowlink\\:\\:validate\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Cc\\)\\) of method Mage_Payment_Model_Method_Cc\\:\\:validate\\(\\)$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Payflowlink.php + path: ../app/code/core/Mage/Sales/Model/Quote/Item.php - - message: "#^Variable \\$order in empty\\(\\) always exists and is not falsy\\.$#" - count: 1 - path: ../app/code/core/Mage/Paypal/Model/Payflowlink.php + message: "#^If condition is always true\\.$#" + count: 5 + path: ../app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php - - message: "#^Property Mage_Paypal_Model_Payflowpro\\:\\:\\$_centinelFieldMap \\(string\\) does not accept default value of type array\\\\.$#" + message: "#^Method Mage_Sales_Model_Quote_Item_Abstract\\:\\:__clone\\(\\) with return type void returns \\$this\\(Mage_Sales_Model_Quote_Item_Abstract\\) but should not return anything\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Payflowpro.php + path: ../app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php - - message: "#^Variable \\$order in empty\\(\\) always exists and is not falsy\\.$#" + message: "#^Method Mage_Sales_Model_Quote_Item_Abstract\\:\\:getParentItem\\(\\) should return \\$this\\(Mage_Sales_Model_Quote_Item_Abstract\\) but returns Mage_Sales_Model_Quote_Item_Abstract\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Payflowpro.php + path: ../app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php - - message: "#^Method Mage_Paypal_Model_Pro\\:\\:capture\\(\\) should return false\\|null but return statement is missing\\.$#" + message: "#^Parameter \\#1 \\$store of method Mage_Tax_Helper_Data\\:\\:discountTax\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Pro.php + path: ../app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php - - message: "#^Property Mage_Paypal_Model_Pro\\:\\:\\$_api \\(Mage_Paypal_Model_Api_Nvp\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Parameter \\#1 \\$value of method Mage_Sales_Model_Quote_Item_Abstract\\:\\:setConvertedPrice\\(\\) expects float, null given\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Pro.php + path: ../app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php - - message: "#^Property Mage_Paypal_Model_Pro\\:\\:\\$_api \\(Mage_Paypal_Model_Api_Nvp\\) does not accept null\\.$#" + message: "#^Property Mage_Sales_Model_Quote_Item_Abstract\\:\\:\\$_parentItem \\(Mage_Sales_Model_Quote_Item_Abstract\\) does not accept null\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Pro.php + path: ../app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php - - message: "#^Property Mage_Paypal_Model_Pro\\:\\:\\$_config \\(Mage_Paypal_Model_Config\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Ternary operator condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Pro.php + path: ../app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php - - message: "#^Method Mage_Paypal_Model_Standard\\:\\:initialize\\(\\) should return \\$this\\(Mage_Paypal_Model_Standard\\) but return statement is missing\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/Standard.php + path: ../app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php - - message: "#^Method Varien_Data_Collection\\:\\:toOptionArray\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/System/Config/Source/BuyerCountry.php + path: ../app/code/core/Mage/Sales/Model/Quote/Item/Option.php - - message: "#^Method Varien_Data_Collection\\:\\:toOptionArray\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Method Mage_Sales_Model_Quote_Item_Option\\:\\:__clone\\(\\) with return type void returns \\$this\\(Mage_Sales_Model_Quote_Item_Option\\) but should not return anything\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/Model/System/Config/Source/MerchantCountry.php + path: ../app/code/core/Mage/Sales/Model/Quote/Item/Option.php - - message: "#^Method Mage_Paypal_HostedproController\\:\\:_getIframeBlock\\(\\) should return Mage_Paypal_Block_Hosted_Pro_Iframe but returns Mage_Core_Block_Abstract\\|false\\.$#" - count: 1 - path: ../app/code/core/Mage/Paypal/controllers/HostedproController.php + message: "#^If condition is always true\\.$#" + count: 3 + path: ../app/code/core/Mage/Sales/Model/Quote/Payment.php - - message: "#^Method Mage_Paypal_PayflowController\\:\\:_getIframeBlock\\(\\) should return Mage_Paypal_Block_Payflow_Link_Iframe but returns Mage_Core_Block_Abstract\\|false\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/Model/Quote/Payment.php + + - + message: "#^Call to Exception\\:\\:__construct\\(\\) on a separate line has no effect\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/controllers/PayflowController.php + path: ../app/code/core/Mage/Sales/Model/Recurring/Profile.php - - message: "#^Method Mage_Paypal_PayflowadvancedController\\:\\:_getIframeBlock\\(\\) should return Mage_Paypal_Block_Payflow_Advanced_Iframe but returns Mage_Core_Block_Abstract\\|false\\.$#" + message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:canGetRecurringProfileDetails\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Paypal/controllers/PayflowadvancedController.php + path: ../app/code/core/Mage/Sales/Model/Recurring/Profile.php - - message: "#^Variable \\$key might not be defined\\.$#" + message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:submitRecurringProfile\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Poll/Block/ActivePoll.php + path: ../app/code/core/Mage/Sales/Model/Recurring/Profile.php - - message: "#^Variable \\$value might not be defined\\.$#" + message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:updateRecurringProfileStatus\\(\\)\\.$#" + count: 3 + path: ../app/code/core/Mage/Sales/Model/Recurring/Profile.php + + - + message: "#^Else branch is unreachable because previous condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Poll/Block/ActivePoll.php + path: ../app/code/core/Mage/Sales/Model/Recurring/Profile.php - - message: "#^Method Mage_Poll_Model_Poll\\:\\:getPoolId\\(\\) should return int but returns string\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Poll/Model/Poll.php + path: ../app/code/core/Mage/Sales/Model/Recurring/Profile.php - - message: "#^Method Mage_Poll_Model_Poll\\:\\:getRandomId\\(\\) should return string but returns int\\.$#" + message: "#^Method Mage_Sales_Model_Recurring_Profile\\:\\:_getItem\\(\\) should return Mage_Sales_Model_Order_Item but return statement is missing\\.$#" count: 1 - path: ../app/code/core/Mage/Poll/Model/Poll.php + path: ../app/code/core/Mage/Sales/Model/Recurring/Profile.php - - message: "#^Method Mage_Poll_Model_Resource_Poll\\:\\:checkAnswerId\\(\\) should return bool but returns string\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Poll/Model/Resource/Poll.php + path: ../app/code/core/Mage/Sales/Model/Recurring/Profile.php - - message: "#^Method Mage_Poll_Model_Resource_Poll\\:\\:getRandomId\\(\\) should return int but returns string\\.$#" + message: "#^Parameter \\#2 \\$attribute of method Mage_Sales_Model_Resource_Order_Abstract\\:\\:_afterSaveAttribute\\(\\) expects string, array given\\.$#" count: 1 - path: ../app/code/core/Mage/Poll/Model/Resource/Poll.php + path: ../app/code/core/Mage/Sales/Model/Resource/Order/Abstract.php - - message: "#^Method Mage_Poll_Model_Resource_Poll_Answer_Collection\\:\\:countPercent\\(\\) should return \\$this\\(Mage_Poll_Model_Resource_Poll_Answer_Collection\\) but empty return statement found\\.$#" + message: "#^Parameter \\#2 \\$attribute of method Mage_Sales_Model_Resource_Order_Abstract\\:\\:_beforeSaveAttribute\\(\\) expects string, array given\\.$#" count: 1 - path: ../app/code/core/Mage/Poll/Model/Resource/Poll/Answer/Collection.php + path: ../app/code/core/Mage/Sales/Model/Resource/Order/Abstract.php - - message: "#^Method Mage_ProductAlert_Helper_Data\\:\\:createBlock\\(\\) should return string but returns Mage_Core_Block_Abstract\\.$#" + message: "#^Cannot call method updateOnRelatedRecordChanged\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" count: 1 - path: ../app/code/core/Mage/ProductAlert/Helper/Data.php + path: ../app/code/core/Mage/Sales/Model/Resource/Order/Address.php - - message: "#^Property Mage_ProductAlert_Model_Email\\:\\:\\$_customer \\(Mage_Customer_Model_Customer\\) does not accept null\\.$#" + message: "#^Parameter \\#1 \\$attribute of method Mage_Sales_Model_Resource_Collection_Abstract\\:\\:addAttributeToFilter\\(\\) expects Mage_Eav_Model_Entity_Attribute\\|string, array given\\.$#" count: 1 - path: ../app/code/core/Mage/ProductAlert/Model/Email.php + path: ../app/code/core/Mage/Sales/Model/Resource/Order/Collection.php - - message: "#^Property Mage_ProductAlert_Model_Email\\:\\:\\$_priceBlock \\(Mage_ProductAlert_Block_Email_Price\\) does not accept string\\.$#" + message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'afterLoad' given\\.$#" count: 1 - path: ../app/code/core/Mage/ProductAlert/Model/Email.php + path: ../app/code/core/Mage/Sales/Model/Resource/Order/Creditmemo/Collection.php - - message: "#^Property Mage_ProductAlert_Model_Email\\:\\:\\$_stockBlock \\(Mage_ProductAlert_Block_Email_Stock\\) does not accept string\\.$#" + message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'afterLoad' given\\.$#" count: 1 - path: ../app/code/core/Mage/ProductAlert/Model/Email.php + path: ../app/code/core/Mage/Sales/Model/Resource/Order/Invoice/Collection.php - - message: "#^Method Mage_ProductAlert_Model_Observer\\:\\:process\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Call to an undefined method Mage_Core_Model_Abstract\\:\\:isFailsafe\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/ProductAlert/controllers/AddController.php + path: ../app/code/core/Mage/Sales/Model/Resource/Order/Payment/Transaction.php - - message: "#^Return type \\(void\\) of method Mage_ProductAlert_AddController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Controller_Front_Action\\)\\) of method Mage_Core_Controller_Front_Action\\:\\:preDispatch\\(\\)$#" + message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'afterLoad' given\\.$#" count: 1 - path: ../app/code/core/Mage/ProductAlert/controllers/AddController.php + path: ../app/code/core/Mage/Sales/Model/Resource/Order/Shipment/Collection.php - - message: "#^Method Mage_Rating_Model_Resource_Rating\\:\\:getEntityIdByCode\\(\\) should return int but returns string\\.$#" + message: "#^Parameter \\#3 \\$object of method Mage_Core_Model_Resource_Db_Abstract\\:\\:_getLoadSelect\\(\\) expects Mage_Core_Model_Abstract, Varien_Object given\\.$#" count: 1 - path: ../app/code/core/Mage/Rating/Model/Resource/Rating.php + path: ../app/code/core/Mage/Sales/Model/Resource/Order/Status.php - - message: "#^Variable \\$data in empty\\(\\) always exists and is not falsy\\.$#" + message: "#^Parameter \\#2 \\$resourceModel of method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:_init\\(\\) expects Mage_Core_Model_Resource_Db_Abstract\\|null, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Rating/Model/Resource/Rating.php + path: ../app/code/core/Mage/Sales/Model/Resource/Order/Tax/Collection.php - - message: "#^Method Mage_Rating_Model_Resource_Rating_Collection\\:\\:getItemById\\(\\) invoked with 1 parameter, 0 required\\.$#" - count: 2 - path: ../app/code/core/Mage/Rating/Model/Resource/Rating/Collection.php + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Resource/Quote.php - - message: "#^Variable \\$storeId in empty\\(\\) always exists and is not falsy\\.$#" + message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Rating/Model/Resource/Rating/Collection.php + path: ../app/code/core/Mage/Sales/Model/Resource/Quote.php - - message: "#^Method Mage_Rating_Model_Resource_Rating_Entity\\:\\:getIdByCode\\(\\) should return int but returns string\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Rating/Model/Resource/Rating/Entity.php + path: ../app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Backend/Region.php - - message: "#^Property Mage_Reports_Block_Product_Abstract\\:\\:\\$_indexModel \\(Mage_Reports_Model_Product_Index_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Custbalance\\)\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Custbalance\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Reports/Block/Product/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend/Custbalance.php - - message: "#^Variable \\$dateStart might not be defined\\.$#" - count: 7 - path: ../app/code/core/Mage/Reports/Helper/Data.php + message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Discount\\)\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Discount\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" + count: 1 + path: ../app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend/Discount.php - - message: "#^Variable \\$t might not be defined\\.$#" + message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Grand\\)\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Grand\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Reports/Helper/Data.php + path: ../app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend/Grand.php - - message: "#^Property Mage_Reports_Model_Grouped_Collection\\:\\:\\$_resourceCollection \\(Mage_Core_Model_Resource_Db_Collection_Abstract\\) does not accept Varien_Data_Collection_Db\\.$#" + message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Shipping\\)\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Shipping\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Reports/Model/Grouped/Collection.php + path: ../app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend/Shipping.php - - message: "#^Method Mage_Reports_Model_Resource_Product_Index_Abstract\\:\\:clean\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Subtotal\\)\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Subtotal\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Reports/Model/Product/Index/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend/Subtotal.php - - message: "#^Property Mage_Reports_Model_Report\\:\\:\\$_reportModel \\(Mage_Reports_Model_Report\\) does not accept Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Tax\\)\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Tax\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Reports/Model/Report.php + path: ../app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend/Tax.php - - message: "#^Call to an undefined method Mage_Customer_Model_Customer\\:\\:remove\\(\\)\\.$#" + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/Model/Resource/Quote/Item/Collection.php + + - + message: "#^Left side of && is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Reports/Model/Resource/Customer/Collection.php + path: ../app/code/core/Mage/Sales/Model/Resource/Quote/Item/Collection.php - - message: "#^Call to an undefined method Mage_Sales_Model_Resource_Quote_Item_Collection\\:\\:setQuoteFilter\\(\\)\\.$#" + message: "#^Right side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Reports/Model/Resource/Customer/Collection.php + path: ../app/code/core/Mage/Sales/Model/Resource/Quote/Item/Collection.php - - message: "#^Call to an undefined method Varien_Data_Collection_Db\\:\\:getResource\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Reports/Model/Resource/Event.php + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers.php - - message: "#^Method Mage_Reports_Model_Resource_Helper_Mysql4\\:\\:mergeVisitorProductIndex\\(\\) should return string but returns int\\.$#" - count: 1 - path: ../app/code/core/Mage/Reports/Model/Resource/Helper/Mysql4.php + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php - - message: "#^Method Mage_Reports_Model_Resource_Order_Collection\\:\\:_prepareSummaryAggregated\\(\\) invoked with 4 parameters, 3 required\\.$#" + message: "#^Comparison operation \"\\!\\=\" between array\\|int and 0 results in an error\\.$#" count: 1 - path: ../app/code/core/Mage/Reports/Model/Resource/Order/Collection.php + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php - - message: "#^Variable \\$productViewEvent might not be defined\\.$#" - count: 1 - path: ../app/code/core/Mage/Reports/Model/Resource/Product/Collection.php + message: "#^If condition is always true\\.$#" + count: 4 + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php - - message: "#^Property Mage_Reports_Model_Resource_Report_Collection\\:\\:\\$_from \\(string\\) does not accept int\\.$#" - count: 1 - path: ../app/code/core/Mage/Reports/Model/Resource/Report/Collection.php + message: "#^Left side of && is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php - - message: "#^Property Mage_Reports_Model_Resource_Report_Collection\\:\\:\\$_to \\(string\\) does not accept int\\.$#" - count: 1 - path: ../app/code/core/Mage/Reports/Model/Resource/Report/Collection.php + message: "#^Negated boolean expression is always false\\.$#" + count: 4 + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php - - message: "#^Comparison operation \"\\!\\=\" between array\\|int and 0 results in an error\\.$#" + message: "#^Parameter \\#1 \\$conn of method Varien_Data_Collection_Db\\:\\:setConnection\\(\\) expects Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface given\\.$#" count: 1 - path: ../app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php - - message: "#^Variable \\$currentStoreIds in isset\\(\\) always exists and is not nullable\\.$#" + message: "#^Parameter \\#1 \\$select of method Mage_Core_Model_Resource_Helper_Mysql4\\:\\:getQueryUsingAnalyticFunction\\(\\) expects Varien_Db_Select, Zend_Db_Select given\\.$#" count: 1 - path: ../app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php - - message: "#^Call to an undefined method Mage_Reports_Model_Resource_Review_Collection\\:\\:_joinFields\\(\\)\\.$#" - count: 1 - path: ../app/code/core/Mage/Reports/Model/Resource/Review/Collection.php + message: "#^Right side of && is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php - - message: "#^Call to an undefined static method Mage_Review_Model_Resource_Review_Collection\\:\\:resetSelect\\(\\)\\.$#" + message: "#^Variable \\$currentStoreIds in isset\\(\\) always exists and is not nullable\\.$#" count: 1 - path: ../app/code/core/Mage/Reports/Model/Resource/Review/Collection.php + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php - - message: "#^Method Mage_Reports_Model_Resource_Wishlist_Collection\\:\\:getSharedCount\\(\\) should return int but returns string\\.$#" + message: "#^Call to function is_array\\(\\) with string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Reports/Model/Resource/Wishlist/Collection.php + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Collection/Abstract.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:setStore\\(\\)\\.$#" + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Reports/Model/Resource/Wishlist/Product/Collection.php + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Collection/Abstract.php - - message: "#^Property DOMNode\\:\\:\\$nodeValue \\(string\\|null\\) does not accept int\\\\|int\\<1, max\\>\\.$#" - count: 1 - path: ../app/code/core/Mage/Reports/Model/Test.php + message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, int given\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Invoiced.php - - message: "#^Argument of an invalid type Mage_Reports_Model_Report supplied for foreach, only iterables are supported\\.$#" + message: "#^Parameter \\#2 \\$true of method Varien_Db_Adapter_Pdo_Mysql\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Reports/Model/Totals.php + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Invoiced.php - - message: "#^Return type \\(string\\) of method Mage_Review_Block_Form\\:\\:getAction\\(\\) should be compatible with return type \\(Mage_Core_Controller_Varien_Action\\) of method Mage_Core_Block_Abstract\\:\\:getAction\\(\\)$#" + message: "#^Parameter \\#3 \\$false of method Varien_Db_Adapter_Pdo_Mysql\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Review/Block/Form.php + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Invoiced.php - - message: "#^Method Mage_Review_Model_Resource_Review\\:\\:getEntityIdByCode\\(\\) should return bool\\|int but returns string\\.$#" + message: "#^Parameter \\#1 \\$conn of method Varien_Data_Collection_Db\\:\\:setConnection\\(\\) expects Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface given\\.$#" count: 1 - path: ../app/code/core/Mage/Review/Model/Resource/Review.php + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Invoiced/Collection/Invoiced.php - - message: "#^Method Mage_Review_Model_Resource_Review\\:\\:getTotalReviews\\(\\) should return int but returns string\\.$#" + message: "#^Parameter \\#1 \\$conn of method Varien_Data_Collection_Db\\:\\:setConnection\\(\\) expects Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface given\\.$#" count: 1 - path: ../app/code/core/Mage/Review/Model/Resource/Review.php + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Invoiced/Collection/Order.php - - message: "#^Comparison operation \"\\=\\=\" between array\\|null and 1 results in an error\\.$#" + message: "#^Parameter \\#1 \\$conn of method Varien_Data_Collection_Db\\:\\:setConnection\\(\\) expects Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface given\\.$#" count: 1 - path: ../app/code/core/Mage/Review/Model/Resource/Review/Product/Collection.php + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Order/Collection.php - - message: "#^Comparison operation \"\\=\\=\" between array\\|null and 2 results in an error\\.$#" + message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Review/Model/Resource/Review/Product/Collection.php + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Order/Createdat.php - - message: "#^Cannot call method getId\\(\\) on true\\.$#" + message: "#^Parameter \\#1 \\$conn of method Varien_Data_Collection_Db\\:\\:setConnection\\(\\) expects Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface given\\.$#" count: 1 - path: ../app/code/core/Mage/Rss/Helper/Data.php + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Refunded/Collection/Order.php - - message: "#^Offset 'actions'\\|'conditions' on array\\{\\} in isset\\(\\) does not exist\\.$#" + message: "#^Parameter \\#1 \\$conn of method Varien_Data_Collection_Db\\:\\:setConnection\\(\\) expects Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface given\\.$#" count: 1 - path: ../app/code/core/Mage/Rule/Model/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Refunded/Collection/Refunded.php - - message: "#^Call to an undefined method Mage_Rule_Model_Action_Interface\\:\\:getId\\(\\)\\.$#" - count: 1 - path: ../app/code/core/Mage/Rule/Model/Action/Collection.php + message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, int given\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Shipping.php - - message: "#^Call to an undefined method Mage_Rule_Model_Action_Interface\\:\\:setId\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$conn of method Varien_Data_Collection_Db\\:\\:setConnection\\(\\) expects Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface given\\.$#" count: 1 - path: ../app/code/core/Mage/Rule/Model/Action/Collection.php + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Shipping/Collection/Order.php - - message: "#^Call to an undefined method Mage_Rule_Model_Action_Interface\\:\\:setRule\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$conn of method Varien_Data_Collection_Db\\:\\:setConnection\\(\\) expects Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface given\\.$#" count: 1 - path: ../app/code/core/Mage/Rule/Model/Action/Collection.php + path: ../app/code/core/Mage/Sales/Model/Resource/Report/Shipping/Collection/Shipment.php - - message: "#^Cannot call method loadArray\\(\\) on Mage_Core_Model_Abstract\\|false\\.$#" + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Rule/Model/Action/Collection.php + path: ../app/code/core/Mage/Sales/Model/Resource/Sale/Collection.php - - message: "#^Binary operation \"\\.\" between array and ' ' results in an error\\.$#" + message: "#^Call to an undefined method Varien_Db_Adapter_Interface\\:\\:listTables\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Rule/Model/Condition/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Resource/Setup.php - - message: "#^Variable \\$valueArr in empty\\(\\) always exists and is always falsy\\.$#" + message: "#^Call to an undefined method Mage_Payment_Model_Recurring_Profile\\:\\:submit\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Rule/Model/Condition/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Service/Quote.php - - message: "#^Method Mage_Rule_Model_Condition_Abstract\\:\\:loadArray\\(\\) invoked with 2 parameters, 1 required\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Rule/Model/Condition/Combine.php + path: ../app/code/core/Mage/Sales/Model/Service/Quote.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" + message: "#^Negated boolean expression is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Rule/Model/Condition/Product/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Service/Quote.php - - message: "#^Method Mage_Rule_Model_Condition_Product_Abstract\\:\\:getAttributeObject\\(\\) should return Mage_Catalog_Model_Resource_Eav_Attribute but returns Varien_Object\\|false\\.$#" + message: "#^Parameter \\#1 \\$message of static method Mage\\:\\:throwException\\(\\) expects string, array given\\.$#" count: 1 - path: ../app/code/core/Mage/Rule/Model/Condition/Product/Abstract.php + path: ../app/code/core/Mage/Sales/Model/Service/Quote.php - - message: "#^Cannot call method setParentFilter\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Block/Order/Comments.php + path: ../app/code/core/Mage/Sales/Model/Status/List.php - - message: "#^Property Mage_Sales_Block_Order_Comments\\:\\:\\$_commentCollection \\(Mage_Sales_Model_Resource_Order_Comment_Collection_Abstract\\) does not accept Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + message: "#^Method Mage_Sales_Billing_AgreementController\\:\\:preDispatch\\(\\) should return \\$this\\(Mage_Sales_Billing_AgreementController\\) but empty return statement found\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Block/Order/Comments.php + path: ../app/code/core/Mage/Sales/controllers/Billing/AgreementController.php - - message: "#^Property Mage_Sales_Block_Order_Comments\\:\\:\\$_commentCollection \\(Mage_Sales_Model_Resource_Order_Comment_Collection_Abstract\\) does not accept null\\.$#" + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Block/Order/Comments.php + path: ../app/code/core/Mage/Sales/controllers/Billing/AgreementController.php - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Creditmemo\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" - count: 1 - path: ../app/code/core/Mage/Sales/Block/Order/Creditmemo.php + message: "#^Variable \\$billingAgreement might not be defined\\.$#" + count: 2 + path: ../app/code/core/Mage/Sales/controllers/Billing/AgreementController.php - - message: "#^Call to method setOrderFilter\\(\\) on an unknown class Mage_Sales_Model_Resource_Invoice_Collection\\.$#" + message: "#^Comparison operation \"\\!\\=\" between int and \\(array\\\\|string\\) results in an error\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Block/Order/Details.php + path: ../app/code/core/Mage/Sales/controllers/DownloadController.php - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Email_Creditmemo_Items\\:\\:_prepareItem\\(\\) should be compatible with return type \\(\\$this\\(Mage_Sales_Block_Items_Abstract\\)\\) of method Mage_Sales_Block_Items_Abstract\\:\\:_prepareItem\\(\\)$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Block/Order/Email/Creditmemo/Items.php + path: ../app/code/core/Mage/Sales/controllers/DownloadController.php - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Email_Invoice_Items\\:\\:_prepareItem\\(\\) should be compatible with return type \\(\\$this\\(Mage_Sales_Block_Items_Abstract\\)\\) of method Mage_Sales_Block_Items_Abstract\\:\\:_prepareItem\\(\\)$#" + message: "#^Parameter \\#2 \\$loginUrl of method Mage_Customer_Model_Session\\:\\:authenticate\\(\\) expects bool\\|null, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Block/Order/Email/Invoice/Items.php + path: ../app/code/core/Mage/Sales/controllers/OrderController.php - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Email_Shipment_Items\\:\\:_prepareItem\\(\\) should be compatible with return type \\(\\$this\\(Mage_Sales_Block_Items_Abstract\\)\\) of method Mage_Sales_Block_Items_Abstract\\:\\:_prepareItem\\(\\)$#" + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Block/Order/Email/Shipment/Items.php + path: ../app/code/core/Mage/Sales/controllers/OrderController.php - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Info\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" + message: "#^Method Mage_Sales_Recurring_ProfileController\\:\\:preDispatch\\(\\) should return \\$this\\(Mage_Sales_Recurring_ProfileController\\) but empty return statement found\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Block/Order/Info.php + path: ../app/code/core/Mage/Sales/controllers/Recurring/ProfileController.php - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Invoice\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Block/Order/Invoice.php + path: ../app/code/core/Mage/Sales/controllers/Recurring/ProfileController.php - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Print\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Block/Order/Print.php + path: ../app/code/core/Mage/SalesRule/Model/Observer.php - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Print_Creditmemo\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" + message: "#^Parameter \\#1 \\$combine of method Mage_SalesRule_Model_Observer\\:\\:_removeAttributeFromConditions\\(\\) expects Mage_Rule_Model_Condition_Combine, Mage_Rule_Model_Action_Collection given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Block/Order/Print/Creditmemo.php + path: ../app/code/core/Mage/SalesRule/Model/Observer.php - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Print_Invoice\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" + message: "#^Parameter \\#2 \\$ruleId of method Mage_SalesRule_Model_Rule_Customer\\:\\:loadByCustomerRule\\(\\) expects int, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Block/Order/Print/Invoice.php + path: ../app/code/core/Mage/SalesRule/Model/Observer.php - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Print_Shipment\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" + message: "#^Return type \\(Mage_SalesRule_Model_Quote_Discount\\) of method Mage_SalesRule_Model_Quote_Discount\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Sales/Block/Order/Print/Shipment.php + path: ../app/code/core/Mage/SalesRule/Model/Quote/Discount.php - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Shipment\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" + message: "#^Return type \\(Mage_SalesRule_Model_Quote_Freeshipping\\) of method Mage_SalesRule_Model_Quote_Freeshipping\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Sales/Block/Order/Shipment.php + path: ../app/code/core/Mage/SalesRule/Model/Quote/Freeshipping.php - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_View\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" + message: "#^Return type \\(array\\) of method Mage_SalesRule_Model_Quote_Nominal_Discount\\:\\:fetch\\(\\) should be compatible with return type \\(Mage_SalesRule_Model_Quote_Discount\\) of method Mage_SalesRule_Model_Quote_Discount\\:\\:fetch\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Sales/Block/Order/View.php + path: ../app/code/core/Mage/SalesRule/Model/Quote/Nominal/Discount.php - - message: "#^Property Mage_Sales_Block_Recurring_Profiles\\:\\:\\$_profiles \\(Mage_Sales_Model_Resource_Recurring_Profile_Collection\\) does not accept Mage_Core_Model_Resource_Db_Collection_Abstract\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Block/Recurring/Profiles.php + path: ../app/code/core/Mage/SalesRule/Model/Resource/Coupon.php - - message: "#^Variable \\$oldArea might not be defined\\.$#" + message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Api2/Order/Comment/Rest/Admin/V1.php + path: ../app/code/core/Mage/SalesRule/Model/Resource/Coupon.php - - message: "#^Variable \\$oldStore might not be defined\\.$#" + message: "#^Parameter \\#2 \\$true of method Varien_Db_Adapter_Interface\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Api2/Order/Comment/Rest/Admin/V1.php + path: ../app/code/core/Mage/SalesRule/Model/Resource/Coupon/Collection.php - - message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:getClassName\\(\\)\\.$#" + message: "#^Parameter \\#3 \\$false of method Varien_Db_Adapter_Interface\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Config/Ordered.php + path: ../app/code/core/Mage/SalesRule/Model/Resource/Coupon/Collection.php - - message: "#^Call to an undefined method Mage_Sales_Model_Resource_Quote_Collection\\:\\:addAttributeToSelect\\(\\)\\.$#" - count: 2 - path: ../app/code/core/Mage/Sales/Model/Entity/Quote.php + message: "#^Binary operation \"\\+\\=\" between string and \\-1\\|1 results in an error\\.$#" + count: 1 + path: ../app/code/core/Mage/SalesRule/Model/Resource/Coupon/Usage.php - - message: "#^Return type \\(void\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Backend_Region\\:\\:beforeSave\\(\\) should be compatible with return type \\(\\$this\\(Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\)\\) of method Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\:\\:beforeSave\\(\\)$#" + message: "#^Else branch is unreachable because previous condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Backend/Region.php + path: ../app/code/core/Mage/SalesRule/Model/Resource/Coupon/Usage.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Custbalance\\)\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Custbalance\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Frontend/Custbalance.php + path: ../app/code/core/Mage/SalesRule/Model/Resource/Coupon/Usage.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Discount\\)\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Discount\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" + message: "#^Method Mage_SalesRule_Model_Resource_Report_Collection\\:\\:_applyRulesFilter\\(\\) should return \\$this\\(Mage_SalesRule_Model_Resource_Report_Collection\\) but return statement is missing\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Frontend/Discount.php + path: ../app/code/core/Mage/SalesRule/Model/Resource/Report/Collection.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Grand\\)\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Grand\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" + message: "#^Parameter \\#1 \\$conn of method Varien_Data_Collection_Db\\:\\:setConnection\\(\\) expects Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Frontend/Grand.php + path: ../app/code/core/Mage/SalesRule/Model/Resource/Report/Collection.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Shipping\\)\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Shipping\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Frontend/Shipping.php + path: ../app/code/core/Mage/SalesRule/Model/Rule.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Subtotal\\)\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Subtotal\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" + message: "#^Return type \\(Mage_SalesRule_Model_Rule_Condition_Product_Combine\\) of method Mage_SalesRule_Model_Rule\\:\\:getActionsInstance\\(\\) should be compatible with return type \\(Mage_Rule_Model_Action_Collection\\) of method Mage_Rule_Model_Abstract\\:\\:getActionsInstance\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Frontend/Subtotal.php + path: ../app/code/core/Mage/SalesRule/Model/Rule.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Tax\\)\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Tax\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Frontend/Tax.php + path: ../app/code/core/Mage/SalesRule/Model/Rule/Condition/Product/Attribute/Assigned.php - - message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_addresses \\(iterable\\&Mage_Sales_Model_Resource_Order_Address_Collection\\) does not accept null\\.$#" + message: "#^Return type \\(string\\) of method Mage_SalesRule_Model_Rule_Condition_Product_Attribute_Assigned\\:\\:getOperatorName\\(\\) should be compatible with return type \\(array\\) of method Mage_Rule_Model_Condition_Abstract\\:\\:getOperatorName\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order.php + path: ../app/code/core/Mage/SalesRule/Model/Rule/Condition/Product/Attribute/Assigned.php - - message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_creditmemos \\(\\(iterable\\&Mage_Sales_Model_Resource_Order_Creditmemo_Collection\\)\\|false\\) does not accept null\\.$#" + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order.php + path: ../app/code/core/Mage/SalesRule/Model/Rule/Condition/Product/Combine.php - - message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_invoices \\(Mage_Sales_Model_Resource_Order_Invoice_Collection\\) does not accept null\\.$#" - count: 1 - path: ../app/code/core/Mage/Sales/Model/Order.php + message: "#^Call to an undefined method Mage_Rule_Model_Action_Collection\\:\\:validate\\(\\)\\.$#" + count: 2 + path: ../app/code/core/Mage/SalesRule/Model/Validator.php - - message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_items \\(iterable\\&Mage_Sales_Model_Resource_Order_Item_Collection\\) does not accept null\\.$#" + message: "#^Parameter \\#1 \\$product of method Mage_Tax_Helper_Data\\:\\:getPrice\\(\\) expects Mage_Catalog_Model_Product, Mage_Sales_Model_Quote_Item_Abstract given\\.$#" count: 2 - path: ../app/code/core/Mage/Sales/Model/Order.php + path: ../app/code/core/Mage/SalesRule/Model/Validator.php - - message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_payments \\(iterable\\&Mage_Sales_Model_Resource_Order_Payment_Collection\\) does not accept null\\.$#" - count: 1 - path: ../app/code/core/Mage/Sales/Model/Order.php + message: "#^Parameter \\#2 \\$title of method Mage_Weee_Helper_Data\\:\\:setWeeeTaxesAppliedProperty\\(\\) expects string, null given\\.$#" + count: 2 + path: ../app/code/core/Mage/SalesRule/Model/Validator.php - - message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_shipments \\(Mage_Sales_Model_Resource_Order_Shipment_Collection\\|false\\) does not accept null\\.$#" + message: "#^Parameter \\#4 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order.php + path: ../app/code/core/Mage/SalesRule/Model/Validator.php - - message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_statusHistory \\(iterable\\&Mage_Sales_Model_Resource_Order_Status_History_Collection\\) does not accept null\\.$#" - count: 1 - path: ../app/code/core/Mage/Sales/Model/Order.php + message: "#^Parameter \\#4 \\$value of method Mage_Weee_Helper_Data\\:\\:setWeeeTaxesAppliedProperty\\(\\) expects string, \\(float\\|int\\) given\\.$#" + count: 2 + path: ../app/code/core/Mage/SalesRule/Model/Validator.php - - message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_tracks \\(Mage_Sales_Model_Resource_Order_Shipment_Track_Collection\\) does not accept null\\.$#" - count: 1 - path: ../app/code/core/Mage/Sales/Model/Order.php + message: "#^Parameter \\#4 \\$value of method Mage_Weee_Helper_Data\\:\\:setWeeeTaxesAppliedProperty\\(\\) expects string, float given\\.$#" + count: 2 + path: ../app/code/core/Mage/SalesRule/Model/Validator.php - - message: "#^Variable \\$oldArea might not be defined\\.$#" + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Api.php + path: ../app/code/core/Mage/Sendfriend/Model/Sendfriend.php - - message: "#^Variable \\$oldStore might not be defined\\.$#" + message: "#^Parameter \\#1 \\$ipAddr of method Mage_Sendfriend_Model_Sendfriend\\:\\:setRemoteAddr\\(\\) expects int, string\\|false given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Api.php + path: ../app/code/core/Mage/Sendfriend/controllers/ProductController.php - - message: "#^Cannot call method addAttributeToFilter\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Invoice.php + path: ../app/code/core/Mage/Sendfriend/controllers/ProductController.php - - message: "#^Property Mage_Sales_Model_Order_Invoice\\:\\:\\$_comments \\(iterable\\&Mage_Sales_Model_Resource_Order_Invoice_Comment_Collection\\) does not accept null\\.$#" + message: "#^Call to an undefined method Mage_Shipping_Model_Carrier_Abstract\\:\\:_getQuotes\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Invoice.php + path: ../app/code/core/Mage/Shipping/Model/Carrier/Abstract.php - - message: "#^Property Mage_Sales_Model_Order_Invoice\\:\\:\\$_items \\(iterable\\&Mage_Sales_Model_Resource_Order_Invoice_Item_Collection\\) does not accept null\\.$#" + message: "#^Call to an undefined method Mage_Shipping_Model_Carrier_Abstract\\:\\:_setFreeMethodRequest\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Invoice.php + path: ../app/code/core/Mage/Shipping/Model/Carrier/Abstract.php - - message: "#^Property Mage_Sales_Model_Order_Invoice\\:\\:\\$_order \\(Mage_Sales_Model_Order\\) does not accept null\\.$#" + message: "#^Left side of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Invoice.php + path: ../app/code/core/Mage/Shipping/Model/Carrier/Abstract.php - - message: "#^Property Varien_Object\\:\\:\\$_origData \\(array\\) does not accept null\\.$#" + message: "#^Method Mage_Shipping_Model_Carrier_Abstract\\:\\:checkAvailableShipCountries\\(\\) should return \\$this\\(Mage_Shipping_Model_Carrier_Abstract\\)\\|bool\\|Mage_Core_Model_Abstract but returns Mage_Shipping_Model_Rate_Result_Error\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Invoice.php + path: ../app/code/core/Mage/Shipping/Model/Carrier/Abstract.php - - message: "#^Property Mage_Sales_Model_Order_Invoice_Item\\:\\:\\$_orderItem \\(Mage_Sales_Model_Order_Item\\) does not accept Varien_Object\\|null\\.$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Invoice/Item.php + path: ../app/code/core/Mage/Shipping/Model/Carrier/Abstract.php - - message: "#^Call to an undefined method Mage_Catalog_Model_Product_Type_Abstract\\:\\:getForceApplyDiscountToParentItem\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$cost of method Mage_Shipping_Model_Carrier_Abstract\\:\\:getFinalPriceWithHandlingFee\\(\\) expects float, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Item.php + path: ../app/code/core/Mage/Shipping/Model/Carrier/Abstract.php - - message: "#^Method Mage_Sales_Model_Order_Payment\\:\\:_addTransaction\\(\\) should return Mage_Sales_Model_Order_Payment_Transaction\\|null but return statement is missing\\.$#" + message: "#^Parameter \\#2 \\$arguments of static method Mage\\:\\:getModel\\(\\) expects array\\|object, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Payment.php + path: ../app/code/core/Mage/Shipping/Model/Carrier/Abstract.php - - message: "#^Property Mage_Sales_Model_Order_Payment\\:\\:\\$_canVoidLookup \\(string\\) does not accept bool\\.$#" - count: 2 - path: ../app/code/core/Mage/Sales/Model/Order/Payment.php + message: "#^Property Mage_Shipping_Model_Carrier_Abstract\\:\\:\\$_numBoxes \\(int\\) does not accept float\\.$#" + count: 1 + path: ../app/code/core/Mage/Shipping/Model/Carrier/Abstract.php - - message: "#^Property Mage_Sales_Model_Order_Payment_Transaction\\:\\:\\$_identifiedChildren \\(array\\) does not accept false\\.$#" + message: "#^Variable \\$rate in empty\\(\\) is never defined\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php + path: ../app/code/core/Mage/Shipping/Model/Carrier/Pickup.php - - message: "#^Property Mage_Sales_Model_Order_Payment_Transaction\\:\\:\\$_order \\(Mage_Sales_Model_Order_Payment\\) does not accept Mage_Sales_Model_Order\\.$#" - count: 2 - path: ../app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php + message: "#^Method Mage_Shipping_Model_Carrier_Tablerate\\:\\:getRate\\(\\) should return Mage_Core_Model_Abstract but returns array\\|bool\\.$#" + count: 1 + path: ../app/code/core/Mage/Shipping/Model/Carrier/Tablerate.php - - message: "#^Property Mage_Sales_Model_Order_Payment_Transaction\\:\\:\\$_order \\(Mage_Sales_Model_Order_Payment\\) does not accept false\\.$#" - count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php + message: "#^Parameter \\#1 \\$result of method Mage_Shipping_Model_Rate_Result\\:\\:append\\(\\) expects Mage_Shipping_Model_Rate_Result\\|Mage_Shipping_Model_Rate_Result_Abstract, Mage_Core_Model_Abstract given\\.$#" + count: 3 + path: ../app/code/core/Mage/Shipping/Model/Carrier/Tablerate.php - - message: "#^Property Mage_Sales_Model_Order_Payment_Transaction\\:\\:\\$_parentTransaction \\(\\$this\\(Mage_Sales_Model_Order_Payment_Transaction\\)\\) does not accept Mage_Sales_Model_Order_Payment_Transaction\\.$#" + message: "#^Result of && is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php + path: ../app/code/core/Mage/Shipping/Model/Carrier/Tablerate.php - - message: "#^Property Mage_Sales_Model_Order_Payment_Transaction\\:\\:\\$_parentTransaction \\(\\$this\\(Mage_Sales_Model_Order_Payment_Transaction\\)\\) does not accept false\\.$#" - count: 2 - path: ../app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php + message: "#^Variable \\$rate in empty\\(\\) always exists and is not falsy\\.$#" + count: 3 + path: ../app/code/core/Mage/Shipping/Model/Carrier/Tablerate.php - - message: "#^Method Mage_Sales_Model_Order_Pdf_Abstract\\:\\:getAlignCenter\\(\\) should return int but returns float\\.$#" + message: "#^Parameter \\#1 \\$hash of method Mage_Shipping_Helper_Data\\:\\:decodeTrackingHash\\(\\) expects string, array given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php + path: ../app/code/core/Mage/Shipping/Model/Info.php - - message: "#^Method Mage_Sales_Model_Order_Pdf_Abstract\\:\\:getAlignRight\\(\\) should return int but returns float\\.$#" - count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 3 + path: ../app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate.php - - message: "#^Variable \\$shippingAddress might not be defined\\.$#" + message: "#^Parameter \\#1 \\$row of method Mage_Shipping_Model_Resource_Carrier_Tablerate\\:\\:_getImportRow\\(\\) expects array, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php + path: ../app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate.php - - message: "#^Variable \\$shippingMethod might not be defined\\.$#" + message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php + path: ../app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate.php - - message: "#^Variable \\$creditmemo might not be defined\\.$#" + message: "#^Result of && is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Creditmemo.php + path: ../app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate.php - - message: "#^Method Mage_Sales_Model_Order_Pdf_Items_Abstract\\:\\:getSku\\(\\) should return string but returns array\\.$#" + message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Items/Abstract.php + path: ../app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate.php - - message: "#^Variable \\$shipment might not be defined\\.$#" - count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Pdf/Shipment.php + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 4 + path: ../app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getStoreId\\(\\)\\.$#" + message: "#^Return type \\(void\\) of method Mage_Shipping_Model_Resource_Carrier_Tablerate_Collection\\:\\:_initSelect\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Resource_Db_Collection_Abstract\\)\\) of method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:_initSelect\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Order/Shipment/Api.php + path: ../app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate/Collection.php - - message: "#^Method Mage_Sales_Model_Quote\\:\\:getIsVirtual\\(\\) should return bool but returns int\\.$#" + message: "#^Comparison operation \"\\<\" between \\(array\\|float\\|int\\) and float results in an error\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote.php + path: ../app/code/core/Mage/Shipping/Model/Shipping.php - - message: "#^Property Mage_Sales_Model_Quote\\:\\:\\$_addresses \\(Mage_Sales_Model_Resource_Order_Address_Collection\\) does not accept Mage_Sales_Model_Resource_Quote_Address_Collection\\.$#" + message: "#^Comparison operation \"\\>\" between \\(array\\|float\\|int\\) and float results in an error\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote.php + path: ../app/code/core/Mage/Shipping/Model/Shipping.php - - message: "#^Variable \\$item might not be defined\\.$#" + message: "#^Instanceof between Mage_Core_Model_Abstract\\|Mage_Shipping_Model_Carrier_Abstract\\|true and Mage_Shipping_Model_Rate_Result_Error will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote.php + path: ../app/code/core/Mage/Shipping/Model/Shipping.php - - message: "#^Variable \\$old in empty\\(\\) always exists and is not falsy\\.$#" - count: 2 - path: ../app/code/core/Mage/Sales/Model/Quote.php + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Shipping/Model/Shipping.php - - message: "#^Method Mage_Sales_Model_Quote_Address\\:\\:getItemsCollection\\(\\) should return Mage_Eav_Model_Entity_Collection_Abstract but returns iterable\\&Mage_Sales_Model_Resource_Quote_Address_Item_Collection\\.$#" + message: "#^Property Mage_Shipping_Model_Shipping\\:\\:\\$_result \\(Mage_Shipping_Model_Rate_Result\\) in empty\\(\\) is not falsy\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote/Address.php + path: ../app/code/core/Mage/Shipping/Model/Shipping.php - - message: "#^Property Mage_Sales_Model_Quote_Address\\:\\:\\$_nominalOnly \\(bool\\) does not accept null\\.$#" - count: 2 - path: ../app/code/core/Mage/Sales/Model/Quote/Address.php + message: "#^Variable \\$sumResults in empty\\(\\) always exists and is not falsy\\.$#" + count: 1 + path: ../app/code/core/Mage/Shipping/Model/Shipping.php - - message: "#^Variable \\$totalInstance might not be defined\\.$#" - count: 3 - path: ../app/code/core/Mage/Sales/Model/Quote/Address.php + message: "#^Call to an undefined method Mage_Shipping_Model_Rate_Result\\:\\:getAllTrackings\\(\\)\\.$#" + count: 1 + path: ../app/code/core/Mage/Shipping/Model/Tracking/Result.php - - message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:getClassName\\(\\)\\.$#" + message: "#^Call to an undefined method Zend_Db_Adapter_Abstract\\:\\:getCheckSql\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Collector.php + path: ../app/code/core/Mage/Sitemap/Model/Resource/Catalog/Abstract.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Quote_Address_Total_Discount\\)\\) of method Mage_Sales_Model_Quote_Address_Total_Discount\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Discount.php + path: ../app/code/core/Mage/Sitemap/Model/Resource/Catalog/Abstract.php - - message: "#^Return type \\(Mage_Sales_Model_Quote_Address_Total_Grand\\) of method Mage_Sales_Model_Quote_Address_Total_Grand\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Grand.php + path: ../app/code/core/Mage/Sitemap/Model/Resource/Catalog/Category.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Quote_Address_Total_Nominal\\)\\) of method Mage_Sales_Model_Quote_Address_Total_Nominal\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Nominal.php + path: ../app/code/core/Mage/Sitemap/Model/Resource/Catalog/Product.php - - message: "#^Return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Nominal_Shipping\\:\\:fetch\\(\\) should be compatible with return type \\(Mage_Sales_Model_Quote_Address_Total_Shipping\\) of method Mage_Sales_Model_Quote_Address_Total_Shipping\\:\\:fetch\\(\\)$#" + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Nominal/Shipping.php + path: ../app/code/core/Mage/Sitemap/Model/Sitemap.php - - message: "#^Return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Nominal_Subtotal\\:\\:fetch\\(\\) should be compatible with return type \\(Mage_Sales_Model_Quote_Address_Total_Subtotal\\) of method Mage_Sales_Model_Quote_Address_Total_Subtotal\\:\\:fetch\\(\\)$#" + message: "#^Method Mage_Tag_Model_Resource_Tag_Collection\\:\\:addPopularity\\(\\) invoked with 2 parameters, 0\\-1 required\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Nominal/Subtotal.php + path: ../app/code/core/Mage/Tag/Block/Customer/Tags.php - - message: "#^Return type \\(Mage_Sales_Model_Quote_Address_Total_Shipping\\) of method Mage_Sales_Model_Quote_Address_Total_Shipping\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" + message: "#^Variable \\$tags in isset\\(\\) always exists and is not nullable\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Shipping.php + path: ../app/code/core/Mage/Tag/Block/Customer/Tags.php - - message: "#^Variable \\$addressQty in isset\\(\\) always exists and is not nullable\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Tag_Model_Resource_Product_Collection will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Shipping.php + path: ../app/code/core/Mage/Tag/Block/Customer/View.php - - message: "#^Return type \\(Mage_Sales_Model_Quote_Address_Total_Subtotal\\) of method Mage_Sales_Model_Quote_Address_Total_Subtotal\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" + message: "#^Call to function is_null\\(\\) with Mage_Tag_Model_Tag will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Subtotal.php + path: ../app/code/core/Mage/Tag/Block/Customer/View.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Quote_Address_Total_Tax\\)\\) of method Mage_Sales_Model_Quote_Address_Total_Tax\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote/Address/Total/Tax.php + path: ../app/code/core/Mage/Tag/Block/Product/List.php - - message: "#^Method Mage_Sales_Model_Quote_Item\\:\\:__clone\\(\\) with return type void returns \\$this\\(Mage_Sales_Model_Quote_Item\\) but should not return anything\\.$#" + message: "#^Method Mage_Tag_Block_Product_List\\:\\:_beforeToHtml\\(\\) should return \\$this\\(Mage_Tag_Block_Product_List\\) but returns false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote/Item.php + path: ../app/code/core/Mage/Tag/Block/Product/List.php - - message: "#^Method Mage_Sales_Model_Quote_Item\\:\\:save\\(\\) should return \\$this\\(Mage_Sales_Model_Quote_Item\\) but return statement is missing\\.$#" + message: "#^Parameter \\#1 \\$productId of method Mage_Tag_Model_Resource_Tag_Collection\\:\\:addProductFilter\\(\\) expects int, true given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote/Item.php + path: ../app/code/core/Mage/Tag/Block/Product/List.php - - message: "#^Property Mage_Sales_Model_Quote_Item\\:\\:\\$_quote \\(Mage_Sales_Model_Quote\\) does not accept null\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Tag_Model_Resource_Tag_Collection will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote/Item.php + path: ../app/code/core/Mage/Tag/Block/Product/Result.php - - message: "#^Return type \\(void\\) of method Mage_Sales_Model_Quote_Item\\:\\:__clone\\(\\) should be compatible with return type \\(\\$this\\(Mage_Sales_Model_Quote_Item_Abstract\\)\\) of method Mage_Sales_Model_Quote_Item_Abstract\\:\\:__clone\\(\\)$#" + message: "#^Property Mage_Tag_Block_Product_Result\\:\\:\\$_productCollection \\(Mage_Tag_Model_Resource_Tag_Collection\\) does not accept Mage_Tag_Model_Resource_Product_Collection\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote/Item.php + path: ../app/code/core/Mage/Tag/Block/Product/Result.php - - message: "#^Method Mage_Sales_Model_Quote_Item_Abstract\\:\\:__clone\\(\\) with return type void returns \\$this\\(Mage_Sales_Model_Quote_Item_Abstract\\) but should not return anything\\.$#" + message: "#^Variable \\$result might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php + path: ../app/code/core/Mage/Tag/Model/Api.php - - message: "#^Method Mage_Sales_Model_Quote_Item_Abstract\\:\\:getParentItem\\(\\) should return \\$this\\(Mage_Sales_Model_Quote_Item_Abstract\\) but returns Mage_Sales_Model_Quote_Item_Abstract\\.$#" + message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Tag_Model_Api_V2\\:\\:_prepareDataForAdd\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Tag_Model_Api\\:\\:_prepareDataForAdd\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php + path: ../app/code/core/Mage/Tag/Model/Api/V2.php - - message: "#^Property Mage_Sales_Model_Quote_Item_Abstract\\:\\:\\$_parentItem \\(Mage_Sales_Model_Quote_Item_Abstract\\) does not accept null\\.$#" + message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Tag_Model_Api_V2\\:\\:_prepareDataForUpdate\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Tag_Model_Api\\:\\:_prepareDataForUpdate\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php + path: ../app/code/core/Mage/Tag/Model/Api/V2.php - - message: "#^Method Mage_Sales_Model_Quote_Item_Option\\:\\:__clone\\(\\) with return type void returns \\$this\\(Mage_Sales_Model_Quote_Item_Option\\) but should not return anything\\.$#" + message: "#^Return type \\(object\\) of method Mage_Tag_Model_Api_V2\\:\\:info\\(\\) should be compatible with return type \\(array\\) of method Mage_Tag_Model_Api\\:\\:info\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Quote/Item/Option.php + path: ../app/code/core/Mage/Tag/Model/Api/V2.php - - message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:canGetRecurringProfileDetails\\(\\)\\.$#" + message: "#^Access to an undefined property Mage_Tag_Model_Entity_Customer_Collection\\:\\:\\$_read\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Recurring/Profile.php + path: ../app/code/core/Mage/Tag/Model/Entity/Customer/Collection.php - - message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:submitRecurringProfile\\(\\)\\.$#" + message: "#^Variable \\$productsSku might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Recurring/Profile.php + path: ../app/code/core/Mage/Tag/Model/Resource/Customer/Collection.php - - message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:updateRecurringProfileStatus\\(\\)\\.$#" - count: 3 - path: ../app/code/core/Mage/Sales/Model/Recurring/Profile.php + message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, int given\\.$#" + count: 7 + path: ../app/code/core/Mage/Tag/Model/Resource/Indexer/Summary.php - - message: "#^Method Mage_Sales_Model_Recurring_Profile\\:\\:_getItem\\(\\) should return Mage_Sales_Model_Order_Item but return statement is missing\\.$#" - count: 1 - path: ../app/code/core/Mage/Sales/Model/Recurring/Profile.php + message: "#^Parameter \\#5 \\$condition of method Mage_Catalog_Model_Resource_Product_Indexer_Abstract\\:\\:_addAttributeToSelect\\(\\) expects Zend_Db_Expr\\|null, string given\\.$#" + count: 2 + path: ../app/code/core/Mage/Tag/Model/Resource/Indexer/Summary.php - - message: "#^Cannot call method updateOnRelatedRecordChanged\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" + message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Resource/Order/Address.php + path: ../app/code/core/Mage/Tag/Model/Resource/Tag.php - - message: "#^Call to an undefined method Mage_Core_Model_Abstract\\:\\:isFailsafe\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$model of method Mage_Tag_Model_Resource_Tag\\:\\:loadByName\\(\\) expects Mage_Tag_Model_Tag, Varien_Object given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Resource/Order/Payment/Transaction.php + path: ../app/code/core/Mage/Tag/Model/Resource/Tag.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Custbalance\\)\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Custbalance\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" - count: 1 - path: ../app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend/Custbalance.php + message: "#^Parameter \\#2 \\$condition of method Mage_Tag_Model_Resource_Tag_Collection\\:\\:addFieldToFilter\\(\\) expects array\\|null, int given\\.$#" + count: 2 + path: ../app/code/core/Mage/Tag/Model/Resource/Tag/Collection.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Discount\\)\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Discount\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" + message: "#^Parameter \\#1 \\$date of method Mage_Core_Model_Resource_Abstract\\:\\:formatDate\\(\\) expects string\\|Zend_Date\\|true\\|null, int\\<1, max\\> given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend/Discount.php + path: ../app/code/core/Mage/Tag/Model/Resource/Tag/Relation.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Grand\\)\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Grand\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" + message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'aggregate' given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend/Grand.php + path: ../app/code/core/Mage/Tag/Model/Tag.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Shipping\\)\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Shipping\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" + message: "#^Parameter \\#1 \\$date of method Mage_Core_Model_Resource_Abstract\\:\\:formatDate\\(\\) expects string\\|Zend_Date\\|true\\|null, int\\<1, max\\> given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend/Shipping.php + path: ../app/code/core/Mage/Tag/Model/Tag.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Subtotal\\)\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Subtotal\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" + message: "#^Variable \\$result might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend/Subtotal.php + path: ../app/code/core/Mage/Tag/Model/Tag.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Tax\\)\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Tax\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" + message: "#^Parameter \\#1 \\$store of method Mage_Weee_Helper_Data\\:\\:validateCatalogPricesAndFptConfiguration\\(\\) expects Mage_Core_Model_Store\\|null, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend/Tax.php + path: ../app/code/core/Mage/Tax/Block/Adminhtml/Notifications.php - - message: "#^Comparison operation \"\\!\\=\" between array\\|int and 0 results in an error\\.$#" + message: "#^Call to an undefined method Mage_Tax_Block_Sales_Order_Tax\\:\\:addTotal\\(\\)\\.$#" + count: 7 + path: ../app/code/core/Mage/Tax/Block/Sales/Order/Tax.php + + - + message: "#^Call to an undefined method Mage_Tax_Block_Sales_Order_Tax\\:\\:removeTotal\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php + path: ../app/code/core/Mage/Tax/Block/Sales/Order/Tax.php - - message: "#^Variable \\$currentStoreIds in isset\\(\\) always exists and is not nullable\\.$#" + message: "#^Instanceof between Mage_Sales_Model_Order_Invoice and Mage_Sales_Model_Order will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php + path: ../app/code/core/Mage/Tax/Block/Sales/Order/Tax.php - - message: "#^Call to an undefined method Varien_Db_Adapter_Interface\\:\\:listTables\\(\\)\\.$#" + message: "#^Property Mage_Tax_Block_Sales_Order_Tax\\:\\:\\$_source \\(Mage_Sales_Model_Order_Invoice\\) does not accept Mage_Sales_Model_Order\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Resource/Setup.php + path: ../app/code/core/Mage/Tax/Block/Sales/Order/Tax.php - - message: "#^Call to an undefined method Mage_Payment_Model_Recurring_Profile\\:\\:submit\\(\\)\\.$#" + message: "#^Call to an undefined method Mage_Core_Model_App\\:\\:getOrder\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/Model/Service/Quote.php + path: ../app/code/core/Mage/Tax/Helper/Data.php - - message: "#^Method Mage_Sales_Billing_AgreementController\\:\\:preDispatch\\(\\) should return \\$this\\(Mage_Sales_Billing_AgreementController\\) but empty return statement found\\.$#" + message: "#^Elseif condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/controllers/Billing/AgreementController.php + path: ../app/code/core/Mage/Tax/Helper/Data.php - - message: "#^Variable \\$billingAgreement might not be defined\\.$#" + message: "#^If condition is always false\\.$#" count: 2 - path: ../app/code/core/Mage/Sales/controllers/Billing/AgreementController.php + path: ../app/code/core/Mage/Tax/Helper/Data.php - - message: "#^Comparison operation \"\\!\\=\" between int and \\(array\\|string\\) results in an error\\.$#" + message: "#^Method Mage_Tax_Helper_Data\\:\\:needPriceConversion\\(\\) should return int\\|false but returns bool\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/controllers/DownloadController.php + path: ../app/code/core/Mage/Tax/Helper/Data.php - - message: "#^Method Mage_Sales_Recurring_ProfileController\\:\\:preDispatch\\(\\) should return \\$this\\(Mage_Sales_Recurring_ProfileController\\) but empty return statement found\\.$#" + message: "#^Parameter \\#1 \\$product of method Mage_Tax_Helper_Data\\:\\:getPrice\\(\\) expects Mage_Catalog_Model_Product, Varien_Object given\\.$#" count: 1 - path: ../app/code/core/Mage/Sales/controllers/Recurring/ProfileController.php + path: ../app/code/core/Mage/Tax/Helper/Data.php - - message: "#^Return type \\(Mage_SalesRule_Model_Quote_Discount\\) of method Mage_SalesRule_Model_Quote_Discount\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" - count: 1 - path: ../app/code/core/Mage/SalesRule/Model/Quote/Discount.php + message: "#^Parameter \\#1 \\$shippingAddress of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects Mage_Sales_Model_Quote_Address\\|false\\|null, Mage_Customer_Model_Address\\|null given\\.$#" + count: 2 + path: ../app/code/core/Mage/Tax/Helper/Data.php - - message: "#^Return type \\(Mage_SalesRule_Model_Quote_Freeshipping\\) of method Mage_SalesRule_Model_Quote_Freeshipping\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" + message: "#^Parameter \\#1 \\$store of method Mage_Tax_Helper_Data\\:\\:isCrossBorderTradeEnabled\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" count: 1 - path: ../app/code/core/Mage/SalesRule/Model/Quote/Freeshipping.php + path: ../app/code/core/Mage/Tax/Helper/Data.php - - message: "#^Return type \\(array\\) of method Mage_SalesRule_Model_Quote_Nominal_Discount\\:\\:fetch\\(\\) should be compatible with return type \\(Mage_SalesRule_Model_Quote_Discount\\) of method Mage_SalesRule_Model_Quote_Discount\\:\\:fetch\\(\\)$#" - count: 1 - path: ../app/code/core/Mage/SalesRule/Model/Quote/Nominal/Discount.php + message: "#^Parameter \\#2 \\$billingAddress of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects Mage_Sales_Model_Quote_Address\\|false\\|null, Mage_Customer_Model_Address\\|null given\\.$#" + count: 2 + path: ../app/code/core/Mage/Tax/Helper/Data.php - - message: "#^Binary operation \"\\+\\=\" between string and \\-1\\|1 results in an error\\.$#" + message: "#^Parameter \\#2 \\$format of method Mage_Core_Model_Store\\:\\:convertPrice\\(\\) expects bool, string\\|null given\\.$#" count: 1 - path: ../app/code/core/Mage/SalesRule/Model/Resource/Coupon/Usage.php + path: ../app/code/core/Mage/Tax/Helper/Data.php - - message: "#^Method Mage_SalesRule_Model_Resource_Report_Collection\\:\\:_applyRulesFilter\\(\\) should return \\$this\\(Mage_SalesRule_Model_Resource_Report_Collection\\) but return statement is missing\\.$#" + message: "#^Parameter \\#4 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" + count: 2 + path: ../app/code/core/Mage/Tax/Helper/Data.php + + - + message: "#^Right side of && is always false\\.$#" count: 1 - path: ../app/code/core/Mage/SalesRule/Model/Resource/Report/Collection.php + path: ../app/code/core/Mage/Tax/Helper/Data.php - - message: "#^Return type \\(Mage_SalesRule_Model_Rule_Condition_Product_Combine\\) of method Mage_SalesRule_Model_Rule\\:\\:getActionsInstance\\(\\) should be compatible with return type \\(Mage_Rule_Model_Action_Collection\\) of method Mage_Rule_Model_Abstract\\:\\:getActionsInstance\\(\\)$#" + message: "#^Parameter \\#1 \\$request of method Mage_Tax_Model_Resource_Calculation\\:\\:getCalculationProcess\\(\\) expects Varien_Object, null given\\.$#" count: 1 - path: ../app/code/core/Mage/SalesRule/Model/Rule.php + path: ../app/code/core/Mage/Tax/Model/Calculation.php - - message: "#^Return type \\(string\\) of method Mage_SalesRule_Model_Rule_Condition_Product_Attribute_Assigned\\:\\:getOperatorName\\(\\) should be compatible with return type \\(array\\) of method Mage_Rule_Model_Condition_Abstract\\:\\:getOperatorName\\(\\)$#" + message: "#^Parameter \\#1 \\$store of method Mage_Tax_Helper_Data\\:\\:isCrossBorderTradeEnabled\\(\\) expects int\\|null, Mage_Core_Model_Store\\|null given\\.$#" count: 1 - path: ../app/code/core/Mage/SalesRule/Model/Rule/Condition/Product/Attribute/Assigned.php + path: ../app/code/core/Mage/Tax/Model/Calculation.php - - message: "#^Call to an undefined method Mage_Rule_Model_Action_Collection\\:\\:validate\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateOriginRequest\\(\\) expects Mage_Core_Model_Store\\|null, int\\|null given\\.$#" count: 2 - path: ../app/code/core/Mage/SalesRule/Model/Validator.php + path: ../app/code/core/Mage/Tax/Model/Calculation.php - - message: "#^Call to an undefined method Mage_Shipping_Model_Carrier_Abstract\\:\\:_getQuotes\\(\\)\\.$#" + message: "#^Parameter \\#4 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects int\\|null, Mage_Core_Model_Store\\|null given\\.$#" count: 1 - path: ../app/code/core/Mage/Shipping/Model/Carrier/Abstract.php + path: ../app/code/core/Mage/Tax/Model/Calculation.php - - message: "#^Call to an undefined method Mage_Shipping_Model_Carrier_Abstract\\:\\:_setFreeMethodRequest\\(\\)\\.$#" + message: "#^Property Mage_Tax_Model_Calculation\\:\\:\\$_customer \\(Mage_Customer_Model_Customer\\) does not accept false\\.$#" count: 1 - path: ../app/code/core/Mage/Shipping/Model/Carrier/Abstract.php + path: ../app/code/core/Mage/Tax/Model/Calculation.php - - message: "#^Method Mage_Shipping_Model_Carrier_Abstract\\:\\:checkAvailableShipCountries\\(\\) should return \\$this\\(Mage_Shipping_Model_Carrier_Abstract\\)\\|bool\\|Mage_Core_Model_Abstract but returns Mage_Shipping_Model_Rate_Result_Error\\.$#" + message: "#^Property Mage_Tax_Model_Calculation\\:\\:\\$_defaultCustomerTaxClass \\(string\\) does not accept int\\.$#" count: 1 - path: ../app/code/core/Mage/Shipping/Model/Carrier/Abstract.php + path: ../app/code/core/Mage/Tax/Model/Calculation.php - - message: "#^Property Mage_Shipping_Model_Carrier_Abstract\\:\\:\\$_numBoxes \\(int\\) does not accept float\\.$#" - count: 1 - path: ../app/code/core/Mage/Shipping/Model/Carrier/Abstract.php + message: "#^Right side of && is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Tax/Model/Calculation.php - - message: "#^Variable \\$rate in empty\\(\\) is never defined\\.$#" + message: "#^Call to function is_null\\(\\) with Mage_Tax_Model_Calculation_Rate_Title will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Shipping/Model/Carrier/Pickup.php + path: ../app/code/core/Mage/Tax/Model/Calculation/Rate.php - - message: "#^Method Mage_Shipping_Model_Carrier_Tablerate\\:\\:getRate\\(\\) should return Mage_Core_Model_Abstract but returns array\\|bool\\.$#" + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Shipping/Model/Carrier/Tablerate.php + path: ../app/code/core/Mage/Tax/Model/Calculation/Rate.php - - message: "#^Variable \\$rate in empty\\(\\) always exists and is not falsy\\.$#" - count: 3 - path: ../app/code/core/Mage/Shipping/Model/Carrier/Tablerate.php + message: "#^Property Mage_Tax_Model_Calculation_Rate\\:\\:\\$_titles \\(array\\) does not accept Mage_Tax_Model_Resource_Calculation_Rate_Title_Collection\\.$#" + count: 1 + path: ../app/code/core/Mage/Tax/Model/Calculation/Rate.php - - message: "#^Return type \\(void\\) of method Mage_Shipping_Model_Resource_Carrier_Tablerate_Collection\\:\\:_initSelect\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Resource_Db_Collection_Abstract\\)\\) of method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:_initSelect\\(\\)$#" + message: "#^Call to function is_null\\(\\) with Mage_Tax_Model_Calculation will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate/Collection.php + path: ../app/code/core/Mage/Tax/Model/Calculation/Rule.php - - message: "#^Comparison operation \"\\<\" between \\(array\\|float\\|int\\) and float results in an error\\.$#" + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Shipping/Model/Shipping.php + path: ../app/code/core/Mage/Tax/Model/Class/Source/Product.php - - message: "#^Comparison operation \"\\>\" between \\(array\\|float\\|int\\) and float results in an error\\.$#" + message: "#^Method Mage_Tax_Model_Config_Notification\\:\\:_getConfig\\(\\) should return Mage_Core_Model_Config_Data but returns bool\\|Mage_Core_Model_Abstract\\.$#" count: 1 - path: ../app/code/core/Mage/Shipping/Model/Shipping.php + path: ../app/code/core/Mage/Tax/Model/Config/Notification.php - - message: "#^Variable \\$sumResults in empty\\(\\) always exists and is not falsy\\.$#" + message: "#^Call to an undefined static method Mage_Core_Model_Config_Data\\:\\:afterSave\\(\\)\\.$#" count: 1 - path: ../app/code/core/Mage/Shipping/Model/Shipping.php + path: ../app/code/core/Mage/Tax/Model/Config/Price/Include.php - - message: "#^Call to an undefined method Mage_Shipping_Model_Rate_Result\\:\\:getAllTrackings\\(\\)\\.$#" + message: "#^Parameter \\#1 \\$tags of method Mage_Core_Model_App\\:\\:cleanCache\\(\\) expects array, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Shipping/Model/Tracking/Result.php + path: ../app/code/core/Mage/Tax/Model/Config/Price/Include.php - - message: "#^Call to an undefined method Zend_Db_Adapter_Abstract\\:\\:getCheckSql\\(\\)\\.$#" - count: 1 - path: ../app/code/core/Mage/Sitemap/Model/Resource/Catalog/Abstract.php + message: "#^Variable \\$selectClone might not be defined\\.$#" + count: 3 + path: ../app/code/core/Mage/Tax/Model/Resource/Calculation.php - - message: "#^Method Mage_Tag_Model_Resource_Tag_Collection\\:\\:addPopularity\\(\\) invoked with 2 parameters, 0\\-1 required\\.$#" + message: "#^Variable \\$zipFrom might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Tag/Block/Customer/Tags.php + path: ../app/code/core/Mage/Tax/Model/Resource/Calculation.php - - message: "#^Variable \\$tags in isset\\(\\) always exists and is not nullable\\.$#" + message: "#^Variable \\$zipTo might not be defined\\.$#" count: 1 - path: ../app/code/core/Mage/Tag/Block/Customer/Tags.php + path: ../app/code/core/Mage/Tax/Model/Resource/Calculation.php - - message: "#^Method Mage_Tag_Block_Product_List\\:\\:_beforeToHtml\\(\\) should return \\$this\\(Mage_Tag_Block_Product_List\\) but returns false\\.$#" + message: "#^Parameter \\#2 \\$resourceModel of method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:_init\\(\\) expects Mage_Core_Model_Resource_Db_Abstract\\|null, string given\\.$#" count: 1 - path: ../app/code/core/Mage/Tag/Block/Product/List.php + path: ../app/code/core/Mage/Tax/Model/Resource/Calculation/Rate/Title/Collection.php - - message: "#^Property Mage_Tag_Block_Product_Result\\:\\:\\$_productCollection \\(Mage_Tag_Model_Resource_Tag_Collection\\) does not accept Mage_Tag_Model_Resource_Product_Collection\\.$#" + message: "#^Parameter \\#1 \\$conn of method Varien_Data_Collection_Db\\:\\:setConnection\\(\\) expects Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface given\\.$#" count: 1 - path: ../app/code/core/Mage/Tag/Block/Product/Result.php + path: ../app/code/core/Mage/Tax/Model/Resource/Report/Collection.php - - message: "#^Variable \\$result might not be defined\\.$#" + message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, int given\\.$#" count: 1 - path: ../app/code/core/Mage/Tag/Model/Api.php + path: ../app/code/core/Mage/Tax/Model/Resource/Report/Tax/Createdat.php - - message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Tag_Model_Api_V2\\:\\:_prepareDataForAdd\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Tag_Model_Api\\:\\:_prepareDataForAdd\\(\\)$#" + message: "#^Negated boolean expression is always false\\.$#" count: 1 - path: ../app/code/core/Mage/Tag/Model/Api/V2.php + path: ../app/code/core/Mage/Tax/Model/Resource/Setup.php - - message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Tag_Model_Api_V2\\:\\:_prepareDataForUpdate\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Tag_Model_Api\\:\\:_prepareDataForUpdate\\(\\)$#" + message: "#^Return type \\(void\\) of method Mage_Tax_Model_Sales_Total_Quote_Discount\\:\\:collect\\(\\) should be compatible with return type \\(\\$this\\(Mage_Sales_Model_Quote_Address_Total_Abstract\\)\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:collect\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Tag/Model/Api/V2.php + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Discount.php - - message: "#^Return type \\(object\\) of method Mage_Tag_Model_Api_V2\\:\\:info\\(\\) should be compatible with return type \\(array\\) of method Mage_Tag_Model_Api\\:\\:info\\(\\)$#" + message: "#^Return type \\(array\\) of method Mage_Tax_Model_Sales_Total_Quote_Nominal_Tax\\:\\:fetch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Tax_Model_Sales_Total_Quote_Tax\\)\\) of method Mage_Tax_Model_Sales_Total_Quote_Tax\\:\\:fetch\\(\\)$#" count: 1 - path: ../app/code/core/Mage/Tag/Model/Api/V2.php + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Nominal/Tax.php - - message: "#^Access to an undefined property Mage_Tag_Model_Entity_Customer_Collection\\:\\:\\$_read\\.$#" + message: "#^Call to function is_null\\(\\) with Varien_Object will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Tag/Model/Entity/Customer/Collection.php + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Shipping.php - - message: "#^Variable \\$productsSku might not be defined\\.$#" + message: "#^Parameter \\#1 \\$store of method Mage_Tax_Helper_Data\\:\\:isCrossBorderTradeEnabled\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" count: 1 - path: ../app/code/core/Mage/Tag/Model/Resource/Customer/Collection.php + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Shipping.php - - message: "#^Variable \\$result might not be defined\\.$#" + message: "#^Parameter \\#1 \\$store of method Mage_Tax_Model_Config\\:\\:discountTax\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" count: 1 - path: ../app/code/core/Mage/Tag/Model/Tag.php + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Shipping.php - - message: "#^Call to an undefined method Mage_Tax_Block_Sales_Order_Tax\\:\\:addTotal\\(\\)\\.$#" - count: 7 - path: ../app/code/core/Mage/Tax/Block/Sales/Order/Tax.php + message: "#^Parameter \\#2 \\$rate of method Mage_Tax_Model_Sales_Total_Quote_Shipping\\:\\:_round\\(\\) expects string, float given\\.$#" + count: 4 + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Shipping.php - - message: "#^Call to an undefined method Mage_Tax_Block_Sales_Order_Tax\\:\\:removeTotal\\(\\)\\.$#" + message: "#^Parameter \\#2 \\$store of method Mage_Tax_Model_Calculation\\:\\:getStoreRate\\(\\) expects null, Mage_Core_Model_Store given\\.$#" count: 1 - path: ../app/code/core/Mage/Tax/Block/Sales/Order/Tax.php + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Shipping.php - - message: "#^Property Mage_Tax_Block_Sales_Order_Tax\\:\\:\\$_source \\(Mage_Sales_Model_Order_Invoice\\) does not accept Mage_Sales_Model_Order\\.$#" - count: 1 - path: ../app/code/core/Mage/Tax/Block/Sales/Order/Tax.php + message: "#^Parameter \\#4 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" + count: 2 + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Shipping.php - - message: "#^Call to an undefined method Mage_Core_Model_App\\:\\:getOrder\\(\\)\\.$#" + message: "#^Call to function is_null\\(\\) with Varien_Object will always evaluate to false\\.$#" count: 1 - path: ../app/code/core/Mage/Tax/Helper/Data.php + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Subtotal.php - - message: "#^Method Mage_Tax_Helper_Data\\:\\:needPriceConversion\\(\\) should return int\\|false but returns bool\\.$#" + message: "#^If condition is always true\\.$#" count: 1 - path: ../app/code/core/Mage/Tax/Helper/Data.php + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Subtotal.php - - message: "#^Property Mage_Tax_Model_Calculation\\:\\:\\$_customer \\(Mage_Customer_Model_Customer\\) does not accept false\\.$#" + message: "#^Parameter \\#1 \\$store of method Mage_Tax_Helper_Data\\:\\:isCrossBorderTradeEnabled\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" count: 1 - path: ../app/code/core/Mage/Tax/Model/Calculation.php + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Subtotal.php - - message: "#^Property Mage_Tax_Model_Calculation\\:\\:\\$_defaultCustomerTaxClass \\(string\\) does not accept int\\.$#" - count: 1 - path: ../app/code/core/Mage/Tax/Model/Calculation.php + message: "#^Parameter \\#1 \\$store of method Mage_Tax_Model_Config\\:\\:discountTax\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" + count: 4 + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Subtotal.php - - message: "#^Property Mage_Tax_Model_Calculation_Rate\\:\\:\\$_titles \\(array\\) does not accept Mage_Tax_Model_Resource_Calculation_Rate_Title_Collection\\.$#" + message: "#^Parameter \\#2 \\$rate of method Mage_Tax_Model_Sales_Total_Quote_Subtotal\\:\\:_deltaRound\\(\\) expects string, float given\\.$#" + count: 4 + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Subtotal.php + + - + message: "#^Parameter \\#2 \\$store of method Mage_Tax_Model_Calculation\\:\\:getStoreRate\\(\\) expects null, Mage_Core_Model_Store given\\.$#" + count: 4 + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Subtotal.php + + - + message: "#^Parameter \\#4 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" count: 1 - path: ../app/code/core/Mage/Tax/Model/Calculation/Rate.php + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Subtotal.php - - message: "#^Method Mage_Tax_Model_Config_Notification\\:\\:_getConfig\\(\\) should return Mage_Core_Model_Config_Data but returns bool\\|Mage_Core_Model_Abstract\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: ../app/code/core/Mage/Tax/Model/Config/Notification.php + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Subtotal.php - - message: "#^Call to an undefined static method Mage_Core_Model_Config_Data\\:\\:afterSave\\(\\)\\.$#" + message: "#^Empty array passed to foreach\\.$#" count: 1 - path: ../app/code/core/Mage/Tax/Model/Config/Price/Include.php + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - message: "#^Variable \\$selectClone might not be defined\\.$#" - count: 3 - path: ../app/code/core/Mage/Tax/Model/Resource/Calculation.php + message: "#^If condition is always true\\.$#" + count: 4 + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - message: "#^Variable \\$zipFrom might not be defined\\.$#" - count: 1 - path: ../app/code/core/Mage/Tax/Model/Resource/Calculation.php + message: "#^Parameter \\#1 \\$store of method Mage_Tax_Helper_Data\\:\\:isCrossBorderTradeEnabled\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" + count: 2 + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - message: "#^Variable \\$zipTo might not be defined\\.$#" + message: "#^Parameter \\#4 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" count: 1 - path: ../app/code/core/Mage/Tax/Model/Resource/Calculation.php + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - message: "#^Return type \\(void\\) of method Mage_Tax_Model_Sales_Total_Quote_Discount\\:\\:collect\\(\\) should be compatible with return type \\(\\$this\\(Mage_Sales_Model_Quote_Address_Total_Abstract\\)\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:collect\\(\\)$#" - count: 1 - path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Discount.php + message: "#^Parameter \\#4 \\$value of method Mage_Weee_Helper_Data\\:\\:setWeeeTaxesAppliedProperty\\(\\) expects string, \\(array\\|float\\|int\\) given\\.$#" + count: 4 + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - message: "#^Return type \\(array\\) of method Mage_Tax_Model_Sales_Total_Quote_Nominal_Tax\\:\\:fetch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Tax_Model_Sales_Total_Quote_Tax\\)\\) of method Mage_Tax_Model_Sales_Total_Quote_Tax\\:\\:fetch\\(\\)$#" - count: 1 - path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Nominal/Tax.php + message: "#^Parameter \\#4 \\$value of method Mage_Weee_Helper_Data\\:\\:setWeeeTaxesAppliedProperty\\(\\) expects string, \\(float\\|int\\) given\\.$#" + count: 4 + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - message: "#^Return type \\(\\$this\\(Mage_Tax_Model_Sales_Total_Quote_Tax\\)\\) of method Mage_Tax_Model_Sales_Total_Quote_Tax\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" count: 1 path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 3 + path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php + - message: "#^Variable \\$baseRowTax might not be defined\\.$#" count: 3 @@ -5770,6 +14980,21 @@ parameters: count: 1 path: ../app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php + - + message: "#^Call to function is_null\\(\\) with Mage_Uploader_Model_Config_Browsebutton will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Uploader/Block/Abstract.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Uploader_Model_Config_Misc will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Uploader/Block/Abstract.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Uploader_Model_Config_Uploader will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Uploader/Block/Abstract.php + - message: "#^Binary operation \"\\*\" between string and 1024 results in an error\\.$#" count: 1 @@ -5790,6 +15015,11 @@ parameters: count: 1 path: ../app/code/core/Mage/Uploader/Helper/File.php + - + message: "#^Parameter \\#2 \\$return of function print_r expects bool, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Uploader/Model/Config/Abstract.php + - message: "#^Method Mage_Widget_Block_Adminhtml_Widget_Chooser\\:\\:getConfig\\(\\) should return Varien_Object but returns mixed\\.$#" count: 2 @@ -5800,6 +15030,16 @@ parameters: count: 1 path: ../app/code/core/Mage/Widget/Block/Adminhtml/Widget/Form.php + - + message: "#^Parameter \\#1 \\$layoutHandles of method Mage_Widget_Block_Adminhtml_Widget_Instance_Edit_Chooser_Layout\\:\\:_collectLayoutHandles\\(\\) expects Mage_Core_Model_Layout_Element, SimpleXMLElement given\\.$#" + count: 1 + path: ../app/code/core/Mage/Widget/Block/Adminhtml/Widget/Instance/Edit/Chooser/Layout.php + + - + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" + count: 1 + path: ../app/code/core/Mage/Widget/Block/Adminhtml/Widget/Instance/Edit/Tab/Main.php + - message: "#^Variable \\$productsOptions might not be defined\\.$#" count: 1 @@ -5810,48 +15050,198 @@ parameters: count: 1 path: ../app/code/core/Mage/Widget/Block/Adminhtml/Widget/Options.php + - + message: "#^Parameter \\#1 \\$as_float of function microtime expects bool, int given\\.$#" + count: 1 + path: ../app/code/core/Mage/Widget/Block/Adminhtml/Widget/Options.php + + - + message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract given\\.$#" + count: 1 + path: ../app/code/core/Mage/Widget/Block/Adminhtml/Widget/Options.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Widget/Block/Adminhtml/Widget/Options.php + + - + message: "#^Parameter \\#1 \\$widgetInstance of method Mage_Widget_Model_Resource_Widget_Instance\\:\\:_saveLayoutUpdates\\(\\) expects Mage_Widget_Model_Widget_Instance, Mage_Core_Model_Abstract given\\.$#" + count: 1 + path: ../app/code/core/Mage/Widget/Model/Resource/Widget/Instance.php + + - + message: "#^Parameter \\#2 \\$mergeToObject of method Mage_Core_Model_Config\\:\\:loadModulesConfiguration\\(\\) expects Mage_Core_Model_Config_Base\\|null, Varien_Simplexml_Config given\\.$#" + count: 1 + path: ../app/code/core/Mage/Widget/Model/Widget.php + + - + message: "#^Comparison operation \"\\>\\=\" between int\\<0, max\\>\\|false and 0 is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Widget/Model/Widget/Instance.php + - message: "#^Variable \\$template might not be defined\\.$#" count: 1 path: ../app/code/core/Mage/Widget/Model/Widget/Instance.php + - + message: "#^Call to function is_null\\(\\) with Mage_Wishlist_Model_Resource_Item_Collection will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Block/Abstract.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Block/Customer/Sharing.php + - message: "#^Return type \\(void\\) of method Mage_Wishlist_Block_Customer_Sharing\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" count: 1 path: ../app/code/core/Mage/Wishlist/Block/Customer/Sharing.php + - + message: "#^Call to function is_null\\(\\) with Mage_Wishlist_Model_Resource_Item_Collection will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Block/Customer/Sidebar.php + - message: "#^Return type \\(void\\) of method Mage_Wishlist_Block_Customer_Wishlist\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Catalog_Block_Product_Abstract\\)\\) of method Mage_Catalog_Block_Product_Abstract\\:\\:_prepareLayout\\(\\)$#" count: 1 path: ../app/code/core/Mage/Wishlist/Block/Customer/Wishlist.php + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Block/Customer/Wishlist/Item/Column.php + + - + message: "#^Unreachable statement \\- code above always terminates\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Block/Customer/Wishlist/Item/Column.php + - message: "#^Parameter \\#1 \\$item \\(Mage_Wishlist_Model_Item\\) of method Mage_Wishlist_Block_Share_Email_Items\\:\\:hasDescription\\(\\) should be compatible with parameter \\$item \\(Mage_Catalog_Model_Product\\) of method Mage_Wishlist_Block_Abstract\\:\\:hasDescription\\(\\)$#" count: 1 path: ../app/code/core/Mage/Wishlist/Block/Share/Email/Items.php + - + message: "#^Parameter \\#1 \\$item of method Mage_Wishlist_Block_Abstract\\:\\:hasDescription\\(\\) expects Mage_Catalog_Model_Product, Mage_Wishlist_Model_Item given\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Block/Share/Email/Items.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Customer_Model_Customer will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Block/Share/Wishlist.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Wishlist_Model_Resource_Item_Collection will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Helper/Data.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Wishlist_Model_Resource_Product_Collection will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Helper/Data.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Wishlist_Model_Wishlist will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Helper/Data.php + + - + message: "#^If condition is always true\\.$#" + count: 2 + path: ../app/code/core/Mage/Wishlist/Helper/Data.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Helper/Data.php + + - + message: "#^Result of && is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Helper/Data.php + - message: "#^Method Mage_Wishlist_Model_Item\\:\\:save\\(\\) should return \\$this\\(Mage_Wishlist_Model_Item\\) but return statement is missing\\.$#" count: 1 path: ../app/code/core/Mage/Wishlist/Model/Item.php + - + message: "#^Negated boolean expression is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Model/Item.php + + - + message: "#^Parameter \\#1 \\$item of method Mage_Wishlist_Model_Resource_Item_Option_Collection\\:\\:addItemFilter\\(\\) expects array\\|int, \\$this\\(Mage_Wishlist_Model_Item\\) given\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Model/Item.php + + - + message: "#^Parameter \\#1 \\$message of class Mage_Core_Exception constructor expects string, null given\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Model/Item.php + + - + message: "#^Parameter \\#1 \\$option of method Mage_Wishlist_Model_Item\\:\\:addOption\\(\\) expects Mage_Wishlist_Model_Item_Option, array\\ given\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Model/Item.php + + - + message: "#^Result of && is always false\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Model/Item.php + - message: "#^Variable \\$buyRequest in empty\\(\\) always exists and is not falsy\\.$#" count: 2 path: ../app/code/core/Mage/Wishlist/Model/Item.php + - + message: "#^If condition is always true\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Model/Item/Option.php + - message: "#^Method Mage_Wishlist_Model_Item_Option\\:\\:__clone\\(\\) with return type void returns \\$this\\(Mage_Wishlist_Model_Item_Option\\) but should not return anything\\.$#" count: 1 path: ../app/code/core/Mage/Wishlist/Model/Item/Option.php + - + message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Model/Resource/Item/Collection.php + + - + message: "#^Parameter \\#1 \\$collection of method Mage_Adminhtml_Helper_Sales\\:\\:applySalableProductTypesFilter\\(\\) expects Mage_Core_Model_Resource_Db_Collection_Abstract, Mage_Catalog_Model_Resource_Product_Collection given\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Model/Resource/Item/Collection.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Store will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Model/Wishlist.php + + - + message: "#^Call to function is_null\\(\\) with Mage_Wishlist_Model_Resource_Item_Collection will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Model/Wishlist.php + + - + message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/Model/Wishlist.php + - message: "#^Variable \\$item might not be defined\\.$#" count: 1 path: ../app/code/core/Mage/Wishlist/Model/Wishlist.php - - message: "#^Comparison operation \"\\!\\=\" between int and \\(array\\|string\\) results in an error\\.$#" + message: "#^Comparison operation \"\\!\\=\" between int and \\(array\\\\|string\\) results in an error\\.$#" count: 1 path: ../app/code/core/Mage/Wishlist/controllers/IndexController.php @@ -5865,7 +15255,37 @@ parameters: count: 3 path: ../app/code/core/Mage/Wishlist/controllers/IndexController.php + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: ../app/code/core/Mage/Wishlist/controllers/IndexController.php + + - + message: "#^Parameter \\#1 \\$qty of method Mage_Wishlist_Model_Item\\:\\:setQty\\(\\) expects int, float given\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/controllers/IndexController.php + + - + message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + count: 1 + path: ../app/code/core/Mage/Wishlist/controllers/IndexController.php + - message: "#^Return type \\(void\\) of method Mage_Wishlist_IndexController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Controller_Front_Action\\)\\) of method Mage_Core_Controller_Front_Action\\:\\:preDispatch\\(\\)$#" count: 1 path: ../app/code/core/Mage/Wishlist/controllers/IndexController.php + + - + message: "#^Variable \\$cronMode might not be defined\\.$#" + count: 1 + path: ../cron.php + + - + message: "#^Parameter \\#2 \\$value of function ini_set expects string, int given\\.$#" + count: 1 + path: ../get.php + + - + message: "#^Variable \\$relativeFilename might not be defined\\.$#" + count: 4 + path: ../get.php diff --git a/.github/phpstan.neon b/.github/phpstan.neon index 95ace89b5b80..d4a076bf2f42 100644 --- a/.github/phpstan.neon +++ b/.github/phpstan.neon @@ -5,13 +5,20 @@ parameters: phpVersion: 80000 # PHP 8.0 magentoRootPath: %currentWorkingDirectory% paths: + - %currentWorkingDirectory%/api.php + - %currentWorkingDirectory%/cron.php + - %currentWorkingDirectory%/get.php + - %currentWorkingDirectory%/index.php + - %currentWorkingDirectory%/install.php + - %currentWorkingDirectory%/app/Mage.php - %currentWorkingDirectory%/app/code/core/Mage excludePaths: #todo DOCblocks - - %currentWorkingDirectory%/app/code/core/Mage/Centinel - - %currentWorkingDirectory%/app/code/core/Mage/PaypalUk - %currentWorkingDirectory%/app/code/core/Mage/Usa - %currentWorkingDirectory%/app/code/core/Mage/Weee + - %currentWorkingDirectory%/lib/Mage + - %currentWorkingDirectory%/lib/Magento + - %currentWorkingDirectory%/lib/Varien #incompatible interfaces - */app/code/core/Mage/Admin/Model/Acl/Assert/Ip.php @@ -20,6 +27,9 @@ parameters: - */app/code/core/Mage/Api/Model/Acl/Assert/Time.php - */app/code/core/Mage/Adminhtml/Block/Widget/Grid/Block.php - */app/code/core/Mage/Core/Model/Mysql4/Design/Theme/Collection.php + - */lib/Varien/Directory/Collection.php + - */lib/Varien/Directory/Factory.php + - */lib/Varien/File/Object.php # deprecated _getHelper() - */app/code/core/Mage/Adminhtml/Controller/Rss/Abstract.php @@ -30,25 +40,43 @@ parameters: - */app/code/core/Mage/Dataflow/Model/Session/Adapter/Http.php - */app/code/core/Mage/Dataflow/Model/Convert/Iterator/Http.php - */app/code/core/Mage/Dataflow/Model/Convert/Iterator/File/Csv.php + - */lib/Varien/Convert/Validator/Column.php # Cannot declare class Varien_Date, because the name is already in use - */app/code/core/Mage/Catalog/Model/Product/Option/Type/Date.php + # Cannot declare class XMLParser, because the name is already in use + - */app/code/core/Mage/Centinel/Model/Api.php + - */app/code/core/Mage/Centinel/Model/Api/Client.php + # Class phpseclib\Net\SSH2 not found. - - */Paypal/Model/Report/Settlement.php + - */app/code/core/Mage/Paypal/Model/Report/Settlement.php + - */lib/Varien/Io/Sftp.php # Class backup/db was not found while trying to analyse it - - */Adminhtml/controllers/System/BackupController.php + - */app/code/core/Mage/Adminhtml/controllers/System/BackupController.php # Dataflow/Model/Convert/Iterator.php - - */Dataflow/Model/Convert/Iterator.php + - */app/code/core/Mage/Dataflow/Model/Convert/Iterator.php # Too much noise from "Variable $this might not be defined" - */app/code/core/*/*/data/* - */app/code/core/*/*/sql/* - level: 3 + + # requires Mycrypt + - */lib/Magento/Crypt.php + - */lib/Varien/Crypt/Mcrypt.php + + # Instantiated class not found + - */lib/Varien/Image/Adapter.php + + # todo check + - */app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php + - */app/code/core/Mage/Weee/Model/Total/Quote/Weee.php + level: 5 checkFunctionNameCase: true checkInternalClassCaseSensitivity: true + treatPhpDocTypesAsCertain: false # universalObjectCratesClasses: # - Varien_Object diff --git a/.github/phpstan_experimental_level.neon b/.github/phpstan_experimental_level.neon deleted file mode 100644 index 76a004ba3d4d..000000000000 --- a/.github/phpstan_experimental_level.neon +++ /dev/null @@ -1,9 +0,0 @@ -includes: - - phpstan.neon -parameters: - paths: - - %currentWorkingDirectory%/app/code/core/Mage - - %currentWorkingDirectory%/lib/Mage - - %currentWorkingDirectory%/lib/Magento - - %currentWorkingDirectory%/lib/Varien - level: 4 diff --git a/.github/workflows/check-files.yml b/.github/workflows/check-files.yml new file mode 100644 index 000000000000..7b54b25e4c7e --- /dev/null +++ b/.github/workflows/check-files.yml @@ -0,0 +1,106 @@ +name: File checker + +on: + workflow_call: + outputs: + composer_count: + description: "Count changed Composer files" + value: ${{ jobs.check.outputs.composer_count }} + php_count: + description: "Count changed PHP files" + value: ${{ jobs.check.outputs.php_count }} + xml_count: + description: "Count changed XML files" + value: ${{ jobs.check.outputs.xml_count }} + ci_count: + description: "Count changed Workflow files" + value: ${{ jobs.check.outputs.ci_count }} + ci_phpcs_count: + description: "Count changed PHPCS files" + value: ${{ jobs.check.outputs.ci_phpcs_count }} + ci_php_cs_fixer_count: + description: "Count changed PHP-CS-Fixer files" + value: ${{ jobs.check.outputs.ci_php_cs_fixer_count }} + ci_phpstan_count: + description: "Count changed PHPStan files" + value: ${{ jobs.check.outputs.ci_phpstan_count }} + # Allow manually triggering the workflow. + workflow_dispatch: + +jobs: + check: + name: Changed + runs-on: [ubuntu-latest] + outputs: + composer_count: ${{ steps.all.outputs.composer_count }} + php_count: ${{ steps.all.outputs.php_count }} + xml_count: ${{ steps.all.outputs.xml_count }} + ci_count: ${{ steps.all.outputs.ci_count }} + ci_phpcs_count: ${{ steps.all.outputs.ci_phpcs_count }} + ci_php_cs_fixer_count: ${{ steps.all.outputs.ci_php_cs_fixer_count }} + ci_phpstan_count: ${{ steps.all.outputs.ci_phpstan_count }} + + steps: + - name: Checkout code + uses: actions/checkout@v3 + with: + fetch-depth: 2 + + - name: Get composer cache directory + id: composer-cache + run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT + + - name: Cache dependencies + uses: actions/cache@v3 + with: + path: ${{ steps.composer-cache.outputs.dir }} + key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }} + restore-keys: ${{ runner.os }}-composer- + + - name: Get changed files + id: changed-files-specific + uses: tj-actions/changed-files@v34 + with: + files: | + composer.* + *.php + **/*.php + **/*.xml + .github/workflows/** + .github/**phpcs** + .github/**php-cs-fixer** + .github/**phpstan** + + - name: Run step if any file(s) changed + id: all + if: steps.changed-files-specific.outputs.any_changed == 'true' + run: | + echo "One or more files have changed." + + count="$(grep -oE "composer.*" <<< "${{ steps.changed-files-specific.outputs.all_changed_files }}" | wc -l)" + echo "$count Composer file(s) changed" + echo "composer_count=$count" >> $GITHUB_OUTPUT + + count="$(grep -oE "*.php" <<< "${{ steps.changed-files-specific.outputs.all_changed_files }}" | wc -l)" + echo "$count PHP file(s) changed" + echo "php_count=$count" >> $GITHUB_OUTPUT + + count="$(grep -oE "*.xml" <<< "${{ steps.changed-files-specific.outputs.all_changed_files }}" | wc -l)" + echo "$count XML file(s) changed" + echo "xml_count=$count" >> $GITHUB_OUTPUT + + count="$(grep -oE ".github/workflows/**" <<< "${{ steps.changed-files-specific.outputs.all_changed_files }}" | wc -l)" + echo "$count Workflow file(s) changed" + echo "ci_count=$count" >> $GITHUB_OUTPUT + + count="$(grep -oE ".github/**phpcs**" <<< "${{ steps.changed-files-specific.outputs.all_changed_files }}" | wc -l)" + echo "$count PHPCS file(s) changed" + echo "ci_phpcs_count=$count" >> $GITHUB_OUTPUT + + count="$(grep -oE ".github/**php-cs-fixer**" <<< "${{ steps.changed-files-specific.outputs.all_changed_files }}" | wc -l)" + echo "$count PHP-CS-Fixer file(s) changed" + echo "ci_php_cs_fixer_count=$count" >> $GITHUB_OUTPUT + + count="$(grep -oE ".github/**phpstan**" <<< "${{ steps.changed-files-specific.outputs.all_changed_files }}" | wc -l)" + echo "$count PHPStan file(s) changed" + echo "ci_phpstan_count=$count" >> $GITHUB_OUTPUT diff --git a/.github/workflows/composer.yml b/.github/workflows/composer.yml new file mode 100644 index 000000000000..56929a37c256 --- /dev/null +++ b/.github/workflows/composer.yml @@ -0,0 +1,29 @@ +name: Composer + +on: + workflow_call: + # Allow manually triggering the workflow. + workflow_dispatch: + +jobs: + composer: + name: Validation + runs-on: [ubuntu-latest] + + steps: + - name: Checkout code + uses: actions/checkout@v3 + + - name: Get composer cache directory + id: composer-cache + run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT + + - name: Cache dependencies + uses: actions/cache@v3 + with: + path: ${{ steps.composer-cache.outputs.dir }} + key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }} + restore-keys: ${{ runner.os }}-composer- + + - name: Validate composer + run: composer validate --strict diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml index e859a082bdfa..c6d6044d2506 100644 --- a/.github/workflows/labeler.yml +++ b/.github/workflows/labeler.yml @@ -7,10 +7,11 @@ name: Labeler on: - - pull_request_target + pull_request_target: jobs: triage: + name: Add labels runs-on: [ubuntu-latest] steps: - uses: actions/labeler@main diff --git a/.github/workflows/php-cs-fixer.yml b/.github/workflows/php-cs-fixer.yml new file mode 100644 index 000000000000..a67e03c865a7 --- /dev/null +++ b/.github/workflows/php-cs-fixer.yml @@ -0,0 +1,32 @@ +name: PHP-CS-Fixer + +on: + workflow_call: + # Allow manually triggering the workflow. + workflow_dispatch: + +jobs: + php-cs-fixer: + name: Validation + runs-on: [ubuntu-latest] + + steps: + - name: Checkout code + uses: actions/checkout@v3 + + - name: Get composer cache directory + id: composer-cache + run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT + + - name: Cache dependencies + uses: actions/cache@v3 + with: + path: ${{ steps.composer-cache.outputs.dir }} + key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }} + restore-keys: ${{ runner.os }}-composer- + + - name: Install dependencies + run: composer install --prefer-dist --no-progress --ignore-platform-req=ext-* + + - name: PHP-CS-Fixer + run: php vendor/bin/php-cs-fixer fix --config=.github/php-cs-fixer-ruleset.php --diff --dry-run diff --git a/.github/workflows/phpcs.yml b/.github/workflows/phpcs.yml index 2d9a18be9ae8..f41a2bca9625 100644 --- a/.github/workflows/phpcs.yml +++ b/.github/workflows/phpcs.yml @@ -1,50 +1,35 @@ -name: "PHPCodeSniffer Code Style Analyses" +name: PHPCodeSniffer Code Style Analyses on: - # Run on all pushes and on all pull requests. - # Prevent the build from running when there are only irrelevant changes. - push: - paths: - - '**.php' - - '.github/phpcs*' - - '.github/workflows/phpcs*' - pull_request: - paths: - - '**.php' - - '.github/phpcs*' - - '.github/workflows/phpcs*' + workflow_call: # Allow manually triggering the workflow. workflow_dispatch: jobs: phpcs: + name: ${{ matrix.rules.label }} runs-on: [ubuntu-latest] strategy: matrix: - paths: [ - 'app/code/core/Mage/', - 'lib/Mage/', - 'lib/Magento/', - 'lib/Varien/', - 'app/code/community/' - ] - - name: PHPCodeSniffer ${{ matrix.paths }} + rules: + - label: Default + path: .github/phpcs-ruleset.xml + - label: Ecg + path: .github/phpcs-ruleset-ecg.xml + - label: PhpCompatibitliy + path: .github/phpcs-ruleset-php.xml steps: - name: Checkout code uses: actions/checkout@v3 - - name: Validate composer - run: composer validate --strict - - name: Get composer cache directory id: composer-cache run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT - name: Cache dependencies - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ steps.composer-cache.outputs.dir }} key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }} @@ -54,5 +39,5 @@ jobs: run: composer install --prefer-dist --no-progress --ignore-platform-req=ext-* - name: PHPCodeSniffer - run: php vendor/bin/phpcs -s --report=full --standard=.github/phpcs-ruleset.xml ${{ matrix.paths }} - continue-on-error: ${{ matrix.paths == 'app/code/community/' }} + run: php vendor/bin/phpcs -s --report=full --standard=${{ matrix.rules.path }} + continue-on-error: ${{ matrix.rules.path != '.github/phpcs-ruleset.xml' }} diff --git a/.github/workflows/phpstan.yml b/.github/workflows/phpstan.yml index 1474e68ab646..0ea2a79da240 100644 --- a/.github/workflows/phpstan.yml +++ b/.github/workflows/phpstan.yml @@ -1,47 +1,24 @@ -name: "PHPStan Static Code Analyses" +name: PHPStan Static Code Analyses on: - # Run on all pushes and on all pull requests. - # Prevent the build from running when there are only irrelevant changes. - push: - paths: - - '**.php' - - '.github/phpstan*' - - '.github/workflows/phpstan*' - pull_request: - paths: - - '**.php' - - '.github/phpstan*' - - '.github/workflows/phpstan*' + workflow_call: # Allow manually triggering the workflow. workflow_dispatch: jobs: - php_stan: + phpstan: + name: Analyze runs-on: [ubuntu-latest] - strategy: - matrix: - config_files: [ - '.github/phpstan.neon', - '.github/phpstan_experimental_level.neon' - ] - - name: PHP Stan ${{ matrix.config_files }} - steps: - - name: Checkout code - uses: actions/checkout@v3 - - - name: Validate composer - run: composer validate --strict + - uses: actions/checkout@v3 - name: Get composer cache directory id: composer-cache run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT - name: Cache dependencies - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ steps.composer-cache.outputs.dir }} key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }} @@ -50,9 +27,5 @@ jobs: - name: Install dependencies run: composer install --prefer-dist --no-progress --ignore-platform-req=ext-* - - name: ensure existance of ./app/code/local - run: mkdir -p app/code/local - - name: PHPStan Static Analysis - run: php vendor/bin/phpstan.phar analyze -c ${{ matrix.config_files }} - continue-on-error: ${{ matrix.config_files == '.github/phpstan_experimental_level.neon' }} + run: XDEBUG_MODE=off php vendor/bin/phpstan.phar analyze -c .github/phpstan.neon \ No newline at end of file diff --git a/.github/workflows/phpunit.yml b/.github/workflows/phpunit.yml index 227aed35ac8a..af56289bc1cc 100644 --- a/.github/workflows/phpunit.yml +++ b/.github/workflows/phpunit.yml @@ -1,16 +1,7 @@ name: OpenMage LTS - Unit Tests on: - # Run on all pushes and on all pull requests. - # Prevent the build from running when there are only irrelevant changes. - push: - paths: - - '**.php' - - '.github/workflows/phpunit*' - pull_request: - paths: - - '**.php' - - '.github/workflows/phpunit*' + workflow_call: # Allow manually triggering the workflow. workflow_dispatch: @@ -32,7 +23,7 @@ jobs: run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT - name: Cache dependencies - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ steps.composer-cache.outputs.dir }} key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }} diff --git a/.github/workflows/security-php.yml b/.github/workflows/security-php.yml index 6cd27c8b2561..d63564f63b96 100644 --- a/.github/workflows/security-php.yml +++ b/.github/workflows/security-php.yml @@ -1,4 +1,4 @@ -name: "PHP Security Check" +name: PHP Security Check on: # Run automatically every Monday on midnight. @@ -18,7 +18,7 @@ jobs: steps: - uses: actions/checkout@v3 - - uses: actions/cache@v2 + - uses: actions/cache@v3 id: cache-db with: path: ~/.symfony/cache diff --git a/.github/workflows/sonar.yml b/.github/workflows/sonar.yml index df569949363b..fbb6205723e6 100644 --- a/.github/workflows/sonar.yml +++ b/.github/workflows/sonar.yml @@ -1,15 +1,9 @@ name: OpenMage LTS - Sonar - Full Analyses on: - # Run on all pushes and on all pull requests. - # Prevent the build from running when there are only irrelevant changes. - push: - paths-ignore: - - '**.md' - pull_request: - paths-ignore: - - '**.md' - types: [opened, synchronize, reopened] + workflow_call: + # Allow manually triggering the workflow. + workflow_dispatch: jobs: unit: @@ -41,7 +35,7 @@ jobs: run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT - name: Cache dependencies - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ steps.composer-cache.outputs.dir }} key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }} diff --git a/.github/workflows/syntax-php.yml b/.github/workflows/syntax-php.yml index d0107e20202d..62072801fdb9 100644 --- a/.github/workflows/syntax-php.yml +++ b/.github/workflows/syntax-php.yml @@ -1,23 +1,12 @@ -name: "PHP Syntax Check" +name: PHP Validatation on: - # Run on all pushes and on all pull requests. - # Prevent the build from running when there are only irrelevant changes. - push: - paths: - - '**.php' - - '**.phtml' - - '.github/workflows/syntax-php.yml' - pull_request: - paths: - - '**.php' - - '**.phtml' - - '.github/workflows/syntax-php.yml' + workflow_call: # Allow manually triggering the workflow. workflow_dispatch: jobs: - php_syntax: + syntax_php: runs-on: [ubuntu-latest] strategy: diff --git a/.github/workflows/syntax-xml.yml b/.github/workflows/syntax-xml.yml index 2448e8472708..a51d3e4f593e 100644 --- a/.github/workflows/syntax-xml.yml +++ b/.github/workflows/syntax-xml.yml @@ -1,23 +1,15 @@ name: XML Validation on: - # Run on all pushes and on all pull requests. - # Prevent the build from running when there are only irrelevant changes. - push: - paths: - - '**.xml' - - '.github/workflows/syntax-xml.yml' - pull_request: - paths: - - '**.xml' - - '.github/workflows/syntax-xml.yml' + workflow_call: # Allow manually triggering the workflow. workflow_dispatch: jobs: - validate: + syntax_xml: + name: XML Validation runs-on: [ubuntu-latest] - + steps: - name: Checkout code uses: actions/checkout@v3 diff --git a/.github/workflows/workflow.yml b/.github/workflows/workflow.yml new file mode 100644 index 000000000000..c3b9b1a0975e --- /dev/null +++ b/.github/workflows/workflow.yml @@ -0,0 +1,80 @@ +name: CI + +on: + push: + paths: + - '.github/**' + - 'composer.json' + - 'composer.lock' + - '**.php' + - '**.xml' + + pull_request: + paths: + - '.github/**' + - 'composer.json' + - 'composer.lock' + - '**.php' + - '**.xml' + +jobs: + debug: + name: Debug + runs-on: [ubuntu-latest] + steps: + - name: Dump GitHub context + env: + GITHUB_CONTEXT: ${{ toJSON(github) }} + run: echo "$GITHUB_CONTEXT" + + check: + name: Check files + uses: ./.github/workflows/check-files.yml + + composer: + name: Composer + needs: [check] + if: needs.check.outputs.composer_count > 0 + uses: ./.github/workflows/composer.yml + + phpcs: + name: PHPCS + needs: [check] + if: needs.check.outputs.php_count > 0 || needs.check.outputs.ci_phpcs_count > 0 || needs.check.outputs.composer_count > 0 || needs.check.outputs.ci_count > 0 + uses: ./.github/workflows/phpcs.yml + + php-cs-fixer: + name: PHP-CS-Fixer + needs: [check] + if: needs.check.outputs.php_count > 0 || needs.check.outputs.ci_php_cs_fixer_count > 0 || needs.check.outputs.composer_count > 0 || needs.check.outputs.ci_count > 0 + uses: ./.github/workflows/php-cs-fixer.yml + + phpstan: + name: PHPStan + needs: [check] + if: needs.check.outputs.php_count > 0 || needs.check.outputs.ci_phpstan_count > 0 || needs.check.outputs.composer_count > 0 || needs.check.outputs.ci_count > 0 + uses: ./.github/workflows/phpstan.yml + + syntax_php: + name: Syntax + needs: [check, phpcs, php-cs-fixer] + if: needs.check.outputs.php_count > 0 || needs.check.outputs.composer_count > 0 + uses: ./.github/workflows/syntax-php.yml + + syntax_xml: + name: Syntax + needs: [check] + if: needs.check.outputs.xml_count > 0 + uses: ./.github/workflows/syntax-xml.yml + + sonar: + name: Sonar Unit Tests + needs: [check, phpcs, php-cs-fixer] + if: needs.check.outputs.php_count > 0 || needs.check.outputs.composer_count > 0 || needs.check.outputs.ci_count > 0 + uses: ./.github/workflows/sonar.yml + + unit_tests: + name: OpenMage LTS - Unit Tests + needs: [check, sonar] + if: needs.check.outputs.php_count > 0 || needs.check.outputs.composer_count > 0 || needs.check.outputs.ci_count > 0 + uses: ./.github/workflows/phpunit.yml diff --git a/.gitignore b/.gitignore index 2fc93493a16e..e55153fdbd86 100644 --- a/.gitignore +++ b/.gitignore @@ -58,3 +58,6 @@ # .phar (n98-magerun, ...) *.phar + +# PHP-CS-Fixer cache +.php-cs-fixer.cache \ No newline at end of file diff --git a/api.php b/api.php index c8e2ff60f3c6..bccd0ccada36 100644 --- a/api.php +++ b/api.php @@ -19,7 +19,7 @@ * @license https://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0) */ -if (version_compare(phpversion(), '7.3.0', '<')===true) { +if (version_compare(phpversion(), '7.3.0', '<') === true) { echo 'It looks like you have an invalid PHP version. OpenMage supports PHP 7.3.0 or newer'; exit; } @@ -56,7 +56,7 @@ if (in_array($apiAlias, Mage_Api2_Model_Server::getApiTypes())) { // emulate index.php entry point for correct URLs generation in API Mage::register('custom_entry_point', true); - /** @var $server Mage_Api2_Model_Server */ + /** @var Mage_Api2_Model_Server $server */ $server = Mage::getSingleton('api2/server'); $server->run(); diff --git a/app/Mage.php b/app/Mage.php index da389ece4209..4c4f8a607ef7 100644 --- a/app/Mage.php +++ b/app/Mage.php @@ -68,71 +68,71 @@ final class Mage * * @var array */ - static private $_registry = []; + private static $_registry = []; /** * Application root absolute path * - * @var string + * @var string|null */ - static private $_appRoot; + private static $_appRoot; /** * Application model * - * @var Mage_Core_Model_App + * @var Mage_Core_Model_App|null */ - static private $_app; + private static $_app; /** * Config Model * - * @var Mage_Core_Model_Config + * @var Mage_Core_Model_Config|null */ - static private $_config; + private static $_config; /** * Event Collection Object * - * @var Varien_Event_Collection + * @var Varien_Event_Collection|null */ - static private $_events; + private static $_events; /** * Object cache instance * - * @var Varien_Object_Cache + * @var Varien_Object_Cache|null */ - static private $_objects; + private static $_objects; /** * Is developer mode flag * * @var bool */ - static private $_isDeveloperMode = false; + private static $_isDeveloperMode = false; /** * Is allow throw Exception about headers already sent * * @var bool */ - public static $headersSentThrowsException = true; + public static $headersSentThrowsException = true; /** * Is installed flag * - * @var bool + * @var bool|null */ - static private $_isInstalled; + private static $_isInstalled; /** * Magento edition constants */ - const EDITION_COMMUNITY = 'Community'; - const EDITION_ENTERPRISE = 'Enterprise'; - const EDITION_PROFESSIONAL = 'Professional'; - const EDITION_GO = 'Go'; + public const EDITION_COMMUNITY = 'Community'; + public const EDITION_ENTERPRISE = 'Enterprise'; + public const EDITION_PROFESSIONAL = 'Professional'; + public const EDITION_GO = 'Go'; /** * Current Magento edition. @@ -140,7 +140,7 @@ final class Mage * @var string * @static */ - static private $_currentEdition = self::EDITION_COMMUNITY; + private static $_currentEdition = self::EDITION_COMMUNITY; /** * Gets the current Magento version string @@ -182,9 +182,9 @@ public static function getOpenMageVersion() { $i = self::getOpenMageVersionInfo(); $versionString = "{$i['major']}.{$i['minor']}.{$i['patch']}"; - if ( $i['stability'] || $i['number'] ) { + if ($i['stability'] || $i['number']) { $versionString .= "-"; - if ( $i['stability'] && $i['number'] ) { + if ($i['stability'] && $i['number']) { $versionString .= implode('.', [$i['stability'], $i['number']]); } else { $versionString .= implode('', [$i['stability'], $i['number']]); @@ -240,7 +240,7 @@ public static function getOpenMageVersionInfo() */ public static function getEdition() { - return self::$_currentEdition; + return self::$_currentEdition; } /** @@ -274,7 +274,7 @@ public static function register($key, $value, $graceful = false) if ($graceful) { return; } - self::throwException('Mage registry key "'.$key.'" already exists'); + self::throwException('Mage registry key "' . $key . '" already exists'); } self::$_registry[$key] = $value; } @@ -360,7 +360,7 @@ public static function getEvents() public static function objects($key = null) { if (!self::$_objects) { - self::$_objects = new Varien_Object_Cache; + self::$_objects = new Varien_Object_Cache(); } if (is_null($key)) { return self::$_objects; @@ -497,9 +497,9 @@ public static function addObserver($eventName, $callback, $data = [], $observerN */ public static function dispatchEvent($name, array $data = []) { - Varien_Profiler::start('DISPATCH EVENT:'.$name); + Varien_Profiler::start('DISPATCH EVENT:' . $name); $result = self::app()->dispatchEvent($name, $data); - Varien_Profiler::stop('DISPATCH EVENT:'.$name); + Varien_Profiler::stop('DISPATCH EVENT:' . $name); return $result; } @@ -523,7 +523,7 @@ public static function getModel($modelClass = '', $arguments = []) * @param array $arguments * @return Mage_Core_Model_Abstract */ - public static function getSingleton($modelClass = '', array $arguments= []) + public static function getSingleton($modelClass = '', array $arguments = []) { $registryKey = '_singleton/' . $modelClass; if (!isset(self::$_registry[$registryKey])) { @@ -597,7 +597,7 @@ public static function helper($name) $registryKey = '_helper/' . $name; if (!isset(self::$_registry[$registryKey])) { $helperClass = self::getConfig()->getHelperClassName($name); - self::register($registryKey, new $helperClass); + self::register($registryKey, new $helperClass()); } return self::$_registry[$registryKey]; } @@ -845,8 +845,7 @@ public static function log($message, $level = null, $file = '', $forceLog = fals if (empty($file)) { $file = self::getStoreConfig('dev/log/file'); } - } - catch (Exception $e) { + } catch (Exception $e) { $logActive = true; } @@ -878,7 +877,7 @@ public static function log($message, $level = null, $file = '', $forceLog = fals ',', (string) self::getConfig()->getNode('dev/log/allowedFileExtensions', Mage_Core_Model_Store::DEFAULT_CODE) ); - if ( ! ($extension = pathinfo($file, PATHINFO_EXTENSION)) || ! in_array($extension, $_allowedFileExtensions)) { + if (! ($extension = pathinfo($file, PATHINFO_EXTENSION)) || ! in_array($extension, $_allowedFileExtensions)) { return; } @@ -900,8 +899,7 @@ public static function log($message, $level = null, $file = '', $forceLog = fals $writerModel = (string)self::getConfig()->getNode('global/log/core/writer_model'); if (!self::$_app || !$writerModel) { $writer = new Zend_Log_Writer_Stream($logFile); - } - else { + } else { $writer = new $writerModel($logFile); } $writer->setFormatter($formatter); @@ -914,8 +912,7 @@ public static function log($message, $level = null, $file = '', $forceLog = fals $message = addcslashes($message, 'log($message, $level); - } - catch (Exception $e) { + } catch (Exception $e) { } } @@ -973,28 +970,25 @@ public static function printException(Throwable $e, $extra = '') print $e->getTraceAsString(); print ''; } else { - $reportData = [ (!empty($extra) ? $extra . "\n\n" : '') . $e->getMessage(), $e->getTraceAsString() ]; // retrieve server data - if (isset($_SERVER)) { - if (isset($_SERVER['REQUEST_URI'])) { - $reportData['url'] = $_SERVER['REQUEST_URI']; - } - if (isset($_SERVER['SCRIPT_NAME'])) { - $reportData['script_name'] = $_SERVER['SCRIPT_NAME']; - } + if (isset($_SERVER['REQUEST_URI'])) { + $reportData['url'] = $_SERVER['REQUEST_URI']; + } + if (isset($_SERVER['SCRIPT_NAME'])) { + $reportData['script_name'] = $_SERVER['SCRIPT_NAME']; } // attempt to specify store as a skin try { $storeCode = self::app()->getStore()->getCode(); $reportData['skin'] = $storeCode; + } catch (Exception $e) { } - catch (Exception $e) {} require_once(self::getBaseDir() . DS . 'errors' . DS . 'report.php'); } @@ -1016,14 +1010,14 @@ public static function getScriptSystemUrl($folder, $exitIfNot = false) $runDir = rtrim(dirname($_SERVER['SCRIPT_FILENAME']), DS); $baseUrl = null; - if (is_dir($runDir.'/'.$folder)) { + if (is_dir($runDir . '/' . $folder)) { $baseUrl = str_replace(DS, '/', $runDirUrl); } else { $runDirUrlArray = explode('/', $runDirUrl); $runDirArray = explode('/', $runDir); $count = count($runDirArray); - for ($i=0; $i < $count; $i++) { + for ($i = 0; $i < $count; $i++) { array_pop($runDirUrlArray); array_pop($runDirArray); $_runDir = implode('/', $runDirArray); @@ -1031,7 +1025,7 @@ public static function getScriptSystemUrl($folder, $exitIfNot = false) $_runDir .= '/'; } - if (is_dir($_runDir.$folder)) { + if (is_dir($_runDir . $folder)) { $_runDirUrl = implode('/', $runDirUrlArray); $baseUrl = str_replace(DS, '/', $_runDirUrl); break; @@ -1059,6 +1053,5 @@ public static function getScriptSystemUrl($folder, $exitIfNot = false) */ public static function setIsDownloader() { - } } diff --git a/app/code/core/Mage/Adminhtml/Block/Api/Tab/Rolesedit.php b/app/code/core/Mage/Adminhtml/Block/Api/Tab/Rolesedit.php index 2d75ea4f55ec..558c31975481 100644 --- a/app/code/core/Mage/Adminhtml/Block/Api/Tab/Rolesedit.php +++ b/app/code/core/Mage/Adminhtml/Block/Api/Tab/Rolesedit.php @@ -40,7 +40,8 @@ public function __construct() foreach ($rules_set->getItems() as $item) { if (array_key_exists(strtolower($item->getResource_id()), $resources) - && $item->getApiPermission() == 'allow') { + && $item->getApiPermission() == 'allow' + ) { $resources[$item->getResource_id()]['checked'] = true; $selrids[] = $item->getResource_id(); } diff --git a/app/code/core/Mage/Adminhtml/Block/Catalog/Category/Tree.php b/app/code/core/Mage/Adminhtml/Block/Catalog/Category/Tree.php index 694555f812e9..150addcea35b 100644 --- a/app/code/core/Mage/Adminhtml/Block/Catalog/Category/Tree.php +++ b/app/code/core/Mage/Adminhtml/Block/Catalog/Category/Tree.php @@ -133,7 +133,8 @@ public function getLoadTreeUrl($expanded = null) { $params = ['_current' => true, 'id' => null,'store' => null]; if ((is_null($expanded) && Mage::getSingleton('admin/session')->getIsTreeWasExpanded()) - || $expanded == true) { + || $expanded == true + ) { $params['expand_all'] = true; } return $this->getUrl('*/*/categoriesJson', $params); diff --git a/app/code/core/Mage/Adminhtml/Block/Catalog/Form/Renderer/Fieldset/Element.php b/app/code/core/Mage/Adminhtml/Block/Catalog/Form/Renderer/Fieldset/Element.php index ddd2ba82b280..5702ec7b006a 100644 --- a/app/code/core/Mage/Adminhtml/Block/Catalog/Form/Renderer/Fieldset/Element.php +++ b/app/code/core/Mage/Adminhtml/Block/Catalog/Form/Renderer/Fieldset/Element.php @@ -77,7 +77,8 @@ public function canDisplayUseDefault() if (!$attribute->isScopeGlobal() && $this->getDataObject() && $this->getDataObject()->getId() - && $this->getDataObject()->getStoreId()) { + && $this->getDataObject()->getStoreId() + ) { return true; } } diff --git a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Options/Option.php b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Options/Option.php index c8b2986e37d1..d0b3d8605f4c 100644 --- a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Options/Option.php +++ b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Options/Option.php @@ -288,7 +288,8 @@ public function getOptionValues() $value['image_size_x'] = $option->getImageSizeX(); $value['image_size_y'] = $option->getImageSizeY(); if ($this->getProduct()->getStoreId() != '0' && - $scope == Mage_Core_Model_Store::PRICE_SCOPE_WEBSITE) { + $scope == Mage_Core_Model_Store::PRICE_SCOPE_WEBSITE + ) { $value['checkboxScopePrice'] = $this->getCheckboxScopeHtml( $option->getOptionId(), 'price', diff --git a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Gallery.php b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Gallery.php index 2361f6cafd99..c1572eb551f7 100644 --- a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Gallery.php +++ b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Gallery.php @@ -85,7 +85,8 @@ public function usedDefault($attribute) if (!$this->getDataObject()->getExistsStoreValueFlag($attributeCode)) { return true; } elseif ($this->getValue() == $defaultValue && - $this->getDataObject()->getStoreId() != $this->_getDefaultStoreId()) { + $this->getDataObject()->getStoreId() != $this->_getDefaultStoreId() + ) { return false; } if ($defaultValue === false && !$attribute->getIsRequired() && $this->getValue()) { diff --git a/app/code/core/Mage/Adminhtml/Block/Customer/Edit.php b/app/code/core/Mage/Adminhtml/Block/Customer/Edit.php index 6798e3a8a345..6d2f8b36245e 100644 --- a/app/code/core/Mage/Adminhtml/Block/Customer/Edit.php +++ b/app/code/core/Mage/Adminhtml/Block/Customer/Edit.php @@ -34,7 +34,8 @@ public function __construct() $this->_controller = 'customer'; if ($this->getCustomerId() && - Mage::getSingleton('admin/session')->isAllowed('sales/order/actions/create')) { + Mage::getSingleton('admin/session')->isAllowed('sales/order/actions/create') + ) { $this->_addButton('order', [ 'label' => Mage::helper('customer')->__('Create Order'), 'onclick' => 'setLocation(\'' . $this->getCreateOrderUrl() . '\')', diff --git a/app/code/core/Mage/Adminhtml/Block/Permissions/Tab/Rolesedit.php b/app/code/core/Mage/Adminhtml/Block/Permissions/Tab/Rolesedit.php index 6016e8618af7..491a54d1a2b6 100644 --- a/app/code/core/Mage/Adminhtml/Block/Permissions/Tab/Rolesedit.php +++ b/app/code/core/Mage/Adminhtml/Block/Permissions/Tab/Rolesedit.php @@ -108,11 +108,12 @@ public function __construct() $undefinedResources = array_diff(array_keys($resources), array_keys($resourcesPermissionsMap)); foreach ($undefinedResources as $undefinedResourceId) { - if ($this->_getFallbackHelper()->fallbackResourcePermissions( + // Fallback resource permissions + $permissions = $this->_getFallbackHelper()->fallbackResourcePermissions( $resourcesPermissionsMap, $undefinedResourceId - ) == Mage_Admin_Model_Rules::RULE_PERMISSION_ALLOWED - ) { + ); + if ($permissions == Mage_Admin_Model_Rules::RULE_PERMISSION_ALLOWED) { $selrids[] = $undefinedResourceId; } } @@ -120,8 +121,6 @@ public function __construct() $this->setSelectedResources($selrids); $this->setTemplate('permissions/rolesedit.phtml'); - //->assign('resources', $resources); - //->assign('checkedResources', join(',', $selrids)); } /** diff --git a/app/code/core/Mage/Adminhtml/Block/Promo/Widget/Chooser/Daterange.php b/app/code/core/Mage/Adminhtml/Block/Promo/Widget/Chooser/Daterange.php index 78f75e9dae7e..8de078871776 100644 --- a/app/code/core/Mage/Adminhtml/Block/Promo/Widget/Chooser/Daterange.php +++ b/app/code/core/Mage/Adminhtml/Block/Promo/Widget/Chooser/Daterange.php @@ -66,7 +66,8 @@ protected function _toHtml() $form = new Varien_Data_Form(); foreach ([ 'from' => Mage::helper('adminhtml')->__('From'), - 'to' => Mage::helper('adminhtml')->__('To')] as $key => $label) { + 'to' => Mage::helper('adminhtml')->__('To')] as $key => $label + ) { $id = "{$key}_{$idSuffix}"; $element = new Varien_Data_Form_Element_Date([ 'format' => Varien_Date::DATE_INTERNAL_FORMAT, // hardcode because hardcoded values delimiter diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage.php b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage.php index 785065d035e8..e2fec1603145 100644 --- a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage.php +++ b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage.php @@ -59,7 +59,8 @@ public function getItems() foreach ($allItems as $item) { if ($this->_getGiftmessageSaveModel()->getIsAllowedQuoteItem($item) - && $helper->getIsMessagesAvailable('item', $item, $this->getStore())) { + && $helper->getIsMessagesAvailable('item', $item, $this->getStore()) + ) { // if item allowed $items[] = $item; } diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage/Form.php b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage/Form.php index 3d5a65e9b421..d8ecc98fd09b 100644 --- a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage/Form.php +++ b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage/Form.php @@ -318,7 +318,8 @@ protected function _getFieldIdPrefix() protected function _applyPostData() { if (is_array($giftmessages = $this->getRequest()->getParam('giftmessage')) - && isset($giftmessages[$this->getEntity()->getId()])) { + && isset($giftmessages[$this->getEntity()->getId()]) + ) { $this->getMessage()->addData($giftmessages[$this->getEntity()->getId()]); } diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Invoice/View.php b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Invoice/View.php index 4b1fee67a549..d58960f6145e 100644 --- a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Invoice/View.php +++ b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Invoice/View.php @@ -75,7 +75,8 @@ public function __construct() if (($orderPayment->canRefundPartialPerInvoice() && $this->getInvoice()->canRefund() && $orderPayment->getAmountPaid() > $orderPayment->getAmountRefunded()) - || ($orderPayment->canRefund() && !$this->getInvoice()->getIsUsedForRefund())) { + || ($orderPayment->canRefund() && !$this->getInvoice()->getIsUsedForRefund()) + ) { $this->_addButton('capture', [ // capture? 'label' => Mage::helper('sales')->__('Credit Memo'), 'class' => 'go', diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Order/View.php b/app/code/core/Mage/Adminhtml/Block/Sales/Order/View.php index 7882e372e526..a88c6947fc32 100644 --- a/app/code/core/Mage/Adminhtml/Block/Sales/Order/View.php +++ b/app/code/core/Mage/Adminhtml/Block/Sales/Order/View.php @@ -164,7 +164,8 @@ public function __construct() } if ($this->_isAllowedAction('ship') && $order->canShip() - && !$order->getForcedDoShipmentWithInvoice()) { + && !$order->getForcedDoShipmentWithInvoice() + ) { $this->_addButton('order_ship', [ 'label' => Mage::helper('sales')->__('Ship'), 'onclick' => 'setLocation(\'' . $this->getShipUrl() . '\')', diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Transactions/Detail.php b/app/code/core/Mage/Adminhtml/Block/Sales/Transactions/Detail.php index c280f038f0c8..8915d18bc610 100644 --- a/app/code/core/Mage/Adminhtml/Block/Sales/Transactions/Detail.php +++ b/app/code/core/Mage/Adminhtml/Block/Sales/Transactions/Detail.php @@ -53,7 +53,8 @@ public function __construct() ]); if (Mage::getSingleton('admin/session')->isAllowed('sales/transactions/fetch') - && $this->_txn->getOrderPaymentObject()->getMethodInstance()->canFetchTransactionInfo()) { + && $this->_txn->getOrderPaymentObject()->getMethodInstance()->canFetchTransactionInfo() + ) { $fetchUrl = $this->getUrl('*/*/fetch', ['_current' => true]); $this->_addButton('fetch', [ 'label' => Mage::helper('sales')->__('Fetch'), diff --git a/app/code/core/Mage/Adminhtml/Block/System/Config/Form/Field/Array/Abstract.php b/app/code/core/Mage/Adminhtml/Block/System/Config/Form/Field/Array/Abstract.php index c3033f298689..dcd5bc859857 100644 --- a/app/code/core/Mage/Adminhtml/Block/System/Config/Form/Field/Array/Abstract.php +++ b/app/code/core/Mage/Adminhtml/Block/System/Config/Form/Field/Array/Abstract.php @@ -88,9 +88,9 @@ public function addColumn($name, $params) { $this->_columns[$name] = [ 'label' => empty($params['label']) ? 'Column' : $params['label'], - 'size' => empty($params['size']) ? false : $params['size'], - 'style' => empty($params['style']) ? null : $params['style'], - 'class' => empty($params['class']) ? null : $params['class'], + 'size' => empty($params['size']) ? false : $params['size'], + 'style' => empty($params['style']) ? null : $params['style'], + 'class' => empty($params['class']) ? null : $params['class'], 'renderer' => false, ]; if ((!empty($params['renderer'])) && ($params['renderer'] instanceof Mage_Core_Block_Abstract)) { diff --git a/app/code/core/Mage/Adminhtml/Block/System/Convert/Profile/Edit/Tab/Run.php b/app/code/core/Mage/Adminhtml/Block/System/Convert/Profile/Edit/Tab/Run.php index 3e78aa196af9..452f9425c7cb 100644 --- a/app/code/core/Mage/Adminhtml/Block/System/Convert/Profile/Edit/Tab/Run.php +++ b/app/code/core/Mage/Adminhtml/Block/System/Convert/Profile/Edit/Tab/Run.php @@ -60,7 +60,8 @@ public function getImportedFiles() while (($entry = $dir->read()) !== false) { if ($entry != '.' && $entry != '..' - && strtolower(substr($entry, strrpos($entry, '.') + 1)) == $this->getParseType()) { + && strtolower(substr($entry, strrpos($entry, '.') + 1)) == $this->getParseType() + ) { $files[] = $entry; } } diff --git a/app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php b/app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php index 7ff9043aa60b..4de0a0d6b5c8 100644 --- a/app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php +++ b/app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php @@ -147,7 +147,8 @@ protected function _prepareForm() ]); if (Mage::registry('store_action') == 'edit' - || (Mage::registry('store_action') == 'add' && Mage::registry('store_type') == 'group')) { + || (Mage::registry('store_action') == 'add' && Mage::registry('store_type') == 'group') + ) { $websites = Mage::getModel('core/website')->getCollection()->toOptionArray(); $fieldset->addField('group_website_id', 'select', [ 'name' => 'group[website_id]', @@ -226,7 +227,8 @@ protected function _prepareForm() ]); if (Mage::registry('store_action') == 'edit' - || Mage::registry('store_action') == 'add' && Mage::registry('store_type') == 'store') { + || Mage::registry('store_action') == 'add' && Mage::registry('store_type') == 'store' + ) { $websites = Mage::getModel('core/website')->getCollection(); $allgroups = Mage::getModel('core/store_group')->getCollection(); $groups = []; diff --git a/app/code/core/Mage/Adminhtml/Block/Widget/Tabs.php b/app/code/core/Mage/Adminhtml/Block/Widget/Tabs.php index 631c149fe9ef..4fc01e8a3eec 100644 --- a/app/code/core/Mage/Adminhtml/Block/Widget/Tabs.php +++ b/app/code/core/Mage/Adminhtml/Block/Widget/Tabs.php @@ -172,7 +172,8 @@ public function getActiveTabId() public function setActiveTab($tabId) { if (isset($this->_tabs[$tabId]) && $this->canShowTab($this->_tabs[$tabId]) - && !$this->getTabIsHidden($this->_tabs[$tabId])) { + && !$this->getTabIsHidden($this->_tabs[$tabId]) + ) { $this->_activeTab = $tabId; } return $this; diff --git a/app/code/core/Mage/Adminhtml/Controller/Action.php b/app/code/core/Mage/Adminhtml/Controller/Action.php index 8409cb0a29e9..3a1392a26367 100644 --- a/app/code/core/Mage/Adminhtml/Controller/Action.php +++ b/app/code/core/Mage/Adminhtml/Controller/Action.php @@ -209,7 +209,8 @@ public function preDispatch() if ($this->getRequest()->isDispatched() && $this->getRequest()->getActionName() !== 'denied' - && !$this->_isAllowed()) { + && !$this->_isAllowed() + ) { $this->_forward('denied'); $this->setFlag('', self::FLAG_NO_DISPATCH, true); return $this; @@ -218,7 +219,8 @@ public function preDispatch() if (!$this->getFlag('', self::FLAG_IS_URLS_CHECKED) && !$this->getRequest()->getParam('forwarded') && !$this->_getSession()->getIsUrlNotice(true) - && !Mage::getConfig()->getNode('global/can_use_base_url')) { + && !Mage::getConfig()->getNode('global/can_use_base_url') + ) { //$this->_checkUrlSettings(); $this->setFlag('', self::FLAG_IS_URLS_CHECKED, true); } @@ -402,7 +404,8 @@ protected function _validateSecretKey() } if (!($secretKey = $this->getRequest()->getParam(Mage_Adminhtml_Model_Url::SECRET_KEY_PARAM_NAME, null)) - || !hash_equals(Mage::getSingleton('adminhtml/url')->getSecretKey(), $secretKey)) { + || !hash_equals(Mage::getSingleton('adminhtml/url')->getSecretKey(), $secretKey) + ) { return false; } return true; diff --git a/app/code/core/Mage/Adminhtml/Model/Giftmessage/Save.php b/app/code/core/Mage/Adminhtml/Model/Giftmessage/Save.php index 74a68691dca6..0f7c642323ae 100644 --- a/app/code/core/Mage/Adminhtml/Model/Giftmessage/Save.php +++ b/app/code/core/Mage/Adminhtml/Model/Giftmessage/Save.php @@ -271,10 +271,12 @@ public function importAllowQuoteItemsFromProducts($products) } if (in_array($item->getId(), $allowedItems) - && !isset($data['giftmessage'])) { + && !isset($data['giftmessage']) + ) { $deleteAllowedItems[] = $item->getId(); } elseif (!in_array($item->getId(), $allowedItems) - && isset($data['giftmessage'])) { + && isset($data['giftmessage']) + ) { $allowedItems[] = $item->getId(); } } @@ -299,10 +301,12 @@ public function importAllowQuoteItemsFromItems($items) } if (in_array($item->getId(), $allowedItems) - && !isset($data['giftmessage'])) { + && !isset($data['giftmessage']) + ) { $deleteAllowedItems[] = $item->getId(); } elseif (!in_array($item->getId(), $allowedItems) - && isset($data['giftmessage'])) { + && isset($data['giftmessage']) + ) { $allowedItems[] = $item->getId(); } } diff --git a/app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php b/app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php index b9d177366365..f75cf69b7326 100644 --- a/app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php +++ b/app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php @@ -292,10 +292,13 @@ public function initFromOrder(Mage_Sales_Model_Order $order) * Initialize catalog rule data with new session values */ $this->initRuleData(); - foreach ($order->getItemsCollection( + + $itemsCollection = $order->getItemsCollection( array_keys(Mage::getConfig()->getNode('adminhtml/sales/order/create/available_product_types')->asArray()), true - ) as $orderItem) { + ); + + foreach ($itemsCollection as $orderItem) { /** @var Mage_Sales_Model_Order_Item $orderItem */ if (!$orderItem->getParentItem()) { if ($order->getReordered()) { diff --git a/app/code/core/Mage/Adminhtml/controllers/Catalog/CategoryController.php b/app/code/core/Mage/Adminhtml/controllers/Catalog/CategoryController.php index 8f6dbe537cc7..eb4f2eee64ca 100644 --- a/app/code/core/Mage/Adminhtml/controllers/Catalog/CategoryController.php +++ b/app/code/core/Mage/Adminhtml/controllers/Catalog/CategoryController.php @@ -118,7 +118,8 @@ public function editAction() if ($_prevCategoryId && !$this->getRequest()->getQuery('isAjax') - && !$this->getRequest()->getParam('clear')) { + && !$this->getRequest()->getParam('clear') + ) { $this->getRequest()->setParam('id', $_prevCategoryId); } diff --git a/app/code/core/Mage/Adminhtml/controllers/Catalog/ProductController.php b/app/code/core/Mage/Adminhtml/controllers/Catalog/ProductController.php index cb5a942042c6..f40a75ee9f19 100644 --- a/app/code/core/Mage/Adminhtml/controllers/Catalog/ProductController.php +++ b/app/code/core/Mage/Adminhtml/controllers/Catalog/ProductController.php @@ -111,7 +111,8 @@ protected function _initProduct() // Required attributes of simple product for configurable creation if ($this->getRequest()->getParam('popup') - && $requiredAttributes = $this->getRequest()->getParam('required')) { + && $requiredAttributes = $this->getRequest()->getParam('required') + ) { $requiredAttributes = explode(",", $requiredAttributes); foreach ($product->getAttributes() as $attribute) { if (in_array($attribute->getId(), $requiredAttributes)) { @@ -123,7 +124,8 @@ protected function _initProduct() if ($this->getRequest()->getParam('popup') && $this->getRequest()->getParam('product') && !is_array($this->getRequest()->getParam('product')) - && $this->getRequest()->getParam('id', false) === false) { + && $this->getRequest()->getParam('id', false) === false + ) { $configProduct = Mage::getModel('catalog/product') ->setStoreId(0) ->load($this->getRequest()->getParam('product')) @@ -138,7 +140,8 @@ protected function _initProduct() && $attribute->getFrontend()->getInputType() != 'gallery' && $attribute->getAttributeCode() != 'required_options' && $attribute->getAttributeCode() != 'has_options' - && $attribute->getAttributeCode() != $configProduct->getIdFieldName()) { + && $attribute->getAttributeCode() != $configProduct->getIdFieldName() + ) { $data[$attribute->getAttributeCode()] = $configProduct->getData($attribute->getAttributeCode()); } } @@ -1032,7 +1035,8 @@ public function quickCreateAction() || $attribute->getAttributeCode() == 'url_key' || $attribute->getFrontend()->getInputType() == 'gallery' || $attribute->getFrontend()->getInputType() == 'media_image' - || !$attribute->getIsVisible()) { + || !$attribute->getIsVisible() + ) { continue; } diff --git a/app/code/core/Mage/Adminhtml/controllers/Checkout/AgreementController.php b/app/code/core/Mage/Adminhtml/controllers/Checkout/AgreementController.php index e102015e66ed..cdafdb4e31cc 100644 --- a/app/code/core/Mage/Adminhtml/controllers/Checkout/AgreementController.php +++ b/app/code/core/Mage/Adminhtml/controllers/Checkout/AgreementController.php @@ -88,7 +88,7 @@ public function editAction() Mage::register('checkout_agreement', $agreementModel); $this->_initAction() - ->_addBreadcrumb($id ? Mage::helper('checkout')->__('Edit Condition') : Mage::helper('checkout')->__('New Condition'), $id ? Mage::helper('checkout')->__('Edit Condition') : Mage::helper('checkout')->__('New Condition')) + ->_addBreadcrumb($id ? Mage::helper('checkout')->__('Edit Condition') : Mage::helper('checkout')->__('New Condition'), $id ? Mage::helper('checkout')->__('Edit Condition') : Mage::helper('checkout')->__('New Condition')) ->_addContent($this->getLayout()->createBlock('adminhtml/checkout_agreement_edit')->setData('action', $this->getUrl('*/*/save'))) ->renderLayout(); } diff --git a/app/code/core/Mage/Adminhtml/controllers/Cms/PageController.php b/app/code/core/Mage/Adminhtml/controllers/Cms/PageController.php index a6ed376f339b..93ca1c867d27 100644 --- a/app/code/core/Mage/Adminhtml/controllers/Cms/PageController.php +++ b/app/code/core/Mage/Adminhtml/controllers/Cms/PageController.php @@ -268,7 +268,8 @@ protected function _validatePostData($data) $errorNo = false; } if (!empty($data['custom_layout_update_xml']) - && !$validatorCustomLayout->isValid($data['custom_layout_update_xml'])) { + && !$validatorCustomLayout->isValid($data['custom_layout_update_xml']) + ) { $errorNo = false; } foreach ($validatorCustomLayout->getMessages() as $message) { diff --git a/app/code/core/Mage/Adminhtml/controllers/Newsletter/QueueController.php b/app/code/core/Mage/Adminhtml/controllers/Newsletter/QueueController.php index 16cc507b9472..57654f05446b 100644 --- a/app/code/core/Mage/Adminhtml/controllers/Newsletter/QueueController.php +++ b/app/code/core/Mage/Adminhtml/controllers/Newsletter/QueueController.php @@ -19,6 +19,8 @@ * @license https://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0) */ +use Mage_Newsletter_Model_Queue as Queue; + /** * Adminhtml newsletter queue controller * @@ -104,17 +106,13 @@ public function startAction() $queue = Mage::getModel('newsletter/queue') ->load($this->getRequest()->getParam('id')); if ($queue->getId()) { - if (!in_array( - $queue->getQueueStatus(), - [Mage_Newsletter_Model_Queue::STATUS_NEVER, - Mage_Newsletter_Model_Queue::STATUS_PAUSE] - )) { + if (!in_array($queue->getQueueStatus(), [Queue::STATUS_NEVER, Queue::STATUS_PAUSE])) { $this->_redirect('*/*'); return; } $queue->setQueueStartAt(Mage::getSingleton('core/date')->gmtDate()) - ->setQueueStatus(Mage_Newsletter_Model_Queue::STATUS_SENDING) + ->setQueueStatus(Queue::STATUS_SENDING) ->save(); } @@ -126,12 +124,12 @@ public function pauseAction() $queue = Mage::getSingleton('newsletter/queue') ->load($this->getRequest()->getParam('id')); - if ($queue->getQueueStatus() != Mage_Newsletter_Model_Queue::STATUS_SENDING) { + if ($queue->getQueueStatus() != Queue::STATUS_SENDING) { $this->_redirect('*/*'); return; } - $queue->setQueueStatus(Mage_Newsletter_Model_Queue::STATUS_PAUSE); + $queue->setQueueStatus(Queue::STATUS_PAUSE); $queue->save(); $this->_redirect('*/*'); @@ -142,12 +140,12 @@ public function resumeAction() $queue = Mage::getSingleton('newsletter/queue') ->load($this->getRequest()->getParam('id')); - if ($queue->getQueueStatus() != Mage_Newsletter_Model_Queue::STATUS_PAUSE) { + if ($queue->getQueueStatus() != Queue::STATUS_PAUSE) { $this->_redirect('*/*'); return; } - $queue->setQueueStatus(Mage_Newsletter_Model_Queue::STATUS_SENDING); + $queue->setQueueStatus(Queue::STATUS_SENDING); $queue->save(); $this->_redirect('*/*'); @@ -158,12 +156,12 @@ public function cancelAction() $queue = Mage::getSingleton('newsletter/queue') ->load($this->getRequest()->getParam('id')); - if ($queue->getQueueStatus() != Mage_Newsletter_Model_Queue::STATUS_SENDING) { + if ($queue->getQueueStatus() != Queue::STATUS_SENDING) { $this->_redirect('*/*'); return; } - $queue->setQueueStatus(Mage_Newsletter_Model_Queue::STATUS_CANCEL); + $queue->setQueueStatus(Queue::STATUS_CANCEL); $queue->save(); $this->_redirect('*/*'); @@ -219,7 +217,7 @@ public function editAction() public function saveAction() { try { - /** @var Mage_Newsletter_Model_Queue $queue */ + /** @var Queue $queue */ $queue = Mage::getModel('newsletter/queue'); $templateId = $this->getRequest()->getParam('template_id'); @@ -232,22 +230,17 @@ public function saveAction() } $queue->setTemplateId($template->getId()) - ->setQueueStatus(Mage_Newsletter_Model_Queue::STATUS_NEVER); + ->setQueueStatus(Queue::STATUS_NEVER); } else { $queue->load($this->getRequest()->getParam('id')); } - if (!in_array( - $queue->getQueueStatus(), - [Mage_Newsletter_Model_Queue::STATUS_NEVER, - Mage_Newsletter_Model_Queue::STATUS_PAUSE] - ) - ) { + if (!in_array($queue->getQueueStatus(), [Queue::STATUS_NEVER, Queue::STATUS_PAUSE])) { $this->_redirect('*/*'); return; } - if ($queue->getQueueStatus() == Mage_Newsletter_Model_Queue::STATUS_NEVER) { + if ($queue->getQueueStatus() == Queue::STATUS_NEVER) { $queue->setQueueStartAtByString($this->getRequest()->getParam('start_at')); } @@ -258,9 +251,10 @@ public function saveAction() ->setNewsletterText($this->getRequest()->getParam('text')) ->setNewsletterStyles($this->getRequest()->getParam('styles')); - if ($queue->getQueueStatus() == Mage_Newsletter_Model_Queue::STATUS_PAUSE - && $this->getRequest()->getParam('_resume', false)) { - $queue->setQueueStatus(Mage_Newsletter_Model_Queue::STATUS_SENDING); + if ($queue->getQueueStatus() == Queue::STATUS_PAUSE + && $this->getRequest()->getParam('_resume', false) + ) { + $queue->setQueueStatus(Queue::STATUS_SENDING); } $queue->save(); diff --git a/app/code/core/Mage/Adminhtml/controllers/Promo/QuoteController.php b/app/code/core/Mage/Adminhtml/controllers/Promo/QuoteController.php index f2cbe3ab269f..4121aa4a475d 100644 --- a/app/code/core/Mage/Adminhtml/controllers/Promo/QuoteController.php +++ b/app/code/core/Mage/Adminhtml/controllers/Promo/QuoteController.php @@ -164,7 +164,8 @@ public function saveAction() } if (isset($data['simple_action']) && $data['simple_action'] == 'by_percent' - && isset($data['discount_amount'])) { + && isset($data['discount_amount']) + ) { $data['discount_amount'] = min(100, $data['discount_amount']); } if (isset($data['rule']['conditions'])) { diff --git a/app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreditmemoController.php b/app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreditmemoController.php index 61349362e099..e19f58f4e190 100644 --- a/app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreditmemoController.php +++ b/app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreditmemoController.php @@ -427,7 +427,8 @@ protected function _needToAddDummy($item, $qtys) foreach ($item->getChildrenItems() as $child) { if (isset($qtys[$child->getId()]) && isset($qtys[$child->getId()]['qty']) - && $qtys[$child->getId()]['qty'] > 0) { + && $qtys[$child->getId()]['qty'] > 0 + ) { return true; } } @@ -437,7 +438,8 @@ protected function _needToAddDummy($item, $qtys) if ($item->getParentItem()) { if (isset($qtys[$item->getParentItem()->getId()]) && isset($qtys[$item->getParentItem()->getId()]['qty']) - && $qtys[$item->getParentItem()->getId()]['qty'] > 0) { + && $qtys[$item->getParentItem()->getId()]['qty'] > 0 + ) { return true; } return false; diff --git a/app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php b/app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php index f163fb035e58..85d3c87f923d 100644 --- a/app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php +++ b/app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php @@ -473,7 +473,8 @@ protected function _needToAddDummy($item, $qtys) continue; } if ((isset($qtys[$child->getId()]) && $qtys[$child->getId()] > 0) - || (!isset($qtys[$child->getId()]) && $child->getQtyToShip())) { + || (!isset($qtys[$child->getId()]) && $child->getQtyToShip()) + ) { return true; } } @@ -485,7 +486,8 @@ protected function _needToAddDummy($item, $qtys) return false; } if ((isset($qtys[$item->getParentItem()->getId()]) && $qtys[$item->getParentItem()->getId()] > 0) - || (!isset($qtys[$item->getParentItem()->getId()]) && $item->getParentItem()->getQtyToShip())) { + || (!isset($qtys[$item->getParentItem()->getId()]) && $item->getParentItem()->getQtyToShip()) + ) { return true; } return false; diff --git a/app/code/core/Mage/Adminhtml/controllers/System/ConfigController.php b/app/code/core/Mage/Adminhtml/controllers/System/ConfigController.php index b2b7c9e6f566..f35549227036 100644 --- a/app/code/core/Mage/Adminhtml/controllers/System/ConfigController.php +++ b/app/code/core/Mage/Adminhtml/controllers/System/ConfigController.php @@ -237,7 +237,8 @@ public function stateAction() { if ($this->getRequest()->getParam('isAjax') == 1 && $this->getRequest()->getParam('container') != '' - && $this->getRequest()->getParam('value') != '') { + && $this->getRequest()->getParam('value') != '' + ) { $configState = [ $this->getRequest()->getParam('container') => $this->getRequest()->getParam('value') ]; diff --git a/app/code/core/Mage/Adminhtml/controllers/Tax/Class/CustomerController.php b/app/code/core/Mage/Adminhtml/controllers/Tax/Class/CustomerController.php index 9e12f1f6a9b0..dc615139a0b2 100644 --- a/app/code/core/Mage/Adminhtml/controllers/Tax/Class/CustomerController.php +++ b/app/code/core/Mage/Adminhtml/controllers/Tax/Class/CustomerController.php @@ -91,8 +91,8 @@ public function editAction() $this->_initAction() ->_addBreadcrumb( - $classId ? Mage::helper('tax')->__('Edit Class') : Mage::helper('tax')->__('New Class'), - $classId ? Mage::helper('tax')->__('Edit Class') : Mage::helper('tax')->__('New Class') + $classId ? Mage::helper('tax')->__('Edit Class') : Mage::helper('tax')->__('New Class'), + $classId ? Mage::helper('tax')->__('Edit Class') : Mage::helper('tax')->__('New Class') ) ->_addContent( $this->getLayout() diff --git a/app/code/core/Mage/Adminhtml/controllers/Tax/Class/ProductController.php b/app/code/core/Mage/Adminhtml/controllers/Tax/Class/ProductController.php index eadc7cc18c1d..9ec812b18cfd 100644 --- a/app/code/core/Mage/Adminhtml/controllers/Tax/Class/ProductController.php +++ b/app/code/core/Mage/Adminhtml/controllers/Tax/Class/ProductController.php @@ -92,8 +92,8 @@ public function editAction() $this->_initAction() ->_addBreadcrumb( - $classId ? Mage::helper('tax')->__('Edit Class') : Mage::helper('tax')->__('New Class'), - $classId ? Mage::helper('tax')->__('Edit Class') : Mage::helper('tax')->__('New Class') + $classId ? Mage::helper('tax')->__('Edit Class') : Mage::helper('tax')->__('New Class'), + $classId ? Mage::helper('tax')->__('Edit Class') : Mage::helper('tax')->__('New Class') ) ->_addContent( $this->getLayout()->createBlock('adminhtml/tax_class_edit') diff --git a/app/code/core/Mage/Adminhtml/controllers/Tax/RuleController.php b/app/code/core/Mage/Adminhtml/controllers/Tax/RuleController.php index 647f6c7ce55f..8f29a6825b4c 100644 --- a/app/code/core/Mage/Adminhtml/controllers/Tax/RuleController.php +++ b/app/code/core/Mage/Adminhtml/controllers/Tax/RuleController.php @@ -92,8 +92,8 @@ public function editAction() $this->_initAction() ->_addBreadcrumb( - $taxRuleId ? Mage::helper('tax')->__('Edit Rule') : Mage::helper('tax')->__('New Rule'), - $taxRuleId ? Mage::helper('tax')->__('Edit Rule') : Mage::helper('tax')->__('New Rule') + $taxRuleId ? Mage::helper('tax')->__('Edit Rule') : Mage::helper('tax')->__('New Rule'), + $taxRuleId ? Mage::helper('tax')->__('Edit Rule') : Mage::helper('tax')->__('New Rule') ) ->_addContent($this->getLayout()->createBlock('adminhtml/tax_rule_edit') ->setData('action', $this->getUrl('*/tax_rule/save'))) diff --git a/app/code/core/Mage/Api/Model/Config.php b/app/code/core/Mage/Api/Model/Config.php index 5f33336e75e3..408175a83c4b 100644 --- a/app/code/core/Mage/Api/Model/Config.php +++ b/app/code/core/Mage/Api/Model/Config.php @@ -230,7 +230,8 @@ public function getFaults($resourceName = null) { if (is_null($resourceName) || !isset($this->getResources()->$resourceName) - || !isset($this->getResources()->$resourceName->faults)) { + || !isset($this->getResources()->$resourceName->faults) + ) { $faultsNode = $this->getNode('faults'); } else { $faultsNode = $this->getResources()->$resourceName->faults; diff --git a/app/code/core/Mage/Api/Model/Server/Adapter/Soap.php b/app/code/core/Mage/Api/Model/Server/Adapter/Soap.php index db0999acd876..600e19e393f9 100644 --- a/app/code/core/Mage/Api/Model/Server/Adapter/Soap.php +++ b/app/code/core/Mage/Api/Model/Server/Adapter/Soap.php @@ -271,11 +271,7 @@ protected function _instantiateServer() ['encoding' => $apiConfigCharset] ); } catch (SoapFault $e) { - if (strpos( - $e->getMessage(), - "can't import schema from 'http://schemas.xmlsoap.org/soap/encoding/'" - ) !== false - ) { + if (strpos($e->getMessage(), "can't import schema from 'http://schemas.xmlsoap.org/soap/encoding/'") !== false) { $retry = true; sleep(1); } else { diff --git a/app/code/core/Mage/Api/Model/Server/Handler/Abstract.php b/app/code/core/Mage/Api/Model/Server/Handler/Abstract.php index d25559ad7cad..7d05b35b8f80 100644 --- a/app/code/core/Mage/Api/Model/Server/Handler/Abstract.php +++ b/app/code/core/Mage/Api/Model/Server/Handler/Abstract.php @@ -251,19 +251,22 @@ public function call($sessionId, $apiPath, $args = []) } if (!isset($resources->$resourceName) - || !isset($resources->$resourceName->methods->$methodName)) { + || !isset($resources->$resourceName->methods->$methodName) + ) { return $this->_fault('resource_path_invalid'); } if (!isset($resources->$resourceName->public) && isset($resources->$resourceName->acl) - && !$this->_isAllowed((string)$resources->$resourceName->acl)) { + && !$this->_isAllowed((string)$resources->$resourceName->acl) + ) { return $this->_fault('access_denied'); } if (!isset($resources->$resourceName->methods->$methodName->public) && isset($resources->$resourceName->methods->$methodName->acl) - && !$this->_isAllowed((string)$resources->$resourceName->methods->$methodName->acl)) { + && !$this->_isAllowed((string)$resources->$resourceName->methods->$methodName->acl) + ) { return $this->_fault('access_denied'); } @@ -353,7 +356,8 @@ public function multiCall($sessionId, array $calls = [], $options = []) } if (!isset($resources->$resourceName) - || !isset($resources->$resourceName->methods->$methodName)) { + || !isset($resources->$resourceName->methods->$methodName) + ) { $result[] = $this->_faultAsArray('resource_path_invalid'); if (isset($options['break']) && $options['break'] == 1) { break; @@ -364,7 +368,8 @@ public function multiCall($sessionId, array $calls = [], $options = []) if (!isset($resources->$resourceName->public) && isset($resources->$resourceName->acl) - && !$this->_isAllowed((string)$resources->$resourceName->acl)) { + && !$this->_isAllowed((string)$resources->$resourceName->acl) + ) { $result[] = $this->_faultAsArray('access_denied'); if (isset($options['break']) && $options['break'] == 1) { break; @@ -375,7 +380,8 @@ public function multiCall($sessionId, array $calls = [], $options = []) if (!isset($resources->$resourceName->methods->$methodName->public) && isset($resources->$resourceName->methods->$methodName->acl) - && !$this->_isAllowed((string)$resources->$resourceName->methods->$methodName->acl)) { + && !$this->_isAllowed((string)$resources->$resourceName->methods->$methodName->acl) + ) { $result[] = $this->_faultAsArray('access_denied'); if (isset($options['break']) && $options['break'] == 1) { break; @@ -516,12 +522,14 @@ public function resourceFaults($sessionId, $resourceName) } if (empty($resourceName) - || !isset($resources->$resourceName)) { + || !isset($resources->$resourceName) + ) { return $this->_fault('resource_path_invalid'); } if (isset($resources->$resourceName->acl) - && !$this->_isAllowed((string)$resources->$resourceName->acl)) { + && !$this->_isAllowed((string)$resources->$resourceName->acl) + ) { return $this->_fault('access_denied'); } diff --git a/app/code/core/Mage/Api2/Block/Adminhtml/Roles/Buttons.php b/app/code/core/Mage/Api2/Block/Adminhtml/Roles/Buttons.php index 4f5479cd2f37..c966bc2d2a5b 100644 --- a/app/code/core/Mage/Api2/Block/Adminhtml/Roles/Buttons.php +++ b/app/code/core/Mage/Api2/Block/Adminhtml/Roles/Buttons.php @@ -112,7 +112,8 @@ public function getSaveButtonHtml() public function getDeleteButtonHtml() { if (!$this->getRole() || !$this->getRole()->getId() - || Mage_Api2_Model_Acl_Global_Role::isSystemRole($this->getRole())) { + || Mage_Api2_Model_Acl_Global_Role::isSystemRole($this->getRole()) + ) { return ''; } diff --git a/app/code/core/Mage/Api2/Model/Acl/Global/Role.php b/app/code/core/Mage/Api2/Model/Acl/Global/Role.php index a10a62514cef..3a14c30a2507 100644 --- a/app/code/core/Mage/Api2/Model/Acl/Global/Role.php +++ b/app/code/core/Mage/Api2/Model/Acl/Global/Role.php @@ -80,9 +80,8 @@ protected function _beforeSave() } //check and protect guest role - if (self::isSystemRole($this) - && $this->getRoleName() != $this->getOrigData('role_name')) { + if (self::isSystemRole($this) && $this->getRoleName() != $this->getOrigData('role_name')) { /** @var Mage_Core_Helper_Data $helper */ $helper = Mage::helper('core'); diff --git a/app/code/core/Mage/Api2/Model/Observer.php b/app/code/core/Mage/Api2/Model/Observer.php index 4e36760ede79..5e2df5bddeff 100644 --- a/app/code/core/Mage/Api2/Model/Observer.php +++ b/app/code/core/Mage/Api2/Model/Observer.php @@ -62,7 +62,8 @@ public function catalogAttributeSaveAfter(Varien_Event_Observer $observer) /** @var Mage_Catalog_Model_Resource_Eav_Attribute $attribute */ $attribute = $observer->getEvent()->getAttribute(); if ($attribute->getIsUserDefined() && $attribute->dataHasChangedFor('is_visible_on_front') - && !$attribute->getIsVisibleOnFront()) { + && !$attribute->getIsVisibleOnFront() + ) { /** @var Mage_Api2_Model_Resource_Acl_Filter_Attribute_Collection $collection */ $collection = Mage::getResourceModel('api2/acl_filter_attribute_collection'); /** @var Mage_Api2_Model_Acl_Filter_Attribute $aclFilter */ diff --git a/app/code/core/Mage/Authorizenet/Model/Directpost.php b/app/code/core/Mage/Authorizenet/Model/Directpost.php index 70090387b01d..8d48397452f7 100644 --- a/app/code/core/Mage/Authorizenet/Model/Directpost.php +++ b/app/code/core/Mage/Authorizenet/Model/Directpost.php @@ -101,7 +101,8 @@ public function capture(Varien_Object $payment, $amount) case self::RESPONSE_CODE_APPROVED: if ($result->getResponseReasonCode() == self::RESPONSE_REASON_CODE_APPROVED) { if (!$payment->getParentTransactionId() || - $result->getTransactionId() != $payment->getParentTransactionId()) { + $result->getTransactionId() != $payment->getParentTransactionId() + ) { $payment->setTransactionId($result->getTransactionId()); } $payment diff --git a/app/code/core/Mage/Backup/Model/Fs/Collection.php b/app/code/core/Mage/Backup/Model/Fs/Collection.php index 1dffd66a9520..fa3818932fe9 100644 --- a/app/code/core/Mage/Backup/Model/Fs/Collection.php +++ b/app/code/core/Mage/Backup/Model/Fs/Collection.php @@ -77,7 +77,8 @@ protected function _generateRow($filename) { $row = parent::_generateRow($filename); foreach (Mage::getSingleton('backup/backup')->load($row['basename'], $this->_baseDir) - ->getData() as $key => $value) { + ->getData() as $key => $value + ) { $row[$key] = $value; } $row['size'] = filesize($filename); diff --git a/app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php b/app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php index 65a9d475fc70..ea84a57aac6b 100644 --- a/app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php +++ b/app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php @@ -221,7 +221,8 @@ public function getValueHtml($item) public function canShowPriceInfo($item) { if (($item->getOrderItem()->getParentItem() && $this->isChildCalculated()) - || (!$item->getOrderItem()->getParentItem() && !$this->isChildCalculated())) { + || (!$item->getOrderItem()->getParentItem() && !$this->isChildCalculated()) + ) { return true; } return false; diff --git a/app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/View/Items/Renderer.php b/app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/View/Items/Renderer.php index 0237d6587eff..17e3ecbeaf1e 100644 --- a/app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/View/Items/Renderer.php +++ b/app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/View/Items/Renderer.php @@ -172,7 +172,8 @@ public function getValueHtml($item) public function canShowPriceInfo($item) { if (($item->getParentItem() && $this->isChildCalculated()) - || (!$item->getParentItem() && !$this->isChildCalculated())) { + || (!$item->getParentItem() && !$this->isChildCalculated()) + ) { return true; } return false; diff --git a/app/code/core/Mage/Bundle/Block/Catalog/Product/Price.php b/app/code/core/Mage/Bundle/Block/Catalog/Product/Price.php index dac4c190d177..b5bebfbfadbe 100644 --- a/app/code/core/Mage/Bundle/Block/Catalog/Product/Price.php +++ b/app/code/core/Mage/Bundle/Block/Catalog/Product/Price.php @@ -59,7 +59,8 @@ public function displayBothPrices() { $product = $this->getProduct(); if ($product->getPriceType() == Mage_Bundle_Model_Product_Price::PRICE_TYPE_DYNAMIC && - $product->getPriceModel()->getIsPricesCalculatedByIndex() !== false) { + $product->getPriceModel()->getIsPricesCalculatedByIndex() !== false + ) { return false; } diff --git a/app/code/core/Mage/Bundle/Block/Sales/Order/Items/Renderer.php b/app/code/core/Mage/Bundle/Block/Sales/Order/Items/Renderer.php index 1dd42375a6f4..8a7c3bc16c4f 100644 --- a/app/code/core/Mage/Bundle/Block/Sales/Order/Items/Renderer.php +++ b/app/code/core/Mage/Bundle/Block/Sales/Order/Items/Renderer.php @@ -184,7 +184,8 @@ public function getChilds($item) public function canShowPriceInfo($item) { if (($item->getOrderItem()->getParentItem() && $this->isChildCalculated()) - || (!$item->getOrderItem()->getParentItem() && !$this->isChildCalculated())) { + || (!$item->getOrderItem()->getParentItem() && !$this->isChildCalculated()) + ) { return true; } return false; diff --git a/app/code/core/Mage/Bundle/Model/Resource/Price/Index.php b/app/code/core/Mage/Bundle/Model/Resource/Price/Index.php index b22f6f78a2ef..d65ed8866ac1 100644 --- a/app/code/core/Mage/Bundle/Model/Resource/Price/Index.php +++ b/app/code/core/Mage/Bundle/Model/Resource/Price/Index.php @@ -833,11 +833,7 @@ public function _calculateSpecialPrice($finalPrice, array $priceData, Mage_Core_ $specialPrice = $priceData['special_price']; if (!is_null($specialPrice) && $specialPrice != false) { - if (Mage::app()->getLocale()->isStoreDateInInterval( - $store, - $priceData['special_from_date'], - $priceData['special_to_date'] - )) { + if (Mage::app()->getLocale()->isStoreDateInInterval($store, $priceData['special_from_date'], $priceData['special_to_date'])) { $specialPrice = ($finalPrice * $specialPrice) / 100; $finalPrice = min($finalPrice, $specialPrice); } diff --git a/app/code/core/Mage/Bundle/Model/Sales/Order/Pdf/Items/Abstract.php b/app/code/core/Mage/Bundle/Model/Sales/Order/Pdf/Items/Abstract.php index f2995af3f28a..34be34b2fc46 100644 --- a/app/code/core/Mage/Bundle/Model/Sales/Order/Pdf/Items/Abstract.php +++ b/app/code/core/Mage/Bundle/Model/Sales/Order/Pdf/Items/Abstract.php @@ -78,7 +78,8 @@ public function isShipmentSeparately($item = null) $options = $parentItem->getProductOptions(); if ($options) { if (isset($options['shipment_type']) - && $options['shipment_type'] == Mage_Catalog_Model_Product_Type_Abstract::SHIPMENT_SEPARATELY) { + && $options['shipment_type'] == Mage_Catalog_Model_Product_Type_Abstract::SHIPMENT_SEPARATELY + ) { return true; } else { return false; @@ -88,7 +89,8 @@ public function isShipmentSeparately($item = null) $options = $item->getProductOptions(); if ($options) { if (isset($options['shipment_type']) - && $options['shipment_type'] == Mage_Catalog_Model_Product_Type_Abstract::SHIPMENT_SEPARATELY) { + && $options['shipment_type'] == Mage_Catalog_Model_Product_Type_Abstract::SHIPMENT_SEPARATELY + ) { return false; } else { return true; @@ -100,7 +102,8 @@ public function isShipmentSeparately($item = null) $options = $this->getOrderItem()->getProductOptions(); if ($options) { if (isset($options['shipment_type']) - && $options['shipment_type'] == Mage_Catalog_Model_Product_Type_Abstract::SHIPMENT_SEPARATELY) { + && $options['shipment_type'] == Mage_Catalog_Model_Product_Type_Abstract::SHIPMENT_SEPARATELY + ) { return true; } } @@ -149,7 +152,8 @@ public function isChildCalculated($item = null) $options = $this->getOrderItem()->getProductOptions(); if ($options) { if (isset($options['product_calculations']) - && $options['product_calculations'] == Mage_Catalog_Model_Product_Type_Abstract::CALCULATE_CHILD) { + && $options['product_calculations'] == Mage_Catalog_Model_Product_Type_Abstract::CALCULATE_CHILD + ) { return true; } } @@ -261,7 +265,8 @@ public function getValueHtml($item) public function canShowPriceInfo($item) { if (($item->getOrderItem()->getParentItem() && $this->isChildCalculated()) - || (!$item->getOrderItem()->getParentItem() && !$this->isChildCalculated())) { + || (!$item->getOrderItem()->getParentItem() && !$this->isChildCalculated()) + ) { return true; } return false; diff --git a/app/code/core/Mage/Catalog/Block/Product/View/Options/Type/Select.php b/app/code/core/Mage/Catalog/Block/Product/View/Options/Type/Select.php index d65234bbfa57..fbc87a225733 100644 --- a/app/code/core/Mage/Catalog/Block/Product/View/Options/Type/Select.php +++ b/app/code/core/Mage/Catalog/Block/Product/View/Options/Type/Select.php @@ -42,7 +42,8 @@ public function getValuesHtml() $store = $this->getProduct()->getStore(); if ($_option->getType() === Mage_Catalog_Model_Product_Option::OPTION_TYPE_DROP_DOWN - || $_option->getType() === Mage_Catalog_Model_Product_Option::OPTION_TYPE_MULTIPLE) { + || $_option->getType() === Mage_Catalog_Model_Product_Option::OPTION_TYPE_MULTIPLE + ) { $require = ($_option->getIsRequire()) ? ' required-entry' : ''; $extraParams = ''; /** @var Mage_Core_Block_Html_Select $block */ diff --git a/app/code/core/Mage/Catalog/Block/Product/View/Type/Configurable.php b/app/code/core/Mage/Catalog/Block/Product/View/Type/Configurable.php index 5b3850471bb6..5b418e4b6f78 100644 --- a/app/code/core/Mage/Catalog/Block/Product/View/Type/Configurable.php +++ b/app/code/core/Mage/Catalog/Block/Product/View/Type/Configurable.php @@ -102,7 +102,8 @@ public function getAllowProducts() if ($product->isSaleable() || $skipSaleableCheck || (!$product->getStockItem()->getIsInStock() - && Mage::helper('cataloginventory')->isShowOutOfStock())) { + && Mage::helper('cataloginventory')->isShowOutOfStock()) + ) { $products[] = $product; } } diff --git a/app/code/core/Mage/Catalog/Helper/Data.php b/app/code/core/Mage/Catalog/Helper/Data.php index 781f878d6ac8..45d0f8de5d38 100644 --- a/app/code/core/Mage/Catalog/Helper/Data.php +++ b/app/code/core/Mage/Catalog/Helper/Data.php @@ -432,15 +432,9 @@ public function canApplyMsrpToProductType($product) public function getMsrpPriceMessage($product) { $message = ""; - if ($this->canApplyMsrp( - $product, - Mage_Catalog_Model_Product_Attribute_Source_Msrp_Type::TYPE_IN_CART - )) { + if ($this->canApplyMsrp($product, Mage_Catalog_Model_Product_Attribute_Source_Msrp_Type::TYPE_IN_CART)) { $message = $this->__('To see product price, add this item to your cart. You can always remove it later.'); - } elseif ($this->canApplyMsrp( - $product, - Mage_Catalog_Model_Product_Attribute_Source_Msrp_Type::TYPE_BEFORE_ORDER_CONFIRM - )) { + } elseif ($this->canApplyMsrp($product, Mage_Catalog_Model_Product_Attribute_Source_Msrp_Type::TYPE_BEFORE_ORDER_CONFIRM)) { $message = $this->__('See price before order confirmation.'); } return $message; diff --git a/app/code/core/Mage/Catalog/Helper/Output.php b/app/code/core/Mage/Catalog/Helper/Output.php index 04856aa7ff0a..ea759134114a 100644 --- a/app/code/core/Mage/Catalog/Helper/Output.php +++ b/app/code/core/Mage/Catalog/Helper/Output.php @@ -124,7 +124,8 @@ public function productAttribute($product, $attributeHtml, $attributeName) /** @var Mage_Catalog_Model_Resource_Eav_Attribute $attribute */ $attribute = Mage::getSingleton('eav/config')->getAttribute(Mage_Catalog_Model_Product::ENTITY, $attributeName); if ($attribute && $attribute->getId() && ($attribute->getFrontendInput() != 'media_image') - && (!$attribute->getIsHtmlAllowedOnFront() && !$attribute->getIsWysiwygEnabled())) { + && (!$attribute->getIsHtmlAllowedOnFront() && !$attribute->getIsWysiwygEnabled()) + ) { if ($attribute->getFrontendInput() != 'price') { $attributeHtml = $this->escapeHtml($attributeHtml); } @@ -160,7 +161,8 @@ public function categoryAttribute($category, $attributeHtml, $attributeName) $attribute = Mage::getSingleton('eav/config')->getAttribute(Mage_Catalog_Model_Category::ENTITY, $attributeName); if ($attribute && ($attribute->getFrontendInput() != 'image') - && (!$attribute->getIsHtmlAllowedOnFront() && !$attribute->getIsWysiwygEnabled())) { + && (!$attribute->getIsHtmlAllowedOnFront() && !$attribute->getIsWysiwygEnabled()) + ) { $attributeHtml = $this->escapeHtml($attributeHtml); } if ($attribute->getIsHtmlAllowedOnFront() && $attribute->getIsWysiwygEnabled()) { diff --git a/app/code/core/Mage/Catalog/Model/Abstract.php b/app/code/core/Mage/Catalog/Model/Abstract.php index 6f0a7a261e5b..6d9d2e77ad40 100644 --- a/app/code/core/Mage/Catalog/Model/Abstract.php +++ b/app/code/core/Mage/Catalog/Model/Abstract.php @@ -186,7 +186,8 @@ public function setData($key, $value = null) public function unsetData($key = null) { if ((!is_null($key) && $this->isLockedAttribute($key)) || - $this->isReadonly()) { + $this->isReadonly() + ) { return $this; } diff --git a/app/code/core/Mage/Catalog/Model/Api/Resource.php b/app/code/core/Mage/Catalog/Model/Api/Resource.php index 2eb17d669e26..9c4df6652642 100644 --- a/app/code/core/Mage/Catalog/Model/Api/Resource.php +++ b/app/code/core/Mage/Catalog/Model/Api/Resource.php @@ -71,7 +71,8 @@ protected function _isAllowedAttribute($attribute, $attributes = null) if (is_array($attributes) && !(in_array($attribute->getAttributeCode(), $attributes) - || in_array($attribute->getAttributeId(), $attributes))) { + || in_array($attribute->getAttributeId(), $attributes)) + ) { return false; } diff --git a/app/code/core/Mage/Catalog/Model/Api2/Product/Rest/Admin/V1.php b/app/code/core/Mage/Catalog/Model/Api2/Product/Rest/Admin/V1.php index aa6333bc35dd..b985096657d9 100644 --- a/app/code/core/Mage/Catalog/Model/Api2/Product/Rest/Admin/V1.php +++ b/app/code/core/Mage/Catalog/Model/Api2/Product/Rest/Admin/V1.php @@ -281,7 +281,8 @@ protected function _prepareDataForSave($product, $productData) if (isset($productData['use_config_gift_message_available'])) { $product->setData('use_config_gift_message_available', $productData['use_config_gift_message_available']); if (!$productData['use_config_gift_message_available'] - && ($product->getData('gift_message_available') === null)) { + && ($product->getData('gift_message_available') === null) + ) { $product->setData('gift_message_available', (int) Mage::getStoreConfig( Mage_GiftMessage_Helper_Message::XPATH_CONFIG_GIFT_MESSAGE_ALLOW_ITEMS, $product->getStoreId() diff --git a/app/code/core/Mage/Catalog/Model/Api2/Product/Validator/Product.php b/app/code/core/Mage/Catalog/Model/Api2/Product/Validator/Product.php index 27d104849306..f01bb09fabdb 100644 --- a/app/code/core/Mage/Catalog/Model/Api2/Product/Validator/Product.php +++ b/app/code/core/Mage/Catalog/Model/Api2/Product/Validator/Product.php @@ -140,7 +140,8 @@ protected function _validateAttributes($data, $productEntity) } // Validate weight if (isset($data['weight']) && !empty($data['weight']) && $data['weight'] > 0 - && !Zend_Validate::is($data['weight'], 'Between', [0, self::MAX_DECIMAL_VALUE])) { + && !Zend_Validate::is($data['weight'], 'Between', [0, self::MAX_DECIMAL_VALUE]) + ) { $this->_addError('The "weight" value is not within the specified range.'); } // msrp_display_actual_price_type attribute values needs to be a string to pass validation @@ -177,7 +178,8 @@ protected function _validateAttributes($data, $productEntity) // Validate dropdown attributes if ($attribute->usesSource() // skip check when field will be validated later as a required one - && !(empty($value) && $attribute->getIsRequired())) { + && !(empty($value) && $attribute->getIsRequired()) + ) { $allowedValues = $this->_getAttributeAllowedValues($attribute->getSource()->getAllOptions()); if (!is_array($value)) { // make validation of select and multiselect identical @@ -186,7 +188,8 @@ protected function _validateAttributes($data, $productEntity) foreach ($value as $selectValue) { $useStrictMode = !is_numeric($selectValue); if (!in_array($selectValue, $allowedValues, $useStrictMode) - && !$this->_isConfigValueUsed($data, $attributeCode)) { + && !$this->_isConfigValueUsed($data, $attributeCode) + ) { $this->_addError(sprintf( 'Invalid value "%s" for attribute "%s".', $selectValue, diff --git a/app/code/core/Mage/Catalog/Model/Category/Api.php b/app/code/core/Mage/Catalog/Model/Category/Api.php index b54a269e109b..a8dd25d38bfe 100644 --- a/app/code/core/Mage/Catalog/Model/Category/Api.php +++ b/app/code/core/Mage/Catalog/Model/Category/Api.php @@ -311,7 +311,8 @@ public function update($categoryId, $categoryData, $store = null) foreach ($category->getAttributes() as $attribute) { if ($this->_isAllowedAttribute($attribute) - && isset($categoryData[$attribute->getAttributeCode()])) { + && isset($categoryData[$attribute->getAttributeCode()]) + ) { $category->setData( $attribute->getAttributeCode(), $categoryData[$attribute->getAttributeCode()] diff --git a/app/code/core/Mage/Catalog/Model/Category/Api/V2.php b/app/code/core/Mage/Catalog/Model/Category/Api/V2.php index 1a36e0f7213a..4641cf350e50 100644 --- a/app/code/core/Mage/Catalog/Model/Category/Api/V2.php +++ b/app/code/core/Mage/Catalog/Model/Category/Api/V2.php @@ -85,7 +85,8 @@ public function create($parentId, $categoryData, $store = null) foreach ($category->getAttributes() as $attribute) { $_attrCode = $attribute->getAttributeCode(); if ($this->_isAllowedAttribute($attribute) - && isset($categoryData->$_attrCode)) { + && isset($categoryData->$_attrCode) + ) { $category->setData( $attribute->getAttributeCode(), $categoryData->$_attrCode @@ -128,7 +129,8 @@ public function update($categoryId, $categoryData, $store = null) foreach ($category->getAttributes() as $attribute) { $_attrCode = $attribute->getAttributeCode(); if ($this->_isAllowedAttribute($attribute) - && isset($categoryData->$_attrCode)) { + && isset($categoryData->$_attrCode) + ) { $category->setData( $attribute->getAttributeCode(), $categoryData->$_attrCode diff --git a/app/code/core/Mage/Catalog/Model/Category/Indexer/Flat.php b/app/code/core/Mage/Catalog/Model/Category/Indexer/Flat.php index 562979fce203..84f1afa660f1 100644 --- a/app/code/core/Mage/Catalog/Model/Category/Indexer/Flat.php +++ b/app/code/core/Mage/Catalog/Model/Category/Indexer/Flat.php @@ -19,6 +19,11 @@ * @license https://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0) */ +use Mage_Catalog_Model_Category as Category; +use Mage_Core_Model_Store as Store; +use Mage_Core_Model_Store_Group as StoreGroup; +use Mage_Index_Model_Event as Event; + /** * Catalog Category Flat Indexer Model * @@ -39,15 +44,15 @@ class Mage_Catalog_Model_Category_Indexer_Flat extends Mage_Index_Model_Indexer_ * @var array */ protected $_matchedEntities = [ - Mage_Catalog_Model_Category::ENTITY => [ - Mage_Index_Model_Event::TYPE_SAVE + Category::ENTITY => [ + Event::TYPE_SAVE ], - Mage_Core_Model_Store::ENTITY => [ - Mage_Index_Model_Event::TYPE_SAVE, - Mage_Index_Model_Event::TYPE_DELETE + Store::ENTITY => [ + Event::TYPE_SAVE, + Event::TYPE_DELETE ], - Mage_Core_Model_Store_Group::ENTITY => [ - Mage_Index_Model_Event::TYPE_SAVE + StoreGroup::ENTITY => [ + Event::TYPE_SAVE ], ]; @@ -98,10 +103,10 @@ protected function _getIndexer() * Overwrote for check is flat catalog category is enabled and specific save * category, store, store_group * - * @param Mage_Index_Model_Event $event + * @param Event $event * @return bool */ - public function matchEvent(Mage_Index_Model_Event $event) + public function matchEvent(Event $event) { /** @var Mage_Catalog_Helper_Category_Flat $categoryFlatHelper */ $categoryFlatHelper = Mage::helper('catalog/category_flat'); @@ -115,17 +120,19 @@ public function matchEvent(Mage_Index_Model_Event $event) } $entity = $event->getEntity(); - if ($entity == Mage_Core_Model_Store::ENTITY) { - if ($event->getType() == Mage_Index_Model_Event::TYPE_DELETE) { + if ($entity == Store::ENTITY) { + if ($event->getType() == Event::TYPE_DELETE) { $result = true; - } elseif ($event->getType() == Mage_Index_Model_Event::TYPE_SAVE) { - /** @var Mage_Core_Model_Store $store */ + } elseif ($event->getType() == Event::TYPE_SAVE) { + /** @var Store $store */ $store = $event->getDataObject(); - if ($store && ( - $store->isObjectNew() - || $store->dataHasChangedFor('group_id') - || $store->dataHasChangedFor('root_category_id') - )) { + if ($store + && ( + $store->isObjectNew() + || $store->dataHasChangedFor('group_id') + || $store->dataHasChangedFor('root_category_id') + ) + ) { $result = true; } else { $result = false; @@ -133,8 +140,8 @@ public function matchEvent(Mage_Index_Model_Event $event) } else { $result = false; } - } elseif ($entity == Mage_Core_Model_Store_Group::ENTITY) { - /** @var Mage_Core_Model_Store_Group $storeGroup */ + } elseif ($entity == StoreGroup::ENTITY) { + /** @var StoreGroup $storeGroup */ $storeGroup = $event->getDataObject(); if ($storeGroup && ($storeGroup->dataHasChangedFor('website_id') || $storeGroup->dataHasChangedFor('root_category_id')) @@ -155,23 +162,23 @@ public function matchEvent(Mage_Index_Model_Event $event) /** * Register data required by process in event object * - * @param Mage_Index_Model_Event $event + * @param Event $event */ - protected function _registerEvent(Mage_Index_Model_Event $event) + protected function _registerEvent(Event $event) { $event->addNewData(self::EVENT_MATCH_RESULT_KEY, true); switch ($event->getEntity()) { - case Mage_Catalog_Model_Category::ENTITY: + case Category::ENTITY: $this->_registerCatalogCategoryEvent($event); break; - case Mage_Core_Model_Store::ENTITY: - if ($event->getType() == Mage_Index_Model_Event::TYPE_DELETE) { + case Store::ENTITY: + if ($event->getType() == Event::TYPE_DELETE) { $this->_registerCoreStoreEvent($event); break; } // no break - case Mage_Core_Model_Store_Group::ENTITY: + case StoreGroup::ENTITY: $event->addNewData('catalog_category_flat_skip_call_event_handler', true); $process = $event->getProcess(); $process->changeStatus(Mage_Index_Model_Process::STATUS_REQUIRE_REINDEX); @@ -182,14 +189,14 @@ protected function _registerEvent(Mage_Index_Model_Event $event) /** * Register data required by catalog category process in event object * - * @param Mage_Index_Model_Event $event + * @param Event $event * @return $this */ - protected function _registerCatalogCategoryEvent(Mage_Index_Model_Event $event) + protected function _registerCatalogCategoryEvent(Event $event) { switch ($event->getType()) { - case Mage_Index_Model_Event::TYPE_SAVE: - /** @var Mage_Catalog_Model_Category $category */ + case Event::TYPE_SAVE: + /** @var Category $category */ $category = $event->getDataObject(); /** @@ -210,13 +217,13 @@ protected function _registerCatalogCategoryEvent(Mage_Index_Model_Event $event) /** * Register core store delete process * - * @param Mage_Index_Model_Event $event + * @param Event $event * @return $this */ - protected function _registerCoreStoreEvent(Mage_Index_Model_Event $event) + protected function _registerCoreStoreEvent(Event $event) { - if ($event->getType() == Mage_Index_Model_Event::TYPE_DELETE) { - /** @var Mage_Core_Model_Store $store */ + if ($event->getType() == Event::TYPE_DELETE) { + /** @var Store $store */ $store = $event->getDataObject(); $event->addNewData('catalog_category_flat_delete_store_id', $store->getId()); } @@ -226,9 +233,9 @@ protected function _registerCoreStoreEvent(Mage_Index_Model_Event $event) /** * Process event * - * @param Mage_Index_Model_Event $event + * @param Event $event */ - protected function _processEvent(Mage_Index_Model_Event $event) + protected function _processEvent(Event $event) { $data = $event->getNewData(); diff --git a/app/code/core/Mage/Catalog/Model/Category/Indexer/Product.php b/app/code/core/Mage/Catalog/Model/Category/Indexer/Product.php index 6c1b5170aee1..0536c6f480c9 100644 --- a/app/code/core/Mage/Catalog/Model/Category/Indexer/Product.php +++ b/app/code/core/Mage/Catalog/Model/Category/Indexer/Product.php @@ -191,7 +191,8 @@ protected function _registerProductEvent(Mage_Index_Model_Event $event) * Check if product categories data was changed */ if ($product->getIsChangedCategories() || $product->dataHasChangedFor('status') - || $product->dataHasChangedFor('visibility') || $product->getIsChangedWebsites()) { + || $product->dataHasChangedFor('visibility') || $product->getIsChangedWebsites() + ) { $event->addNewData('category_ids', $product->getCategoryIds()); } } elseif ($eventType == Mage_Index_Model_Event::TYPE_MASS_ACTION) { diff --git a/app/code/core/Mage/Catalog/Model/Design.php b/app/code/core/Mage/Catalog/Model/Design.php index bdd23cee8f9c..ec4d57c9cb6b 100644 --- a/app/code/core/Mage/Catalog/Model/Design.php +++ b/app/code/core/Mage/Catalog/Model/Design.php @@ -214,7 +214,8 @@ protected function _inheritDesign($object, $calledFrom = 0) if ($category && $category->getId() && $category->getLevel() > 1 && - $category->getId() != Mage_Catalog_Model_Category::TREE_ROOT_ID) { + $category->getId() != Mage_Catalog_Model_Category::TREE_ROOT_ID + ) { return $this->_inheritDesign($category, $calledFrom); } } @@ -373,7 +374,8 @@ protected function _extractSettings($object) } $date = $object->getCustomDesignDate(); if (array_key_exists('from', $date) && array_key_exists('to', $date) - && Mage::app()->getLocale()->isStoreDateInInterval(null, $date['from'], $date['to'])) { + && Mage::app()->getLocale()->isStoreDateInInterval(null, $date['from'], $date['to']) + ) { $customLayout = $object->getCustomLayoutUpdate(); if ($customLayout) { try { diff --git a/app/code/core/Mage/Catalog/Model/Product/Api.php b/app/code/core/Mage/Catalog/Model/Product/Api.php index a1c22dfb433c..5933ad5c14d0 100644 --- a/app/code/core/Mage/Catalog/Model/Product/Api.php +++ b/app/code/core/Mage/Catalog/Model/Product/Api.php @@ -409,7 +409,8 @@ public function getAdditionalAttributes($productType, $attributeSetId) foreach ($productAttributes as $attribute) { /** @var Mage_Catalog_Model_Resource_Eav_Attribute $attribute */ if ($attribute->isInSet($attributeSetId) && $this->_isAllowedAttribute($attribute) - && !in_array($attribute->getAttributeCode(), $this->_defaultProductAttributeList)) { + && !in_array($attribute->getAttributeCode(), $this->_defaultProductAttributeList) + ) { if ($attribute->isScopeGlobal()) { $scope = 'global'; } elseif ($attribute->isScopeWebsite()) { diff --git a/app/code/core/Mage/Catalog/Model/Product/Attribute/Api.php b/app/code/core/Mage/Catalog/Model/Product/Attribute/Api.php index 2f0953d506b4..400ba3f94b92 100644 --- a/app/code/core/Mage/Catalog/Model/Product/Attribute/Api.php +++ b/app/code/core/Mage/Catalog/Model/Product/Attribute/Api.php @@ -60,7 +60,8 @@ public function items($setId) foreach ($attributes as $attribute) { /** @var Mage_Catalog_Model_Resource_Eav_Attribute $attribute */ if ((!$attribute->getId() || $attribute->isInSet($setId)) - && $this->_isAllowedAttribute($attribute)) { + && $this->_isAllowedAttribute($attribute) + ) { if (!$attribute->getId() || $attribute->isScopeGlobal()) { $scope = 'global'; } elseif ($attribute->isScopeWebsite()) { diff --git a/app/code/core/Mage/Catalog/Model/Product/Attribute/Media/Api.php b/app/code/core/Mage/Catalog/Model/Product/Attribute/Media/Api.php index 021144e59d94..1a692146f19c 100644 --- a/app/code/core/Mage/Catalog/Model/Product/Attribute/Media/Api.php +++ b/app/code/core/Mage/Catalog/Model/Product/Attribute/Media/Api.php @@ -312,7 +312,8 @@ public function types($setId) foreach ($attributes as $attribute) { /** @var Mage_Catalog_Model_Resource_Eav_Attribute $attribute */ if ($attribute->isInSet($setId) - && $attribute->getFrontendInput() == 'media_image') { + && $attribute->getFrontendInput() == 'media_image' + ) { if ($attribute->isScopeGlobal()) { $scope = 'global'; } elseif ($attribute->isScopeWebsite()) { diff --git a/app/code/core/Mage/Catalog/Model/Product/Attribute/Tierprice/Api.php b/app/code/core/Mage/Catalog/Model/Product/Attribute/Tierprice/Api.php index a1238ad30e79..29aa09df5042 100644 --- a/app/code/core/Mage/Catalog/Model/Product/Attribute/Tierprice/Api.php +++ b/app/code/core/Mage/Catalog/Model/Product/Attribute/Tierprice/Api.php @@ -131,7 +131,8 @@ public function prepareTierPrices($product, $tierPrices = null) foreach ($tierPrices as $tierPrice) { if (!is_array($tierPrice) || !isset($tierPrice['qty']) - || !isset($tierPrice['price'])) { + || !isset($tierPrice['price']) + ) { $this->_fault('data_invalid', Mage::helper('catalog')->__('Invalid Tier Prices')); } diff --git a/app/code/core/Mage/Catalog/Model/Product/Attribute/Tierprice/Api/V2.php b/app/code/core/Mage/Catalog/Model/Product/Attribute/Tierprice/Api/V2.php index 8ec1fda6db0d..f3effefac8bd 100644 --- a/app/code/core/Mage/Catalog/Model/Product/Attribute/Tierprice/Api/V2.php +++ b/app/code/core/Mage/Catalog/Model/Product/Attribute/Tierprice/Api/V2.php @@ -46,7 +46,8 @@ public function prepareTierPrices($product, $tierPrices = null) foreach ($tierPrices as $tierPrice) { if (!is_object($tierPrice) || !isset($tierPrice->qty) - || !isset($tierPrice->price)) { + || !isset($tierPrice->price) + ) { $this->_fault('data_invalid', Mage::helper('catalog')->__('Invalid Tier Prices')); } diff --git a/app/code/core/Mage/Catalog/Model/Product/Flat/Observer.php b/app/code/core/Mage/Catalog/Model/Product/Flat/Observer.php index 5341d866457b..e28aabffa9bd 100644 --- a/app/code/core/Mage/Catalog/Model/Product/Flat/Observer.php +++ b/app/code/core/Mage/Catalog/Model/Product/Flat/Observer.php @@ -274,7 +274,8 @@ public function customerGroupSaveAfter(Varien_Event_Observer $observer) $customerGroup = $observer->getEvent()->getObject(); /** @var Mage_Customer_Model_Group $customerGroup */ if ($customerGroup->dataHasChangedFor($customerGroup->getIdFieldName()) - || $customerGroup->dataHasChangedFor('tax_class_id')) { + || $customerGroup->dataHasChangedFor('tax_class_id') + ) { $this->_getIndexer()->updateEventAttributes(); } return $this; diff --git a/app/code/core/Mage/Catalog/Model/Product/Image.php b/app/code/core/Mage/Catalog/Model/Product/Image.php index 018f46ac3347..3f7543666aa7 100644 --- a/app/code/core/Mage/Catalog/Model/Product/Image.php +++ b/app/code/core/Mage/Catalog/Model/Product/Image.php @@ -392,8 +392,8 @@ public function setBaseFile($file) // add misc params as a hash $miscParams = [ - ($this->_keepAspectRatio ? '' : 'non') . 'proportional', - ($this->_keepFrame ? '' : 'no') . 'frame', + ($this->_keepAspectRatio ? '' : 'non') . 'proportional', + ($this->_keepFrame ? '' : 'no') . 'frame', ($this->_keepTransparency ? '' : 'no') . 'transparency', ($this->_constrainOnly ? 'do' : 'not') . 'constrainonly', $this->_rgbToString($this->_backgroundColor), diff --git a/app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php b/app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php index 6a68499e4e2b..d34326a80fd0 100644 --- a/app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php +++ b/app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php @@ -407,7 +407,8 @@ protected function _getValidatorErrors($errors, $fileInfo) } elseif ($errorCode == Zend_Validate_File_Extension::FALSE_EXTENSION) { $result[] = Mage::helper('catalog')->__("The file '%s' for '%s' has an invalid extension", $fileInfo['title'], $option->getTitle()); } elseif ($errorCode == Zend_Validate_File_ImageSize::WIDTH_TOO_BIG - || $errorCode == Zend_Validate_File_ImageSize::HEIGHT_TOO_BIG) { + || $errorCode == Zend_Validate_File_ImageSize::HEIGHT_TOO_BIG + ) { $result[] = Mage::helper('catalog')->__("Maximum allowed image size for '%s' is %sx%s px.", $option->getTitle(), $option->getImageSizeX(), $option->getImageSizeY()); } elseif ($errorCode == Zend_Validate_File_FilesSize::TOO_BIG) { $result[] = Mage::helper('catalog')->__("The file '%s' you uploaded is larger than %s Megabytes allowed by server", $fileInfo['title'], $this->_bytesToMbytes($this->_getUploadMaxFilesize())); diff --git a/app/code/core/Mage/Catalog/Model/Product/Type/Abstract.php b/app/code/core/Mage/Catalog/Model/Product/Type/Abstract.php index 5e1bd32c430b..2d2c5893105e 100644 --- a/app/code/core/Mage/Catalog/Model/Product/Type/Abstract.php +++ b/app/code/core/Mage/Catalog/Model/Product/Type/Abstract.php @@ -244,7 +244,8 @@ public function getEditableAttributes($product = null) foreach ($this->getSetAttributes($product) as $attributeCode => $attribute) { if (!is_array($attribute->getApplyTo()) || count($attribute->getApplyTo()) == 0 - || in_array($this->getProduct($product)->getTypeId(), $attribute->getApplyTo())) { + || in_array($this->getProduct($product)->getTypeId(), $attribute->getApplyTo()) + ) { $editableAttributes[$attributeCode] = $attribute; } } diff --git a/app/code/core/Mage/Catalog/Model/Product/Type/Configurable.php b/app/code/core/Mage/Catalog/Model/Product/Type/Configurable.php index 0f76b06e33a9..d88203debbe7 100644 --- a/app/code/core/Mage/Catalog/Model/Product/Type/Configurable.php +++ b/app/code/core/Mage/Catalog/Model/Product/Type/Configurable.php @@ -149,7 +149,8 @@ public function getEditableAttributes($product = null) $this->_editableAttributes = parent::getEditableAttributes($product); foreach ($this->_editableAttributes as $index => $attribute) { if ($this->getUsedProductAttributeIds($product) - && in_array($attribute->getAttributeId(), $this->getUsedProductAttributeIds($product))) { + && in_array($attribute->getAttributeId(), $this->getUsedProductAttributeIds($product)) + ) { unset($this->_editableAttributes[$index]); } } @@ -324,7 +325,8 @@ public function getUsedProducts($requiredAttributeIds = null, $product = null) Varien_Profiler::start('CONFIGURABLE:' . __METHOD__); if (!$this->getProduct($product)->hasData($this->_usedProducts)) { if (is_null($requiredAttributeIds) - and is_null($this->getProduct($product)->getData($this->_configurableAttributes))) { + && is_null($this->getProduct($product)->getData($this->_configurableAttributes)) + ) { // If used products load before attributes, we will load attributes. $this->getConfigurableAttributes($product); // After attributes loading products loaded too. diff --git a/app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php b/app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php index 6a8dc287f92c..063e2e3581b5 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php @@ -583,7 +583,8 @@ protected function _createTable($store) foreach ($this->_columns as $fieldName => $fieldProp) { $default = $fieldProp['default']; if ($fieldProp['type'][0] == Varien_Db_Ddl_Table::TYPE_TIMESTAMP - && $default === 'CURRENT_TIMESTAMP') { + && $default === 'CURRENT_TIMESTAMP' + ) { $default = Varien_Db_Ddl_Table::TIMESTAMP_INIT; } $table->addColumn($fieldName, $fieldProp['type'][0], $fieldProp['type'][1], [ diff --git a/app/code/core/Mage/Catalog/Model/Resource/Eav/Attribute.php b/app/code/core/Mage/Catalog/Model/Resource/Eav/Attribute.php index 1cd9c97750d7..30e4b7ea4ec0 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Eav/Attribute.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Eav/Attribute.php @@ -113,7 +113,8 @@ protected function _beforeSave() $this->_data['is_global'] = self::SCOPE_GLOBAL; } if (($this->_data['is_global'] != $this->_origData['is_global']) - && $this->_getResource()->isUsedBySuperProducts($this)) { + && $this->_getResource()->isUsedBySuperProducts($this) + ) { Mage::throwException(Mage::helper('catalog')->__('Scope must not be changed, because the attribute is used in configurable products.')); } } diff --git a/app/code/core/Mage/Catalog/Model/Resource/Product/Flat/Indexer.php b/app/code/core/Mage/Catalog/Model/Resource/Product/Flat/Indexer.php index 45348422a32d..7784e548bedc 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Product/Flat/Indexer.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Product/Flat/Indexer.php @@ -730,7 +730,8 @@ public function prepareFlatTable($storeId) if (isset($indexesNeed[$key])) { $indexNeed = $indexesNeed[$key]; if (($indexNeed['INDEX_TYPE'] != $indexNow['INDEX_TYPE']) - || ($indexNeed['COLUMNS_LIST'] != $indexNow['COLUMNS_LIST'])) { + || ($indexNeed['COLUMNS_LIST'] != $indexNow['COLUMNS_LIST']) + ) { $dropIndexes[$key] = $indexNow; $addIndexes[$key] = $indexNeed; } diff --git a/app/code/core/Mage/Catalog/Model/Resource/Product/Option.php b/app/code/core/Mage/Catalog/Model/Resource/Product/Option.php index 6bab892f0299..102b5fcacabf 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Product/Option.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Product/Option.php @@ -118,7 +118,8 @@ protected function _saveValuePrices(Mage_Core_Model_Abstract $object) $scope = (int) Mage::app()->getStore()->getConfig(Mage_Core_Model_Store::XML_PATH_PRICE_SCOPE); if ($object->getStoreId() != '0' && $scope == Mage_Core_Model_Store::PRICE_SCOPE_WEBSITE - && !$object->getData('scope', 'price')) { + && !$object->getData('scope', 'price') + ) { $baseCurrency = Mage::app()->getBaseCurrencyCode(); $storeIds = Mage::app()->getStore($object->getStoreId())->getWebsite()->getStoreIds(); diff --git a/app/code/core/Mage/Catalog/Model/Resource/Product/Option/Value.php b/app/code/core/Mage/Catalog/Model/Resource/Product/Option/Value.php index 65281e7a4669..337eb43f5843 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Product/Option/Value.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Product/Option/Value.php @@ -95,7 +95,8 @@ protected function _saveValuePrices(Mage_Core_Model_Abstract $object) $scope = (int)Mage::app()->getStore()->getConfig(Mage_Core_Model_Store::XML_PATH_PRICE_SCOPE); if ($object->getStoreId() != '0' && $scope == Mage_Core_Model_Store::PRICE_SCOPE_WEBSITE - && !$object->getData('scope', 'price')) { + && !$object->getData('scope', 'price') + ) { $baseCurrency = Mage::app()->getBaseCurrencyCode(); $storeIds = Mage::app()->getStore($object->getStoreId()) diff --git a/app/code/core/Mage/Catalog/Model/Resource/Product/Website.php b/app/code/core/Mage/Catalog/Model/Resource/Product/Website.php index 311b45e394a3..9bb582cb18f3 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Product/Website.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Product/Website.php @@ -54,7 +54,8 @@ protected function _getProductResource() public function removeProducts($websiteIds, $productIds) { if (!is_array($websiteIds) || !is_array($productIds) - || count($websiteIds) == 0 || count($productIds) == 0) { + || count($websiteIds) == 0 || count($productIds) == 0 + ) { return $this; } @@ -88,7 +89,8 @@ public function removeProducts($websiteIds, $productIds) public function addProducts($websiteIds, $productIds) { if (!is_array($websiteIds) || !is_array($productIds) - || count($websiteIds) == 0 || count($productIds) == 0) { + || count($websiteIds) == 0 || count($productIds) == 0 + ) { return $this; } diff --git a/app/code/core/Mage/Catalog/Model/Resource/Url.php b/app/code/core/Mage/Catalog/Model/Resource/Url.php index d19093e51cd3..638c18f04793 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Url.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Url.php @@ -750,7 +750,8 @@ protected function _getCategories($categoryIds, $storeId = null, $path = null) } // Second - check non-root category - that it's really a descendant, not a simple string match if ((strlen($row['path']) > $rootCategoryPathLength) - && ($row['path'][$rootCategoryPathLength] !== '/')) { + && ($row['path'][$rootCategoryPathLength] !== '/') + ) { continue; } } diff --git a/app/code/core/Mage/CatalogIndex/Model/Indexer.php b/app/code/core/Mage/CatalogIndex/Model/Indexer.php index ed4feda62610..062e69d0808a 100644 --- a/app/code/core/Mage/CatalogIndex/Model/Indexer.php +++ b/app/code/core/Mage/CatalogIndex/Model/Indexer.php @@ -604,7 +604,8 @@ public function buildEntityPriceFilter($attributes, $values, &$filteredAttribute if ($indexer->isAttributeIndexable($attribute)) { if ($values[$code]) { if (isset($values[$code]['from']) && isset($values[$code]['to']) - && (strlen($values[$code]['from']) == 0 && strlen($values[$code]['to']) == 0)) { + && (strlen($values[$code]['from']) == 0 && strlen($values[$code]['to']) == 0) + ) { continue; } $table = $indexer->getResource()->getMainTable(); @@ -699,7 +700,8 @@ public function buildEntityFilter($attributes, $values, &$filteredAttributes, $p if ($indexer->isAttributeIndexable($attribute)) { if ($values[$code]) { if (isset($values[$code]['from']) && isset($values[$code]['to']) - && (!$values[$code]['from'] && !$values[$code]['to'])) { + && (!$values[$code]['from'] && !$values[$code]['to']) + ) { continue; } diff --git a/app/code/core/Mage/CatalogIndex/Model/Indexer/Abstract.php b/app/code/core/Mage/CatalogIndex/Model/Indexer/Abstract.php index bae3ae2f84b4..2133c7fde991 100644 --- a/app/code/core/Mage/CatalogIndex/Model/Indexer/Abstract.php +++ b/app/code/core/Mage/CatalogIndex/Model/Indexer/Abstract.php @@ -130,7 +130,8 @@ protected function _isObjectIndexable(Mage_Catalog_Model_Product $object) } if ($object->getVisibility() != Mage_Catalog_Model_Product_Visibility::VISIBILITY_IN_CATALOG && - $object->getVisibility() != Mage_Catalog_Model_Product_Visibility::VISIBILITY_BOTH) { + $object->getVisibility() != Mage_Catalog_Model_Product_Visibility::VISIBILITY_BOTH + ) { return false; } diff --git a/app/code/core/Mage/CatalogInventory/Model/Observer.php b/app/code/core/Mage/CatalogInventory/Model/Observer.php index 779492f94a72..8fd5736004e1 100644 --- a/app/code/core/Mage/CatalogInventory/Model/Observer.php +++ b/app/code/core/Mage/CatalogInventory/Model/Observer.php @@ -91,7 +91,8 @@ public function removeInventoryData($observer) $product = $observer->getEvent()->getProduct(); if (($product instanceof Mage_Catalog_Model_Product) && $product->getId() - && isset($this->_stockItemsArray[$product->getId()])) { + && isset($this->_stockItemsArray[$product->getId()]) + ) { unset($this->_stockItemsArray[$product->getId()]); } return $this; @@ -209,23 +210,28 @@ protected function _prepareItemForSave($item, $product) ->setProductId($product->getId()) ->setStockId($item->getStockId()); if (!is_null($product->getData('stock_data/min_qty')) - && is_null($product->getData('stock_data/use_config_min_qty'))) { + && is_null($product->getData('stock_data/use_config_min_qty')) + ) { $item->setData('use_config_min_qty', false); } if (!is_null($product->getData('stock_data/min_sale_qty')) - && is_null($product->getData('stock_data/use_config_min_sale_qty'))) { + && is_null($product->getData('stock_data/use_config_min_sale_qty')) + ) { $item->setData('use_config_min_sale_qty', false); } if (!is_null($product->getData('stock_data/max_sale_qty')) - && is_null($product->getData('stock_data/use_config_max_sale_qty'))) { + && is_null($product->getData('stock_data/use_config_max_sale_qty')) + ) { $item->setData('use_config_max_sale_qty', false); } if (!is_null($product->getData('stock_data/backorders')) - && is_null($product->getData('stock_data/use_config_backorders'))) { + && is_null($product->getData('stock_data/use_config_backorders')) + ) { $item->setData('use_config_backorders', false); } if (!is_null($product->getData('stock_data/notify_stock_qty')) - && is_null($product->getData('stock_data/use_config_notify_stock_qty'))) { + && is_null($product->getData('stock_data/use_config_notify_stock_qty')) + ) { $item->setData('use_config_notify_stock_qty', false); } $originalQty = $product->getData('stock_data/original_inventory_qty'); @@ -233,11 +239,13 @@ protected function _prepareItemForSave($item, $product) $item->setQtyCorrection($item->getQty() - $originalQty); } if (!is_null($product->getData('stock_data/enable_qty_increments')) - && is_null($product->getData('stock_data/use_config_enable_qty_inc'))) { + && is_null($product->getData('stock_data/use_config_enable_qty_inc')) + ) { $item->setData('use_config_enable_qty_inc', false); } if (!is_null($product->getData('stock_data/qty_increments')) - && is_null($product->getData('stock_data/use_config_qty_increments'))) { + && is_null($product->getData('stock_data/use_config_qty_increments')) + ) { $item->setData('use_config_qty_increments', false); } return $this; @@ -305,7 +313,8 @@ public function checkQuoteItemQty($observer) $quoteItem = $observer->getEvent()->getItem(); /** @var Mage_Sales_Model_Quote_Item $quoteItem */ if (!$quoteItem || !$quoteItem->getProductId() || !$quoteItem->getQuote() - || $quoteItem->getQuote()->getIsSuperMode()) { + || $quoteItem->getQuote()->getIsSuperMode() + ) { return $this; } @@ -587,7 +596,8 @@ protected function _getQuoteItemQtyForCheck($productId, $quoteItemId, $itemQty) { $qty = $itemQty; if (isset($this->_checkedQuoteItems[$productId]['qty']) && - !in_array($quoteItemId, $this->_checkedQuoteItems[$productId]['items'])) { + !in_array($quoteItemId, $this->_checkedQuoteItems[$productId]['items']) + ) { $qty += $this->_checkedQuoteItems[$productId]['qty']; } diff --git a/app/code/core/Mage/CatalogInventory/sql/cataloginventory_setup/mysql4-upgrade-0.7.3-0.7.4.php b/app/code/core/Mage/CatalogInventory/sql/cataloginventory_setup/mysql4-upgrade-0.7.3-0.7.4.php index 597372d1606e..5697c38c01ba 100644 --- a/app/code/core/Mage/CatalogInventory/sql/cataloginventory_setup/mysql4-upgrade-0.7.3-0.7.4.php +++ b/app/code/core/Mage/CatalogInventory/sql/cataloginventory_setup/mysql4-upgrade-0.7.3-0.7.4.php @@ -30,7 +30,8 @@ 'cataloginventory/options/backorders' => 'cataloginventory/item_options/backorders', 'cataloginventory/options/notify_stock_qty' => 'cataloginventory/item_options/notify_stock_qty', 'cataloginventory/options/manage_stock' => 'cataloginventory/item_options/manage_stock', - ] as $was => $become) { + ] as $was => $become +) { $installer->run(sprintf( "UPDATE `%s` SET `path` = '%s' WHERE `path` = '%s'", $this->getTable('core/config_data'), diff --git a/app/code/core/Mage/CatalogSearch/Block/Layer.php b/app/code/core/Mage/CatalogSearch/Block/Layer.php index 541945bd9098..3c9bdf85f35b 100644 --- a/app/code/core/Mage/CatalogSearch/Block/Layer.php +++ b/app/code/core/Mage/CatalogSearch/Block/Layer.php @@ -83,7 +83,8 @@ public function canShowBlock() ->getConfig(Mage_CatalogSearch_Model_Layer::XML_PATH_DISPLAY_LAYER_COUNT); if (!$availableResCount - || ($availableResCount > $this->getLayer()->getProductCollection()->getSize())) { + || ($availableResCount > $this->getLayer()->getProductCollection()->getSize()) + ) { return parent::canShowBlock(); } return false; diff --git a/app/code/core/Mage/CatalogSearch/Model/Advanced.php b/app/code/core/Mage/CatalogSearch/Model/Advanced.php index 0616ccb3cc7b..84fcd07da78f 100644 --- a/app/code/core/Mage/CatalogSearch/Model/Advanced.php +++ b/app/code/core/Mage/CatalogSearch/Model/Advanced.php @@ -171,11 +171,12 @@ public function addFilters($values) } else { $rate = 1; } - if ($this->_getResource()->addRatedPriceFilter( - $this->getProductCollection(), - $attribute, - $value, - $rate + if ($this->_getResource() + ->addRatedPriceFilter( + $this->getProductCollection(), + $attribute, + $value, + $rate ) ) { $hasConditions = true; @@ -184,11 +185,13 @@ public function addFilters($values) } } elseif ($attribute->isIndexable()) { if (!is_string($value) || strlen($value) != 0) { - if ($this->_getResource()->addIndexableAttributeModifiedFilter( - $this->getProductCollection(), - $attribute, - $value - )) { + if ($this->_getResource() + ->addIndexableAttributeModifiedFilter( + $this->getProductCollection(), + $attribute, + $value + ) + ) { $hasConditions = true; $this->_addSearchCriteria($attribute, $value); } diff --git a/app/code/core/Mage/CatalogSearch/Model/Resource/Search/Collection.php b/app/code/core/Mage/CatalogSearch/Model/Resource/Search/Collection.php index c2a9b4cb228e..51e678088517 100644 --- a/app/code/core/Mage/CatalogSearch/Model/Resource/Search/Collection.php +++ b/app/code/core/Mage/CatalogSearch/Model/Resource/Search/Collection.php @@ -84,7 +84,8 @@ protected function _isAttributeTextAndSearchable($attribute) if (($attribute->getIsSearchable() && !in_array($attribute->getFrontendInput(), ['select', 'multiselect'])) && (in_array($attribute->getBackendType(), ['varchar', 'text']) - || $attribute->getBackendType() == 'static')) { + || $attribute->getBackendType() == 'static') + ) { return true; } return false; @@ -99,7 +100,8 @@ protected function _isAttributeTextAndSearchable($attribute) protected function _hasAttributeOptionsAndSearchable($attribute) { if ($attribute->getIsSearchable() - && in_array($attribute->getFrontendInput(), ['select', 'multiselect'])) { + && in_array($attribute->getFrontendInput(), ['select', 'multiselect']) + ) { return true; } diff --git a/app/code/core/Mage/Centinel/Block/Adminhtml/Validation.php b/app/code/core/Mage/Centinel/Block/Adminhtml/Validation.php index 6edc88c90355..081d99afa690 100644 --- a/app/code/core/Mage/Centinel/Block/Adminhtml/Validation.php +++ b/app/code/core/Mage/Centinel/Block/Adminhtml/Validation.php @@ -64,7 +64,8 @@ protected function _toHtml() if (!$payment->getMethod() || !$payment->getMethodInstance() || $payment->getMethodInstance()->getIsDummy() - || !$payment->getMethodInstance()->getIsCentinelValidationEnabled()) { + || !$payment->getMethodInstance()->getIsCentinelValidationEnabled() + ) { return ''; } return parent::_toHtml(); diff --git a/app/code/core/Mage/Centinel/Helper/Data.php b/app/code/core/Mage/Centinel/Helper/Data.php index 7326b767d1ee..0f5d0cd95238 100644 --- a/app/code/core/Mage/Centinel/Helper/Data.php +++ b/app/code/core/Mage/Centinel/Helper/Data.php @@ -141,7 +141,7 @@ private function _getCmpiParesValue($value) * Return centinel block for payment form with logos * * @param Mage_Payment_Model_Method_Abstract $method - * @return Mage_Centinel_Block_Logo + * @return Mage_Centinel_Block_Logo|Mage_Core_Block_Abstract|false */ public function getMethodFormBlock($method) { diff --git a/app/code/core/Mage/Centinel/Model/Config.php b/app/code/core/Mage/Centinel/Model/Config.php index e2a22973c6b9..2b551858f6d4 100644 --- a/app/code/core/Mage/Centinel/Model/Config.php +++ b/app/code/core/Mage/Centinel/Model/Config.php @@ -29,7 +29,7 @@ class Mage_Centinel_Model_Config /** * Store id or store model * - * @var int|Mage_Core_Model_Store + * @var int|Mage_Core_Model_Store|false */ protected $_store = false; @@ -73,7 +73,7 @@ public function getStore() * Return validation state class for card with type $cardType * * @param string $cardType - * @return string + * @return string|array|false */ public function getStateModelClass($cardType) { @@ -138,7 +138,7 @@ private function _getServiceConfigValue($key) /** * Define if debugging is enabled * - * @return bool + * @return string */ public function getDebugFlag() { diff --git a/app/code/core/Mage/Centinel/Model/Observer.php b/app/code/core/Mage/Centinel/Model/Observer.php index 8375dae48cd3..1c1e7cb0e26e 100644 --- a/app/code/core/Mage/Centinel/Model/Observer.php +++ b/app/code/core/Mage/Centinel/Model/Observer.php @@ -54,7 +54,7 @@ public function salesEventConvertQuoteToOrder($observer) public function paymentInfoBlockPrepareSpecificInformation($observer) { if ($observer->getEvent()->getBlock()->getIsSecureMode()) { - return; + return $this; } $payment = $observer->getEvent()->getPayment(); diff --git a/app/code/core/Mage/Centinel/Model/Service.php b/app/code/core/Mage/Centinel/Model/Service.php index a6ca26431afa..5cd402bd9558 100644 --- a/app/code/core/Mage/Centinel/Model/Service.php +++ b/app/code/core/Mage/Centinel/Model/Service.php @@ -54,14 +54,14 @@ class Mage_Centinel_Model_Service extends Varien_Object /** * Validation api model * - * @var Mage_Centinel_Model_Api + * @var Mage_Centinel_Model_Api|null */ protected $_api; /** * Validation state model * - * @var Mage_Centinel_Model_StateAbstract + * @var Mage_Centinel_Model_StateAbstract|false */ protected $_validationState; @@ -78,7 +78,7 @@ protected function _getSession() /** * Return value from section of centinel config * - * @return string + * @return Mage_Centinel_Model_Config */ protected function _getConfig() { @@ -131,7 +131,7 @@ private function _getUrl($suffix, $current = false) */ protected function _getApi() { - if (!is_null($this->_api)) { + if ($this->_api !== null) { return $this->_api; } @@ -151,12 +151,14 @@ protected function _getApi() * Create and return validation state model for card type * * @param string $cardType - * @return Mage_Centinel_Model_StateAbstract + * @return Mage_Centinel_Model_StateAbstract|false */ protected function _getValidationStateModel($cardType) { if ($modelClass = $this->_getConfig()->getStateModelClass($cardType)) { - return Mage::getModel($modelClass); + /** @var Mage_Centinel_Model_StateAbstract $model */ + $model = Mage::getModel($modelClass); + return $model; } return false; } @@ -165,7 +167,7 @@ protected function _getValidationStateModel($cardType) * Return validation state model * * @param string $cardType - * @return Mage_Centinel_Model_StateAbstract + * @return Mage_Centinel_Model_StateAbstract|false */ protected function _getValidationState($cardType = null) { @@ -378,7 +380,7 @@ public function isAuthenticateSuccessful() * Export cmpi lookups and authentication information stored in session into array * * @param mixed $to - * @param array $map + * @param array|false $map * @return mixed $to */ public function exportCmpiData($to, $map = false) diff --git a/app/code/core/Mage/Centinel/Model/State/Jcb.php b/app/code/core/Mage/Centinel/Model/State/Jcb.php index 5d0fbb0a17fb..6b1baef17947 100644 --- a/app/code/core/Mage/Centinel/Model/State/Jcb.php +++ b/app/code/core/Mage/Centinel/Model/State/Jcb.php @@ -72,13 +72,15 @@ public function isAuthenticateSuccessful() //Test case 3 if ($paResStatus == 'N' && $signatureVerification == 'Y' && $eciFlag == '07' && - $xid != '' && $cavv == '' && $errorNo == '0') { + $xid != '' && $cavv == '' && $errorNo == '0' + ) { return false; } //Test case 4 if ($paResStatus == 'U' && $signatureVerification == 'Y' && $eciFlag == '07' && - $xid != '' && $cavv == '' && $errorNo == '0') { + $xid != '' && $cavv == '' && $errorNo == '0' + ) { if ($this->getIsModeStrict()) { return false; } else { @@ -88,7 +90,8 @@ public function isAuthenticateSuccessful() //Test case 5 if ($paResStatus == 'U' && $signatureVerification == 'Y' && $eciFlag == '07' && - $xid != '' && $cavv == '' && $errorNo == '0') { + $xid != '' && $cavv == '' && $errorNo == '0' + ) { if ($this->getIsModeStrict()) { return false; } else { @@ -98,13 +101,15 @@ public function isAuthenticateSuccessful() //Test case 10 if ($paResStatus == '' && $signatureVerification == '' && $eciFlag == '07' && - $xid == '' && $cavv == '' && $errorNo != '0') { + $xid == '' && $cavv == '' && $errorNo != '0' + ) { return false; } //Test case 11 if ($paResStatus == 'A' && $signatureVerification == 'Y' && $eciFlag == '06' && - $xid != '' && $cavv != '' && $errorNo == '0') { + $xid != '' && $cavv != '' && $errorNo == '0' + ) { return true; } } @@ -123,7 +128,8 @@ protected function _isLookupStrictSuccessful() if ($this->getLookupEnrolled() == 'Y' && $this->getLookupAcsUrl() != '' && $this->getLookupPayload() != '' && - $this->getLookupErrorNo() == '0') { + $this->getLookupErrorNo() == '0' + ) { return true; } return false; diff --git a/app/code/core/Mage/Centinel/Model/State/Mastercard.php b/app/code/core/Mage/Centinel/Model/State/Mastercard.php index b53d77225bba..3bf3990ab44d 100644 --- a/app/code/core/Mage/Centinel/Model/State/Mastercard.php +++ b/app/code/core/Mage/Centinel/Model/State/Mastercard.php @@ -67,13 +67,15 @@ public function isAuthenticateSuccessful() //Test case 3 if ($paResStatus == 'N' && $signatureVerification == 'Y' && $eciFlag == '01' && - $xid != '' && $cavv == '' && $errorNo == '0') { + $xid != '' && $cavv == '' && $errorNo == '0' + ) { return false; } //Test case 4 if ($paResStatus == 'U' && $signatureVerification == 'Y' && $eciFlag == '01' && - $xid != '' && $cavv == '' && $errorNo == '0') { + $xid != '' && $cavv == '' && $errorNo == '0' + ) { if ($this->getIsModeStrict()) { return false; } else { @@ -92,10 +94,12 @@ public function isAuthenticateSuccessful() //Test cases 5-9 if (!$this->getIsModeStrict() && $this->_isLookupSoftSuccessful()) { if ($paResStatus == '' && $signatureVerification == '' && $eciFlag == '' && - $xid == '' && $cavv == '' && $errorNo == '0') { + $xid == '' && $cavv == '' && $errorNo == '0' + ) { return true; } elseif ($paResStatus == false && $signatureVerification == false && $eciFlag == false && - $xid == false && $cavv == false && $errorNo == false) { + $xid == false && $cavv == false && $errorNo == false + ) { return true; } } @@ -114,7 +118,8 @@ protected function _isLookupStrictSuccessful() if ($this->getLookupEnrolled() == 'Y' && $this->getLookupAcsUrl() != '' && $this->getLookupPayload() != '' && - $this->getLookupErrorNo() == '0') { + $this->getLookupErrorNo() == '0' + ) { return true; } return false; diff --git a/app/code/core/Mage/Centinel/Model/State/Visa.php b/app/code/core/Mage/Centinel/Model/State/Visa.php index 73d7d13e6fdb..43ccddc60115 100644 --- a/app/code/core/Mage/Centinel/Model/State/Visa.php +++ b/app/code/core/Mage/Centinel/Model/State/Visa.php @@ -67,13 +67,15 @@ public function isAuthenticateSuccessful() //Test case 3 if ($paResStatus == 'N' && $signatureVerification == 'Y' && $eciFlag == '07' && - $xid != '' && $cavv == '' && $errorNo == '0') { + $xid != '' && $cavv == '' && $errorNo == '0' + ) { return false; } //Test case 4 if ($paResStatus == 'A' && $signatureVerification == 'Y' && $eciFlag == '06' && - $xid != '' && $cavv != '' && $errorNo == '0') { + $xid != '' && $cavv != '' && $errorNo == '0' + ) { if ($this->getIsModeStrict()) { return false; } else { @@ -83,7 +85,8 @@ public function isAuthenticateSuccessful() //Test case 5 if ($paResStatus == 'U' && $signatureVerification == 'Y' && $eciFlag == '07' && - $xid != '' && $cavv == '' && $errorNo == '0') { + $xid != '' && $cavv == '' && $errorNo == '0' + ) { if ($this->getIsModeStrict()) { return false; } else { @@ -93,7 +96,8 @@ public function isAuthenticateSuccessful() //Test case 11 if ($paResStatus == 'U' && $signatureVerification == '' && $eciFlag == '07' && - $xid == '' && $cavv == '' && $errorNo == '1050') { + $xid == '' && $cavv == '' && $errorNo == '1050' + ) { if ($this->getIsModeStrict()) { return false; } else { @@ -105,10 +109,12 @@ public function isAuthenticateSuccessful() //Test cases 6-10 if (!$this->getIsModeStrict() && $this->_isLookupSoftSuccessful()) { if ($paResStatus == '' && $signatureVerification == '' && $eciFlag == '' && - $xid == '' && $cavv == '' && $errorNo == '0') { + $xid == '' && $cavv == '' && $errorNo == '0' + ) { return true; } elseif ($paResStatus == false && $signatureVerification == false && $eciFlag == false && - $xid == false && $cavv == false && $errorNo == false) { + $xid == false && $cavv == false && $errorNo == false + ) { return true; } } @@ -127,7 +133,8 @@ protected function _isLookupStrictSuccessful() if ($this->getLookupEnrolled() == 'Y' && $this->getLookupAcsUrl() != '' && $this->getLookupPayload() != '' && - $this->getLookupErrorNo() == '0') { + $this->getLookupErrorNo() == '0' + ) { return true; } return false; diff --git a/app/code/core/Mage/Centinel/Model/StateAbstract.php b/app/code/core/Mage/Centinel/Model/StateAbstract.php index 183ccd4c4928..5295bc6e320b 100644 --- a/app/code/core/Mage/Centinel/Model/StateAbstract.php +++ b/app/code/core/Mage/Centinel/Model/StateAbstract.php @@ -30,7 +30,7 @@ abstract class Mage_Centinel_Model_StateAbstract extends Varien_Object /** * Storage data model * - * @var Varien_Object + * @var Varien_Object|false */ private $_dataStorage = false; diff --git a/app/code/core/Mage/Centinel/controllers/IndexController.php b/app/code/core/Mage/Centinel/controllers/IndexController.php index bdc9ac634987..5db9f3f38a57 100644 --- a/app/code/core/Mage/Centinel/controllers/IndexController.php +++ b/app/code/core/Mage/Centinel/controllers/IndexController.php @@ -75,7 +75,7 @@ private function _getPayment() /** * Return Centinel validation model * - * @return Mage_Centinel_Model_Service + * @return Mage_Centinel_Model_Service|false */ private function _getValidator() { diff --git a/app/code/core/Mage/Checkout/Block/Cart.php b/app/code/core/Mage/Checkout/Block/Cart.php index 4c59959115bf..f7ce73afeb04 100644 --- a/app/code/core/Mage/Checkout/Block/Cart.php +++ b/app/code/core/Mage/Checkout/Block/Cart.php @@ -51,7 +51,8 @@ public function prepareItemUrls() if ($item->getStoreId() != Mage::app()->getStore()->getId() && !$item->getRedirectUrl() - && !$product->isVisibleInSiteVisibility()) { + && !$product->isVisibleInSiteVisibility() + ) { $products[$product->getId()] = $item->getStoreId(); } } diff --git a/app/code/core/Mage/Checkout/Block/Cart/Item/Renderer/Configurable.php b/app/code/core/Mage/Checkout/Block/Cart/Item/Renderer/Configurable.php index 46e0896f1842..4d526e8e620b 100644 --- a/app/code/core/Mage/Checkout/Block/Cart/Item/Renderer/Configurable.php +++ b/app/code/core/Mage/Checkout/Block/Cart/Item/Renderer/Configurable.php @@ -67,7 +67,8 @@ public function getProductThumbnail() $product = $this->getChildProduct(); if (!$product || !$product->getData('thumbnail') || ($product->getData('thumbnail') === 'no_selection') - || (Mage::getStoreConfig(self::CONFIGURABLE_PRODUCT_IMAGE) === self::USE_PARENT_IMAGE)) { + || (Mage::getStoreConfig(self::CONFIGURABLE_PRODUCT_IMAGE) === self::USE_PARENT_IMAGE) + ) { $product = $this->getProduct(); } diff --git a/app/code/core/Mage/Checkout/Block/Cart/Item/Renderer/Grouped.php b/app/code/core/Mage/Checkout/Block/Cart/Item/Renderer/Grouped.php index b04502f3396f..7fd30892f982 100644 --- a/app/code/core/Mage/Checkout/Block/Cart/Item/Renderer/Grouped.php +++ b/app/code/core/Mage/Checkout/Block/Cart/Item/Renderer/Grouped.php @@ -57,7 +57,8 @@ public function getProductThumbnail() $product = $this->getProduct(); if (!$product->getData('thumbnail') || ($product->getData('thumbnail') === 'no_selection') - || (Mage::getStoreConfig(self::GROUPED_PRODUCT_IMAGE) === self::USE_PARENT_IMAGE)) { + || (Mage::getStoreConfig(self::GROUPED_PRODUCT_IMAGE) === self::USE_PARENT_IMAGE) + ) { $product = $this->getGroupedProduct(); } diff --git a/app/code/core/Mage/Checkout/Block/Onepage/Billing.php b/app/code/core/Mage/Checkout/Block/Onepage/Billing.php index a829fdb4d9f5..1791fe91c74c 100644 --- a/app/code/core/Mage/Checkout/Block/Onepage/Billing.php +++ b/app/code/core/Mage/Checkout/Block/Onepage/Billing.php @@ -65,7 +65,8 @@ protected function _construct() public function isUseBillingAddressForShipping() { if (($this->getQuote()->getIsVirtual()) - || !$this->getQuote()->getShippingAddress()->getSameAsBilling()) { + || !$this->getQuote()->getShippingAddress()->getSameAsBilling() + ) { return false; } return true; diff --git a/app/code/core/Mage/Checkout/Model/Api/Resource.php b/app/code/core/Mage/Checkout/Model/Api/Resource.php index 9eab710d6b7b..4ccc09e3400b 100644 --- a/app/code/core/Mage/Checkout/Model/Api/Resource.php +++ b/app/code/core/Mage/Checkout/Model/Api/Resource.php @@ -212,7 +212,8 @@ protected function _getAttributes($object, $type, array $attributes = null) protected function _isAllowedAttribute($attributeCode, $type, array $attributes = null) { if (!empty($attributes) - && !(in_array($attributeCode, $attributes))) { + && !(in_array($attributeCode, $attributes)) + ) { return false; } @@ -221,7 +222,8 @@ protected function _isAllowedAttribute($attributeCode, $type, array $attributes } if (isset($this->_ignoredAttributeCodes[$type]) - && in_array($attributeCode, $this->_ignoredAttributeCodes[$type])) { + && in_array($attributeCode, $this->_ignoredAttributeCodes[$type]) + ) { return false; } diff --git a/app/code/core/Mage/Checkout/Model/Api/Resource/Customer.php b/app/code/core/Mage/Checkout/Model/Api/Resource/Customer.php index b6a92fb4eeb8..9ffa4032a623 100644 --- a/app/code/core/Mage/Checkout/Model/Api/Resource/Customer.php +++ b/app/code/core/Mage/Checkout/Model/Api/Resource/Customer.php @@ -170,7 +170,8 @@ protected function _prepareCustomerQuote(Mage_Sales_Model_Quote $quote) $billing->setCustomerAddress($customerBilling); } if ($shipping && ((!$shipping->getCustomerId() && !$shipping->getSameAsBilling()) - || (!$shipping->getSameAsBilling() && $shipping->getSaveInAddressBook()))) { + || (!$shipping->getSameAsBilling() && $shipping->getSaveInAddressBook())) + ) { $customerShipping = $shipping->exportCustomerAddress(); $customer->addAddress($customerShipping); $shipping->setCustomerAddress($customerShipping); diff --git a/app/code/core/Mage/Checkout/Model/Cart/Api.php b/app/code/core/Mage/Checkout/Model/Cart/Api.php index cb06812276f6..554468de61c0 100644 --- a/app/code/core/Mage/Checkout/Model/Cart/Api.php +++ b/app/code/core/Mage/Checkout/Model/Cart/Api.php @@ -141,7 +141,8 @@ public function createOrder($quoteId, $store = null, $agreements = null) $this->_fault('invalid_checkout_type'); } if ($quote->getCheckoutMethod() == Mage_Checkout_Model_Api_Resource_Customer::MODE_GUEST - && !Mage::helper('checkout')->isAllowedGuestCheckout($quote, $quote->getStoreId())) { + && !Mage::helper('checkout')->isAllowedGuestCheckout($quote, $quote->getStoreId()) + ) { $this->_fault('guest_checkout_is_not_enabled'); } diff --git a/app/code/core/Mage/Checkout/Model/Cart/Product/Api/V2.php b/app/code/core/Mage/Checkout/Model/Cart/Product/Api/V2.php index 866a6edb27d9..cfb14a7e12cc 100644 --- a/app/code/core/Mage/Checkout/Model/Cart/Product/Api/V2.php +++ b/app/code/core/Mage/Checkout/Model/Cart/Product/Api/V2.php @@ -43,7 +43,8 @@ protected function _prepareProductsData($data) if (is_array($value)) { foreach ($value as $v) { if (is_object($v) && count(get_object_vars($v)) == 2 - && isset($v->key) && isset($v->value)) { + && isset($v->key) && isset($v->value) + ) { $assocArr[$v->key] = $v->value; } } diff --git a/app/code/core/Mage/Checkout/Model/Type/Onepage.php b/app/code/core/Mage/Checkout/Model/Type/Onepage.php index 28b16a494d48..99ff55b66db1 100644 --- a/app/code/core/Mage/Checkout/Model/Type/Onepage.php +++ b/app/code/core/Mage/Checkout/Model/Type/Onepage.php @@ -499,7 +499,8 @@ protected function _processValidateCustomer(Mage_Sales_Model_Quote_Address $addr 'confirmation' => 'confirm_password', 'taxvat' => 'taxvat', 'gender' => 'gender', - ] as $key => $dataKey) { + ] as $key => $dataKey + ) { $customer->setData($key, $address->getData($dataKey)); } if ($dob) { @@ -748,7 +749,8 @@ protected function _prepareCustomerQuote() $billing->setCustomerAddress($customerBilling); } if ($shipping && !$shipping->getSameAsBilling() && - (!$shipping->getCustomerId() || $shipping->getSaveInAddressBook())) { + (!$shipping->getCustomerId() || $shipping->getSaveInAddressBook()) + ) { $customerShipping = $shipping->exportCustomerAddress(); $customer->addAddress($customerShipping); $shipping->setCustomerAddress($customerShipping); diff --git a/app/code/core/Mage/Cms/Block/Page.php b/app/code/core/Mage/Cms/Block/Page.php index 8ef56d0f71dd..46b2613f47d5 100644 --- a/app/code/core/Mage/Cms/Block/Page.php +++ b/app/code/core/Mage/Cms/Block/Page.php @@ -66,7 +66,8 @@ protected function _prepareLayout() if (Mage::getStoreConfig('web/default/show_cms_breadcrumbs') && ($breadcrumbs = $this->getLayout()->getBlock('breadcrumbs')) && ($page->getIdentifier() !== Mage::getStoreConfig('web/default/cms_home_page')) - && ($page->getIdentifier() !== Mage::getStoreConfig('web/default/cms_no_route'))) { + && ($page->getIdentifier() !== Mage::getStoreConfig('web/default/cms_no_route')) + ) { $breadcrumbsArray[] = [ 'crumbName' => 'home', 'crumbInfo' => [ diff --git a/app/code/core/Mage/Cms/Model/Wysiwyg/Images/Storage.php b/app/code/core/Mage/Cms/Model/Wysiwyg/Images/Storage.php index 1287a87fda16..6ab62676194c 100644 --- a/app/code/core/Mage/Cms/Model/Wysiwyg/Images/Storage.php +++ b/app/code/core/Mage/Cms/Model/Wysiwyg/Images/Storage.php @@ -85,7 +85,8 @@ public function getDirsCollection($path) $rootChildParts = explode(DIRECTORY_SEPARATOR, substr($value->getFilename(), $storageRootLength)); if (array_key_exists(end($rootChildParts), $conditions['plain']) - || ($regExp && preg_match($regExp, $value->getFilename()))) { + || ($regExp && preg_match($regExp, $value->getFilename())) + ) { $collection->removeItemByKey($key); } } diff --git a/app/code/core/Mage/ConfigurableSwatches/Helper/Mediafallback.php b/app/code/core/Mage/ConfigurableSwatches/Helper/Mediafallback.php index 96c468de5bb4..f7aad885c079 100644 --- a/app/code/core/Mage/ConfigurableSwatches/Helper/Mediafallback.php +++ b/app/code/core/Mage/ConfigurableSwatches/Helper/Mediafallback.php @@ -109,7 +109,8 @@ public function attachProductChildrenAttributeMapping(array $parentProducts, $st // product has no value for attribute or not available, we can't process it $isInStock = $childProduct->getStockItem()->getIsInStock(); if (!$childProduct->hasData($attribute->getAttributeCode()) - || (!$isInStock && !Mage::helper('cataloginventory')->isShowOutOfStock())) { + || (!$isInStock && !Mage::helper('cataloginventory')->isShowOutOfStock()) + ) { continue; } $optionId = $childProduct->getData($attribute->getAttributeCode()); diff --git a/app/code/core/Mage/ConfigurableSwatches/Model/Observer.php b/app/code/core/Mage/ConfigurableSwatches/Model/Observer.php index 34b6a3c36fc1..0fd3c738802a 100644 --- a/app/code/core/Mage/ConfigurableSwatches/Model/Observer.php +++ b/app/code/core/Mage/ConfigurableSwatches/Model/Observer.php @@ -48,7 +48,8 @@ public function productListCollectionLoadAfter(Varien_Event_Observer $observer) $collection = $observer->getCollection(); if ($collection - instanceof Mage_ConfigurableSwatches_Model_Resource_Catalog_Product_Type_Configurable_Product_Collection) { + instanceof Mage_ConfigurableSwatches_Model_Resource_Catalog_Product_Type_Configurable_Product_Collection + ) { // avoid recursion return; } @@ -155,7 +156,8 @@ public function convertLayerBlock(Varien_Event_Observer $observer) // Perform this operation if we're on a category view page or search results page if (($front == 'catalog' && $controller == 'category' && $action == 'view') - || ($front == 'catalogsearch' && $controller == 'result' && $action == 'index')) { + || ($front == 'catalogsearch' && $controller == 'result' && $action == 'index') + ) { // Block name for layered navigation differs depending on which Magento edition we're in $blockName = 'catalog.leftnav'; if (Mage::getEdition() == Mage::EDITION_ENTERPRISE) { diff --git a/app/code/core/Mage/Core/Block/Profiler.php b/app/code/core/Mage/Core/Block/Profiler.php index 874bcfb4931b..a299b70324e6 100644 --- a/app/code/core/Mage/Core/Block/Profiler.php +++ b/app/code/core/Mage/Core/Block/Profiler.php @@ -33,7 +33,8 @@ protected function _toHtml() { if (!$this->_beforeToHtml() || !Mage::getStoreConfig('dev/debug/profiler') - || !Mage::helper('core')->isDevAllowed()) { + || !Mage::helper('core')->isDevAllowed() + ) { return ''; } diff --git a/app/code/core/Mage/Core/Controller/Varien/Action.php b/app/code/core/Mage/Core/Controller/Varien/Action.php index e3c17927b826..e550d34e0420 100644 --- a/app/code/core/Mage/Core/Controller/Varien/Action.php +++ b/app/code/core/Mage/Core/Controller/Varien/Action.php @@ -574,7 +574,8 @@ public function norouteAction($coreRoute = null) Mage::dispatchEvent('controller_action_noroute', ['action' => $this, 'status' => $status]); if ($status->getLoaded() !== true || $status->getForwarded() === true - || !is_null($coreRoute)) { + || !is_null($coreRoute) + ) { $this->loadLayout(['default', 'noRoute']); $this->renderLayout(); } else { @@ -909,7 +910,8 @@ protected function _rewrite() protected function _validateFormKey() { if (!($formKey = $this->getRequest()->getParam('form_key', null)) - || $formKey != Mage::getSingleton('core/session')->getFormKey()) { + || $formKey != Mage::getSingleton('core/session')->getFormKey() + ) { return false; } return true; diff --git a/app/code/core/Mage/Core/Controller/Varien/Router/Standard.php b/app/code/core/Mage/Core/Controller/Varien/Router/Standard.php index 96f90f7d993d..f69eb8a4736c 100644 --- a/app/code/core/Mage/Core/Controller/Varien/Router/Standard.php +++ b/app/code/core/Mage/Core/Controller/Varien/Router/Standard.php @@ -389,7 +389,8 @@ public function getModuleByName($moduleName, $modules) { foreach ($modules as $module) { if ($moduleName === $module || (is_array($module) - && $this->getModuleByName($moduleName, $module))) { + && $this->getModuleByName($moduleName, $module)) + ) { return true; } } diff --git a/app/code/core/Mage/Core/Helper/Data.php b/app/code/core/Mage/Core/Helper/Data.php index b3e6fa998f9a..80704388b361 100644 --- a/app/code/core/Mage/Core/Helper/Data.php +++ b/app/code/core/Mage/Core/Helper/Data.php @@ -401,7 +401,8 @@ public function isDevAllowed($storeId = null) if (!empty($allowedIps) && !empty($remoteAddr)) { $allowedIps = preg_split('#\s*,\s*#', $allowedIps, -1, PREG_SPLIT_NO_EMPTY); if (array_search($remoteAddr, $allowedIps) === false - && array_search(Mage::helper('core/http')->getHttpHost(), $allowedIps) === false) { + && array_search(Mage::helper('core/http')->getHttpHost(), $allowedIps) === false + ) { $allow = false; } } @@ -458,7 +459,8 @@ public function getCacheBetaTypes() public function copyFieldset($fieldset, $aspect, $source, $target, $root = 'global') { if (!(is_array($source) || $source instanceof Varien_Object) - || !(is_array($target) || $target instanceof Varien_Object)) { + || !(is_array($target) || $target instanceof Varien_Object) + ) { return false; } $fields = Mage::getConfig()->getFieldset($fieldset, $root); diff --git a/app/code/core/Mage/Core/Helper/Security.php b/app/code/core/Mage/Core/Helper/Security.php index f3ff5edaf324..76040c39cbb1 100644 --- a/app/code/core/Mage/Core/Helper/Security.php +++ b/app/code/core/Mage/Core/Helper/Security.php @@ -47,7 +47,8 @@ public function validateAgainstBlockMethodBlacklist(Mage_Core_Block_Abstract $bl $calledMethod = strtolower($method); if (($block instanceof $action['block'] && strtolower($action['method']) === $calledMethod) || ($block instanceof $action['block'] - && strtolower($action['block'] . '::' . $action['method']) === $calledMethod)) { + && strtolower($action['block'] . '::' . $action['method']) === $calledMethod) + ) { Mage::throwException( sprintf('Action with combination block %s and method %s is forbidden.', get_class($block), $method) ); diff --git a/app/code/core/Mage/Core/Model/App.php b/app/code/core/Mage/Core/Model/App.php index 4ae3a039af5a..bd0a8b91c335 100644 --- a/app/code/core/Mage/Core/Model/App.php +++ b/app/code/core/Mage/Core/Model/App.php @@ -589,13 +589,16 @@ protected function _checkCookieStore($type) $store = $this->getCookie()->get(Mage_Core_Model_Store::COOKIE_NAME); if ($store && isset($this->_stores[$store]) && $this->_stores[$store]->getId() - && $this->_stores[$store]->getIsActive()) { + && $this->_stores[$store]->getIsActive() + ) { if ($type == 'website' - && $this->_stores[$store]->getWebsiteId() == $this->_stores[$this->_currentStore]->getWebsiteId()) { + && $this->_stores[$store]->getWebsiteId() == $this->_stores[$this->_currentStore]->getWebsiteId() + ) { $this->_currentStore = $store; } if ($type == 'group' - && $this->_stores[$store]->getGroupId() == $this->_stores[$this->_currentStore]->getGroupId()) { + && $this->_stores[$store]->getGroupId() == $this->_stores[$this->_currentStore]->getGroupId() + ) { $this->_currentStore = $store; } if ($type == 'store') { diff --git a/app/code/core/Mage/Core/Model/Locale.php b/app/code/core/Mage/Core/Model/Locale.php index 7aabc24a8b67..5fc904baed98 100644 --- a/app/code/core/Mage/Core/Model/Locale.php +++ b/app/code/core/Mage/Core/Model/Locale.php @@ -321,7 +321,7 @@ public function getOptionWeekdays($preserveCodes = false, $ucFirstCode = false) { $options = []; $days = $this->getTranslationList('days'); - $days = $preserveCodes ? $days['format']['wide'] : array_values($days['format']['wide']); + $days = $preserveCodes ? $days['format']['wide'] : array_values($days['format']['wide']); foreach ($days as $code => $name) { $options[] = [ 'label' => $name, diff --git a/app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php b/app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php index 81c7ded43bf9..397aa6123d65 100644 --- a/app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php +++ b/app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php @@ -239,7 +239,8 @@ protected function _initSelectFields() if (($alias !== null && in_array($alias, $columnsToSelect)) || // If field already joined from another table - ($alias === null && isset($alias, $columnsToSelect))) { + ($alias === null && isset($alias, $columnsToSelect)) + ) { continue; } diff --git a/app/code/core/Mage/Core/Model/Resource/Resource.php b/app/code/core/Mage/Core/Model/Resource/Resource.php index 8c02925fabd1..0edafb78697e 100644 --- a/app/code/core/Mage/Core/Model/Resource/Resource.php +++ b/app/code/core/Mage/Core/Model/Resource/Resource.php @@ -60,7 +60,8 @@ protected function _construct() protected function _loadVersionData($needType) { if ((($needType == 'db') && is_null(self::$_versions)) - || (($needType == 'data') && is_null(self::$_dataVersions))) { + || (($needType == 'data') && is_null(self::$_dataVersions)) + ) { self::$_versions = []; // Db version column always exists self::$_dataVersions = null; // Data version array will be filled only if Data column exist diff --git a/app/code/core/Mage/Core/Model/Resource/Session.php b/app/code/core/Mage/Core/Model/Resource/Session.php index 24b69a95a60b..bdd1bc0d0ba7 100644 --- a/app/code/core/Mage/Core/Model/Resource/Session.php +++ b/app/code/core/Mage/Core/Model/Resource/Session.php @@ -265,7 +265,8 @@ public function gc($sessMaxLifeTime) { if ($this->_automaticCleaningFactor > 0) { if ($this->_automaticCleaningFactor == 1 || - rand(1, $this->_automaticCleaningFactor) == 1) { + rand(1, $this->_automaticCleaningFactor) == 1 + ) { $where = ['session_expires < ?' => Varien_Date::toTimestamp(true)]; $this->_write->delete($this->_sessionTable, $where); } diff --git a/app/code/core/Mage/Core/Model/Resource/Setup.php b/app/code/core/Mage/Core/Model/Resource/Setup.php index 2b04f0426a4f..fe6df25038f0 100644 --- a/app/code/core/Mage/Core/Model/Resource/Setup.php +++ b/app/code/core/Mage/Core/Model/Resource/Setup.php @@ -681,7 +681,8 @@ protected function _getModifySqlFiles($actionType, $fromVersion, $toVersion, $ar $infoFrom = $versionInfo[0]; $infoTo = $versionInfo[1]; if (version_compare($infoFrom, $fromVersion) !== self::VERSION_COMPARE_LOWER - && version_compare($infoTo, $toVersion) !== self::VERSION_COMPARE_GREATER) { + && version_compare($infoTo, $toVersion) !== self::VERSION_COMPARE_GREATER + ) { $arrRes[] = [ 'toVersion' => $infoTo, 'fileName' => $file diff --git a/app/code/core/Mage/Core/Model/Session/Abstract/Varien.php b/app/code/core/Mage/Core/Model/Session/Abstract/Varien.php index 6790e109d79f..1fc13535d29a 100644 --- a/app/code/core/Mage/Core/Model/Session/Abstract/Varien.php +++ b/app/code/core/Mage/Core/Model/Session/Abstract/Varien.php @@ -487,16 +487,19 @@ protected function _validate() self::$isValidated = true; // Only validate once since the validator data is the same for every namespace if ($this->useValidateRemoteAddr() - && $sessionData[self::VALIDATOR_REMOTE_ADDR_KEY] != $validatorData[self::VALIDATOR_REMOTE_ADDR_KEY]) { + && $sessionData[self::VALIDATOR_REMOTE_ADDR_KEY] != $validatorData[self::VALIDATOR_REMOTE_ADDR_KEY] + ) { return false; } if ($this->useValidateHttpVia() - && $sessionData[self::VALIDATOR_HTTP_VIA_KEY] != $validatorData[self::VALIDATOR_HTTP_VIA_KEY]) { + && $sessionData[self::VALIDATOR_HTTP_VIA_KEY] != $validatorData[self::VALIDATOR_HTTP_VIA_KEY] + ) { return false; } if ($this->useValidateHttpXForwardedFor() - && $sessionData[self::VALIDATOR_HTTP_X_FORVARDED_FOR_KEY] != $validatorData[self::VALIDATOR_HTTP_X_FORVARDED_FOR_KEY]) { + && $sessionData[self::VALIDATOR_HTTP_X_FORVARDED_FOR_KEY] != $validatorData[self::VALIDATOR_HTTP_X_FORVARDED_FOR_KEY] + ) { return false; } if ($this->useValidateHttpUserAgent() diff --git a/app/code/core/Mage/Core/Model/Translate.php b/app/code/core/Mage/Core/Model/Translate.php index 8490810e4f00..6029fb24c703 100644 --- a/app/code/core/Mage/Core/Model/Translate.php +++ b/app/code/core/Mage/Core/Model/Translate.php @@ -398,7 +398,8 @@ public function translate($args) if (is_string($text) && $text == '' || is_null($text) || is_bool($text) && $text === false - || is_object($text) && $text->getText() == '') { + || is_object($text) && $text->getText() == '' + ) { return ''; } if ($text instanceof Mage_Core_Model_Translate_Expr) { diff --git a/app/code/core/Mage/Core/Model/Url.php b/app/code/core/Mage/Core/Model/Url.php index ebe7241b6df9..db9bd7ed6c4e 100644 --- a/app/code/core/Mage/Core/Model/Url.php +++ b/app/code/core/Mage/Core/Model/Url.php @@ -398,7 +398,8 @@ public function getBaseUrl($params = []) * Add availability support urls without store code */ if ($this->getType() == Mage_Core_Model_Store::URL_TYPE_LINK - && Mage::app()->getRequest()->isDirectAccessFrontendName($this->getRouteFrontName())) { + && Mage::app()->getRequest()->isDirectAccessFrontendName($this->getRouteFrontName()) + ) { $this->setType(Mage_Core_Model_Store::URL_TYPE_DIRECT_LINK); } diff --git a/app/code/core/Mage/Customer/Model/Address/Abstract.php b/app/code/core/Mage/Customer/Model/Address/Abstract.php index f13bc3b3095c..55417a23c59a 100644 --- a/app/code/core/Mage/Customer/Model/Address/Abstract.php +++ b/app/code/core/Mage/Customer/Model/Address/Abstract.php @@ -392,7 +392,8 @@ public function getFormated($html = false) public function format($type) { if (!($formatType = $this->getConfig()->getFormatByCode($type)) - || !$formatType->getRenderer()) { + || !$formatType->getRenderer() + ) { return null; } Mage::dispatchEvent('customer_address_format', ['type' => $formatType, 'address' => $this]); diff --git a/app/code/core/Mage/Customer/Model/Api/Resource.php b/app/code/core/Mage/Customer/Model/Api/Resource.php index a85712d086b6..42bfe88862ca 100644 --- a/app/code/core/Mage/Customer/Model/Api/Resource.php +++ b/app/code/core/Mage/Customer/Model/Api/Resource.php @@ -53,7 +53,8 @@ protected function _isAllowedAttribute($attribute, array $filter = null) { if (!is_null($filter) && !(in_array($attribute->getAttributeCode(), $filter) - || in_array($attribute->getAttributeId(), $filter))) { + || in_array($attribute->getAttributeId(), $filter)) + ) { return false; } diff --git a/app/code/core/Mage/Customer/Model/Api2/Customer/Address/Rest.php b/app/code/core/Mage/Customer/Model/Api2/Customer/Address/Rest.php index 39180e937c6d..ea3f4b5ee7c5 100644 --- a/app/code/core/Mage/Customer/Model/Api2/Customer/Address/Rest.php +++ b/app/code/core/Mage/Customer/Model/Api2/Customer/Address/Rest.php @@ -142,7 +142,8 @@ protected function _update(array $data) $data = $validator->filter($data); if (!$validator->isValidData($data, true) - || !$validator->isValidDataForChangeAssociationWithCountry($address, $data)) { + || !$validator->isValidDataForChangeAssociationWithCountry($address, $data) + ) { foreach ($validator->getErrors() as $error) { $this->_error($error, Mage_Api2_Model_Server::HTTP_BAD_REQUEST); } diff --git a/app/code/core/Mage/Customer/Model/Convert/Adapter/Customer.php b/app/code/core/Mage/Customer/Model/Convert/Adapter/Customer.php index cd3b3bfe609b..f96a641a046a 100644 --- a/app/code/core/Mage/Customer/Model/Convert/Adapter/Customer.php +++ b/app/code/core/Mage/Customer/Model/Convert/Adapter/Customer.php @@ -609,7 +609,8 @@ public function saveRow($importData) if (isset($importData[$field])) { $billingAddress->setDataUsingMethod($cleanField, $importData[$field]); } elseif (isset($this->_billingMappedFields[$field]) - && isset($importData[$this->_billingMappedFields[$field]])) { + && isset($importData[$this->_billingMappedFields[$field]]) + ) { $billingAddress->setDataUsingMethod($cleanField, $importData[$this->_billingMappedFields[$field]]); } } @@ -662,7 +663,8 @@ public function saveRow($importData) if (isset($importData[$field])) { $shippingAddress->setDataUsingMethod($cleanField, $importData[$field]); } elseif (isset($this->_shippingMappedFields[$field]) - && isset($importData[$this->_shippingMappedFields[$field]])) { + && isset($importData[$this->_shippingMappedFields[$field]]) + ) { $shippingAddress->setDataUsingMethod($cleanField, $importData[$this->_shippingMappedFields[$field]]); } } diff --git a/app/code/core/Mage/Customer/Model/Customer.php b/app/code/core/Mage/Customer/Model/Customer.php index 8db719936dd3..2909d3988228 100644 --- a/app/code/core/Mage/Customer/Model/Customer.php +++ b/app/code/core/Mage/Customer/Model/Customer.php @@ -1363,7 +1363,8 @@ public function validateAddress(array $data, $type = 'billing') return false; } if ($field == 'country' - && in_array(strtolower($data[$prefix . $field]), ['US', 'CA'])) { + && in_array(strtolower($data[$prefix . $field]), ['US', 'CA']) + ) { if (!isset($data[$prefix . 'region'])) { return false; } diff --git a/app/code/core/Mage/Customer/Model/Observer.php b/app/code/core/Mage/Customer/Model/Observer.php index 9178f07496d5..4cbd6e440465 100644 --- a/app/code/core/Mage/Customer/Model/Observer.php +++ b/app/code/core/Mage/Customer/Model/Observer.php @@ -153,7 +153,8 @@ public function afterAddressSave($observer) $customerHelper = Mage::helper('customer'); if ($customerAddress->getVatId() == '' - || !Mage::helper('core')->isCountryInEU($customerAddress->getCountry())) { + || !Mage::helper('core')->isCountryInEU($customerAddress->getCountry()) + ) { $defaultGroupId = $customerHelper->getDefaultCustomerGroupId($customer->getStore()); if (!$customer->getDisableAutoGroupChange() && $customer->getGroupId() != $defaultGroupId) { diff --git a/app/code/core/Mage/Customer/controllers/AccountController.php b/app/code/core/Mage/Customer/controllers/AccountController.php index 90b10601f305..504d7fce142a 100644 --- a/app/code/core/Mage/Customer/controllers/AccountController.php +++ b/app/code/core/Mage/Customer/controllers/AccountController.php @@ -19,6 +19,8 @@ * @license https://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0) */ +use Mage_Customer_Helper_Data as Helper; + /** * Customer account controller * @@ -158,7 +160,7 @@ public function loginPostAction() } catch (Mage_Core_Exception $e) { switch ($e->getCode()) { case Mage_Customer_Model_Customer::EXCEPTION_EMAIL_NOT_CONFIRMED: - /** @var Mage_Customer_Helper_Data $helper */ + /** @var Helper $helper */ $helper = $this->_getHelper('customer'); $value = $helper->getEmailConfirmationUrl($login['username']); $message = $helper->__('This account is not confirmed. Click here to resend confirmation email.', $value); @@ -187,7 +189,7 @@ public function loginPostAction() */ protected function _loginPostRedirect() { - /** @var Mage_Customer_Helper_Data $helper */ + /** @var Helper $helper */ $helper = $this->_getHelper('customer'); $session = $this->_getSession(); @@ -197,10 +199,8 @@ protected function _loginPostRedirect() $session->setBeforeAuthUrl($helper->getAccountUrl()); // Redirect customer to the last page visited after logging in if ($session->isLoggedIn()) { - if (!Mage::getStoreConfigFlag( - Mage_Customer_Helper_Data::XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD - )) { - $referer = $this->getRequest()->getParam(Mage_Customer_Helper_Data::REFERER_QUERY_PARAM_NAME); + if (!Mage::getStoreConfigFlag(Helper::XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD)) { + $referer = $this->getRequest()->getParam(Helper::REFERER_QUERY_PARAM_NAME); if ($referer) { // Rebuild referer URL to handle the case when SID was changed $referer = $this->_getModel('core/url') @@ -236,7 +236,7 @@ public function logoutAction() $session = $this->_getSession(); $session->logout()->renewSession(); - if (Mage::getStoreConfigFlag(Mage_Customer_Helper_Data::XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD)) { + if (Mage::getStoreConfigFlag(Helper::XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD)) { $session->setBeforeAuthUrl(Mage::getBaseUrl()); } else { $session->setBeforeAuthUrl($this->_getRefererUrl()); @@ -342,7 +342,7 @@ protected function _successProcessRegistration(Mage_Customer_Model_Customer $cus $store->getId(), $this->getRequest()->getPost('password') ); - /** @var Mage_Customer_Helper_Data $customerHelper */ + /** @var Helper $customerHelper */ $customerHelper = $this->_getHelper('customer'); $session->addSuccess($this->__( 'Account confirmation is required. Please, check your email for the confirmation link. To resend the confirmation email please click here.', @@ -770,7 +770,7 @@ public function forgotPasswordPostAction() $customerId = $customer->getId(); if ($customerId) { try { - /** @var Mage_Customer_Helper_Data $helper */ + /** @var Helper $helper */ $helper = $this->_getHelper('customer'); $newResetPasswordLinkToken = $helper->generateResetPasswordLinkToken(); $newResetPasswordLinkCustomerId = $helper->generateResetPasswordLinkCustomerId($customerId); diff --git a/app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php b/app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php index 9b1849752a35..2351a9682159 100644 --- a/app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php +++ b/app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php @@ -59,7 +59,8 @@ public function getResource($forWrite = false) } if (preg_match('#^' . preg_quote(DS, '#') . '#', $this->getVar('path')) || - preg_match('#^[a-z]:' . preg_quote(DS, '#') . '#i', $this->getVar('path'))) { + preg_match('#^[a-z]:' . preg_quote(DS, '#') . '#i', $this->getVar('path')) + ) { $path = $this->_resource->getCleanPath($this->getVar('path')); } else { $baseDir = Mage::getBaseDir(); diff --git a/app/code/core/Mage/Dataflow/Model/Convert/Parser/Csv.php b/app/code/core/Mage/Dataflow/Model/Convert/Parser/Csv.php index aa31f20b8de0..6c4baa044bf3 100644 --- a/app/code/core/Mage/Dataflow/Model/Convert/Parser/Csv.php +++ b/app/code/core/Mage/Dataflow/Model/Convert/Parser/Csv.php @@ -242,7 +242,8 @@ public function getCsvString($fields = []) strpos($value, "\n") !== false || strpos($value, "\r") !== false || strpos($value, "\t") !== false || - strpos($value, ' ') !== false) { + strpos($value, ' ') !== false + ) { $str2 = $enclosure; $escaped = 0; $len = strlen($value); diff --git a/app/code/core/Mage/Dataflow/Model/Profile.php b/app/code/core/Mage/Dataflow/Model/Profile.php index e4a551df46e6..c404c56a2330 100644 --- a/app/code/core/Mage/Dataflow/Model/Profile.php +++ b/app/code/core/Mage/Dataflow/Model/Profile.php @@ -94,7 +94,8 @@ protected function _beforeSave() parent::_beforeSave(); $actionsXML = $this->getData('actions_xml'); if (strlen($actionsXML) < 0 && - @simplexml_load_string('' . $actionsXML . '', null, LIBXML_NOERROR) === false) { + @simplexml_load_string('' . $actionsXML . '', null, LIBXML_NOERROR) === false + ) { Mage::throwException(Mage::helper('dataflow')->__("Actions XML is not valid.")); } @@ -105,7 +106,8 @@ protected function _beforeSave() if (isset($guiData['file']['type']) && $guiData['file']['type'] == 'file') { if (empty($guiData['file']['path']) || (strlen($guiData['file']['path']) == 1 - && in_array($guiData['file']['path'], $charSingleList))) { + && in_array($guiData['file']['path'], $charSingleList)) + ) { $guiData['file']['path'] = self::DEFAULT_EXPORT_PATH; } if (empty($guiData['file']['filename'])) { @@ -172,7 +174,8 @@ protected function _afterSave() $newUploadedFilenames = []; if (isset($_FILES['file_1']['tmp_name']) || isset($_FILES['file_2']['tmp_name']) - || isset($_FILES['file_3']['tmp_name'])) { + || isset($_FILES['file_3']['tmp_name']) + ) { for ($index = 0; $index < 3; $index++) { if ($file = $_FILES['file_' . ($index + 1)]['tmp_name']) { $uploader = new Mage_Core_Model_File_Uploader('file_' . ($index + 1)); diff --git a/app/code/core/Mage/Downloadable/Helper/Download.php b/app/code/core/Mage/Downloadable/Helper/Download.php index a6044b97bef9..8135615285cf 100644 --- a/app/code/core/Mage/Downloadable/Helper/Download.php +++ b/app/code/core/Mage/Downloadable/Helper/Download.php @@ -96,7 +96,8 @@ protected function _getHandle() */ $urlProp = parse_url($this->_resourceFile); if (!isset($urlProp['scheme']) - || strtolower($urlProp['scheme'] != 'http') && strtolower($urlProp['scheme'] != 'https')) { + || strtolower($urlProp['scheme'] != 'http') && strtolower($urlProp['scheme'] != 'https') + ) { Mage::throwException(Mage::helper('downloadable')->__('Invalid download URL scheme.')); } if (!isset($urlProp['host'])) { diff --git a/app/code/core/Mage/Downloadable/Model/Observer.php b/app/code/core/Mage/Downloadable/Model/Observer.php index f4b3cdb066fa..b7fc774c96ac 100644 --- a/app/code/core/Mage/Downloadable/Model/Observer.php +++ b/app/code/core/Mage/Downloadable/Model/Observer.php @@ -144,7 +144,8 @@ public function setHasDownloadableProducts($observer) /** @var Mage_Sales_Model_Order_Item $item */ if ($item->getProductType() == Mage_Downloadable_Model_Product_Type::TYPE_DOWNLOADABLE || $item->getRealProductType() == Mage_Downloadable_Model_Product_Type::TYPE_DOWNLOADABLE - || $item->getProductOptionByCode('is_downloadable')) { + || $item->getProductOptionByCode('is_downloadable') + ) { $session->setHasDownloadableProducts(true); break; } @@ -218,7 +219,8 @@ public function setLinkStatus($observer) ) { if ($item->getStatusId() == Mage_Sales_Model_Order_Item::STATUS_BACKORDERED && $orderItemStatusToEnable == Mage_Sales_Model_Order_Item::STATUS_PENDING && - !in_array(Mage_Sales_Model_Order_Item::STATUS_BACKORDERED, $availableStatuses, true)) { + !in_array(Mage_Sales_Model_Order_Item::STATUS_BACKORDERED, $availableStatuses, true) + ) { $availableStatuses[] = Mage_Sales_Model_Order_Item::STATUS_BACKORDERED; } @@ -271,7 +273,8 @@ public function isAllowedGuestCheckout(Varien_Event_Observer $observer) foreach ($quote->getAllItems() as $item) { if (($product = $item->getProduct()) && - $product->getTypeId() == Mage_Downloadable_Model_Product_Type::TYPE_DOWNLOADABLE) { + $product->getTypeId() == Mage_Downloadable_Model_Product_Type::TYPE_DOWNLOADABLE + ) { $isContain = true; } } diff --git a/app/code/core/Mage/Eav/Model/Config.php b/app/code/core/Mage/Eav/Model/Config.php index f1e654ad11bd..50734bd40b51 100644 --- a/app/code/core/Mage/Eav/Model/Config.php +++ b/app/code/core/Mage/Eav/Model/Config.php @@ -244,7 +244,8 @@ protected function _initEntityTypes() * try load information about entity types from cache */ if ($this->_isCacheEnabled() - && ($cache = Mage::app()->loadCache(self::ENTITIES_CACHE_ID))) { + && ($cache = Mage::app()->loadCache(self::ENTITIES_CACHE_ID)) + ) { $this->_entityData = unserialize($cache, ['allowed_classes' => false]); foreach ($this->_entityData as $typeCode => $data) { $typeId = $data['entity_type_id']; diff --git a/app/code/core/Mage/Eav/Model/Convert/Adapter/Entity.php b/app/code/core/Mage/Eav/Model/Convert/Adapter/Entity.php index b9974f12878c..45f8725d3acb 100644 --- a/app/code/core/Mage/Eav/Model/Convert/Adapter/Entity.php +++ b/app/code/core/Mage/Eav/Model/Convert/Adapter/Entity.php @@ -263,7 +263,8 @@ public function setJoinField($joinField) public function load() { if (!($entityType = $this->getVar('entity_type')) - || !(Mage::getResourceSingleton($entityType) instanceof Mage_Eav_Model_Entity_Interface)) { + || !(Mage::getResourceSingleton($entityType) instanceof Mage_Eav_Model_Entity_Interface) + ) { $this->addException(Mage::helper('eav')->__('Invalid entity specified'), Varien_Convert_Exception::FATAL); } try { diff --git a/app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php b/app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php index 8bfaf93a63c8..2627b7df2a52 100644 --- a/app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php +++ b/app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php @@ -44,7 +44,8 @@ public function getEntity() { if (!$this->_entityType) { if (!($entityType = $this->getVar('entity_type')) - || !(($entity = Mage::getResourceSingleton($entityType)) instanceof Mage_Eav_Model_Entity_Interface)) { + || !(($entity = Mage::getResourceSingleton($entityType)) instanceof Mage_Eav_Model_Entity_Interface) + ) { $this->addException(Mage::helper('eav')->__('Invalid entity specified'), Varien_Convert_Exception::FATAL); } $this->_entity = $entity; diff --git a/app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php b/app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php index 8ec16ab41390..41aa57449841 100644 --- a/app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php +++ b/app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php @@ -560,12 +560,14 @@ public function isInSet($setId) } if (is_array($setId) - && count(array_intersect($setId, array_keys($this->getAttributeSetInfo())))) { + && count(array_intersect($setId, array_keys($this->getAttributeSetInfo()))) + ) { return true; } if (!is_array($setId) - && array_key_exists($setId, $this->getAttributeSetInfo())) { + && array_key_exists($setId, $this->getAttributeSetInfo()) + ) { return true; } diff --git a/app/code/core/Mage/Eav/Model/Entity/Attribute/Backend/Abstract.php b/app/code/core/Mage/Eav/Model/Entity/Attribute/Backend/Abstract.php index 243c241a5d4f..0e81c343922e 100644 --- a/app/code/core/Mage/Eav/Model/Entity/Attribute/Backend/Abstract.php +++ b/app/code/core/Mage/Eav/Model/Entity/Attribute/Backend/Abstract.php @@ -250,7 +250,8 @@ public function validate($object) if ($this->getAttribute()->getIsUnique() && !$this->getAttribute()->getIsRequired() - && ($value == '' || $this->getAttribute()->isValueEmpty($value))) { + && ($value == '' || $this->getAttribute()->isValueEmpty($value)) + ) { return true; } diff --git a/app/code/core/Mage/Eav/Model/Entity/Attribute/Backend/Time/Created.php b/app/code/core/Mage/Eav/Model/Entity/Attribute/Backend/Time/Created.php index a72ade2cc5ea..591e78ec78f4 100644 --- a/app/code/core/Mage/Eav/Model/Entity/Attribute/Backend/Time/Created.php +++ b/app/code/core/Mage/Eav/Model/Entity/Attribute/Backend/Time/Created.php @@ -36,7 +36,8 @@ class Mage_Eav_Model_Entity_Attribute_Backend_Time_Created extends Mage_Eav_Mode protected function _getFormat($date) { if (is_string($date) && preg_match('#^\d{4,4}-\d{2,2}-\d{2,2}\s\d{2,2}:\d{2,2}:\d{2,2}$#', $date) - || preg_match('#^\d{4,4}-\d{2,2}-\d{2,2}\w{1,1}\d{2,2}:\d{2,2}:\d{2,2}[+-]\d{2,2}:\d{2,2}$#', $date)) { + || preg_match('#^\d{4,4}-\d{2,2}-\d{2,2}\w{1,1}\d{2,2}:\d{2,2}:\d{2,2}[+-]\d{2,2}:\d{2,2}$#', $date) + ) { return 'yyyy-MM-dd HH:mm:ss'; } return null; diff --git a/app/code/core/Mage/Eav/Model/Entity/Setup.php b/app/code/core/Mage/Eav/Model/Entity/Setup.php index 919ba5d3f672..36e57c91bd37 100644 --- a/app/code/core/Mage/Eav/Model/Entity/Setup.php +++ b/app/code/core/Mage/Eav/Model/Entity/Setup.php @@ -655,7 +655,8 @@ protected function _validateAttributeData($data) $attributeCodeMaxLength = Mage_Eav_Model_Entity_Attribute::ATTRIBUTE_CODE_MAX_LENGTH; if (isset($data['attribute_code']) && - !Zend_Validate::is($data['attribute_code'], 'StringLength', ['max' => $attributeCodeMaxLength])) { + !Zend_Validate::is($data['attribute_code'], 'StringLength', ['max' => $attributeCodeMaxLength]) + ) { throw Mage::exception( 'Mage_Eav', Mage::helper('eav')->__('Maximum length of attribute code must be less then %s symbols', $attributeCodeMaxLength) diff --git a/app/code/core/Mage/GiftMessage/Model/Api.php b/app/code/core/Mage/GiftMessage/Model/Api.php index 492b6fd8391f..45f68c168ac9 100644 --- a/app/code/core/Mage/GiftMessage/Model/Api.php +++ b/app/code/core/Mage/GiftMessage/Model/Api.php @@ -112,7 +112,8 @@ public function setForQuoteProduct($quoteId, $productsAndMessages, $store = null if (count($productsAndMessages) == 2 && isset($productsAndMessages['product']) - && isset($productsAndMessages['message'])) { + && isset($productsAndMessages['message']) + ) { $productsAndMessages = [$productsAndMessages]; } diff --git a/app/code/core/Mage/GiftMessage/Model/Api/V2.php b/app/code/core/Mage/GiftMessage/Model/Api/V2.php index 51fb881d105a..023c18a61695 100644 --- a/app/code/core/Mage/GiftMessage/Model/Api/V2.php +++ b/app/code/core/Mage/GiftMessage/Model/Api/V2.php @@ -43,7 +43,8 @@ protected function _prepareData($data) if (is_array($value)) { foreach ($value as $v) { if (is_object($v) && count(get_object_vars($v)) == 2 - && isset($v->key) && isset($v->value)) { + && isset($v->key) && isset($v->value) + ) { $assocArr[$v->key] = $v->value; } } diff --git a/app/code/core/Mage/GiftMessage/Model/Entity/Attribute/Backend/Boolean/Config.php b/app/code/core/Mage/GiftMessage/Model/Entity/Attribute/Backend/Boolean/Config.php index e9bf556bf037..e209d3c36996 100644 --- a/app/code/core/Mage/GiftMessage/Model/Entity/Attribute/Backend/Boolean/Config.php +++ b/app/code/core/Mage/GiftMessage/Model/Entity/Attribute/Backend/Boolean/Config.php @@ -52,7 +52,8 @@ public function afterLoad($object) public function beforeSave($object) { if ($object->hasData($this->getAttribute()->getAttributeCode()) - && $object->getData($this->getAttribute()->getAttributeCode()) == $this->getDefaultValue()) { + && $object->getData($this->getAttribute()->getAttributeCode()) == $this->getDefaultValue() + ) { $object->unsData($this->getAttribute()->getAttributeCode()); } return $this; diff --git a/app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php b/app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php index 2ee78406c4d8..abafa83e0a43 100644 --- a/app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php +++ b/app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php @@ -216,7 +216,8 @@ protected function _getExportAttrCodes() { if (self::$attrCodes === null) { if (!empty($this->_parameters[Mage_ImportExport_Model_Export::FILTER_ELEMENT_SKIP]) - && is_array($this->_parameters[Mage_ImportExport_Model_Export::FILTER_ELEMENT_SKIP])) { + && is_array($this->_parameters[Mage_ImportExport_Model_Export::FILTER_ELEMENT_SKIP]) + ) { $skipAttr = array_flip($this->_parameters[Mage_ImportExport_Model_Export::FILTER_ELEMENT_SKIP]); } else { $skipAttr = []; @@ -225,7 +226,8 @@ protected function _getExportAttrCodes() foreach ($this->filterAttributeCollection($this->getAttributeCollection()) as $attribute) { if (!isset($skipAttr[$attribute->getAttributeId()]) - || in_array($attribute->getAttributeCode(), $this->_permanentAttributes)) { + || in_array($attribute->getAttributeCode(), $this->_permanentAttributes) + ) { $attrCodes[] = $attribute->getAttributeCode(); } } @@ -256,7 +258,8 @@ protected function _initAttrValues() protected function _prepareEntityCollection(Mage_Eav_Model_Entity_Collection_Abstract $collection) { if (!isset($this->_parameters[Mage_ImportExport_Model_Export::FILTER_ELEMENT_GROUP]) - || !is_array($this->_parameters[Mage_ImportExport_Model_Export::FILTER_ELEMENT_GROUP])) { + || !is_array($this->_parameters[Mage_ImportExport_Model_Export::FILTER_ELEMENT_GROUP]) + ) { $exportFilter = []; } else { $exportFilter = $this->_parameters[Mage_ImportExport_Model_Export::FILTER_ELEMENT_GROUP]; diff --git a/app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php b/app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php index 64f7bc228141..731b9e5af87f 100644 --- a/app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php +++ b/app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php @@ -131,7 +131,8 @@ protected function _initAttributeSets() { $productTypeId = Mage::getModel('catalog/product')->getResource()->getTypeId(); foreach (Mage::getResourceModel('eav/entity_attribute_set_collection') - ->setEntityTypeFilter($productTypeId) as $attributeSet) { + ->setEntityTypeFilter($productTypeId) as $attributeSet + ) { $this->_attrSetIdToName[$attributeSet->getId()] = $attributeSet->getAttributeSetName(); } return $this; diff --git a/app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php b/app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php index 2213d056fa38..cd36a7ceafea 100644 --- a/app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php +++ b/app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php @@ -387,7 +387,8 @@ public function getBehavior() if (!isset($this->_parameters['behavior']) || ($this->_parameters['behavior'] != Mage_ImportExport_Model_Import::BEHAVIOR_APPEND && $this->_parameters['behavior'] != Mage_ImportExport_Model_Import::BEHAVIOR_REPLACE - && $this->_parameters['behavior'] != Mage_ImportExport_Model_Import::BEHAVIOR_DELETE)) { + && $this->_parameters['behavior'] != Mage_ImportExport_Model_Import::BEHAVIOR_DELETE) + ) { return Mage_ImportExport_Model_Import::getDefaultBehavior(); } return $this->_parameters['behavior']; diff --git a/app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php b/app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php index 541d9c77d216..106fa3377097 100644 --- a/app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php +++ b/app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php @@ -616,7 +616,8 @@ public function validateRow(array $rowData, $rowNum) // BEHAVIOR_DELETE use specific validation logic if (Mage_ImportExport_Model_Import::BEHAVIOR_DELETE == $this->getBehavior()) { if (self::SCOPE_DEFAULT == $rowScope - && !isset($oldCustomersToLower[$emailToLower][$website])) { + && !isset($oldCustomersToLower[$emailToLower][$website]) + ) { $this->addRowError(self::ERROR_EMAIL_SITE_NOT_FOUND, $rowNum); } } elseif (self::SCOPE_DEFAULT == $rowScope) { // row is SCOPE_DEFAULT = new customer block begins diff --git a/app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php b/app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php index 6a3a6405d65f..4c4ec604b9cb 100644 --- a/app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php +++ b/app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php @@ -503,7 +503,8 @@ protected function _importData() protected function _initAttributeSets() { foreach (Mage::getResourceModel('eav/entity_attribute_set_collection') - ->setEntityTypeFilter($this->_entityTypeId) as $attributeSet) { + ->setEntityTypeFilter($this->_entityTypeId) as $attributeSet + ) { /** @var Mage_Eav_Model_Entity_Attribute_Set $attributeSet */ $this->_attrSetNameToId[$attributeSet->getAttributeSetName()] = $attributeSet->getId(); $this->_attrSetIdToName[$attributeSet->getId()] = $attributeSet->getAttributeSetName(); @@ -725,11 +726,13 @@ protected function _isTierPriceValid(array $rowData, $rowNum) $this->addRowError(self::ERROR_TIER_DATA_INCOMPLETE, $rowNum); return false; } elseif ($rowData['_tier_price_website'] != self::VALUE_ALL - && !isset($this->_websiteCodeToId[$rowData['_tier_price_website']])) { + && !isset($this->_websiteCodeToId[$rowData['_tier_price_website']]) + ) { $this->addRowError(self::ERROR_INVALID_TIER_PRICE_SITE, $rowNum); return false; } elseif ($rowData['_tier_price_customer_group'] != self::VALUE_ALL - && !isset($this->_customerGroups[$rowData['_tier_price_customer_group']])) { + && !isset($this->_customerGroups[$rowData['_tier_price_customer_group']]) + ) { $this->addRowError(self::ERROR_INVALID_TIER_PRICE_GROUP, $rowNum); return false; } elseif ($rowData['_tier_price_qty'] <= 0 || $rowData['_tier_price_price'] <= 0) { @@ -1175,7 +1178,8 @@ protected function _saveLinks() $linkedSku = $rowData[$linkName . 'sku']; if ((isset($this->_newSku[$linkedSku]) || isset($this->_oldSku[$linkedSku])) - && $linkedSku != $sku) { + && $linkedSku != $sku + ) { if (isset($this->_newSku[$linkedSku])) { $linkedId = $this->_newSku[$linkedSku]['entity_id']; } else { diff --git a/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Abstract.php b/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Abstract.php index 14e4b137c553..2701fcac940e 100644 --- a/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Abstract.php +++ b/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Abstract.php @@ -97,7 +97,8 @@ final public function __construct(array $params) { if ($this->isSuitable()) { if (!isset($params[0]) || !isset($params[1]) - || !is_object($params[0]) || !($params[0] instanceof Mage_ImportExport_Model_Import_Entity_Product)) { + || !is_object($params[0]) || !($params[0] instanceof Mage_ImportExport_Model_Import_Entity_Product) + ) { Mage::throwException(Mage::helper('importexport')->__('Invalid parameters')); } $this->_entityModel = $params[0]; @@ -156,9 +157,11 @@ protected function _initAttributes() $attributesCache = []; foreach (Mage::getResourceModel('eav/entity_attribute_set_collection') - ->setEntityTypeFilter($this->_entityModel->getEntityTypeId()) as $attributeSet) { + ->setEntityTypeFilter($this->_entityModel->getEntityTypeId()) as $attributeSet + ) { foreach (Mage::getResourceModel('catalog/product_attribute_collection') - ->setAttributeSetFilter($attributeSet->getId()) as $attribute) { + ->setAttributeSetFilter($attributeSet->getId()) as $attribute + ) { /** @var Mage_Eav_Model_Entity_Attribute $attribute */ $attributeCode = $attribute->getAttributeCode(); $attributeId = $attribute->getId(); @@ -252,11 +255,13 @@ public function isRowValid(array $rowData, $rowNum, $isNewProduct = true) if (isset($rowData[$attrCode]) && strlen($rowData[$attrCode])) { $error |= !$this->_entityModel->isAttributeValid($attrCode, $attrParams, $rowData, $rowNum); } elseif ($this->_isAttributeRequiredCheckNeeded($attrCode) - && $attrParams['is_required']) { + && $attrParams['is_required'] + ) { // For the default scope - if this is a new product or // for an old product, if the imported doc has the column present for the attrCode if (Mage_ImportExport_Model_Import_Entity_Product::SCOPE_DEFAULT == $rowScope && - ($isNewProduct || array_key_exists($attrCode, $rowData))) { + ($isNewProduct || array_key_exists($attrCode, $rowData)) + ) { $this->_entityModel->addRowError( Mage_ImportExport_Model_Import_Entity_Product::ERROR_VALUE_IS_REQUIRED, $rowNum, diff --git a/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Configurable.php b/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Configurable.php index 4d1c693fb4a5..95f8275e1858 100644 --- a/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Configurable.php +++ b/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Configurable.php @@ -217,7 +217,8 @@ protected function _loadSkuSuperAttributeValues() $allowProductTypes = []; foreach (Mage::getConfig() - ->getNode('global/catalog/product/type/configurable/allow_product_types')->children() as $type) { + ->getNode('global/catalog/product/type/configurable/allow_product_types')->children() as $type + ) { $allowProductTypes[] = $type->getName(); } /** @var Mage_Catalog_Model_Resource_Product_Collection $collection */ @@ -455,7 +456,8 @@ public function saveData() // remove old data if needed if ($this->_entityModel->getBehavior() != Mage_ImportExport_Model_Import::BEHAVIOR_APPEND - && $superAttributes['attributes']) { + && $superAttributes['attributes'] + ) { $quoted = $connection->quoteInto('IN (?)', array_keys($superAttributes['attributes'])); $connection->delete($mainTable, "product_id {$quoted}"); $connection->delete($linkTable, "parent_id {$quoted}"); diff --git a/app/code/core/Mage/ImportExport/Model/Import/Proxy/Product/Resource.php b/app/code/core/Mage/ImportExport/Model/Import/Proxy/Product/Resource.php index 26bbbc94d412..392807d79467 100644 --- a/app/code/core/Mage/ImportExport/Model/Import/Proxy/Product/Resource.php +++ b/app/code/core/Mage/ImportExport/Model/Import/Proxy/Product/Resource.php @@ -25,7 +25,7 @@ * @package Mage_ImportExport * @author Magento Core Team */ -class Mage_ImportExport_Model_Import_Proxy_Product_Resource extends Mage_Catalog_Model_Resource_Eav_Mysql4_Product +class Mage_ImportExport_Model_Import_Proxy_Product_Resource extends Mage_Catalog_Model_Resource_Product { /** * Product to category table. diff --git a/app/code/core/Mage/Index/Model/Indexer.php b/app/code/core/Mage/Index/Model/Indexer.php index 66f206782146..769c70ad7ba4 100644 --- a/app/code/core/Mage/Index/Model/Indexer.php +++ b/app/code/core/Mage/Index/Model/Indexer.php @@ -430,7 +430,8 @@ protected function _changeProcessKeyStatus($process, $enable = true) is_null($event) || ($event instanceof Mage_Index_Model_Event && $process->matchEvent($event)) || (is_array($event) && $process->matchEntityAndType($event[0], $event[1])) - )) { + ) + ) { if ($enable) { $process->enableIndexerKeys(); } else { diff --git a/app/code/core/Mage/Index/Model/Lock.php b/app/code/core/Mage/Index/Model/Lock.php index 11d121b11a66..91ed1bda203f 100644 --- a/app/code/core/Mage/Index/Model/Lock.php +++ b/app/code/core/Mage/Index/Model/Lock.php @@ -249,7 +249,7 @@ protected function _isLockExistsFile($lockName) Mage::logException($e); throw $e; } - + return $result; } diff --git a/app/code/core/Mage/Install/Model/Installer/Config.php b/app/code/core/Mage/Install/Model/Installer/Config.php index b2778308b806..3a7194b7f786 100644 --- a/app/code/core/Mage/Install/Model/Installer/Config.php +++ b/app/code/core/Mage/Install/Model/Installer/Config.php @@ -83,7 +83,8 @@ public function install() } if (!empty($data['use_secure']) - && !$this->_getInstaller()->getDataModel()->getSkipUrlValidation()) { + && !$this->_getInstaller()->getDataModel()->getSkipUrlValidation() + ) { $this->_checkUrl($data['secure_base_url']); } } diff --git a/app/code/core/Mage/Install/Model/Wizard.php b/app/code/core/Mage/Install/Model/Wizard.php index a424f6e8ab31..dd5b578694f2 100644 --- a/app/code/core/Mage/Install/Model/Wizard.php +++ b/app/code/core/Mage/Install/Model/Wizard.php @@ -73,7 +73,8 @@ public function getStepByRequest(Zend_Controller_Request_Abstract $request) { foreach ($this->_steps as $step) { if ($step->getController() == $request->getControllerName() - && $step->getAction() == $request->getActionName()) { + && $step->getAction() == $request->getActionName() + ) { return $step; } } diff --git a/app/code/core/Mage/Newsletter/controllers/SubscriberController.php b/app/code/core/Mage/Newsletter/controllers/SubscriberController.php index 7b03e64375f0..d88dff1f88b2 100644 --- a/app/code/core/Mage/Newsletter/controllers/SubscriberController.php +++ b/app/code/core/Mage/Newsletter/controllers/SubscriberController.php @@ -54,7 +54,8 @@ public function newAction() } if (Mage::getStoreConfig(Mage_Newsletter_Model_Subscriber::XML_PATH_ALLOW_GUEST_SUBSCRIBE_FLAG) != 1 && - !$customerSession->isLoggedIn()) { + !$customerSession->isLoggedIn() + ) { Mage::throwException($this->__('Sorry, but administrator denied subscription for guests. Please register.', Mage::helper('customer')->getRegisterUrl())); } diff --git a/app/code/core/Mage/Oauth/Block/Adminhtml/Oauth/AuthorizedTokens/Grid.php b/app/code/core/Mage/Oauth/Block/Adminhtml/Oauth/AuthorizedTokens/Grid.php index 822dcabc0f0e..e9b14ef36863 100644 --- a/app/code/core/Mage/Oauth/Block/Adminhtml/Oauth/AuthorizedTokens/Grid.php +++ b/app/code/core/Mage/Oauth/Block/Adminhtml/Oauth/AuthorizedTokens/Grid.php @@ -183,7 +183,7 @@ public function decorateUserType($value, $row, $column, $isExport) { $options = $column->getOptions(); - $value = ($row->getCustomerId()) ? $options[1] : $options[0]; + $value = ($row->getCustomerId()) ? $options[1] : $options[0]; return $value; } diff --git a/app/code/core/Mage/Oauth/Model/Server.php b/app/code/core/Mage/Oauth/Model/Server.php index 87dd18b6a301..f7514cc69b8b 100644 --- a/app/code/core/Mage/Oauth/Model/Server.php +++ b/app/code/core/Mage/Oauth/Model/Server.php @@ -408,7 +408,8 @@ protected function _saveToken() { if (self::REQUEST_INITIATE == $this->_requestType) { if (self::CALLBACK_ESTABLISHED == $this->_protocolParams['oauth_callback'] - && $this->_consumer->getCallBackUrl()) { + && $this->_consumer->getCallBackUrl() + ) { $callbackUrl = $this->_consumer->getCallbackUrl(); } else { $callbackUrl = $this->_protocolParams['oauth_callback']; diff --git a/app/code/core/Mage/Page/Helper/Layout.php b/app/code/core/Mage/Page/Helper/Layout.php index 3c1a589fa704..51b98284c206 100644 --- a/app/code/core/Mage/Page/Helper/Layout.php +++ b/app/code/core/Mage/Page/Helper/Layout.php @@ -71,7 +71,8 @@ public function applyTemplate($pageLayout = null) } if ($this->getLayout()->getBlock('root') && - !$this->getLayout()->getBlock('root')->getIsHandle()) { + !$this->getLayout()->getBlock('root')->getIsHandle() + ) { // If not applied handle $this->getLayout() ->getBlock('root') @@ -89,7 +90,8 @@ public function applyTemplate($pageLayout = null) public function getCurrentPageLayout() { if ($this->getLayout()->getBlock('root') && - $this->getLayout()->getBlock('root')->getLayoutCode()) { + $this->getLayout()->getBlock('root')->getLayoutCode() + ) { return $this->_getConfig()->getPageLayout($this->getLayout()->getBlock('root')->getLayoutCode()); } diff --git a/app/code/core/Mage/Paygate/Model/Authorizenet.php b/app/code/core/Mage/Paygate/Model/Authorizenet.php index f2a993c88acc..9db69b8ba92b 100644 --- a/app/code/core/Mage/Paygate/Model/Authorizenet.php +++ b/app/code/core/Mage/Paygate/Model/Authorizenet.php @@ -423,10 +423,7 @@ public function refund(Varien_Object $payment, $requestedAmount) { $cardsStorage = $this->getCardsStorage($payment); - if ($this->_formatAmount( - $cardsStorage->getCapturedAmount() - $cardsStorage->getRefundedAmount() - ) < $requestedAmount - ) { + if ($this->_formatAmount($cardsStorage->getCapturedAmount() - $cardsStorage->getRefundedAmount()) < $requestedAmount) { Mage::throwException(Mage::helper('paygate')->__('Invalid amount for refund.')); } @@ -706,10 +703,7 @@ protected function _preauthorizeCapture($payment, $requestedAmount) { $cardsStorage = $this->getCardsStorage($payment); - if ($this->_formatAmount( - $cardsStorage->getProcessedAmount() - $cardsStorage->getCapturedAmount() - ) < $requestedAmount - ) { + if ($this->_formatAmount($cardsStorage->getProcessedAmount() - $cardsStorage->getCapturedAmount()) < $requestedAmount) { Mage::throwException(Mage::helper('paygate')->__('Invalid amount for capture.')); } diff --git a/app/code/core/Mage/Paygate/sql/paygate_setup/mysql4-data-upgrade-0.7.0-0.7.1.php b/app/code/core/Mage/Paygate/sql/paygate_setup/mysql4-data-upgrade-0.7.0-0.7.1.php index 1bb68078be1f..c459d5c14414 100644 --- a/app/code/core/Mage/Paygate/sql/paygate_setup/mysql4-data-upgrade-0.7.0-0.7.1.php +++ b/app/code/core/Mage/Paygate/sql/paygate_setup/mysql4-data-upgrade-0.7.0-0.7.1.php @@ -96,7 +96,8 @@ */ $paymentsIds[] = $paymentId; if (($payment['last_transaction_type'] == 'authorization' || $payment['last_transaction_type'] == 'capture') - && $payment['last_transaction_is_closed'] == '1') { + && $payment['last_transaction_is_closed'] == '1' + ) { $transactionsShouldBeOpened[] = $payment['last_transaction_id']; } } diff --git a/app/code/core/Mage/Paygate/sql/paygate_setup/mysql4-upgrade-0.7.0-0.7.1.php b/app/code/core/Mage/Paygate/sql/paygate_setup/mysql4-upgrade-0.7.0-0.7.1.php index a796a8de3e07..d0ab77e9fdb3 100644 --- a/app/code/core/Mage/Paygate/sql/paygate_setup/mysql4-upgrade-0.7.0-0.7.1.php +++ b/app/code/core/Mage/Paygate/sql/paygate_setup/mysql4-upgrade-0.7.0-0.7.1.php @@ -28,7 +28,8 @@ 'pilot-payflowpro.verisign.com' => 'pilot-payflowpro.paypal.com', 'test-payflow.verisign.com' => 'pilot-payflowpro.paypal.com', 'payflow.verisign.com' => 'payflowpro.paypal.com', - ] as $from => $to) { + ] as $from => $to +) { $installer->run(" UPDATE {$installer->getTable('core/config_data')} SET `value` = REPLACE(`value`, '{$from}', '{$to}') WHERE `path` = 'payment/verisign/url' diff --git a/app/code/core/Mage/Payment/Block/Form/Container.php b/app/code/core/Mage/Payment/Block/Form/Container.php index 1fe1cb158631..48d9dc90fd65 100644 --- a/app/code/core/Mage/Payment/Block/Form/Container.php +++ b/app/code/core/Mage/Payment/Block/Form/Container.php @@ -111,10 +111,9 @@ public function getMethods() $store = $quote ? $quote->getStoreId() : null; $methods = []; foreach ($helper->getStoreMethods($store, $quote) as $method) { - if ($this->_canUseMethod($method) && $method->isApplicableToQuote( - $quote, - Mage_Payment_Model_Method_Abstract::CHECK_ZERO_TOTAL - )) { + if ($this->_canUseMethod($method) + && $method->isApplicableToQuote($quote, Mage_Payment_Model_Method_Abstract::CHECK_ZERO_TOTAL) + ) { $this->_assignMethod($method); $methods[] = $method; } diff --git a/app/code/core/Mage/Payment/Model/Method/Cc.php b/app/code/core/Mage/Payment/Model/Method/Cc.php index fb45aeabdbd5..7879cb3c0105 100644 --- a/app/code/core/Mage/Payment/Model/Method/Cc.php +++ b/app/code/core/Mage/Payment/Model/Method/Cc.php @@ -102,7 +102,8 @@ public function validate() if (in_array($info->getCcType(), $availableTypes)) { if ($this->validateCcNum($ccNumber) // Other credit card type number validation - || ($this->otherCcType($info->getCcType()) && $this->validateCcNumOther($ccNumber))) { + || ($this->otherCcType($info->getCcType()) && $this->validateCcNumOther($ccNumber)) + ) { $ccType = 'OT'; $discoverNetworkRegexp = '/^(30[0-5]\d{13}|3095\d{12}|35(2[8-9]\d{12}|[3-8]\d{13})|36\d{12}' . '|3[8-9]\d{14}|6011(0\d{11}|[2-4]\d{11}|74\d{10}|7[7-9]\d{10}|8[6-9]\d{10}|9\d{11})' @@ -365,9 +366,9 @@ private function _getAmount() { $info = $this->getInfoInstance(); if ($this->_isPlaceOrder()) { - return (double)$info->getOrder()->getQuoteBaseGrandTotal(); + return (float)$info->getOrder()->getQuoteBaseGrandTotal(); } else { - return (double)$info->getQuote()->getBaseGrandTotal(); + return (float)$info->getQuote()->getBaseGrandTotal(); } } diff --git a/app/code/core/Mage/Payment/Model/Recurring/Profile.php b/app/code/core/Mage/Payment/Model/Recurring/Profile.php index e3aa180c6ab2..ff1c78103b55 100644 --- a/app/code/core/Mage/Payment/Model/Recurring/Profile.php +++ b/app/code/core/Mage/Payment/Model/Recurring/Profile.php @@ -543,7 +543,8 @@ protected function _filterValues() // unset redundant values, if empty foreach (['schedule_description', 'suspension_threshold', 'bill_failed_later', 'period_frequency', 'period_max_cycles', 'reference_id', - 'trial_period_unit', 'trial_period_frequency', 'trial_period_max_cycles', 'init_may_fail'] as $key) { + 'trial_period_unit', 'trial_period_frequency', 'trial_period_max_cycles', 'init_may_fail'] as $key + ) { if ($this->hasData($key) && (!$this->getData($key) || $this->getData($key) == '0')) { $this->unsetData($key); } @@ -551,7 +552,8 @@ protected function _filterValues() // cast amounts foreach ([ - 'billing_amount', 'trial_billing_amount', 'shipping_amount', 'tax_amount', 'init_amount'] as $key) { + 'billing_amount', 'trial_billing_amount', 'shipping_amount', 'tax_amount', 'init_amount'] as $key + ) { if ($this->hasData($key)) { if (!$this->getData($key) || $this->getData($key) == 0) { $this->unsetData($key); diff --git a/app/code/core/Mage/Paypal/Block/Bml/Banners.php b/app/code/core/Mage/Paypal/Block/Bml/Banners.php index d31e17378e20..a638e5fd5e92 100644 --- a/app/code/core/Mage/Paypal/Block/Bml/Banners.php +++ b/app/code/core/Mage/Paypal/Block/Bml/Banners.php @@ -71,7 +71,8 @@ protected function _getConfig() protected function _toHtml() { if (!$this->_getConfig()->isMethodAvailable(Mage_Paypal_Model_Config::METHOD_BML) - && !$this->_getConfig()->isMethodAvailable(Mage_Paypal_Model_Config::METHOD_WPP_PE_BML)) { + && !$this->_getConfig()->isMethodAvailable(Mage_Paypal_Model_Config::METHOD_WPP_PE_BML) + ) { return ''; } $publisherId = $this->_getConfig()->getBmlPublisherId(); diff --git a/app/code/core/Mage/Paypal/Block/Express/Form.php b/app/code/core/Mage/Paypal/Block/Express/Form.php index 718d1346f8f3..991a6a249e45 100644 --- a/app/code/core/Mage/Paypal/Block/Express/Form.php +++ b/app/code/core/Mage/Paypal/Block/Express/Form.php @@ -52,7 +52,8 @@ protected function _beforeToHtml() { $customerId = Mage::getSingleton('customer/session')->getCustomerId(); if (Mage::helper('paypal')->shouldAskToCreateBillingAgreement($this->_config, $customerId) - && $this->canCreateBillingAgreement()) { + && $this->canCreateBillingAgreement() + ) { $this->setCreateBACode(Mage_Paypal_Model_Express_Checkout::PAYMENT_INFO_TRANSPORT_BILLING_AGREEMENT); } return parent::_beforeToHtml(); diff --git a/app/code/core/Mage/Paypal/Block/Express/Shortcut.php b/app/code/core/Mage/Paypal/Block/Express/Shortcut.php index 0b33fd57ac60..56bff6a71e57 100644 --- a/app/code/core/Mage/Paypal/Block/Express/Shortcut.php +++ b/app/code/core/Mage/Paypal/Block/Express/Shortcut.php @@ -106,7 +106,8 @@ protected function _beforeToHtml() // validate minimum quote amount and validate quote for zero grandtotal if ($quote !== null && (!$quote->validateMinimumAmount() - || (!$quote->getGrandTotal() && !$quote->hasNominalItems()))) { + || (!$quote->getGrandTotal() && !$quote->hasNominalItems())) + ) { $this->_shouldRender = false; return $result; } diff --git a/app/code/core/Mage/Paypal/Block/Iframe.php b/app/code/core/Mage/Paypal/Block/Iframe.php index 8ec24b0a9292..3695175c8757 100644 --- a/app/code/core/Mage/Paypal/Block/Iframe.php +++ b/app/code/core/Mage/Paypal/Block/Iframe.php @@ -134,7 +134,8 @@ protected function _beforeToHtml() { if ($this->_getOrder()->getId() && $this->_getOrder()->getQuoteId() == $this->_getCheckout()->getLastQuoteId() && - $this->_paymentMethodCode) { + $this->_paymentMethodCode + ) { $this->_shouldRender = true; } @@ -175,7 +176,8 @@ protected function _isAfterPaymentSave() if ($quote->getPayment()->getMethod() == $this->_paymentMethodCode && $quote->getIsActive() && $this->getTemplate() && - $this->getRequest()->getActionName() == 'savePayment') { + $this->getRequest()->getActionName() == 'savePayment' + ) { return true; } diff --git a/app/code/core/Mage/Paypal/Controller/Express/Abstract.php b/app/code/core/Mage/Paypal/Controller/Express/Abstract.php index e9c073d846af..5c285dfb76b2 100644 --- a/app/code/core/Mage/Paypal/Controller/Express/Abstract.php +++ b/app/code/core/Mage/Paypal/Controller/Express/Abstract.php @@ -93,7 +93,8 @@ public function startAction() && !Mage::helper('checkout')->isAllowedGuestCheckout( $this->_getQuote(), $this->_getQuote()->getStoreId() - )) { + ) + ) { Mage::getSingleton('core/session')->addNotice( Mage::helper('paypal')->__('To proceed to Checkout, please log in using your email address.') ); diff --git a/app/code/core/Mage/Paypal/Helper/Data.php b/app/code/core/Mage/Paypal/Helper/Data.php index 7093eaade7c4..c9373d158b19 100644 --- a/app/code/core/Mage/Paypal/Helper/Data.php +++ b/app/code/core/Mage/Paypal/Helper/Data.php @@ -122,7 +122,8 @@ public function getHtmlTransactionId($methodCode, $txnId) Mage_Paypal_Model_Config::METHOD_WPP_EXPRESS, Mage_Paypal_Model_Config::METHOD_HOSTEDPRO, Mage_Paypal_Model_Config::METHOD_WPS, - ])) { + ]) + ) { /** @var Mage_Paypal_Model_Config $config */ $config = Mage::getModel('paypal/config')->setMethod($methodCode); $url = 'https://www.' . ($config->sandboxFlag ? 'sandbox.' : '') diff --git a/app/code/core/Mage/Paypal/Model/Cart.php b/app/code/core/Mage/Paypal/Model/Cart.php index ba410730bc39..20233443f4f8 100644 --- a/app/code/core/Mage/Paypal/Model/Cart.php +++ b/app/code/core/Mage/Paypal/Model/Cart.php @@ -116,7 +116,8 @@ public function __construct($params = []) { $salesEntity = array_shift($params); if (is_object($salesEntity) - && (($salesEntity instanceof Mage_Sales_Model_Order) || ($salesEntity instanceof Mage_Sales_Model_Quote))) { + && (($salesEntity instanceof Mage_Sales_Model_Order) || ($salesEntity instanceof Mage_Sales_Model_Quote)) + ) { $this->_salesEntity = $salesEntity; } else { throw new Exception('Invalid sales entity provided.'); diff --git a/app/code/core/Mage/Paypal/Model/Config.php b/app/code/core/Mage/Paypal/Model/Config.php index bd1acf9ee5bf..f0fcf559a900 100644 --- a/app/code/core/Mage/Paypal/Model/Config.php +++ b/app/code/core/Mage/Paypal/Model/Config.php @@ -44,6 +44,7 @@ * @property mixed $debug; * @property mixed $lineItemsEnabled; * @property mixed $lineItemsSummary; + * @property mixed $payment_action; * @property mixed $paymentAction; * @property mixed $paymentMarkSize; * @property mixed $requireBillingAddress; @@ -725,7 +726,8 @@ public function isMethodAvailable($methodCode = null) } // check for direct payments dependence if ($this->isMethodActive(self::METHOD_WPP_DIRECT) - || $this->isMethodActive(self::METHOD_WPP_PE_DIRECT)) { + || $this->isMethodActive(self::METHOD_WPP_PE_DIRECT) + ) { $result = false; } break; @@ -748,7 +750,8 @@ public function isMethodAvailable($methodCode = null) if ($this->isMethodActive(self::METHOD_WPP_PE_DIRECT)) { $result = true; } elseif (!$this->isMethodActive(self::METHOD_WPP_PE_DIRECT) - && !$this->isMethodActive(self::METHOD_PAYFLOWPRO)) { + && !$this->isMethodActive(self::METHOD_PAYFLOWPRO) + ) { $result = false; } break; @@ -800,7 +803,8 @@ protected function _prepareValue($key, $value) if ($key == 'payment_action' && $value != self::PAYMENT_ACTION_SALE && $this->_methodCode == self::METHOD_WPP_EXPRESS - && $this->shouldUseUnilateralPayments()) { + && $this->shouldUseUnilateralPayments() + ) { return self::PAYMENT_ACTION_SALE; } return $value; @@ -1813,7 +1817,8 @@ protected function _mapWpukFieldset($fieldName) $pathPrefix = 'paypal/wpuk'; // Use PUMP credentials from Verisign for EC when Direct Payments are unavailable if ($this->_methodCode == self::METHOD_WPP_PE_EXPRESS - && !$this->isMethodAvailable(self::METHOD_WPP_PE_DIRECT)) { + && !$this->isMethodAvailable(self::METHOD_WPP_PE_DIRECT) + ) { $pathPrefix = 'payment/verisign'; } elseif ($this->_methodCode == self::METHOD_PAYFLOWADVANCED || $this->_methodCode == self::METHOD_PAYFLOWLINK diff --git a/app/code/core/Mage/Paypal/Model/Express/Checkout.php b/app/code/core/Mage/Paypal/Model/Express/Checkout.php index 7132bdcc16ee..2687791a0970 100644 --- a/app/code/core/Mage/Paypal/Model/Express/Checkout.php +++ b/app/code/core/Mage/Paypal/Model/Express/Checkout.php @@ -618,9 +618,7 @@ public function place($token, $shippingMethodCode = null) $this->_billingAgreement = $order->getPayment()->getBillingAgreement(); // commence redirecting to finish payment, if paypal requires it - if ($order->getPayment()->getAdditionalInformation( - self::PAYMENT_INFO_TRANSPORT_REDIRECT - )) { + if ($order->getPayment()->getAdditionalInformation(self::PAYMENT_INFO_TRANSPORT_REDIRECT)) { $this->_redirectUrl = $this->_config->getExpressCheckoutCompleteUrl($token); } @@ -765,7 +763,8 @@ protected function _setBillingAgreementRequest() ->getAdditionalInformation(self::PAYMENT_INFO_TRANSPORT_BILLING_AGREEMENT); if (!($this->_config->allow_ba_signup == Mage_Paypal_Model_Config::EC_BA_SIGNUP_AUTO - || $isRequested && $this->_config->shouldAskToCreateBillingAgreement())) { + || $isRequested && $this->_config->shouldAskToCreateBillingAgreement()) + ) { return $this; } @@ -1019,7 +1018,8 @@ protected function _prepareCustomerQuote() $billing->setCustomerAddress($customerBilling); } if ($shipping && ((!$shipping->getCustomerId() && !$shipping->getSameAsBilling()) - || (!$shipping->getSameAsBilling() && $shipping->getSaveInAddressBook()))) { + || (!$shipping->getSameAsBilling() && $shipping->getSaveInAddressBook())) + ) { $customerShipping = $shipping->exportCustomerAddress(); $customer->addAddress($customerShipping); $shipping->setCustomerAddress($customerShipping); diff --git a/app/code/core/Mage/Paypal/Model/Info.php b/app/code/core/Mage/Paypal/Model/Info.php index 566b70458d1b..85e9c264967d 100644 --- a/app/code/core/Mage/Paypal/Model/Info.php +++ b/app/code/core/Mage/Paypal/Model/Info.php @@ -280,7 +280,8 @@ public static function isPaymentSuccessful(Mage_Payment_Model_Info $payment) if (in_array($paymentStatus, [ self::PAYMENTSTATUS_COMPLETED, self::PAYMENTSTATUS_INPROGRESS, self::PAYMENTSTATUS_REFUNDED, self::PAYMENTSTATUS_REFUNDEDPART, self::PAYMENTSTATUS_UNREVERSED, self::PAYMENTSTATUS_PROCESSED, - ])) { + ]) + ) { return true; } $pendingReason = $payment->getAdditionalInformation(self::PENDING_REASON_GLOBAL); diff --git a/app/code/core/Mage/Paypal/Model/Ipn.php b/app/code/core/Mage/Paypal/Model/Ipn.php index c62c8944db2b..1681f3befe14 100644 --- a/app/code/core/Mage/Paypal/Model/Ipn.php +++ b/app/code/core/Mage/Paypal/Model/Ipn.php @@ -737,7 +737,8 @@ protected function _importPaymentInformation() Mage_Paypal_Model_Info::PROTECTION_EL, Mage_Paypal_Model_Info::PAYMENT_STATUS, Mage_Paypal_Model_Info::PENDING_REASON, - ] as $privateKey => $publicKey) { + ] as $privateKey => $publicKey + ) { if (is_int($privateKey)) { $privateKey = $publicKey; } diff --git a/app/code/core/Mage/Paypal/Model/Method/Agreement.php b/app/code/core/Mage/Paypal/Model/Method/Agreement.php index 3f82445a7b1c..84888c8ffdcc 100644 --- a/app/code/core/Mage/Paypal/Model/Method/Agreement.php +++ b/app/code/core/Mage/Paypal/Model/Method/Agreement.php @@ -163,7 +163,8 @@ public function updateBillingAgreementStatus(Mage_Payment_Model_Billing_Agreemen } catch (Mage_Core_Exception $e) { // when BA was already canceled, just pretend that the operation succeeded if (!(Mage_Sales_Model_Billing_Agreement::STATUS_CANCELED == $targetStatus - && $api->getIsBillingAgreementAlreadyCancelled())) { + && $api->getIsBillingAgreementAlreadyCancelled()) + ) { throw $e; } } diff --git a/app/code/core/Mage/Paypal/Model/Payflowlink.php b/app/code/core/Mage/Paypal/Model/Payflowlink.php index b9f93e886424..d7a0235bce1e 100644 --- a/app/code/core/Mage/Paypal/Model/Payflowlink.php +++ b/app/code/core/Mage/Paypal/Model/Payflowlink.php @@ -527,7 +527,8 @@ protected function _processTokenErrors($response, $payment) { if (!$response->getSecuretoken() && $response->getResult() != self::RESPONSE_CODE_APPROVED && - $response->getResult() != self::RESPONSE_CODE_FRAUDSERVICE_FILTER) { + $response->getResult() != self::RESPONSE_CODE_FRAUDSERVICE_FILTER + ) { Mage::throwException($response->getRespmsg()); } else { $payment->setAdditionalInformation('secure_token_id', $response->getSecuretokenid()) diff --git a/app/code/core/Mage/Paypal/Model/Payflowpro.php b/app/code/core/Mage/Paypal/Model/Payflowpro.php index d0e8ebd8bc40..ddd903f92642 100644 --- a/app/code/core/Mage/Paypal/Model/Payflowpro.php +++ b/app/code/core/Mage/Paypal/Model/Payflowpro.php @@ -539,7 +539,8 @@ protected function _processErrors(Varien_Object $response) if ($response->getResultCode() == self::RESPONSE_CODE_VOID_ERROR) { throw new Mage_Paypal_Exception(Mage::helper('paypal')->__('You cannot void a verification transaction')); } elseif ($response->getResultCode() != self::RESPONSE_CODE_APPROVED - && $response->getResultCode() != self::RESPONSE_CODE_FRAUDSERVICE_FILTER) { + && $response->getResultCode() != self::RESPONSE_CODE_FRAUDSERVICE_FILTER + ) { Mage::throwException($response->getRespmsg()); } } diff --git a/app/code/core/Mage/Paypal/sql/paypal_setup/mysql4-upgrade-0.7.2-0.7.3.php b/app/code/core/Mage/Paypal/sql/paypal_setup/mysql4-upgrade-0.7.2-0.7.3.php index 3897c3ce8fe0..d74b52258856 100644 --- a/app/code/core/Mage/Paypal/sql/paypal_setup/mysql4-upgrade-0.7.2-0.7.3.php +++ b/app/code/core/Mage/Paypal/sql/paypal_setup/mysql4-upgrade-0.7.2-0.7.3.php @@ -29,7 +29,8 @@ foreach ([ 'paypal/wpp/page_style' => 'paypal/style/page_style', 'paypal/wps/logo_url' => 'paypal/style/logo_url', - ] as $from => $to) { + ] as $from => $to +) { $installer->run(" UPDATE {$installer->getTable('core/config_data')} SET `path` = '{$to}' WHERE `path` = '{$from}' diff --git a/app/code/core/Mage/PaypalUk/Block/Express/Shortcut.php b/app/code/core/Mage/PaypalUk/Block/Express/Shortcut.php index 5effec2edf0f..e291585f62c8 100644 --- a/app/code/core/Mage/PaypalUk/Block/Express/Shortcut.php +++ b/app/code/core/Mage/PaypalUk/Block/Express/Shortcut.php @@ -50,14 +50,15 @@ class Mage_PaypalUk_Block_Express_Shortcut extends Mage_Paypal_Block_Express_Sho /** * @param $quote - * - * @return Mage_Paypal_Block_Express_Shortcut + * @return $this */ protected function _getBmlShortcut($quote) { $bml = Mage::helper('payment')->getMethodInstance(Mage_Paypal_Model_Config::METHOD_WPP_PE_BML); $isBmlEnabled = $bml && $bml->isAvailable($quote); - $this->setBmlShortcutHtmlId($this->helper('core')->uniqHash('ec_shortcut_bml_')) + /** @var Mage_Core_Helper_Data $helper */ + $helper = $this->helper('core'); + $this->setBmlShortcutHtmlId($helper->uniqHash('ec_shortcut_bml_')) ->setBmlCheckoutUrl($this->getUrl('paypaluk/bml/start/button/1')) ->setBmlImageUrl('https://www.paypalobjects.com/webstatic/en_US/i/buttons/ppcredit-logo-medium.png') ->setMarketMessage('https://www.paypalobjects.com/webstatic/en_US/btn/btn_bml_text.png') diff --git a/app/code/core/Mage/PaypalUk/Model/Api/Nvp.php b/app/code/core/Mage/PaypalUk/Model/Api/Nvp.php index 89c7ec8f9b9c..258b618eaee0 100644 --- a/app/code/core/Mage/PaypalUk/Model/Api/Nvp.php +++ b/app/code/core/Mage/PaypalUk/Model/Api/Nvp.php @@ -451,8 +451,8 @@ protected function _getPaypalUkActionName($methodName) /** * Map paypal method names * - * @param string| $methodName - * @return string + * @param string $methodName + * @return string|void */ protected function _mapPaypalMethodName($methodName) { diff --git a/app/code/core/Mage/PaypalUk/Model/Express.php b/app/code/core/Mage/PaypalUk/Model/Express.php index d42e4cb9d1ea..ec695d96f2f6 100644 --- a/app/code/core/Mage/PaypalUk/Model/Express.php +++ b/app/code/core/Mage/PaypalUk/Model/Express.php @@ -41,7 +41,7 @@ class Mage_PaypalUk_Model_Express extends Mage_Paypal_Model_Express /** * Express Checkout payment method instance * - * @var Mage_Paypal_Model_Express + * @var Mage_Payment_Model_Method_Abstract|false */ protected $_ecInstance = null; diff --git a/app/code/core/Mage/Persistent/Model/Observer.php b/app/code/core/Mage/Persistent/Model/Observer.php index c3f38c3d5735..cf25d1743120 100644 --- a/app/code/core/Mage/Persistent/Model/Observer.php +++ b/app/code/core/Mage/Persistent/Model/Observer.php @@ -44,7 +44,8 @@ class Mage_Persistent_Model_Observer public function applyPersistentData($observer) { if (!Mage::helper('persistent')->canProcess($observer) - || !$this->_getPersistentHelper()->isPersistent() || Mage::getSingleton('customer/session')->isLoggedIn()) { + || !$this->_getPersistentHelper()->isPersistent() || Mage::getSingleton('customer/session')->isLoggedIn() + ) { return $this; } Mage::getModel('persistent/persistent_config') @@ -169,7 +170,8 @@ public function emulateQuote($observer) ]; if (!Mage::helper('persistent')->canProcess($observer) - || !$this->_getPersistentHelper()->isPersistent() || Mage::getSingleton('customer/session')->isLoggedIn()) { + || !$this->_getPersistentHelper()->isPersistent() || Mage::getSingleton('customer/session')->isLoggedIn() + ) { return; } diff --git a/app/code/core/Mage/ProductAlert/Model/Observer.php b/app/code/core/Mage/ProductAlert/Model/Observer.php index a94e7ba08d04..048e7bce1d9a 100644 --- a/app/code/core/Mage/ProductAlert/Model/Observer.php +++ b/app/code/core/Mage/ProductAlert/Model/Observer.php @@ -102,10 +102,7 @@ protected function _processPrice(Mage_ProductAlert_Model_Email $email) if (!$website->getDefaultGroup() || !$website->getDefaultGroup()->getDefaultStore()) { continue; } - if (!Mage::getStoreConfig( - self::XML_PATH_PRICE_ALLOW, - $website->getDefaultGroup()->getDefaultStore()->getId() - )) { + if (!Mage::getStoreConfig(self::XML_PATH_PRICE_ALLOW, $website->getDefaultGroup()->getDefaultStore()->getId())) { continue; } try { @@ -191,10 +188,7 @@ protected function _processStock(Mage_ProductAlert_Model_Email $email) if (!$website->getDefaultGroup() || !$website->getDefaultGroup()->getDefaultStore()) { continue; } - if (!Mage::getStoreConfig( - self::XML_PATH_STOCK_ALLOW, - $website->getDefaultGroup()->getDefaultStore()->getId() - )) { + if (!Mage::getStoreConfig(self::XML_PATH_STOCK_ALLOW, $website->getDefaultGroup()->getDefaultStore()->getId())) { continue; } try { diff --git a/app/code/core/Mage/ProductAlert/Model/Resource/Price.php b/app/code/core/Mage/ProductAlert/Model/Resource/Price.php index 0d2ecc8268f2..d208d05e35de 100644 --- a/app/code/core/Mage/ProductAlert/Model/Resource/Price.php +++ b/app/code/core/Mage/ProductAlert/Model/Resource/Price.php @@ -42,7 +42,8 @@ protected function _construct() protected function _beforeSave(Mage_Core_Model_Abstract $object) { if (is_null($object->getId()) && $object->getCustomerId() - && $object->getProductId() && $object->getWebsiteId()) { + && $object->getProductId() && $object->getWebsiteId() + ) { if ($row = $this->_getAlertRow($object)) { $price = $object->getPrice(); $object->addData($row); diff --git a/app/code/core/Mage/ProductAlert/Model/Resource/Stock.php b/app/code/core/Mage/ProductAlert/Model/Resource/Stock.php index 8a1b82cea670..c8eb415f5474 100644 --- a/app/code/core/Mage/ProductAlert/Model/Resource/Stock.php +++ b/app/code/core/Mage/ProductAlert/Model/Resource/Stock.php @@ -42,7 +42,8 @@ protected function _construct() protected function _beforeSave(Mage_Core_Model_Abstract $object) { if (is_null($object->getId()) && $object->getCustomerId() - && $object->getProductId() && $object->getWebsiteId()) { + && $object->getProductId() && $object->getWebsiteId() + ) { if ($row = $this->_getAlertRow($object)) { $object->addData($row); $object->setStatus(0); diff --git a/app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php b/app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php index c54cbcde83d0..8e7237a23117 100644 --- a/app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php +++ b/app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php @@ -189,7 +189,8 @@ public function addStoreRestrictions($storeIds) } $currentStoreIds = $this->_storesIds; if (isset($currentStoreIds) && $currentStoreIds != Mage_Core_Model_App::ADMIN_STORE_ID - && $currentStoreIds != [Mage_Core_Model_App::ADMIN_STORE_ID]) { + && $currentStoreIds != [Mage_Core_Model_App::ADMIN_STORE_ID] + ) { if (!is_array($currentStoreIds)) { $currentStoreIds = [$currentStoreIds]; } diff --git a/app/code/core/Mage/Rss/controllers/IndexController.php b/app/code/core/Mage/Rss/controllers/IndexController.php index a52d33a032cc..9566178fec5b 100644 --- a/app/code/core/Mage/Rss/controllers/IndexController.php +++ b/app/code/core/Mage/Rss/controllers/IndexController.php @@ -95,7 +95,8 @@ public function wishlistAction() } if (Mage::getSingleton('customer/session')->authenticate($this) - && $wishlist->getCustomerId() == $this->_getCustomer()->getId()) { + && $wishlist->getCustomerId() == $this->_getCustomer()->getId() + ) { $this->_showWishlistRss(); } else { $this->_forward('nofeed', 'index', 'rss'); diff --git a/app/code/core/Mage/Rule/Model/Condition/Product/Abstract.php b/app/code/core/Mage/Rule/Model/Condition/Product/Abstract.php index 874792d20c84..2495d23a8105 100644 --- a/app/code/core/Mage/Rule/Model/Condition/Product/Abstract.php +++ b/app/code/core/Mage/Rule/Model/Condition/Product/Abstract.php @@ -485,7 +485,8 @@ public function loadArray($arr) if (isset($arr['value'])) { if (!empty($arr['operator']) && in_array($arr['operator'], ['!()', '()']) - && strpos($arr['value'], ',') !== false) { + && strpos($arr['value'], ',') !== false + ) { $tmp = []; foreach (explode(',', $arr['value']) as $value) { $tmp[] = Mage::app()->getLocale()->getNumber($value); diff --git a/app/code/core/Mage/Sales/Block/Recurring/Profile/View.php b/app/code/core/Mage/Sales/Block/Recurring/Profile/View.php index 02f88fe6175f..adacf62f3200 100644 --- a/app/code/core/Mage/Sales/Block/Recurring/Profile/View.php +++ b/app/code/core/Mage/Sales/Block/Recurring/Profile/View.php @@ -110,7 +110,8 @@ public function prepareItemInfo() foreach (['name' => Mage::helper('catalog')->__('Product Name'), 'sku' => Mage::helper('catalog')->__('SKU'), 'qty' => Mage::helper('catalog')->__('Quantity'), - ] as $itemKey => $label) { + ] as $itemKey => $label + ) { $value = $this->_profile->getInfoValue($key, $itemKey); if ($value) { $this->_addInfo(['label' => $label, 'value' => $value,]); @@ -207,7 +208,8 @@ public function prepareFeesInfo() 'billing_amount', 'tax_amount', 'shipping_amount' - ] as $key) { + ] as $key + ) { $value = $this->_profile->getData($key); if ($value) { $this->_addInfo([ diff --git a/app/code/core/Mage/Sales/Helper/Guest.php b/app/code/core/Mage/Sales/Helper/Guest.php index 950a60d8fcf8..26f97471dbe6 100644 --- a/app/code/core/Mage/Sales/Helper/Guest.php +++ b/app/code/core/Mage/Sales/Helper/Guest.php @@ -68,7 +68,8 @@ public function loadValidOrder() $zip = $post['oar_zip']; if (empty($incrementId) || empty($lastName) || empty($type) || (!in_array($type, ['email', 'zip'])) - || ($type == 'email' && empty($email)) || ($type == 'zip' && empty($zip))) { + || ($type == 'email' && empty($email)) || ($type == 'zip' && empty($zip)) + ) { $errors = true; } diff --git a/app/code/core/Mage/Sales/Model/Api/Resource.php b/app/code/core/Mage/Sales/Model/Api/Resource.php index 86b47a384ddb..da78182dbef8 100644 --- a/app/code/core/Mage/Sales/Model/Api/Resource.php +++ b/app/code/core/Mage/Sales/Model/Api/Resource.php @@ -114,7 +114,8 @@ protected function _getAttributes($object, $type, array $attributes = null) protected function _isAllowedAttribute($attributeCode, $type, array $attributes = null) { if (!empty($attributes) - && !(in_array($attributeCode, $attributes))) { + && !(in_array($attributeCode, $attributes)) + ) { return false; } @@ -123,7 +124,8 @@ protected function _isAllowedAttribute($attributeCode, $type, array $attributes } if (isset($this->_ignoredAttributeCodes[$type]) - && in_array($attributeCode, $this->_ignoredAttributeCodes[$type])) { + && in_array($attributeCode, $this->_ignoredAttributeCodes[$type]) + ) { return false; } diff --git a/app/code/core/Mage/Sales/Model/Order.php b/app/code/core/Mage/Sales/Model/Order.php index 9fe059f5a9dd..2b42ba173d7f 100644 --- a/app/code/core/Mage/Sales/Model/Order.php +++ b/app/code/core/Mage/Sales/Model/Order.php @@ -759,7 +759,8 @@ public function canHold() { $state = $this->getState(); if ($this->isCanceled() || $this->isPaymentReview() - || $state === self::STATE_COMPLETE || $state === self::STATE_CLOSED || $state === self::STATE_HOLDED) { + || $state === self::STATE_COMPLETE || $state === self::STATE_CLOSED || $state === self::STATE_HOLDED + ) { return false; } @@ -816,7 +817,8 @@ public function canShip() foreach ($this->getAllItems() as $item) { if ($item->getQtyToShip() > 0 && !$item->getIsVirtual() - && !$item->getLockedDoShip()) { + && !$item->getLockedDoShip() + ) { return true; } } @@ -836,7 +838,8 @@ public function canEdit() $state = $this->getState(); if ($this->isCanceled() || $this->isPaymentReview() - || $state === self::STATE_COMPLETE || $state === self::STATE_CLOSED) { + || $state === self::STATE_COMPLETE || $state === self::STATE_CLOSED + ) { return false; } @@ -2356,7 +2359,8 @@ protected function _checkState() if (!$this->isCanceled() && !$this->canUnhold() && !$this->canInvoice() - && !$this->canShip()) { + && !$this->canShip() + ) { if ($this->getBaseGrandTotal() == 0 || $this->canCreditmemo()) { if ($this->getState() !== self::STATE_COMPLETE) { $this->_setState(self::STATE_COMPLETE, true, '', $userNotification); diff --git a/app/code/core/Mage/Sales/Model/Order/Creditmemo/Item.php b/app/code/core/Mage/Sales/Model/Order/Creditmemo/Item.php index d502ced22f2e..b1fe792f91e3 100644 --- a/app/code/core/Mage/Sales/Model/Order/Creditmemo/Item.php +++ b/app/code/core/Mage/Sales/Model/Order/Creditmemo/Item.php @@ -301,7 +301,8 @@ public function isLast() { $orderItem = $this->getOrderItem(); if ((string)(float)$this->getQty() == (string)(float)$orderItem->getQtyToRefund() - && !$orderItem->getQtyToInvoice()) { + && !$orderItem->getQtyToInvoice() + ) { return true; } return false; diff --git a/app/code/core/Mage/Sales/Model/Order/Item.php b/app/code/core/Mage/Sales/Model/Order/Item.php index 721dd6047949..9fb28bfd1a9c 100644 --- a/app/code/core/Mage/Sales/Model/Order/Item.php +++ b/app/code/core/Mage/Sales/Model/Order/Item.php @@ -693,7 +693,8 @@ public function isChildrenCalculated() } if (isset($options['product_calculations']) && - $options['product_calculations'] == Mage_Catalog_Model_Product_Type_Abstract::CALCULATE_CHILD) { + $options['product_calculations'] == Mage_Catalog_Model_Product_Type_Abstract::CALCULATE_CHILD + ) { return true; } return false; @@ -729,7 +730,8 @@ public function isShipSeparately() } if (isset($options['shipment_type']) && - $options['shipment_type'] == Mage_Catalog_Model_Product_Type_Abstract::SHIPMENT_SEPARATELY) { + $options['shipment_type'] == Mage_Catalog_Model_Product_Type_Abstract::SHIPMENT_SEPARATELY + ) { return true; } return false; diff --git a/app/code/core/Mage/Sales/Model/Order/Payment.php b/app/code/core/Mage/Sales/Model/Order/Payment.php index c66a9ad36fcd..0fad4ab33fef 100644 --- a/app/code/core/Mage/Sales/Model/Order/Payment.php +++ b/app/code/core/Mage/Sales/Model/Order/Payment.php @@ -1209,7 +1209,8 @@ protected function _void($isOnline, $amount = null, $gatewayCallback = 'void') // if the authorization was untouched, we may assume voided amount = order grand total // but only if the payment auth amount equals to order grand total if ($authTransaction && ($order->getBaseGrandTotal() == $this->getBaseAmountAuthorized()) - && ($this->getBaseAmountCanceled() == 0)) { + && ($this->getBaseAmountCanceled() == 0) + ) { if ($authTransaction->canVoidAuthorizationCompletely()) { $amount = (float)$order->getBaseGrandTotal(); } diff --git a/app/code/core/Mage/Sales/Model/Quote.php b/app/code/core/Mage/Sales/Model/Quote.php index 4939a200cfed..31ae1b7bc433 100644 --- a/app/code/core/Mage/Sales/Model/Quote.php +++ b/app/code/core/Mage/Sales/Model/Quote.php @@ -625,7 +625,8 @@ public function getAllShippingAddresses() $addresses = []; foreach ($this->getAddressesCollection() as $address) { if ($address->getAddressType() == Mage_Sales_Model_Quote_Address::TYPE_SHIPPING - && !$address->isDeleted()) { + && !$address->isDeleted() + ) { $addresses[] = $address; } } @@ -683,7 +684,8 @@ public function getShippingAddressByCustomerAddressId($addressId) { foreach ($this->getAddressesCollection() as $address) { if (!$address->isDeleted() && $address->getAddressType() == Mage_Sales_Model_Quote_Address::TYPE_SHIPPING - && $address->getCustomerAddressId() == $addressId) { + && $address->getCustomerAddressId() == $addressId + ) { return $address; } } @@ -871,7 +873,8 @@ public function hasItemsWithDecimalQty() { foreach ($this->getAllItems() as $item) { if ($item->getProduct()->getStockItem() - && $item->getProduct()->getStockItem()->getIsQtyDecimal()) { + && $item->getProduct()->getStockItem()->getIsQtyDecimal() + ) { return true; } } diff --git a/app/code/core/Mage/Sales/Model/Quote/Address/Total/Msrp.php b/app/code/core/Mage/Sales/Model/Quote/Address/Total/Msrp.php index 6351c42bbb15..17c36b4374d7 100644 --- a/app/code/core/Mage/Sales/Model/Quote/Address/Total/Msrp.php +++ b/app/code/core/Mage/Sales/Model/Quote/Address/Total/Msrp.php @@ -48,11 +48,13 @@ public function collect(Mage_Sales_Model_Quote_Address $address) $canApplyMsrp = false; foreach ($items as $item) { - if (!$item->getParentItemId() && Mage::helper('catalog')->canApplyMsrp( - $item->getProductId(), - Mage_Catalog_Model_Product_Attribute_Source_Msrp_Type::TYPE_BEFORE_ORDER_CONFIRM, - true - )) { + if (!$item->getParentItemId() + && Mage::helper('catalog')->canApplyMsrp( + $item->getProductId(), + Mage_Catalog_Model_Product_Attribute_Source_Msrp_Type::TYPE_BEFORE_ORDER_CONFIRM, + true + ) + ) { $canApplyMsrp = true; break; } diff --git a/app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php b/app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php index 9fb5570348fa..f93bc709807a 100644 --- a/app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php +++ b/app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php @@ -742,7 +742,8 @@ public function isShipSeparately() } if (($shipmentType !== null) && - (int)$shipmentType === Mage_Catalog_Model_Product_Type_Abstract::SHIPMENT_SEPARATELY) { + (int)$shipmentType === Mage_Catalog_Model_Product_Type_Abstract::SHIPMENT_SEPARATELY + ) { return true; } return false; diff --git a/app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php b/app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php index 795f2ec239aa..1137d9ea078e 100644 --- a/app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php +++ b/app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php @@ -190,7 +190,8 @@ public function addStoreRestrictions($storeIds) } $currentStoreIds = $this->_storesIds; if (isset($currentStoreIds) && $currentStoreIds != Mage_Core_Model_App::ADMIN_STORE_ID - && $currentStoreIds != [Mage_Core_Model_App::ADMIN_STORE_ID]) { + && $currentStoreIds != [Mage_Core_Model_App::ADMIN_STORE_ID] + ) { if (!is_array($currentStoreIds)) { $currentStoreIds = [$currentStoreIds]; } @@ -220,7 +221,7 @@ protected function _beforeLoad() // apply date boundaries (before calling $this->_applyDateRangeFilter()) $dtFormat = Varien_Date::DATE_INTERNAL_FORMAT; $periodFrom = (!is_null($this->_from) ? new Zend_Date($this->_from, $dtFormat) : null); - $periodTo = (!is_null($this->_to) ? new Zend_Date($this->_to, $dtFormat) : null); + $periodTo = (!is_null($this->_to) ? new Zend_Date($this->_to, $dtFormat) : null); if ($this->_period == 'year') { if ($periodFrom) { // not the first day of the year diff --git a/app/code/core/Mage/Sales/Model/Resource/Setup.php b/app/code/core/Mage/Sales/Model/Resource/Setup.php index 87a27eebdbc1..582fc89016b7 100644 --- a/app/code/core/Mage/Sales/Model/Resource/Setup.php +++ b/app/code/core/Mage/Sales/Model/Resource/Setup.php @@ -92,7 +92,8 @@ protected function _flatTableExist($table) public function addAttribute($entityTypeId, $code, array $attr) { if (isset($this->_flatEntityTables[$entityTypeId]) && - $this->_flatTableExist($this->_flatEntityTables[$entityTypeId])) { + $this->_flatTableExist($this->_flatEntityTables[$entityTypeId]) + ) { $this->_addFlatAttribute($this->_flatEntityTables[$entityTypeId], $code, $attr); $this->_addGridAttribute($this->_flatEntityTables[$entityTypeId], $code, $attr, $entityTypeId); } else { diff --git a/app/code/core/Mage/Sales/Model/Service/Order.php b/app/code/core/Mage/Sales/Model/Service/Order.php index f1679352ca96..9ac8e69d07f5 100644 --- a/app/code/core/Mage/Sales/Model/Service/Order.php +++ b/app/code/core/Mage/Sales/Model/Service/Order.php @@ -266,7 +266,8 @@ public function prepareInvoiceCreditmemo($invoice, $data = []) $invoiceQtysRefunded = []; foreach ($invoice->getOrder()->getCreditmemosCollection() as $createdCreditmemo) { if ($createdCreditmemo->getState() != Mage_Sales_Model_Order_Creditmemo::STATE_CANCELED - && $createdCreditmemo->getInvoiceId() == $invoice->getId()) { + && $createdCreditmemo->getInvoiceId() == $invoice->getId() + ) { foreach ($createdCreditmemo->getAllItems() as $createdCreditmemoItem) { $orderItemId = $createdCreditmemoItem->getOrderItem()->getId(); if (isset($invoiceQtysRefunded[$orderItemId])) { diff --git a/app/code/core/Mage/Sales/sql/sales_setup/mysql4-upgrade-1.3.99-1.4.0.0.php b/app/code/core/Mage/Sales/sql/sales_setup/mysql4-upgrade-1.3.99-1.4.0.0.php index 2056383d63e9..8844f79419c6 100644 --- a/app/code/core/Mage/Sales/sql/sales_setup/mysql4-upgrade-1.3.99-1.4.0.0.php +++ b/app/code/core/Mage/Sales/sql/sales_setup/mysql4-upgrade-1.3.99-1.4.0.0.php @@ -832,7 +832,8 @@ if (!isset($flatFields[$code]) && !in_array($code, $excludeAttributes['all']) && (!isset($excludeAttributes[$entityCode]) || - !in_array($code, $excludeAttributes[$entityCode]))) { + !in_array($code, $excludeAttributes[$entityCode])) + ) { $installer->getConnection()->addColumn( $installer->getTable($flatTablePrefix), $code, @@ -870,7 +871,8 @@ isset($definitions[$attribute['type']]) && !in_array($attributeCode, $excludeAttributes['all']) && (!isset($excludeAttributes[$entityCode]) || - !in_array($attributeCode, $excludeAttributes[$entityCode]))) { + !in_array($attributeCode, $excludeAttributes[$entityCode])) + ) { $installer->getConnection()->addColumn( $installer->getTable($flatTablePrefix), $attributeCode, diff --git a/app/code/core/Mage/Sales/sql/sales_setup/mysql4-upgrade-1.4.0.21-1.4.0.22.php b/app/code/core/Mage/Sales/sql/sales_setup/mysql4-upgrade-1.4.0.21-1.4.0.22.php index d2a08f518112..eeb5a03defc5 100644 --- a/app/code/core/Mage/Sales/sql/sales_setup/mysql4-upgrade-1.4.0.21-1.4.0.22.php +++ b/app/code/core/Mage/Sales/sql/sales_setup/mysql4-upgrade-1.4.0.21-1.4.0.22.php @@ -25,7 +25,8 @@ foreach ([ 'sales/order', 'sales/order_grid', 'sales/creditmemo', 'sales/creditmemo_grid', 'sales/invoice', 'sales/invoice_grid', 'sales/shipment','sales/shipment_grid', - ] as $table) { + ] as $table +) { $tableName = $installer->getTable($table); $installer->getConnection()->dropKey($tableName, 'IDX_INCREMENT_ID'); $installer->getConnection()->addKey($tableName, 'UNQ_INCREMENT_ID', 'increment_id', 'unique'); diff --git a/app/code/core/Mage/SalesRule/Model/Resource/Rule.php b/app/code/core/Mage/SalesRule/Model/Resource/Rule.php index f6b9b2be2d5d..e5ae163e9aff 100644 --- a/app/code/core/Mage/SalesRule/Model/Resource/Rule.php +++ b/app/code/core/Mage/SalesRule/Model/Resource/Rule.php @@ -300,11 +300,7 @@ public function setActualProductAttributes($rule, $attributes) public function getProductAttributes($serializedString) { $result = []; - if (preg_match_all( - '~s:32:"salesrule/rule_condition_product";s:9:"attribute";s:\d+:"(.*?)"~s', - $serializedString, - $matches - )) { + if (preg_match_all('~s:32:"salesrule/rule_condition_product";s:9:"attribute";s:\d+:"(.*?)"~s', $serializedString, $matches)) { foreach ($matches[1] as $offset => $attributeCode) { $result[] = $attributeCode; } diff --git a/app/code/core/Mage/SalesRule/Model/Validator.php b/app/code/core/Mage/SalesRule/Model/Validator.php index bf787a61d5cd..393a04df3cbe 100644 --- a/app/code/core/Mage/SalesRule/Model/Validator.php +++ b/app/code/core/Mage/SalesRule/Model/Validator.php @@ -896,7 +896,8 @@ public function initTotals($items, Mage_Sales_Model_Quote_Address $address) foreach ($this->_getRules() as $rule) { if (Mage_SalesRule_Model_Rule::CART_FIXED_ACTION === $rule->getSimpleAction() - && $this->_canProcessRule($rule, $address)) { + && $this->_canProcessRule($rule, $address) + ) { $ruleTotalItemsPrice = 0; $ruleTotalBaseItemsPrice = 0; $validItemsCount = 0; @@ -1054,7 +1055,7 @@ public function prepareDescription($address, $separator = ', ') $description = $descriptionArray && is_array($descriptionArray) ? implode($separator, array_unique($descriptionArray)) - : ''; + : ''; $address->setDiscountDescription($description); return $this; diff --git a/app/code/core/Mage/Sendfriend/Model/Sendfriend.php b/app/code/core/Mage/Sendfriend/Model/Sendfriend.php index 1bc68e362702..9eaae3770f40 100644 --- a/app/code/core/Mage/Sendfriend/Model/Sendfriend.php +++ b/app/code/core/Mage/Sendfriend/Model/Sendfriend.php @@ -292,7 +292,8 @@ public function setRecipients($recipients) // validate array if (!is_array($recipients) || !isset($recipients['email']) || !isset($recipients['name']) || !is_array($recipients['email']) - || !is_array($recipients['name'])) { + || !is_array($recipients['name']) + ) { return $this; } diff --git a/app/code/core/Mage/Tag/Model/Api.php b/app/code/core/Mage/Tag/Model/Api.php index 48bd095501e2..ea76e46c795a 100644 --- a/app/code/core/Mage/Tag/Model/Api.php +++ b/app/code/core/Mage/Tag/Model/Api.php @@ -169,7 +169,8 @@ public function update($tagId, $data, $store) if (isset($data['status'])) { // validate tag status if (!in_array($data['status'], [ - $tag->getApprovedStatus(), $tag->getPendingStatus(), $tag->getDisabledStatus()])) { + $tag->getApprovedStatus(), $tag->getPendingStatus(), $tag->getDisabledStatus()]) + ) { $this->_fault('invalid_data'); } $tag->setStatus($data['status']); @@ -215,7 +216,8 @@ public function remove($tagId) protected function _prepareDataForAdd($data) { if (!isset($data['product_id']) || !isset($data['tag']) - || !isset($data['customer_id']) || !isset($data['store'])) { + || !isset($data['customer_id']) || !isset($data['store']) + ) { $this->_fault('invalid_data'); } diff --git a/app/code/core/Mage/Tag/Model/Resource/Tag.php b/app/code/core/Mage/Tag/Model/Resource/Tag.php index aaa09255a0fe..7b7ad0c066cf 100644 --- a/app/code/core/Mage/Tag/Model/Resource/Tag.php +++ b/app/code/core/Mage/Tag/Model/Resource/Tag.php @@ -85,7 +85,8 @@ protected function _beforeSave(Mage_Core_Model_Abstract $object) $searchTag = new Varien_Object(); $this->loadByName($searchTag, $object->getName()); if ($searchTag->getData($this->getIdFieldName()) - && $searchTag->getStatus() == $object->getPendingStatus()) { + && $searchTag->getStatus() == $object->getPendingStatus() + ) { $object->setId($searchTag->getData($this->getIdFieldName())); } } diff --git a/app/code/core/Mage/Tag/Model/Resource/Tag/Collection.php b/app/code/core/Mage/Tag/Model/Resource/Tag/Collection.php index 9414ea557d55..574de4e0a826 100644 --- a/app/code/core/Mage/Tag/Model/Resource/Tag/Collection.php +++ b/app/code/core/Mage/Tag/Model/Resource/Tag/Collection.php @@ -265,10 +265,9 @@ public function addFieldToFilter($field, $condition = null) $this->getSelect()->having( $this->_getConditionSql('COUNT(relation.tag_relation_id)', $condition) ); - } elseif ($this->getFlag('summary') && in_array( - $field, - ['customers', 'products', 'uses', 'historical_uses', 'popularity'] - )) { + } elseif ($this->getFlag('summary') + && in_array($field, ['customers', 'products', 'uses', 'historical_uses', 'popularity']) + ) { $this->getSelect()->where($this->_getConditionSql('summary.' . $field, $condition)); } else { parent::addFieldToFilter($field, $condition); diff --git a/app/code/core/Mage/Usa/Helper/Data.php b/app/code/core/Mage/Usa/Helper/Data.php index 926d20454291..8abe5ed99bdd 100644 --- a/app/code/core/Mage/Usa/Helper/Data.php +++ b/app/code/core/Mage/Usa/Helper/Data.php @@ -126,7 +126,8 @@ public function displayGirthValue($shippingMethod) 'usps_INT_16', // Priority Mail International Small Flat Rate Box 'usps_INT_20', // Priority Mail International Small Flat Rate Envelope 'usps_INT_26', // Priority Mail Express International Flat Rate Boxes - ])) { + ]) + ) { return true; } else { return false; diff --git a/app/code/core/Mage/Usa/Model/Shipping/Carrier/Ups.php b/app/code/core/Mage/Usa/Model/Shipping/Carrier/Ups.php index 96b39eba0450..2e0bb50dfb48 100644 --- a/app/code/core/Mage/Usa/Model/Shipping/Carrier/Ups.php +++ b/app/code/core/Mage/Usa/Model/Shipping/Carrier/Ups.php @@ -1521,7 +1521,8 @@ protected function _formShipmentRequest(Varien_Object $request) && ( $request->getRecipientAddressCountryCode() == 'CA' //Canada || $request->getRecipientAddressCountryCode() == 'PR' //Puerto Rico - )) { + ) + ) { $invoiceLineTotalPart = $shipmentPart->addChild('InvoiceLineTotal'); $invoiceLineTotalPart->addChild('CurrencyCode', $request->getBaseCurrencyCode()); $invoiceLineTotalPart->addChild('MonetaryValue', ceil($packageParams->getCustomsValue())); @@ -1681,7 +1682,6 @@ public function getContainerTypes(Varien_Object $params = null) if ($method == '07' // Worldwide Express || $method == '08' // Worldwide Expedited || $method == '65' // Worldwide Saver - ) { // Worldwide Expedited if ($method != '08') { @@ -1705,7 +1705,8 @@ public function getContainerTypes(Varien_Object $params = null) $method == '03' // UPS Ground || $method == '02' // UPS Second Day Air || $method == '01' // UPS Next Day Air - )) { + ) + ) { // Container types should be the same as for domestic $params->setCountryRecipient(self::USA_COUNTRY_ID); $containerTypes = $this->_getAllowedContainers($params); diff --git a/app/code/core/Mage/Weee/Model/Total/Quote/Weee.php b/app/code/core/Mage/Weee/Model/Total/Quote/Weee.php index 41eae416174e..5245afebaab0 100644 --- a/app/code/core/Mage/Weee/Model/Total/Quote/Weee.php +++ b/app/code/core/Mage/Weee/Model/Total/Quote/Weee.php @@ -303,7 +303,8 @@ protected function _processTaxSettings($item, $value, $baseValue, $rowValue, $ba ->unsBasePriceInclTax(); } if ($this->_helper->isTaxable($this->_store) - && !$this->_helper->isTaxIncluded($this->_store) && $rowValue) { + && !$this->_helper->isTaxIncluded($this->_store) && $rowValue + ) { if (!$this->_helper->includeInSubtotal($this->_store)) { $item->setExtraTaxableAmount($value) ->setBaseExtraTaxableAmount($baseValue) diff --git a/app/code/core/Mage/Widget/Model/Widget/Instance.php b/app/code/core/Mage/Widget/Model/Widget/Instance.php index 7819939cf527..b47e2c13361a 100644 --- a/app/code/core/Mage/Widget/Model/Widget/Instance.php +++ b/app/code/core/Mage/Widget/Model/Widget/Instance.php @@ -502,7 +502,8 @@ public function generateLayoutUpdateXml($blockReference, $templatePath = '') '_theme' => $this->getTheme() ]); if (!$this->getId() && !$this->isCompleteToCreate() - || ($templatePath && !is_readable($templateFilename))) { + || ($templatePath && !is_readable($templateFilename)) + ) { return ''; } $parameters = $this->getWidgetParameters(); diff --git a/app/code/core/Mage/Wishlist/Helper/Data.php b/app/code/core/Mage/Wishlist/Helper/Data.php index bbc47406d692..c3d778e161a1 100644 --- a/app/code/core/Mage/Wishlist/Helper/Data.php +++ b/app/code/core/Mage/Wishlist/Helper/Data.php @@ -169,7 +169,8 @@ public function getItemCount() if (!$this->_getCustomerSession()->hasWishlistItemCount() || ($currentDisplayType != $storedDisplayType) || $this->_getCustomerSession()->hasDisplayOutOfStockProducts() - || ($currentDisplayOutOfStockProducts != $storedDisplayOutOfStockProducts)) { + || ($currentDisplayOutOfStockProducts != $storedDisplayOutOfStockProducts) + ) { $this->calculate(); } diff --git a/app/code/core/Mage/Wishlist/Model/Item.php b/app/code/core/Mage/Wishlist/Model/Item.php index 358efe468b0a..2a97058cb9b4 100644 --- a/app/code/core/Mage/Wishlist/Model/Item.php +++ b/app/code/core/Mage/Wishlist/Model/Item.php @@ -552,7 +552,8 @@ public function compareOptions($options1, $options2) } if (!isset($options2[$code]) || ($options2[$code]->getValue() === null) - || $options2[$code]->getValue() != $option->getValue()) { + || $options2[$code]->getValue() != $option->getValue() + ) { return false; } } diff --git a/app/code/core/Mage/Wishlist/Model/Wishlist.php b/app/code/core/Mage/Wishlist/Model/Wishlist.php index 52837fbac2d5..346a187093a5 100644 --- a/app/code/core/Mage/Wishlist/Model/Wishlist.php +++ b/app/code/core/Mage/Wishlist/Model/Wishlist.php @@ -572,7 +572,8 @@ public function updateItem($itemId, $buyRequest, $params = null) /** @var Mage_Wishlist_Model_Item $_item */ if ($_item->getProductId() == $product->getId() && $_item->representProduct($product) - && $_item->getId() != $item->getId()) { + && $_item->getId() != $item->getId() + ) { // We do not add new wishlist item, but updating the existing one $isForceSetQuantity = false; } diff --git a/composer.json b/composer.json index b218dde793ca..381a2c293d7a 100644 --- a/composer.json +++ b/composer.json @@ -31,7 +31,7 @@ "magento-ecg/coding-standard": "^4.5", "phpcompatibility/php-compatibility": "^9.3", "phpmd/phpmd": "^2.13", - "phpstan/phpstan": "^1.8.10", + "phpstan/phpstan": "^1.9.2", "phpunit/phpunit": "^9.5", "squizlabs/php_codesniffer": "^3.7" }, diff --git a/composer.lock b/composer.lock index 6b917e6eb333..f303bcb1a4a7 100644 --- a/composer.lock +++ b/composer.lock @@ -4,7 +4,7 @@ "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies", "This file is @generated automatically" ], - "content-hash": "932d727fb422621b11ccae92764ca2ae", + "content-hash": "eadec3d254ea631fecce240761e65937", "packages": [ { "name": "eloquent/enumeration", @@ -2320,16 +2320,16 @@ }, { "name": "phpstan/phpstan", - "version": "1.8.10", + "version": "1.9.2", "source": { "type": "git", "url": "https://github.com/phpstan/phpstan.git", - "reference": "0c4459dc42c568b818b3f25186589f3acddc1823" + "reference": "d6fdf01c53978b6429f1393ba4afeca39cc68afa" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/phpstan/phpstan/zipball/0c4459dc42c568b818b3f25186589f3acddc1823", - "reference": "0c4459dc42c568b818b3f25186589f3acddc1823", + "url": "https://api.github.com/repos/phpstan/phpstan/zipball/d6fdf01c53978b6429f1393ba4afeca39cc68afa", + "reference": "d6fdf01c53978b6429f1393ba4afeca39cc68afa", "shasum": "" }, "require": { @@ -2359,7 +2359,7 @@ ], "support": { "issues": "https://github.com/phpstan/phpstan/issues", - "source": "https://github.com/phpstan/phpstan/tree/1.8.10" + "source": "https://github.com/phpstan/phpstan/tree/1.9.2" }, "funding": [ { @@ -2375,7 +2375,7 @@ "type": "tidelift" } ], - "time": "2022-10-17T14:23:35+00:00" + "time": "2022-11-10T09:56:11+00:00" }, { "name": "phpunit/php-code-coverage", diff --git a/cron.php b/cron.php index 148fab70e25a..d52a0879bc0b 100644 --- a/cron.php +++ b/cron.php @@ -59,7 +59,7 @@ } else { Mage::throwException('Unrecognized cron mode was defined'); } - } else if (!$isShellDisabled) { + } elseif (!$isShellDisabled) { $fileName = escapeshellarg(basename(__FILE__)); $cronPath = escapeshellarg(__DIR__ . '/cron.sh'); diff --git a/get.php b/get.php index 530305e15fc9..5a8c332be165 100644 --- a/get.php +++ b/get.php @@ -18,7 +18,7 @@ * @copyright Copyright (c) 2016-2022 The OpenMage Contributors (https://www.openmage.org) * @license https://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0) */ -if (version_compare(phpversion(), '7.3.0', '<')===true) { +if (version_compare(phpversion(), '7.3.0', '<') === true) { echo '

Whoops, it looks like you have an invalid PHP version.' @@ -61,7 +61,7 @@ $configCacheFile = $varDirectory . $ds . 'resource_config.json'; $mediaDirectory = null; -$allowedResources = array(); +$allowedResources = []; if (file_exists($configCacheFile) && is_readable($configCacheFile)) { $config = json_decode(file_get_contents($configCacheFile), true); @@ -100,10 +100,10 @@ umask(0); /* Store or website code */ -$mageRunCode = isset($_SERVER['MAGE_RUN_CODE']) ? $_SERVER['MAGE_RUN_CODE'] : ''; +$mageRunCode = $_SERVER['MAGE_RUN_CODE'] ?? ''; /* Run store or run website */ -$mageRunType = isset($_SERVER['MAGE_RUN_TYPE']) ? $_SERVER['MAGE_RUN_TYPE'] : 'store'; +$mageRunType = $_SERVER['MAGE_RUN_TYPE'] ?? 'store'; if (empty($mediaDirectory)) { Mage::init($mageRunCode, $mageRunType); @@ -111,8 +111,8 @@ Mage::init( $mageRunCode, $mageRunType, - array('cache' => array('disallow_save' => true)), - isset($config['loaded_modules']) ? $config['loaded_modules'] : ['Mage_Core'] + ['cache' => ['disallow_save' => true]], + $config['loaded_modules'] ?? ['Mage_Core'] ); } diff --git a/index.php b/index.php index dfb0bf13c44b..c3219b8c6e67 100644 --- a/index.php +++ b/index.php @@ -19,7 +19,7 @@ * @license https://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0) */ -if (version_compare(phpversion(), '7.3.0', '<')===true) { +if (version_compare(phpversion(), '7.3.0', '<') === true) { echo '

@@ -42,7 +42,7 @@ if (is_dir('downloader')) { header("Location: downloader"); } else { - echo $mageFilename." was not found"; + echo $mageFilename . " was not found"; } exit; } @@ -55,10 +55,10 @@ umask(0); /* Store or website code */ -$mageRunCode = isset($_SERVER['MAGE_RUN_CODE']) ? $_SERVER['MAGE_RUN_CODE'] : ''; +$mageRunCode = $_SERVER['MAGE_RUN_CODE'] ?? ''; /* Run store or run website */ -$mageRunType = isset($_SERVER['MAGE_RUN_TYPE']) ? $_SERVER['MAGE_RUN_TYPE'] : 'store'; +$mageRunType = $_SERVER['MAGE_RUN_TYPE'] ?? 'store'; if (file_exists($maintenanceFile)) { $maintenanceBypass = false; diff --git a/install.php b/install.php index 9e46c7e97986..4cccd8b8c600 100644 --- a/install.php +++ b/install.php @@ -113,28 +113,27 @@ * */ -if (version_compare(phpversion(), '7.3.0', '<')===true) { +if (version_compare(phpversion(), '7.3.0', '<') === true) { die('ERROR: Whoops, it looks like you have an invalid PHP version. OpenMage supports PHP 7.3.0 or newer.'); } set_include_path(__DIR__ . PATH_SEPARATOR . get_include_path()); require 'app/bootstrap.php'; require 'app/Mage.php'; -try { - $app = Mage::app('default'); +$app = Mage::app('default'); - $installer = Mage::getSingleton('install/installer_console'); - /* @var $installer Mage_Install_Model_Installer_Console */ +/** @var Mage_Install_Model_Installer_Console $installer */ +$installer = Mage::getSingleton('install/installer_console'); +try { if ($installer->init($app) // initialize installer && $installer->checkConsole() // check if the script is run in shell, otherwise redirect to web-installer && $installer->setArgs() // set and validate script arguments - && $installer->install()) // do install - { + && $installer->install() // do install + ) { echo 'SUCCESS: ' . $installer->getEncryptionKey() . "\n"; exit; } - } catch (Exception $e) { Mage::printException($e); } diff --git a/lib/Mage/Archive/Helper/File.php b/lib/Mage/Archive/Helper/File.php index 09d3a27f5fa4..8035bc8b7cde 100644 --- a/lib/Mage/Archive/Helper/File.php +++ b/lib/Mage/Archive/Helper/File.php @@ -72,8 +72,8 @@ public function __construct($filePath) $pathInfo = pathinfo($filePath); $this->_filePath = $filePath; - $this->_fileLocation = isset($pathInfo['dirname']) ? $pathInfo['dirname'] : ''; - $this->_fileName = isset($pathInfo['basename']) ? $pathInfo['basename'] : ''; + $this->_fileLocation = $pathInfo['dirname'] ?? ''; + $this->_fileName = $pathInfo['basename'] ?? ''; } /** diff --git a/lib/Magento/Db/Adapter/Pdo/Mysql.php b/lib/Magento/Db/Adapter/Pdo/Mysql.php index fed8d7822383..b6c0dd238d45 100644 --- a/lib/Magento/Db/Adapter/Pdo/Mysql.php +++ b/lib/Magento/Db/Adapter/Pdo/Mysql.php @@ -131,9 +131,10 @@ public function quote($value, $type = null) { $this->_connect(); - if ($type !== null && - array_key_exists($type = strtoupper($type), $this->_numericDataTypes) && - $this->_numericDataTypes[$type] == Zend_Db::FLOAT_TYPE) { + if ($type !== null + && rray_key_exists($type = strtoupper($type), $this->_numericDataTypes) + && $this->_numericDataTypes[$type] == Zend_Db::FLOAT_TYPE + ) { $value = $this->_convertFloat($value); $quoteValue = sprintf('%F', $value); return $quoteValue; diff --git a/lib/Varien/Data/Collection/Filesystem.php b/lib/Varien/Data/Collection/Filesystem.php index b9c65807b1ff..5165c0fa6a9a 100644 --- a/lib/Varien/Data/Collection/Filesystem.php +++ b/lib/Varien/Data/Collection/Filesystem.php @@ -250,7 +250,8 @@ protected function _collectRecursive($dir) } } elseif ($this->_collectFiles && is_file($item) && (!$this->_allowedFilesMask || preg_match($this->_allowedFilesMask, basename($item))) - && (!$this->_disallowedFilesMask || !preg_match($this->_disallowedFilesMask, basename($item)))) { + && (!$this->_disallowedFilesMask || !preg_match($this->_disallowedFilesMask, basename($item))) + ) { $this->_collectedFiles[] = $item; } } diff --git a/lib/Varien/Data/Tree/Db.php b/lib/Varien/Data/Tree/Db.php index e8f1e6964372..1e2480d2e35d 100644 --- a/lib/Varien/Data/Tree/Db.php +++ b/lib/Varien/Data/Tree/Db.php @@ -92,10 +92,11 @@ public function __construct($connection, $table, $fields) $this->_conn = $connection; $this->_table = $table; - if (!isset($fields[self::ID_FIELD]) || - !isset($fields[self::PARENT_FIELD]) || - !isset($fields[self::LEVEL_FIELD]) || - !isset($fields[self::ORDER_FIELD])) { + if (!isset($fields[self::ID_FIELD]) + || !isset($fields[self::PARENT_FIELD]) + || !isset($fields[self::LEVEL_FIELD]) + || !isset($fields[self::ORDER_FIELD]) + ) { throw new Exception('"$fields" tree configuratin array'); } diff --git a/lib/Varien/Data/Tree/Dbp.php b/lib/Varien/Data/Tree/Dbp.php index 898dd1825530..b36a5b14e7e0 100644 --- a/lib/Varien/Data/Tree/Dbp.php +++ b/lib/Varien/Data/Tree/Dbp.php @@ -94,10 +94,11 @@ public function __construct($connection, $table, $fields) $this->_conn = $connection; $this->_table = $table; - if (!isset($fields[self::ID_FIELD]) || - !isset($fields[self::PATH_FIELD]) || - !isset($fields[self::LEVEL_FIELD]) || - !isset($fields[self::ORDER_FIELD])) { + if (!isset($fields[self::ID_FIELD]) + || !isset($fields[self::PATH_FIELD]) + || !isset($fields[self::LEVEL_FIELD]) + || !isset($fields[self::ORDER_FIELD]) + ) { throw new Exception('"$fields" tree configuratin array'); } diff --git a/lib/Varien/Db/Adapter/Pdo/Mysql.php b/lib/Varien/Db/Adapter/Pdo/Mysql.php index a67c27600eb4..97bbcd378507 100644 --- a/lib/Varien/Db/Adapter/Pdo/Mysql.php +++ b/lib/Varien/Db/Adapter/Pdo/Mysql.php @@ -314,24 +314,14 @@ protected function _getHostInfo($hostName) if (strpos($hostName, '/') !== false) { $hostInfo->setAddressType(self::ADDRESS_TYPE_UNIX_SOCKET) ->setUnixSocket($hostName); - } elseif (preg_match( - '/^\[(([0-9a-f]{1,4})?(:([0-9a-f]{1,4})?){1,}:([0-9a-f]{1,4}))(%[0-9a-z]+)?\](:([0-9]+))?$/i', - $hostName, - $matches - ) - ) { - $hostName = isset($matches[1]) ? $matches[1] : null; + } elseif (preg_match('/^\[(([0-9a-f]{1,4})?(:([0-9a-f]{1,4})?){1,}:([0-9a-f]{1,4}))(%[0-9a-z]+)?\](:([0-9]+))?$/i', $hostName, $matches)) { + $hostName = $matches[1] ?? null; !is_null($hostName) && isset($matches[6]) && ($hostName .= $matches[6]); $hostInfo->setAddressType(self::ADDRESS_TYPE_IPV6_ADDRESS) ->setHostName($hostName) - ->setPort(isset($matches[8]) ? $matches[8] : null); - } elseif (preg_match( - '/^(([0-9a-f]{1,4})?(:([0-9a-f]{1,4})?){1,}:([0-9a-f]{1,4}))(%[0-9a-z]+)?$/i', - $hostName, - $matches - ) - ) { - $hostName = isset($matches[1]) ? $matches[1] : null; + ->setPort($matches[8] ?? null); + } elseif (preg_match('/^(([0-9a-f]{1,4})?(:([0-9a-f]{1,4})?){1,}:([0-9a-f]{1,4}))(%[0-9a-z]+)?$/i', $hostName, $matches)) { + $hostName = $matches[1] ?? null; !is_null($hostName) && isset($matches[6]) && ($hostName .= $matches[6]); $hostInfo->setAddressType(self::ADDRESS_TYPE_IPV6_ADDRESS) ->setHostName($hostName); @@ -369,7 +359,7 @@ protected function _connect() throw new Zend_Db_Adapter_Exception('pdo_mysql extension is not installed'); } - $hostInfo = $this->_getHostInfo(isset($this->_config['host']) ? $this->_config['host'] : (isset($this->_config['unix_socket']) ? $this->_config['unix_socket'] : null)); + $hostInfo = $this->_getHostInfo($this->_config['host'] ?? $this->_config['unix_socket'] ?? null); switch ($hostInfo->getAddressType()) { case self::ADDRESS_TYPE_UNIX_SOCKET: @@ -462,7 +452,7 @@ public function raw_fetchRow($sql, $field = null) if (empty($field)) { return $row; } else { - return isset($row[$field]) ? $row[$field] : false; + return $row[$field] ?? false; } } @@ -572,11 +562,12 @@ protected function _prepareQuery(&$sql, &$bind = []) */ public function proccessBindCallback($matches) { - if (isset($matches[6]) && ( - strpos($matches[6], "'") !== false || - strpos($matches[6], ':') !== false || - strpos($matches[6], '?') !== false - ) + if (isset($matches[6]) + && ( + strpos($matches[6], "'") !== false + || strpos($matches[6], ':') !== false + || strpos($matches[6], '?') !== false + ) ) { $bindName = ':_mage_bind_var_' . (++$this->_bindIncrement); $this->_bindParams[$bindName] = $this->_unQuote($matches[6]); @@ -1194,7 +1185,7 @@ public function getForeignKeys($tableName, $schemaName = null) 'SCHEMA_NAME' => $schemaName, 'TABLE_NAME' => $tableName, 'COLUMN_NAME' => $match[2], - 'REF_SHEMA_NAME' => isset($match[3]) ? $match[3] : $schemaName, + 'REF_SHEMA_NAME' => $match[3] ?? $schemaName, 'REF_TABLE_NAME' => $match[4], 'REF_COLUMN_NAME' => $match[5], 'ON_DELETE' => isset($match[6]) ? $match[7] : '', @@ -1268,7 +1259,8 @@ public function modifyTables($tables) $onUpdate = $options['ON_UPDATE']; if ($onDelete == Varien_Db_Adapter_Interface::FK_ACTION_SET_NULL - || $onUpdate == Varien_Db_Adapter_Interface::FK_ACTION_SET_NULL) { + || $onUpdate == Varien_Db_Adapter_Interface::FK_ACTION_SET_NULL + ) { $columnDefinition['nullable'] = true; } $this->modifyColumn($options['TABLE_NAME'], $options['COLUMN_NAME'], $columnDefinition); diff --git a/lib/Varien/Db/Select.php b/lib/Varien/Db/Select.php index 6c3dd7975866..a1f65b26c2ec 100644 --- a/lib/Varien/Db/Select.php +++ b/lib/Varien/Db/Select.php @@ -133,7 +133,8 @@ public function resetJoinLeft() list($correlationName, $column) = $columnEntry; if ($column instanceof Zend_Db_Expr) { if ($this->_findTableInCond($tableId, $column) - || $this->_findTableInCond($tableProp['tableName'], $column)) { + || $this->_findTableInCond($tableProp['tableName'], $column) + ) { $useJoin = true; } } else { @@ -144,7 +145,8 @@ public function resetJoinLeft() } foreach ($this->_parts[self::WHERE] as $where) { if ($this->_findTableInCond($tableId, $where) - || $this->_findTableInCond($tableProp['tableName'], $where)) { + || $this->_findTableInCond($tableProp['tableName'], $where) + ) { $useJoin = true; } } @@ -158,7 +160,8 @@ public function resetJoinLeft() } if (!empty($table['joinCondition'])) { if ($this->_findTableInCond($tableId, $table['joinCondition']) - || $this->_findTableInCond($tableProp['tableName'], $table['joinCondition'])) { + || $this->_findTableInCond($tableProp['tableName'], $table['joinCondition']) + ) { $useJoin = true; $joinInTables[] = $tableCorrelationName; } diff --git a/lib/Varien/File/Csv.php b/lib/Varien/File/Csv.php index 0baf9101a736..c9c52df303ed 100644 --- a/lib/Varien/File/Csv.php +++ b/lib/Varien/File/Csv.php @@ -137,7 +137,8 @@ public function fputcsv(&$handle, $fields = [], $delimiter = ',', $enclosure = ' strpos($value, "\n") !== false || strpos($value, "\r") !== false || strpos($value, "\t") !== false || - strpos($value, ' ') !== false) { + strpos($value, ' ') !== false + ) { $str2 = $enclosure; $escaped = 0; $len = strlen($value); diff --git a/lib/Varien/Filter/Template.php b/lib/Varien/Filter/Template.php index 6cba49cb4e14..d0d0800ef34e 100644 --- a/lib/Varien/Filter/Template.php +++ b/lib/Varien/Filter/Template.php @@ -126,10 +126,11 @@ public function getIncludeProcessor() public function filter($value) { // "depend" and "if" operands should be first - foreach ([ + $directives = [ self::CONSTRUCTION_DEPEND_PATTERN => 'dependDirective', self::CONSTRUCTION_IF_PATTERN => 'ifDirective', - ] as $pattern => $directive) { + ]; + foreach ($directives as $pattern => $directive) { if (preg_match_all($pattern, $value, $constructions, PREG_SET_ORDER)) { foreach ($constructions as $index => $construction) { $replacedValue = '';