Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct instructions in "Build user feature" blog #3503

Closed
cbridgha opened this issue Jan 3, 2024 · 1 comment
Closed

Correct instructions in "Build user feature" blog #3503

cbridgha opened this issue Jan 3, 2024 · 1 comment

Comments

@cbridgha
Copy link
Member

cbridgha commented Jan 3, 2024

In the blog: Build and install an Open Liberty user feature by using Maven plug-ins

Under the section: Building an Enterprise Subsystem Archive

It states: By default, it will not generate the manifest file, so we have to set the generateManifest header to true. To install the feature on to the Open Liberty runtime, we need to set the visibility directive to "public". We can do so by setting the Subsystem-SymbolicName header to "Bundle-SymbolicName;visibility:=public". If the visibility is set to protected|private, the Liberty Maven Plugin can’t resolve the feature. Also, the plugin automatically creates the mandatory Subsystem-Content header. IBM-ShortName is an optional header alias to Subsystem-SymbolicName.

Change the line: We can do so by setting the Subsystem-SymbolicName header to "Bundle-SymbolicName;visibility:=public".

to: We can do so by setting the Subsystem-SymbolicName header to "Subsystem-SymbolicName;visibility:=public".

Also in the example source for SUBSYSTEM.MF

Subsystem-ManifestVersion: 1
Subsystem-SymbolicName: com.example.bundle.Activator;visibility:=public
Subsystem-Version: 1.0.0
Subsystem-Name: SimpleActivatorESA
Subsystem-Content: com.example.bundle.Activator;version="[1.0.0,1.0.0]"
IBM-Feature-Version: 2
IBM-ShortName: SimpleActivator
Subsystem-Type: osgi.subsystem.feature
Subsystem-Vendor: IBM

replace line: Subsystem-SymbolicName: com.example.bundle.Activator;visibility:=public

with

Subsystem-SymbolicName: com.example.feature.SimpleActivator;visibility:=public

@steven1046 steven1046 transferred this issue from OpenLiberty/openliberty.io Jan 10, 2024
@natalie-bernhard natalie-bernhard moved this from New (Untriaged) to Icebox in Website backlog Jan 17, 2024
@dmuelle
Copy link
Member

dmuelle commented Aug 26, 2024

fixed in #4006

@dmuelle dmuelle closed this as completed Aug 26, 2024
@github-project-automation github-project-automation bot moved this from Icebox to Closed/Done in Website backlog Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed/Done
Development

No branches or pull requests

2 participants