Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Mods Manager cannot recognize Japanese Characters 0x91 and 0x93 when building. #1125

Open
TopazTK opened this issue Dec 15, 2024 · 5 comments
Labels
Bug Something is not working as intended, or at all.

Comments

@TopazTK
Copy link
Collaborator

TopazTK commented Dec 15, 2024

OpenKH Build
Latest as of 12/15/2024

OpenKH Program
Mods Manager

Describe the Bug
The Mods Manager errors out if characters 0x91 (い) or 0x93 (え) are found within text, and will refuse to build because the encoding does not support the characters. The problem with that is the encoding does support said characters.

To Reproduce
Steps to reproduce the behavior:
Have a mod that uses either of those characters in a text file.
Try to build the mod.
???
Profit!

Expected behavior
The mod should build without issue.

@TopazTK
Copy link
Collaborator Author

TopazTK commented Dec 15, 2024

Current Workaround: Use {:unk 91} and {:unk 93} respectively. I would like to iterate that this is a terrible solution.

@Delta-473
Copy link
Collaborator

So it crashes when you those 2 Japanese characters but not when you use {:unk 91}. Would it be a lot of work to make empty mods where one has the Japanese character that would crash it and the other where it doesn't and attach them to this issue?

@Delta-473 Delta-473 added the Bug Something is not working as intended, or at all. label Dec 21, 2024
@TopazTK
Copy link
Collaborator Author

TopazTK commented Dec 21, 2024

So it crashes when you those 2 Japanese characters but not when you use {:unk 91}. Would it be a lot of work to make empty mods where one has the Japanese character that would crash it and the other where it doesn't and attach them to this issue?

It doesn't crash, it just cannot build because the character is unrecognized. Of course the unk tag does not fail building since it's entire purpose is to use unrecognized characters.
Also, I can quickly make something of that nature but it will be a minute before I can do so.

@Delta-473
Copy link
Collaborator

Can you check if #1133 fixes the issue?

@TopazTK
Copy link
Collaborator Author

TopazTK commented Dec 30, 2024

It does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended, or at all.
Projects
None yet
Development

No branches or pull requests

2 participants