Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: let people turn of active highlighting #1354

Conversation

cyai
Copy link
Contributor

@cyai cyai commented Jul 24, 2024

Describe the changes you have made:

  • Added a new feature to allow users to turn off active line highlighting in code blocks
  • Implemented a new CLI argument --no-highlight-active-line (short form: -nhl) to disable active line highlighting
  • Modified the OpenInterpreter class to include a highlight_active_line attribute
  • Updated the CodeBlock class to respect the highlight_active_line setting
  • Adjusted the terminal_interface function to pass the interpreter instance to CodeBlock
  • Updated the ROADMAP.md to mark the "Let people turn off the active line highlighting" task as completed

Pre-Submission Checklist (optional but appreciated):

  • I have included relevant documentation updates (stored in /docs)
  • I have read docs/CONTRIBUTING.md
  • I have read docs/ROADMAP.md

OS Tests (optional but appreciated):

  • Tested on Windows
  • Tested on MacOS
  • Tested on Linux

Additional Notes:

This PR adds the ability for users to disable active line highlighting in code blocks, which can be useful for users who prefer a cleaner output or for scenarios where the highlighting might interfere with readability. The feature is disabled by default, maintaining the current behavior, but can be turned off using the new CLI argument.

Please review the changes and let me know if any further modifications or testing are needed.

@KillianLucas KillianLucas changed the base branch from main to development July 26, 2024 20:50
@KillianLucas
Copy link
Collaborator

Legendary to check the roadmap and knock something out!! Lots of folks have wanted this. Great work @cyai. Merging!

@KillianLucas KillianLucas merged commit 65ce8f9 into OpenInterpreter:development Jul 26, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants