Fix some minor problems with oiiotool --resample #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes you really, REALLY just want closest pixel blocky appearance rather than bilinear sampling. ImageBufAlgo::resample() had that option, but `oiotool --resample` didn't expose it.
GerHobbelt
pushed a commit
to GerHobbelt/oiio
that referenced
this pull request
Dec 10, 2024
Signed-off-by: Rémi Achard <[email protected]> Signed-off-by: Rémi Achard <[email protected]> Co-authored-by: Michael Dolan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oiiotool --resample:interp=0Sometimes you really, REALLY just want closest pixel blocky appearance rather than bilinear sampling. ImageBufAlgo::resample() had that option, but
oiotool --resampledidn't expose it.Discovered and fixed a 1/2 pixel shift for resampling. (resize was correct, resample was off)
Discovered along the way: fix some broken diff printing when deep images are involved.