Fix: Silence Deprecated Version Warning #1570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove deprecated Docker Version object from YML files
|
But will this break with older versions of docker-compose? |
|
It should work on v2+, as this was deprecated after v2. Do we still ship/support v1? |
|
We try to support everything. I'm OK merging this if it doesn't break older versions (test?). If it does break older versions, we'll just keep the deprecation notice, which is just a notice and can be ignored. |
|
I need to package it to test, Alpine doesn't ship v1 since it is long since deprecated. One of the major improvements of v2 is using |
|
+1 for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated Docker Version object from YML files