Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE 5] Dollar figures on Loss Exceedence Curve; Colour of postal code area #84

Closed
anthonyfok opened this issue Oct 17, 2022 · 2 comments
Assignees
Labels
Bug Something isn't working Review & Close Ready for review

Comments

@anthonyfok
Copy link
Member

@tieganh wrote on Thu 2022-10-13 evening:

On the loss exceedance curves, there’s two “$” and also it seems strange to call it “0.49 million” instead of “490 thousand” especially when the horizontal axis is in thousands.

Also, it’s low priority but if it’s super easy to change could we make the outline of the postal code area black instead of red? It’s really hard to see in this map, for example.

Screen Shot 2022-10-13 at 7 40 13 PM

@anthonyfok anthonyfok added the Bug Something isn't working label Oct 17, 2022
@anthonyfok anthonyfok changed the title [ISSUE 5] Dollar figure on Loss Exceedence Curve; Colour of postal code area [ISSUE 5] $ figures on Loss Exceedence Curve; Colour of postal code area Oct 17, 2022
@anthonyfok anthonyfok changed the title [ISSUE 5] $ figures on Loss Exceedence Curve; Colour of postal code area [ISSUE 5] Dollar figures on Loss Exceedence Curve; Colour of postal code area Oct 17, 2022
@anthonyfok
Copy link
Member Author

@phil-evans replied on Fri 2022-10-14 morning:

fixed the $ figures, it was still using the old rounding method

Screen Shot 2022-10-14 at 11 29 08 AM

@anthonyfok
Copy link
Member Author

@phil-evans further replied on Fri 2022-10-14 afternoon:

changed the FSA outline to black

Screen Shot 2022-10-14 at 2 41 35 PM

@anthonyfok anthonyfok added the Review & Close Ready for review label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Review & Close Ready for review
Projects
None yet
Development

No branches or pull requests

3 participants