Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make migrations compatible with latest webauthn-framework #143

Open
johanib opened this issue Nov 26, 2024 · 1 comment · May be fixed by #170
Open

Make migrations compatible with latest webauthn-framework #143

johanib opened this issue Nov 26, 2024 · 1 comment · May be fixed by #170
Assignees
@johanib
Labels
bug Something isn't working webauthn webauthn-gssp

Comments

@johanib
Copy link
Contributor

johanib commented Nov 26, 2024 •
edited
Loading

The 4.8.6 release of webauthn-framework which we merged here introduced some new fields.

These are not added in the Stepup-Webauthn migrations, this breaks when installing Webauthn.

Desired situation

  • The build breaks if the database is not up-to-date with the schema (if possible)
  • Proper migrations are added
@johanib johanib added the bug Something isn't working label Nov 26, 2024
@phavekes phavekes moved this from New to Backlog in PHP development Nov 30, 2024
@johanib johanib self-assigned this Jan 7, 2025
@johanib johanib moved this from Backlog to In Progress in PHP development Jan 7, 2025
@johanib johanib linked a pull request Jan 7, 2025 that will close this issue
Fix doctrine mapping & add smoketest that fails on invalid schema #170
Open
johanib added a commit that referenced this issue Jan 7, 2025
@johanib
Fix: Implement PublicKeyCredentialSource schema changes
6f6fc93 
Prior to this change, the PublicKeyCredentialSource entity could not be
saved, because a 3rd party web authn package which we extend
PublicKeyCredentialSource from has new db fields. This resulted in sql
errors.

This change implements the required fields and adds a migration.

Fixes #143
Caused by dd32c26#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R37

See web-auth/webauthn-framework#592
See https://github.com/web-auth/webauthn-framework/releases/tag/4.8.6
johanib added a commit that referenced this issue Jan 7, 2025
@johanib
Fix: Implement PublicKeyCredentialSource schema changes
b59c8b9 
Prior to this change, the PublicKeyCredentialSource entity could not be
saved, because a 3rd party web authn package which we extend
PublicKeyCredentialSource from has new db fields. This resulted in sql
errors.

This change implements the required fields and adds a migration.

Fixes #143
Caused by dd32c26#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R37

See web-auth/webauthn-framework#592
See https://github.com/web-auth/webauthn-framework/releases/tag/4.8.6
johanib added a commit that referenced this issue Jan 7, 2025
@johanib
Fix: Implement PublicKeyCredentialSource schema changes
77dd85c 
Prior to this change, the PublicKeyCredentialSource entity could not be
saved, because a 3rd party web authn package which we extend
PublicKeyCredentialSource from has new db fields. This resulted in sql
errors.

This change implements the required fields and adds a migration.

Fixes #143
Caused by dd32c26#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R37

See web-auth/webauthn-framework#592
See https://github.com/web-auth/webauthn-framework/releases/tag/4.8.6
johanib added a commit that referenced this issue Jan 8, 2025
@johanib
Fix: Implement PublicKeyCredentialSource schema changes
fdba704 
Prior to this change, the PublicKeyCredentialSource entity could not be
saved, because a 3rd party web authn package which we extend
PublicKeyCredentialSource from has new db fields. This resulted in sql
errors.

This change implements the required fields and adds a migration.

Fixes #143
Caused by dd32c26#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R37

See web-auth/webauthn-framework#592
See https://github.com/web-auth/webauthn-framework/releases/tag/4.8.6
johanib added a commit that referenced this issue Jan 9, 2025
@johanib
Fix: Implement PublicKeyCredentialSource schema changes
8467ca0 
Prior to this change, the PublicKeyCredentialSource entity could not be
saved, because a 3rd party web authn package which we extend
PublicKeyCredentialSource from has new db fields. This resulted in sql
errors.

This change implements the required fields and adds a migration.

Fixes #143
Caused by dd32c26#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R37

See web-auth/webauthn-framework#592
See https://github.com/web-auth/webauthn-framework/releases/tag/4.8.6
johanib added a commit that referenced this issue Jan 9, 2025
@johanib
Fix: Implement PublicKeyCredentialSource schema changes
a6090a4 
Prior to this change, the PublicKeyCredentialSource entity could not be
saved, because a 3rd party web authn package which we extend
PublicKeyCredentialSource from has new db fields. This resulted in sql
errors.

This change implements the required fields and adds a migration.

Fixes #143
Caused by dd32c26#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R37

See web-auth/webauthn-framework#592
See https://github.com/web-auth/webauthn-framework/releases/tag/4.8.6
johanib added a commit that referenced this issue Jan 9, 2025
@johanib
Fix: Implement PublicKeyCredentialSource schema changes
a0a7448 
Prior to this change, the PublicKeyCredentialSource entity could not be
saved, because a 3rd party web authn package which we extend
PublicKeyCredentialSource from has new db fields. This resulted in sql
errors.

This change implements the required fields and adds a migration.

Fixes #143
Caused by dd32c26#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R37

See web-auth/webauthn-framework#592
See https://github.com/web-auth/webauthn-framework/releases/tag/4.8.6
@johanib
Copy link
Contributor Author

johanib commented Jan 9, 2025

@pmeulen

In this ticket, I made webauthn installable again by simply mapping the new fields in our database.

Do you think we need to actually implement these new fields functionally?
https://github.com/web-auth/webauthn-framework/pull/592/files

johanib added a commit that referenced this issue Jan 9, 2025
@johanib
Fix: Implement PublicKeyCredentialSource schema changes
11bc471 
Prior to this change, the PublicKeyCredentialSource entity could not be
saved, because a 3rd party web authn package which we extend
PublicKeyCredentialSource from has new db fields. This resulted in sql
errors.

This change implements the required fields and adds a migration.

Fixes #143
Caused by dd32c26#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R37

See web-auth/webauthn-framework#592
See https://github.com/web-auth/webauthn-framework/releases/tag/4.8.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johanib johanib

Labels
bug Something isn't working webauthn webauthn-gssp
Projects
PHP development
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix doctrine mapping & add smoketest that fails on invalid schema OpenConext/Stepup-Webauthn
2 participants
@phavekes @johanib