PublicKeyCredentialSource entity misalignment

[phavekes]

This issue is imported from pivotal - Originaly created at Apr 15, 2024 by Michiel Kodde

The Webauthn\PublicKeyCredentialSource maps the publicKeyCredentialId to the id field. We however have a more traditional auto increment numeric id field.

When the parent app tries to access our PublicKeyCredentialSource::id it is presented with a numeric ID which makes no sense to it. As it expects an UUID.

To work around this, we currently utilize a __get magic getter for the id field. Previously the vendor code would access the id via the getId method.

To fix this we should refactor our entity to let it use the publicKeyCredentialId for the id field, this would result in a schema change with some data transfer.

See:

Stepup-Webauthn/src/Entity/PublicKeyCredentialSource.php

Lines 75 to 86 in a9e43c1

	/**
	* Warning: the id field is accessed directly in :\Webauthn\CeremonyStep\CheckAllowedCredentialList::process
	* The entity tracks a numeric auto increment id value, but the CheckAllowedCredentialList expects the
	* publicKeyCredentialId.
	*/
	public function __get(string $name): mixed
	{
	if ($name === 'id') {
	return $this->publicKeyCredentialId;
	}
	throw new RuntimeException(sprintf('Not allowed to access "%s" via the magic __get function', $name));
	}