Feedbackinfo not cleared after successful login

[thijskh]

Error messages provide debug information in feedbackinfo, e.g. the SP entityID/name or IdP entityID/name involved.

These are stored in the user's session. After a succesful login they are not cleared. This means that when an error occurs in a user's session at some point after they've already authenticated, one of two things happens:

1. The feedbackinfo is overwritten with the new authentication in progress, so is (more or less) correct
2. The error occurs at a point where (this part of) the feedbackinfo is not yet overwritten, so is misleading.

Possible solutions:

• Clear feedbackinfo when completing an authentication successfully
• When starting to register feedbackinfo, clear all existing fields first
• Store feedbackinfo not globally but per request-id, so associated with the inflight authentications which are also stored separately in the session