-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Finish Later" button to forms opened in Participant mode #39
Add "Finish Later" button to forms opened in Participant mode #39
Comments
single page, full XML record submission: http://localhost:8005/single/full/participant/ecc3bb1f8ede1cf154664522e3f0f2c9?ecid=1
test message received by iframe parentWindow: |
@pbowen-oc, @malcjackson we have full-XML-record Participate views (incl offline-capable ones) and fieldsubmission Participate views. Should this new feature (including the new button text for the existing Submit/Close button) be for all of them? |
@pbowen-oc, @malcjackson, should any confirmation dialog be shown before exiting? If so, what should be the text? |
@MartijnR - This feature should only be added to our standard field submission Participate views. It would not be relevant for our online anonymous view and the offline view already has a button to save as a draft (which creates a similar effect to this new Finish Later button). I don't think there is a need to have a confirmation dialog since the user will see a button to resume form data entry on the page they go to after the form closes from Finish Later. |
The message sent to the parentWindow is the same as the 'close' message except that the |
…pate-674 added ‘Finish Later' button in fieldsubmission Participate views, kobotoolbox#674
We are currently seeing some unexpected behavior with the relabeled "I'm Done" button.
The expectation is that I'm Done always only appears on the last page of the form. |
@theywa - Can you work on this? |
Hi @MartijnR ~ I found the reason is in css like you said. The trigger is this class on line 433 on _common-oc.scss that added on f3d64f0e206b4b9e2912644f17e7a206334f54ad
Do you have a suggestion/opinion about this issue or how to fix it? |
Oh interesting find. As you likely noticed, this class is set here, and is for empty Participate Fieldsubmission-type forms (not when editing a record). It is removed here when a dataupdate event fires. It looks like this feature/hack relates to some new RFC views (introduced in that same commit) #100. As to why it only causes a problem for some forms, I wonder if that is because a calculation causes a dataupdate event that removes that class. I wonder if the solution is to tweak that I hope that helps! |
Thank you @MartijnR, that is very helpful. After taking a look at the code your suggestion makes sense and after testing, that update fixes the issue. I also found out, why only that form has the issue. because that form does not have any calculated item that will trigger auto-saving the first time we open the form. By auto-saving the form type will be changed to "edit"(that will remove the |
When a form is opened in the Participant flavor there is no option built into the form to close it without evaluating for errors and come back later to finish. Adding something like this to Participant-mode forms would help guide those users and improve their experience.
The text was updated successfully, but these errors were encountered: