Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sendMessage(json) signal #1358

Open
ghutchis opened this issue Sep 29, 2023 · 2 comments · May be fixed by #1959
Open

Add sendMessage(json) signal #1358

ghutchis opened this issue Sep 29, 2023 · 2 comments · May be fixed by #1959
Labels
enhancement feature changes / API changes

Comments

@ghutchis
Copy link
Member

Plugins should emit a sendMessage(json) signal in response to commands.

For example, surface calculation should emit a "finished" signal through RPC.
@ghutchis ghutchis added the enhancement feature changes / API changes label Oct 25, 2023
@ghutchis ghutchis moved this to To do in Avogadro 1.99 Nov 25, 2023
@harshit4311
Copy link

I would love working on this issue! Could you please assign it to me?

@peach280 peach280 linked a pull request Jan 31, 2025 that will close this issue
Open
@peach280
Copy link
Contributor

I interpreted this issue as emitting a json signal through RPC, but I was not sure whether to just print this on console or use signal and slots in qt. So I changed it only for calculateEDT function.
I have generated a PR for this though. I think that my understanding of this issue might not be very clear so please suggest improvements. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement feature changes / API changes
Projects
No open projects
Avogadro 1.99
Status: To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added sendMessage signal to surface calculation peach280/avogadrolibs
3 participants
@ghutchis @harshit4311 @peach280