-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish package #277
Publish package #277
Conversation
Pull Request Test Coverage Report for Build 6905159534
💛 - Coveralls |
This looks great! For example, now we are at And for releases, we should instead change the minor or even major, i.e. |
prerelease are great because users don't get to install them unless they explicitly say. They look like this: which would make it: From semantic versioning
Instead of prereleasing, we can also patch everytime, but I think it's better to do it manually just because if things get broken in the automated pipeline, at least we don't have a release.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I'll test installing it from pypi now, and approve if this works!
perfect! this I love this! And yes, I think once most of the current open PRs are merged we can bump to |
This looks great, yes! |
We can make the pipy badge link to the pipy page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It worked, I got it installed on maxwell with python 3.10 by simply creating a conda environment, and running pip install sed-processor.
The only problem is we have really a LOT of dependencies!
LGTM!
Yes, I also noticed it and we really should see if we can remove some. |
A lot of them come from pynxtools... |
Now we have the capability of prereleasing to pypi whenever we push to main. And releasing when we push a tag.
The release version can be arbitrarily set by the person who releases (by defining the tag).
The package is distributed as sed-processor and can be found on https://pypi.org/project/sed-processor/
There are four steps to what the workflow does:
Necessary changes to be made before merging:
closes #266
Changes made:
Improvements possible: