Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus definitions for processing steps #430

Open
zain-sohail opened this issue Jun 22, 2024 · 0 comments
Open

Nexus definitions for processing steps #430

zain-sohail opened this issue Jun 22, 2024 · 0 comments

Comments

@zain-sohail
Copy link
Member

Continuing the discussion in #417
The processing section should ideally be either dynamic since new methods might be added in future. And even if not, putting an /ENTRY[entry] for each of the processing methods seems cumbersome.
I think with a decorator, this could section could perhaps be entirely autogenerated e.g.

  "/ENTRY[entry]/PROCESS_MPES[process]/energy_calibration":{
    "coefficients": "@attrs:metadata/energy_calibration/calibration/coefficients",
    "fit_function": "@attrs:metadata/energy_calibration/calibration/fit_function",
    "original_axis": "@attrs:metadata/energy_calibration/tof",
    "calibrated_axis": "@attrs:metadata/energy_calibration/calibration/axis",
    "calibrated_axis/@units": "eV"
  },

has all keys heirarchically arranged, so one just needs to parse them (it should rather be calibration/energy_calibration/.. than energy_calibration/calibration, so that all calibrations can come under that section).

Also, in/after #429 we should definitely add package name/version/etc. to the metadata so the workflow is completely reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant