Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlashLoader: load_parquet not working after using save_parquet #319

Closed
zain-sohail opened this issue Jan 2, 2024 · 3 comments
Closed

FlashLoader: load_parquet not working after using save_parquet #319

zain-sohail opened this issue Jan 2, 2024 · 3 comments

Comments

@zain-sohail
Copy link
Member

Some of the code is in the else condition that should occur after the if-else statement

# Remove the NaNs from per_electron channels
dataframe_electron = dataframe.dropna(
subset=self.get_channels(["per_electron"]),
)
dataframe_pulse = dataframe[
self.multi_index + self.get_channels(["per_pulse", "per_train"])
]
dataframe_pulse = dataframe_pulse[
(dataframe_pulse["electronId"] == 0) | (np.isnan(dataframe_pulse["electronId"]))
]

easy fix. Should be fixed in current version and also the refactoring branch is merged. Fix should be merged before the refactoring

@zain-sohail
Copy link
Member Author

actually, save_parquet should save 2 parquet files and read parquet reads both. This is being done in refactored version already.

@zain-sohail
Copy link
Member Author

addressed in #329

@zain-sohail
Copy link
Member Author

Fixed this in #385 and merged to main. Still needs work in refactor branch before merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant