-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binning using step size #297
Comments
We decided for the current functionality because this is the way most scanning programs work I know of. Also, if you provide bin size you potentially cannot fill the whole bin range. |
This workaround is how binning is being performed at flash now, and is not optimal. However, the request is about adding the option of defining your bins prioritizing the step size, which is a reasonable request. I think when there is a feature request, which does not break previous functionality, it is not our place to judge how good of an idea it is for our experience, but rather we should consider if we can provide this to improve user experience for others too. |
I don't oppose this idea, I just wanted to explain the decision for the current functionality and point out a workaround. Please feel free to implement this. |
Related to #123 |
Is your feature request related to a problem? Please describe.
I would prefer inserting the bin size instead of the bin number when defining the binning
Describe the solution you'd like
Having an option for the bin size instead
Describe alternatives you've considered
wrapper functions would be ok but it makes the code unnecessarily difficult to read in notebooks
The text was updated successfully, but these errors were encountered: