Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worflow items to add from HextofProcessor #167

Closed
5 tasks done
rettigl opened this issue Oct 9, 2023 · 4 comments
Closed
5 tasks done

Worflow items to add from HextofProcessor #167

rettigl opened this issue Oct 9, 2023 · 4 comments

Comments

@rettigl
Copy link
Member

rettigl commented Oct 9, 2023

These workflow items should be added as discussed today:

  • Sector calibration for the 8-sector DLD. I suggest to split this up into parameter generation and application function, similar as done for the other calibration/correction functions, and perform the operation on the digitized DLD bin coordinates, rather than converted ns coordinates (for compatibility with the current jitter framework, see Flash jitter config #163)

  • Funtion to shift the energy axis. This could include photon energy, bias voltage, a given, external offset, and potentially any other voltages that influence the energy scale. We could also place the code that swaps the energy axis from kinetic to binding energy scale here.

  • Code for the BAM correction #236

  • Code for shifting the delay axis. Similar interface to the shift energy axis. #237

  • Add default jitter columns to the default config, that refer to the config names of the X, Y, TOF columns

@rettigl
Copy link
Member Author

rettigl commented Oct 9, 2023

* [x]  Add default jitter columns to the default config, that refer to the config names of the X, Y, TOF columns

The last point is addressed in PR #168

@steinnymir
Copy link
Member

Funtion to shift the energy axis. This could include photon energy, bias voltage, a given, external offset, and potentially any other voltages that influence the energy scale. We could also place the code that swaps the energy axis from kinetic to binding energy scale here.

addressed in #169

@steinnymir
Copy link
Member

Sector calibration for the 8-sector DLD. I suggest to split this up into parameter generation and application function, similar as done for the other calibration/correction functions, and perform the operation on the digitized DLD bin coordinates, rather than converted ns coordinates (for compatibility with the current jitter framework, see #163)

correction implemented in #169. Parameter generation still missing

@steinnymir steinnymir added this to the FLASH Beamtime milestone Nov 3, 2023
@steinnymir
Copy link
Member

all tasks completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants