Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin token is accessible in the toml agent #1919

Open
RomuDeuxfois opened this issue Nov 25, 2024 · 3 comments · May be fixed by #2100
Open

Admin token is accessible in the toml agent #1919

RomuDeuxfois opened this issue Nov 25, 2024 · 3 comments · May be fixed by #2100
Assignees
@savacano28
Labels
feature use for describing a new feature to develop technical improvement Technical refactor or improvement is needed
Milestone
Release 1.12.0

Comments

@RomuDeuxfois
Copy link
Member

RomuDeuxfois commented Nov 25, 2024 •
edited
Loading

No description provided.

@RomuDeuxfois RomuDeuxfois added feature use for describing a new feature to develop needs triage use to identify issue needing triage from Filigran Product team labels Nov 25, 2024
@RomuDeuxfois RomuDeuxfois changed the title Communication between OpenBAS platform & Agent should be encrypted Admin token is accessible in the toml agent Nov 25, 2024
@EllynBsc EllynBsc added technical improvement Technical refactor or improvement is needed needs more info use to identify issue needing additional info to be triaged or solved and removed needs triage use to identify issue needing triage from Filigran Product team labels Nov 25, 2024
@EllynBsc
Copy link
Member

Hello @RomuDeuxfois 👋

Can you give me a bit more context ? Is it a technical improvement ? Why do we need it ? So I can put in the backlog accordingly. Thank you!

@RomuDeuxfois
Copy link
Member Author

RomuDeuxfois commented Dec 3, 2024 •
edited
Loading

We need to set up a key exchange system

Have a restrict token for fitting agent action (create a new role).
Have a screen to know which token is attached on which agent.
Add possibility to revoke a token -> the agent will no longer work.

@EllynBsc EllynBsc removed the needs more info use to identify issue needing additional info to be triaged or solved label Dec 3, 2024
@EllynBsc EllynBsc added this to the Release 1.10.0 milestone Dec 3, 2024
@EllynBsc
Copy link
Member

EllynBsc commented Dec 5, 2024 •
edited
Loading

Restrict token, following up tech ref

@savacano28 savacano28 self-assigned this Dec 17, 2024
@savacano28 savacano28 linked a pull request Dec 18, 2024 that will close this issue
Draft
5 tasks
@EllynBsc EllynBsc mentioned this issue Dec 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@savacano28 savacano28

Labels
feature use for describing a new feature to develop technical improvement Technical refactor or improvement is needed
Projects
None yet
Milestone
Release 1.12.0
Development

Successfully merging a pull request may close this issue.

[backend] Add 'agent' role and pass the agent token in the installati… OpenBAS-Platform/openbas
4 participants
@savacano28 @EllynBsc @jborozco @RomuDeuxfois