Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rust generation for versions without minor or patch parts #19946

Conversation

Schmiddiii
Copy link
Contributor

This fixes generation of a Rust library for OpenAPI specifications where info.version was a single-digit number. This happened to for this specification. The fix for this issue is similar to the one in !17440.

The error of Rust generates for this is:

error: unexpected end of input while parsing major version number
 --> Cargo.toml:3:11
  |
3 | version = "1"
  |           ^^^
  |

PR checklist

  • Read the contribution guidelines. (I know I am supposed to open an issue discussing this change before actually opening the PR, but I think this change is simple enough to not require much discussion in an issue).
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05) @jacob-pro (2022/10)

This fixes generation of a Rust library for OpenAPI specifications
where `info.version` was a single-digit number. This happened to for
[this](https://github.com/motis-project/motis/blob/db005f2e55812b8231e2e2dbac4d3abf711a8610/openapi.yaml#L10)
specification. The fix for this issue is similar to the one in !17440.
@wing328
Copy link
Member

wing328 commented Oct 23, 2024

thanks for the fix, which looks good to me.

@wing328 wing328 merged commit f576f05 into OpenAPITools:master Oct 23, 2024
15 checks passed
@Schmiddiii Schmiddiii deleted the rust-fix-version-without-minor-or-patch branch October 23, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants