-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start unit testing... seriously... #8806
Comments
I realize that there may already be some tests, but the above approach should work more effectively. The right areas are not being tested, leading to tons of issues. |
Hey there;
json schema has some test specs that could be used as a starting point. Does anyone want to write a PR improving our project in the way that this issue suggests? |
Some background info here:
Json schema spec versions: https://json-schema.org/specification-links.html Per json schema draft6: Openapi v3.1.0 describes examples: Openapi v3.0.3 describes examples: |
Also for the record, people have added many unit tests using sample specs that they put in this directory: |
This library is so full of bugs and regressions that it's absurd.
I hear there's a new TypeScript rewrite going on? Just wanted to make sure that unit tests are being a part of that.
Every time I contribute to fixing a bug here, it gets ruined again 4 - 6 months after. In addition, everytime something is "fixed", it ends up getting re-opened again because the fix broke someone else's flow.
Start 👏 Creating 👏 Unit 👏 Tests 👏
It's a must for such a big library. Then, whenever someone "fixes" something, require that they make a test for that specific scenario. In time, we'll then have a lot of concrete cases to work with.
The tests should be easy to implement.
In addition, I think there should be two types of tests. Compile-tests, and runtime tests.
An example of a compile-test:
An example of a runtime-test:
I have lost faith in this library. This is my last cry for help. You must see the relevance in this.
The text was updated successfully, but these errors were encountered: