Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also carry out "exam" audit? #27

Open
yarikoptic opened this issue Jan 28, 2023 · 4 comments
Open

Also carry out "exam" audit? #27

yarikoptic opened this issue Jan 28, 2023 · 4 comments

Comments

@yarikoptic
Copy link
Contributor

Not quite sure how to name it in addition to "vertical" and "horizontal" (IMHO an easier to grasp something like "cross-{dimension}" would be better so "cross-site" and "cross-subject" correspondingly; and here "cross-sequence"). To do some consistency analysis under assumptions across different sequences within specific exam.
E.g. correspondence (of shims, geometry, etc) of fieldmaps to func/dwi in BIDS "style" based on their assignment using IntendedFor field in side-car files. Also a check that all func/dwi do have fieldmaps if typically there is a fieldmap.

@raamana
Copy link
Contributor

raamana commented Jan 28, 2023

this is a great suggestion Yarik - something I was thinking about too, like within-session (vertical) and cross-session (horizontal) etc.

@raamana
Copy link
Contributor

raamana commented Jan 28, 2023

yes, it would be great to layout all the assumptions and rules explicitly in a consistent framework. this would require careful thought into design on how it will be implemented, and iterated on with some user testing e.g., to enable them to easily add their own new rules.. hence I am leaning into object-oriented design

@yarikoptic
Copy link
Contributor Author

this is a great suggestion Yarik - something I was thinking about too, like within-session (vertical) and cross-session (horizontal) etc.

'within' is ambiguous since could still be different dimensions (sessions, sites, ...). cross identifies dimension across which consistency is checked

@raamana
Copy link
Contributor

raamana commented Jan 29, 2023

I agree. cross-sequence is more precise in that sense! @sinhaharsh and will ideate ways to implement this, keeping in mind we need flexibility and easy customization to enable users to implement and share their own rules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants