Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if all the .dcm files in the folder belong to the same set. #5

Open
sinhaharsh opened this issue Oct 14, 2022 · 1 comment
Open

Comments

@sinhaharsh
Copy link
Collaborator

As per communication with Chris Rorden,

Segmenting data depends on modality, manufacturer and software version. You can see the heuristic here:
https://github.com/rordenlab/dcm2niix/blob/bb3a6c35d2bbac6ed95acb2cd0df65f35e79b5fb/console/nii_dicom_batch.cpp#L7482

@raamana
Copy link
Contributor

raamana commented Oct 15, 2022

wow - I'd like to learn more about the origins of the issue here as that would imply the library exporting the DICOMs screwed up horribly.

that said, thanks to the nature of the way we populate the MRDataset, we easily accommodate the checks and add the .dcm to the right branch of the project tree, right?

this also means that an MRdataset, when trying to parse a single project or modality, should have the ability to instantiate and add another parallel project should it discover data from another project or modality has been misplaced in this folder. we should also generate some sort of warning, e.g., UnexpectedLocationWarning, if and when we encounter them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants