New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative tolerance in dictdiff is problematic #13

Open

sinhaharsh opened this issue Apr 19, 2023 · 0 comments

Collaborator

sinhaharsh commented Apr 19, 2023

Consider giving up the dependency on dictdiff as it looks like the relative tolerance is computed based off the larger of the two values: https://docs.python.org/3/library/math.html#math.isclose

which can lead to some weird behaviour in some situations.
See Issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment