Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow entering process graph without "process_graph" wrapper #271

Closed
soxofaan opened this issue Aug 11, 2022 · 2 comments
Closed

allow entering process graph without "process_graph" wrapper #271

soxofaan opened this issue Aug 11, 2022 · 2 comments
Labels
wontfix This will not be worked on

Comments

@soxofaan
Copy link
Member

The code editor requires that the process graph JSON is wrapped in {"process_graph": ...}
otherwise, when you try to switch to "visual mode", you get this "Process invalid" error:

Screenshot from 2022-08-11 14-56-34

Very often, when I do user support, the user shares their process graph without the {"process_graph": ...} wrapper.
Can't we just support that format too in the editor?

@m-mohr
Copy link
Member

m-mohr commented Aug 11, 2022

It requires it because that's how it is specified, a process requires the "process_graph". The other variant is a left over in the other clients from the old 0.x days. So I'd rather say, please implement the other clients in a way that they don't export invalid processes any more:

So as this seems to bubble up again, I think Open-EO/openeo-python-client#155 should be re-opened?

A related issue is probably that for example in https://discuss.eodc.eu/t/renaming-existing-bands-bugged/442 users post Python dict representations, that can't be imported in JS either.

Related improvement planned for the Editor: #269

@m-mohr m-mohr closed this as completed Aug 11, 2022
@m-mohr m-mohr reopened this Aug 11, 2022
@m-mohr m-mohr closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2022
@m-mohr m-mohr added the wontfix This will not be worked on label Aug 11, 2022
@soxofaan
Copy link
Member Author

Regarding re-opening Open-EO/openeo-python-client#155 : I commented on that ticket itself.
I also closed Open-EO/openeo-python-client#209 as a duplicate of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants