From 46a1f8306e438facd713fc8c8050c2b0e85209da Mon Sep 17 00:00:00 2001 From: Lukas Weidenholzer Date: Thu, 29 Jun 2023 13:13:05 +0200 Subject: [PATCH 1/3] chore: change logging structure --- .../process_implementations/__init__.py | 3 +++ openeo_processes_dask/process_implementations/core.py | 9 +++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/openeo_processes_dask/process_implementations/__init__.py b/openeo_processes_dask/process_implementations/__init__.py index e261e9e7..840aa04e 100644 --- a/openeo_processes_dask/process_implementations/__init__.py +++ b/openeo_processes_dask/process_implementations/__init__.py @@ -26,3 +26,6 @@ import rioxarray as rio # Required for the .rio accessor on xarrays. import openeo_processes_dask.process_implementations.cubes._xr_interop + +log_format = "%(asctime)s - %(name)s - %(levelname)s - %(message)s" +logging.basicConfig(level=logging.INFO, format=log_format) diff --git a/openeo_processes_dask/process_implementations/core.py b/openeo_processes_dask/process_implementations/core.py index 664ad28d..698de7c5 100644 --- a/openeo_processes_dask/process_implementations/core.py +++ b/openeo_processes_dask/process_implementations/core.py @@ -74,10 +74,11 @@ def wrapper( if arg not in inspect.signature(f).parameters: resolved_kwargs.pop(arg, None) - pretty_args = {k: type(v) for k, v in resolved_kwargs.items()} - logger.warning(f"Running process {f.__name__}") - logger.warning(f"kwargs: {pretty_args}") - logger.warning("-" * 80) + pretty_args = {k: v.__repr__()[:80] for k, v in resolved_kwargs.items()} + logger.info(f"Running process {f.__name__}") + logger.debug( + f"Running process {f.__name__} with resolved parameters: {pretty_args}" + ) return f(*resolved_args, **resolved_kwargs) From da5d72fb165daa39c1f5321581270674d830fc7b Mon Sep 17 00:00:00 2001 From: Lukas Weidenholzer <17790923+LukeWeidenwalker@users.noreply.github.com> Date: Fri, 30 Jun 2023 11:57:27 +0200 Subject: [PATCH 2/3] Update openeo_processes_dask/process_implementations/core.py Co-authored-by: Stefaan Lippens --- openeo_processes_dask/process_implementations/core.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openeo_processes_dask/process_implementations/core.py b/openeo_processes_dask/process_implementations/core.py index 698de7c5..1d78ec85 100644 --- a/openeo_processes_dask/process_implementations/core.py +++ b/openeo_processes_dask/process_implementations/core.py @@ -74,7 +74,7 @@ def wrapper( if arg not in inspect.signature(f).parameters: resolved_kwargs.pop(arg, None) - pretty_args = {k: v.__repr__()[:80] for k, v in resolved_kwargs.items()} + pretty_args = {k: repr(v)[:80] for k, v in resolved_kwargs.items()} logger.info(f"Running process {f.__name__}") logger.debug( f"Running process {f.__name__} with resolved parameters: {pretty_args}" From 10f87b5d02f87aa209be86ac188ede9777bca968 Mon Sep 17 00:00:00 2001 From: Lukas Weidenholzer Date: Fri, 30 Jun 2023 11:58:59 +0200 Subject: [PATCH 3/3] apply suggestion from review --- openeo_processes_dask/process_implementations/__init__.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/openeo_processes_dask/process_implementations/__init__.py b/openeo_processes_dask/process_implementations/__init__.py index 840aa04e..614826e4 100644 --- a/openeo_processes_dask/process_implementations/__init__.py +++ b/openeo_processes_dask/process_implementations/__init__.py @@ -2,7 +2,6 @@ logger = logging.getLogger(__name__) - from .arrays import * from .comparison import * from .cubes import * @@ -26,6 +25,3 @@ import rioxarray as rio # Required for the .rio accessor on xarrays. import openeo_processes_dask.process_implementations.cubes._xr_interop - -log_format = "%(asctime)s - %(name)s - %(levelname)s - %(message)s" -logging.basicConfig(level=logging.INFO, format=log_format)