Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore bands that have role "metadata" when loading with load_stac #971

Merged
merged 8 commits into from
Dec 19, 2024

Conversation

…se-infra#333. This caused the 'Product' band to be loaded, which contains a zip file. eu-cdse/openeo-cdse-infra#333
@EmileSonneveld EmileSonneveld marked this pull request as draft December 13, 2024 09:41
@EmileSonneveld
Copy link
Contributor Author

This is the problematic 'band'

"Product": {
    "href": "https://zipper.dataspace.copernicus.eu/dummy",
    "type": "application/zip",
    "roles": [
        "data",
        "metadata",
        "archive"
    ],
    "title": "Zipped product",
    "alternate": {
        "s3": {
            "href": "s3://eodata/Landsat-9/OLI/L1GT/2022/03/12/LO09_L1GT_137106_20220312_20230424_02_T2.zip",
            "auth:refs": [
                "s3"
            ],
            "description": "S3 storage provided by CloudFerro Cloud and OpenTelekom Cloud (OTC). Use endpoint URL `https://eodata.dataspace.copernicus.eu`.",
            "alternate:name": "S3"
        }
    },
    "auth:refs": [
        "oidc"
    ],
    "alternate:name": "HTTPS",
    "file:local_path": "LO09_L1GT_137106_20220312_20230424_02_T2.zip"
}

Ok band:

"green": {
    "gsd": 30,
    "href": "https://zipper.dataspace.copernicus.eu/dummy",
    "type": "image/tiff; application=geotiff; profile=cloud-optimized",
    "bands": [
        {
            "name": "B3",
            "eo:common_name": "green",
            "eo:center_wavelength": 0.56
        }
    ],
    "roles": [
        "data"
    ],
    "title": "Green Band (B3)",
    "nodata": 0,
    "alternate": {
        "s3": {
            "href": "s3://eodata/Landsat-9/OLI/L1GT/2022/03/12/LO09_L1GT_137106_20220312_20230424_02_T2/LO09_L1GT_137106_20220312_20230424_02_T2_B3.TIF",
            "auth:refs": [
                "s3"
            ],
            "description": "S3 storage provided by CloudFerro Cloud and OpenTelekom Cloud (OTC). Use endpoint URL `https://eodata.dataspace.copernicus.eu`.",
            "alternate:name": "S3"
        }
    },
    "auth:refs": [
        "oidc"
    ],
    "data_type": "uint16",
    "file:size": "93384687",
    "proj:bbox": [
        2273999.8390177847,
        1140299.9150258568,
        2492400.4286099034,
        1360800.362137389
    ],
    "proj:code": "EPSG:3031",
    "proj:shape": [
        7351,
        7281
    ],
    "description": "Collection 2 Level-1 Green Band (B3) Top of Atmosphere Radiance",
    "file:checksum": "d50110d8eb1f3da9361d6ee859c7f72b450c79",
    "alternate:name": "HTTPS",
    "file:local_path": "LO09_L1GT_137106_20220312_20230424_02_T2/LO09_L1GT_137106_20220312_20230424_02_T2_B3.TIF"
}

@EmileSonneveld EmileSonneveld marked this pull request as ready for review December 13, 2024 11:29
Copy link
Collaborator

@bossie bossie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remarks inline.

Needs a test.

@bossie
Copy link
Collaborator

bossie commented Dec 18, 2024

Breaks tests.test_api_result.TestLoadStac.test_load_stac_issue830_alternate_url_s3 but STAC used in test is artificial so just change asset media type to supported one.

@EmileSonneveld EmileSonneveld merged commit 2106cb1 into master Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants