You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following up on #32, now that there are two temperature probes (as there should be since that's what's on the board). Unlike the real probes, which get their data from the same beaker of solution, the mock probes get their temperatures from their own internal variables. It might not be the worst issue, but it's a little odd functionally and may come out with some weird results in test mode.
My proposed solution would be to make some kind of Solution_Model class that would alleviate this. Basically, a "beaker of solution" would be made to connect these probes. This could have use for both the mock and real versions:
Mock:
The Solution_Model acts as the connection point between the temperature probes, getting their temperature reading from it in the same fashion the real one does
Real:
The Solution_Model class could be the common storage location for various components for the titration status:
Whenever acid is dispensed, it writes to the beaker how much was dispensed, which it holds internally in a list
Whenever the temperature is read (real or mock) it writes that temperature to the beaker, which it holds internally in a list
When the weight, salinity, calibration, and other parameters are entered, the beaker holds those values
At the end of the titration, the Solution_Model is used to output all the information into a report/csv.
The purpose being that this information is currently being stored in a local dataFrame object that's being accessed throughout various functions in the titration process. I think it may be slightly easier to work with and cleaner if all of that information was stored elsewhere and tabulated at the end. It may seem similar, but I think it would help take some of the number crunching out of functions that are currently bigger than they need to be.
Thoughts?
The text was updated successfully, but these errors were encountered:
KonradMcClure
changed the title
Mock temperature probes don't communicate
Mock temperature probes don't share temperature
Aug 13, 2021
KonradMcClure
changed the title
Mock temperature probes don't share temperature
Mock temperature probes don't share readings
Aug 13, 2021
Following up on #32, now that there are two temperature probes (as there should be since that's what's on the board). Unlike the real probes, which get their data from the same beaker of solution, the mock probes get their temperatures from their own internal variables. It might not be the worst issue, but it's a little odd functionally and may come out with some weird results in test mode.
My proposed solution would be to make some kind of
Solution_Model
class that would alleviate this. Basically, a "beaker of solution" would be made to connect these probes. This could have use for both the mock and real versions:Mock:
Real:
The purpose being that this information is currently being stored in a local
dataFrame
object that's being accessed throughout various functions in the titration process. I think it may be slightly easier to work with and cleaner if all of that information was stored elsewhere and tabulated at the end. It may seem similar, but I think it would help take some of the number crunching out of functions that are currently bigger than they need to be.Thoughts?
The text was updated successfully, but these errors were encountered: