Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on type change not working #18

Closed
dylanvdmerwe opened this issue May 4, 2022 · 1 comment · Fixed by #20
Closed

on type change not working #18

dylanvdmerwe opened this issue May 4, 2022 · 1 comment · Fixed by #20
Labels
Bug Something isn't working

Comments

@dylanvdmerwe
Copy link

This commit has broken how we use the code and does not appear right. https://github.com/OneSignal/onesignal-ngx/pull/16/files

  1. Documentation is out of date and no longer represents how to use the plugin:
    image

  2. Code using these events no longer works:
    image

@rgomezp rgomezp added the Bug Something isn't working label Jun 7, 2022
@rgomezp
Copy link
Contributor

rgomezp commented Jun 7, 2022

Thank you for opening this issue and your patience. It is indeed a bug. We will try to fix asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants