From 5f071c0728a0611294dac37637e5f81ea257cb0f Mon Sep 17 00:00:00 2001 From: emawby Date: Fri, 9 Apr 2021 11:08:35 -0700 Subject: [PATCH 1/2] no longer using identifierForVendor This means all new installs will result in a new player id. --- iOS_SDK/OneSignalSDK/Source/OSUserState.h | 1 + iOS_SDK/OneSignalSDK/Source/OneSignal.m | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/iOS_SDK/OneSignalSDK/Source/OSUserState.h b/iOS_SDK/OneSignalSDK/Source/OSUserState.h index c27df678b..9951682ae 100644 --- a/iOS_SDK/OneSignalSDK/Source/OSUserState.h +++ b/iOS_SDK/OneSignalSDK/Source/OSUserState.h @@ -33,6 +33,7 @@ THE SOFTWARE. @property (strong, nonatomic, readwrite, nullable) NSString *deviceOs; @property (strong, nonatomic, readwrite, nullable) NSNumber *timezone; @property (strong, nonatomic, readwrite, nullable) NSString *timezoneId; +//This property is no longer being populated with vendor id @property (strong, nonatomic, readwrite, nullable) NSString *adId; @property (strong, nonatomic, readwrite, nullable) NSString *sdk; @property (strong, nonatomic, readwrite, nullable) NSString *sdkType; diff --git a/iOS_SDK/OneSignalSDK/Source/OneSignal.m b/iOS_SDK/OneSignalSDK/Source/OneSignal.m index 3a38d5d31..7162dbc43 100755 --- a/iOS_SDK/OneSignalSDK/Source/OneSignal.m +++ b/iOS_SDK/OneSignalSDK/Source/OneSignal.m @@ -1743,7 +1743,6 @@ + (OSUserState *)createUserState { userState.deviceOs = [[UIDevice currentDevice] systemVersion]; userState.timezone = [NSNumber numberWithInt:(int)[[NSTimeZone localTimeZone] secondsFromGMT]]; userState.timezoneId = [[NSTimeZone localTimeZone] name]; - userState.adId = [[[UIDevice currentDevice] identifierForVendor] UUIDString]; userState.sdk = ONESIGNAL_VERSION; // should be set to true even before the API request is finished From f1c05efaca3b739dcfde71606dfa85c41aa63c31 Mon Sep 17 00:00:00 2001 From: emawby Date: Fri, 9 Apr 2021 15:41:54 -0700 Subject: [PATCH 2/2] removing adid from userstate --- iOS_SDK/OneSignalSDK/Source/OSUserState.h | 2 -- iOS_SDK/OneSignalSDK/Source/OSUserState.m | 1 - 2 files changed, 3 deletions(-) diff --git a/iOS_SDK/OneSignalSDK/Source/OSUserState.h b/iOS_SDK/OneSignalSDK/Source/OSUserState.h index 9951682ae..69fa8bd92 100644 --- a/iOS_SDK/OneSignalSDK/Source/OSUserState.h +++ b/iOS_SDK/OneSignalSDK/Source/OSUserState.h @@ -33,8 +33,6 @@ THE SOFTWARE. @property (strong, nonatomic, readwrite, nullable) NSString *deviceOs; @property (strong, nonatomic, readwrite, nullable) NSNumber *timezone; @property (strong, nonatomic, readwrite, nullable) NSString *timezoneId; -//This property is no longer being populated with vendor id -@property (strong, nonatomic, readwrite, nullable) NSString *adId; @property (strong, nonatomic, readwrite, nullable) NSString *sdk; @property (strong, nonatomic, readwrite, nullable) NSString *sdkType; @property (strong, nonatomic, readwrite, nullable) NSString *externalUserId; diff --git a/iOS_SDK/OneSignalSDK/Source/OSUserState.m b/iOS_SDK/OneSignalSDK/Source/OSUserState.m index 97239c2d8..028d0b68e 100644 --- a/iOS_SDK/OneSignalSDK/Source/OSUserState.m +++ b/iOS_SDK/OneSignalSDK/Source/OSUserState.m @@ -37,7 +37,6 @@ - (NSDictionary*)toDictionary { _deviceOs, @"device_os", _timezone, @"timezone", _timezoneId, @"timezone_id", - _adId, @"ad_id", _sdk, @"sdk", nil];