-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Satya fix teams UI #2736
Satya fix teams UI #2736
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the PR and all the below issues seems to be fixed but there is a slight misalignment in the position of button "Active teams" when the screen size was 400 px or below. I am not sure if this is the expected behavior or needs to be fixed, So, I am not requesting a change.
At 768px and below, the table is not centered and the top two cards lack padding.
At 575px and below, the table starts side-scrolling.
At 479px and below, the cards stack vertically.
Around 400px and below, the members modal’s table cuts off and starts side-scrolling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this function and under the 756 px width, the teams list and members list looks as expected.
bandicam.2024-10-12.00-13-09-985.mp4
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All requested changes have been addressed, and the failing tests are resolved. This PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I've checked this and the UI looks good!
Thank you all, merging! |
Description
This PR addresses the UI issues on the Teams page in the admin/owner profile. These issues are primarily related to table and card layout at various screen sizes:
At 768px and below, the table is not centered and the top two cards lack padding.
At 575px and below, the table starts side-scrolling.
At 479px and below, the cards stack vertically.
Around 400px and below, the members modal’s table cuts off and starts side-scrolling.
Related PRS (if any):
This PR is related to the PR2416 front-end PR.
Main changes explained:
Updated Teams.css to reduce font size at 575px and below.
Adjusted padding for cards at 768px and below.
Reduced card size at 479px to prevent vertical stacking.
Implemented overflow-x adjustments for members modal at 400px and below.
How to test:
Check into the current branch.
Run npm install to update dependencies.
Clear site data/cache.
Log in as an admin user.
Navigate to Dashboard → Teams page.
Verify table alignment, card layout, and responsiveness across 768px, 575px, 479px, and 400px screen sizes.
Ensure that the changes function properly in dark mode.
Screenshots or videos of changes: