Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satya fix teams UI #2736

Merged
merged 4 commits into from
Dec 8, 2024
Merged

Satya fix teams UI #2736

merged 4 commits into from
Dec 8, 2024

Conversation

SatyashanthiT
Copy link
Contributor

Description
This PR addresses the UI issues on the Teams page in the admin/owner profile. These issues are primarily related to table and card layout at various screen sizes:

At 768px and below, the table is not centered and the top two cards lack padding.
At 575px and below, the table starts side-scrolling.
At 479px and below, the cards stack vertically.
Around 400px and below, the members modal’s table cuts off and starts side-scrolling.

Related PRS (if any):
This PR is related to the PR2416 front-end PR.

Main changes explained:
Updated Teams.css to reduce font size at 575px and below.
Adjusted padding for cards at 768px and below.
Reduced card size at 479px to prevent vertical stacking.
Implemented overflow-x adjustments for members modal at 400px and below.

How to test:
Check into the current branch.
Run npm install to update dependencies.
Clear site data/cache.
Log in as an admin user.
Navigate to Dashboard → Teams page.
Verify table alignment, card layout, and responsiveness across 768px, 575px, 479px, and 400px screen sizes.
Ensure that the changes function properly in dark mode.

Screenshots or videos of changes:

center table Has padding - 756 has padding 594 reduced side scrolling no vertical stacking 414px reduced font

Copy link

netlify bot commented Sep 29, 2024

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 369f29c
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/6755f85f0314e30008114ce5
😎 Deploy Preview https://deploy-preview-2736--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@Muzammil603 Muzammil603 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
image
image
image
image
not working as expected

Copy link
Contributor

@ziyanw52 ziyanw52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I have test this PR, and when if it's 427px and below, the cards stack vertically. Please see screenshot as reference.
701727849597_ pic_hd

@SatyashanthiT SatyashanthiT dismissed nikhilgiri0226’s stale review October 5, 2024 02:29

The merge-base changed after approval.

nikhilgiri0226
nikhilgiri0226 previously approved these changes Oct 5, 2024
Copy link
Contributor

@nikhilgiri0226 nikhilgiri0226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the PR and all the below issues seems to be fixed but there is a slight misalignment in the position of button "Active teams" when the screen size was 400 px or below. I am not sure if this is the expected behavior or needs to be fixed, So, I am not requesting a change.

At 768px and below, the table is not centered and the top two cards lack padding.
At 575px and below, the table starts side-scrolling.
At 479px and below, the cards stack vertically.
Around 400px and below, the members modal’s table cuts off and starts side-scrolling.

Screenshot_2736_400px Screenshot_2736_479px Screenshot_2736_575px Screenshot_2736_768px

Jingyii800
Jingyii800 previously approved these changes Oct 12, 2024
Copy link
Contributor

@Jingyii800 Jingyii800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this function and under the 756 px width, the teams list and members list looks as expected.

bandicam.2024-10-12.00-13-09-985.mp4

@SatyashanthiT SatyashanthiT dismissed Jingyii800’s stale review October 12, 2024 07:15

The merge-base changed after approval.

@ShreyaLaheri
Copy link

I have tested this PR - functionality wise everything looks okay. However, there seems to be a little misalignment in elements as we change screen sizes.
image
image

Copy link
Contributor

@SharadhaS24 SharadhaS24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is working as expected in 700px 300px,400px and 500px perfectly . Tested the PR in Safari with both light and dark mode.

image image image image image

SharadhaS24
SharadhaS24 previously approved these changes Oct 24, 2024
Copy link
Contributor

@SharadhaS24 SharadhaS24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is working as expected in 700px 300px,400px and 500px perfectly . Tested the PR in Safari with both light and dark mode.

image image image image

@SatyashanthiT SatyashanthiT dismissed SharadhaS24’s stale review October 24, 2024 19:23

The merge-base changed after approval.

NK3101
NK3101 previously approved these changes Oct 25, 2024
Copy link

@NK3101 NK3101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is working as expected in 700px, 400px and 500px. Tested the PR in both light and dark mode.

Screenshot 2024-10-24 at 11 10 04 PM Screenshot 2024-10-24 at 11 09 31 PM Screenshot 2024-10-24 at 11 05 46 PM

@SatyashanthiT SatyashanthiT dismissed stale reviews from NK3101 and Muhideenthegreat October 25, 2024 03:14

The merge-base changed after approval.

Copy link

@Muhideenthegreat Muhideenthegreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verification:

The UI is much responsive with the various paddings added and works as expected:

Screenshot 2024-10-26 at 5 56 18 PM Screenshot 2024-10-26 at 5 56 57 PM Screenshot 2024-10-26 at 5 57 39 PM

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Dec 3, 2024
@SatyashanthiT
Copy link
Contributor Author

All requested changes have been addressed, and the failing tests are resolved. This PR is ready for review.

Copy link
Contributor

@ziyanw52 ziyanw52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I've checked this and the UI looks good!

@one-community
Copy link
Member

Thank you all, merging!

@one-community one-community merged commit 9ad50b4 into development Dec 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.