-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Razor VSCode 5.0 Preview 3 #3696
Razor VSCode 5.0 Preview 3 #3696
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3696 +/- ##
=======================================
Coverage 87.32% 87.32%
=======================================
Files 59 59
Lines 1767 1767
Branches 206 206
=======================================
Hits 1543 1543
Misses 169 169
Partials 55 55
Continue to review full report at Codecov.
|
Co-Authored-By: Joey Robichaud <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super solid broseph 👌
Travis-CI check still shows in progress on the PR, but seems to have gone through already on the Travis-CI end: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Travis-CI check seems to be passing but the github check isn't getting updated: Could this be manually pushed through? |
Hmm @JoeRobich the Travis build is succeeding but it doesn't look to be reporting to GitHub properly. |
<text>
tag completions.razor.trace
level.Covers: https://github.com/dotnet/aspnetcore/milestone/97?closed=1
@NTaylorMullen @ryanbrandenburg @ajaybhargavb Please look over the changelog / test-plan to ensure I didn't miss anything or if I can word something better.