Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Razor VSCode 5.0 Preview 3 #3696

Merged

Conversation

TanayParikh
Copy link
Contributor

@TanayParikh TanayParikh commented Mar 27, 2020

  • Razor support for <text> tag completions.
  • Ability to restart the Razor Language Server to activate changes to the razor.trace level.
  • Bug fixes and performance improvements.

Covers: https://github.com/dotnet/aspnetcore/milestone/97?closed=1

@NTaylorMullen @ryanbrandenburg @ajaybhargavb Please look over the changelog / test-plan to ensure I didn't miss anything or if I can word something better.

@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #3696 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3696   +/-   ##
=======================================
  Coverage   87.32%   87.32%           
=======================================
  Files          59       59           
  Lines        1767     1767           
  Branches      206      206           
=======================================
  Hits         1543     1543           
  Misses        169      169           
  Partials       55       55           
Flag Coverage Δ
#integration 100.00% <ø> (ø)
#unit 87.32% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3df235d...617be31. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@NTaylorMullen NTaylorMullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super solid broseph 👌

@TanayParikh
Copy link
Contributor Author

Travis-CI check still shows in progress on the PR, but seems to have gone through already on the Travis-CI end:

https://travis-ci.org/github/OmniSharp/omnisharp-vscode/jobs/667905947?utm_medium=notification&utm_source=github_status

@TanayParikh TanayParikh reopened this Mar 30, 2020
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TanayParikh
Copy link
Contributor Author

Travis-CI check seems to be passing but the github check isn't getting updated:
https://travis-ci.org/github/OmniSharp/omnisharp-vscode/builds/668850141?utm_medium=notification&utm_source=github_status

Could this be manually pushed through?

@NTaylorMullen
Copy link
Contributor

Hmm @JoeRobich the Travis build is succeeding but it doesn't look to be reporting to GitHub properly.

@TanayParikh TanayParikh reopened this Mar 30, 2020
@NTaylorMullen NTaylorMullen merged commit 91d97b2 into dotnet:master Mar 30, 2020
@TanayParikh TanayParikh deleted the vscode-razor-preview-3-release branch March 30, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants