Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add csharp.supressBuildAssetsNotification setting to allow the 'Required assets to build and debug' notifications to be supressed #3538

Merged
merged 2 commits into from
Jan 30, 2020

Conversation

seesharprun
Copy link

I regularly teach classes around using the .NET CLI and this setting is pretty obtrusive.

image

I have students run dotnet build and dotnet run manually so I reguarly get asked if there is a way to suppress this notification.

I'll share an example:

  • I'm teaching a class on how to create a new project using the CLI and build it
  • Open an empty folder
  • Run dotnet new console
  • Open the folder in Visual Studio Code
  • The prompt will show up. We are not ready to do a build yet. We can dismiss the notification for this project, but not for future folders

This PR proposes to fix this issue by adding a new setting.

@dnfclas
Copy link

dnfclas commented Jan 30, 2020

CLA assistant check
All CLA requirements met.

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #3538 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3538   +/-   ##
======================================
  Coverage    89.8%   89.8%           
======================================
  Files          59      59           
  Lines        1589    1589           
  Branches       89      89           
======================================
  Hits         1427    1427           
- Misses        150     151    +1     
+ Partials       12      11    -1
Flag Coverage Δ
#integration ?
#unit 89.8% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/packageManager/FileDownloader.ts 91.3% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c1668...d9f133d. Read the comment docs.

Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seesharprun! Lots of people will be happy to have this setting. =)

@JoeRobich JoeRobich merged commit 6b97ec9 into dotnet:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants