Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'envFile' launch.json option on Windows #2560

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

gregg-miskelly
Copy link
Contributor

@gregg-miskelly gregg-miskelly commented Sep 28, 2018

The 'workspaceFolder' subsitution logic was wrong for 'envFile', which broke the feature on Windows. This fixes it.

This fixes #2512

The 'workspaceFolder' subsitution logic was wrong for 'envFile', which broke the feature on Windows. This fixes it.
@codecov
Copy link

codecov bot commented Sep 28, 2018

Codecov Report

Merging #2560 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2560      +/-   ##
==========================================
+ Coverage   65.04%   65.09%   +0.04%     
==========================================
  Files          97       97              
  Lines        4226     4226              
  Branches      605      605              
==========================================
+ Hits         2749     2751       +2     
+ Misses       1304     1303       -1     
+ Partials      173      172       -1
Flag Coverage Δ
#integration 52.92% <0%> (+0.04%) ⬆️
#unit 84.76% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/configurationProvider.ts 21.42% <0%> (ø) ⬆️
src/omnisharp/delayTracker.ts 73.68% <0%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d711ff...15e6517. Read the comment docs.

@gregg-miskelly gregg-miskelly merged commit 6c6c4c9 into dotnet:master Sep 28, 2018
@gregg-miskelly gregg-miskelly deleted the DbgEnvFileOnWin branch September 28, 2018 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot load envFile on windows
2 participants