Can't build plugin from source

[jlsiewert]

Description

I tried to build the package from source. However, rollup warns about a circular dependency:

node_modules/glob/glob.js -> node_modules/glob/sync.js -> node_modules/glob/glob.js
node_modules/glob/glob.js -> node_modules/glob/sync.js -> node_modules/glob/glob.js?commonjs-proxy -> node_modules/glob/glob.js

The resulting main.js is 897 KB in size (compared to 1.33 MB in the released version).
Loading the plugin in obsidian fails:

Plugin failure: obsidian-pandoc-fixes TypeError: Cannot read property 'Glob' of undefined

Steps to Reproduce

To exclude some issues on main machine I tried to build the package in the node:lates docker image.

$ docker run -it --rm node:latest /bin/sh

# git clone https://github.com/OliverBalfour/obsidian-pandoc

# cd obsidian-pandoc

# npm i
added 47 packages, and audited 48 packages in 7s

# npm run-script build
> [email protected] build
> rollup --config rollup.config.js --environment BUILD:production


main.ts → ....
(!) Unresolved dependencies
https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency
fs (imported by main.ts, renderer.ts, pandoc.ts, global.ts, node_modules/lookpath/lib/index.js, node_modules/temp/lib/temp.js, node_modules/rimraf/rimraf.js, node_modules/mkdirp/index.js, node_modules/glob/common.js, fs?commonjs-external, node_modules/fs.realpath/index.js, node_modules/fs.realpath/old.js)
path (imported by renderer.ts, main.ts, pandoc.ts, node_modules/lookpath/lib/index.js, node_modules/temp/lib/temp.js, node_modules/rimraf/rimraf.js, node_modules/mkdirp/index.js, node_modules/glob/glob.js, node_modules/glob/sync.js, node_modules/glob/common.js, path?commonjs-external, node_modules/minimatch/minimatch.js, node_modules/fs.realpath/old.js)
child_process (imported by pandoc.ts)
os (imported by node_modules/temp/lib/temp.js, os?commonjs-external)
constants (imported by node_modules/temp/lib/temp.js, constants?commonjs-external)
assert (imported by node_modules/rimraf/rimraf.js, node_modules/glob/glob.js, node_modules/glob/sync.js, assert?commonjs-external)
util (imported by node_modules/glob/sync.js, node_modules/glob/glob.js, node_modules/inherits/inherits.js, util?commonjs-external)
events (imported by node_modules/glob/glob.js, events?commonjs-external)
(!) Circular dependencies
node_modules/glob/glob.js -> node_modules/glob/sync.js -> node_modules/glob/glob.js
node_modules/glob/glob.js -> node_modules/glob/sync.js -> /obsidian-pandoc/node_modules/glob/glob.js?commonjs-proxy -> node_modules/glob/glob.js
created . in 2.7s

# ls main.js
-rw-r--r--  1 root root 896252 Oct 22 13:26 main.js

Any ideas on how to resolve this?

[kometenstaub]

You can build it with esbuild, that doesn't have this issue. It doesn't seem to be a real circular dependency (only an unused import), but rollup can't resolve it properly.

isaacs/node-glob#365, isaacs/node-glob#374

[OliverBalfour]

Fixed by #140