Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add modules required #17

Closed
PululuK opened this issue Mar 30, 2021 · 5 comments · Fixed by #18
Closed

Add modules required #17

PululuK opened this issue Mar 30, 2021 · 5 comments · Fixed by #18

Comments

@PululuK
Copy link
Contributor

PululuK commented Mar 30, 2021

During installation I have some errors, because some required modules is missing.

  • is_imageslider
  • is_searchbar
  • is_shoppingcart
  • is_themecore

We nee to alert people in requirements doc.
@PululuK PululuK mentioned this issue Mar 30, 2021
Merged
@Oksydan
Copy link
Owner

Oksydan commented Mar 31, 2021

Hi,
package from releases contains these modules.

@PululuK
Copy link
Contributor Author

PululuK commented Mar 31, 2021

Hi,
package from releases contains these modules.

Hi @Oksydan
Yes ... but it missing in manual install process !

@Oksydan
Copy link
Owner

Oksydan commented Mar 31, 2021

@PululuK
Yes, you are right. Could you make pull request on develop branch? I will update contribution guide later.

@PululuK
Copy link
Contributor Author

PululuK commented Mar 31, 2021

Yep !
I just rebase my PR #18

@Oksydan
Copy link
Owner

Oksydan commented Mar 31, 2021

@PululuK
The changes have been merged. Thank you again.

@Oksydan Oksydan closed this as completed Mar 31, 2021
@ePiliK ePiliK mentioned this issue Jan 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Modules required PululuK/modern-prestashop-starter-theme
2 participants
@PululuK @Oksydan