refactor: show warning if API contains optional params only #9843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yuqizhou77
commented
Sep 5, 2023
•
yuqizhou77
commented
- show warning if API contains optional params only that we won't generate parameters for the command.
refactor: msg refactor: telemetry refactor: test
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #9843 +/- ##
=======================================
Coverage 85.51% 85.52%
=======================================
Files 440 440
Lines 25212 25222 +10
Branches 4808 4808
=======================================
+ Hits 21560 21570 +10
+ Misses 1931 1930 -1
- Partials 1721 1722 +1
|
yuqizhou77
requested review from
nliu-ms,
Alive-Fish,
jayzhang,
timngmsft,
sffamily and
therealjohn
as code owners
Alive-Fish
previously approved these changes
Sep 5, 2023
nliu-ms
previously approved these changes
Sep 5, 2023
nliu-ms
previously approved these changes
Sep 5, 2023
nliu-ms
previously approved these changes
Sep 6, 2023
sffamily
reviewed
Sep 6, 2023
| @@ -254,6 +254,8 @@ | |||
| "core.copilotPlugin.scaffold.summary.warning.teamsManifest.mitigation": "Mitigation: update \"%s\" field in \"%s\".", | |||
| "core.copilotPlugin.scaffold.summary.warning.teamsManifest.missingCardTemlate": "Missing \"%s\" in command \"%s\".", | |||
| "core.copilotPlugin.scaffold.summary.warning.teamsManifest.missingCardTemlate.mitigation": " Mitigation: create Adaptive Card template in \"%s\" and then update \"%s\" field to the relative path in \"%s\".", | |||
| "core.copilotPlugin.scaffold.summary.warning.teamsManifest.missingCommandParameters": "Missing parameters in command \"%s\" as we cannot find any required parameter.", | |||
There was a problem hiding this comment.
as we cannot find any required parameter. -> consider to remove? duplicated with the wording before it.
| @@ -254,6 +254,8 @@ | |||
| "core.copilotPlugin.scaffold.summary.warning.teamsManifest.mitigation": "Mitigation: update \"%s\" field in \"%s\".", | |||
| "core.copilotPlugin.scaffold.summary.warning.teamsManifest.missingCardTemlate": "Missing \"%s\" in command \"%s\".", | |||
| "core.copilotPlugin.scaffold.summary.warning.teamsManifest.missingCardTemlate.mitigation": " Mitigation: create Adaptive Card template in \"%s\" and then update \"%s\" field to the relative path in \"%s\".", | |||
| "core.copilotPlugin.scaffold.summary.warning.teamsManifest.missingCommandParameters": "Missing parameters in command \"%s\" as we cannot find any required parameter.", | |||
| "core.copilotPlugin.scaffold.summary.warning.teamsManifest.missingCommandParameters.mitigation": " Mitigation: add at least one parameter for command \"%s\" in \"%s\". The parameter name should match what defined in \"%s\".", | |||
There was a problem hiding this comment.
what defined -> what's defined
Alive-Fish
approved these changes
Sep 6, 2023
sffamily
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.