Skip to content

Commit

Permalink
fix(react-examples): Change item names to match icon in OverflowSet e…
Browse files Browse the repository at this point in the history
…xample (#16494)

#### Pull request checklist

- [x] Addresses an existing issue: Fixes microsoftdesign/fluentui#10282
- [x] Include a change request file using `$ yarn change`: No change files are needed

#### Description of changes

Add descriptive names for the icons used in the OverflowSet Vertical example.
Removed unused `icon` props for the `overflowItems`
  • Loading branch information
andrefcdias authored Jan 19, 2021
1 parent 1ed476d commit dadc7e0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -45,33 +45,31 @@ export const OverflowSetVerticalExample: React.FunctionComponent = () => (
{
key: 'item1',
icon: 'Add',
name: 'Link 1',
name: 'Add',
ariaLabel: 'New. Use left and right arrow keys to navigate',
onClick: noOp,
},
{
key: 'item2',
icon: 'Upload',
name: 'Link 2',
name: 'Upload',
onClick: noOp,
},
{
key: 'item3',
icon: 'Share',
name: 'Link 3',
name: 'Share',
onClick: noOp,
},
]}
overflowItems={[
{
key: 'item4',
icon: 'Mail',
name: 'Overflow Link 1',
onClick: noOp,
},
{
key: 'item5',
icon: 'Calendar',
name: 'Overflow Link 2',
onClick: noOp,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ exports[`Component Examples renders OverflowSet.Vertical.Example.tsx correctly 1
}
>
<button
aria-label="Link 1"
aria-label="Add"
className=
ms-Button
ms-Button--commandBar
Expand Down Expand Up @@ -176,7 +176,7 @@ exports[`Component Examples renders OverflowSet.Vertical.Example.tsx correctly 1
}
>
<button
aria-label="Link 2"
aria-label="Upload"
className=
ms-Button
ms-Button--commandBar
Expand Down Expand Up @@ -329,7 +329,7 @@ exports[`Component Examples renders OverflowSet.Vertical.Example.tsx correctly 1
}
>
<button
aria-label="Link 3"
aria-label="Share"
className=
ms-Button
ms-Button--commandBar
Expand Down

0 comments on commit dadc7e0

Please sign in to comment.