-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with AppContainer Loopback Logic in office-addin-debugging
and office-addin-dev-settings
#840
Comments
More thoughts on this: Since the |
I'm not working in this space now, so Darren can investigate. It may be that the webview2 code allows the localhost loopback when debugging or this was allowed in a mechanism which CheckNetIsolation doesn't report. Certainly there are different flavors and ways of installing webview2, as you mention the different app ids. |
I make a PR with simple change to keep behavior the same when user type Some other investigation I found: I found the following docs:
In the first doc, it said that for Legacy Edge, it need the loopback exemption, but for Webview 2 it doesn't need so. Maybe this is the kernel cause of all my above issues. |
Thanks for reporting this issue. After careful consideration, our team has decided to not fix this issue in the short term due to the amount of effort needed for this and the fact that the PR you created provides a workaround for this as well. If we end up working on this issue we will re-activate as needed. |
Hi all, I recently found some issues/strange behavior with the loopback logic.
Background
I know that AppContainer tech make some Apps likes UWP can't access localhost (loopback) by default.
In previously, I think Webview2 && Edge need that loopback exempt for Add-in side-load.
But some test I did recently shows that things may be different.
Tools I used:
CheckNetIsolation.exe
Issue 1: Type
No
during Loopback question promptCode in
office-addin-debugging
dosen't use the result fromensureLoopbackIsEnabled
:So, when
ensureLoopbackIsEnabled
detect that loopback is not exempted and user typeNo
, the logic inoffice-addin-debugging
will carried on the following steps (start the dev server and side load the add-in).Then the things get interested:
No
during loopback question askedThese result shows that maybe the Loopback exempt is no needed for user to side load the add-in.
Issue 2: Edge App Container Name
In this code file, we can see the Edge Browser App Container Name (AC Name):
However, on my new Win11 23H2 machine, I don't have Edge that with AC Name, instead I have a Edge with AC Name of
Microsoft.MicrosoftEdge.Stable_8wekyb3d8bbwe
:But in my two other machine (one is Win11 which upgrade from Win10, another is Win10), they both have two Edge App Container and one is
Microsoft.MicrosoftEdge_8wekyb3d8bbwe
another isMicrosoft.MicrosoftEdge.Stable_8wekyb3d8bbwe
Issue 3: The way to check whether Edge Browser have Loopback exempt maybe wrong
This code shows that how to check the app have the exempt:
But I did some test here:
We can see that for
EdgeWebViewAppcontainerName
, this way works. But forEdgeBrowserAppcontainerName
this way not work. ThoughMicrosoft.MicrosoftEdge_8wekyb3d8bbwe
already have exempt but.\CheckNetIsolation.exe LoopbackExempt -s
will not list it.Issue 4: Only Add Edge Browser to loopback Exempt maybe not correct.
When sideload in web, this code show that
open
is used for open the sideload link.But
open
seems to open link with system default browser, which may not be Edge.So only exempt Edge Browser maybe not correct. But accroding to above information, maybe exempt browser is not needed.
The text was updated successfully, but these errors were encountered: