Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Suggestion] Show cost of deployment in Eth #72

Closed
srinjoyc opened this issue Aug 13, 2024 · 0 comments · Fixed by #80
Closed

[Feature Suggestion] Show cost of deployment in Eth #72

srinjoyc opened this issue Aug 13, 2024 · 0 comments · Fixed by #80

Comments

@srinjoyc
Copy link
Contributor

srinjoyc commented Aug 13, 2024

Problem

Currently, when you run cargo stylus deploy --estimate-gas --private-key $PVT_KEY, the last log shows deploy gas estimate: 30989288 gas. While this is useful, the user would have to take additional steps and time to know if they have sufficient funds for deployment / get the actual cost of deployment.

Proposed Solution

It would be very convenient to have this displayed alongside an estimated_gas_fee (similar to how Metamask shows you the fee costs directly when estimating gas). If there was some additional log output that could fetch the current gas price and display an estimated amount in ETH, it makes it easy for the user to determine if they would like to deploy under current network conditions.

Benefits

Saves the user some steps/time, gives them confidence in the costs, and prevents users from having a poor experience if there is a spike in gas prices prior to deployment which may result in failed deployments, lost fees, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant