Add build information push error handling #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Release-As: 3.4.1
hnrkndrssn
requested changes
Oct 2, 2024
| await new BuildInformationRepository(client, space.Name).push(buildInformation); | ||
| await new BuildInformationRepository(client, space.Name).push(buildInformation); | ||
| } catch (error) { | ||
| expect(error).toBeDefined(); |
There was a problem hiding this comment.
Can we also add a check for the error message returned (similar to what we do in the package repository)
hnrkndrssn
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no error in the build logs when a user was trying to push build info from ADO to Octopus which failed as they did not have the correct permissions.
This PR includes code to throw an error when the build information push fails.
The following error will be thrown when the user does not have the correct permissions: