Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update to node 20 #168

Merged
merged 4 commits into from
Dec 13, 2023
Merged

feat: Update to node 20 #168

merged 4 commits into from
Dec 13, 2023

Conversation

geofflamrock
Copy link
Contributor

@geofflamrock geofflamrock commented Dec 12, 2023

Node 16 is EOL, and 20 is now the new LTS version.

This PR updates to node 20, this includes the @types/node package and GitHub workflows. I don't believe there should need to be any further changes assuming a green build.

At the moment we don't mention in the readme, nor enforce which version(s) of node we support, this is something we could consider adding in the future.

@geofflamrock geofflamrock marked this pull request as ready for review December 13, 2023 01:55
Copy link
Contributor

@stevencl840 stevencl840 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sound

@geofflamrock geofflamrock merged commit 618afa7 into main Dec 13, 2023
4 checks passed
@geofflamrock geofflamrock deleted the geoffl/node-20 branch December 13, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants