Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly compare versions #158

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

tmercswims
Copy link
Contributor

Uses semver's lt() function to compare version strings, rather than <.

Fixes #157.

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2023

CLA assistant check
All committers have signed the CLA.

@tmercswims
Copy link
Contributor Author

tmercswims commented Mar 8, 2023

Is there anyone who can take a look at this change? I'd love to get it in and propagated so that I can use new things against my Octopus instance 🙂

I also feel compelled to apologize for how the tone of the issue I filed could be taken, I didn't mean for it to come across as explaining-how-something-works-to-the-people-who-made-it - I was very occupied with the investigation that I did and keeping everything straight for myself, which is why the explanation is so long 😅 Apologies if it was taken that way, no offense meant.

@jbristowe
Copy link
Contributor

jbristowe commented Mar 20, 2023

Hey @tmercswims! My apologies. I missed this. Looking now.

No need to apologise. Your issue description (explanation) is EXCELLENT. Thank you for taking the time to write this up. It helped me understand the issue immediately.

@jbristowe jbristowe force-pushed the 157-version-comparison branch from fffcc06 to ecd057a Compare March 20, 2023 23:55
@rory-hughes-cko
Copy link

Is it possible for someone to give this PR a review?

Copy link
Contributor

@benPearce1 benPearce1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally

@benPearce1 benPearce1 merged commit e604b86 into OctopusDeploy:main Apr 18, 2023
@tmercswims tmercswims deleted the 157-version-comparison branch April 20, 2023 01:37
@octoreleasebot
Copy link

PR did not have successful (green) build statuses, as required by our PRGB policy.

Justification provided by robert.erez (@zentron) was:

Merged before PRGB defaults were added to the repository. All looks fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SemVer comparison is done incorrectly
6 participants