-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Get data #68
Comments
Also see if we can use one environment for everything:
|
Is someone working on this? If not, I can try to help. virtualship/src/virtualship/cli/commands.py Lines 48 to 50 in 6f843e9
Let me know your thoughts. |
I'm happy to work on this as well
I think that would be good, but perhaps instead of in the config maybe we can have it as arguments to the @ammedd, in terms of data fetching is the EDIT: Hmm, also the question of time domain then. Perhaps it would just be easiest to add spatial and temporal domain to the schedule config file |
Yes, I lean more towards adding this to the config file. For example, if we have an experiment that relies only on drifters, the study area and time range will probably be considerably larger than the schedule. If you haven't started working on this, I can initiate a PR and we can collaborate from there. What do you think? |
@iuryt Sounds good! Happy for you to do a PR and I can jump in in review |
The download_data is all I used before. It was based on an area of interest based on the sampling stations, but indeed, it would be nice to extend this a bit. And in case of Argo/drifter deployment It downloaded a separate dataset that had an area 3degrees more on each side to allow for 3 additional weeks of data from the deployed instruments. |
virtualship fetch
: Downloads the data needed for the simulation as an explicit step so that users can do it separately. Ifvirtualship
is ran without this, then it will go and fetch this data.The text was updated successfully, but these errors were encountered: